HBASE-26690 Modify FSTableDescriptors to not rely on renaming when writing TableDescriptor (#4054)
Signed-off-by: Wellington Ramos Chevreuil <wchevreuil@apache.org>
This commit is contained in:
Duo Zhang
Andrew Purtell
parent
46c10f78ff
commit
f0e1bc81f9
|
|
@ -191,7 +191,7 @@ public class CompactionTool extends Configured implements Tool {
|
|||
}
|
||||
|
||||
private static boolean isTableDir(final FileSystem fs, final Path path) throws IOException {
|
||||
return FSTableDescriptors.getTableInfoPath(fs, path) != null;
|
||||
return FSTableDescriptors.isTableDir(fs, path);
|
||||
}
|
||||
|
||||
private static boolean isFamilyDir(final FileSystem fs, final Path path) throws IOException {
|
||||
|
|
|
|||
|
|
@ -17,19 +17,22 @@
|
|||
*/
|
||||
package org.apache.hadoop.hbase.util;
|
||||
|
||||
import com.google.errorprone.annotations.RestrictedApi;
|
||||
import edu.umd.cs.findbugs.annotations.Nullable;
|
||||
import java.io.EOFException;
|
||||
import java.io.IOException;
|
||||
import java.util.Arrays;
|
||||
import java.util.Comparator;
|
||||
import java.util.List;
|
||||
import java.util.Map;
|
||||
import java.util.Optional;
|
||||
import java.util.TreeMap;
|
||||
import java.util.concurrent.ConcurrentHashMap;
|
||||
import java.util.regex.Matcher;
|
||||
import java.util.regex.Pattern;
|
||||
import org.apache.commons.lang3.NotImplementedException;
|
||||
import org.apache.hadoop.conf.Configuration;
|
||||
import org.apache.hadoop.fs.FSDataInputStream;
|
||||
import org.apache.hadoop.fs.FSDataOutputStream;
|
||||
import org.apache.hadoop.fs.FileAlreadyExistsException;
|
||||
import org.apache.hadoop.fs.FileStatus;
|
||||
import org.apache.hadoop.fs.FileSystem;
|
||||
import org.apache.hadoop.fs.Path;
|
||||
|
|
@ -37,7 +40,6 @@ import org.apache.hadoop.fs.PathFilter;
|
|||
import org.apache.hadoop.hbase.Coprocessor;
|
||||
import org.apache.hadoop.hbase.HConstants;
|
||||
import org.apache.hadoop.hbase.TableDescriptors;
|
||||
import org.apache.hadoop.hbase.TableInfoMissingException;
|
||||
import org.apache.hadoop.hbase.TableName;
|
||||
import org.apache.hadoop.hbase.client.ColumnFamilyDescriptor;
|
||||
import org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder;
|
||||
|
|
@ -88,8 +90,8 @@ public class FSTableDescriptors implements TableDescriptors {
|
|||
* The file name prefix used to store HTD in HDFS
|
||||
*/
|
||||
static final String TABLEINFO_FILE_PREFIX = ".tableinfo";
|
||||
static final String TABLEINFO_DIR = ".tabledesc";
|
||||
static final String TMP_DIR = ".tmp";
|
||||
|
||||
public static final String TABLEINFO_DIR = ".tabledesc";
|
||||
|
||||
// This cache does not age out the old stuff. Thinking is that the amount
|
||||
// of data we keep up in here is so small, no need to do occasional purge.
|
||||
|
|
@ -124,23 +126,23 @@ public class FSTableDescriptors implements TableDescriptors {
|
|||
public static TableDescriptor tryUpdateAndGetMetaTableDescriptor(Configuration conf,
|
||||
FileSystem fs, Path rootdir) throws IOException {
|
||||
// see if we already have meta descriptor on fs. Write one if not.
|
||||
try {
|
||||
return getTableDescriptorFromFs(fs, rootdir, TableName.META_TABLE_NAME);
|
||||
} catch (TableInfoMissingException e) {
|
||||
Optional<Pair<FileStatus, TableDescriptor>> opt = getTableDescriptorFromFs(fs,
|
||||
CommonFSUtils.getTableDir(rootdir, TableName.META_TABLE_NAME), false);
|
||||
if (opt.isPresent()) {
|
||||
return opt.get().getSecond();
|
||||
}
|
||||
TableDescriptorBuilder builder = createMetaTableDescriptorBuilder(conf);
|
||||
TableDescriptor td = StoreFileTrackerFactory.
|
||||
updateWithTrackerConfigs(conf, builder.build());
|
||||
TableDescriptor td = StoreFileTrackerFactory.updateWithTrackerConfigs(conf, builder.build());
|
||||
LOG.info("Creating new hbase:meta table descriptor {}", td);
|
||||
TableName tableName = td.getTableName();
|
||||
Path tableDir = CommonFSUtils.getTableDir(rootdir, tableName);
|
||||
Path p = writeTableDescriptor(fs, td, tableDir, getTableInfoPath(fs, tableDir, true));
|
||||
Path p = writeTableDescriptor(fs, td, tableDir, null);
|
||||
if (p == null) {
|
||||
throw new IOException("Failed update hbase:meta table descriptor");
|
||||
}
|
||||
LOG.info("Updated hbase:meta table descriptor to {}", p);
|
||||
return td;
|
||||
}
|
||||
}
|
||||
|
||||
public static ColumnFamilyDescriptor getTableFamilyDescForMeta(
|
||||
final Configuration conf) {
|
||||
|
|
@ -220,10 +222,9 @@ public class FSTableDescriptors implements TableDescriptors {
|
|||
}
|
||||
TableDescriptor tdmt = null;
|
||||
try {
|
||||
tdmt = getTableDescriptorFromFs(fs, rootdir, tableName);
|
||||
} catch (TableInfoMissingException e) {
|
||||
// ignore. This is regular operation
|
||||
} catch (NullPointerException | IOException ioe) {
|
||||
tdmt = getTableDescriptorFromFs(fs, getTableDir(tableName), fsreadonly).map(Pair::getSecond)
|
||||
.orElse(null);
|
||||
} catch (IOException ioe) {
|
||||
LOG.debug("Exception during readTableDecriptor. Current table name = " + tableName, ioe);
|
||||
}
|
||||
// last HTD written wins
|
||||
|
|
@ -297,10 +298,13 @@ public class FSTableDescriptors implements TableDescriptors {
|
|||
}
|
||||
}
|
||||
|
||||
@RestrictedApi(explanation = "Should only be called in tests or self", link = "",
|
||||
allowedOnPath = ".*/src/test/.*|.*/FSTableDescriptors\\.java")
|
||||
Path updateTableDescriptor(TableDescriptor td) throws IOException {
|
||||
TableName tableName = td.getTableName();
|
||||
Path tableDir = getTableDir(tableName);
|
||||
Path p = writeTableDescriptor(fs, td, tableDir, getTableInfoPath(tableDir));
|
||||
Path p = writeTableDescriptor(fs, td, tableDir,
|
||||
getTableDescriptorFromFs(fs, tableDir, fsreadonly).map(Pair::getFirst).orElse(null));
|
||||
if (p == null) {
|
||||
throw new IOException("Failed update");
|
||||
}
|
||||
|
|
@ -328,80 +332,11 @@ public class FSTableDescriptors implements TableDescriptors {
|
|||
return descriptor;
|
||||
}
|
||||
|
||||
private FileStatus getTableInfoPath(Path tableDir) throws IOException {
|
||||
return getTableInfoPath(fs, tableDir, !fsreadonly);
|
||||
}
|
||||
|
||||
/**
|
||||
* Find the most current table info file for the table located in the given table directory.
|
||||
*
|
||||
* Looks within the {@link #TABLEINFO_DIR} subdirectory of the given directory for any table info
|
||||
* files and takes the 'current' one - meaning the one with the highest sequence number if present
|
||||
* or no sequence number at all if none exist (for backward compatibility from before there
|
||||
* were sequence numbers).
|
||||
*
|
||||
* @return The file status of the current table info file or null if it does not exist
|
||||
* Check whether we have a valid TableDescriptor.
|
||||
*/
|
||||
public static FileStatus getTableInfoPath(FileSystem fs, Path tableDir)
|
||||
throws IOException {
|
||||
return getTableInfoPath(fs, tableDir, false);
|
||||
}
|
||||
|
||||
/**
|
||||
* Find the most current table info file for the table in the given table directory.
|
||||
*
|
||||
* Looks within the {@link #TABLEINFO_DIR} subdirectory of the given directory for any table info
|
||||
* files and takes the 'current' one - meaning the one with the highest sequence number if
|
||||
* present or no sequence number at all if none exist (for backward compatibility from before
|
||||
* there were sequence numbers).
|
||||
* If there are multiple table info files found and removeOldFiles is true it also deletes the
|
||||
* older files.
|
||||
*
|
||||
* @return The file status of the current table info file or null if none exist
|
||||
*/
|
||||
private static FileStatus getTableInfoPath(FileSystem fs, Path tableDir, boolean removeOldFiles)
|
||||
throws IOException {
|
||||
Path tableInfoDir = new Path(tableDir, TABLEINFO_DIR);
|
||||
return getCurrentTableInfoStatus(fs, tableInfoDir, removeOldFiles);
|
||||
}
|
||||
|
||||
/**
|
||||
* Find the most current table info file in the given directory
|
||||
* <p/>
|
||||
* Looks within the given directory for any table info files and takes the 'current' one - meaning
|
||||
* the one with the highest sequence number if present or no sequence number at all if none exist
|
||||
* (for backward compatibility from before there were sequence numbers).
|
||||
* <p/>
|
||||
* If there are multiple possible files found and the we're not in read only mode it also deletes
|
||||
* the older files.
|
||||
* @return The file status of the current table info file or null if it does not exist
|
||||
*/
|
||||
private static FileStatus getCurrentTableInfoStatus(FileSystem fs, Path dir,
|
||||
boolean removeOldFiles) throws IOException {
|
||||
FileStatus[] status = CommonFSUtils.listStatus(fs, dir, TABLEINFO_PATHFILTER);
|
||||
if (status == null || status.length < 1) {
|
||||
return null;
|
||||
}
|
||||
FileStatus mostCurrent = null;
|
||||
for (FileStatus file : status) {
|
||||
if (mostCurrent == null || TABLEINFO_FILESTATUS_COMPARATOR.compare(file, mostCurrent) < 0) {
|
||||
mostCurrent = file;
|
||||
}
|
||||
}
|
||||
if (removeOldFiles && status.length > 1) {
|
||||
// Clean away old versions
|
||||
for (FileStatus file : status) {
|
||||
Path path = file.getPath();
|
||||
if (!file.equals(mostCurrent)) {
|
||||
if (!fs.delete(file.getPath(), false)) {
|
||||
LOG.warn("Failed cleanup of " + path);
|
||||
} else {
|
||||
LOG.debug("Cleaned up old tableinfo file " + path);
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
return mostCurrent;
|
||||
public static boolean isTableDir(FileSystem fs, Path tableDir) throws IOException {
|
||||
return getTableDescriptorFromFs(fs, tableDir, true).isPresent();
|
||||
}
|
||||
|
||||
/**
|
||||
|
|
@ -411,14 +346,14 @@ public class FSTableDescriptors implements TableDescriptors {
|
|||
new Comparator<FileStatus>() {
|
||||
@Override
|
||||
public int compare(FileStatus left, FileStatus right) {
|
||||
return right.compareTo(left);
|
||||
return right.getPath().getName().compareTo(left.getPath().getName());
|
||||
}
|
||||
};
|
||||
|
||||
/**
|
||||
* Return the table directory in HDFS
|
||||
*/
|
||||
Path getTableDir(final TableName tableName) {
|
||||
private Path getTableDir(TableName tableName) {
|
||||
return CommonFSUtils.getTableDir(rootdir, tableName);
|
||||
}
|
||||
|
||||
|
|
@ -449,39 +384,53 @@ public class FSTableDescriptors implements TableDescriptors {
|
|||
return Bytes.toString(b);
|
||||
}
|
||||
|
||||
/**
|
||||
* Regex to eat up sequenceid suffix on a .tableinfo file.
|
||||
* Use regex because may encounter oldstyle .tableinfos where there is no
|
||||
* sequenceid on the end.
|
||||
*/
|
||||
private static final Pattern TABLEINFO_FILE_REGEX =
|
||||
Pattern.compile(TABLEINFO_FILE_PREFIX + "(\\.([0-9]{" + WIDTH_OF_SEQUENCE_ID + "}))?$");
|
||||
static final class SequenceIdAndFileLength {
|
||||
|
||||
final int sequenceId;
|
||||
|
||||
final int fileLength;
|
||||
|
||||
SequenceIdAndFileLength(int sequenceId, int fileLength) {
|
||||
this.sequenceId = sequenceId;
|
||||
this.fileLength = fileLength;
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Returns the current sequence id and file length or 0 if none found.
|
||||
* @param p Path to a <code>.tableinfo</code> file.
|
||||
* @return The current editid or 0 if none found.
|
||||
*/
|
||||
static int getTableInfoSequenceId(final Path p) {
|
||||
if (p == null) {
|
||||
return 0;
|
||||
@RestrictedApi(explanation = "Should only be called in tests or self", link = "",
|
||||
allowedOnPath = ".*/src/test/.*|.*/FSTableDescriptors\\.java")
|
||||
static SequenceIdAndFileLength getTableInfoSequenceIdAndFileLength(Path p) {
|
||||
String name = p.getName();
|
||||
if (!name.startsWith(TABLEINFO_FILE_PREFIX)) {
|
||||
throw new IllegalArgumentException("Invalid table descriptor file name: " + name);
|
||||
}
|
||||
Matcher m = TABLEINFO_FILE_REGEX.matcher(p.getName());
|
||||
if (!m.matches()) {
|
||||
throw new IllegalArgumentException(p.toString());
|
||||
int firstDot = name.indexOf('.', TABLEINFO_FILE_PREFIX.length());
|
||||
if (firstDot < 0) {
|
||||
// oldest style where we do not have both sequence id and file length
|
||||
return new SequenceIdAndFileLength(0, 0);
|
||||
}
|
||||
String suffix = m.group(2);
|
||||
if (suffix == null || suffix.length() <= 0) {
|
||||
return 0;
|
||||
int secondDot = name.indexOf('.', firstDot + 1);
|
||||
if (secondDot < 0) {
|
||||
// old stype where we do not have file length
|
||||
int sequenceId = Integer.parseInt(name.substring(firstDot + 1));
|
||||
return new SequenceIdAndFileLength(sequenceId, 0);
|
||||
}
|
||||
return Integer.parseInt(m.group(2));
|
||||
int sequenceId = Integer.parseInt(name.substring(firstDot + 1, secondDot));
|
||||
int fileLength = Integer.parseInt(name.substring(secondDot + 1));
|
||||
return new SequenceIdAndFileLength(sequenceId, fileLength);
|
||||
}
|
||||
|
||||
/**
|
||||
* @param sequenceid
|
||||
* @return Name of tableinfo file.
|
||||
* Returns Name of tableinfo file.
|
||||
*/
|
||||
static String getTableInfoFileName(final int sequenceid) {
|
||||
return TABLEINFO_FILE_PREFIX + "." + formatTableInfoSequenceId(sequenceid);
|
||||
@RestrictedApi(explanation = "Should only be called in tests or self", link = "",
|
||||
allowedOnPath = ".*/src/test/.*|.*/FSTableDescriptors\\.java")
|
||||
static String getTableInfoFileName(int sequenceId, byte[] content) {
|
||||
return TABLEINFO_FILE_PREFIX + "." + formatTableInfoSequenceId(sequenceId) + "." +
|
||||
content.length;
|
||||
}
|
||||
|
||||
/**
|
||||
|
|
@ -496,131 +445,135 @@ public class FSTableDescriptors implements TableDescriptors {
|
|||
}
|
||||
|
||||
/**
|
||||
* Returns the latest table descriptor for the table located at the given directory
|
||||
* directly from the file system if it exists.
|
||||
* @throws TableInfoMissingException if there is no descriptor
|
||||
* Returns the latest table descriptor for the table located at the given directory directly from
|
||||
* the file system if it exists.
|
||||
*/
|
||||
public static TableDescriptor getTableDescriptorFromFs(FileSystem fs, Path tableDir)
|
||||
throws IOException {
|
||||
FileStatus status = getTableInfoPath(fs, tableDir, false);
|
||||
if (status == null) {
|
||||
throw new TableInfoMissingException("No table descriptor file under " + tableDir);
|
||||
}
|
||||
return readTableDescriptor(fs, status);
|
||||
return getTableDescriptorFromFs(fs, tableDir, true).map(Pair::getSecond).orElse(null);
|
||||
}
|
||||
|
||||
private static TableDescriptor readTableDescriptor(FileSystem fs, FileStatus status)
|
||||
throws IOException {
|
||||
int len = Ints.checkedCast(status.getLen());
|
||||
byte [] content = new byte[len];
|
||||
FSDataInputStream fsDataInputStream = fs.open(status.getPath());
|
||||
try {
|
||||
fsDataInputStream.readFully(content);
|
||||
} finally {
|
||||
fsDataInputStream.close();
|
||||
private static void deleteMalformedFile(FileSystem fs, Path file) throws IOException {
|
||||
LOG.info("Delete malformed table descriptor file {}", file);
|
||||
if (!fs.delete(file, false)) {
|
||||
LOG.warn("Failed to delete malformed table descriptor file {}", file);
|
||||
}
|
||||
}
|
||||
|
||||
private static Optional<Pair<FileStatus, TableDescriptor>> getTableDescriptorFromFs(FileSystem fs,
|
||||
Path tableDir, boolean readonly) throws IOException {
|
||||
Path tableInfoDir = new Path(tableDir, TABLEINFO_DIR);
|
||||
FileStatus[] descFiles = CommonFSUtils.listStatus(fs, tableInfoDir, TABLEINFO_PATHFILTER);
|
||||
if (descFiles == null || descFiles.length < 1) {
|
||||
return Optional.empty();
|
||||
}
|
||||
Arrays.sort(descFiles, TABLEINFO_FILESTATUS_COMPARATOR);
|
||||
int i = 0;
|
||||
TableDescriptor td = null;
|
||||
FileStatus descFile = null;
|
||||
for (; i < descFiles.length; i++) {
|
||||
descFile = descFiles[i];
|
||||
Path file = descFile.getPath();
|
||||
// get file length from file name if present
|
||||
int fileLength = getTableInfoSequenceIdAndFileLength(file).fileLength;
|
||||
byte[] content = new byte[fileLength > 0 ? fileLength : Ints.checkedCast(descFile.getLen())];
|
||||
try (FSDataInputStream in = fs.open(file)) {
|
||||
in.readFully(content);
|
||||
} catch (EOFException e) {
|
||||
LOG.info("Failed to load file {} due to EOF, it should be half written: {}", file,
|
||||
e.toString());
|
||||
if (!readonly) {
|
||||
deleteMalformedFile(fs, file);
|
||||
}
|
||||
continue;
|
||||
}
|
||||
TableDescriptor htd = null;
|
||||
try {
|
||||
htd = TableDescriptorBuilder.parseFrom(content);
|
||||
td = TableDescriptorBuilder.parseFrom(content);
|
||||
break;
|
||||
} catch (DeserializationException e) {
|
||||
throw new IOException("content=" + Bytes.toShort(content), e);
|
||||
LOG.info("Failed to parse file {} due to malformed protobuf message: {}", file,
|
||||
e.toString());
|
||||
if (!readonly) {
|
||||
deleteMalformedFile(fs, file);
|
||||
}
|
||||
return htd;
|
||||
}
|
||||
}
|
||||
if (!readonly) {
|
||||
// i + 1 to skip the one we load
|
||||
for (i = i + 1; i < descFiles.length; i++) {
|
||||
Path file = descFiles[i].getPath();
|
||||
LOG.info("Delete old table descriptor file {}", file);
|
||||
if (!fs.delete(file, false)) {
|
||||
LOG.info("Failed to delete old table descriptor file {}", file);
|
||||
}
|
||||
}
|
||||
}
|
||||
return td != null ? Optional.of(Pair.newPair(descFile, td)) : Optional.empty();
|
||||
}
|
||||
|
||||
/**
|
||||
* Deletes files matching the table info file pattern within the given directory
|
||||
* whose sequenceId is at most the given max sequenceId.
|
||||
* Deletes files matching the table info file pattern within the given directory whose sequenceId
|
||||
* is at most the given max sequenceId.
|
||||
*/
|
||||
private static void deleteTableDescriptorFiles(FileSystem fs, Path dir, int maxSequenceId)
|
||||
throws IOException {
|
||||
FileStatus[] status = CommonFSUtils.listStatus(fs, dir, TABLEINFO_PATHFILTER);
|
||||
for (FileStatus file : status) {
|
||||
Path path = file.getPath();
|
||||
int sequenceId = getTableInfoSequenceId(path);
|
||||
int sequenceId = getTableInfoSequenceIdAndFileLength(path).sequenceId;
|
||||
if (sequenceId <= maxSequenceId) {
|
||||
boolean success = CommonFSUtils.delete(fs, path, false);
|
||||
if (success) {
|
||||
LOG.debug("Deleted " + path);
|
||||
LOG.debug("Deleted {}", path);
|
||||
} else {
|
||||
LOG.error("Failed to delete table descriptor at " + path);
|
||||
LOG.error("Failed to delete table descriptor at {}", path);
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Attempts to write a new table descriptor to the given table's directory. It first writes it to
|
||||
* the .tmp dir then uses an atomic rename to move it into place. It begins at the
|
||||
* Attempts to write a new table descriptor to the given table's directory. It begins at the
|
||||
* currentSequenceId + 1 and tries 10 times to find a new sequence number not already in use.
|
||||
* <p/>
|
||||
* Removes the current descriptor file if passed in.
|
||||
* @return Descriptor file or null if we failed write.
|
||||
*/
|
||||
private static Path writeTableDescriptor(final FileSystem fs, final TableDescriptor htd,
|
||||
private static Path writeTableDescriptor(final FileSystem fs, final TableDescriptor td,
|
||||
final Path tableDir, final FileStatus currentDescriptorFile) throws IOException {
|
||||
// Get temporary dir into which we'll first write a file to avoid half-written file phenomenon.
|
||||
// This directory is never removed to avoid removing it out from under a concurrent writer.
|
||||
Path tmpTableDir = new Path(tableDir, TMP_DIR);
|
||||
// Here we will write to the final directory directly to avoid renaming as on OSS renaming is
|
||||
// not atomic and has performance issue. The reason why we could do this is that, in the below
|
||||
// code we will not overwrite existing files, we will write a new file instead. And when
|
||||
// loading, we will skip the half written file, please see the code in getTableDescriptorFromFs
|
||||
Path tableInfoDir = new Path(tableDir, TABLEINFO_DIR);
|
||||
|
||||
// What is current sequenceid? We read the current sequenceid from
|
||||
// the current file. After we read it, another thread could come in and
|
||||
// compete with us writing out next version of file. The below retries
|
||||
// should help in this case some but its hard to do guarantees in face of
|
||||
// concurrent schema edits.
|
||||
// In proc v2 we have table lock so typically, there will be no concurrent writes. Keep the
|
||||
// retry logic here since we may still want to write the table descriptor from for example,
|
||||
// HBCK2?
|
||||
int currentSequenceId = currentDescriptorFile == null ? 0 :
|
||||
getTableInfoSequenceId(currentDescriptorFile.getPath());
|
||||
int newSequenceId = currentSequenceId;
|
||||
getTableInfoSequenceIdAndFileLength(currentDescriptorFile.getPath()).sequenceId;
|
||||
|
||||
// Put arbitrary upperbound on how often we retry
|
||||
int retries = 10;
|
||||
int retrymax = currentSequenceId + retries;
|
||||
Path tableInfoDirPath = null;
|
||||
do {
|
||||
newSequenceId += 1;
|
||||
String filename = getTableInfoFileName(newSequenceId);
|
||||
Path tempPath = new Path(tmpTableDir, filename);
|
||||
if (fs.exists(tempPath)) {
|
||||
LOG.debug(tempPath + " exists; retrying up to " + retries + " times");
|
||||
int maxAttempts = 10;
|
||||
int maxSequenceId = currentSequenceId + maxAttempts;
|
||||
byte[] bytes = TableDescriptorBuilder.toByteArray(td);
|
||||
for (int newSequenceId =
|
||||
currentSequenceId + 1; newSequenceId <= maxSequenceId; newSequenceId++) {
|
||||
String fileName = getTableInfoFileName(newSequenceId, bytes);
|
||||
Path filePath = new Path(tableInfoDir, fileName);
|
||||
try (FSDataOutputStream out = fs.create(filePath, false)) {
|
||||
out.write(bytes);
|
||||
} catch (FileAlreadyExistsException e) {
|
||||
LOG.debug("{} exists; retrying up to {} times", filePath, maxAttempts, e);
|
||||
continue;
|
||||
} catch (IOException e) {
|
||||
LOG.debug("Failed write {}; retrying up to {} times", filePath, maxAttempts, e);
|
||||
continue;
|
||||
}
|
||||
tableInfoDirPath = new Path(tableInfoDir, filename);
|
||||
try {
|
||||
writeTD(fs, tempPath, htd);
|
||||
fs.mkdirs(tableInfoDirPath.getParent());
|
||||
if (!fs.rename(tempPath, tableInfoDirPath)) {
|
||||
throw new IOException("Failed rename of " + tempPath + " to " + tableInfoDirPath);
|
||||
}
|
||||
LOG.debug("Wrote into " + tableInfoDirPath);
|
||||
} catch (IOException ioe) {
|
||||
// Presume clash of names or something; go around again.
|
||||
LOG.debug("Failed write and/or rename; retrying", ioe);
|
||||
if (!CommonFSUtils.deleteDirectory(fs, tempPath)) {
|
||||
LOG.warn("Failed cleanup of " + tempPath);
|
||||
}
|
||||
tableInfoDirPath = null;
|
||||
continue;
|
||||
}
|
||||
break;
|
||||
} while (newSequenceId < retrymax);
|
||||
if (tableInfoDirPath != null) {
|
||||
// if we succeeded, remove old table info files.
|
||||
deleteTableDescriptorFiles(fs, tableInfoDir, newSequenceId - 1);
|
||||
return filePath;
|
||||
}
|
||||
return tableInfoDirPath;
|
||||
}
|
||||
|
||||
private static void writeTD(final FileSystem fs, final Path p, final TableDescriptor htd)
|
||||
throws IOException {
|
||||
FSDataOutputStream out = fs.create(p, false);
|
||||
try {
|
||||
// We used to write this file out as a serialized HTD Writable followed by two '\n's and then
|
||||
// the toString version of HTD. Now we just write out the pb serialization.
|
||||
out.write(TableDescriptorBuilder.toByteArray(htd));
|
||||
} finally {
|
||||
out.close();
|
||||
}
|
||||
return null;
|
||||
}
|
||||
|
||||
/**
|
||||
|
|
@ -679,19 +632,17 @@ public class FSTableDescriptors implements TableDescriptors {
|
|||
*/
|
||||
public static boolean createTableDescriptorForTableDirectory(FileSystem fs, Path tableDir,
|
||||
TableDescriptor htd, boolean forceCreation) throws IOException {
|
||||
FileStatus status = getTableInfoPath(fs, tableDir);
|
||||
if (status != null) {
|
||||
LOG.debug("Current path=" + status.getPath());
|
||||
Optional<Pair<FileStatus, TableDescriptor>> opt = getTableDescriptorFromFs(fs, tableDir, false);
|
||||
if (opt.isPresent()) {
|
||||
LOG.debug("Current path={}", opt.get().getFirst());
|
||||
if (!forceCreation) {
|
||||
if (fs.exists(status.getPath()) && status.getLen() > 0) {
|
||||
if (readTableDescriptor(fs, status).equals(htd)) {
|
||||
if (htd.equals(opt.get().getSecond())) {
|
||||
LOG.trace("TableInfo already exists.. Skipping creation");
|
||||
return false;
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
return writeTableDescriptor(fs, htd, tableDir, status) != null;
|
||||
return writeTableDescriptor(fs, htd, tableDir, opt.map(Pair::getFirst).orElse(null)) != null;
|
||||
}
|
||||
}
|
||||
|
||||
|
|
|
|||
|
|
@ -19,6 +19,7 @@ package org.apache.hadoop.hbase.util;
|
|||
|
||||
import static org.junit.Assert.assertEquals;
|
||||
import static org.junit.Assert.assertFalse;
|
||||
import static org.junit.Assert.assertNotEquals;
|
||||
import static org.junit.Assert.assertNotNull;
|
||||
import static org.junit.Assert.assertNull;
|
||||
import static org.junit.Assert.assertTrue;
|
||||
|
|
@ -28,22 +29,22 @@ import java.io.IOException;
|
|||
import java.util.Arrays;
|
||||
import java.util.Comparator;
|
||||
import java.util.Map;
|
||||
import org.apache.hadoop.fs.FSDataInputStream;
|
||||
import org.apache.hadoop.fs.FSDataOutputStream;
|
||||
import org.apache.hadoop.fs.FileStatus;
|
||||
import org.apache.hadoop.fs.FileSystem;
|
||||
import org.apache.hadoop.fs.Path;
|
||||
import org.apache.hadoop.hbase.HBaseClassTestRule;
|
||||
import org.apache.hadoop.hbase.HBaseTestingUtility;
|
||||
import org.apache.hadoop.hbase.HBaseCommonTestingUtility;
|
||||
import org.apache.hadoop.hbase.HConstants;
|
||||
import org.apache.hadoop.hbase.TableDescriptors;
|
||||
import org.apache.hadoop.hbase.TableName;
|
||||
import org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder;
|
||||
import org.apache.hadoop.hbase.client.TableDescriptor;
|
||||
import org.apache.hadoop.hbase.client.TableDescriptorBuilder;
|
||||
import org.apache.hadoop.hbase.exceptions.DeserializationException;
|
||||
import org.apache.hadoop.hbase.testclassification.MediumTests;
|
||||
import org.apache.hadoop.hbase.testclassification.MiscTests;
|
||||
import org.junit.AfterClass;
|
||||
import org.junit.Before;
|
||||
import org.junit.ClassRule;
|
||||
import org.junit.Rule;
|
||||
import org.junit.Test;
|
||||
|
|
@ -63,69 +64,73 @@ public class TestFSTableDescriptors {
|
|||
public static final HBaseClassTestRule CLASS_RULE =
|
||||
HBaseClassTestRule.forClass(TestFSTableDescriptors.class);
|
||||
|
||||
private static final HBaseTestingUtility UTIL = new HBaseTestingUtility();
|
||||
private static final HBaseCommonTestingUtility UTIL = new HBaseCommonTestingUtility();
|
||||
private static final Logger LOG = LoggerFactory.getLogger(TestFSTableDescriptors.class);
|
||||
|
||||
@Rule
|
||||
public TestName name = new TestName();
|
||||
|
||||
private Path testDir;
|
||||
|
||||
@Before
|
||||
public void setUp() {
|
||||
testDir = UTIL.getDataTestDir(name.getMethodName());
|
||||
}
|
||||
|
||||
@AfterClass
|
||||
public static void tearDownAfterClass() {
|
||||
UTIL.cleanupTestDir();
|
||||
}
|
||||
|
||||
@Test(expected = IllegalArgumentException.class)
|
||||
public void testRegexAgainstOldStyleTableInfo() {
|
||||
Path p = new Path("/tmp", FSTableDescriptors.TABLEINFO_FILE_PREFIX);
|
||||
int i = FSTableDescriptors.getTableInfoSequenceId(p);
|
||||
Path p = new Path(testDir, FSTableDescriptors.TABLEINFO_FILE_PREFIX);
|
||||
int i = FSTableDescriptors.getTableInfoSequenceIdAndFileLength(p).sequenceId;
|
||||
assertEquals(0, i);
|
||||
// Assert it won't eat garbage -- that it fails
|
||||
p = new Path("/tmp", "abc");
|
||||
FSTableDescriptors.getTableInfoSequenceId(p);
|
||||
p = new Path(testDir, "abc");
|
||||
FSTableDescriptors.getTableInfoSequenceIdAndFileLength(p);
|
||||
}
|
||||
|
||||
@Test
|
||||
public void testCreateAndUpdate() throws IOException {
|
||||
Path testdir = UTIL.getDataTestDir(name.getMethodName());
|
||||
TableDescriptor htd =
|
||||
TableDescriptorBuilder.newBuilder(TableName.valueOf(name.getMethodName())).build();
|
||||
FileSystem fs = FileSystem.get(UTIL.getConfiguration());
|
||||
FSTableDescriptors fstd = new FSTableDescriptors(fs, testdir);
|
||||
FSTableDescriptors fstd = new FSTableDescriptors(fs, testDir);
|
||||
assertTrue(fstd.createTableDescriptor(htd));
|
||||
assertFalse(fstd.createTableDescriptor(htd));
|
||||
FileStatus[] statuses = fs.listStatus(testdir);
|
||||
assertTrue("statuses.length=" + statuses.length, statuses.length == 1);
|
||||
Path tableInfoDir = new Path(CommonFSUtils.getTableDir(testDir, htd.getTableName()),
|
||||
FSTableDescriptors.TABLEINFO_DIR);
|
||||
FileStatus[] statuses = fs.listStatus(tableInfoDir);
|
||||
assertEquals("statuses.length=" + statuses.length, 1, statuses.length);
|
||||
for (int i = 0; i < 10; i++) {
|
||||
fstd.update(htd);
|
||||
}
|
||||
statuses = fs.listStatus(testdir);
|
||||
assertTrue(statuses.length == 1);
|
||||
Path tmpTableDir = new Path(CommonFSUtils.getTableDir(testdir, htd.getTableName()), ".tmp");
|
||||
statuses = fs.listStatus(tmpTableDir);
|
||||
assertTrue(statuses.length == 0);
|
||||
statuses = fs.listStatus(tableInfoDir);
|
||||
assertEquals(1, statuses.length);
|
||||
}
|
||||
|
||||
@Test
|
||||
public void testSequenceIdAdvancesOnTableInfo() throws IOException {
|
||||
Path testdir = UTIL.getDataTestDir(name.getMethodName());
|
||||
TableDescriptor htd =
|
||||
TableDescriptorBuilder.newBuilder(TableName.valueOf(name.getMethodName())).build();
|
||||
FileSystem fs = FileSystem.get(UTIL.getConfiguration());
|
||||
FSTableDescriptors fstd = new FSTableDescriptors(fs, testdir);
|
||||
Path p0 = fstd.updateTableDescriptor(htd);
|
||||
int i0 = FSTableDescriptors.getTableInfoSequenceId(p0);
|
||||
Path p1 = fstd.updateTableDescriptor(htd);
|
||||
FSTableDescriptors fstd = new FSTableDescriptors(fs, testDir);
|
||||
Path previousPath = null;
|
||||
int previousSeqId = -1;
|
||||
for (int i = 0; i < 10; i++) {
|
||||
Path path = fstd.updateTableDescriptor(htd);
|
||||
int seqId =
|
||||
FSTableDescriptors.getTableInfoSequenceIdAndFileLength(path).sequenceId;
|
||||
if (previousPath != null) {
|
||||
// Assert we cleaned up the old file.
|
||||
assertTrue(!fs.exists(p0));
|
||||
int i1 = FSTableDescriptors.getTableInfoSequenceId(p1);
|
||||
assertTrue(i1 == i0 + 1);
|
||||
Path p2 = fstd.updateTableDescriptor(htd);
|
||||
// Assert we cleaned up the old file.
|
||||
assertTrue(!fs.exists(p1));
|
||||
int i2 = FSTableDescriptors.getTableInfoSequenceId(p2);
|
||||
assertTrue(i2 == i1 + 1);
|
||||
Path p3 = fstd.updateTableDescriptor(htd);
|
||||
// Assert we cleaned up the old file.
|
||||
assertTrue(!fs.exists(p2));
|
||||
int i3 = FSTableDescriptors.getTableInfoSequenceId(p3);
|
||||
assertTrue(i3 == i2 + 1);
|
||||
TableDescriptor descriptor = fstd.get(htd.getTableName());
|
||||
assertEquals(descriptor, htd);
|
||||
assertTrue(!fs.exists(previousPath));
|
||||
assertEquals(previousSeqId + 1, seqId);
|
||||
}
|
||||
previousPath = path;
|
||||
previousSeqId = seqId;
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
|
|
@ -136,7 +141,7 @@ public class TestFSTableDescriptors {
|
|||
for (int i = 0; i < FSTableDescriptors.WIDTH_OF_SEQUENCE_ID; i++) {
|
||||
sb.append("0");
|
||||
}
|
||||
assertEquals(FSTableDescriptors.TABLEINFO_FILE_PREFIX + "." + sb.toString(),
|
||||
assertEquals(FSTableDescriptors.TABLEINFO_FILE_PREFIX + "." + sb.toString() + ".0",
|
||||
p0.getName());
|
||||
// Check a few more.
|
||||
Path p2 = assertWriteAndReadSequenceId(2);
|
||||
|
|
@ -154,67 +159,42 @@ public class TestFSTableDescriptors {
|
|||
}
|
||||
|
||||
private Path assertWriteAndReadSequenceId(final int i) {
|
||||
Path p = new Path("/tmp", FSTableDescriptors.getTableInfoFileName(i));
|
||||
int ii = FSTableDescriptors.getTableInfoSequenceId(p);
|
||||
Path p =
|
||||
new Path(testDir, FSTableDescriptors.getTableInfoFileName(i, HConstants.EMPTY_BYTE_ARRAY));
|
||||
int ii = FSTableDescriptors.getTableInfoSequenceIdAndFileLength(p).sequenceId;
|
||||
assertEquals(i, ii);
|
||||
return p;
|
||||
}
|
||||
|
||||
@Test
|
||||
public void testRemoves() throws IOException {
|
||||
final String name = this.name.getMethodName();
|
||||
FileSystem fs = FileSystem.get(UTIL.getConfiguration());
|
||||
// Cleanup old tests if any detrius laying around.
|
||||
Path rootdir = new Path(UTIL.getDataTestDir(), name);
|
||||
TableDescriptors htds = new FSTableDescriptors(fs, rootdir);
|
||||
TableDescriptor htd = TableDescriptorBuilder.newBuilder(TableName.valueOf(name)).build();
|
||||
TableDescriptors htds = new FSTableDescriptors(fs, testDir);
|
||||
TableDescriptor htd =
|
||||
TableDescriptorBuilder.newBuilder(TableName.valueOf(name.getMethodName())).build();
|
||||
htds.update(htd);
|
||||
assertNotNull(htds.remove(htd.getTableName()));
|
||||
assertNull(htds.remove(htd.getTableName()));
|
||||
}
|
||||
|
||||
@Test public void testReadingHTDFromFS() throws IOException {
|
||||
final String name = this.name.getMethodName();
|
||||
@Test
|
||||
public void testReadingHTDFromFS() throws IOException {
|
||||
FileSystem fs = FileSystem.get(UTIL.getConfiguration());
|
||||
TableDescriptor htd = TableDescriptorBuilder.newBuilder(TableName.valueOf(name)).build();
|
||||
Path rootdir = UTIL.getDataTestDir(name);
|
||||
FSTableDescriptors fstd = new FSTableDescriptors(fs, rootdir);
|
||||
TableDescriptor htd =
|
||||
TableDescriptorBuilder.newBuilder(TableName.valueOf(name.getMethodName())).build();
|
||||
FSTableDescriptors fstd = new FSTableDescriptors(fs, testDir);
|
||||
fstd.createTableDescriptor(htd);
|
||||
TableDescriptor td2 =
|
||||
FSTableDescriptors.getTableDescriptorFromFs(fs, rootdir, htd.getTableName());
|
||||
FSTableDescriptors.getTableDescriptorFromFs(fs, testDir, htd.getTableName());
|
||||
assertTrue(htd.equals(td2));
|
||||
}
|
||||
|
||||
@Test public void testReadingOldHTDFromFS() throws IOException, DeserializationException {
|
||||
final String name = this.name.getMethodName();
|
||||
FileSystem fs = FileSystem.get(UTIL.getConfiguration());
|
||||
Path rootdir = UTIL.getDataTestDir(name);
|
||||
FSTableDescriptors fstd = new FSTableDescriptors(fs, rootdir);
|
||||
TableDescriptor htd = TableDescriptorBuilder.newBuilder(TableName.valueOf(name)).build();
|
||||
Path descriptorFile = fstd.updateTableDescriptor(htd);
|
||||
try (FSDataOutputStream out = fs.create(descriptorFile, true)) {
|
||||
out.write(TableDescriptorBuilder.toByteArray(htd));
|
||||
}
|
||||
FSTableDescriptors fstd2 = new FSTableDescriptors(fs, rootdir);
|
||||
TableDescriptor td2 = fstd2.get(htd.getTableName());
|
||||
assertEquals(htd, td2);
|
||||
FileStatus descriptorFile2 =
|
||||
FSTableDescriptors.getTableInfoPath(fs, fstd2.getTableDir(htd.getTableName()));
|
||||
byte[] buffer = TableDescriptorBuilder.toByteArray(htd);
|
||||
try (FSDataInputStream in = fs.open(descriptorFile2.getPath())) {
|
||||
in.readFully(buffer);
|
||||
}
|
||||
TableDescriptor td3 = TableDescriptorBuilder.parseFrom(buffer);
|
||||
assertEquals(htd, td3);
|
||||
}
|
||||
|
||||
@Test public void testTableDescriptors()
|
||||
throws IOException, InterruptedException {
|
||||
final String name = this.name.getMethodName();
|
||||
@Test
|
||||
public void testTableDescriptors() throws IOException, InterruptedException {
|
||||
FileSystem fs = FileSystem.get(UTIL.getConfiguration());
|
||||
// Cleanup old tests if any debris laying around.
|
||||
Path rootdir = new Path(UTIL.getDataTestDir(), name);
|
||||
FSTableDescriptors htds = new FSTableDescriptors(fs, rootdir) {
|
||||
FSTableDescriptors htds = new FSTableDescriptors(fs, testDir) {
|
||||
@Override
|
||||
public TableDescriptor get(TableName tablename) {
|
||||
LOG.info(tablename + ", cachehits=" + this.cachehits);
|
||||
|
|
@ -224,28 +204,30 @@ public class TestFSTableDescriptors {
|
|||
final int count = 10;
|
||||
// Write out table infos.
|
||||
for (int i = 0; i < count; i++) {
|
||||
htds.createTableDescriptor(TableDescriptorBuilder.newBuilder(TableName.valueOf(name + i)).build());
|
||||
htds.createTableDescriptor(
|
||||
TableDescriptorBuilder.newBuilder(TableName.valueOf(name.getMethodName() + i)).build());
|
||||
}
|
||||
|
||||
for (int i = 0; i < count; i++) {
|
||||
assertTrue(htds.get(TableName.valueOf(name + i)) != null);
|
||||
assertTrue(htds.get(TableName.valueOf(name.getMethodName() + i)) != null);
|
||||
}
|
||||
for (int i = 0; i < count; i++) {
|
||||
assertTrue(htds.get(TableName.valueOf(name + i)) != null);
|
||||
assertTrue(htds.get(TableName.valueOf(name.getMethodName() + i)) != null);
|
||||
}
|
||||
// Update the table infos
|
||||
for (int i = 0; i < count; i++) {
|
||||
TableDescriptorBuilder builder = TableDescriptorBuilder.newBuilder(TableName.valueOf(name + i));
|
||||
TableDescriptorBuilder builder =
|
||||
TableDescriptorBuilder.newBuilder(TableName.valueOf(name.getMethodName() + i));
|
||||
builder.setColumnFamily(ColumnFamilyDescriptorBuilder.of("" + i));
|
||||
htds.update(builder.build());
|
||||
}
|
||||
// Wait a while so mod time we write is for sure different.
|
||||
Thread.sleep(100);
|
||||
for (int i = 0; i < count; i++) {
|
||||
assertTrue(htds.get(TableName.valueOf(name + i)) != null);
|
||||
assertTrue(htds.get(TableName.valueOf(name.getMethodName() + i)) != null);
|
||||
}
|
||||
for (int i = 0; i < count; i++) {
|
||||
assertTrue(htds.get(TableName.valueOf(name + i)) != null);
|
||||
assertTrue(htds.get(TableName.valueOf(name.getMethodName() + i)) != null);
|
||||
}
|
||||
assertEquals(count * 4, htds.invocations);
|
||||
assertTrue("expected=" + (count * 2) + ", actual=" + htds.cachehits,
|
||||
|
|
@ -253,64 +235,61 @@ public class TestFSTableDescriptors {
|
|||
}
|
||||
|
||||
@Test
|
||||
public void testTableDescriptorsNoCache()
|
||||
throws IOException, InterruptedException {
|
||||
final String name = this.name.getMethodName();
|
||||
public void testTableDescriptorsNoCache() throws IOException, InterruptedException {
|
||||
FileSystem fs = FileSystem.get(UTIL.getConfiguration());
|
||||
// Cleanup old tests if any debris laying around.
|
||||
Path rootdir = new Path(UTIL.getDataTestDir(), name);
|
||||
FSTableDescriptors htds = new FSTableDescriptorsTest(fs, rootdir, false);
|
||||
FSTableDescriptors htds = new FSTableDescriptorsTest(fs, testDir, false);
|
||||
final int count = 10;
|
||||
// Write out table infos.
|
||||
for (int i = 0; i < count; i++) {
|
||||
htds.createTableDescriptor(TableDescriptorBuilder.newBuilder(TableName.valueOf(name + i)).build());
|
||||
htds.createTableDescriptor(
|
||||
TableDescriptorBuilder.newBuilder(TableName.valueOf(name.getMethodName() + i)).build());
|
||||
}
|
||||
|
||||
for (int i = 0; i < 2 * count; i++) {
|
||||
assertNotNull("Expected HTD, got null instead", htds.get(TableName.valueOf(name + i % 2)));
|
||||
assertNotNull("Expected HTD, got null instead",
|
||||
htds.get(TableName.valueOf(name.getMethodName() + i % 2)));
|
||||
}
|
||||
// Update the table infos
|
||||
for (int i = 0; i < count; i++) {
|
||||
TableDescriptorBuilder builder = TableDescriptorBuilder.newBuilder(TableName.valueOf(name + i));
|
||||
TableDescriptorBuilder builder =
|
||||
TableDescriptorBuilder.newBuilder(TableName.valueOf(name.getMethodName() + i));
|
||||
builder.setColumnFamily(ColumnFamilyDescriptorBuilder.of("" + i));
|
||||
htds.update(builder.build());
|
||||
}
|
||||
for (int i = 0; i < count; i++) {
|
||||
assertNotNull("Expected HTD, got null instead", htds.get(TableName.valueOf(name + i)));
|
||||
assertTrue("Column Family " + i + " missing",
|
||||
htds.get(TableName.valueOf(name + i)).hasColumnFamily(Bytes.toBytes("" + i)));
|
||||
assertNotNull("Expected HTD, got null instead",
|
||||
htds.get(TableName.valueOf(name.getMethodName() + i)));
|
||||
assertTrue("Column Family " + i + " missing", htds
|
||||
.get(TableName.valueOf(name.getMethodName() + i)).hasColumnFamily(Bytes.toBytes("" + i)));
|
||||
}
|
||||
assertEquals(count * 4, htds.invocations);
|
||||
assertEquals("expected=0, actual=" + htds.cachehits, 0, htds.cachehits);
|
||||
}
|
||||
|
||||
@Test
|
||||
public void testGetAll()
|
||||
throws IOException, InterruptedException {
|
||||
public void testGetAll() throws IOException, InterruptedException {
|
||||
final String name = "testGetAll";
|
||||
FileSystem fs = FileSystem.get(UTIL.getConfiguration());
|
||||
// Cleanup old tests if any debris laying around.
|
||||
Path rootdir = new Path(UTIL.getDataTestDir(), name);
|
||||
FSTableDescriptors htds = new FSTableDescriptorsTest(fs, rootdir);
|
||||
FSTableDescriptors htds = new FSTableDescriptorsTest(fs, testDir);
|
||||
final int count = 4;
|
||||
// Write out table infos.
|
||||
for (int i = 0; i < count; i++) {
|
||||
htds.createTableDescriptor(TableDescriptorBuilder.newBuilder(TableName.valueOf(name + i)).build());
|
||||
htds.createTableDescriptor(
|
||||
TableDescriptorBuilder.newBuilder(TableName.valueOf(name + i)).build());
|
||||
}
|
||||
// add hbase:meta
|
||||
htds.createTableDescriptor(TableDescriptorBuilder.newBuilder(TableName.META_TABLE_NAME).build());
|
||||
|
||||
assertEquals("getAll() didn't return all TableDescriptors, expected: " +
|
||||
(count + 1) + " got: " + htds.getAll().size(),
|
||||
count + 1, htds.getAll().size());
|
||||
htds
|
||||
.createTableDescriptor(TableDescriptorBuilder.newBuilder(TableName.META_TABLE_NAME).build());
|
||||
assertEquals("getAll() didn't return all TableDescriptors, expected: " + (count + 1) +
|
||||
" got: " + htds.getAll().size(), count + 1, htds.getAll().size());
|
||||
}
|
||||
|
||||
@Test
|
||||
public void testGetAllOrdering() throws Exception {
|
||||
final String name = "testGetAllOrdering";
|
||||
FileSystem fs = FileSystem.get(UTIL.getConfiguration());
|
||||
Path rootDir = new Path(UTIL.getDataTestDir(), name);
|
||||
FSTableDescriptors tds = new FSTableDescriptorsTest(fs, rootDir);
|
||||
FSTableDescriptors tds = new FSTableDescriptorsTest(fs, testDir);
|
||||
|
||||
String[] tableNames = new String[] { "foo", "bar", "foo:bar", "bar:foo" };
|
||||
for (String tableName : tableNames) {
|
||||
|
|
@ -325,7 +304,6 @@ public class TestFSTableDescriptors {
|
|||
tables.remove(TableName.META_TABLE_NAME.getNameAsString());
|
||||
assertEquals(4, tables.size());
|
||||
|
||||
|
||||
String[] tableNamesOrdered =
|
||||
new String[] { "bar:foo", "default:bar", "default:foo", "foo:bar" };
|
||||
int i = 0;
|
||||
|
|
@ -338,24 +316,22 @@ public class TestFSTableDescriptors {
|
|||
}
|
||||
|
||||
@Test
|
||||
public void testCacheConsistency()
|
||||
throws IOException, InterruptedException {
|
||||
final String name = this.name.getMethodName();
|
||||
public void testCacheConsistency() throws IOException, InterruptedException {
|
||||
FileSystem fs = FileSystem.get(UTIL.getConfiguration());
|
||||
// Cleanup old tests if any debris laying around.
|
||||
Path rootdir = new Path(UTIL.getDataTestDir(), name);
|
||||
FSTableDescriptors chtds = new FSTableDescriptorsTest(fs, rootdir);
|
||||
FSTableDescriptors nonchtds = new FSTableDescriptorsTest(fs, rootdir, false);
|
||||
FSTableDescriptors chtds = new FSTableDescriptorsTest(fs, testDir);
|
||||
FSTableDescriptors nonchtds = new FSTableDescriptorsTest(fs, testDir, false);
|
||||
|
||||
final int count = 10;
|
||||
// Write out table infos via non-cached FSTableDescriptors
|
||||
for (int i = 0; i < count; i++) {
|
||||
nonchtds.createTableDescriptor(TableDescriptorBuilder.newBuilder(TableName.valueOf(name + i)).build());
|
||||
nonchtds.createTableDescriptor(
|
||||
TableDescriptorBuilder.newBuilder(TableName.valueOf(name.getMethodName() + i)).build());
|
||||
}
|
||||
|
||||
// Calls to getAll() won't increase the cache counter, do per table.
|
||||
for (int i = 0; i < count; i++) {
|
||||
assertTrue(chtds.get(TableName.valueOf(name + i)) != null);
|
||||
assertTrue(chtds.get(TableName.valueOf(name.getMethodName() + i)) != null);
|
||||
}
|
||||
|
||||
assertTrue(nonchtds.getAll().size() == chtds.getAll().size());
|
||||
|
|
@ -384,23 +360,20 @@ public class TestFSTableDescriptors {
|
|||
|
||||
@Test
|
||||
public void testNoSuchTable() throws IOException {
|
||||
final String name = "testNoSuchTable";
|
||||
FileSystem fs = FileSystem.get(UTIL.getConfiguration());
|
||||
// Cleanup old tests if any detrius laying around.
|
||||
Path rootdir = new Path(UTIL.getDataTestDir(), name);
|
||||
TableDescriptors htds = new FSTableDescriptors(fs, rootdir);
|
||||
TableDescriptors htds = new FSTableDescriptors(fs, testDir);
|
||||
assertNull("There shouldn't be any HTD for this table",
|
||||
htds.get(TableName.valueOf("NoSuchTable")));
|
||||
}
|
||||
|
||||
@Test
|
||||
public void testUpdates() throws IOException {
|
||||
final String name = "testUpdates";
|
||||
FileSystem fs = FileSystem.get(UTIL.getConfiguration());
|
||||
// Cleanup old tests if any detrius laying around.
|
||||
Path rootdir = new Path(UTIL.getDataTestDir(), name);
|
||||
TableDescriptors htds = new FSTableDescriptors(fs, rootdir);
|
||||
TableDescriptor htd = TableDescriptorBuilder.newBuilder(TableName.valueOf(name)).build();
|
||||
TableDescriptors htds = new FSTableDescriptors(fs, testDir);
|
||||
TableDescriptor htd =
|
||||
TableDescriptorBuilder.newBuilder(TableName.valueOf(name.getMethodName())).build();
|
||||
htds.update(htd);
|
||||
htds.update(htd);
|
||||
htds.update(htd);
|
||||
|
|
@ -408,14 +381,11 @@ public class TestFSTableDescriptors {
|
|||
|
||||
@Test
|
||||
public void testTableInfoFileStatusComparator() {
|
||||
FileStatus bare =
|
||||
new FileStatus(0, false, 0, 0, -1,
|
||||
FileStatus bare = new FileStatus(0, false, 0, 0, -1,
|
||||
new Path("/tmp", FSTableDescriptors.TABLEINFO_FILE_PREFIX));
|
||||
FileStatus future =
|
||||
new FileStatus(0, false, 0, 0, -1,
|
||||
FileStatus future = new FileStatus(0, false, 0, 0, -1,
|
||||
new Path("/tmp/tablinfo." + EnvironmentEdgeManager.currentTime()));
|
||||
FileStatus farFuture =
|
||||
new FileStatus(0, false, 0, 0, -1,
|
||||
FileStatus farFuture = new FileStatus(0, false, 0, 0, -1,
|
||||
new Path("/tmp/tablinfo." + EnvironmentEdgeManager.currentTime() + 1000));
|
||||
FileStatus[] alist = { bare, future, farFuture };
|
||||
FileStatus[] blist = { bare, farFuture, future };
|
||||
|
|
@ -440,31 +410,54 @@ public class TestFSTableDescriptors {
|
|||
.get(TableName.valueOf(HConstants.HBASE_TEMP_DIRECTORY));
|
||||
fail("Shouldn't be able to read a table descriptor for the archive directory.");
|
||||
} catch (Exception e) {
|
||||
LOG.debug("Correctly got error when reading a table descriptor from the archive directory: "
|
||||
+ e.getMessage());
|
||||
LOG.debug("Correctly got error when reading a table descriptor from the archive directory: " +
|
||||
e.getMessage());
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
public void testCreateTableDescriptorUpdatesIfExistsAlready() throws IOException {
|
||||
Path testdir = UTIL.getDataTestDir(name.getMethodName());
|
||||
TableDescriptor htd = TableDescriptorBuilder.newBuilder(TableName.valueOf(name.getMethodName())).build();
|
||||
TableDescriptor htd =
|
||||
TableDescriptorBuilder.newBuilder(TableName.valueOf(name.getMethodName())).build();
|
||||
FileSystem fs = FileSystem.get(UTIL.getConfiguration());
|
||||
FSTableDescriptors fstd = new FSTableDescriptors(fs, testdir);
|
||||
FSTableDescriptors fstd = new FSTableDescriptors(fs, testDir);
|
||||
assertTrue(fstd.createTableDescriptor(htd));
|
||||
assertFalse(fstd.createTableDescriptor(htd));
|
||||
htd = TableDescriptorBuilder.newBuilder(htd)
|
||||
.setValue(Bytes.toBytes("mykey"), Bytes.toBytes("myValue"))
|
||||
.build();
|
||||
.setValue(Bytes.toBytes("mykey"), Bytes.toBytes("myValue")).build();
|
||||
assertTrue(fstd.createTableDescriptor(htd)); // this will re-create
|
||||
Path tableDir = fstd.getTableDir(htd.getTableName());
|
||||
Path tmpTableDir = new Path(tableDir, FSTableDescriptors.TMP_DIR);
|
||||
FileStatus[] statuses = fs.listStatus(tmpTableDir);
|
||||
assertTrue(statuses.length == 0);
|
||||
|
||||
Path tableDir = CommonFSUtils.getTableDir(testDir, htd.getTableName());
|
||||
assertEquals(htd, FSTableDescriptors.getTableDescriptorFromFs(fs, tableDir));
|
||||
}
|
||||
|
||||
@Test
|
||||
public void testIgnoreBrokenTableDescriptorFiles() throws IOException {
|
||||
TableDescriptor htd = TableDescriptorBuilder.newBuilder(TableName.valueOf(name.getMethodName()))
|
||||
.setColumnFamily(ColumnFamilyDescriptorBuilder.of("cf")).build();
|
||||
TableDescriptor newHtd =
|
||||
TableDescriptorBuilder.newBuilder(TableName.valueOf(name.getMethodName()))
|
||||
.setColumnFamily(ColumnFamilyDescriptorBuilder.of("cf2")).build();
|
||||
assertNotEquals(newHtd, htd);
|
||||
FileSystem fs = FileSystem.get(UTIL.getConfiguration());
|
||||
FSTableDescriptors fstd = new FSTableDescriptors(fs, testDir, false, false);
|
||||
fstd.update(htd);
|
||||
byte[] bytes = TableDescriptorBuilder.toByteArray(newHtd);
|
||||
Path tableDir = CommonFSUtils.getTableDir(testDir, htd.getTableName());
|
||||
Path tableInfoDir = new Path(tableDir, FSTableDescriptors.TABLEINFO_DIR);
|
||||
FileStatus[] statuses = fs.listStatus(tableInfoDir);
|
||||
assertEquals(1, statuses.length);
|
||||
int seqId =
|
||||
FSTableDescriptors.getTableInfoSequenceIdAndFileLength(statuses[0].getPath()).sequenceId + 1;
|
||||
Path brokenFile = new Path(tableInfoDir, FSTableDescriptors.getTableInfoFileName(seqId, bytes));
|
||||
try (FSDataOutputStream out = fs.create(brokenFile)) {
|
||||
out.write(bytes, 0, bytes.length / 2);
|
||||
}
|
||||
assertTrue(fs.exists(brokenFile));
|
||||
TableDescriptor getTd = fstd.get(htd.getTableName());
|
||||
assertEquals(htd, getTd);
|
||||
assertFalse(fs.exists(brokenFile));
|
||||
}
|
||||
|
||||
private static class FSTableDescriptorsTest extends FSTableDescriptors {
|
||||
|
||||
public FSTableDescriptorsTest(FileSystem fs, Path rootdir) {
|
||||
|
|
|
|||
Loading…
Reference in New Issue