Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-27720 TestClusterRestartFailover is flakey due to metrics assertion (#5110) 

Signed-off-by: Duo Zhang <zhangduo@apache.org>
This commit is contained in:
Nick Dimiduk 2023-04-07 23:02:09 -04:00 committed by GitHub
parent 164b8e2600
commit f36587c648
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestClusterRestartFailover.java
View File

@ -141,6 +141,12 @@ public class TestClusterRestartFailover extends AbstractTestRestartCluster {
LOG.info("Setup cluster");
UTIL.startMiniCluster(StartTestingClusterOption.builder().masterClass(HMasterForTest.class)
.numMasters(1).numRegionServers(3).build());
// this test has been flaky. When it is rerun by surefire, the underlying minicluster isn't
// completely cleaned. specifically, the metrics system isn't reset. The result is an otherwise
// successful re-run is failed because there's 8 or 12 SCPcounts instead of the 4 that a
// single run of the test would otherwise produce. Thus, explicitly reset the metrics source
// each time we setup the cluster.
UTIL.getMiniHBaseCluster().getMaster().getMasterMetrics().getMetricsSource().init();
LOG.info("Cluster is up");
UTIL.waitFor(60000, () -> UTIL.getMiniHBaseCluster().getMaster().isInitialized());
LOG.info("Master is up");