From f60b8246e737f0f7e686f7bedd7bd376288d03b0 Mon Sep 17 00:00:00 2001 From: Michael Stack Date: Tue, 22 Jan 2013 20:45:40 +0000 Subject: [PATCH] HBASE-7588 Fix two findbugs warning in MemStoreFlusher; REAPPLIED git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1437154 13f79535-47bb-0310-9956-ffa450edef68 --- .../hbase/regionserver/MemStoreFlusher.java | 26 ++++++++++++++++--- 1 file changed, 22 insertions(+), 4 deletions(-) diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java index 2fcf4cd5c70..0a62d4f838d 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java @@ -500,21 +500,21 @@ class MemStoreFlusher extends HasThread implements FlushRequester { return "flush_queue=" + flushQueue.size(); } - + public String dumpQueue() { StringBuilder queueList = new StringBuilder(); queueList.append("Flush Queue Queue dump:\n"); queueList.append(" Flush Queue:\n"); java.util.Iterator it = flushQueue.iterator(); - + while(it.hasNext()){ queueList.append(" "+it.next().toString()); queueList.append("\n"); } - + return queueList.toString(); } - + interface FlushQueueEntry extends Delayed {} /** @@ -530,6 +530,12 @@ class MemStoreFlusher extends HasThread implements FlushRequester { public int compareTo(Delayed o) { return -1; } + + @Override + public boolean equals(Object obj) { + return (this == obj); + } + } /** @@ -597,5 +603,17 @@ class MemStoreFlusher extends HasThread implements FlushRequester { public String toString() { return "[flush region " + Bytes.toStringBinary(region.getRegionName()) + "]"; } + + @Override + public boolean equals(Object obj) { + if (this == obj) { + return true; + } + if (obj == null || getClass() != obj.getClass()) { + return false; + } + Delayed other = (Delayed) obj; + return compareTo(other) == 0; + } } }