Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-5189 Add metrics to keep track of region-splits in RS 

git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1370583 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Michael Stack 2012-08-07 22:56:05 +00:00
parent 14a2e4c347
commit f807add65b
2 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SplitRequest.java
View File

@ -67,7 +67,7 @@ class SplitRequest implements Runnable {
if (!st.prepare()) return; if (!st.prepare()) return;
try { try {
st.execute(this.server, this.server); st.execute(this.server, this.server);
this.server.getMetrics().incrementSplitSuccessCount(); this.server.getMetrics().incrementSplitSuccessCount(System.currentTimeMillis() - startTime);
} catch (Exception e) { } catch (Exception e) {
if (this.server.isStopping() || this.server.isStopped()) { if (this.server.isStopping() || this.server.isStopped()) {
LOG.info( LOG.info(

15
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java
View File

@ -32,6 +32,7 @@ import org.apache.hadoop.hbase.metrics.ExactCounterMetric;
import org.apache.hadoop.hbase.metrics.HBaseInfo; import org.apache.hadoop.hbase.metrics.HBaseInfo;
import org.apache.hadoop.hbase.metrics.MetricsRate; import org.apache.hadoop.hbase.metrics.MetricsRate;
import org.apache.hadoop.hbase.metrics.histogram.MetricsHistogram; import org.apache.hadoop.hbase.metrics.histogram.MetricsHistogram;
import org.apache.hadoop.hbase.metrics.PersistentMetricsTimeVaryingRate;
import com.yammer.metrics.stats.Snapshot; import com.yammer.metrics.stats.Snapshot;
import org.apache.hadoop.hbase.regionserver.wal.HLog; import org.apache.hadoop.hbase.regionserver.wal.HLog;
import org.apache.hadoop.hbase.util.Pair; import org.apache.hadoop.hbase.util.Pair;
@ -287,11 +288,11 @@ public class RegionServerMetrics implements Updater {
public final MetricsTimeVaryingRate slowHLogAppendTime = public final MetricsTimeVaryingRate slowHLogAppendTime =
new MetricsTimeVaryingRate("slowHLogAppendTime", registry); new MetricsTimeVaryingRate("slowHLogAppendTime", registry);
public final MetricsTimeVaryingLong regionSplitSuccessCount = public final PersistentMetricsTimeVaryingRate regionSplitSuccessCount =
new MetricsTimeVaryingLong("regionSplitSuccessCount", registry); new PersistentMetricsTimeVaryingRate("regionSplitSuccessCount", registry);
public final MetricsTimeVaryingLong regionSplitFailureCount = public final MetricsLongValue regionSplitFailureCount =
new MetricsTimeVaryingLong("regionSplitFailureCount", registry); new MetricsLongValue("regionSplitFailureCount", registry);
/** /**
* Number of times checksum verification failed. * Number of times checksum verification failed.
@ -496,12 +497,12 @@ public class RegionServerMetrics implements Updater {
this.requests.inc(inc); this.requests.inc(inc);
} }
public void incrementSplitSuccessCount() { public void incrementSplitSuccessCount(long time) {
this.regionSplitSuccessCount.inc(); this.regionSplitSuccessCount.inc(time);
} }
public void incrementSplitFailureCount() { public void incrementSplitFailureCount() {
this.regionSplitFailureCount.inc(); this.regionSplitFailureCount.set(this.regionSplitFailureCount.get() + 1);
} }
@Override @Override