Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-15148 Resolve IS2_INCONSISTENT_SYNC findbugs warning in AuthenticationTokenSecretManager (Yu Li)

This commit is contained in:
tedyu 2016-01-22 02:47:49 -08:00
parent b1df2f8c88
commit f9e69b51e1
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/AuthenticationTokenSecretManager.java
View File

@ -285,6 +285,10 @@ public class AuthenticationTokenSecretManager
} }
} }
synchronized long getLastKeyUpdate() {
return lastKeyUpdate;
}
public static SecretKey createSecretKey(byte[] raw) { public static SecretKey createSecretKey(byte[] raw) {
return SecretManager.createSecretKey(raw); return SecretManager.createSecretKey(raw);
} }
@ -338,10 +342,7 @@ public class AuthenticationTokenSecretManager
// clear any expired // clear any expired
removeExpiredKeys(); removeExpiredKeys();
long localLastKeyUpdate; long localLastKeyUpdate = getLastKeyUpdate();
synchronized (this) {
localLastKeyUpdate = lastKeyUpdate;
}
if (localLastKeyUpdate + keyUpdateInterval < now) { if (localLastKeyUpdate + keyUpdateInterval < now) {
// roll a new master key // roll a new master key
rollCurrentKey(); rollCurrentKey();