Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-18731 [compat 1-2] Mark protected methods of QuotaSettings that touch Protobuf internals as IA.Private 

Signed-off-by: Michael Stack <stack@apache.org>
This commit is contained in:
Sean Busbey 2017-09-21 14:04:42 -05:00 committed by Michael Stack
parent eeaa9aee66
commit fa7d0ccb05
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
hbase-client/src/main/java/org/apache/hadoop/hbase/quotas/QuotaSettings.java
View File

@ -49,7 +49,9 @@ public abstract class QuotaSettings {
/** /**
* Convert a QuotaSettings to a protocol buffer SetQuotaRequest. This is used internally by the * Convert a QuotaSettings to a protocol buffer SetQuotaRequest. This is used internally by the
* Admin client to serialize the quota settings and send them to the master. * Admin client to serialize the quota settings and send them to the master.
* @deprecated Removed in HBase 2.0+ as a part of removing protobuf from our API
*/ */
@Deprecated
public static SetQuotaRequest buildSetQuotaRequestProto(final QuotaSettings settings) { public static SetQuotaRequest buildSetQuotaRequestProto(final QuotaSettings settings) {
SetQuotaRequest.Builder builder = SetQuotaRequest.newBuilder(); SetQuotaRequest.Builder builder = SetQuotaRequest.newBuilder();
if (settings.getUserName() != null) { if (settings.getUserName() != null) {
@ -68,7 +70,9 @@ public abstract class QuotaSettings {
/** /**
* Called by toSetQuotaRequestProto() the subclass should implement this method to set the * Called by toSetQuotaRequestProto() the subclass should implement this method to set the
* specific SetQuotaRequest properties. * specific SetQuotaRequest properties.
* @deprecated Removed in HBase 2.0+ as a part of removing protobuf from our API
*/ */
@Deprecated
protected abstract void setupSetQuotaRequest(SetQuotaRequest.Builder builder); protected abstract void setupSetQuotaRequest(SetQuotaRequest.Builder builder);
protected String ownerToString() { protected String ownerToString() {