Apache/hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-11988 AC/VC system table create on postStartMaster fails too often in test; ADD DEBUG

Browse Source
This commit is contained in:
stack 2014-09-16 16:31:57 -07:00
parent e1f8a325fb
commit fc97a1b34c
1 changed files with 11 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
hbase-server/src/main/java/org/apache/hadoop/hbase/master/TableNamespaceManager.java
View File

@ -74,7 +74,7 @@ public class TableNamespaceManager {
private boolean initialized; private boolean initialized;
static final String NS_INIT_TIMEOUT = "hbase.master.namespace.init.timeout"; static final String NS_INIT_TIMEOUT = "hbase.master.namespace.init.timeout";
static final int DEFAULT_NS_INIT_TIMEOUT = 60000; static final int DEFAULT_NS_INIT_TIMEOUT = 300000;
public TableNamespaceManager(MasterServices masterServices) { public TableNamespaceManager(MasterServices masterServices) {
this.masterServices = masterServices; this.masterServices = masterServices;
@ -83,7 +83,7 @@ public class TableNamespaceManager {
public void start() throws IOException { public void start() throws IOException {
if (!MetaTableAccessor.tableExists(masterServices.getShortCircuitConnection(), if (!MetaTableAccessor.tableExists(masterServices.getShortCircuitConnection(),
TableName.NAMESPACE_TABLE_NAME)) { TableName.NAMESPACE_TABLE_NAME)) {
LOG.info("Namespace table not found. Creating..."); LOG.info("Namespace table not found. Creating...");
createNamespaceTable(masterServices); createNamespaceTable(masterServices);
} }
@ -94,10 +94,11 @@ public class TableNamespaceManager {
// So that it should be initialized later on lazily. // So that it should be initialized later on lazily.
long startTime = EnvironmentEdgeManager.currentTime(); long startTime = EnvironmentEdgeManager.currentTime();
int timeout = conf.getInt(NS_INIT_TIMEOUT, DEFAULT_NS_INIT_TIMEOUT); int timeout = conf.getInt(NS_INIT_TIMEOUT, DEFAULT_NS_INIT_TIMEOUT);
while (!isTableAssigned()) { while (!(isTableAssigned() && isTableEnabled())) {
if (EnvironmentEdgeManager.currentTime() - startTime + 100 > timeout) { if (EnvironmentEdgeManager.currentTime() - startTime + 100 > timeout) {
LOG.warn("Timedout waiting for namespace table to be assigned."); // We can't do anything if ns is not online.
return; throw new IOException("Timedout " + timeout + "ms waiting for namespace table to " +
"be assigned and enabled: " + getTableState());
} }
Thread.sleep(100); Thread.sleep(100);
} }
@ -299,10 +300,12 @@ public class TableNamespaceManager {
return false; return false;
} }
private TableState.State getTableState() throws IOException {
return masterServices.getTableStateManager().getTableState(TableName.NAMESPACE_TABLE_NAME);
}
private boolean isTableEnabled() throws IOException { private boolean isTableEnabled() throws IOException {
return masterServices.getTableStateManager().getTableState( return getTableState().equals(TableState.State.ENABLED);
TableName.NAMESPACE_TABLE_NAME
).equals(TableState.State.ENABLED);
} }
private boolean isTableAssigned() { private boolean isTableAssigned() {