Apache/hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-8339 Make sure the StochasticLoadBalancer doesn't run a cost function when not needed

Browse Source 
git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1467517 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
eclark 2013-04-12 23:43:17 +00:00
parent 7667ab5414
commit ffd8cab11b
1 changed files with 32 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

51
hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
View File

@ -370,37 +370,50 @@ public class StochasticLoadBalancer extends BaseLoadBalancer {
* @return a double of a cost associated with the proposed
*/
protected double computeCost(Cluster cluster) {
double moveCost = (moveCostMultiplier > 0) ?
(moveCostMultiplier * computeMoveCost(cluster)) :
0;
double moveCost = moveCostMultiplier * computeMoveCost(cluster);
double regionCountSkewCost = (loadMultiplier > 0) ?
(loadMultiplier * computeSkewLoadCost(cluster)) :
0;
double regionCountSkewCost = loadMultiplier * computeSkewLoadCost(cluster);
double tableSkewCost = tableMultiplier * computeTableSkewLoadCost(cluster);
double localityCost =
localityMultiplier * computeDataLocalityCost(cluster);
double tableSkewCost = (tableMultiplier > 0) ?
(tableMultiplier * computeTableSkewLoadCost(cluster)) :
0;
double localityCost = (localityMultiplier > 0) ?
(localityMultiplier * computeDataLocalityCost(cluster)) :
0;
double memstoreSizeCost =
memStoreSizeMultiplier
* computeRegionLoadCost(cluster, RegionLoadCostType.MEMSTORE_SIZE);
double storefileSizeCost =
storeFileSizeMultiplier
* computeRegionLoadCost(cluster, RegionLoadCostType.STOREFILE_SIZE);
(memStoreSizeMultiplier > 0) ?
(memStoreSizeMultiplier * computeRegionLoadCost(cluster, RegionLoadCostType.MEMSTORE_SIZE)) :
0;
double storefileSizeCost =
(storeFileSizeMultiplier > 0) ?
(storeFileSizeMultiplier * computeRegionLoadCost(cluster, RegionLoadCostType.STOREFILE_SIZE)):
0;
double readRequestCost =
readRequestMultiplier
* computeRegionLoadCost(cluster, RegionLoadCostType.READ_REQUEST);
(readRequestMultiplier > 0) ?
(readRequestMultiplier * computeRegionLoadCost(cluster, RegionLoadCostType.READ_REQUEST)) :
0;
double writeRequestCost =
writeRequestMultiplier
* computeRegionLoadCost(cluster, RegionLoadCostType.WRITE_REQUEST);
(writeRequestMultiplier > 0) ?
(writeRequestMultiplier * computeRegionLoadCost(cluster, RegionLoadCostType.WRITE_REQUEST)) :
0;
double total =
moveCost + regionCountSkewCost + tableSkewCost + localityCost + memstoreSizeCost
+ storefileSizeCost + readRequestCost + writeRequestCost;
moveCost + regionCountSkewCost + tableSkewCost + localityCost + memstoreSizeCost
+ storefileSizeCost + readRequestCost + writeRequestCost;
if (LOG.isTraceEnabled()) {
LOG.trace("Computed weights for a potential balancing total = " + total + " moveCost = "
+ moveCost + " regionCountSkewCost = " + regionCountSkewCost + " tableSkewCost = "
+ tableSkewCost + " localityCost = " + localityCost + " memstoreSizeCost = "
+ memstoreSizeCost + " storefileSizeCost = " + storefileSizeCost);
+ moveCost + " regionCountSkewCost = " + regionCountSkewCost + " tableSkewCost = "
+ tableSkewCost + " localityCost = " + localityCost + " memstoreSizeCost = "
+ memstoreSizeCost + " storefileSizeCost = " + storefileSizeCost);
}
return total;
}