Commit Graph

2514 Commits

Author SHA1 Message Date
Duo Zhang 5b6d9de54c HBASE-27668 PB's parseDelimitedFrom can successfully return when there are not enough bytes (#5059)
Signed-off-by: Viraj Jasani <vjasani@apache.org>
(cherry picked from commit d1fede72c3)
2023-02-28 10:02:46 +08:00
Bryan Beaudreault 53d3e78432
HBASE-27650 Merging empty regions corrupts meta cache (branch-2) (#5038)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2023-02-27 20:40:19 -05:00
Victor 0747f0c934 HBASE-15242: add client side metrics for timeout and remote exceptions. (#5023)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2023-02-24 16:25:41 -08:00
Nihal Jain 4ac84b8aa0
HBASE-27626 Suppress noisy logging in client.ConnectionImplementation (#5019)
Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org>
2023-02-09 10:29:32 -08:00
Bryan Beaudreault 3358db1f97 HBASE-27534 Determine too large requests by response block size rather than just cell size (#5007)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2023-02-05 17:28:53 -05:00
chaijunjie0101 3a98d87030 HBASE-26967 FilterList with FuzzyRowFilter and SingleColumnValueFilter evaluated with operator MUST_PASS_ONE doesn't work as expected(#4820)
Close #4820

Co-authored-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 382681e2d6)
2023-01-29 17:39:39 +08:00
Duo Zhang 35cca16e74 HBASE-27598 Upgrade mockito to 4.x (#4998)
Signed-off-by: Yulin Niu <niuyulin@apache.org>
(cherry picked from commit bd7a78add5)
2023-01-29 12:22:18 +08:00
Andrew Purtell 28da1546e2 HBASE-27561 hbase.master.port is ignored in processing of hbase.masters (#4952)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Reid Chan <reidchan@apache.org>
2023-01-17 13:21:04 -08:00
Bryan Beaudreault 06c7548770
HBASE-27531 AsyncRequestFutureImpl unnecessarily clears meta cache for full server (#4930)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2023-01-10 07:54:17 -05:00
Duo Zhang cdc48fca41 HBASE-27514 Move some persistent states from zookeeper to master region (#4925)
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
(cherry picked from commit dcfde79f7e)
2022-12-22 12:48:21 +08:00
Victor b63e4b73e5 HBASE-27540 add client side counter metrics for failed rpc calls (#4929)
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
2022-12-21 08:51:02 -05:00
Wellington Ramos Chevreuil 012306b62d HBASE-27474 Evict blocks on split/merge; Avoid caching reference/hlinks if compaction is enabled (#4868)
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
(cherry picked from commit 222ec684d6)
2022-12-19 12:05:06 +00:00
Vaibhav Joshi 2e94f6fb50
HBASE-27527 Port HBASE-27498 to branch-2 (#4919)
Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org>
2022-12-12 11:01:09 -08:00
Bri Augenreich d87ab898bf
HBASE-27491: do not clear cache on RejectedExecutionException (#4914)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
2022-12-09 08:45:40 -05:00
Bryan Beaudreault f320ad9354
HBASE-27490 Locating regions for all actions of batch requests can exceed operation timeout (#4908)
Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>
2022-12-06 08:03:23 -05:00
Victor 8c4f0e3fd1
HBASE-27466: Making metrics instance containing one or more connections. (#4874) (#4909)
Signed-off-by: David Manning <67607031+d-c-manning@users.noreply.github.com>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2022-12-05 12:24:15 -08:00
Bri Augenreich 7b4b4ce81e
HBASE-27487: Slow meta can create pathological feedback loop with multigets (#4900)
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-12-01 08:13:47 -05:00
Bri Augenreich 53b4b4e941
HBASE-27494: Fix missing meta cache dropping exception metrics (#4902)
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
2022-11-30 13:03:19 -05:00
Andor Molnár e90a351d0d
HBASE-27347 Port FileWatcher from ZK to autodetect keystore/truststore changes in TLS connections (branch-2) (#4897)
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
2022-11-28 08:06:29 -05:00
LiangJun He 8c2f4b2aaa
HBASE-27444 Add tool commands list_enabled_tables and list_disabled_tables (#4880)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-11-23 10:29:37 +08:00
Bri Augenreich 53e872e5f1
HBASE-26809: Report client backoff time for server overloaded (#4786)
Co-authored-by: Briana Augenreich <baugenreich@hubspot.com>
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
2022-11-15 15:41:08 -05:00
Rushabh Shah ecf3debd42
HBASE-26913 Replication Observability Framework (#4862)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2022-11-08 13:05:42 -08:00
LiangJun He 1530d855ea
HBASE-27448 Add an admin method to get replication enabled state (#4858)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-11-01 11:22:05 +08:00
Duo Zhang 738ed028ad HBASE-27434 Use ${revision} as placeholder for maven version to make it easier to control the version from command line (#4836)
Signed-off-by: GeorryHuang <huangzhuoyue@apache.org>
(cherry picked from commit 2fc879e863)
2022-10-24 12:05:01 +08:00
Andrew Purtell dfaa63890a HBASE-27339 Improve sasl connection failure log message to include server (#4823)
Include the remote server name in the logged exception message when the
connection setup fails in BlockingRpcConnection.

Add an equivalent log line in NettyRpcConnection.

Signed-off-by: Viraj Jasani <vjasani@apache.org>
2022-10-11 10:20:01 -07:00
Duo Zhang 5cab4be075 HBASE-27401 Clean up current broken 'n's in our javadoc (#4812)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
(cherry picked from commit 63cdd026f0)

Conflicts:
	hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManager.java
	hbase-client/src/main/java/org/apache/hadoop/hbase/HRegionLocation.java
	hbase-client/src/main/java/org/apache/hadoop/hbase/client/Append.java
	hbase-client/src/main/java/org/apache/hadoop/hbase/client/Mutation.java
	hbase-client/src/main/java/org/apache/hadoop/hbase/client/Scan.java
	hbase-client/src/main/java/org/apache/hadoop/hbase/filter/SingleColumnValueExcludeFilter.java
	hbase-client/src/main/java/org/apache/hadoop/hbase/filter/SingleColumnValueFilter.java
	hbase-client/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityClient.java
	hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/RequestConverter.java
	hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java
	hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestReplication.java
	hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/client/TestRemoteTable.java
	hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManager.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/HBaseServerBase.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/MasterObserver.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobUtils.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/procedure/flush/RegionServerFlushTableProcedureManager.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Region.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/replication/HBaseReplicationEndpoint.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsSource.java
	hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtil.java
	hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
	hbase-server/src/test/java/org/apache/hadoop/hbase/tool/TestBulkLoadHFilesSplitRecovery.java
	hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftUtilities.java
2022-10-06 22:13:14 +08:00
Bryan Beaudreault af28101ccc HBASE-27381 Still seeing 'Stuck' in static initialization creating RegionInfo instance (#4813)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-10-04 08:29:20 -04:00
Bryan Beaudreault 913ca3ed3c HBASE-27391 Downgrade ERROR log to DEBUG in ConnectionUtils.updateStats (#4804)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-09-28 11:32:15 -04:00
Duo Zhang 9fb3aee22b
HBASE-27373 Fix new spotbugs warnings after upgrading spotbugs to 4.7.2 (#4787) (#4789)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
2022-09-18 18:31:05 +08:00
Duo Zhang 7ae66a1d2e HBASE-27360 The trace related assertions are flaky for async client tests (#4767)
Signed-off-by: GeorryHuang <huangzhuoyue@apache.org>
(cherry picked from commit f3f88ff6c1)
2022-09-09 23:03:05 +08:00
binlijin bfd8501e23
HBASE-27314 Make index block be customized and configured (#4763)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-09-08 09:27:53 +08:00
Andor Molnár 9838c070aa
HBASE-27342 Use Hadoop Credentials API to retrieve passwords of TLS key/trust stores (#4751)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
2022-09-01 10:06:15 +02:00
LiangJun He 6a7a91a256
HBASE-27335 HBase shell hang for a minute when quiting (#4737)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-08-31 11:01:10 +08:00
LiangJun He 1bd0b581cb
HBASE-27104 Add a tool command list_unknownservers (#4714)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-08-22 21:15:47 +08:00
Fantasy-Jay 8a10dbf6c4 HBASE-27268 In trace log mode, the client does not print callId/startTime and the server does not print receiveTime (#4710)
Co-authored-by: jay.zhu <jay.zhu@huolala.cn>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 32c135d8a5)
2022-08-20 21:09:43 +08:00
Duo Zhang c2dff398d3 HBASE-27279 Make SslHandler work with SaslWrapHandler/SaslUnwrapHandler (#4705)
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
Reviewed-by: Andor Molnár <andor@cloudera.com>
(cherry picked from commit 2b9d36869f)

Conflicts:
	hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestNettyTlsIPCRejectPlainText.java
	hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestSecureIPC.java
	hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestTlsWithKerberos.java
2022-08-16 21:37:47 +08:00
SiCheng-Zheng 1b5d20dcf6 HBASE-27301 Add Delete addFamilyVersion timestamp verify (#4700)
Co-authored-by: SiCheng-Zheng <zhengsicheng@jd.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit b531e71455)
2022-08-15 15:23:04 +08:00
Duo Zhang b820188c68 HBASE-27278 Improve TestTlsIPC to reuse existing IPC test code (#4682)
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
(cherry picked from commit 3309108ca7)
2022-08-12 13:21:11 +08:00
Peter Somogyi 3f5076dac5 HBASE-27281 Add default implementation for Connection$getClusterId (#4683)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-08-11 17:21:14 +02:00
Duo Zhang beb7c6d490 HBASE-27283 Use readTO instead of hard coded RpcClient.DEFAULT_SOCKET_TIMEOUT_READ when creating ReadTimeoutHandler in NettyRpcConnection (#4685)
Signed-off-by: Xin Sun <ddupgs@gmail.com
Signed-off-by: GeorryHuang <huangzhuoyue@apache.org>
(cherry picked from commit 5919b30b6d)
2022-08-09 16:22:57 +08:00
Andor Molnár 2821cc518a HBASE-26666 Add native TLS encryption support to RPC server/client (#4666)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
(cherry picked from commit f8dcf07055)

Conflicts:
	hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcClient.java
	hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcServer.java
2022-08-06 19:43:17 -04:00
Duo Zhang 272805c32e HBASE-27271 BufferCallBeforeInitHandler should ignore the flush request (#4676)
Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
(cherry picked from commit fb529e2352)

Conflicts:
	hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java
2022-08-04 22:57:13 +08:00
Nick Dimiduk bcec871959 HBASE-27153 Improvements to read-path tracing
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-08-02 14:09:39 +02:00
Duo Zhang 5e4ddad9a9 HBASE-27185 Addendum fix TestShadeSaslAuthenticationProvider 2022-07-28 17:31:28 +08:00
chenglei 7910f7738f HBASE-27247 TestPerTableCFReplication.testParseTableCFsFromConfig is broken because of ReplicationPeerConfigUtil.parseTableCFsFromConfig (#4658)
Co-authored-by: comnetwork <comnetwork@163.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-07-27 17:55:00 -07:00
Andrew Purtell 29f51c05f0
HBASE-27203 Clean up error-prone findings in hbase-client [branch-2] (#4651)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2022-07-27 15:58:40 -07:00
Duo Zhang 5f231d3fb3 HBASE-27185 Rewrite NettyRpcServer to decode rpc request with netty handler (#4624)
Signed-off-by: Xin Sun <ddupgs@gmail.com>
(cherry picked from commit 0c4263a18b)

Conflicts:
	hbase-client/src/main/java/org/apache/hadoop/hbase/security/NettyHBaseSaslRpcClientHandler.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ServerRpcConnection.java
2022-07-27 09:10:32 +08:00
Duo Zhang 84e7cdb2c0 HBASE-27222 Purge FutureReturnValueIgnored warnings from error prone (#4634)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
(cherry picked from commit 8b091c4061)
2022-07-26 23:45:15 +08:00
Andrew Purtell eef5edb403 HBASE-27204 BlockingRpcClient will hang for 20 seconds when SASL is enabled after finishing negotiation (#4642)
Revert "HBASE-24579: Failed SASL authentication does not result in an exception on client side (#1921)"

This reverts commit bd79c4065c.

When Kerberos authentication succeeds, on the server side, after
receiving the final SASL token from the client, we simply wait for
the client to continue by sending the connection header.
After HBASE-24579, on the client side, an additional readStatus()
was added, which mistakenly assumes that after negotiation has
completed a status code will be sent. However when authentication
has succeeded the server will not send one. As a result the client
will hang and only throw an exception when the configured read
timeout is reached, which is 20 seconds by default.

We cannot unilaterally send the expected additional status code
from the server side because older clients will not expect it. The
first call will fail because the client finds unexpected bytes in
the stream ahead of the call response. Fabricating a call response
also does not seem a viable strategy for backwards compatibility.

The HBASE-24579 change needs to be reconsidered given the
difficult backwards compatibility challenges here.

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2022-07-24 23:06:58 -07:00
Minwoo Kang 5cf9a9b4b1 HBASE-27219 Change JONI encoding in RegexStringComparator (#4632)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-07-19 09:20:55 -07:00