18560 Commits

Author SHA1 Message Date
Peter Somogyi
e239f70f2d HBASE-25970 MOB data loss - incorrect concatenation of MOB_FILE_REFS (#3355)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Signed-off-by: Pankaj Kumar<pankajkumar@apache.org>
2022-08-19 12:17:30 +02:00
Sean Busbey
a9f4ec3759 HBASE-24163 MOB compactor implementations should use format specifiers when calling String.format
Signed-off-by: stack <stack@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: Josh Elser <elserj@apache.org>
2022-08-17 13:58:31 +02:00
Duo Zhang
b269884728 HBASE-27294 Add new hadoop releases in our hadoop checks (#4692)
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
(cherry picked from commit 4a57cbd2cb01b63a93f0171c068b9fd49d239c99)
2022-08-16 21:43:37 +08:00
huaxiangsun
e595f154d1
HBASE-23723 Ensure MOB compaction works in optimized mode after snapshot clone (#4617) (#4704)
* HBASE-23723 Ensure MOB compaction works in optimized mode after snapshot clone (#1446)

* Reorganize MOB compaction tests for more reuse.
* Add tests for mob compaction after snapshot clone operations
* note the original table used to write a given mob hfile and use that to find it later.

Signed-off-by: Esteban Gutierrez <esteban@apache.org>

* spotless:apply to fix HBaseTestingUtility

* Fix error-prone errors

Signed-off-by: Esteban Gutierrez <esteban@apache.org>
Co-authored-by: Sean Busbey <busbey@apache.org>

Signed-off-by: Esteban Gutierrez <esteban@apache.org>
Co-authored-by: Andrew Purtell <apurtell@apache.org>
Co-authored-by: Sean Busbey <busbey@apache.org>
2022-08-15 13:16:00 -07:00
liangxs
3980e6d087 HBASE-26982 Add index and bloom filter statistics of LruBlockCache on… (#4376)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: stack <stack@apache.org>
2022-08-15 11:12:34 -07:00
huaxiangsun
7f6f184f06
HBASE-27296 Some Cell's implementation of toString() such as IndividualBytesFieldCell prints out value and tags which is too verbose (#4695) (#4702)
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
2022-08-15 09:16:51 -07:00
Duo Zhang
7c226727c0 HBASE-27299 Bump minimum hadoop 2 version to 2.10.2 (#4699)
Signed-off-by: Xin Sun <ddupgs@gmail.com>
(cherry picked from commit 60394e95a7ccf39fb86e14981a79e90ce3dd8734)
2022-08-15 18:57:00 +08:00
Duo Zhang
6cedefc192 HBASE-27221 Bump spotless version to 2.24.1 (#4693)
Signed-off-by: Xin Sun <ddupgs@gmail.com>
(cherry picked from commit 9215066e2b8e114fb4e96f1b701a8cbd85638284)
2022-08-15 15:23:40 +08:00
SiCheng-Zheng
0ceb3577fc HBASE-27301 Add Delete addFamilyVersion timestamp verify (#4700)
Co-authored-by: SiCheng-Zheng <zhengsicheng@jd.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit b531e71455423a9f5a5956da90026085dde96117)
2022-08-15 15:23:34 +08:00
dependabot[bot]
da472aac06 HBASE-27298 Bump hadoop version to 3.2.4 (#4696)
Bumps hadoop-common from 3.2.3 to 3.2.4.

---
updated-dependencies:
- dependency-name: org.apache.hadoop:hadoop-common
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Duo Zhang <zhangduo@apache.org>

Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 97fb5cc6d24daf7b62c59972f8b24e788a7edae9)
2022-08-12 14:50:49 +08:00
Peter Somogyi
ad6770652f HBASE-27281 Add default implementation for Connection$getClusterId (#4683)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-08-11 17:21:33 +02:00
Duo Zhang
1040ab4fd6 HBASE-27293 Remove jenkins and personality scripts support for 1.x (#4690)
Signed-off-by: GeorryHuang <huangzhuoyue@apache.org>
(cherry picked from commit bffae99f40f5fb144d52450bfedadfd168a429e0)
2022-08-11 17:10:32 +08:00
Andrew Purtell
18eef2bc69 HBASE-27240 Clean up error-prone findings in hbase-http (#4653)
Signed-off-by: Duo Zhang <zhangduo@apache.org>

(cherry picked from commit 5eaeff5fcdd5c4e42376a56cca02e4cbb56cc3f0)
2022-08-11 14:47:16 +08:00
Masatake Iwasaki
8d7955f06f HBASE-27292. Fix build failure against Hadoop 3.3.4 due to added dependency on okhttp. (#4687)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 00612106b5fa78a0dd198cbcaab610bd8b1be277)
2022-08-10 22:15:36 +08:00
SiCheng-Zheng
5a606837fc HBASE-27248 WALPrettyPrinter add print timestamp (#4659)
Co-authored-by: SiCheng-Zheng <zhengsicheng@jd.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 6b2e9d14a71d3ccbedabf971fe961802d263a995)
2022-08-10 21:31:06 +08:00
Bryan Beaudreault
c0717c7383 HBASE-27241 Add metrics for evaluating cost and effectiveness of bloom filters (#4669)
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
2022-08-09 15:28:43 -04:00
Duo Zhang
187c084cf2 HBASE-27283 Use readTO instead of hard coded RpcClient.DEFAULT_SOCKET_TIMEOUT_READ when creating ReadTimeoutHandler in NettyRpcConnection (#4685)
Signed-off-by: Xin Sun <ddupgs@gmail.com
Signed-off-by: GeorryHuang <huangzhuoyue@apache.org>
(cherry picked from commit 5919b30b6d9e905130033461efc37fae60bab947)
2022-08-09 16:23:08 +08:00
chaijunjie0101
97d87b011f HBASE-27282 CME in AuthManager causes region server crash (#4684)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit d6641626a97529982720de2b73593e294869c4ca)
2022-08-09 09:57:40 +08:00
LiangJun He
45d7562c28 HBASE-27275 graceful_stop.sh unable to restore the balance state (#4680)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit b431652e48e7cd003c7f8cad4eb9e3065cb0b40f)
2022-08-09 09:56:08 +08:00
ryakhovskiy
948b323075 HBASE-26775 - add synchronized modifier to the toString() method of ProcedureEvent.java (#4681)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 74726617b8418f9cd0b1f3ae209cfc42adbf26cd)
2022-08-08 18:06:23 +08:00
Duo Zhang
0a36504848 HBASE-27273 Should stop autoRead and skip all the bytes when rpc request too big (#4679)
Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>
(cherry picked from commit 486d19e99ff4370bc60e0db235508198c84a00e3)
2022-08-06 20:31:38 +08:00
LiangJun He
a7f8dde815 HBASE-27269 The implementation of TestReplicationStatus.waitOnMetricsReport is incorrect (#4678)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 2dc26082be978796046d9124212e8c9d2d8a1f5d)
2022-08-04 23:17:30 +08:00
Duo Zhang
1720ced4c5 HBASE-27271 BufferCallBeforeInitHandler should ignore the flush request (#4676)
Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
(cherry picked from commit fb529e23526eaa250bdd355db3c2f0dedc55c3e8)

Conflicts:
	hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java
2022-08-04 23:03:52 +08:00
Nick Dimiduk
472e81098e HBASE-27153 Improvements to read-path tracing
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-08-02 14:10:05 +02:00
Bryan Beaudreault
7aa46f03f4 HBASE-27257 Remove unnecessary usage of CachedBlocksByFile from RS UI (#4667)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
2022-07-29 15:33:44 -04:00
chenglei
95a2e59618 HBASE-27247 TestPerTableCFReplication.testParseTableCFsFromConfig is broken because of ReplicationPeerConfigUtil.parseTableCFsFromConfig (#4658)
Co-authored-by: comnetwork <comnetwork@163.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-07-27 17:57:09 -07:00
Andrew Purtell
6a169b5079 HBASE-27203 Clean up error-prone findings in hbase-client [branch-2] (#4651)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2022-07-27 15:59:06 -07:00
Andrew Purtell
32cc65ec9d HBASE-27236 Clean up error-prone warnings in hbase-hbtop (#4649)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-07-26 18:05:13 -07:00
Andrew Purtell
15db425ad9 HBASE-27210 Clean up error-prone findings in hbase-endpoint (#4646)
Signed-off-by: Duo Zhang <zhangduo@apache.org>

Conflicts:
	hbase-endpoint/src/test/java/org/apache/hadoop/hbase/client/TestRpcControllerFactory.java
	hbase-endpoint/src/test/java/org/apache/hadoop/hbase/coprocessor/TestSecureExport.java
2022-07-26 17:46:12 -07:00
Andrew Purtell
ce1455c365 HBASE-27087 TestQuotaThrottle times out
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-07-26 14:11:32 -07:00
Bryan Beaudreault
25136c39f9 HBASE-27229 BucketCache statistics should not count evictions by hfile (#4639)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-07-26 17:10:41 -04:00
Duo Zhang
88f957b323 HBASE-27222 Purge FutureReturnValueIgnored warnings from error prone (#4634)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
(cherry picked from commit 8b091c4061220cc4307ef2ed35291f6fe14bbdb0)
2022-07-26 23:45:29 +08:00
Bryan Beaudreault
4e4ebe99c5 HBASE-27225 Add BucketAllocator bucket size statistic logging (#4637)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
2022-07-25 21:02:23 -04:00
Andrew Purtell
f7ffeac554 HBASE-27235 Clean up error-prone warnings in hbase-hadoop-compat (#4648)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-07-25 17:31:05 -07:00
Ramón García Fernández
0ab933f520 HBASE-27179 Issues building with OpenJDK 17 (#4594)
Fix test case failures in org.apache.hadoop.hbase.http.log.TestLogLevel under Openjdk 17 because of a missing export of java.security.jgss/sun.security.krb5.
Removed option --illegal-access=permit ignored since Openjdk 17.

Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit e10c15d0306e678ace8748680527e6eecbf424e5)
2022-07-25 19:23:55 +08:00
Andrew Purtell
9cec74c503 HBASE-27204 BlockingRpcClient will hang for 20 seconds when SASL is enabled after finishing negotiation (#4642)
Revert "HBASE-24579: Failed SASL authentication does not result in an exception on client side (#1921)"

This reverts commit bd79c4065ccb13a5e217d844376b3e7b9489d2fe.

When Kerberos authentication succeeds, on the server side, after
receiving the final SASL token from the client, we simply wait for
the client to continue by sending the connection header.
After HBASE-24579, on the client side, an additional readStatus()
was added, which mistakenly assumes that after negotiation has
completed a status code will be sent. However when authentication
has succeeded the server will not send one. As a result the client
will hang and only throw an exception when the configured read
timeout is reached, which is 20 seconds by default.

We cannot unilaterally send the expected additional status code
from the server side because older clients will not expect it. The
first call will fail because the client finds unexpected bytes in
the stream ahead of the call response. Fabricating a call response
also does not seem a viable strategy for backwards compatibility.

The HBASE-24579 change needs to be reconsidered given the
difficult backwards compatibility challenges here.

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2022-07-24 23:07:01 -07:00
Duo Zhang
a6a75ef43d HBASE-27075 TestUpdateRSGroupConfiguration.testCustomOnlineConfigChangeInRSGroup is flaky (#4636)
Signed-off-by: Xin Sun <ddupgs@gmail.com>
(cherry picked from commit 31fc97edeede08cfc9c8dd9fe22c3775ede2eebb)

Conflicts:
	hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsBase.java
	hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestUpdateRSGroupConfiguration.java
2022-07-21 14:52:59 +08:00
Duo Zhang
cf4da36954 Revert "HBASE-27152 Under compaction mark may leak (#4568)"
This reverts commit 3ebb4360b9bc17c8eed362671c1cba49c3a05697.
2022-07-21 09:04:37 +08:00
Xiaolin Ha
3ebb4360b9 HBASE-27152 Under compaction mark may leak (#4568)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit da27a67a1e3abfa0117b0cf1a59d01b7a2f8ab05)
2022-07-20 08:52:10 +08:00
Minwoo Kang
ee56bcafb4 HBASE-27219 Change JONI encoding in RegexStringComparator (#4632)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-07-19 09:20:59 -07:00
Nihal Jain
25c375e186 HBASE-20499 Replication/Priority executors can use specific max queue length as default value instead of general maxQueueLength
Signed-off-by: tedyu <yuzhihong@gmail.com>
(cherry picked from commit 6d080762ef795adf02dd0ab236c4b3eb73e19a91)
2022-07-19 13:57:47 +08:00
Duo Zhang
9c3528d730 HBASE-27220 Apply the spotless format change in HBASE-27208 to our code base
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-07-19 10:03:26 +08:00
Duo Zhang
aae664b7b5 HBASE-27208 Use spotless to purge the missing summary warnings from error prone (#4628)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
(cherry picked from commit 7484a9163a438f2cd9c4e0ac5ab88b00b3340737)
2022-07-19 09:49:57 +08:00
Andrew Purtell
a321fb2eee HBASE-27195 Clean up netty worker/thread pool configuration (#4619)
The configuration settings "hbase.netty.worker.count" and
"hbase.netty.eventloop.rpcserver.thread.count" appear to duplicate each
other.

Also, formalizes another setting found in NettyEventLoopGroupConfig,
"hbase.netty.nativetransport".

Also, native epoll is not limited to amd64. aarch64 supports it too.

Signed-off-by: Duo Zhang <zhangduo@apache.org>

Conflicts:
	hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcServer.java
2022-07-18 17:43:40 -07:00
Andrew Purtell
23462f88f2 HBASE-27202 Clean up error-prone findings in hbase-balancer (#4623)
On branch-2.5, the affected code is in hbase-server.

Signed-off-by: Duo Zhang <zhangduo@apache.org>

Conflicts:
	hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/RegionLocationFinder.java
2022-07-18 16:01:00 -07:00
Andrew Purtell
0cd5d2dcb2 HBASE-27200 Clean up error-prone findings in hbase-archetypes (#4621)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-07-18 15:42:31 -07:00
Duo Zhang
0a659b18d5 HBASE-27211 Data race in MonitoredTaskImpl could cause split wal failure (#4630)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
Signed-off-by: Xin Sun <ddupgs@gmail.com>
(cherry picked from commit 9ab0b1504f589c78cd4e01895027d2ce954ba7f7)

Conflicts:
	hbase-server/src/main/java/org/apache/hadoop/hbase/monitoring/TaskMonitor.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
2022-07-18 20:07:25 +08:00
Bryan Beaudreault
8f7801c1f1 HBASE-27053 IOException during caching of uncompressed block to the block cache (#4610)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Reviewed-by: wenwj0 <wenweijian2@huawei.com>
2022-07-16 18:09:27 -04:00
Duo Zhang
4a1872b80c HBASE-27192 The retry number for TestSeparateClientZKCluster is too small (#4614)
Signed-off-by: GeorryHuang <huangzhuoyue@apache.org>
(cherry picked from commit 648bb6d0eba64f32a90e8b4df20fe50ffe80dd02)
2022-07-14 08:52:25 +08:00
Andrew Purtell
74e83c840f HBASE-27194 Add test coverage for SimpleRpcServer (#4616)
Add test coverage for SimpleRpcServer.

Improve the way we test both SimpleRpcServer and NettyRpcServer. Use
LoadTestKVGenerator to generate random values with varying sizes between
1000 bytes and 1M bytes, and also to verify them when reading the values
back.

Add secure test coverage for both SimpleRpcServer and NettyRpcServer.

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2022-07-13 11:22:38 -07:00