Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
18,179 Commits 95 Branches 866 Tags 550 MiB
Commit Graph

18179 Commits

Author SHA1 Message Date
Bryan Beaudreault 1dfbd6cd54 HBASE-27225 Add BucketAllocator bucket size statistic logging (#4637) 
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
 2022-07-25 21:07:50 -04:00
Andrew Purtell 33b3bbe5ca HBASE-27204 BlockingRpcClient will hang for 20 seconds when SASL is enabled after finishing negotiation (#4642) 
Revert "HBASE-24579: Failed SASL authentication does not result in an exception on client side (#1921)"

This reverts commit bd79c4065c.

When Kerberos authentication succeeds, on the server side, after
receiving the final SASL token from the client, we simply wait for
the client to continue by sending the connection header.
After HBASE-24579, on the client side, an additional readStatus()
was added, which mistakenly assumes that after negotiation has
completed a status code will be sent. However when authentication
has succeeded the server will not send one. As a result the client
will hang and only throw an exception when the configured read
timeout is reached, which is 20 seconds by default.

We cannot unilaterally send the expected additional status code
from the server side because older clients will not expect it. The
first call will fail because the client finds unexpected bytes in
the stream ahead of the call response. Fabricating a call response
also does not seem a viable strategy for backwards compatibility.

The HBASE-24579 change needs to be reconsidered given the
difficult backwards compatibility challenges here.

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>

Conflicts:
	hbase-client/src/test/java/org/apache/hadoop/hbase/security/TestHBaseSaslRpcClient.java
 2022-07-24 23:09:01 -07:00
Minwoo Kang 0df2cc3c37 HBASE-27219 Change JONI encoding in RegexStringComparator (#4632) 
Signed-off-by: Andrew Purtell <apurtell@apache.org>
 2022-07-19 09:21:11 -07:00
Duo Zhang fb2593b840 HBASE-27220 Apply the spotless format change in HBASE-27208 to our code base 
Signed-off-by: Andrew Purtell <apurtell@apache.org>
 2022-07-19 10:03:16 +08:00
Duo Zhang be6f517d92 HBASE-27208 Use spotless to purge the missing summary warnings from error prone (#4628) 
Signed-off-by: Andrew Purtell <apurtell@apache.org>
(cherry picked from commit 7484a9163a)
 2022-07-19 09:48:43 +08:00
Bryan Beaudreault f5f248d054
HBASE-27205 Fix tests that rely on EnvironmentEdgeManager in branch-2.4 (addendum) (#4631) 
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
 2022-07-18 14:54:26 -04:00
Duo Zhang bc6295e0a5 HBASE-27211 Data race in MonitoredTaskImpl could cause split wal failure (#4630) 
Signed-off-by: Guanghao Zhang <zghao@apache.org>
Signed-off-by: Xin Sun <ddupgs@gmail.com>
(cherry picked from commit 9ab0b1504f)

Conflicts:
	hbase-server/src/main/java/org/apache/hadoop/hbase/monitoring/TaskMonitor.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
 2022-07-18 20:06:12 +08:00
Bryan Beaudreault 33b25ab19a HBASE-27053 IOException during caching of uncompressed block to the block cache (#4610) 
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Reviewed-by: wenwj0 <wenweijian2@huawei.com>
 2022-07-16 18:21:12 -04:00
Bryan Beaudreault cc62da2944
HBASE-27205 Fix tests that rely on EnvironmentEdgeManager in branch-2.4 (#4625) 
Signed-off-by: Andrew Purtell <apurtell@apache.org>
 2022-07-14 16:08:29 -04:00
Duo Zhang 4b3464531a HBASE-27192 The retry number for TestSeparateClientZKCluster is too small (#4614) 
Signed-off-by: GeorryHuang <huangzhuoyue@apache.org>
(cherry picked from commit 648bb6d0eb)
 2022-07-14 08:52:32 +08:00
Duo Zhang b8f71ec487 HBASE-27193 TestZooKeeper is flaky (#4615) 
Signed-off-by: Guanghao Zhang <zghao@apache.org>
(cherry picked from commit 2662607b71)
 2022-07-13 10:34:33 +08:00
Andrew Purtell 3316b48365 HBASE-27161 Improve TestMultiRespectsLimits (#4586) 
TestMultiRespectLimits submits a put with an empty value. This appears
to not be what was intended. Instead, use a single byte.

Signed-off-by: Duo Zhang <zhangduo@apache.org>
 2022-07-12 11:21:04 -07:00
Andrew Purtell 9af341c672 HBASE-27097 SimpleRpcServer is broken (#4613) 
Replace BufferChain#write(channel,int) with a simpler #write(channel)
implementation that does not attempt to "chunk" data to be written. This
method was used exclusively by SimpleRpcServer. The code was unnecessarily
complex and caused short writes when values were large, so was corrected
and simplified. Any difference in performance from this change will be
limited to SimpleRpcServer. Testing under load confirms the fix and does
not show significant regression.

SimpleRpcServer and its related code is now also marked as @Deprecated.

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>

Conflicts:
	hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/SimpleRpcServer.java
 2022-07-12 11:14:42 -07:00
Andrew Purtell ad82104233 Amend HBASE-27180 Fix multiple possible buffer leaks (#4597) 
spotless:apply fix

Signed-off-by: Andrew Purtell <apurtell@apache.org>
 2022-07-12 11:14:42 -07:00
Bryan Beaudreault 7dfed53819 HBASE-27188 Report maxStoreFileCount in jmx (#4609) 
Signed-off-by: Andrew Purtell <apurtell@apache.org>
 2022-07-11 22:19:30 -04:00
Bryan Beaudreault a8a67d4314 HBASE-27186 Report block cache size metrics separately for L1 and L2 (#4608) 
Signed-off-by: Andrew Purtell <apurtell@apache.org>
 2022-07-11 22:09:57 -04:00
Duo Zhang d054c93be1 HBASE-27189 NettyServerRpcConnection is not properly closed when the netty channel is closed (#4611) 
Signed-off-by: Viraj Jasani <vjasani@apache.org>
(cherry picked from commit 5bc8670322)
 2022-07-12 09:47:03 +08:00
Norman Maurer ff710b8252 HBASE-27180 Fix multiple possible buffer leaks (#4597) 
* Fix multiple possible buffer leaks

Motivation:

When using ByteBuf you need to be very careful about releasing it as otherwise you might leak data. There were various places in the code-base where such a leak could happen.

Modifications:

- Fix possible buffer leaks
- Ensure we call touch(...) so its easier to debug buffer leaks

Result:

Fix buffer leaks

* Formatting

* Revert some changes as requested

* revert touch

* Also release checksum and header buffers

Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 2197b3806b)
 2022-07-08 08:32:33 +08:00
Duo Zhang decb96edd2 HBASE-26708 Netty leak detected and OutOfDirectMemoryError due to direct memory buffering with SASL implementation (#4596) 
Co-authored-by: Norman Maurer <norman_maurer@apple.com>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
(cherry picked from commit 816e919e95)
 2022-07-07 16:04:40 +08:00
Ujjawal 60521caf9f
HBASE-27175 - Failure to cleanup WAL split dir log should be at INFO level (#4593) 
Signed-off-by: Viraj Jasani <vjasani@apache.org>
 2022-07-06 16:35:22 -07:00
Bryan Beaudreault 87f22813f4 HBASE-27048 Server side scanner time limit should account for time in queue (#4562) 
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
 2022-07-06 14:21:56 -04:00
tianhang c725dc98e5 HBASE-27171 Fix Annotation Error in HRegionFileSystem (#4588) 
Co-authored-by: Tang Tianhang <tianhang.tang@shopee.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 6031a3a8d4)
 2022-07-06 12:39:35 +08:00
Duo Zhang 2cd30e5f00 HBASE-23330: Fix delegation token fetch with MasterRegistry (#1084) (#4598) 
Signed-off-by: Andrew Purtell <apurtell@apache.org>
(cherry picked from commit d8b3f55518)

Co-authored-by: Bharath Vissapragada <bharathv@apache.org>
 2022-07-06 12:00:09 +08:00
Bryan Beaudreault f36b8eadd8 HBASE-27170 ByteBuffAllocator leak when decompressing blocks near minSizeForReservoirUse (#4592) 
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
 2022-07-04 16:47:47 -04:00
Duo Zhang ab722fe765 HBASE-27169 TestSeparateClientZKCluster is flaky (#4587) 
Signed-off-by: Xin Sun <ddupgs@gmail.com>
(cherry picked from commit 03c23beb57)
 2022-07-01 22:16:52 +08:00
Ishika ba9aa5df99 HBASE-26218 Add logs in Canary tool (#4501) 
Co-authored-by: Ishika Soni <isoni@isoni-ltmag9r.internal.salesforce.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit acfbc3ff7d)
 2022-06-30 23:28:41 +08:00
Duo Zhang aaf6435317 HBASE-27160 ClientZKSyncer.deleteDataForClientZkUntilSuccess should break from the loop when deletion is succeeded (#4579) 
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
(cherry picked from commit d7f6861e8d)
 2022-06-26 15:29:47 +08:00
Bryan Beaudreault 9735b545d1 HBASE-27060 Addendum spotless fix (#4580) 
Signed-off-by: Sean Busbey <busbey@apache.org>
 2022-06-25 17:36:49 -04:00
Bryan Beaudreault 4c24c5d8e0 HBASE-27060 Addendum fix HBaseTestingUtility import in test 2022-06-25 01:49:24 -04:00
Bryan Beaudreault 4e4b3baed4 HBASE-27060 Allow sharing connections between AggregationClient instances (#4566) 
Signed-off-by: Duo Zhang <zhangduo@apache.org>
 2022-06-24 10:51:10 -04:00
Duo Zhang 2472a77b3d HBASE-27146 Avoid CellUtil.cloneRow in MetaCellComparator (#4571) 
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
Reviewed-by: SiCheng-Zheng <643463623@qq.com>
(cherry picked from commit b1691a5318)
 2022-06-24 22:37:46 +08:00
Bryan Beaudreault ce3a37ebac HBASE-26790 getAllRegionLocations can cache locations with null hostname (#4575) 
Signed-off-by: Andrew Purtell <apurtell@apache.org>
 2022-06-24 07:47:37 -04:00
Bryan Beaudreault 207b7d0fe5 HBASE-26945 Quotas causes too much load on meta for large clusters (#4576) 
Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>
 2022-06-23 16:48:52 -04:00
Andrew Purtell 54be59642d Preparing development version 2.4.14-SNAPSHOT 
Signed-off-by: Andrew Purtell <apurtell@apache.org>
 2022-06-22 20:15:07 -07:00
Andrew Purtell 90fb1ddc1d Preparing hbase release 2.4.13RC1; tagging and updates to CHANGES.md and RELEASENOTES.md 
Signed-off-by: Andrew Purtell <apurtell@apache.org>
 2022-06-22 20:15:03 -07:00
Andrew Purtell 847665d9d6 HBASE-27151 TestMultiRespectsLimits.testBlockMultiLimits repeatable failure 
Revert "HBASE-26856 BufferedDataBlockEncoder.OnheapDecodedCell value can get corrupted"

This reverts commit b2f71f2049.
 2022-06-22 20:11:42 -07:00
Andrew Purtell 21481143d8 HBASE-27050 Support unit test pattern matching again (#4447) 
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Sean Busbey <busbey@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
 2022-06-22 19:46:46 -07:00
Andrew Purtell 67592eaba0 Preparing development version 2.4.14-SNAPSHOT 
Signed-off-by: Andrew Purtell <apurtell@apache.org>
 2022-06-22 09:51:14 -07:00
Andrew Purtell 249b5f1170 Preparing hbase release 2.4.13RC0; tagging and updates to CHANGES.md and RELEASENOTES.md 
Signed-off-by: Andrew Purtell <apurtell@apache.org>
 2022-06-22 09:51:11 -07:00
Duo Zhang ba3d86c972 HBASE-27141 Upgrade hbase-thirdparty dependency to 4.1.1 (#4552) 
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Pankaj Kumar <pankajkumar@apache.org>
(cherry picked from commit 9bae50f83c)

Conflicts:
	pom.xml
 2022-06-22 23:38:41 +08:00
Andrew Purtell cd2a7ff1c0 HBASE-27051 TestReplicationSource.testReplicationSourceInitializingMetric is flaky (#4448) 
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
 2022-06-22 14:05:52 +02:00
Tak Lon (Stephen) Wu 230e0a24ec HBASE-27143 Add hbase-unsafe as a dependency for a MR job triggered by hbase shell (#4554) 
Signed-off-by: Duo Zhang <zhangduo@apache.org>
 2022-06-21 13:42:21 -07:00
xiaozhang0319 745cc7bc58 HBASE-27099 The log printing fspread/fsread cost time unit should be milliseconds (#4500) 
Co-authored-by: xiaozhang <issac.zhang@huolala.cn>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit b498efdbc1)
 2022-06-21 00:14:44 +08:00
SiCheng-Zheng eb41b47baa HBASE-27128 when open archiveRetries totalLogSize calculation mistake (#4546) 
Co-authored-by: zhengsicheng <zhengsicheng@jd.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 5833756e5e)
 2022-06-20 23:48:51 +08:00
Xiaolin Ha 51e8f6e6dc
HBASE-27125 The batch size of cleaning expired mob files should have an upper bound(addendum) (#4553) 
fix ut error
 2022-06-20 11:44:31 +08:00
Xiaolin Ha 15a88efb17 HBASE-27125 The batch size of cleaning expired mob files should have an upper bound (#4541) 
Signed-off-by: Duo Zhang <zhangduo@apache.org>
 2022-06-18 02:09:00 +08:00
litao e21f164050
HBASE-27117 Update the method comments for RegionServerAccounting (#4532) 2022-06-16 17:20:19 -07:00
Mohammad Arshad b2f71f2049 HBASE-26856 BufferedDataBlockEncoder.OnheapDecodedCell value can get corrupted 
Created OnheapDecodedCell and OffheapDecodedExtendedCell objects with duplicate copy of
ByteBuffer's underlying array instead of original ByteBuffer

Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Pankaj Kumar<pankajkumar@apache.org>
 2022-06-13 14:21:38 +02:00
Viraj Jasani ae1a0ed94e Revert "HBASE-25709 Close region may stuck when region is compacting and skipped most cells read (#3117)" (#4524) 
This reverts commit f3a48d1910.

Signed-off-by: Andrew Purtell <apurtell@apache.org>

Conflicts:
	hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
 2022-06-12 10:25:28 -07:00
Andrew Purtell fdb91176b5 HBASE-27097 SimpleRpcServer is broken (#4521) 
Apply https://issues.apache.org/jira/secure/attachment/13044874/MultiByteBuff.patch
from Lijin Bin on JIRA.

Co-authored-by: Lijin Bin <binlijin@apache.org>
Signed-off-by: Lijin Bin <binlijin@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
 2022-06-11 10:46:24 -07:00