Commit Graph

7045 Commits

Author SHA1 Message Date
Michael Stack c365c4084e HBASE-20989 Minor, miscellaneous logging fixes
Signed-off-by: Zach York <zyork@amazon.com>
Signed-off-by: Mingliang Liu <liuml07@apache.org>
2018-08-01 11:20:59 -07:00
Xu Cang e7b56c3fa8 HBASE-20794 add INFO level log to createTable operation 2018-08-01 11:04:38 -07:00
Michael Stack 323907f84f HBASE-20893 Data loss if splitting region while ServerCrashProcedure executing ADDENDUM: Rather than rollback, just do region reopens.
In split, reopen the parent if recovered.edits and in merge, reopen the
parent region or regions that happened to have recovered.edits on close.
2018-08-01 00:33:55 -07:00
Andrew Purtell 5a1e02b6dc HBASE-20935 HStore.removeCompactedFiles should log in case it is unable to delete a file (Vishal Khandelwal) 2018-07-31 15:58:05 -07:00
Wei-Chiu Chuang 7be97980f5 HBASE-20950 Helper method to configure secure DFS cluster for tests
Create a helper method HBaseKerberosUtils#setSecuredConfiguration().
TestSecureExport, TestSaslFanOutOneBlockAsyncDFSOutput,
SecureTestCluster and TestThriftSpnegoHttpServer uses this new helper
method.

Signed-off-by: tedyu <yuzhihong@gmail.com>
2018-07-31 13:36:17 -07:00
Reid Chan a8e184dc77 HBASE-20886 [Auth] Support keytab login in hbase client
Signed-off-by: Sean Busbey <busbey@apache.org>
2018-07-31 11:04:40 +08:00
zhangduo df256223d6 HBASE-20538 Upgrade our hadoop versions to 2.7.7 and 3.0.3 2018-07-29 20:18:40 +08:00
zhangduo e8cd3c4b95 Revert "HBASE-20538 Upgrade our hadoop-two.version to 2.7.7 and 3.0.3"
This reverts commit 336fd14e26.
2018-07-29 20:18:23 +08:00
zhangduo 336fd14e26 HBASE-20538 Upgrade our hadoop-two.version to 2.7.7 and 3.0.3 2018-07-29 20:04:57 +08:00
Alex Leblang e963694259
HBASE-19369 Switch to Builder Pattern In WAL
This patch switches to the builder pattern by adding a helper method.
It also checks to ensure that the pattern is available (i.e. that
HBase is running on a hadoop version that supports it).

Amending-Author: Mike Drob <mdrob@apache.org>
Signed-off-by: tedyu <yuzhihong@gmail.com>
Signed-off-by: zhangduo <zhangduo@apache.org>
2018-07-27 23:42:33 -05:00
zhangduo 7178a98258 HBASE-20939 There will be race when we call suspendIfNotReady and then throw ProcedureSuspendedException 2018-07-27 17:27:12 +08:00
Allan Yang 80b40a3b58 HBASE-20921 Possible NPE in ReopenTableRegionsProcedure 2018-07-27 09:36:50 +08:00
zhangduo d43e28dc82 Revert "HBASE-20949 Add logs for debugging"
This reverts commit 8b8de1f8a7.
2018-07-27 08:40:46 +08:00
zhangduo 8b8de1f8a7 HBASE-20949 Add logs for debugging 2018-07-26 22:43:14 +08:00
Mingliang Liu a392c017ed HBASE-20932 Effective MemStoreSize::hashCode()
Signed-off-by: tedyu <yuzhihong@gmail.com>
2018-07-25 14:40:45 -07:00
Peter Somogyi ba5d1c1f28 HBASE-20649 Validate HFiles do not have PREFIX_TREE DataBlockEncoding
Amending-Author: Balazs Meszaros <balazs.meszaros@cloudera.com>

Signed-off-by: Sean Busbey <busbey@apache.org>
2018-07-25 09:00:00 -05:00
Allan Yang 44f6ef1c90 HBASE-20867 RS may get killed while master restarts 2018-07-25 18:16:28 +08:00
zhangduo f3f17fa111 HBASE-20846 Restore procedure locks when master restarts 2018-07-25 14:37:26 +08:00
Saurabh Singh 3a3855aade HBASE-20928 Rewrite calculation of midpoint in binarySearch functions to prevent overflow
Signed-off-by: tedyu <yuzhihong@gmail.com>
2018-07-24 08:16:30 -07:00
huzheng a888af3dc9 HBASE-20565 ColumnRangeFilter combined with ColumnPaginationFilter can produce incorrect result 2018-07-24 10:29:24 +08:00
Allan Yang b631727bdf HBASE-20878 Data loss if merging regions while ServerCrashProcedure executing 2018-07-24 10:00:28 +08:00
Allan Yang 4804483f7e HBASE-20893 Data loss if splitting region while ServerCrashProcedure executing 2018-07-23 14:48:43 +08:00
tedyu 37de961f20 HBASE-20917 MetaTableMetrics#stop references uninitialized requestsMap for non-meta region 2018-07-22 20:50:51 -07:00
Reid Chan 4613f3e8c7 HBASE-20401 Make MAX_WAIT and waitIfNotFinished in CleanerContext configurable (Contributed by Stephen Wu) 2018-07-23 10:30:01 +08:00
Toshihiro Suzuki 682aa69677 HBASE-19893 restore_snapshot is broken in master branch when region splits
Signed-off-by: tedyu <yuzhihong@gmail.com>
2018-07-21 07:37:10 -07:00
Ankit Singhal eb906e20ee HBASE-20908 Infinite loop on regionserver if region replica are reduced
Signed-off-by: tedyu <yuzhihong@gmail.com>
2018-07-20 13:05:11 -07:00
Michael Stack 067388bfd9 HBASE-20914 Trim Master memory usage
Add (weak reference) interning of ServerNames.

Correct Balancer regions x racks matrix.

Make smaller defaults when creating ArrayDeques.
2018-07-20 10:08:55 -07:00
Allan Yang 03e596c669 HBASE-20870 Wrong HBase root dir in ITBLL's Search Tool 2018-07-20 12:17:21 +08:00
Ankit e66a6603e3 HBASE-20672 New metrics ReadRequestRate and WriteRequestRate
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2018-07-19 15:33:09 -07:00
Ankit Singhal b4eacdabd6 HBASE-20901 Reducing region replica has no effect
Signed-off-by: tedyu <yuzhihong@gmail.com>
2018-07-19 13:38:32 -07:00
Mohit Goel 950d6e6fb0 HBASE-6028 Start/Stop compactions at region server level
Add switching on/off of compactions.

Switching off compactions will also interrupt any currently ongoing compactions.
Adds a "compaction_switch" to hbase shell. Switching off compactions will
interrupt any currently ongoing compactions. State set from shell will be
lost on restart. To persist the changes across region servers modify
hbase.regionserver.compaction.enabled in hbase-site.xml and restart.

Signed-off-by: Umesh Agashe <uagashe@cloudera.com>
Signed-off-by: Michael Stack <stack@apache.org>
2018-07-19 06:20:44 -07:00
jack-altiscale 7e599428d3 HBASE-20823. Fix wrong param name in javadoc
Signed-off-by: Reid Chan <reidchan@apache.org>
2018-07-19 18:26:18 +08:00
Yu Li 619e0fdab8 HBASE-20907 Fix Intermittent failure on TestProcedurePriority 2018-07-19 12:00:55 +08:00
Michael Stack 2bf5e46a33 HBASE-20875 MemStoreLABImp::copyIntoCell uses 7% CPU when writing
Make the #copyCellInto method smaller so it inlines; we do it by
checking for the common type early and then taking a code path
that presumes ByteBufferExtendedCell -- avoids checks.
2018-07-18 20:41:19 -07:00
tedyu 2997b6d071 HBASE-20879 Compacting memstore config should handle lower case 2018-07-13 11:19:45 -07:00
Toshihiro Suzuki ce82fd0f47 HBASE-19572 RegionMover should use the configured default port number and not the one from HConstants
Signed-off-by: Reid Chan <reidchan@apache.org>
2018-07-13 10:44:35 +08:00
Toshihiro Suzuki 3fc23fe930 HBASE-20865 CreateTableProcedure is stuck in retry loop in CREATE_TABLE_WRITE_FS_LAYOUT state
Signed-off-by: tedyu <yuzhihong@gmail.com>
2018-07-12 00:15:26 -07:00
Allan Yang 51527f551b HBASE-20860 Merged region's RIT state may not be cleaned after master restart 2018-07-12 10:12:07 +08:00
zhangduo 4a08135dd8 HBASE-20847 Addendum use addFront instead of addBack to add sub procedure 2018-07-12 08:31:05 +08:00
zhangduo a838f7631f HBASE-20847 The parent procedure of RegionTransitionProcedure may not have the table lock 2018-07-11 17:34:35 +08:00
eshcar 1804b6d059 HBASE-20542-ADDENDUM: fix TestHStore 2018-07-11 11:25:49 +03:00
zhaoyuan 1e0650955a HBASE-20697 Can't cache All region locations of the specify table by calling table.getRegionLocator().getAllRegionLocations()
Signed-off-by: Guanghao Zhang <zghao@apache.org>
2018-07-11 10:52:06 +08:00
zhangduo d7561cee50 HBASE-20784 Will lose the SNAPSHOT suffix if we get the version of RS from ServerManager 2018-07-10 09:59:41 +08:00
Balazs Meszaros ad5b4af2c4
HBASE-20833 Modify pre-upgrade coprocessor validator to support table level coprocessors
- -jar parameter now accepts multiple jar files and directories of jar files.
- observer classes can be verified by -class option.
- -table parameter was added to check table level coprocessors.
- -config parameter was added to obtain the coprocessor classes from
  HBase cofiguration.
- -scan option was removed.

Signed-off-by: Mike Drob <mdrob@apache.org>
2018-07-09 11:00:36 -05:00
Abhishek Singh Chouhan 59867eeeeb HBASE-20806 Split style journal for flushes and compactions 2018-07-09 18:25:34 +05:30
zhangduo b5222f88b2 HBASE-20822 TestAsyncNonMetaRegionLocator is flakey 2018-07-09 14:56:37 +08:00
Guanghao Zhang 3bca01854a HBASE-20842 Infinite loop when replaying remote wals
Signed-off-by: zhangduo <zhangduo@apache.org>
2018-07-08 09:35:45 +08:00
Nihal Jain 361be53344 HBASE-20808 (Addendum) Remove duplicate calls for cancelling of chores
Signed-off-by: Reid Chan <reidchan@apache.org>
2018-07-07 00:17:10 +08:00
Nihal Jain 1ade4d2f44 HBASE-20808 Wrong shutdown order between Chores and ChoreService
Signed-off-by: Reid Chan <reidchan@apache.org>
2018-07-06 11:35:03 +08:00
Yu Li ec8947f226 HBASE-20691 Change the default WAL storage policy back to "NONE""
This reverts commit 564c193d61 and added more doc
about why we choose "NONE" as the default.
2018-07-04 13:43:48 +08:00
Guangxu Cheng ee3990e42c HBASE-20474 Show non-RPC tasks on master/regionserver Web UI by default 2018-07-04 10:53:02 +08:00
zhangduo 4366720bd1 HBASE-20839 Fallback to FSHLog if we can not instantiated AsyncFSWAL when user does not specify AsyncFSWAL explicitly 2018-07-04 10:29:24 +08:00
Ted Yu 0f23784182 HBASE-20244 NoSuchMethodException when retrieving private method decryptEncryptedDataEncryptionKey from DFSClient
Signed-off-by: zhangduo <zhangduo@apache.org>
2018-07-03 22:15:18 +08:00
huzheng 0454878e71 HBASE-20789 TestBucketCache#testCacheBlockNextBlockMetadataMissing is flaky 2018-07-03 17:56:34 +08:00
jingyuntian 66ad9fdef8 HBASE-20193 Basic Replication Web UI - Regionserver
Signed-off-by: zhangduo <zhangduo@apache.org>
2018-07-03 15:47:14 +08:00
zhangduo 380350d5bc HBASE-20829 Remove the addFront assertion in MasterProcedureScheduler.doAdd 2018-07-03 15:43:20 +08:00
Josh Elser 13e4578be8 HBASE-20826 Truncate really long RpcServer warnings unless TRACE is on
Signed-off-by: zhangduo <zhangduo@apache.org>
Signed-off-by: Ted Yu <tyu@apache.org>
Signed-off-by: Michael Stack <stack@apache.org>
2018-07-03 10:14:34 +08:00
Ankit Singhal cfdabe9267 HBASE-20817 Infinite loop when executing ReopenTableRegionsProcedure
Signed-off-by: zhangduo <zhangduo@apache.org>
2018-07-02 21:26:14 +08:00
eshcar d822ee3a7c HBASE-20542: Better heap utilization for IMC with MSLABs 2018-07-01 15:31:31 +03:00
zhangduo 112d050609 HBASE-20829 TestSyncReplicationStandbyKillRS is flakey - add error log for debugging 2018-07-01 18:14:10 +08:00
Ankit Singhal 34e23fe425 HBASE-20825 Fix pre and post hooks of CloneSnapshot and RestoreSnapshot for Access checks
Signed-off-by: Josh Elser <elserj@apache.org>
Signed-off-by: Ted Yu <tyu@apache.org>
2018-06-29 16:33:02 -04:00
Pankaj bb8826ca5f HBASE-20357 AccessControlClient API Enhancement
Signed-off-by: tedyu <yuzhihong@gmail.com>
2018-06-28 22:48:58 -07:00
Josh Elser fe75f90be2 HBASE-20792 info:servername and info:sn inconsistent for OPEN region
Signed-off-by: zhangduo <zhangduo@apache.org>
Signed-off-by: Michael Stack <stack@apache.org>
2018-06-29 11:10:40 +08:00
Xu Cang 78e7dd6537 HBASE-19722 Meta query statistics metrics source
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2018-06-28 17:17:23 -07:00
zhangduo 0789e15b5e HBASE-20790 Fix the style issues on branch HBASE-19064 before merging back to master 2018-06-28 18:08:43 +08:00
zhangduo a84cdbd579 HBASE-20783 Addendum fix broken TestSyncReplicationStandBy 2018-06-28 18:08:43 +08:00
Guanghao Zhang 44ca13fe07 HBASE-20569 NPE in RecoverStandbyProcedure.execute 2018-06-28 18:08:43 +08:00
zhangduo 7448b045cc HBASE-20660 Reopen regions using ReopenTableRegionsProcedure 2018-06-28 18:08:43 +08:00
zhangduo 05295abd5b HBASE-20637 Polish the WAL switching when transiting from A to S 2018-06-28 18:08:43 +08:00
zhangduo f67763ffa0 HBASE-20424 Allow writing WAL to local and remote cluster concurrently 2018-06-28 18:08:43 +08:00
zhangduo 603110719d HBASE-20576 Check remote WAL directory when creating peer and transiting peer to A 2018-06-28 18:08:43 +08:00
zhangduo 8a264dfc00 HBASE-19865 Add UT for sync replication peer in DA state 2018-06-28 18:08:43 +08:00
zhangduo ae6c90b4ec HBASE-20426 Give up replicating anything in S state 2018-06-28 18:08:43 +08:00
huzheng 5b6c0d2777 HBASE-20432 Cleanup related resources when remove a sync replication peer 2018-06-28 18:08:43 +08:00
Guanghao Zhang 1bea678ef8 HBASE-20458 Support removing a WAL from LogRoller 2018-06-28 18:08:43 +08:00
zhangduo 2d203c4479 HBASE-20434 Also remove remote wals when peer is in DA state 2018-06-28 18:08:43 +08:00
zhangduo b281328228 HBASE-20456 Support removing a ReplicationSourceShipper for a special wal group 2018-06-28 18:08:43 +08:00
huzheng 66cced16dc HBASE-20425 Do not write the cluster id of the current active cluster when writing remote WAL 2018-06-28 18:08:43 +08:00
huzheng fe339860b5 HBASE-19782 Reject the replication request when peer is DA or A state 2018-06-28 18:08:43 +08:00
zhangduo d91784e666 HBASE-20370 Also remove the wal file in remote cluster when we finish replicating a file 2018-06-28 18:08:43 +08:00
Guanghao Zhang d57c80c415 HBASE-20163 Forbid major compaction when standby cluster replay the remote wals 2018-06-28 18:08:43 +08:00
zhangduo 2389c09d75 HBASE-19079 Support setting up two clusters with A and S stat 2018-06-28 18:08:43 +08:00
Guanghao Zhang c7d1085fa2 HBASE-19999 Remove the SYNC_REPLICATION_ENABLED flag 2018-06-28 18:07:44 +08:00
Guanghao Zhang 183b8d0581 HBASE-19973 Implement a procedure to replay sync replication wal for standby cluster 2018-06-28 18:07:44 +08:00
huzheng 45794d4156 HBASE-19943 Only allow removing sync replication peer which is in DA state 2018-06-28 18:07:44 +08:00
zhangduo 0c97cda2a9 HBASE-19990 Create remote wal directory when transitting to state S 2018-06-28 18:07:44 +08:00
zhangduo a41c549ca4 HBASE-19082 Reject read/write from client but accept write from replication in state S 2018-06-28 18:07:44 +08:00
zhangduo 39dd81a7c6 HBASE-19957 General framework to transit sync replication state 2018-06-28 18:07:44 +08:00
Guanghao Zhang 00e54aae24 HBASE-19935 Only allow table replication for sync replication for now 2018-06-28 18:07:44 +08:00
Guanghao Zhang 1481bd9481 HBASE-19864 Use protobuf instead of enum.ordinal to store SyncReplicationState
Signed-off-by: zhangduo <zhangduo@apache.org>
2018-06-28 18:07:44 +08:00
zhangduo d8842dc3d4 HBASE-19857 Complete the procedure for adding a sync replication peer 2018-06-28 18:07:44 +08:00
Guanghao Zhang 2acebac00e HBASE-19781 Add a new cluster state flag for synchronous replication 2018-06-28 18:07:44 +08:00
zhangduo 274b813e12 HBASE-19747 Introduce a special WALProvider for synchronous replication 2018-06-28 18:07:44 +08:00
Guanghao Zhang b4a1dbf768 HBASE-19078 Add a remote peer cluster wal directory config for synchronous replication
Signed-off-by: zhangduo <zhangduo@apache.org>
2018-06-28 18:07:44 +08:00
zhangduo b3dea0378e HBASE-19083 Introduce a new log writer which can write to two HDFSes 2018-06-28 18:07:44 +08:00
Michael Stack c23e61f20d HBASE-20781 Save recalculating families in a WALEdit batch of Cells
Pass the Set of families through to the WAL rather than recalculate
a Set already known.

Signed-off-by: zhangduo <zhangduo@apache.org>
2018-06-27 22:04:57 -07:00
Reid Chan 74e5c776b3 HBASE-20732 Shutdown scan pool when master is stopped
Signed-off-by: Chia-Ping Tsai <chia7712@gmail.com>
2018-06-28 11:42:18 +08:00
tedyu a8b16ac907 HBASE-20798 Duplicate thread names of StoreFileOpenerThread and StoreFileCloserThread (Zephyr Guo) 2018-06-27 17:21:07 -07:00
Sahil Aggarwal 952bb96c8a
HBASE-19164: Remove UUID.randomUUID in tests.
Signed-off-by: Mike Drob <mdrob@apache.org>
2018-06-27 10:34:16 -05:00
jingyuntian 6a0c67344a HBASE-20194 Basic Replication WebUI - Master
Signed-off-by: zhangduo <zhangduo@apache.org>
2018-06-26 18:26:54 +08:00
Michael Stack 4ba6242a62 HBASE-20780 ServerRpcConnection logging cleanup Get rid of one of the logging lines in ServerRpcConnection by amalgamating all into one new-style log line. 2018-06-25 16:43:11 -07:00
Michael Stack 0db2b628d6
HBASE-20770 WAL cleaner logs way too much; gets clogged when lots of work to do
General log cleanup; setting stuff that can flood the log to TRACE.
2018-06-25 12:13:04 -07:00
Todd Lipcon 025ddce868 HBASE-20403. Fix race between prefetch task and non-pread HFile reads
With prefetch-on-open enabled, the task doing the prefetching was using
non-positional (i.e. streaming) reads. If the main (non-prefetch) thread
was also using non-positional reads, these two would conflict, because
inputstreams are not thread-safe for non-positional reads.

In the case of an encrypted filesystem, this could cause JVM crashes,
etc, as underlying cipher buffers were freed underneath the racing
threads. In the case of a non-encrypted filesystem, less severe errors
would be thrown. The included unit test reproduces the latter case.
2018-06-25 11:54:52 -07:00
zhangduo 9640ebacd4 HBASE-20777 RpcConnection could still remain opened after we shutdown the NettyRpcServer 2018-06-25 14:15:15 +08:00
Michael Stack daad14428d HBASE-20778 Make it so WALPE runs on DFS 2018-06-23 23:33:53 -07:00
zhangduo 55147c7eae HBASE-20775 Addendum disable REGIONS_ON_MASTER for TEstMultiParallel 2018-06-23 17:38:50 +08:00
zhangduo 177458d9d0 HBASE-18569 Add prefetch support for async region locator 2018-06-22 18:25:31 +08:00
tedyu 98245ca6e4 HBASE-20740 StochasticLoadBalancer should consider CoprocessorService request factor when computing cost (chenxu) 2018-06-22 00:26:14 -07:00
zhangduo 7b716c964b HBASE-20752 Make sure the regions are truly reopened after ReopenTableRegionsProcedure 2018-06-22 14:04:33 +08:00
zhangduo 0d784efc37 HBASE-20767 Always close hbaseAdmin along with connection in HBTU 2018-06-21 21:01:19 +08:00
Ankit Singhal 72784c2d83 HBASE-20642 Clients should re-use the same nonce across DDL operations
Also changes modify table operations to help the case where a MTP spans
two master, avoiding the sanity-checks propagating back to the client
unnecessarily.

Signed-off-by: Josh Elser <elserj@apache.org>
Signed-off-by: Michael Stack <stack@apache.org>
2018-06-20 14:56:10 -07:00
Josh Elser e989a9927e HBASE-20706 Prevent MTP from trying to reopen non-OPEN regions
ModifyTableProcedure is using MoveRegionProcedure in a way
that was unintended from the original implementation. As such,
we have to guard against certain usages of it. We know we can
re-open OPEN regions, but regions in OPENING will similarly
soon be OPEN (thus, we want to reopen those regions too).

Signed-off-by: Michael Stack <stack@apache.org>
Signed-off-by: zhangduo <zhangduo@apache.org>
2018-06-20 14:19:28 -07:00
zhangduo 4cb70ea9f5 HBASE-20739 Add priority for SCP 2018-06-20 15:17:07 +08:00
zhangduo c08eff67af HBASE-20742 Always create WAL directory for region server 2018-06-20 14:21:23 +08:00
Michael Stack 21684a32fa HBASE-20745 Log when master proc wal rolls 2018-06-19 19:53:51 -07:00
zhangduo 6dbbd78aa0 HBASE-20708 Remove the usage of RecoverMetaProcedure in master startup 2018-06-19 15:02:10 +08:00
Allan Yang b336da925a HBASE-20727 Persist FlushedSequenceId to speed up WAL split after cluster restart 2018-06-19 09:45:47 +08:00
tedyu ac5bb8155b HBASE-20723 Custom hbase.wal.dir results in data loss because we write recovered edits into a different place than where the recovering region server looks for them 2018-06-15 19:40:48 -07:00
taiynlee 0e43abc78a HBASE-20737 put collection into ArrayList instead of addAll function
Signed-off-by: Chia-Ping Tsai <chia7712@gmail.com>
2018-06-16 03:25:42 +08:00
Xu Cang 86653c708f HBASE-20695 Implement table level RegionServer replication metrics
Signed-off-by: Guanghao Zhang <zghao@apache.org>
2018-06-15 10:38:49 +08:00
jingyuntian 0b28155d27 HBASE-20625 refactor some WALCellCodec related code
Signed-off-by: Guanghao Zhang <zghao@apache.org>
2018-06-14 19:37:01 +08:00
zhangduo 423a0ab71a HBASE-20722 Make RegionServerTracker only depend on children changed event 2018-06-14 08:36:37 +08:00
Guanghao Zhang ec66434380 HBASE-20561 The way we stop a ReplicationSource may cause the RS down 2018-06-13 17:58:59 +08:00
tedyu edf60b965b HBASE-20672 Adding new Metrics readRequestRate and writeRequestRate - revert pending discussion 2018-06-11 18:47:30 -07:00
Balazs Meszaros c323e7bfaa
HBASE-20656 Validate pre-2.0 coprocessors against HBase 2.0+
Signed-off-by: Mike Drob <mdrob@apache.org>
2018-06-11 10:26:58 -05:00
Mike Drob eb13cdd7ed HBASE-20707 Move MissingSwitchDefault case check
Perform this check using error-prone instead of checkstyle because the
former can handle enum switches somewhat more intelligently.
2018-06-11 09:57:50 -05:00
zhangduo 573b57d437 HBASE-20700 Move meta region when server crash can cause the procedure to be stuck 2018-06-11 14:57:31 +08:00
Guanghao Zhang cc7aefe0bb HBASE-20698 (addendum) Master don't record right server version until new started region server call regionServerReport method 2018-06-10 08:23:28 +08:00
Guanghao Zhang 5fd16f3853 HBASE-20698 Master don't record right server version until new started region server call regionServerReport method 2018-06-09 14:40:43 +08:00
Ankit 519236b4af HBASE-20672 Adding new Metrics readRequestRate and writeRequestRate
Signed-off-by: tedyu <yuzhihong@gmail.com>
2018-06-08 13:48:33 -07:00
Nihal Jain 30a052b3e5 HBASE-20699 QuotaCache should cancel the QuotaRefresherChore service inside its stop()
Signed-off-by: tedyu <yuzhihong@gmail.com>
2018-06-08 04:30:52 -07:00
Michael Stack cfeb26d27a HBASE-20702 Processing crash, skip ONLINE'ing empty rows
Signed-off-by: Josh Elser <elserj@apache.org>
2018-06-07 09:54:57 -07:00
eric-maynard 9a80907760 HBASE-20665: Changed log level of HBASE-8547 warning to debug
Closes #77

Signed-off-by: Josh Elser <elserj@apache.org>
Signed-off-by: Sean Busbey <busbey@apache.org>
2018-06-07 11:34:33 -04:00
Peter Somogyi cfd4b7d564 HBASE-20683 Incorrect return value for PreUpgradeValidator
Signed-off-by: Ted Yu <yuzhihong@gmail.com>
Signed-off-by: Chia-Ping Tsai <chia7712@gmail.com>
2018-06-06 20:03:56 +02:00
Andrew Purtell a45763df55 HBASE-20670 NPE in HMaster#isInMaintenanceMode 2018-06-04 15:19:47 -07:00
Michael Stack d99ba62b12 HBASE-20634 Reopen region while server crash can cause the procedure to be stuck; ADDENDUM 2018-06-04 12:39:39 -07:00
Michael Stack 03c0f7fe13 HBASE-20628 SegmentScanner does over-comparing when one flushing
Signed-off-by: eshcar <eshcar@oath.com>
Signed-off-by: anoopsjohn <anoopsamjohn@gmail.com>
2018-06-04 09:50:47 -07:00
zhangduo a472f24d17 HBASE-20634 Reopen region while server crash can cause the procedure to be stuck
A reattempt at fixing HBASE-20173 [AMv2] DisableTableProcedure concurrent to ServerCrashProcedure can deadlock

The scenario is a SCP after processing WALs, goes to assign regions that
were on the crashed server but a concurrent Procedure gets in there
first and tries to unassign a region that was on the crashed server
(could be part of a move procedure or a disable table, etc.). The
unassign happens to run AFTER SCP has released all RPCs that
were going against the crashed server. The unassign fails because the
server is crashed. The unassign used to suspend itself only it would
never be woken up because the server it was going against had already
been processed. Worse, the SCP could not make progress because the
unassign was suspended with the lock on a region that it wanted to
assign held making it so it could make no progress.

In here, we add to the unassign recognition of the state where it is
running post SCP cleanup of RPCs. If present, unassign moves to finish
instead of suspending itself.

Includes a nice unit test made by Duo Zhang that reproduces nicely the
hung scenario.

M hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/FailedRemoteDispatchException.java
 Moved this class back to hbase-procedure where it belongs.

M hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/NoNodeDispatchException.java
M hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/NoServerDispatchException.java
M hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/NullTargetServerDispatchException.java
 Specializiations on FRDE so we can be more particular when we say there
 was a problem.

M hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/RemoteProcedureDispatcher.java
 Change addOperationToNode so we throw exceptions that give more detail
 on issue rather than a mysterious true/false

M hbase-protocol-shaded/src/main/protobuf/MasterProcedure.proto
 Undo SERVER_CRASH_HANDLE_RIT2. Bad idea (from HBASE-20173)

M hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
 Have expireServer return true if it actually queued an expiration. Used
 later in this patch.

M hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
 Hide methods that shouldn't be public. Add a particular check used out
 in unassign procedure failure processing.

M hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/MoveRegionProcedure.java
 Check that server we're to move from is actually online (might
 catch a few silly move requests early).

M hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionStates.java
 Add doc on ServerState. Wasn't being used really. Now we actually stamp
 a Server OFFLINE after its WAL has been split. Means its safe to assign
 since all WALs have been processed. Add methods to update SPLITTING
 and to set it to OFFLINE after splitting done.

M hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionTransitionProcedure.java
 Change logging to be new-style and less repetitive of info.
 Cater to new way in which .addOperationToNode returns info (exceptions
 rather than true/false).

M hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/UnassignProcedure.java
 Add looking for the case where we failed assign AND we should not
 suspend because we will never be woken up because SCP is beyond
 doing this for all stuck RPCs.

 Some cleanup of the failure processing grouping where we can proceed.

 TODOs have been handled in this refactor including the TODO that
 wonders if it possible that there are concurrent fails coming in
 (Yes).

M hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java
 Doc and removing the old HBASE-20173 'fix'.
 Also updating ServerStateNode post WAL splitting so it gets marked
 OFFLINE.

A hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestServerCrashProcedureStuck.java
 Nice test by Duo Zhang.

Signed-off-by: Umesh Agashe <uagashe@cloudera.com>
Signed-off-by: Duo Zhang <palomino219@gmail.com>
Signed-off-by: Mike Drob <mdrob@apache.org>
2018-06-04 09:26:56 -07:00
maoling 1b98a96caa HBASE-19761:Fix Checkstyle errors in hbase-zookeeper
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
2018-06-02 10:08:15 +02:00
Andrew Purtell 9d5004894c HBASE-20667 Rename TestGlobalThrottler to TestReplicationGlobalThrottler 2018-06-01 17:01:16 -07:00
Xu Cang a11701ecc5 HBASE-18116 Replication source in-memory accounting should not include bulk transfer hfiles
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2018-06-01 11:15:47 -07:00
Peter Somogyi 0968668283 HBASE-20592 Create a tool to verify tables do not have prefix tree encoding
Signed-off-by: Mike Drob <mdrob@apache.org>
2018-06-01 19:17:49 +02:00
Andrew Purtell da3ecf1f13 Revert "HBASE-18116 fix replication source in-memory calculation by excluding bulk load file"
This reverts commit 6f3f34227e.
2018-05-31 15:28:28 -07:00
Xu Cang 6f3f34227e HBASE-18116 fix replication source in-memory calculation by excluding bulk load file
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2018-05-31 14:22:12 -07:00
Sean Busbey d909ec55aa HBASE-20444 Addendum keep folks from looking at raw version component array.
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2018-05-31 13:29:52 -05:00
Nihal Jain 40a73a5ca7 HBASE-20653 Add missing observer hooks for region server group to MasterObserver
Signed-off-by: tedyu <yuzhihong@gmail.com>
2018-05-30 21:29:07 -07:00
Andrew Purtell b889c8a221 HBASE-20646 TestWALProcedureStoreOnHDFS failing on branch-1 2018-05-30 14:44:30 -07:00
Andrew Purtell 31ae8dc7f3 Revert "TestWALProcedureStoreOnHDFS failing on branch-1"
This reverts commit dcfa01448c.
2018-05-30 14:44:22 -07:00
Andrew Purtell dcfa01448c TestWALProcedureStoreOnHDFS failing on branch-1 2018-05-30 13:45:38 -07:00
zhangduo 997747076d HBASE-20659 Implement a reopen table regions procedure 2018-05-30 20:03:25 +08:00
tedyu 266b251dfa HBASE-20639 Implement permission checking through AccessController instead of RSGroupAdminEndpoint - revert due to pending discussion 2018-05-29 19:57:51 -07:00
tedyu fe73fe8def HBASE-20653 Add missing observer hooks for region server group to MasterObserver - revert due to pending discussion 2018-05-29 19:42:28 -07:00
Nihal Jain 8d19bbd347 HBASE-20653 Add missing observer hooks for region server group to MasterObserver
Signed-off-by: tedyu <yuzhihong@gmail.com>
2018-05-29 16:37:19 -07:00
Andrew Purtell 06611256ee HBASE-20597 Serialize access to a shared reference to ZooKeeperWatcher in HBaseReplicationEndpoint 2018-05-29 11:29:05 -07:00
Andrew Purtell 807c905f90 Revert "HBASE-20597 Use a lock to serialize access to a shared reference to ZooKeeperWatcher in HBaseReplicationEndpoint"
This reverts commit 9fbce1668b.
2018-05-29 11:24:11 -07:00
Nihal Jain 7ff29d8e00 HBASE-20633 Dropping a table containing a disable violation policy fails to remove the quota upon table delete
Signed-off-by: Josh Elser <elserj@apache.org>
Signed-off-by: Michael Stack <stack@apache.org>
2018-05-29 11:33:56 -04:00
Mike Drob a110e1eff5 HBASE-20478 Update checkstyle to v8.2
Cannot go to latest (8.9) yet due to
  https://github.com/checkstyle/checkstyle/issues/5279

* move hbaseanti import checks to checkstyle
* implment a few missing equals checks, and ignore one
* fix lots of javadoc errors

Signed-off-by: Sean Busbey <busbey@apache.org>
2018-05-29 10:12:31 -05:00
eshcar 42be553433 HBASE-20390 ADDENDUM 2: fix TestHRegionWithInMemoryFlush OOME 2018-05-29 16:27:20 +03:00
Apekshit Sharma 05f57f4c03 HBASE-20652 Remove internal uses of some deprecated MasterObserver hooks
Remove internal uses of these hooks:
preModifyNamespace
postModifyNamespace
preModifyTable
postModifyTable
preModifyTableAction
postCompletedModifyTableAction

Signed-off-by: tedyu <yuzhihong@gmail.com>
2018-05-28 21:10:52 -07:00
huzheng 81228f72d0 HBASE-20533 Fix the flaky TestAssignmentManagerMetrics 2018-05-29 09:38:47 +08:00
eshcar 1cd2b56802 HBASE-20390-ADDENDUM: fix TestHRegionWithInMemoryFlush OOME 2018-05-28 16:10:53 +03:00
Nihal Jain 9bd4b04ca8 HBASE-20639 Implement permission checking through AccessController instead of RSGroupAdminEndpoint
Signed-off-by: tedyu <yuzhihong@gmail.com>
2018-05-27 11:29:26 -07:00
eshcar 1eabbb4295 HBASE-20390: IMC Default Parameters for 2.0.0 2018-05-26 22:57:28 +03:00
Toshihiro Suzuki b1089e8310 HBASE-20648 HBASE-19364 "Truncate_preserve fails with table when replica region > 1" for master branch
Signed-off-by: tedyu <yuzhihong@gmail.com>
2018-05-25 07:52:40 -07:00
meiyi 36f3d9432a HBASE-20518 Need to serialize the enabled field for UpdatePeerConfigProcedure
Signed-off-by: zhangduo <zhangduo@apache.org>
2018-05-25 14:36:16 +08:00
Thiruvel Thirumoolan 1fbce10ff4 HBASE-20548 Master fails to startup on large clusters, refreshing block distribution
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2018-05-24 15:47:24 -07:00
Toshihiro Suzuki 554d513f50 HBASE-20616 TruncateTableProcedure is stuck in retry loop in TRUNCATE_TABLE_CREATE_FS_LAYOUT state
Signed-off-by: tedyu <yuzhihong@gmail.com>
2018-05-24 15:16:30 -07:00
Nihal Jain 09dac89908 HBASE-20588 Space quota change after quota violation doesn't seem to take in effect
Signed-off-by: Josh Elser <elserj@apache.org>
2018-05-24 12:40:55 -04:00
Guanghao Zhang 320a3332e0 HBASE-20589 Don't need to assign meta to a new RS when standby master become active 2018-05-24 11:26:48 +08:00
zhangduo ee540c9f9e HBASE-20624 Race in ReplicationSource which causes walEntryFilter being null when creating new shipper 2018-05-24 10:48:29 +08:00
Andrew Purtell 9fbce1668b HBASE-20597 Use a lock to serialize access to a shared reference to ZooKeeperWatcher in HBaseReplicationEndpoint 2018-05-23 16:46:22 -07:00
Michael Stack 079f168c5c HBASE-20620 HBASE-20564 Tighter ByteBufferKeyValue Cell Comparator; part 2
Adds new stripped-down, faster ByteBufferKeyValue comparator
(BBKV is the base Cell-type in hbase2). Creates an instance
of new Comparator each time we create new memstore rather
than use the universal CellComparator.

Remove unused and unneeded Interfaces from Cell base type.
2018-05-23 13:20:47 -07:00
huzheng 5721150c6d HBASE-20612 TestReplicationKillSlaveRSWithSeparateOldWALs sometimes fail because it uses an expired cluster conn 2018-05-23 12:07:01 +08:00
tedyu 6c1097e92f HBASE-20609 SnapshotHFileCleaner#init should check that params is not null 2018-05-21 18:36:38 -07:00
jingyuntian c9f8c3436f HBASE-20579 Improve snapshot manifest copy in ExportSnapshot
Signed-off-by: tedyu <yuzhihong@gmail.com>
2018-05-18 06:42:12 -07:00
Guanghao Zhang 0836b0719a HBASE-20583 SplitLogWorker should handle FileNotFoundException when split a wal 2018-05-18 14:29:41 +08:00
Balazs Meszaros 6148b4785d HBASE-20571 JMXJsonServlet generates invalid JSON if it has NaN in metrics
- CacheStats won't generate NaN metrics.
- JSONBean class will serialize special floating point values as
  "NaN", "Infinity" or "-Infinity"

Signed-off-by: Andrew Purtell <apurtell@apache.org>
2018-05-16 12:20:39 -07:00
Apekshit Sharma 8c9825a030 HBASE-20567 Pass both old and new descriptors to pre/post hooks of modify operations for table and namespace.
Signed-off-by: Mike Drob <mdrob@apache.org>
2018-05-16 14:03:18 -05:00
Michael Stack 060b8aca86
HBASE-20520 Failed effort upping default HDFS blocksize, hbase.regionserver.hlog.blocksize 2018-05-16 09:19:24 -07:00
zhangduo ab53329cb3 HBASE-20585 Need to clear peer map when clearing MasterProcedureScheduler 2018-05-16 08:46:29 +08:00
zhangduo 26babcf013 HBASE-20457 Return immediately for a scan rpc call when we want to switch from pread to stream 2018-05-15 20:56:20 +08:00
Zach York d2daada970 HBASE-20447 Only fail cacheBlock if block collisions aren't related to next block metadata
When we pread, we don't force the read to read all of the next block header.
However, when we get into a race condition where two opener threads try to
cache the same block and one thread read all of the next block header and
the other one didn't, it will fail the open process. This is especially important
in a splitting case where it will potentially fail the split process.
Instead, in the caches, we should only fail if the required blocks are different.

Signed-off-by: Andrew Purtell <apurtell@apache.org>
2018-05-14 17:16:54 -07:00
huzheng eabe672ebd HBASE-20560 Revisit the TestReplicationDroppedTables ut 2018-05-14 19:12:43 +08:00
Michael Stack 021f66d11d
HBASE-20411 Ameliorate MutableSegment synchronize
Change the MemStore size accounting so we don't synchronize across three
volatiles applying deltas. Instead:

 + Make MemStoreSize, a datastructure of our memstore size longs, immutable.
 + Undo MemStoreSizing being an instance of MemStoreSize; instead it has-a.
 + Make two MemStoreSizing implementations; one thread-safe, the other not.
 + Let all memory sizing longs run independent, untied by
   synchronize (Huaxiang and Anoop suggestion) using atomiclongs.
 + Review all use of MemStoreSizing. Many are single-threaded and do
   not need to be synchronized; use the non-thread safe counter.

TODO: Use this technique accounting at the global level too.
2018-05-12 02:17:50 +01:00
Sean Busbey 8ba2a7eeb9 HBASE-20544 Make HBTU default to random ports.
Signed-off-by: Umesh Agashe <uagashe@cloudera.com>
Signed-off-by: Josh Elser <elserj@apache.org>
2018-05-09 23:35:20 -07:00
Thiruvel Thirumoolan a67909d3d6 HBASE-20545 Improve performance of BaseLoadBalancer.retainAssignment
Signed-off-by: tedyu <yuzhihong@gmail.com>
2018-05-09 19:48:27 -07:00
Andrew Purtell 32dd633b98 HBASE-20554 "WALs outstanding" message from CleanerChore is noisy 2018-05-09 19:08:35 -07:00
Zach York 9c046c091c HBASE-20204 Add locking to RefreshFileConnections in BucketCache
This is a follow-up to HBASE-20141 where Anoop suggested adding locking
for refreshing channels.
2018-05-09 14:01:51 -07:00
Michael Stack 4f2dfd3877 HBASE-20539 Disable IMC; part 2
Set default for in-memory compaction to NONE. PE was using
this value creating its table. Add test to ensure expected
default.
2018-05-09 06:30:28 -07:00
Nihal Jain f8281aa208 HBASE-20485 Copy constructor of Scan doesn't copy the readType and replicaId
Signed-off-by: Chia-Ping Tsai <chia7712@gmail.com>
2018-05-09 16:39:57 +08:00
Guanghao Zhang 3a2a76f6f8 HBASE-20536 Make TestRegionServerAccounting stable and it should not use absolute number 2018-05-08 08:20:48 +08:00
Michael Stack bb1a935636 HBASE-20538 TestSaslFanOutOneBlockAsyncDFSOutput failing: UnrecoverableKeyException: Rejected by the jceks.key.serialFilter or jdk.serialFilter property
Disable test TestSaslFanOutOneBlockAsyncDFSOutput for the moment.
Depends on HDFS-13494
2018-05-07 09:54:32 -07:00
huzheng 971f5350e8 HBASE-20531 RS may throw NPE when close meta regions in shutdown procedure. 2018-05-06 11:18:23 +08:00
jingyuntian 87f5b5f341 HBASE-20378 Provide a hbck option to cleanup replication barrier for a table
Signed-off-by: zhangduo <zhangduo@apache.org>
2018-05-04 15:27:33 +08:00
huzheng 6225b4a492 HBASE-20481 Replicate entries from same region serially in ReplicationEndpoint for serial replication 2018-05-04 15:22:02 +08:00
Guanghao Zhang 9b9f851470 HBASE-20524 Need to clear metrics when ReplicationSourceManager refresh replication sources 2018-05-04 14:31:41 +08:00
Michael Stack 09ca619389
HBASE-20507 Do not need to call recoverLease on the broken file when we fail to create a wal writer 2018-05-03 12:30:13 -07:00
Chia-Ping Tsai 4cb444e77b
HBASE-20169 NPE when calling HBTU.shutdownMiniCluster (TestAssignmentManagerMetrics is flakey); AMENDMENT 2018-05-02 16:14:58 -07:00
Umesh Agashe c4b4023b60 HBASE-20514 On Master restart if table is stuck in DISABLING state, CLOSED regions should not be considered stuck in-transition
On startup CLOSED regions of DISABLED and DISABLING tables are treated the same way as not in-transition.
2018-05-02 12:18:24 -07:00
tedyu 2e9b96e4f1 HBASE-20414 TestLockProcedure#testMultipleLocks may fail on slow machine 2018-05-02 06:39:51 -07:00