Commit Graph

5731 Commits

Author SHA1 Message Date
Ramkrishna db5953c6fe HBASE-17333 HBASE-17294 always ensures CompactingMemstore is default (Ram) 2016-12-20 11:01:27 +05:30
binlijin b7bde350a1 HBASE-17332 Replace HashMap to Array for DataBlockEncoding.idToEncoding 2016-12-20 09:32:28 +08:00
zhangduo d53f012bb7 Revert "HBASE-17081 Flush the entire CompactingMemStore content to disk (Anastasia"
Revert to address tests failure.

This reverts commit a2a7618d26.
2016-12-16 18:49:48 +08:00
tedyu 665fe3eef1 HBASE-17331 Avoid busy waiting in ThrottledInputStream (ChiaPing Tsai) 2016-12-18 08:15:15 -08:00
zhangduo f041306cda HBASE-17282 Reduce the redundant requests to meta table 2016-12-18 08:52:06 +08:00
Michael Stack da356069f2 HBASE-17149 Procedure v2 - Fix nonce submission
Signed-off-by: Michael Stack <stack@apache.org>
2016-12-16 21:41:18 -08:00
tedyu 2c107e4d08 HBASE-15432 TableInputFormat - support multi column family scan (Xuesen Liang) 2016-12-16 18:04:55 -08:00
tedyu 49b0bab504 HBASE-17292 Add observer notification before bulk loaded hfile is moved - addendum properly handles copied hfile 2016-12-16 15:31:30 -08:00
Michael Stack c3ce02d592 HBASE-17326 Fix findbugs warning in BufferedMutatorParams Fix above and the other hbase-server findbugs complaint about null-check 2016-12-16 13:47:58 -08:00
binlijin 6acbee179f HBASE-16398 optimize HRegion computeHDFSBlocksDistribution 2016-12-16 11:02:27 +08:00
tedyu 35f0718a41 HBASE-17292 Add observer notification before bulk loaded hfile is moved to region directory 2016-12-15 09:43:22 -08:00
Ramkrishna d1147eeb7e HBASE-15787 Change the flush related heuristics to work with offheap size
configured (Ram)
2016-12-15 22:49:52 +05:30
Ramkrishna a2a7618d26 HBASE-17081 Flush the entire CompactingMemStore content to disk (Anastasia
Braginsky)
2016-12-15 22:02:05 +05:30
tedyu 401e83cee3 HBASE-17318 Increment does not add new column if the increment amount is zero at first time writing (Guangxu Cheng) 2016-12-15 07:06:37 -08:00
anoopsamjohn f9750f2122 HBASE-17298 remove unused code in HRegion#doMiniBatchMutation. (huaxiang sun) 2016-12-15 15:54:49 +05:30
tedyu a5a6036883 HBASE-17309 Fix connection leaks in TestAcidGuarantees (huaxiang sun) 2016-12-14 20:03:44 -08:00
eshcar 691f266fc2 HBASE-17316: Addendum of HBASE-17294
Signed-off-by: Michael Stack <stack@apache.org>
2016-12-14 08:17:57 -08:00
eshcar a9310436d5 HBASE-17294: External configuration for memory compaction
Signed-off-by: Michael Stack <stack@apache.org>
2016-12-13 17:16:00 -08:00
tedyu de98f68408 HBASE-17302 The region flush request disappeared from flushQueue (Guangxu Cheng) 2016-12-13 12:45:09 -08:00
tedyu 2333596279 HBASE-17296 Provide per peer throttling for replication (Guanghao Zhang) 2016-12-13 04:20:20 -08:00
tedyu adb319f5c2 HBASE-17297 Single Filter in parenthesis cannot be parsed correctly (Xuesen Liang) 2016-12-12 12:07:34 -08:00
Jingcheng Du 1615f45b31 HBASE-17237 Override the correct compact method in HMobStore 2016-12-12 11:54:21 +08:00
tedyu 67420fe21d HBASE-16336 Removing peers seems to be leaving spare queues (Guanghao Zhang) 2016-12-10 04:33:40 -08:00
Josh Elser b554e05410 HBASE-17276 Only log stacktraces for exceptions once for updates in a batch
For large batches of updates, repeatedly logging WrongRegionExceptions,
FailedSanityCheckExceptions, and/or NoSuchColumnFamilyExceptions can
easily dominate the contents of a RegionServer log. After the first
occurence of logging the full exception, switch to logging only the
message on the exception.
2016-12-09 14:28:00 -08:00
zhangduo b3ae87bd7d HBASE-17251 Add a timeout parameter when locating region 2016-12-08 09:55:29 +08:00
Thiruvel Thirumoolan c1293cc91e HBASE-16941: FavoredNodes - Split/Merge code paths
Signed-off-by: Francis Liu <toffer@apache.org>
2016-12-07 16:38:48 -08:00
Jerry He 75567f828c HBASE-15437 Response size calculated in RPCServer for warning tooLarge responses does NOT count CellScanner payload 2016-12-07 14:47:10 -08:00
Matteo Bertozzi 1eb24e4e8e HBASE-17260 Procedure v2 - Add setOwner() overload taking a User instance 2016-12-06 10:32:43 -08:00
anoopsamjohn f112427425 HBASE-17207 Arrays.asList() with too few arguments. (John Leach) 2016-12-06 14:42:14 +05:30
Clay Baenziger c7b8b63cd1 HBASE-16700 Allow for coprocessor whitelisting
Signed-off-by: Enis Soztutar <enis@apache.org>
2016-12-05 14:46:15 -08:00
tedyu 3190605801 HBASE-17256 Rpc handler monitoring will be removed when the task queue is full (Guangxu Cheng) 2016-12-05 11:32:17 -08:00
Jerry He 39653862a4 HBASE-17221 Abstract out an interface for RpcServer.Call 2016-12-05 10:21:55 -08:00
Ramkrishna 94302a3d26 HBASE-17239 Add UnsafeByteOperations#wrap(ByteInput, int offset, int len)
API (Ram)
2016-12-05 15:13:04 +05:30
Jingcheng Du 26c2d93f77 HBASE-16841 Data loss in MOB files after cloning a snapshot and deleting that snapshot 2016-12-05 16:22:10 +08:00
anoopsamjohn e10baacd3e HBASE-17245 Replace HTableDescriptor#htd.getColumnFamilies().length with a low-cost implementation. (huaxiang sun) 2016-12-05 13:28:57 +05:30
tedyu 0d6b872d9d HBASE-17241 Avoid compacting already compacted mob files with _del files (huaxiang sun) 2016-12-04 20:23:06 -08:00
John Leach 42ff4a7164 HBASE-17231 Region#getCellCompartor -> Region#getCellComparator
Signed-off-by: Michael Stack <stack@apache.org>
2016-12-03 16:07:42 -08:00
Huaxiang Sun 03423fec6b HBASE-17243 Reuse CompactionPartitionId and avoid creating MobFileName in PartitionedMobCompactor to avoid unnecessary new objects (addendum)
Signed-off-by: Matteo Bertozzi <matteo.bertozzi@cloudera.com>
2016-12-03 07:19:02 -08:00
Huaxiang Sun efcd15bf67 HBASE-17243 Reuse CompactionPartitionId and avoid creating MobFileName in PartitionedMobCompactor to avoid unnecessary new objects
Signed-off-by: Matteo Bertozzi <matteo.bertozzi@cloudera.com>
2016-12-03 03:48:23 -08:00
Michael Stack 7775feda05 HBASE-17194 Assign the new region to the idle server after splitting (ChiaPing Tsai) 2016-12-02 11:34:14 -08:00
Michael Stack 4a20361f1a HBASE-17184 Revert "Code cleanup of LruBlockCache"
Revert "Revert "Code cleanup of LruBlockCache""
This is a revert of a revert; i.e. it is putting the change
back only this time we add the missing JIRA number

This reverts commit f3524a06bb.
2016-12-02 11:19:07 -08:00
Michael Stack f3524a06bb Revert "Code cleanup of LruBlockCache"
Missing JIRA number

This reverts commit ad857d1b77.
2016-12-02 11:18:42 -08:00
binlijin 9c13219f0d HBASE-17232 Replace HashSet with ArrayList to accumulate delayed scanners in KVHeap and StoreScanner. 2016-12-02 21:10:37 +08:00
anoopsamjohn 4b3ffffa09 HBASE-17161 MOB : Make ref cell creation more efficient. 2016-12-02 17:30:34 +05:30
Ramkrishna cb5c4c146f HBASE-17235 Improvement in creation of CIS for onheap buffer cases (Ram) 2016-12-02 14:07:16 +05:30
Ramkrishna 3b72b69d0e HBASE-17191 Make use of UnsafeByteOperations#unsafeWrap(ByteBuffer buffer)
in PBUtil#toCell(Cell cell) (Ram)
2016-12-02 12:48:06 +05:30
Stephen Yuan Jiang 0a24077841 HBASE-16119 Procedure v2 - Reimplement Merge region (Stephen Yuan Jiang) 2016-12-01 22:41:15 -08:00
Apekshit Sharma 37b30d93d8 HBASE-17111 Use Apache CLI in SnapshotInfo tool.
Change-Id: Ifd4b0200ba58737c5583dfbcf23f2549c4f233d0
2016-12-01 17:53:01 -08:00
Guanghao Zhang b3d8d06703 HBASE-17205 Add a metric for the duration of region in transition 2016-12-01 10:13:37 -08:00
Jonathan M Hsieh eeaea4aea3 HBASE-17224 Fix lots of spelling errors in HBase logging and exception messages (Grant Sohn) 2016-12-01 08:57:16 -08:00
zhangduo 540ede376b HBASE-16648 [JDK8] Use computeIfAbsent instead of get and putIfAbsent 2016-12-01 21:17:55 +08:00
zhangduo fb789b340c HBASE-17206 FSHLog may roll a new writer successfully with unflushed entries 2016-12-01 14:15:03 +08:00
John Leach 37d7b57128 HBASE-17216 Fields that can safetly be made static 2016-11-30 22:03:35 -08:00
Charlie Qiangeng Xu b2086873a9 HBASE-17110 Improve SimpleLoadBalancer to always take server-level balance into account
Signed-off-by: Yu Li <liyu@apache.org>
2016-12-01 12:12:16 +08:00
Enis Soztutar b6f5d5b85f HBASE-17151 New API to create HFile.Reader without instantiating block cache (Vladimir Rodionov) 2016-11-30 17:04:31 -08:00
Lars Francke ad857d1b77 Code cleanup of LruBlockCache
Signed-off-by: Michael Stack <stack@apache.org>
2016-11-30 12:57:14 -08:00
Guanghao Zhang ea912478e2 HBASE-17178 Add region balance throttling
Signed-off-by: Phil Yang <yangzhe1991@apache.org>
2016-11-30 18:03:15 +08:00
zhangduo 890fcbd0e6 HBASE-17167 Pass mvcc to client when scan 2016-11-30 10:11:04 +08:00
Ramkrishna 7c43a23c07 HBASE-17012 Handle Offheap cells in CompressedKvEncoder (Ram) 2016-11-29 22:27:45 +05:30
Ashu Pachauri 7bcbac91a2 HBASE-16302 age of last shipped op and age of last applied op should be histograms
Signed-off-by: Ashish Singhi <ashishsinghi@apache.org>
2016-11-29 13:51:32 +05:30
Stephen Yuan Jiang d87df9209a HBASE-17189 TestMasterObserver#wasModifyTableActionCalled uses wrong variables (Stephen Yuan Jiang) 2016-11-28 23:09:42 -08:00
Stephen Yuan Jiang b2d3fa1a8a HBASE-17186 MasterProcedureTestingUtility#testRecoveryAndDoubleExecution displays stale procedure state info (Stephen Yuan Jiang) 2016-11-28 23:00:51 -08:00
Ramkrishna 51d9bac42b HBASE-17048 Calcuate suitable ByteBuf size when allocating send buffer in
FanOutOneBlockAsyncDFSOutput (Ram)
2016-11-29 09:12:47 +05:30
Guanghao Zhang cc03f7ad53 HBASE-16561 Add metrics about read/write/scan queue length and active read/write/scan handler count
Signed-off-by: zhangduo <zhangduo@apache.org>
2016-11-29 09:43:30 +08:00
Michael Stack 3d5e686070 HBASE-17072 CPU usage starts to climb up to 90-100% when using G1GC
Removes ThreadLocal. Uses AtomicReference instead (based on patch
posted up in HBASE-10676 "Removing ThreadLocal of PrefetchedHeader in
HFileBlock.FSReaderV2 make higher perforamce of scan")

Signed-off-by: Michael Stack <stack@apache.org>
2016-11-28 09:51:05 -08:00
Jerry He 4771c217cd HBASE-17116 [PerformanceEvaluation] Add option to configure block size (Yi Liang) 2016-11-27 19:04:32 -08:00
anoopsamjohn 030054bcce HBASE-17162 Avoid unconditional call to getXXXArray() in write path. 2016-11-26 12:49:01 +05:30
anoopsamjohn 3f7f1c1353 HBASE-17169 Remove Cell variants with ShareableMemory. 2016-11-26 12:20:06 +05:30
zhangduo 01d3473bf0 HBASE-16984 Implement getScanner 2016-11-25 20:32:35 +08:00
anoopsamjohn 86e17858f7 HBASE-15786 Create DBB backed MSLAB pool. 2016-11-24 20:47:41 +05:30
binlijin a45b3c3533 HBASE-17144 Possible offheap read ByteBuffers leak 2016-11-24 16:12:20 +08:00
tedyu 9f5b8a83b7 HBASE-17158 Avoid deadlock caused by HRegion#doDelta (ChiaPing Tsai) 2016-11-23 07:05:46 -08:00
Michael Stack 511398f43a HBASE-17166 ITBLL fails on master unable to find hbase-protocol-shaded content 2016-11-22 19:45:20 -08:00
zhangduo 47a4e3437b HBASE-17132 Cleanup deprecated code for WAL 2016-11-22 18:27:41 +08:00
Jingcheng Du 92b494f117 HBASE-17157 Increase the default mergeable threshold for mob compaction 2016-11-22 17:39:10 +08:00
zhangduo 6ff19f94fe HBASE-17141 Introduce a more user-friendly implementation of AsyncTable 2016-11-22 14:44:51 +08:00
Jingcheng Du b297f2dae1 HBASE-17095 The ClientSimpleScanner keeps retrying if the hfile is corrupt or cannot found 2016-11-22 11:18:00 +08:00
tedyu 7ff7b88db5 HBASE-17123 Add postBulkLoadHFile variant that notifies the final paths for the hfiles - addendum calls existing BaseRegionObserver#postBulkLoadHFile() 2016-11-21 06:49:18 -08:00
anoopsamjohn 549c8d835a HBASE-17139 Remove sweep tool related configs from hbase-default.xml. 2016-11-21 15:54:31 +05:30
tedyu 768b4119da HBASE-17123 Add postBulkLoadHFile variant that notifies the final paths for the hfiles 2016-11-20 09:26:42 -08:00
tedyu bb645bcfda HBASE-17131 Avoid livelock caused by HRegion#processRowsWithLocks (ChiaPing Tsai) 2016-11-20 07:09:02 -08:00
anoopsamjohn a3a56b6380 HBASE-16989 RowProcess#postBatchMutate doesn’t be executed before the mvcc transaction completion. (ChiaPing Tsai) 2016-11-19 12:32:49 +05:30
Guanghao Zhang fa7ed58e1b HBASE-17088 Refactor RWQueueRpcExecutor/BalancedQueueRpcExecutor/RpcExecutor
Signed-off-by: zhangduo <zhangduo@apache.org>
2016-11-19 14:17:45 +08:00
Esteban Gutierrez 7c6e839f6a HBASE-17058 Lower epsilon used for jitter verification from HBASE-15324 2016-11-17 11:11:30 -08:00
Devaraj Das 5753d18c70 HBASE-16956 Refactor FavoredNodePlan to use regionNames as keys (Thiruvel Thirumoolan) 2016-11-17 10:09:48 -08:00
tedyu 4c7eac8977 HBASE-17112 Prevent setting timestamp of delta operations the same as previous value's (Phil Yang) 2016-11-17 09:03:48 -08:00
tedyu f6fc94ede9 HBASE-17118 StoreScanner leaked in KeyValueHeap (binlijin) 2016-11-17 07:52:52 -08:00
tedyu b9319496bc HBASE-17120 TestAssignmentListener#testAssignmentListener fails (ChiaPing Tsai) 2016-11-17 07:48:52 -08:00
zhangduo ab55bad899 HBASE-17085 AsyncFSWAL may issue unnecessary AsyncDFSOutput.sync 2016-11-17 15:10:19 +08:00
thiruvel 80acc2dca5 HBASE-16169: Make RegionSizeCalculator scalable
Signed-off-by: Michael Stack <stack@apache.org>
2016-11-16 23:07:14 -08:00
anoopsamjohn 4d1bff9e78 HBASE-17073 Increase the max number of buffers in ByteBufferPool. 2016-11-15 11:23:03 +05:30
tedyu c7bdb3017f HBASE-17092 Both LoadIncrementalHFiles#doBulkLoad() methods should set return value 2016-11-14 17:30:55 -08:00
Andrew Purtell dcf03b32f4 HBASE-17044 Fix merge failed before creating merged region leaves meta inconsistent 2016-11-14 17:23:27 -08:00
anoopsamjohn c3685760f0 HBASE-15788 Use Offheap ByteBuffers from BufferPool to read RPC requests. 2016-11-14 23:05:05 +05:30
tedyu 9250bf8091 HBASE-17037 Enhance LoadIncrementalHFiles API to convey loaded files 2016-11-13 07:02:18 -08:00
tedyu dba7ec1b69 HBASE-17077 Don't copy the replication queue belonging to the peer which has been deleted (Guanghao Zhang) 2016-11-13 06:58:39 -08:00
tedyu 5e91b45b16 HBASE-17062 RegionSplitter throws ClassCastException (Jeongdae Kim) 2016-11-11 07:15:03 -08:00
zhangduo 8a6d6aa239 HBASE-16838 Implement basic scan 2016-11-11 21:01:16 +08:00
anoopsamjohn fa838b020d HBASE-17071 Do not initialize MemstoreChunkPool when use mslab option is turned off. 2016-11-11 16:44:34 +05:30
thiruvel f9c6b66b95 HBASE-16962: Add readPoint to preCompactScannerOpen() and preFlushScannerOpen APIs
Signed-off-by: anoopsamjohn <anoopsamjohn@gmail.com>
2016-11-11 11:07:22 +05:30
Apekshit Sharma 62e3b1ece6 HBASE-17063 Cleanup TestHRegion : remove duplicate variables for method name and two unused params in initRegion
- Replaces local tablename and method names in individual tests with those initialized in setup() function
- Remove unused params from initHRegion().

Change-Id: Id0fe25890c833f7cc9b91277d5015480a007d788
2016-11-10 17:21:06 -08:00
Guanghao Zhang 12eec5bc5d HBASE-16938 TableCFsUpdater maybe failed due to no write permission on peerNode
Signed-off-by: Enis Soztutar <enis@apache.org>
2016-11-10 14:04:28 -08:00
Yu Sun fb4c50966e HBASE-17020 keylen in midkey() dont computed correctly
Signed-off-by: Yu Li <liyu@apache.org>
2016-11-10 17:15:34 +08:00
binlijin 7f08cd0e10 HBASE-16570 Compute region locality in parallel at startup (addendum)
Addendum mainly for:
1. Avoid interfering with block location cache in RegionLocationFinder
2. Avoid refreshing block lcoations during HMaster startup (or else the startup could be really slow)

Signed-off-by: Yu Li <liyu@apache.org>
2016-11-10 16:53:07 +08:00
zhangduo e5a288e5c0 HBASE-17053 Remove LogRollerExitedChecker 2016-11-10 10:52:49 +08:00
Michael Stack 8192a6b6ee Revert "HBASE-16993 BucketCache throw java.io.IOException: Invalid HFile block magic when DATA_BLOCK_ENCODING set to DIFF"
Revert of premature push.

This reverts commit de3a51263d.
2016-11-09 17:08:14 -08:00
Guanghao Zhang 1462cf77ef HBASE-16985 TestClusterId failed due to wrong hbase rootdir
Signed-off-by: Michael Stack <stack@apache.org>
2016-11-09 17:06:58 -08:00
Michael Stack de3a51263d HBASE-16993 BucketCache throw java.io.IOException: Invalid HFile block magic when DATA_BLOCK_ENCODING set to DIFF 2016-11-09 17:00:30 -08:00
tedyu 287358ba6c HBASE-17054 Compactor#preCreateCoprocScanner should be passed user 2016-11-09 06:57:43 -08:00
Charlie Qiangeng Xu 3b63f701e6 HBASE-17039 SimpleLoadBalancer schedules large amount of invalid region moves
Signed-off-by: Yu Li <liyu@apache.org>
2016-11-09 17:04:16 +08:00
Enis Soztutar 03bc884ea0 HBASE-17017 Remove the current per-region latency histogram metrics 2016-11-08 18:31:53 -08:00
zhangduo 3b629d632a HBASE-17021 Use RingBuffer to reduce the contention in AsyncFSWAL 2016-11-09 09:24:12 +08:00
Michael Stack 0998af01df Revert "Revert "HBASE-16983 TestMultiTableSnapshotInputFormat failing with Unable to create region directory: /tmp/... (Addendum by Guanghao Zhang)""
This is a revert of a revert, i.e. puts back the change only I added
HBaseCommonTestingUtility#getRandomDir from branch-1 too since
missing in master branch.

This reverts commit 9afcb4366d.
2016-11-08 12:55:48 -08:00
Apekshit Sharma 52241c90e4 HBASE-16982 Better integrate Apache CLI in AbstractHBaseTool.
- processOldArgs() in AbstractHBaseTool will make it possible to change existing tools to use Apache CLI in a backward compatible manner.
- Changes ExportSnapshot tool as a proof-of-concept
- Update version of Apache CLI from 1.2 to 1.3.1

Change-Id: I4bb2e7da4f2ed0e12e28621ab16459309fa36d03
2016-11-08 12:21:29 -08:00
Michael Stack 9afcb4366d Revert "HBASE-16983 TestMultiTableSnapshotInputFormat failing with Unable to create region directory: /tmp/... (Addendum by Guanghao Zhang)"
This reverts commit f9c23f5e9d.
2016-11-08 12:15:36 -08:00
Michael Stack f9c23f5e9d HBASE-16983 TestMultiTableSnapshotInputFormat failing with Unable to create region directory: /tmp/... (Addendum by Guanghao Zhang) 2016-11-08 12:00:51 -08:00
Matteo Bertozzi b143f6e4a3 HBASE-17030 Procedure v2 - A couple of tweaks to the SplitTableRegionProcedure 2016-11-08 10:30:33 -08:00
tedyu 76814e8451 HBASE-17010 Serial replication should handle daughter regions being assigned to another RS (Phil Yang) 2016-11-08 06:25:50 -08:00
Stephen Yuan Jiang 0512b4d015 HBASE-17042 Remove 'public' keyword from MasterObserver interface (Stephen Yuan Jiang) 2016-11-07 17:50:58 -08:00
Enis Soztutar 59d7b47e60 HBASE-17033 LogRoller makes a lot of allocations unnecessarily 2016-11-07 14:18:00 -08:00
anoopsamjohn 2182ca34ac HBASE-16992 The usage of mutation from CP is weird. (ChiaPing Tsai) 2016-11-07 23:24:34 +05:30
Michael Stack e60a7f6e7d HBASE-15513 hbase.hregion.memstore.chunkpool.maxsize is 0.0 by default (Addendum by Anoop Sam John) 2016-11-07 09:33:01 -08:00
Michael Stack 97ce30d47e Revert "Revert "HBASE-15513 hbase.hregion.memstore.chunkpool.maxsize is 0.0 by default (Vladimir Rodionov)""
This is a revert of a revert.

This reverts commit fd6b0b3dbf.
2016-11-07 09:31:44 -08:00
Michael Stack fd6b0b3dbf Revert "HBASE-15513 hbase.hregion.memstore.chunkpool.maxsize is 0.0 by default (Vladimir Rodionov)"
This reverts commit 8b4bb34ec2.
2016-11-07 09:07:02 -08:00
tedyu f3bed5b0d9 HBASE-17026 VerifyReplication log should distinguish whether good row key is result of revalidation 2016-11-07 07:38:47 -08:00
binlijin e8e658ed38 HBASE-16840 Reuse cell's timestamp and type in ScanQueryMatcher
Signed-off-by: Yu Li <liyu@apache.org>
2016-11-07 22:40:18 +08:00
Yu Li e33fd427e4 Revert "HBASE-16840 Reuse cell's timestamp and type in ScanQueryMatcher" to update author
This reverts commit 28de528c6e.
2016-11-07 22:40:02 +08:00
Yu Li 28de528c6e HBASE-16840 Reuse cell's timestamp and type in ScanQueryMatcher
Signed-off-by: Yu Li <liyu@apache.org>
2016-11-07 21:33:37 +08:00
Jingcheng Du 4ca668dd11 HBASE-17005 Improve log message in MobFileCache (huaxiang sun) 2016-11-07 16:38:14 +08:00
Mikhail Antonov a34a9adb22 HBASE-17032 CallQueueTooBigException and CallDroppedException should not be triggering PFFE 2016-11-06 21:44:59 -08:00
Michael Stack 8b4bb34ec2 HBASE-15513 hbase.hregion.memstore.chunkpool.maxsize is 0.0 by default (Vladimir Rodionov) 2016-11-06 21:43:02 -08:00
Matteo Bertozzi 7e05d0f161 HBASE-16937 Replace SnapshotType protobuf conversion when we can directly use the pojo object 2016-11-04 13:18:34 -07:00
Matteo Bertozzi 00ea7aeafe HBASE-16892 Use TableName instead of String in SnapshotDescription 2016-11-04 13:18:10 -07:00
Matteo Bertozzi efe0a0eead HBASE-16865 Procedure v2 - Inherit lock from root proc 2016-11-04 13:17:40 -07:00
anoopsamjohn 05ee54f665 HBASE-17013 Add constructor to RowMutations for initializing the capacity of internal list. (ChiaPing Tsai) 2016-11-04 10:34:20 +05:30
Apekshit Sharma bb0fc6b602 HBASE-17006 Give name to existing threads.
Having thread names in logs and thread dumps greatly improve debugability. This patch is simply adding the names to the threads we spawn.

Change-Id: I6ff22cc3804bb81147dde3a8e9ab671633c6f6ce
2016-11-03 18:28:19 -07:00
Eddie Elizondo f61ae6f06d HBASE-14329 Report region in transition should check all regions in request
Signed-off-by: Gary Helmling <garyh@apache.org>
2016-11-03 11:16:57 -07:00
Umesh Agashe 281bf9a222 HBASE-17014 Added clearly marked log messages for start and shutdown of services HMaster, HRegionServer, ThriftServer, RESTServer. Also changed the log level for RPCServer responder starting log message to debug.
Signed-off-by: Michael Stack <stack@apache.org>
2016-11-03 11:09:55 -07:00
Gary Helmling e820e64272 HBASE-16964 Always clear successfully archived files from compacted files list 2016-11-03 09:09:08 -07:00
tedyu c82fc6e0b2 HBASE-16975 Disable two subtests of TestSerialReplication (Phil Yang) 2016-11-03 01:55:26 -07:00
Yu Li b1d1dc8569 HBASE-16972 Log more details for Scan#next request when responseTooSlow 2016-11-02 15:02:07 +08:00
binlijin 6b957b69a7 HBASE-16960 RegionServer hang when aborting
Signed-off-by: Yu Li <liyu@apache.org>
2016-11-02 11:59:51 +08:00
Lars Hofhansl b7293bf5ad HBASE-16765 New SteppingRegionSplitPolicy, avoid too aggressive spread of regions for small tables. 2016-11-01 13:12:21 -07:00
Lars Hofhansl 1c07d1d591 Revert "New SteppingRegionSplitPolicy, avoid too aggressive spread of regions for small tables."
This reverts commit 791052c50a.
2016-11-01 13:11:31 -07:00
Lars Hofhansl 791052c50a New SteppingRegionSplitPolicy, avoid too aggressive spread of regions for small tables. 2016-11-01 12:21:51 -07:00
Michael Stack 26cbe44337 HBASE-16983 TestMultiTableSnapshotInputFormat failing with Unable to
create region directory: /tmp/...
2016-10-31 21:57:48 -07:00
zhangduo 6cf9333e97 HBASE-16945 Implement AsyncRegionLocator 2016-11-01 10:18:55 +08:00
zhangduo 45a2594249 HBASE-16968 Refactor FanOutOneBlockAsyncDFSOutput 2016-11-01 09:19:02 +08:00
Michael Stack d0be36deb7 HBASE-16966 Re-enable TestSimpleRpcScheduler#testCoDelScheduling in master branch 2016-10-31 14:40:51 -07:00
Michael Stack fe47ec81f9 HBASE-16969 RegionCoprocessorServiceExec should override the toString() for debugging (ChiaPing Tsai) 2016-10-31 14:32:59 -07:00
tedyu 861880b86b HBASE-16971 The passed durability of Append/Increment isn't used in wal sync (ChiaPing Tsai) 2016-10-31 09:50:47 -07:00
tedyu c3bb3b35c5 HBASE-16946 Provide Raw scan as an option in VerifyReplication (Sreekar Pallapothu) 2016-10-31 09:08:36 -07:00
anoopsamjohn 79073cd40c HBASE-16747 Track memstore data size and heap overhead separately - Addendum to fix TestIOFencing. 2016-10-31 11:05:36 +05:30
daoye.ch 6ce05d44e5 HBASE-16954 Unify HTable#checkAndDelete with AP (ChiaPing Tsai) 2016-10-31 09:15:29 +08:00
anoopsamjohn ba6d952324 HBASE-16747 Track memstore data size and heap overhead separately. 2016-10-30 12:20:46 +05:30
zhangduo 6127753b65 HBASE-16891 Try copying to the Netty ByteBuf directly from the WALEdit 2016-10-29 23:30:52 +08:00
Mikhail Antonov 17dfa34cfb HBASE-16743 TestSimpleRpcScheduler#testCoDelScheduling is broke 2016-10-28 16:47:10 -07:00
zhangduo 3283bc7c91 HBASE-16835 Revisit the zookeeper usage at client side 2016-10-28 13:27:41 +08:00
Stephen Yuan Jiang e108a4f815 HBASE-14551 Procedure v2 - Reimplement split (Stephen Yuan Jiang) 2016-10-27 21:45:41 -07:00
Guanghao Zhang 7b74dd0374 HBASE-16947 Some improvements for DumpReplicationQueues tool
Signed-off-by: Michael Stack <stack@apache.org>
2016-10-27 10:12:26 -07:00
tedyu d35b65883c HBASE-16886 hbase-client: scanner with reversed=true and small=true gets no result (huzheng) 2016-10-27 06:54:13 -07:00
Apekshit Sharma a3f1490601 HBASE-16950 Print raw stats in the end of proc performance tools for parsing results from scripts.
Change-Id: I45d77e838689dde7ec596de26ae98bd62e1b727e
2016-10-27 00:04:24 -07:00
Michael Stack 8d9b9dc6b7 HBASE-16948 Fix inconsistency between HRegion and Region javadoc on getRowLock 2016-10-26 16:09:43 -07:00
zhangduo cd3dd6e018 HBASE-16932 Implement small scan 2016-10-26 17:26:58 +08:00
zhangduo 5cee6a39c2 Revert "Implement small scan" due to miss issue number
This reverts commit c7c45f2c85.
2016-10-26 17:22:50 +08:00
Ramkrishna 1eae9aeeac HBASE-16783 Use ByteBufferPool for the header and message during Rpc
response (Ram)
2016-10-26 14:33:49 +05:30
zhangduo c7c45f2c85 Implement small scan 2016-10-26 15:45:02 +08:00
Michael Stack bbe88d942e HBASE-16944 Fix findbugs warning in hbase-server HRegion UL_UNRELEASED_LOCK 2016-10-25 14:44:11 -07:00
Guanghao Zhang c4be87d050 HBASE-16939 ExportSnapshot: set owner and permission on right directory
Signed-off-by: Matteo Bertozzi <matteo.bertozzi@cloudera.com>
2016-10-25 14:08:44 -07:00
zhangduo caa1a8494a HBASE-15709 Handle large edits for asynchronous WAL 2016-10-25 13:46:01 +08:00
Michael Stack 4533bb63cf Revert "Revert "HBASE-15789 PB related changes to work with offheap""
Restore this change but with a clean of the generated dirs first so
that we avoid trying to apply a patch on top of an already patched src.

This reverts commit 0f384158fc.
2016-10-24 16:51:50 -07:00
anoopsamjohn 988d1f9bc9 HBASE-16608 Introducing the ability to merge ImmutableSegments without copy-compaction or SQM usage. (Anastasia) 2016-10-24 23:09:48 +05:30
tedyu 1b12a60392 HBASE-16930 AssignmentManager#checkWals() function can recur infinitely (Umesh Agashe) 2016-10-24 10:10:03 -07:00
binlijin fa3cbd1d80 HBASE-16931 Setting cell's seqId to zero in compaction flow might cause RS down.
Signed-off-by: Yu Li <liyu@apache.org>
2016-10-24 23:32:38 +08:00
Ramkrishna 3584537b07 HBASE-16463 Improve transparent table/CF encryption with Commons Crypto
(Dapeng Sun)
2016-10-24 16:22:30 +05:30
tedyu 97cb1d71bc HBASE-16929 Move default method of shipped to Shipper interface - revert pending finding cause for Phoenix compilation error 2016-10-24 01:39:02 -07:00
zhangduo 2f4c91e41a HBASE-15684 Fix the broken log file size accounting 2016-10-22 17:42:09 +08:00
tedyu ac415f85f3 HBASE-16929 Move default method of shipped to Shipper interface 2016-10-21 17:23:07 -07:00
Guanghao Zhang 6415137574 HBASE-16815 Low scan ratio in RPC queue tuning triggers divide by zero exception
Signed-off-by: Matteo Bertozzi <matteo.bertozzi@cloudera.com>
2016-10-21 16:59:55 -07:00
tedyu e223639671 HBASE-16910 Avoid NPE when starting StochasticLoadBalancer (Guanghao Zhang) 2016-10-21 10:25:42 -07:00
Ramkrishna 0ae211eb39 HBASE-16414 Improve performance for RPC encryption with Apache Common
Crypto (Colin Ma)
2016-10-21 16:02:39 +05:30
Ashu Pachauri f1691e3d0d HBASE-16752 addendum. Do not retry large request for client versions less than 1.3
Signed-off-by: Gary Helmling <garyh@apache.org>
2016-10-20 10:34:01 -07:00
Guanghao Zhang 59857a41ea HBASE-16870 ADDENDUM fix failed TestReplicationSmallTests 2016-10-20 20:02:12 +08:00
zhangduo b2a7f31a06 Revert "HBASE-16870 ADDENDUM fix failed TestReplicationSmallTests"
This reverts commit c02b672e83.
2016-10-20 16:14:34 +08:00
Guanghao Zhang c02b672e83 HBASE-16870 ADDENDUM fix failed TestReplicationSmallTests
Signed-off-by: zhangduo <zhangduo@apache.org>
2016-10-20 14:36:23 +08:00
zhangduo ddc84356dd HBASE-16872 Implement mutateRow and checkAndMutate 2016-10-20 09:40:05 +08:00
Ashu Pachauri ee1123b069 HBASE-16752 Return error back to rpc client on exceeding rpc request size limit.
Signed-off-by: Gary Helmling <garyh@apache.org>
2016-10-19 15:09:51 -07:00
tedyu 674511875d HBASE-16870 Add the metrics of replication sources which were transformed from other dead rs to ReplicationLoad (Guanghao Zhang) 2016-10-19 14:54:35 -07:00
Huaxiang Sun 72db953886 HBASE-16345 RpcRetryingCallerWithReadReplicas#call() should catch some RegionServer Exceptions
Fix logic for
1). how to handle exception while waiting for reply from the primary replica.
2). handle exception from replicas while waiting for a correct response.

Signed-off-by: Esteban Gutierrez <esteban@apache.org>
2016-10-19 13:55:43 -07:00
Matteo Bertozzi d9ee25e82a HBASE-16874 Fix TestMasterFailoverWithProcedures and ensure single proc-executor for kill/restart tests 2016-10-19 13:25:17 -07:00
Jingcheng Du 67f1ac1f8e HBASE-16578 Mob data loss after mob compaction and normal compaction 2016-10-19 13:58:54 +08:00
zhangduo acc606571b HBASE-16837 Implement checkAndPut and checkAndDelete 2016-10-19 13:32:24 +08:00
Enis Soztutar ef8c65e542 HBASE-16824 Writer.flush() can be called on already closed streams in WAL roll 2016-10-18 18:46:02 -07:00
tedyu bb6cc4d43e HBASE-16854 Refactor the org.apache.hadoop.hbase.client.Action (ChiaPing Tsai) 2016-10-18 09:47:25 -07:00
Gary Helmling 317136e272 HBASE-16754 All WALSplitter OutputSinks should process compaction events 2016-10-18 09:37:37 -07:00
Esteban Gutierrez 5bc518b387 HBASE-16774 [shell] Add coverage to TestShell when ZooKeeper is not reachable 2016-10-18 09:08:33 -07:00
Michael Stack 0d40a52ee8 Revert "Revert "HBASE-16698 Performance issue: handlers stuck waiting for CountDownLatch inside WALKey#getWriteEntry under high writing workload; ADDENDUM. Fix findbugs""
This reverts commit f555b5be9c.

A revert of a revert
2016-10-18 08:35:45 -07:00
Michael Stack ec1adb7baa Revert "Revert "HBASE-16698 Performance issue: handlers stuck waiting for CountDownLatch inside WALKey#getWriteEntry under high writing workload""
This reverts commit 13baf4d37a.

This is a revert of a revert.
2016-10-18 08:34:29 -07:00
zhangduo b4f6ebde24 HBASE-16836 Implement increment and append 2016-10-18 22:34:14 +08:00
tedyu 10840a51e8 HBASE-16145 MultiRowRangeFilter constructor shouldn't throw IOException (Konstantin Ryakhovskiy) 2016-10-17 16:06:10 -07:00
tedyu 0c304a049b HBASE-16283 Batch Append/Increment will always fail if set ReturnResults to false (Allan Yang) 2016-10-17 15:42:06 -07:00
Matteo Bertozzi c6e9dabe62 HBASE-16846 Procedure v2 - executor cleanup 2016-10-17 10:30:59 -07:00
tedyu 2786253120 HBASE-16856 Exception message in SyncRunner.run() should print currentSequence (Allan Yang) 2016-10-17 07:19:49 -07:00
Ramkrishna 1e3d8c8226 HBASE-16792 Reuse KeyValue.KeyOnlyKeyValue in
BufferedDataBlockEncoder.SeekerState (Binlijin)
2016-10-17 12:26:36 +05:30
Ramkrishna bda5fd5a11 HBASE-16792 - reverting to change commit message 2016-10-17 12:25:13 +05:30
zhangduo 3a0dbf71a9 HBASE-16834 Add AsyncConnection support for ConnectionFactory 2016-10-17 13:08:43 +08:00
tedyu 109db38b6a HBASE-16853 Regions are assigned to Region Servers in /hbase/draining after HBase Master failover (David Pope) 2016-10-16 19:59:38 -07:00
Michael Stack 0f384158fc Revert "HBASE-15789 PB related changes to work with offheap"
This reverts commit fb15e3d4f5.
Breaks the build
2016-10-15 18:44:00 -07:00
Michael Stack fb15e3d4f5 HBASE-15789 PB related changes to work with offheap
Adds means of patching our shaded protobuf. Does it using
the Anoop patch attached to HBASE-15789 that adds ByteInput
to protobuf. This patch gets applied after protobuf has been
downloaded, relocated, and then unpacked over src/main/java.

Also fixes a few small build WARNINGs because of duplicate
mentions of dependencies.
2016-10-15 10:02:23 -07:00
Stephen Yuan Jiang b972839ca1 HBASE-16844 Procedure V2: DispatchMergingRegionsProcedure to use base class StateMachineProcedure for abort and rollback (Stephen Yuan Jiang) 2016-10-14 14:09:35 -07:00
Matteo Bertozzi 62c84115ec HBASE-16839 Procedure v2 - Move all protobuf handling to ProcedureUtil 2016-10-14 11:32:28 -07:00
Michael Stack 13baf4d37a Revert "HBASE-16698 Performance issue: handlers stuck waiting for CountDownLatch inside WALKey#getWriteEntry under high writing workload"
Premature commit. Revert while discussion still ongoing.

This reverts commit 9b13514483.
2016-10-14 11:27:05 -07:00
Michael Stack f555b5be9c Revert "HBASE-16698 Performance issue: handlers stuck waiting for CountDownLatch inside WALKey#getWriteEntry under high writing workload; ADDENDUM. Fix findbugs"
Premature commit. Revert while discussion ongoing

This reverts commit e1923b7c0c.
2016-10-14 11:26:33 -07:00
Ramkrishna 635ea05b9a HBASE-16729 Define the behavior of (default) empty FilterList(ChiaPing
Tsai)
2016-10-14 23:14:33 +05:30
anoopsamjohn 5f75fa0c4f HBASE-16799 CP exposed Store should not expose unwanted APIs. 2016-10-14 22:16:54 +05:30
tedyu 39d43ab779 HBASE-16821 Enhance LoadIncrementalHFiles API to convey missing hfiles if any 2016-10-14 09:07:38 -07:00
zhangduo 3fe7508295 HBASE-15921 Add first AsyncTable impl and create TableImpl based on it 2016-10-14 22:52:52 +08:00
Ramkrishna 4127fd2a7c iHBASE-16792 Reuse KeyValue.KeyOnlyKeyValue in
BufferedDataBlockEncoder.SeekerState (Binlijin)
2016-10-14 17:52:24 +05:30
Michael Stack e1923b7c0c HBASE-16698 Performance issue: handlers stuck waiting for CountDownLatch inside WALKey#getWriteEntry under high writing workload; ADDENDUM. Fix findbugs 2016-10-13 17:16:47 -07:00
Michael Stack 9b13514483 HBASE-16698 Performance issue: handlers stuck waiting for CountDownLatch inside WALKey#getWriteEntry under high writing workload 2016-10-13 09:25:23 -07:00
Pankaj Kumar c9c67d1a94 HBASE-16724 Snapshot owner can't clone
Signed-off-by: Ashish Singhi <ashishsinghi@apache.org>
2016-10-13 17:20:52 +05:30
Pankaj Kumar 90d83d5b38 HBASE-16807, RegionServer will fail to report new active Hmaster until HMaster/RegionServer failover.
Signed-off-by: chenheng <chenheng@apache.org>
2016-10-13 18:00:57 +08:00
Phil Yang 88ff71b91b HBASE-16664 Timeout logic in AsyncProcess is broken
Signed-off-by: chenheng <chenheng@apache.org>
2016-10-13 16:15:43 +08:00
Matteo Bertozzi 92ef234486 HBASE-16813 Procedure v2 - Move ProcedureEvent to hbase-procedure module 2016-10-12 16:33:25 -07:00
Michael Stack dfb2a800c4 HBASE-16746 The log of “region close” should differ from “region move” (ChiaPing Tsai) 2016-10-12 16:08:25 -07:00
tedyu f4bdab8bac HBASE-16810 HBase Balancer throws ArrayIndexOutOfBoundsException when regionservers are in /hbase/draining znode and unloaded (David Pope) 2016-10-12 13:23:06 -07:00
Phil Yang b8173a548c HBASE-16505 Pass deadline to HRegion operations
Signed-off-by: Michael Stack <stack@apache.org>
2016-10-12 12:16:18 -07:00
Matteo Bertozzi e868d9586f HBASE-16735 Procedure v2 - Fix yield while holding locks 2016-10-12 12:14:36 -07:00
Michael Stack a46134bffc HBASE-16731 Inconsistent results from the Get/Scan if we use the empty FilterList (ChiaPing Tsai) 2016-10-12 12:13:41 -07:00
tedyu 996d631c62 HBASE-16801 The Append/Increment may return the data from future - addendum (ChiaPing Tsai) 2016-10-12 10:06:51 -07:00
anoopsamjohn f77ff9f96f HBASE-16809 Save one cell length calculation in HeapMemStoreLAB#copyCellInto. (binlijin) 2016-10-12 09:57:23 +05:30
Pankaj Kumar 0af10f8942 HBASE-16663 JMX ConnectorServer stopped when unauthorized user try to stop HM/RS/cluster
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2016-10-11 17:54:19 -07:00
Apekshit Sharma eb52e26822 HBASE-16811 Remove mob sweep job.
Change-Id: If849fdcafb8af4a9765be1eb80da77f8b3f29a1a
2016-10-11 16:37:47 -07:00
tedyu ec87b4bfe2 HBASE-15109 HM/RS failed to start when "fs.hdfs.impl.disable.cache" is set to true (Pankaj Kumar) 2016-10-11 15:37:26 -07:00
tedyu fef3c908d3 HBASE-16803 Make hbase:acl table unsplittable - revert pending review comments 2016-10-11 12:52:32 -07:00
tedyu bbc2746267 HBASE-16803 Make hbase:acl table unsplittable 2016-10-11 12:48:14 -07:00
Gary Helmling bc7e034052 HBASE-16788 addendum Account for HStore archiveLock in heap size 2016-10-11 10:57:13 -07:00
tedyu 4d09116695 HBASE-16716 OfflineMetaRepair leaves empty directory inside /hbase/WALs which remains forever (Pankaj Kumar) 2016-10-11 07:19:54 -07:00
tedyu 0f21c41eda HBASE-16801 The Append/Increment may return the data from future (Chiaping Tsai) 2016-10-10 18:31:31 -07:00
Gary Helmling 7493e79f15 HBASE-16788 Guard HFile archiving under a separate lock 2016-10-10 15:58:12 -07:00
Dustin Pho fcef2c02c9 HBASE-16661 Add last major compaction age to per-region metrics
Signed-off-by: Gary Helmling <garyh@apache.org>
2016-10-10 15:16:12 -07:00
Huaxiang Sun 341f049e77 HBASE-16699 Overflows in AverageIntervalRateLimiter's refill() and getWaitInterval()
Signed-off-by: Matteo Bertozzi <matteo.bertozzi@cloudera.com>
2016-10-10 14:07:00 -07:00
Huaxiang Sun c930bc92f4 HBASE-16767 Mob compaction needs to clean up temporary files in face of IOExceptions.
1). Fix resource leak issue upon exception during mob compaction.
2). Reorg the code in compactMobFilesInBatch() to make it more readable.

Signed-off-by: Jonathan M Hsieh <jmhsieh@apache.org>
2016-10-10 14:48:24 -05:00
Sean Busbey 932a1964bf Revert "1). Fix resource leak issue upon exception during mob compaction. 2). Reorg the code in compactMobFilesInBatch() to make it more readable."
This reverts commit c7cae6be3d.

Missing JIRA ID
2016-10-10 14:47:46 -05:00
Sean Busbey 6b6a801876 HBASE-16701 rely on test category timeout instead of defining one on a specific test.
Signed-off-by: Umesh Agashe <uagashe@cloudera.com>
Signed-off-by: Yu Li <liyu@apache.org>
2016-10-10 00:14:38 -05:00
tedyu ccde439392 HBASE-16771 VerifyReplication should increase GOODROWS counter if re-comparison passes 2016-10-09 20:48:28 -07:00
ChiaPing Tsai 8a8c60889c HBASE-16794 TestDispatchMergingRegionsProcedure#testMergeRegionsConcurrently is flaky
Signed-off-by: Matteo Bertozzi <matteo.bertozzi@cloudera.com>
2016-10-09 16:53:29 -07:00
Matteo Bertozzi e06c3676f1 HBASE-16791 Fix TestDispatchMergingRegionsProcedure 2016-10-08 15:32:34 -07:00
Matteo Bertozzi 29d701a314 HBASE-16781 Fix flaky TestMasterProcedureWalLease 2016-10-07 18:01:53 -07:00
Huaxiang Sun c7cae6be3d 1). Fix resource leak issue upon exception during mob compaction. 2). Reorg the code in compactMobFilesInBatch() to make it more readable.
Signed-off-by: Jonathan M Hsieh <jmhsieh@apache.org>
2016-10-07 17:49:27 -07:00
Gary Helmling 723d56153f HBASE-16657 addendum handle null RegionLoad 2016-10-07 13:29:19 -07:00
Dustin Pho bc9a972451 HBASE-16657 Expose per-region last major compaction time in RegionServer UI
Signed-off-by: Gary Helmling <garyh@apache.org>
2016-10-07 09:49:24 -07:00
tedyu 62bc090123 HBASE-16773 AccessController should access local region if possible 2016-10-07 06:22:32 -07:00
tedyu 96d34f2a79 HBASE-16768 Inconsistent results from the Append/Increment (ChiaPing Tsai) 2016-10-07 00:59:27 -07:00
Ashu Pachauri 2c7211ec4b HBASE-16681: Flaky TestReplicationSourceManagerZkImpl 2016-10-06 16:26:38 -07:00
tedyu 97c1333831 HBASE-16772 Add verbose option to VerifyReplication for logging good rows 2016-10-06 11:16:18 -07:00
Matteo Bertozzi 7a38509782 HBASE-16777 Fix flaky TestMasterProcedureEvents 2016-10-06 07:24:39 -07:00
anoopsamjohn 912ed17286 HBASE-15721 Optimization in cloning cells into MSLAB. 2016-10-06 14:48:03 +05:30
Ramkrishna 58e843dae2 HBASE-16372 References to previous cell in read path should be avoided
(Ram)
2016-10-06 14:19:12 +05:30
Matteo Bertozzi eb33b60a95 HBASE-16778 Move testIllegalTableDescriptor out from TestFromClientSide 2016-10-05 20:04:18 -07:00
Matteo Bertozzi b548d4978b HBASE-16776 Remove duplicated versions of countRow() in tests 2016-10-05 19:45:50 -07:00
anoopsamjohn 06758bf630 HBASE-16759 Avoid ByteString.copyFrom usage wherever possible. 2016-10-06 00:27:34 +05:30
zhangduo 3aa4dfa73d HBASE-16690 Move znode path configs to a separated class 2016-10-05 20:12:44 +08:00
anoopsamjohn 617dfe18cd HBASE-16758 back HBaseZeroCopyByteStringer stuff. 2016-10-05 12:57:13 +05:30
Mikhail Antonov 5ae516bd63 HBASE-16644 Errors when reading legit HFile Trailer of old (v2.0) format file 2016-10-04 21:10:42 -07:00
Jonathan M Hsieh 0daeb635d0 HBASE-16763 Remove unintentional dependency on net.sf.ehcache.search.Results 2016-10-04 16:40:15 -07:00
tedyu b952e64751 HBASE-15560 TinyLFU-based BlockCache - revert pending performance verification 2016-10-04 08:37:29 -07:00
tedyu 9e0c2562a9 HBASE-15560 TinyLFU-based BlockCache (Ben Manes) 2016-10-04 05:15:51 -07:00
stack 95c1dc93fb HBASE-15638 Shade protobuf
Which includes

    HBASE-16742 Add chapter for devs on how we do protobufs going forward

    HBASE-16741 Amend the generate protobufs out-of-band build step
    to include shade, pulling in protobuf source and a hook for patching protobuf

    Removed ByteStringer from hbase-protocol-shaded. Use the protobuf-3.1.0
    trick directly instead. Makes stuff cleaner. All under 'shaded' dir is
    now generated.

    HBASE-16567 Upgrade to protobuf-3.1.x
    Regenerate all protos in this module with protoc3.
    Redo ByteStringer to use new pb3.1.0 unsafebytesutil
    instead of HBaseZeroCopyByteString

    HBASE-16264 Figure how to deal with endpoints and shaded pb Shade our protobufs.
    Do it in a manner that makes it so we can still have in our API references to
    com.google.protobuf (and in REST). The c.g.p in API is for Coprocessor Endpoints (CPEP)

            This patch is Tactic #4 from Shading Doc attached to the referenced issue.
            Figuring an appoach took a while because we have Coprocessor Endpoints
            mixed in with the core of HBase that are tough to untangle (FIX).

            Tactic #4 (the fourth attempt at addressing this issue) is COPY all but
            the CPEP .proto files currently in hbase-protocol to a new module named
            hbase-protocol-shaded. Generate .protos again in the new location and
            then relocate/shade the generated files. Let CPEPs keep on with the
            old references at com.google.protobuf.* and
            org.apache.hadoop.hbase.protobuf.* but change the hbase core so all
            instead refer to the relocated files in their new location at
            org.apache.hadoop.hbase.shaded.com.google.protobuf.*.

            Let the new module also shade protobufs themselves and change hbase
            core to pick up this shaded protobuf rather than directly reference
            com.google.protobuf.

            This approach allows us to explicitly refer to either the shaded or
            non-shaded version of a protobuf class in any particular context (though
            usually context dictates one or the other). Core runs on shaded protobuf.
            CPEPs continue to use whatever is on the classpath with
            com.google.protobuf.* which is pb2.5.0 for the near future at least.

            See above cited doc for follow-ons and downsides. In short, IDEs will complain
            about not being able to find the shaded protobufs since shading happens at package
            time; will fix by checking in all generated classes and relocated protobuf in
            a follow-on. Also, CPEPs currently suffer an extra-copy as marshalled from
            non-shaded to shaded. To fix. Finally, our .protos are duplicated; once
            shaded, and once not. Pain, but how else to reveal our protos to CPEPs or
            C++ client that wants to talk with HBase AND shade protobuf.

            Details:

            Add a new hbase-protocol-shaded module. It is a copy of hbase-protocol
    i       with all relocated offset from o.a.h.h. to o.a.h.h.shaded. The new module
            also includes the relocated pb. It does not include CPEPs. They stay in
            their old location.

            Add another module hbase-endpoint which has in it all the endpoints
            that ship as part of hbase -- at least the ones that are not
            entangled with core such as AccessControl and Auth. Move all protos
            for these CPEPs here as well as their unit tests (mostly moving a
            bunch of stuff out of hbase-server module)

            Much of the change looks like this:

                 -import org.apache.hadoop.hbase.protobuf.ProtobufUtil;
                 -import org.apache.hadoop.hbase.protobuf.generated.ClusterIdProtos;
                 +import org.apache.hadoop.hbase.protobuf.shaded.ProtobufUtil;
                 +import org.apache.hadoop.hbase.shaded.protobuf.generated.ClusterIdProtos;

            In HTable and in HBaseAdmin, regularize the way Callables are used and also hide
            protobuf usage as much as possible moving it up into Callable super classes or out
            to utility classes. Still TODO is adding in of retries, etc., but can wait on
            procedure which will redo all this.

            Also in HTable and HBaseAdmin as well as in HRegionServer and Server, be explicit
            when using non-shaded protobuf. Do the full-path so it is clear. This is around
            endpoint coprocessors registration of services and execution of CPEP methods.

            Shrunk ProtobufUtil by moving methods used by one CPEP only back to the CPEP either
            into Client class or as new Util class; e.g. AccessControlUtil.

            There are actually two versions of ProtobufUtil now; a shaded one and a subset
            that is used by CPEPs doing non-shaded work.

            Made it so hbase-common no longer depends on hbase-protocol (with Matteo's help)

            R*Converter classes got moved down under shaded package -- they are for internal
            use only. There are no non-shaded versions of these classes.

            D hbase-client/src/main/java/org/apache/hadoop/hbase/client/AbstractRegionServerCallable
            D RetryingCallableBase
             Not used anymore and we have too many tiers of Callables so removed/cleaned-up.

            A ClientServicecallable
             Had to add this one. RegionServerCallable was made generic so it could be used
             for a few Interfaces (Client and Admin). Then added ClientServiceCallable to
             implement RegionServerCallable with the Client Interface.
2016-10-03 21:37:32 -07:00
tedyu b43d1ecf5c HBASE-16739 Timed out exception message should include encoded region name 2016-10-03 06:46:04 -07:00
tedyu 1c083d9794 HBASE-16739 Timed out exception message should include encoded region name - Revert due to misspelled word in subject 2016-10-03 06:45:44 -07:00
Ramkrishna 7d0a6a82ab HBASE-15871 Memstore flush doesn't finish because of backwardseek() in
memstore scanner. (Ram)
2016-10-03 17:15:24 +05:30
anoopsamjohn 250ad644e4 HBASE-16738 L1 cache caching shared memory HFile block when blocks promoted from L2 to L1. 2016-10-03 16:04:48 +05:30
tedyu ec0adbd2c0 HBASE-16739) imed out exception message should include encoded region name 2016-10-02 21:09:09 -07:00
Enis Soztutar b8ad9b17bb HBASE-16721 Concurrency issue in WAL unflushed seqId tracking - ADDENDUM to change WAL to extend Closeable 2016-10-01 14:50:49 -07:00
Enis Soztutar c3c82f3558 HBASE-16678 MapReduce jobs do not update counters from ScanMetrics 2016-09-29 15:34:03 -07:00
Enis Soztutar bf3c928b74 HBASE-16721 Concurrency issue in WAL unflushed seqId tracking 2016-09-29 12:56:22 -07:00
Sean Busbey 76396714e1 HBASE-15984 Handle premature EOF treatment of WALs in replication.
In some particular deployments, the Replication code believes it has
reached EOF for a WAL prior to succesfully parsing all bytes known to
exist in a cleanly closed file.

Consistently this failure happens due to an InvalidProtobufException
after some number of seeks during our attempts to tail the in-progress
RegionServer WAL. As a work-around, this patch treats cleanly closed
files differently than other execution paths. If an EOF is detected due
to parsing or other errors while there are still unparsed bytes before
the end-of-file trailer, we now reset the WAL to the very beginning and
attempt a clean read-through.

In current testing, a single such reset is sufficient to work around
observed dataloss. However, the above change will retry a given WAL file
indefinitely. On each such attempt, a log message like the below will
be emitted at the WARN level:

  Processing end of WAL file '{}'. At position {}, which is too far away
  from reported file length {}. Restarting WAL reading (see HBASE-15983
  for details).

Additionally, this patch adds some additional log detail at the TRACE
level about file offsets seen while handling recoverable errors. It also
add metrics that measure the use of this recovery mechanism.
2016-09-29 10:07:14 -05:00
tedyu 63808a224c HBASE-16725 Don't let flushThread hang in TestHRegion 2016-09-29 06:56:19 -07:00
tedyu f3270d44c3 HBASE-16723 RMI registry is not destroyed after stopping JMX Connector Server (Pankaj Kumar) 2016-09-29 01:57:54 -07:00
Jonathan M Hsieh 09a31bd1e9 HBASE-16711 Fix hadoop-3.0 profile compile
Eliminates use of removed or deprecated hadoop2 api
- MBeanUtil -> MBeans Hadoop2 has both; Hadoop 3 removes MBeanUtil and uses MBeans
- FSDataOutputStream(OutputStream) -> FSDataOutputStream(OutputStream, FileSystem.Statistics)
- MetricsServlet is removed.  See HADOOP-12504
2016-09-28 13:11:37 -07:00
Ramkrishna 47e12fb3a0 HBASE-16696 After HBASE-16604 - does not release blocks in case of scanner
exception (Ram)
2016-09-28 15:39:08 +05:30
Abhishek Singh Chouhan d127d64266 HBASE-16660 ArrayIndexOutOfBounds during the majorCompactionCheck in DateTieredCompaction
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2016-09-27 10:58:51 -07:00
anoopsamjohn b644e0fb8d HBASE-16134 Introduce Cell extension for server side. 2016-09-27 22:55:45 +05:30
anoopsamjohn b0fcca6d7b HBASE-16691 Optimize KeyOnlyFilter by utilizing KeyOnlyCell.(binlijin) 2016-09-27 22:48:04 +05:30
Ramkrishna f196a8c331 HBASE-16643 - Reverse scanner heap creation may not allow MSLAB closure
due to improper ref counting of segments (Ram)
2016-09-27 14:24:19 +05:30
Stephen Yuan Jiang db394f57de HBASE-16714 Procedure V2 - use base class to remove duplicate set up test code in table DDL procedures (Stephen Yuan Jiang) 2016-09-26 20:41:43 -07:00
tedyu 219c786457 HBASE-16672 Add option for bulk load to copy hfile(s) instead of renaming 2016-09-26 18:56:38 -07:00
Andrew Purtell b9ec59ebbe HBASE-16694 Reduce garbage for onDiskChecksum in HFileBlock (binlijin) 2016-09-26 13:55:35 -07:00
Matteo Bertozzi f06c0060aa HBASE-16649 Truncate table with splits preserved can cause both data loss and truncated data appeared again 2016-09-26 12:58:04 -07:00
anoopsamjohn 43f47a8e73 HBASE-16704 Scan will be broken while working with DBE and KeyValueCodecWithTags. 2016-09-26 22:32:24 +05:30
Matteo Bertozzi 8da0500e7d HBASE-16695 Procedure v2 - Support for parent holding locks 2016-09-26 08:42:48 -07:00
Matteo Bertozzi e01e05cc0e HBASE-16587 Procedure v2 - Cleanup suspended proc execution 2016-09-26 08:08:44 -07:00
tedyu b7e0e15787 HBASE-16645 Wrong range of Cells is caused by CellFlatMap#tailMap, headMap, and SubMap (ChiaPing Tsai) 2016-09-25 06:42:32 -07:00
tedyu 3896d9ed0a HBASE-16692 Make ByteBufferUtils#equals safer and correct (binlijin) 2016-09-25 06:37:40 -07:00
chenheng 21969f5159 HBASE-16665 Check whether KeyValueUtil.createXXX could be replaced by CellUtil without copy 2016-09-25 14:06:55 +08:00
chenheng f7bb6fbf21 HBASE-16677 Add table size (total store file size) to table page (Guang Yang) 2016-09-25 10:48:01 +08:00
chenheng b14fb14886 Revert "HBASE-16677 Add table size (total store file size) to table page"
This reverts commit f5351e2dbd.
2016-09-25 10:47:20 +08:00
chenheng f5351e2dbd HBASE-16677 Add table size (total store file size) to table page 2016-09-25 09:49:50 +08:00
Matteo Bertozzi 7ed93f8f79 HBASE-16697 bump TestRegionServerMetrics to LargeTests 2016-09-23 15:45:56 -07:00
Apekshit Sharma 4082424305 HBASE-16679 Flush throughput controller: Minor perf change and fix flaky TestFlushWithThroughputController.
Change-Id: I79f4a65a67bfdc46868d68ff8a0c32f3a02b8cb1
2016-09-23 11:43:22 -07:00
Enis Soztutar eb112783ae HBASE-16604 Scanner retries on IOException can cause the scans to miss data - RECOMMIT after revert 2016-09-23 11:27:13 -07:00
Enis Soztutar 39db0cac78 Revert "HBASE-16604 Scanner retries on IOException can cause the scans to miss data"
This reverts commit 83cf44cd3f.

Reverting because accidental files are committed with this.
2016-09-23 11:25:23 -07:00
Jerry He 50b051ade1 HBASE-16257 Move staging dir to be under hbase root dir 2016-09-23 10:07:58 -07:00
Matteo Bertozzi d2ed74cbc6 HBASE-16688 Split TestMasterFailoverWithProcedures 2016-09-23 08:42:21 -07:00
tedyu 946c1ed8f8 HBASE-16423 Add re-compare option to VerifyReplication to avoid occasional inconsistent rows (Jianwei Cui) 2016-09-22 21:01:22 -07:00
binlijin 191afc8eb1 HBASE-16680 Reduce garbage in BufferChain
Signed-off-by: Yu Li <liyu@apache.org>
2016-09-23 11:06:23 +08:00
Yu Li 96c5a02217 Revert "HBASE-16880 Reduce garbage in BufferChain (binlijin)" to fix JIRA number
This reverts commit ce493642c0.
2016-09-23 11:03:21 +08:00
Matteo Bertozzi 07ed15598b HBASE-16671 Split TestExportSnapshot 2016-09-22 15:40:29 -07:00
Ben Lau 4b05f40984 HBASE-16662 Fix open POODLE vulnerabilities
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2016-09-22 14:27:07 -07:00
Enis Soztutar 83cf44cd3f HBASE-16604 Scanner retries on IOException can cause the scans to miss data 2016-09-22 12:06:11 -07:00
anoopsamjohn 1384c9a08d HBASE-16650 Wrong usage of BlockCache eviction stat for heap memory tuning. 2016-09-22 21:28:30 +05:30
tedyu 4bb84f7d0c HBASE-16675 Average region size may be incorrect when there is region whose RegionLoad cannot be retrieved 2016-09-22 07:33:34 -07:00
Ashish Singhi ce493642c0 HBASE-16880 Reduce garbage in BufferChain (binlijin) 2016-09-22 13:59:18 +05:30
Yu Li 2ff2c0ba6e HBASE-16670 Make RpcServer#processRequest logic more robust 2016-09-22 15:43:53 +08:00
anoopsamjohn 19bbf44554 HBASE-16651 LRUBlockCache#returnBlock should try return block to Victim Handler L2 cache. 2016-09-22 11:20:11 +05:30
Jonathan M Hsieh a90d433a2c HBASE-12088 Remove unused hadoop-1.0, hadoop-1.1 profiles from non-root poms 2016-09-21 20:45:03 -07:00
Jonathan M Hsieh 055dde7dfc HBASE-16669 Fix flakey TestAdmin1#testMergeRegions
Has been failing with incorrect region counts
2016-09-21 20:42:34 -07:00
Apekshit Sharma 593fb75083 HBASE-14734 Prevent BindException when setting up MiniKdc.
Port for kdc service gets selected in the constructor, but we bind to it later in MiniKdc.start()-->MiniKdc.initKDCServer() --> KdcServer.start(). In meantime, some other service can capture the port which results in BindException. The solution here is to catch the exception and retry.

Testing methodology:
- Used python and intellij.
- breakpoint on kdc.start(1), in catch block(2) and just after catch block(3).
- used python to bind to the selected port on breakpoint 1 --> run the program --> stops at breakpoint 2 (catch block)
- On breakpoint 1 and after 2 failures, close the port --> run the program --> skips catch block and goes to breakpoint 3.

Change-Id: I4e06e69819d1ec9a0a7fa471bf017f3a72c75cb3
2016-09-21 16:35:43 -07:00
Umesh Agashe 6a4c292a90 HBASE-16294 hbck reporting "No HDFS region dir found" for replicas
Signed-off-by: Matteo Bertozzi <matteo.bertozzi@cloudera.com>
2016-09-21 14:40:43 -07:00
Jerry He b6b01a790f HBASE-12949 Scanner can be stuck in infinite loop if the HFile is corrupted 2016-09-21 13:25:23 -07:00
chenheng c67983ebf8 HBASE-16659 Use CellUtil.createFirstOnRow instead of KeyValueUtil.createFirstOnRow in some places (binlijin) 2016-09-21 15:25:36 +08:00
Jerry He 66821206b8 HBASE-16647 hbck should do offline reference repair before online repair 2016-09-20 11:49:09 -07:00
tedyu 22dcce571c HBASE-16646 Enhance LoadIncrementalHFiles API to accept store file paths as input - addendum populates filesystem for the new doBulkLoad() 2016-09-20 10:52:38 -07:00
Matteo Bertozzi 181fed4450 HBASE-16551 Cleanup SplitLogManager and CatalogJanitor 2016-09-20 10:33:39 -07:00
tedyu 08d9a2b662 HBASE-16646 Enhance LoadIncrementalHFiles API to accept store file paths as input - addendum adheres to original cleanup logic 2016-09-20 09:38:18 -07:00
tedyu 348eb2834a HBASE-16646 Enhance LoadIncrementalHFiles API to accept store file paths as input 2016-09-20 07:42:01 -07:00
zhangduo 6eb6225456 HBASE-7612 [JDK8] Replace use of high-scale-lib counters with intrinsic facilities 2016-09-19 13:37:24 +08:00
zhangduo 4faa8ea934 HBASE-16165 Decrease RpcServer.callQueueSize before writeResponse causes OOM (Guanghao Zhang) 2016-09-18 10:05:27 +08:00
Apekshit Sharma da3abbcb35 HBASE-16534 Procedure v2 - Perf Tool for Scheduler.
Tool to test performance of locks and queues in procedure scheduler independently from other framework components.
Inserts table and region operations in the scheduler, then polls them and exercises their locks. Number of tables, regions and operations can be set using cli args.

Change-Id: I0fb27e67d3fcab70dd5d0b5197396b117b11eac6
2016-09-17 17:38:51 -07:00
Jerry He edc0ef3fe4 HBASE-16598 Enable zookeeper useMulti always and clean up in HBase code 2016-09-17 16:51:26 -07:00
Enis Soztutar 1a1003a482 HBASE-16447 Replication by namespaces config in peer (Guanghao Zhang) 2016-09-16 11:47:42 -07:00
chenheng 2cf8907db5 HBASE-16631 Extract AsyncRequestFuture related code from AsyncProcess 2016-09-17 00:35:23 +08:00
Matteo Bertozzi b6b72361b6 HBASE-16586 Procedure v2 - Cleanup sched wait/lock semantic 2016-09-16 08:50:17 -07:00
tedyu 2597217ae5 HBASE-16349 TestClusterId may hang during cluster shutdown 2016-09-16 02:32:03 -07:00
Matteo Bertozzi e19632a19a HBASE-16634 Speedup TestExportSnapshot 2016-09-15 18:29:09 -07:00
Nitin Aggarwal 8c4b09dfba HBASE-16624 Fix MVCC DeSerialization bug in the HFileScannerImpl
Change-Id: Ia970619ac7369d24ed432e827319dfdca16143c2

Signed-off-by: stack <stack@apache.org>
2016-09-15 11:01:51 -07:00
anoopsamjohn 56be3ac7c8 HBASE-16626 User customized RegionScanner from 1.X is incompatible with 2.0.0's off-heap part. (Charlie Qiangeng Xu) 2016-09-15 18:07:43 +05:30
Phil Yang 8ef6c76344 HBASE-16388 Prevent client threads being blocked by only one slow region server
Signed-off-by: stack <stack@apache.org>
2016-09-14 09:08:20 -07:00
Matteo Bertozzi 4c6a98bd76 HBASE-16618 Procedure v2 - Add base class for table and ns procedures 2016-09-13 11:37:52 -07:00
zhangduo a602aaf9ba HBASE-16615 Fix flaky TestScannerHeartbeatMessages 2016-09-13 17:41:01 +08:00
anoopsamjohn 77b327320a HBASE-16229 Cleaning up size and heapSize calculation. 2016-09-12 23:23:38 -07:00
chenheng 2566cfeb60 HBASE-16592 Unify Delete request with AP 2016-09-12 23:23:38 -07:00
tedyu 8855670cd7 HBASE-16616 Rpc handlers stuck on ThreadLocalMap.expungeStaleEntry (Tomu Tsuruhara) 2016-09-12 15:49:23 -07:00
chenheng 80d8b2100d HBASE-16086 TableCfWALEntryFilter and ScopeWALEntryFilter should not redundantly iterate over cells (Vincent Poon) 2016-09-11 09:55:08 +08:00
chenheng cc2a40a78f HBASE-16596 Reduce redundant interfaces in AsyncProcess 2016-09-10 11:13:28 +08:00
zhangduo 6c8d1f0ae8 HBASE-16309 TestDefaultCompactSelection.testCompactionRatio is flaky 2016-09-09 14:20:39 +08:00
chenheng e11aafae95 HBASE-16570 Compute region locality in parallel at startup (binlijin) 2016-09-09 10:54:48 +08:00
Andrew Purtell 46c756a4a7 HBASE-16589 Adjust log level for FATAL messages from HBaseReplicationEndpoint that are not fatal 2016-09-08 13:04:18 -07:00
tedyu d7e5c6fa8e HBASE-16505 Add AsyncRegion interface to pass deadline and support async operations - revert due to open questions 2016-09-08 11:55:46 -07:00
tedyu 1574c6ef39 HBASE-16505 Add AsyncRegion interface to pass deadline and support async operations (Phil Yang) 2016-09-08 06:57:03 -07:00
zhangduo c04b389181 HBASE-16445 Refactor and reimplement RpcClient 2016-09-08 20:32:56 +08:00
binlijin fc224ed0ed HBASE-16530 Reduce DBE code duplication
Signed-off-by: Yu Li <liyu@apache.org>
2016-09-08 13:48:27 +08:00
tedyu e9cfbfd107 HBASE-16572 Sync method in RecoverableZooKeeper failed to pass callback function in (Allan Yang) 2016-09-07 11:35:35 -07:00
tedyu b6ba13c377 HBASE-16460 Can't rebuild the BucketAllocator's data structures when BucketCache uses FileIOEngine (Guanghao Zhang) 2016-09-05 06:50:50 -07:00
zhangduo 91227f8f98 HBASE-16516 Revisit the implementation of PayloadCarryingRpcController 2016-09-04 09:16:15 +08:00
tedyu 592245ff13 HBASE-16556 The read/write timeout are not used in HTable.delete(List), HTable.get(List), and HTable.existsAll(List) (ChiaPing Tsai) 2016-09-03 17:14:57 -07:00
Matteo Bertozzi 008091fe8a HBASE-16552 MiniHBaseCluster#getServerWith() does not ignore stopped RSs 2016-09-02 16:49:17 -07:00
Andrew Purtell 5e905c02d9 HBASE-16399 Provide an API to get list of failed regions and servername in Canary (Vishal Khandelwal) 2016-09-02 10:13:35 -07:00
Jerry He 0b6eccf4c3 HBASE-16311 Audit log for delete snapshot operation is missing in case of snapshot owner deleting the same (Yi Liang) 2016-09-02 09:47:28 -07:00
Matteo Bertozzi f6ccae3502 HBASE-16507 Procedure v2 - Force DDL operation to always roll forward 2016-09-01 21:06:32 -07:00
Loknath Priyatham Teja Singamsetty b839d04d8e HBASE-16375 Mapreduce mini cluster using HBaseTestingUtility not setting correct resourcemanager and jobhistory webapp address of MapReduceTestingShim
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Amending-Author: Andrew Purtell <apurtell@apache.org>
2016-09-01 15:57:39 -07:00
tedyu a1cd601ad7 HBASE-16527 IOExceptions from DFS client still can cause CatalogJanitor to delete referenced files (Vladimir Rodionov) 2016-09-01 12:31:20 -07:00
chenheng 3892550484 HBASE-15278 AsyncRPCClient hangs if Connection closes before RPC call response 2016-09-01 10:33:24 +08:00
Matteo Bertozzi 8479554275 HBASE-16519 Procedure v2 - Avoid sync wait on DDLs operation (addendum) 2016-08-31 13:48:25 -07:00
Stephen Yuan Jiang 605af95132 HBASE-16528 Procedure-V2: ServerCrashProcedure misses owner information (Stephen Yuan Jiang) 2016-08-31 09:25:51 -07:00
zhangduo 45af3831fe HBASE-16526 Add more ipc tests 2016-08-31 20:44:56 +08:00
zhangduo 647a65ce01 HBASE-16531 Move cell block related code out of IPCUtil 2016-08-31 13:09:22 +08:00
tedyu 7b95ac117d HBASE-16502 Reduce garbage in BufferedDataBlockEncoder - addendum adopts Hiroshi's suggestion (binlijin) 2016-08-30 18:04:34 -07:00
Matteo Bertozzi af33f94513 HBASE-16522 Procedure v2 - Cache system user and avoid IOException 2016-08-30 15:39:49 -07:00
Matteo Bertozzi 4a4f8e7049 HBASE-16519 Procedure v2 - Avoid sync wait on DDLs operation 2016-08-30 09:45:56 -07:00
Matteo Bertozzi 2acd788dce HBASE-16082 Procedure v2 - Move out helpers from MasterProcedureScheduler 2016-08-30 09:44:35 -07:00
tedyu 9cb0094bdb HBASE-16509 Add option to LoadIncrementalHFiles which allows skipping unmatched column families 2016-08-30 03:00:59 -07:00
zhangduo 0d05c75184 HBASE-16510 Reset RpcController before retry 2016-08-30 16:56:28 +08:00
chenheng c000f29e47 HBASE-16224 Reduce the number of RPCs for the large PUTs (ChiaPing Tsai) 2016-08-30 06:35:33 +08:00
anoopsamjohn 950d547dae HBASE-16407 Handle MemstoreChunkPool size when HeapMemoryManager tunes memory. 2016-08-29 10:22:27 +05:30
chenheng 7eaba369e7 HBASE016490 Fix race condition between SnapshotManager and SnapshotCleaner 2016-08-27 10:48:21 +08:00
Matteo Bertozzi 1b9af2a2fa HBASE-16508 Move UnexpectedStateException to common 2016-08-26 16:40:30 -07:00
anoopsamjohn 0d99e827b2 HBASE-16213 A new HFileBlock structure for fast random get. (binlijin) 2016-08-26 10:50:36 +05:30
tedyu b1ee8a88c3 HBASE-16502 Reduce garbage in BufferedDataBlockEncoder (binlijin) 2016-08-25 20:35:30 -07:00
tedyu 3fd59b0ba9 HBASE-16409 Addendum fixes the case where delimiter is not specified by user 2016-08-25 11:53:49 -07:00
zhangduo a1f760ff76 HBASE-16433 Remove AsyncRpcChannel related stuffs 2016-08-25 08:15:46 +08:00
Stephen Yuan Jiang 8a692ff189 HBASE-16486 Unify system table creation using the same createSystemTable API (Stephen Yuan Jiang) 2016-08-24 15:21:20 -07:00
tedyu bf7015d320 HBASE-16304 HRegion#RegionScannerImpl#handleFileNotFoundException may lead to deadlock when trying to obtain write lock on updatesLock 2016-08-24 09:04:47 -07:00
Enis Soztutar dda8f67b2c HBASE-16270 Handle duplicate clearing of snapshot in region replicas (Robert Yokota) 2016-08-24 06:33:46 -07:00
Ashish Singhi 31f16d6aec HBASE-16471 Region Server metrics context will be wrong when machine hostname contain "master" word (Pankaj Kumar) 2016-08-24 18:59:44 +05:30
Enis Soztutar cbfd6eecbd HBASE-16474 Remove dfs.support.append related code and documentation 2016-08-24 03:41:54 -07:00
chenheng 3909b7c96f HBASE-16464 archive folder grows bigger and bigger due to corrupt snapshot under tmp dir 2016-08-24 13:38:32 +08:00
anoopsamjohn 32c21f4594 HBASE-14921 In-Memory MemStore Flush and Compaction : Memory optimizations. (Anastasia) 2016-08-24 09:25:21 +05:30
Geoffrey cb02be38ab HBASE-16448 Custom metrics for custom replication endpoints
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2016-08-23 17:17:08 -07:00
Matteo Bertozzi cb507b8cff HBASE-16360 TableMapReduceUtil addHBaseDependencyJars has the wrong class name for PrefixTreeCodec (Jing Pu Chen) 2016-08-23 14:22:20 -07:00
anoopsamjohn 897631f8d1 HBASE-16440 MemstoreChunkPool might cross its maxCount of chunks to pool. 2016-08-23 22:28:14 +05:30
Ashish Singhi 77a7394f17 HBASE-16446 append_peer_tableCFs failed when there already have this table's partial cfs in the peer (Guanghao Zhang) 2016-08-23 15:28:33 +05:30
Ramkrishna ff6182b020 HBASE-16454 Compactor's shipping logic decision should be based on the
current store's block size (Ram)
2016-08-23 11:06:02 +05:30
Esteban Gutierrez abc64fa69f HBASE-16450 Shell tool to dump replication queues
New tool to dump existing replication peers, configurations and
queues when using HBase Replication. The tool provides two flags:

 --distributed  This flag will poll each RS for information about
                the replication queues being processed on this RS.
                By default this is not enabled and the information
                about the replication queues and configuration will
                be obtained from ZooKeeper.
 --hdfs         When --distributed is used, this flag will attempt
                to calculate the total size of the WAL files used
                by the replication queues. Since its possible that
                multiple peers can be configured this value can be
                overestimated.

Signed-off-by: Matteo Bertozzi <matteo.bertozzi@cloudera.com>
2016-08-22 19:50:10 -07:00
Apekshit Sharma ae42a934d8 HBASE-16467 Move AbstractHBaseTool to hbase-common.
Change-Id: I64775f875f6900520e66c22c007704a067e8c2a4
2016-08-22 16:06:17 -07:00
tedyu f174fec391 HBASE-16455 Provide API for obtaining all the WAL files 2016-08-22 01:34:58 -07:00
tedyu d077219d3a HBASE-16409 Row key for bad row should be properly delimited in VerifyReplication 2016-08-20 17:16:39 -07:00
anoopsamjohn 5f61f9cc5c HBASE-16405 Change read path Bloom check to work with Cells with out any copy. 2016-08-19 11:25:35 +05:30
Yu Li 642d2fe0f8 HBASE-16429 FSHLog: deadlock if rollWriter called when ring buffer filled with appends 2016-08-18 09:59:36 +08:00
Matteo Bertozzi e637a61e26 HBASE-16378 Procedure v2 - Make ProcedureException extend HBaseException 2016-08-17 14:31:08 -07:00
chenheng fb4ef53571 HBASE-15635 Mean age of Blocks in cache (seconds) on webUI should be greater than zero
Signed-off-by: stack <stack@apache.org>
2016-08-17 10:59:00 -07:00
tedyu 233ca65b8f HBASE-16419 check REPLICATION_SCOPE's value more stringently (Guangxu Cheng) 2016-08-17 07:58:06 -07:00
stack 907ac1f655 HBASE-16341 Missing bit on "Regression: Random Read/WorkloadC slower in 1.x than 0.98" 2016-08-13 20:16:44 -07:00
Ramkrishna 65c03b058c HBASE-16404 Make DeleteBloomFilters work with BloomContext (Ram) 2016-08-12 15:09:31 +05:30
Ramkrishna 285e104176 HBASE-15554 - StoreFile$Writer.appendGeneralBloomFilter generates extra KV
(Ram)
2016-08-12 10:21:41 +05:30
tedyu fb668a0d3f HBASE-16267 Remove commons-httpclient dependency from hbase-rest module 2016-08-10 21:28:45 -07:00
tedyu 9e116e048b HBASE-16389 Thread leak in CoprocessorHost#getTable(TableName) API (Ankit Singhal) 2016-08-10 19:58:13 -07:00
stack 45bb6180a3 REVERT of revert of "HBASE-16308 Contain protobuf references Gather up the pb references into a few locations only rather than have pb references distributed all about the code base."
This is a revert of a revert; i.e. we are adding back the change only adding
back with fixes for the broken unit test; was a real issue on a test that
went in just at same time as this commit; I was getting a new nonce on each
retry rather than getting one for the mutation.

Other changes since revert are more hiding of RpcController. Use
accessor method rather than always pass in a RpcController

Walked back retrying operations that used to be single-shot (though
code comment said need a retry) because it opens a can of worms where
we retry stuff like bad column family when we shouldn't (needs
work adding in DoNotRetryIOEs)

Changed name of class from PayloadCarryingServerCallable to
CancellableRegionServerCallable.

Fix javadoc and findbugs warnings.

Fix case of not initializing the ScannerCallable RpcController.

Below is original commit message:

 Remove mention of ServiceException and other protobuf classes from all over the codebase.
 Purge TimeLimitedRpcController. Lets just have one override of RpcController.
        M hbase-client/src/main/java/org/apache/hadoop/hbase/client/AbstractRegionServerCallable.java
         Cleanup. Make it clear this is an odd class for async hbase intro.
        M hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java
         Refactor of RegionServerCallable allows me clean up a bunch of
         boilerplate in here and remove protobuf references.
        M hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
          Purge protobuf references everywhere except a reference to a throw of a
          ServiceException in method checkHBaseAvailable. I deprecated it in favor
          of new available method (the SE is not actually needed)
        M hbase-client/src/main/java/org/apache/hadoop/hbase/client/PayloadCarryingServerCallable.java
         Move the RetryingTimeTracker instance in here from HTable.
         Allows me to contain tracker and remove a repeated code in HTable.
        M hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionServerCallable.java
         Clean up move set up of rpc in here rather than have it repeat in HTable.
         Allows me to remove protobuf references from a bunch of places.
    M hbase-client/src/main/java/org/apache/hadoop/hbase/client/FlushRegionCallable.java
     Make use of the push of boilerplate up into RegionServerCallable
    M hbase-client/src/main/java/org/apache/hadoop/hbase/client/MultiServerCallable.java
    M hbase-client/src/main/java/org/apache/hadoop/hbase/client/PayloadCarryingServerCallable.java
    M hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionAdminServiceCallable.java
    M hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerWithReadReplicas.java
    M hbase-client/src/main/java/org/apache/hadoop/hbase/client/ScannerCallable.java
    M hbase-client/src/main/java/org/apache/hadoop/hbase/client/SecureBulkLoadClient.java
    M hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java
     Move boilerplate up into superclass.
    M hbase-client/src/main/java/org/apache/hadoop/hbase/client/RetryingTimeTracker.java
     Cleanup
    M hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/PayloadCarryingRpcController.java
    M hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
    M hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALEditsReplaySink.java
    M hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/RegionReplicaReplicationEndpoint.java
     Factor in TimeLimitedRpcController. Just have one RpcController override.
    D hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/TimeLimitedRpcController.java
     Removed. Lets have one override of pb rpccontroller only.
    M hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
     (handleRemoteException) added
     (toText) added
2016-08-10 10:12:06 -07:00
Phil Yang 091a17e3c9 HBASE-16368 test*WhenRegionMove in TestPartialResultsFromClientSide is flaky
Signed-off-by: zhangduo <zhangduo@apache.org>
2016-08-10 18:13:12 +08:00
Phil Yang ede9940a7b HBASE-16285 Drop RPC requests if it must be considered as timeout at client
Signed-off-by: zhangduo <zhangduo@apache.org>
2016-08-10 16:56:27 +08:00
stack 46defe8e31 HBASE-9899 for idempotent operation dups, return the result instead of throwing conflict exception (Guanghao Zhang): ADDENDUM 2016-08-09 07:09:44 -07:00
Phil Yang 5cadcd59aa HBASE-9465 Push entries to peer clusters serially
Signed-off-by: zhangduo <zhangduo@apache.org>
2016-08-09 15:25:50 +08:00
tedyu 1ecb0fce34 HBASE-16367 Race between master and region server initialization may lead to premature server abort - addendum shortens the waiting duration 2016-08-08 10:39:35 -07:00
tedyu 50f3c9572c HBASE-16367 Race between master and region server initialization may lead to premature server abort 2016-08-08 04:07:30 -07:00
Phil Yang e5f9df1e23 HBASE-12770 Don't transfer all the queued hlogs of a dead server to the same alive server
Signed-off-by: zhangduo <zhangduo@apache.org>
2016-08-08 16:30:23 +08:00
Vivek 30d7eeaefe HBASE-15866 Split hbase.rpc.timeout into *.read.timeout and *.write.timeout
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Amending-Author: Andrew Purtell <apurtell@apache.org>
2016-08-06 16:55:09 -07:00
zhangduo 977858c9cb HBASE-16362 Mob compaction does not set cacheBlocks to false when creating StoreScanner 2016-08-06 22:38:26 +08:00
stack 0206dc67d6 Revert "HBASE-16308 Contain protobuf references Gather up the pb references into a few locations only rather than have pb references distributed all about the code base."
This reverts commit ed87a81b4b.
2016-08-05 15:18:48 -07:00
stack ed87a81b4b HBASE-16308 Contain protobuf references Gather up the pb references into a few locations only rather than have pb references distributed all about the code base.
Purge ServiceException from Callable subclasses by pushing SE handling
up into the parent Callable class (varies by context but this is basic
patten). Allows us remove a bunch of boilerplate.
Do this in the public facing classes in particular (though if
an API has SE in it -- which a few do, this patch leaves these
untouched -- for now.) Make it so HBaseAdmin and HTable have no
direct pb imports (except for endpoint processor API).

Change a few of the HBaseAdmin calls to be retrying where comments
ask that we do retry rather than one time.

Purge TimeLimitedRpcController. Lets just have one override of RpcController.

        M hbase-client/src/main/java/org/apache/hadoop/hbase/client/AbstractRegionServerCallable.java
         Cleanup. Make it clear this is an odd class for async hbase intro.

        M hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java
         Refactor of RegionServerCallable allows me clean up a bunch of
         boilerplate in here and remove protobuf references.

        M hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
          Purge protobuf references everywhere except a reference to a throw of a
          ServiceException in method checkHBaseAvailable. I deprecated it in favor
          of new available method (the SE is not actually needed)

        M hbase-client/src/main/java/org/apache/hadoop/hbase/client/PayloadCarryingServerCallable.java
         Move the RetryingTimeTracker instance in here from HTable.
         Allows me to contain tracker and remove a repeated code in HTable.

        M hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionServerCallable.java
         Clean up move set up of rpc in here rather than have it repeat in HTable.
         Allows me to remove protobuf references from a bunch of places.

    M hbase-client/src/main/java/org/apache/hadoop/hbase/client/FlushRegionCallable.java
     Make use of the push of boilerplate up into RegionServerCallable

    M hbase-client/src/main/java/org/apache/hadoop/hbase/client/MultiServerCallable.java
    M hbase-client/src/main/java/org/apache/hadoop/hbase/client/PayloadCarryingServerCallable.java
    M hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionAdminServiceCallable.java
    M hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerWithReadReplicas.java
    M hbase-client/src/main/java/org/apache/hadoop/hbase/client/ScannerCallable.java
    M hbase-client/src/main/java/org/apache/hadoop/hbase/client/SecureBulkLoadClient.java
    M hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java
     Move boilerplate up into superclass.

    M hbase-client/src/main/java/org/apache/hadoop/hbase/client/RetryingTimeTracker.java
     Cleanup

    M hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/PayloadCarryingRpcController.java
    M hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
    M hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALEditsReplaySink.java
    M hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/RegionReplicaReplicationEndpoint.java
     Factor in TimeLimitedRpcController. Just have one RpcController override.

    D hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/TimeLimitedRpcController.java
     Removed. Lets have one override of pb rpccontroller only.

    M hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
     (handleRemoteException) added
     (toText) added

Signed-off-by: stack <stack@apache.org>
2016-08-05 10:13:58 -07:00
Sean Busbey 431c8c9ad0 HBASE-8386 deprecate TableMapReduce.addDependencyJars(Configuration, class<?> ...)
Signed-off-by: Matteo Bertozzi <matteo.bertozzi@cloudera.com>
2016-08-05 10:35:02 -05:00
Sean Busbey 60b79e2daa HBASE-16321 ensure no findbugs-jsr305
Signed-off-by: Esteban Gutierrez <esteban@apache.org>
2016-08-05 10:16:29 -05:00
tedyu 4b3e45fceb HBASE-16359 Addendum moves null checking as suggested by Heng 2016-08-05 03:18:28 -07:00
Ramkrishna 19c609fa5e HBASE-16303 FilterList with MUST_PASS_ONE optimization (Ram) 2016-08-05 10:58:02 +05:30
tedyu 5e23b3aad5 HBASE-16359 NullPointerException in RSRpcServices.openRegion() 2016-08-04 20:46:48 -07:00
stack 975f0dd958 HBASE-9899 for idempotent operation dups, return the result instead of throwing conflict exception (Guanghao Zhang) 2016-08-04 12:40:19 -07:00
chenheng 550b937bcf HBASE-16287 LruBlockCache size should not exceed acceptableSize too many(Yu Sun) 2016-08-04 21:13:42 +08:00
Lim Chee Hau 0eaf3edc3a HBASE-15574 Fix typo in HRegionServerCommandLine
Signed-off-by: Sean Busbey <busbey@apache.org>
2016-08-03 23:43:33 -05:00
Nick Dimiduk 209b6f74c7 HBASE-16317 revert all ESAPI changes
Revert "HBASE-15270 Use appropriate encoding for "filter" field in TaskMonitorTmpl.jamon."

This reverts commit bba4f107c1.

Revert "HBASE-15122 Servlets generate XSS_REQUEST_PARAMETER_TO_SERVLET_WRITER findbugs warnings (Samir Ahmic)"

This reverts commit 68b300173f.

 Conflicts:
	hbase-server/pom.xml

Revert "HBASE-15329 Cross-Site Scripting: Reflected in table.jsp (Samir Ahmic)"

This reverts commit 4b3e38705c.

 Conflicts:
	hbase-server/src/main/resources/hbase-webapps/master/table.jsp

Revert "HBASE-15369 Handle NPE in region.jsp (Samir Ahmic)"

This reverts commit 3826894f89.
2016-08-03 20:47:02 -07:00
Enis Soztutar 81b06b3bdd HBASE-16350 Undo server abort from HBASE-14968 2016-08-03 19:37:58 -07:00
Enis Soztutar bcf2738a01 HBASE-16301 Trigger flush without waiting when compaction is disabled on a table (huaxiang sun) 2016-08-02 18:46:07 -07:00
Andrew Purtell e63fb6c025 HBASE-16319 Fix TestCacheOnWrite after HBASE-16288 2016-08-02 16:53:32 -07:00
Deokwoo Han eef6a4834a HBASE-16284 Unauthorized client can shutdown the cluster 2016-08-02 11:21:31 -07:00
zhangduo b35cf8f93a HBASE-16225 Refactor ScanQueryMatcher 2016-08-02 14:01:28 +08:00
Andrew Purtell 78361243c8 HBASE-16296 Reverse scan performance degrades when using filter lists (Ted Yu) 2016-08-01 17:41:10 -07:00
Enis Soztutar aa0235f98c HBASE-16288 HFile intermediate block level indexes might recurse forever creating multi TB files 2016-08-01 11:08:56 -07:00
chenheng 7e6f562754 HBASE-16234 Expect and handle nulls when assigning replicas(Yi Liang) 2016-08-01 11:21:13 +08:00
Joseph Hwang 3729320099 HBASE-16209 Removed unnecessary method and method calls from AssignmentManager and AssignmentManager UI (addendum)
Signed-off-by: Matteo Bertozzi <matteo.bertozzi@cloudera.com>
2016-07-29 16:05:00 -07:00
Joseph Hwang fe44383619 HBASE-16209 provide an ExponentialBackOffPolicy sleep between failed region open requests
Signed-off-by: Elliott Clark <eclark@apache.org>
2016-07-29 09:47:00 -07:00
Yu Sun 2b1cbeb28d HBASE-16300 LruBlockCache.CACHE_FIXED_OVERHEAD should calculate LruBlockCache size correctly
Signed-off-by: Yu Li <liyu@apache.org>
2016-07-29 14:29:01 +08:00
Matteo Bertozzi 66fb697f81 HBASE-16275 Change ServerManager#onlineServers from ConcurrentHashMap to ConcurrentSkipListMap (Huaxiang Sun) 2016-07-28 11:13:58 -07:00
Matteo Bertozzi 64804a0497 HBASE-16293 TestSnapshotFromMaster#testSnapshotHFileArchiving flakey (Huaxiang Sun) 2016-07-28 10:42:30 -07:00
anoopsjohn 00c2a5da7b HBASE-16286 When TagRewriteCell are not copied to MSLAB, deep clone it while adding to Memstore. 2016-07-27 22:29:26 +05:30
zhangduo bcf409e11f HBASE-16280 Use hash based map in SequenceIdAccounting 2016-07-26 11:31:32 +08:00
Phil Yang 0da8119fbc HBASE-16281 TestMasterReplication is flaky
Signed-off-by: zhangduo <zhangduo@apache.org>
2016-07-26 10:54:46 +08:00
Reid Chan abfd584fe6 HBASE-14743 Add metrics around HeapMemoryManager. (Reid Chan)
Change-Id: I7305f7b7034b216930b5fb5c57de9ba5eabf96d8

Signed-off-by: Apekshit Sharma <appy@apache.org>
2016-07-25 14:32:38 -07:00
Apekshit Sharma eff38ccf8c Revert HBASE-14743 because of wrong attribution. Since I added commit message to the raw patch, it's making me as author instead of Reid. I should have used --author flag to set Reid as author.
This reverts commit 064271da16.
2016-07-25 14:32:38 -07:00
Apekshit Sharma 064271da16 HBASE-14743 Add metrics around HeapMemoryManager. (Reid Chan)
Change-Id: I60b2435355b3e605e7d91cbf5aca5d2988f26f33
2016-07-25 13:45:50 -07:00
anoopsjohn 2df0ef549a HBASE-16205 When Cells are not copied to MSLAB, deep clone it while adding to Memstore. 2016-07-25 22:58:32 +05:30
Phil Yang 6dbce2a8cb HBASE-16266 Do not throw ScannerTimeoutException when catch UnknownScannerException
Signed-off-by: zhangduo <zhangduo@apache.org>
2016-07-25 22:26:19 +08:00