7433 Commits

Author SHA1 Message Date
stack
4565e9f43b HBASE-22723 Have CatalogJanitor report holes and overlaps; i.e. problems it sees when doing its regular scan of hbase:meta
Refactor of CatalogJanitor so it generates a
Report on the state of hbase:meta when it runs. Also
refactor so CJ runs even if RIT (previous it would
punt on running if RIT) so it can generate a 'Report'
on the interval regardless. If RIT, it just doesn't
go on to do the merge/split GC as it used to.

If report finds an issue, dump as a WARN message
to the master log.

Follow-on is to make the Report actionable/available
for the Master to pull when it goes to draw the hbck
UI page (could also consider shipping the Report as
part of ClusterMetrics?)

Adds new, fatter Visitor to CJ, one that generates
Report on each run keeping around more findings as
it runs.

Moved some methods around so class reads better;
previous methods were randomly ordered in the class.

M hbase-client/src/main/java/org/apache/hadoop/hbase/MetaTableAccessor.java
 Make a few handy methods public.

M hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionInfo.java
 Add utility as defaults on the Inteface; i.e. is this the first region
 in table, is it last, does a passed region come next, or does passed
 region overlap this region (added tests for this new stuff).

M hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java
 Bugfix... handle case where buffer passed is null.

M hbase-server/src/main/java/org/apache/hadoop/hbase/master/CatalogJanitor.java
 Lots of change, reorg., but mostly adding consistency checking
 to the visitor used scanning hbase:meta on a period and the
 generation of a Report on what the scan has found traversing
 hbase:meta. Added a main so could try the CatalogJanitor against
 a running cluster.

A hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitorCluster.java
 Fat ugly test for CatalogJanitor consistency checking.

M hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionInfo.java
 Add tests for new functionality in RI.

M hbase-shell/src/main/ruby/hbase/table.rb
 Bug fix for case where meta has a null regioninfo; scan was aborting.

Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
2019-07-29 16:07:10 -07:00
stack
d23236a452 HBASE-22751 table.jsp fails if ugly regions in table 2019-07-29 15:14:41 -07:00
stack
8b1952a42a HBASE-22751 table.jsp fails if ugly regions in table 2019-07-29 15:06:22 -07:00
Venkatesh Sridharan
4a83de75c7 HBASE-22313 Add method to FsDelegation token to accept token kind (#199)
Signed-off-by: stack <stack@apache.org>
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
2019-07-29 11:18:48 +02:00
meiyi
8bd90f2e55 HBASE-22580 Add a table attribute to make user scan snapshot feature configurable for table (#336) 2019-07-29 10:03:54 +08:00
Guanghao Zhang
4c4f0184e0 HBASE-22709 Add a chore thread in master to do hbck checking (#404)
Signed-off-by: stack <stack@apache.org>
2019-07-27 18:31:33 +08:00
Guanghao Zhang
da4d72c2d4 HBASE-22742 [HBCK2] Add more log for hbck operations at master side
Signed-off-by: stack <stack@apache.org>
2019-07-27 12:39:43 +08:00
stack
f7ac3badbc HBASE-22382 Refactor tests in TestFromClientSide; ADDENDUM to fix tests 2019-07-26 13:41:50 -07:00
linkaline
9f961ea1d8 HBASE-22733 TestSplitTransactionOnCluster.testMasterRestartAtRegionSplitPendingCatalogJanitor is flakey (#408)
Signed-off-by: stack <stack@apache.org>
2019-07-25 11:11:46 -07:00
Jan Hentschel
62710d5835 HBASE-22594 Clean up for backup examples (#315)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2019-07-25 15:45:35 +08:00
meiyi
ff9589c9ab HBASE-22578 HFileCleaner should not delete empty ns/table directories used for user san snapshot feature (#337) 2019-07-25 10:52:23 +08:00
Andor Molnár
ed72cd7c1a HBASE-22382 Refactor tests in TestFromClientSide (#385)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2019-07-25 10:41:06 +08:00
Guanghao Zhang
73b2bd5185 HBASE-22721 Refactor HBaseFsck: move the inner class out
Signed-off-by: stack <stack@apache.org>
2019-07-25 08:13:30 +08:00
Jeongdae Kim
f61e987c6a
HBASE-22715 All scan requests should be handled by scan handler threads in RWQueueRpcExecutor (#393)
Signed-off-by: Andrew Purtell <apurtell@apache.org>

Conflicts:
	hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestSimpleRpcScheduler.java
2019-07-24 11:56:54 -07:00
syedmurtazahassan
169abb48c4
HBASE-22603 Javadoc Warnings related to @link tag
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
2019-07-23 14:33:01 +02:00
syedmurtazahassan
fa4466d345 HBASE-22610 [BucketCache] Rename hbase.offheapcache.minblocksize
Signed-off-by: Reid Chan <reidchan@apache.org>
Co-authored-by: Reid Chan <reidchan@apache.org>
2019-07-23 11:17:42 +08:00
Reid Chan
be5e3de8af Revert "HBASE-22610 [BucketCache] Rename hbase.offheapcache.minblocksize"
Reason: Deprecated a wrong parameter.

This reverts commit e95bdf415cea2190083150e3f8f6cea8995550d6.
2019-07-23 11:07:41 +08:00
syedmurtazahassan
e95bdf415c HBASE-22610 [BucketCache] Rename hbase.offheapcache.minblocksize
* Deprecated old attribute and introduced a new one

* Removed unnecessary import

* Added two import configs and removed one

Signed-off-by: Reid Chan <reidchan@apache.org>
2019-07-23 10:42:41 +08:00
Viraj Jasani
3a72ccefbd
HBASE-22648 Snapshot TTL (#371)
Signed-off-by: Reid Chan <reidchan@apache.org>
Signed-off-by: Andrew Purtell <apurtell@apache.org>

Conflicts:
	hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotDescriptionUtils.java
2019-07-22 15:08:20 -07:00
Toshihiro Suzuki
15671e5002 HBASE-22690 Deprecate / Remove OfflineMetaRepair in hbase-2+
Signed-off-by: stack <stack@apache.org>
2019-07-22 23:24:47 +09:00
openinx
6fb03e63b6 HBASE-22663 The HeapAllocationRatio in WebUI is not accurate because all of the heap allocation will happen in another separated allocator named HEAP (#365) 2019-07-20 23:36:21 +08:00
Geoffrey Jacoby
439da96a1c
HBASE-22622 WALKey Extended Attributes (#352)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2019-07-19 15:31:12 -07:00
linkaline
b9b7b6e734 HBASE-21426 TestEncryptionKeyRotation.testCFKeyRotation is flaky (#375)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
2019-07-19 09:43:42 +08:00
Guanghao
4c89354f3b HBASE-22673 Avoid to expose protobuf stuff in Hbck interface
Signed-off-by: stack <stack@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2019-07-19 08:10:38 +08:00
sreenivasulureddy
2fa6d062f5 HBASE-22537 Split happened Replica region can not be deleted after deleting table successfully and restarting RegionServer
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
2019-07-18 15:26:10 +01:00
Guanghao Zhang
22a991e8b6 HBASE-22527 [hbck2] Add a master web ui to show the problematic regions (addendum) 2019-07-18 17:51:27 +08:00
Guanghao Zhang
9e59b7ff5e HBASE-22527 [hbck2] Add a master web ui to show the problematic regions 2019-07-18 08:26:31 +08:00
Guanghao
db4cd6bd45 HBASE-22704 Avoid NPE when access table.jsp and snapshot.jsp but master not finish initialization (#389) 2019-07-18 08:26:20 +08:00
stack
d904344421 HBASE-7191 HBCK - Add offline create/fix hbase.version and hbase.id
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
2019-07-17 07:52:32 -07:00
linkaline
abf3d183cd HBASE-20368 Fix RIT stuck when a rsgroup has no online servers but AM's pendingAssginQueue is cleared (#354)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
2019-07-17 22:11:24 +08:00
Viraj Jasani
6c834b974c
HBASE-22643 : Delete region without archiving only if regiondir is present
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Signed-off-by: Xu Cang <xucang@apache.org>
2019-07-16 17:41:24 -07:00
Duo Zhang
5333d8f1b4 HBASE-22684 The log rolling request maybe canceled immediately in LogRoller due to a race (#378)
Signed-off-by: Michael Stack <stack@apache.org>
2019-07-15 21:52:55 +08:00
syedmurtazahassan
955e643e1d
HBASE-22586 Javadoc Warnings related to @param tag
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
2019-07-13 16:56:53 +02:00
Duo Zhang
3eda33a048 HBASE-22681 The 'assert highestUnsyncedTxid < entry.getTxid();' in AbstractFWAL.append may fail when using AsyncFSWAL (#376)
Signed-off-by: Zheng Hu <openinx@gmail.com>
2019-07-13 22:16:34 +08:00
syedmurtazahassan
b6e66699a9
HBASE-22571 Javadoc Warnings related to @return tag
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
2019-07-13 13:48:45 +02:00
Andrew Purtell
19d8e33798
HBASE-22686 ZkSplitLogWorkerCoordination doesn't allow a regionserver to pick up all of the split work it is capable of (#377)
Signed-off-by: Xu Cang <xcang@apache.org>
2019-07-12 18:12:39 -07:00
Reid Chan
8222631ee3 HBASE-22656 [Metrics] Table metrics 'BatchPut' and 'BatchDelete' are never updated
Signed-off-by: Michael Stack <stack@apache.org>
2019-07-07 23:26:02 +08:00
openinx
f84edde148 HBASE-22582 The Compaction writer may access the lastCell whose memory has been released when appending fileInfo in the final (#341) 2019-07-04 14:30:37 +08:00
haxiaolin
5087fddedf HBASE-22403 Balance in RSGroup should consider throttling and a failure affects the whole
Signed-off-by: Guanghao Zhang <zghao@apache.org>
2019-07-04 08:51:55 +08:00
Guanghao
78f704796e HBASE-22624 Should sanity check table configuration when clone snapshot to a new table 2019-07-03 18:28:48 +08:00
Andor Molnár
2f8ad5a51f HBASE-13798 TestFromClientSide* don't close the Table 2019-07-02 11:29:01 +02:00
Mate Szalay-Beko
ede6a0a97b HBASE-22637 fix flaky test in TestMetaTableMetrics
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
Signed-off-by: Sakthi <sakthivel.azhaku@gmail.com>
2019-07-02 09:37:01 +02:00
Bing Xiao
12c933ac51 HBASE-21751 WAL creation fails during region open may cause region assign forever fail
Signed-off-by: Allan Yang <allan163@apache.org>
    Signed-off-by: Michael Stack <stack@apache.org>
2019-07-01 22:19:42 -07:00
syedmurtazahassan
8fa7800389 HBASE-22572 Javadoc Warnings: @link reference not found (#306)
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
Signed-off-by: stack <stack@apache.org>
2019-07-01 21:18:11 -07:00
Bing Xiao
49a4eeab3b HBASE-22169 Open region failed cause memory leak
Signed-off-by: stack <stack@apache.org>
2019-07-01 13:51:33 -07:00
Duo Zhang
f812352c4e HBASE-22632 SplitTableRegionProcedure and MergeTableRegionsProcedure should skip store files for unknown column families (#344)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
2019-06-27 21:57:11 +08:00
openinx
345f80ea5f HBASE-20060 Add details of off heap memstore into book. (#334) 2019-06-27 16:54:48 +08:00
huzheng
6a3aa789d8 HBASE-22612 Address the final overview reviewing comments of HBASE-21879 2019-06-26 15:40:23 +08:00
openinx
af0e23c359 HBASE-22547 Align the config keys and add document for offheap read in HBase Book. (#301) 2019-06-25 22:25:30 +08:00
openinx
4f1b5ab54e HBASE-22531 The HFileReaderImpl#shouldUseHeap return the incorrect true when disabled BlockCache (#304) 2019-06-25 22:22:23 +08:00