Commit Graph

16470 Commits

Author SHA1 Message Date
Wellington Ramos Chevreuil 5635752179 HBASE-23197 'IllegalArgumentException: Wrong FS' on edits replay when… (#740)
Signed-off-by: Josh Elser <elserj@apache.org>
2019-11-25 08:33:58 +00:00
Karthik Palanisamy 1fa9a8c62a HBASE-23237 Prevent Negative values in metrics requestsPerSecond (#865)
Signed-off-by: Guangxu Cheng <gxcheng@apache.org>
Signed-off-by: Josh Elser <elserj@apache.org>
2019-11-23 23:27:49 +08:00
Peter Somogyi ce34d895e5 HBASE-23085 Network and Data related Actions; ADDENDUM (#871)
Fix percentage in String.format

Signed-off-by: Sean Busbey <busbey@apache.org>
2019-11-22 22:15:27 -06:00
Peter Somogyi c60d11b2ba HBASE-22969 A new binary component comparator(BinaryComponentComparator) to perform comparison of arbitrary length and position; ADDENDUM (#869)
Signed-off-by: Sean Busbey <busbey@apache.org>
2019-11-22 13:51:49 -06:00
Michael Stack c8592f1fb7 HBASE-23307 Add running of ReplicationBarrierCleaner to hbck2 fixMeta invocation (#859)
Signed-off-by: Lijin Bin <binlijin@apache.org>
2019-11-22 08:27:58 -08:00
Michael Stack 12b2e1fd52
HBASE-23328 info:regioninfo goes wrong when region replicas enabled (#863)
Signed-off-by: Ramkrishna <ramkrishna.s.vasudevan@intel.com>
Signed-off-by: Guangxu Cheng <guangxucheng@gmail.com>
2019-11-21 22:57:22 -08:00
xuqinya1 f905bb32c3 HBASE-23325 [UI]rsgoup average load keep two decimals (#860)
Signed-off-by: Guangxu Cheng <gxcheng@apache.org>
2019-11-22 14:34:09 +08:00
Nick Dimiduk bb83a09d15 HBASE-23234 Provide .editorconfig based on checkstyle configuration (#846)
This file is generated using IntelliJ, following these steps:
 #. Open Preferences > Editor > Code Style
 #. Select (config wheel) > Import Schema > CheckStyle Configuration
 #. Select `hbase-checkstyle/src/main/resources/hbase/checkstyle.xml`
 #. Select (config wheel) > Export > EditorConfig File

Signed-off-by: Sean Busbey <busbey@apache.org>
2019-11-21 11:23:51 -08:00
Nick Dimiduk d742112ed9
HBASE-23259: Populate master address end points in cluster/rs configs (#807) (#857)
All the clients need to know the master RPC end points while using master
based registry for creating cluster connections. This patch amends the
test cluster utility to populate these configs in the base configuration
object used to spin up the cluster.

The config key added here ("hbase.master.addrs") is used in the subsequent
patches for HBASE-18095.

Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
2019-11-21 09:43:53 -08:00
stack 126ea28c80 HBASE-23322 [hbck2] Simplification on HBCKSCP scheduling
Signed-off-by: Lijin Bin <binlijin@apache.org>
2019-11-20 21:25:26 -08:00
stack 7e088daf39 HBASE-23321 [hbck2] fixHoles of fixMeta doesn't update in-memory state 2019-11-20 09:02:41 -08:00
stack a05cef75c4 Add status when fixing hole
TODO: Add region to master memory and region state.
2019-11-20 09:02:41 -08:00
Mingliang Liu 95f25fed86 HBASE-22607. TestExportSnapshotNoCluster fails intermittently 2019-11-20 08:41:07 -08:00
stack 70771b603e HBASE-23315 Miscellaneous HBCK Report page cleanup
* Add a bit of javadoc around SerialReplicationChecker.
 * Miniscule edit to the profiler jsp page and then a bit of doc on how to make it work that might help.
 * Add some detail if NPE getting BitSetNode to help w/ debug.
 * Change HbckChore to log region names instead of encoded names; helps doing diagnostics; can take region name and query in shell to find out all about the region according to hbase:meta.
 * Add some fix-it help inline in the HBCK Report page – how to fix.
 * Add counts in procedures page so can see if making progress; move listing of WALs to end of the page.
2019-11-19 07:33:13 -08:00
Baiqiang Zhao c6ad71e256 HBASE-23278 Add a table-level compaction progress display on the UI (#816)
Signed-off-by: Guangxu Cheng <gxcheng@apache.org>
2019-11-19 19:38:43 +08:00
BukrosSzabolcs 54be3d1d86 HBASE-23085 Network and Data related Actions
Add monkey actions:
- manipulate network packages with tc (reorder, loose,...)
- add CPU load
- fill the disk
- corrupt or delete regionserver data files

Extend HBaseClusterManager to allow sudo calls.

Signed-off-by: Josh Elser <elserj@apache.org>
Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
2019-11-19 10:15:35 +01:00
Andrew Purtell 1f9f45ca79
HBASE-23318 LoadTestTool doesn't start (#848)
* Package the test jar from hbase-zookeeper into lib/

Signed-off-by: Duo Zhang <zhangduo@apache.org>
2019-11-18 16:49:50 -08:00
stack 44c8b58cec HBASE-23282 HBCKServerCrashProcedure for 'Unknown Servers'
Have the existing scheduleRecoveries launch a new HBCKSCP
instead of SCP. It gets regions to recover from Master
in-memory context AND from a scan of hbase:meta. This
new HBCKSCP is For processing 'Unknown Servers', servers that
are 'dead' and purged but still have references in
hbase:meta. Rare occurance but needs tooling to address.
Later have catalogjanitor take care of these deviations
between Master in-memory and hbase:meta content (usually
because of overdriven cluster with failed RPCs to hbase:meta,
etc)

Changed expireServers in ServerManager so could pass in
custom reaction to expired server.... This is how we
run our custom HBCKSCP while keeping all other aspects
of expiring services (rather than try replicate it
externally).
2019-11-18 14:26:11 -08:00
Udai Bhan Kashyap ab63bde013 HBASE-22969 A new binary component comparator(BinaryComponentComparator) to perform comparison of arbitrary length and position (#829)
Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
2019-11-18 13:30:08 +01:00
Sean Busbey baf8849050 HBASE-19450 Addendum Limit logging of chore execution time at INFO to once per 5 minutes.
* Ensure MovingAverage related classes are IA.Private
* Move trace logging into MovingAverage class

Signed-off-by: Duo Zhang <zhangduo@apache.org>
2019-11-16 09:40:20 -06:00
Duo Zhang e69431ae8c HBASE-23294 ReplicationBarrierCleaner should delete all the barriers for a removed region which does not belong to any serial replication peer (#827)
Signed-off-by: stack <stack@apache.org>
2019-11-15 19:04:42 +08:00
Reid Chan f5db86ca8f HBASE-19450 Add log about average execution time for ScheduledChore
Signed-off-by: Sean Busbey <busbey@apache.org>
2019-11-14 22:07:02 -06:00
Mingliang Liu d22e6f55d8 HBASE-23283 Provide clear and consistent logging about the period of enabled chores
Signed-off-by: Sean Busbey <busbey@apache.org>
2019-11-14 20:47:01 -06:00
Mingliang Liu b2f3ddeaa9 HBASE-23290 shell processlist command is broken 2019-11-14 16:02:28 -08:00
Viraj Jasani 9cc144e3c7 HBASE-23245 : MutableHistogram constructor changes and provide HistogramImpl maxExpected as long (#787)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Xu Cang <xucang@apache.org> 
Signed-off-by: Guangxu Cheng <gxcheng@apache.org>
2019-11-12 01:03:32 +08:00
Geoffrey Jacoby da06aa7f1f HBASE-23251 - Add Column Family and Table Names to HFileContext and use in HFileWriterImpl logging (#796)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Xu Cang <xucang@apache.org>
Signed-off-by: Zheng Hu <openinx@gmail.com>
2019-11-11 16:22:09 +08:00
Nick Dimiduk f42b2aa108
HBASE-23230 Enforce member visibility in HRegionServer (#775) (#806)
* Clean up a bunch of private variable leakage into other
   classes. Reduces visibility as much as possible, providing getters
   where access remains necessary or making use of getters that
   already exist. There remains an insidious relationship between
   `HRegionServer` and `RSRpcServices`.
 * Rename `fs` to `dataFs`, `rootDir` as `dataRootDir` so as to
   distinguish from the new `walFs`, `walRootDir` (and make it easier
   to spot bugs).
 * Cleanup or delete a bunch of lack-luster javadoc comments.
 * Delete a handful of methods that are unused according to static
   analysis.
 * Reduces the warning count as reported by IntelliJ from 100 to 7.

Signed-off-by: stack <stack@apache.org>
2019-11-08 13:54:02 -08:00
ravowlga123 5dfa58b017
HBASE-18439 Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
Signed-off-by: Guangxu Cheng <gxcheng@apache.org>
2019-11-08 20:26:43 +01:00
Sean Busbey 82037ee3f2 HBASE-23228 Allow for jdk8 specific modules on branch-1 in precommit/nightly testing (#804)
Signed-off-by: Josh Elser <elserj@apache.org>
2019-11-08 10:08:56 -06:00
chenxu14 235d03bc07 HBASE-22888 Share some stuffs with the initial reader when new stream reader created (#581)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2019-11-08 14:30:49 +08:00
Duo Zhang cddf8b0ae4 HBASE-23236 Upgrade to yetus 0.11.1
Signed-off-by: stack <stack@apache.org>
2019-11-08 13:48:07 +08:00
Karthik Palanisamy 10b38d5f82 HBASE-23263 NPE in Quotas.jsp (#800)
Signed-off-by: Guangxu Cheng <guangxucheng@gmail.com>
2019-11-08 09:56:35 +08:00
Karthik Palanisamy 0a20c4010f HBASE-23262 Cannot load Master UI (#799)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2019-11-08 09:50:32 +08:00
lijinbin e8c16a2fb9 HBASE-22480 Get block from BlockCache once and return this block to BlockCache twice make ref count error. 2019-11-08 09:35:37 +08:00
Shardul Singh d1864ae8af HBASE-22980 HRegionPartioner getPartition() method incorrectly partitions the regions of the table. (#590)
Signed-off-by: Michael Stack <stack@apache.org>
Signed-off-by: Guangxu Cheng <guangxucheng@gmail.com>
2019-11-07 10:08:03 +08:00
Viraj Jasani 29c27e3d04
HBASE-23212 Dynamically reload configs for Region Recovery chore (#802)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2019-11-06 15:54:57 -08:00
Michael Stack ea20bb35be HBASE-21458 Error: Could not find or load main class org.apache.hadoop.hbase.util.GetJavaProperty
Signed-off-by: Sean Busbey <busbey@apache.org>
2019-11-05 22:55:13 -06:00
ravowlga123 d4c23ee0c6
HBASE-23250 Log message about CleanerChore delegate initialization should be at INFO
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
2019-11-05 20:23:37 +01:00
Josh Elser 46a18833a0 HBASE-23082 Backport of low latency space quotas for hbase snapshots
Includes the following, incorporating HBASE-20439 and HBASE-20440, too.

1)
HBASE-18133 Decrease quota reaction latency by HBase

Certain operations in HBase are known to directly affect
the utilization of tables on HDFS. When these actions
occur, we can circumvent the normal path and notify the
Master directly. This results in a much faster response to
changes in HDFS usage.

This requires FS scanning by the RS to be decoupled from
the reporting of sizes to the Master. An API inside each
RS is made so that any operation can hook into this call
in the face of other operations (e.g. compaction, flush,
bulk load).

2)
HBASE-18135 Implement mechanism for RegionServers to report file archival for space quotas

This de-couples the snapshot size calculation from the
SpaceQuotaObserverChore into another API which both the periodically
invoked Master chore and the Master service endpoint can invoke. This
allows for multiple sources of snapshot size to reported (from the
multiple sources we have in HBase).

When a file is archived, snapshot sizes can be more quickly realized and
the Master can still perform periodical computations of the total
snapshot size to account for any delayed/missing/lost file archival RPCs.

3)
HBASE-20531 RS may throw NPE when close meta regions in shutdown procedure.
2019-11-04 16:54:18 -05:00
Michael Stack ac0a605ee9 HBASE-23243 [pv2] Filter out SUCCESS procedures; on decent-sized cluster, plethora overwhelms problems (#790)
Signed-off-by: GuangxuCheng  <guangxucheng@gmail.com>
Signed-off-by: Sean Busbey <busbey@apache.org>
2019-11-04 09:17:47 -08:00
Michael Stack 4f39b93a34 HBASE-23247 [hbck2] Schedule SCPs for 'Unknown Servers' (#791)
Signed-off-by: Sean Busbey <busbey@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2019-11-04 09:01:25 -08:00
binlijin c8c8eef0d4 HBASE-23241 TestExecutorService sometimes fail (#782)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
2019-11-04 17:19:13 +08:00
stack df04fbc6db HBASE-23244 NPEs running Canary (#784)
Addendum to fix findbugs complaint.
2019-11-02 09:34:53 -07:00
Michael Stack 74e17be4e2
HBASE-23244 NPEs running Canary (#784)
Signed-off-by: Viraj Jasani <virajjasani007@gmail.com>
2019-11-01 21:40:23 -07:00
Wellington Chevreuil 18f1aacae0 HBASE-23238 Additional test and checks for null references on ScannerCallableWithReplicas (#780)
Signed-off-by: Sean Busbey <busbey@apache.org>
(cherry picked from commit 577db5d7e5)
2019-11-01 10:32:12 +00:00
stack 55210571c2 Revert "HBASE-22917 Proc-WAL roll fails saying someone else has already created log (#544)"
This reverts commit 834f7bf970.
2019-10-31 10:37:08 -07:00
stack 97644e20bb Revert "Revert "HBASE-23191 EOFE log spam (#733)""
Reapply. Reverted wrong commit.

This reverts commit 87b4cfabda.
2019-10-31 10:35:39 -07:00
stack 87b4cfabda Revert "HBASE-23191 EOFE log spam (#733)"
This reverts commit f0c38e8ae6.
2019-10-31 08:11:21 -07:00
chenxu14 26663585de HBASE-23184 The HeapAllocation in WebUI is not accurate (#730)
Signed-off-by: stack <stack@apache.org>
2019-10-31 17:57:52 +08:00
Michael Stack 471538ca9e HBASE-23221 Polish the WAL interface after HBASE-23181 (#774)
Removes the closeRegion flag added by HBASE-23181 and instead
relies on reading meta WALEdit content. Modified how qualifier is
written when the meta WALEdit is for a RegionEventDescriptor
so the 'type' is added to the qualifer so can figure type
w/o having to deserialize protobuf value content: e.g.
HBASE::REGION_EVENT::REGION_CLOSE

Added doc on WALEdit and tried to formalize the 'meta' WALEdit
type and how it works. Needs complete redo in part as suggested
by HBASE-8457. Meantime, some doc and cleanup.

Also changed the LogRoller constructor to remove redundant param.
Because of constructor change, need to change also
TestFailedAppendAndSync, TestWALLockup, TestAsyncFSWAL &
WALPerformanceEvaluation.java

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Lijin Bin <binlijin@apache.org>
2019-10-30 22:10:51 -07:00