e7eb628025
HBASE-26922 Fix LineLength warnings as much as possible if it can not be fixed by spotless ( #4324 )
...
Signed-off-by: Yulin Niu <niuyulin@apache.org
(cherry picked from commit 3ae0d9012c
2022-04-09 23:13:49 +08:00
197b8d48ec
HBASE-26928 Fix several indentation problems ( #4323 )
...
Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>
(cherry picked from commit e68c61dd54
2022-04-06 15:14:03 +08:00
455b7c701f
HBASE-26903 Bump httpclient from 4.5.3 to 4.5.13 ( #4296 )
...
Bump httpclient from 4.5.3 to 4.5.13 to avoid a CVE of medium severity in this
dependency.
Newer httpclient versions enable a URI normalization algorithm by default that
rewrites URIs in a way that breaks some forms of valid REST gateway interactions,
so disable it when building the httpclient instance in Client.
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Pankaj Kumar <pankajkumar@apache.org>
2022-03-30 14:31:24 -07:00
ba14796289
Revert "HBASE-26813 Remove javax.ws.rs-api dependency ( #4191 )"
...
MiniYARNCluster needs it
This reverts commit abde344767
2022-03-19 19:45:29 +08:00
d09b04df64
HBASE-26855 Delete unnecessary dependency on jaxb-runtime jar ( #4236 )
...
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-03-18 19:13:37 +01:00
abde344767
HBASE-26813 Remove javax.ws.rs-api dependency ( #4191 )
...
This is no longer needed since we've transitioned to the shaded Jersey shipped in
hbase-thirdparty. Also drop supplemental models entry.
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-03-16 17:24:20 +01:00
9e1de13d03
HBASE-25465 Use javac --release option for supporting cross version compilation ( #4164 )
...
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-03-12 18:30:29 +08:00
340cc6c6f1
HBASE-26802 Backport the log4j2 changes to branch-2 ( #4166 )
...
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-03-11 11:17:43 -08:00
300f9b9576
HBASE-26582 Prune use of Random and SecureRandom objects ( #4118 )
...
Avoid the pattern where a Random object is allocated, used once or twice, and
then left for GC. This pattern triggers warnings from some static analysis tools
because this pattern leads to poor effective randomness. In a few cases we were
legitimately suffering from this issue; in others a change is still good to
reduce noise in analysis results.
Use ThreadLocalRandom where there is no requirement to set the seed to gain
good reuse.
Where useful relax use of SecureRandom to simply Random or ThreadLocalRandom,
which are unlikely to block if the system entropy pool is low, if we don't need
crypographically strong randomness for the use case. The exception to this is
normalization of use of Bytes#random to fill byte arrays with randomness.
Because Bytes#random may be used to generate key material it must be backed by
SecureRandom.
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-03-08 15:22:00 -08:00
4644efb9f3
HBASE-26691 Replacing log4j with reload4j for branch-2.x ( #4050 )
...
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-03-04 12:06:34 -08:00
7f30aa8b63
HBASE-23303 Add default security headers if SSL is enabled ( #4128 )
...
Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
2022-03-02 15:28:45 +01:00
e1131a2608
HBASE-26767 Rest server should not use a large Header Cache.
...
Closes #4123
Co-authored-by: Tak Lon (Stephen) Wu <taklwu@apache.org>
Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org>
Signed-off-by: Josh Elser <elserj@apache.org>
2022-02-23 15:37:03 -05:00
e53712ae99
HBASE-26523 Upgrade hbase-thirdparty dependency to 4.0.1 ( #3988 )
...
Signed-off-by: GeorryHuang <huangzhuoyue@apache.org>
2021-12-31 12:10:08 +08:00
b1bc5f3a5c
Renumber to 2.6.0-SNAPSHOT after branching branch-2.5
...
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2021-12-08 16:54:32 -08:00
a4e8ee183e
HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime ( #3302 )
...
We introduced EnvironmentEdgeManager as a way to inject alternate clocks
for unit tests. In order for this to be effective, all callers that would
otherwise use System.currentTimeMillis() must call
EnvironmentEdgeManager.currentTime() instead, except the implementers of
EnvironmentEdge.
Signed-off-by: Bharath Vissapragada <bharathv@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Conflicts:
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManager.java
hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupBase.java
hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupManager.java
hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupSystemTable.java
hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncConnectionTracing.java
hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncRegionLocatorTracing.java
hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestBackupRestore.java
hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestManyRegions.java
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/MoveRegionsOfTableAction.java
hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestWALRecordReader.java
hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/replication/TestVerifyReplicationCrossDiffHdfs.java
hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/snapshot/TestExportSnapshotV1NoCluster.java
hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestEnableRSGroups.java
hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsAdmin2.java
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/CallRunner.java
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/SimpleRpcServer.java
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionStateStore.java
hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/SimpleLoadBalancer.java
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/AbstractWALRoller.java
hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
hbase-server/src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java
hbase-server/src/test/java/org/apache/hadoop/hbase/TestMetaTableAccessor.java
hbase-server/src/test/java/org/apache/hadoop/hbase/TestMetaUpdatesGoToPriorityQueue.java
hbase-server/src/test/java/org/apache/hadoop/hbase/TestSerialization.java
hbase-server/src/test/java/org/apache/hadoop/hbase/backup/TestHFileArchiving.java
hbase-server/src/test/java/org/apache/hadoop/hbase/client/RestoreSnapshotFromClientSimpleTestBase.java
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin2.java
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestConnection.java
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide3.java
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMobCloneSnapshotFromClientCloneLinksAfterDelete.java
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMutationGetCellBuilder.java
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestSnapshotMetadata.java
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestActiveMasterManager.java
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterMetricsWrapper.java
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMetaAssignmentWithStopMaster.java
hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestRegionStateStore.java
hbase-server/src/test/java/org/apache/hadoop/hbase/master/cleaner/TestLogsCleaner.java
hbase-server/src/test/java/org/apache/hadoop/hbase/master/cleaner/TestReplicationHFileCleaner.java
hbase-server/src/test/java/org/apache/hadoop/hbase/master/janitor/TestCatalogJanitor.java
hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/MasterProcedureSchedulerPerformanceEvaluation.java
hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestCloneSnapshotProcedure.java
hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestRestoreSnapshotProcedure.java
hbase-server/src/test/java/org/apache/hadoop/hbase/procedure2/store/region/RegionProcedureStorePerformanceEvaluation.java
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionInfo.java
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHStoreFile.java
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMajorCompaction.java
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionOpen.java
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSimpleTimeRangeTracker.java
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestWideScanner.java
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/compactions/TestCloseChecker.java
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/AbstractTestProtobufLog.java
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/AbstractTestWALReplay.java
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestCombinedAsyncWriter.java
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/master/TestRecoverStandbyProcedure.java
hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestFlushSnapshotFromClient.java
hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestSyncReplicationWALProvider.java
hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java
2021-06-01 12:41:15 -07:00
9beb278d8b
HBASE-25941 TestRESTServerSSL fails because of jdk bug ( #3335 )
...
Signed-off-by: Wei-Chiu Chuang weichiu@apache.org
2021-05-30 21:33:34 -07:00
1ca85017f7
HBASE-25374 Make REST Client connection and socket time out configurable ( #2752 )
...
Signed-off-by: Guanghao Zhang <zghao@apache.org>
Signed-off-by: stack <stack@apache.org>
2021-03-15 16:46:04 -07:00
aafbbc2456
HBASE-25657 Fix spotbugs warnings after upgrading spotbugs to 4.x ( #3041 )
...
Signed-off-by: meiyi <myimeiyi@gmail.com>
Signed-off-by: stack <stack@apache.org>
2021-03-12 14:37:17 +08:00
0788547fea
HBASE-25474 : Bump HBase version on branch-2 ( #2871 )
...
Signed-off-by: stack <stack@apache.org>
2021-01-12 10:20:22 +05:30
9325a775fe
HBASE-25452 Use MatcherAssert.assertThat instead of org.junit.Assert.assertThat ( #2826 )
...
Signed-off-by: Guanghao Zhang <zghao@apache.org>
2020-12-30 10:03:39 +08:00
3775464981
HBASE-25242 Add Increment/Append support to RowMutations ( #2711 )
...
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2020-11-27 03:53:19 +09:00
5ce3e3e12c
HBASE-24268 REST and Thrift server do not handle the "doAs" parameter case insensitively
...
Closes #1843
Signed-off-by: Josh Elser <elserj@apache.org>
Signed-off-by: Sean Busbey <busbey@apache.org>
2020-11-24 12:25:46 -05:00
873bef1d7e
HBASE-25267 Add SSL keystore type and truststore related configs for HBase RESTServer ( #2642 )
...
HBASE-25267 Make SSL keystore type configurable in HBase RESTServer
In this patch I want to introduce the hbase.rest.ssl.keystore.type parameter,
enabling us to customize the keystore type for the REST server. If the
parameter is not provided, then we should fall-back to the current behaviour
(which assumes keystore type JKS).
This is similar to how we already configure the InfoServer objects with the
ssl.server.keystore.type parameter to set up HTTPS for the various admin UIs.
Signed-off-by: Wellington Chevreuil <wellington.chevreuil@gmail.com>
Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
Signed-off-by: Sean Busbey <busbey@apache.org>
2020-11-12 12:43:58 +01:00
21b32d9a6f
HBASE-24667 Rename configs that support atypical DNS set ups to put them in hbase.unsafe
...
Closes #2542
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
2020-11-09 12:41:04 +05:30
d638ec26ff
HBASE-24976 REST Server failes to start without any error message
...
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: Guanghao Zhang <zghao@apache.org>
2020-09-21 08:29:56 +08:00
7aa36ae10a
HBASE-24481 REST - Fix incorrect response code of get-regions in rest api
...
Closes #2425
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2020-09-19 19:50:12 +05:30
4e50269889
HBASE-24944 Remove MetaTableAccessor.getTableRegionsAndLocations in hbase-rest module ( #2302 )
...
Signed-off-by: Guanghao Zhang <zghao@apache.org>
2020-08-25 16:52:59 +08:00
4455856e9c
HBASE-23834 HBase fails to run on Hadoop 3.3.0/3.2.2/3.1.4 due to jetty version mismatch ( #2222 )
...
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: Josh Elser <elserj@apache.org>
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
2020-08-25 15:02:55 +08:00
4667a971b1
HBASE-24912 Enlarge MemstoreFlusherChore/CompactionChecker period for unit test ( #2285 )
...
Signed-off-by: stack <stack@apache.org>
2020-08-21 12:42:11 +08:00
3c91c33452
HBASE-24696 Include JVM information on Web UI under "Software Attributes"
...
Closes #2087
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
2020-07-21 16:55:44 +05:30
f771fd26b4
HBASE-24650 Change the return types of the new checkAndMutate methods introduced in HBASE-8458 ( #2033 )
...
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2020-07-08 08:00:48 +09:00
6ff6fe49a3
HBASE-8458 Support for batch version of checkAndMutate() ( #1897 )
...
Signed-off-by: Josh Elser <elserj@apache.org>
2020-06-14 13:55:06 +09:00
dc2146069c
HBASE-24309 Avoid introducing log4j and slf4j-log4j dependencies for … ( #1697 )
...
Signed-off-by: stack <stack@apache.org>
2020-05-13 17:59:21 +08:00
f41c9038e7
HBASE-24333 Backport HBASE-24304 "Separate a hbase-asyncfs module" to branch-2.x ( #1664 )
...
Signed-off-by: stack <stack@apache.org>
2020-05-09 12:00:45 +08:00
80561504d2
HBASE-24284 [h3/jdk11] REST server won't start Exclude transitive includes of jax-rs 1.x and then explicitly include jax-rs 2.x glassfish impl for REST context when hadoop3. ( #1625 )
2020-05-05 15:27:11 -07:00
337529ba2c
HBASE-24303 Undo core of parent TestSecureRESTServer change; use fix over in HBASE-24280 instead ( #1630 )
2020-05-04 10:12:32 -07:00
3b0812d3e1
HBASE-24215 [Flakey Tests] [ERROR] TestSecureRESTServer java.lang.NoClassDefFoundError: com/sun/jersey/core/spi/factory/AbstractRuntimeDelegate
...
Addendum #2 : Add jersey-servlet to hadoop3 profile.
2020-04-28 20:18:31 -07:00
da92d016c4
HBASE-24215 [Flakey Tests] [ERROR] TestSecureRESTServer java.lang.NoClassDefFoundError: com/sun/jersey/core/spi/factory/AbstractRuntimeDelegate
...
Second attempt. Made the hadoop3 profile in top-level pom same as it is
for hadoop2 when it comes to exclusions. Then backed out previous
attempt mostly. Made the failing test medium-sized so it ran in its
own jvm.
2020-04-23 22:22:35 -07:00
6c69b65e4f
HBASE-24215 [Flakey Tests] [ERROR] TestSecureRESTServer java.lang.NoClassDefFoundError: com/sun/jersey/core/spi/factory/AbstractRuntimeDelegate ( #1553 )
2020-04-20 21:51:16 -07:00
2905507ce2
HBASE-24115 Relocate test-only REST "client" from src/ to test/ and mark Private ( #1434 )
...
Signed-off-by: Sean Busbey <busbey@apache.org>
Signed-off-by: Zach York <zyork@apache.org>
Signed-off-by: Reid Chan <reidchan@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: Josh Elser <elserj@apache.org>
2020-04-06 17:06:04 -07:00
a867464f5a
HBASE-24041 [regression] Increase RESTServer buffer size back to 64k ( #1339 )
...
* HBASE-24041 [regression] Increase RESTServer buffer size back to 64k
* HBASE-24041 [regression] Increase RESTServer buffer size back to 64k
2020-03-25 17:00:40 -05:00
ffb2359146
HBASE-24013 Bump branch-2 version to 2.4.0-SNAPSHOT ( #1309 )
...
Increment version in poms with
```
$ mvn org.codehaus.mojo:versions-maven-plugin:2.7:set -DnewVersion=2.4.0-SNAPSHOT -DgenerateBackupPoms=false
```
Verified no dangling references with
```
$ find . -iname '*pom.xml' -exec grep -n '2.3.0-SNAPSHOT' {} +
```
Verified build with
```
$ JAVA_HOME=/Library/Java/JavaVirtualMachines/adoptopenjdk-8.jdk/Contents/Home mvn clean package -DskipTests
$ JAVA_HOME=/Library/Java/JavaVirtualMachines/adoptopenjdk-11.jdk/Contents/Home mvn clean package -DskipTests -Dhadoop.profile=3.0
```
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
2020-03-19 08:01:43 -07:00
292cadf847
HBASE-23971 protoc warns: "no protobuf syntax specified"
2020-03-17 15:38:50 -07:00
7eeb6a0815
HBASE-23077 move entirely to spotbugs ( #1265 )
...
Signed-off-by: Sean Busbey <busbey@apache.org>
2020-03-12 11:42:23 +08:00
2655f9647e
HBASE-23956 Use less resources running tests ( #1266 )
...
Add being able to configure netty thread counts. Enable socket reuse
(should not have any impact).
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/BlockingRpcConnection.java
Rename the threads we create in here so they are NOT named same was
threads created by Hadoop RPC.
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/DefaultNettyEventLoopConfig.java
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcClient.java
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AsyncFSWAL.java
Allow configuring eventloopgroup thread count (so can override for
tests)
hbase-examples/src/main/java/org/apache/hadoop/hbase/client/example/HttpProxyExample.java
Enable socket resuse.
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcServer.java
Enable socket resuse and config for how many threads to use.
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
hbase-server/src/main/java/org/apache/hadoop/hbase/util/ModifyRegionUtils.java
Thread name edit; drop the redundant 'Thread' suffix.
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/HFileReplicator.java
Make closeable and shutdown executor when called.
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java
Call close on HFileReplicator
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationBase.java
HDFS creates lots of threads. Use less of it so less threads overall.
hbase-server/src/test/resources/hbase-site.xml
hbase-server/src/test/resources/hdfs-site.xml
Constrain resources when running in test context.
hbase-server/src/test/resources/log4j.properties
Enable debug on netty to see netty configs in our log
pom.xml
Add system properties when we launch JVMs to constrain thread counts in
tests
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2020-03-11 10:25:11 -07:00
c3edceb6ae
HBASE-23146 Support CheckAndMutate with multiple conditions ( #1209 )
...
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2020-03-04 15:08:31 +09:00
f6a2238889
HBASE-23661 Reduced number of Checkstyle violations in hbase-rest
...
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2020-01-19 18:17:14 +01:00
954b602a59
HBASE-23646 Resolved remaining Checkstyle violations in tests of hbase-rest
...
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2020-01-11 21:12:14 +01:00
b81685cfcc
HBASE-23623 Reduced the number of Checkstyle violations in hbase-rest
...
Signed-off-by: stack <stack@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2020-01-02 00:42:13 +01:00
188742a82f
HBASE-23303 Add security headers to REST server/info page ( #843 )
...
Signed-off-by: Toshihiro Suzuki <brfrn169@gmail.com>
Signed-off-by: Sean Busbey <busbey@apache.org>
2019-12-08 22:10:41 +09:00
Duo Zhang
Andrew Purtell
Nick Dimiduk
Andor Molnár
Sergey Soldatov
Michael Stack
Pankaj
Viraj Jasani
Toshihiro Suzuki
Richard Antal
Mate Szalay-Beko
gvprathyusha6
lujiefsi
KevinSmile
Guanghao Zhang
Mingliang Liu
stack
Esteban Gutierrez
wen_yi
Jan Hentschel