18472 Commits

Author SHA1 Message Date
Nick Dimiduk
1e6d93a789 HBASE-26986 Trace a one-shot execution of a Master procedure
This one adds a tracing context to the Master's ProcedureV2 execution. This ties all the spans
that result from a procedure execution back to a procedure by name. Maybe in a follow-on issue, we
can serialize span context along with procedures and display procedure start/stop/retry events and
parent-child hierarchy in tracing visualization.

Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-05-18 13:08:27 +02:00
Nick Dimiduk
71bd62da41 Revert "HBASE-26856:BufferedDataBlockEncoder.OnheapDecodedCell value can get corrupted (#4394)"
This reverts commit de9a17e75cc80e7a473f1a4269092a557b1105a0.
2022-05-18 13:03:16 +02:00
Mohammad Arshad
de9a17e75c HBASE-26856:BufferedDataBlockEncoder.OnheapDecodedCell value can get corrupted (#4394)
Created OnheapDecodedCell and OffheapDecodedExtendedCell objects with duplicate copy of ByteBuffer's underlying array instead of original ByteBuffer

Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Pankaj Kumar<pankajkumar@apache.org>
(cherry picked from commit c198f23e5eb078abc47d4c3439477c6c2b4d5136)
2022-05-17 10:58:06 +05:30
litao
31f4b422ab HBASE-27032 The draining region servers metric description is incorrect (#4428)
Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>
Signed-off-by: Pankaj Kumar<pankajkumar@apache.org>
(cherry picked from commit ed1665355a221f9f36ce7c8905d9ed063c6e9eac)
2022-05-17 10:38:15 +05:30
Andrew Purtell
2efaa7d221 HBASE-27019 Minor compression performance improvements (#4420)
TRACE level logging is expensive enough to warrant removal. They were
useful during development but are now just overhead.

Also we unnecessarily create new compressor and decompressor instances
in the reset() methods for the Aircompressor and Lz4 codecs. Remove.

Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>
2022-05-13 18:30:54 -07:00
Rushabh Shah
7bc7eb5f48 HBASE-26905 ReplicationPeerManager#checkPeerExists should throw ReplicationPeerNotFoundException if peer doesn't exists (#4422)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-05-13 18:25:19 -07:00
Tak Lon (Stephen) Wu
43e8c11989 HBASE-27013 Introduce read all bytes when using pread for prefetch (#4414)
- introduce optional flag `hfile.pread.all.bytes.enabled` for pread that must read full bytes with the next block header

Signed-off-by: Josh Elser <elserj@apache.org>
2022-05-13 13:14:17 -07:00
Duo Zhang
62dbae2914 HBASE-26999 Addendum fix spotless errors 2022-05-13 09:57:26 +08:00
Wellington Chevreuil
930bc5368c HBASE-27021 StoreFileInfo should set its initialPath in a consistent way
(Amending spotless errors after revert by Duo)
2022-05-12 10:53:19 +01:00
Duo Zhang
e3359efe7a Revert "HBASE-27021 StoreFileInfo should set its initialPath in a consistent way (#4419)"
Revert due to failure spotless:check

This reverts commit aa31b0f695ab02015a7a183aaf10ac9963a22ddb.
2022-05-12 10:53:10 +01:00
Wellington Ramos Chevreuil
b7647d8d5f HBASE-27021 StoreFileInfo should set its initialPath in a consistent way (#4419)
Signed-off-by: Josh Elser <elserj@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-05-12 10:52:47 +01:00
litao
5cfce692a5
HBASE-27003 Optimize log format for PerformanceEvaluation (#4411)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2022-05-10 22:32:36 -07:00
Wellington Ramos Chevreuil
7b7f57619b HBASE-26999 HStore should try write WAL compaction marker before repl… (#4407)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-05-09 11:00:26 +01:00
skysiders
ad2180b75d
HBASE-26994 MasterFileSystem create directory without permission check (#4391)
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2022-05-08 13:28:40 -07:00
Andrew Purtell
6cd31edf5c HBASE-26330 Document new provided compression codecs (#4396)
Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>
Signed-off-by: Viraj Jasani<virajjasani@apache.org
2022-05-07 11:26:14 -07:00
Rushabh Shah
f5a08063b6
HBASE-26963 ReplicationSource#removePeer hangs if we try to remove bad peer. (#4413)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-05-07 10:38:17 -07:00
litao
91eab0b657
HBASE-27000 Block cache stats (Misses Caching) display error in RS web UI (#4406)
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2022-05-05 23:35:09 -07:00
huaxiangsun
8703cacba5
HBASE-26984 Chaos Monkey thread dies in ITBLL Chaos GracefulRollingRestartRsAction (#4383) (#4408)
There are two cases here:
  1. Chaos Monkey thread died and there is no chaos after that.
  2. Sometimes, regions are being moved back too quick that region server has not finished its initliazation yet.
     wait sometime to make sure that region server finishes its initialization.

Signed-off-by:  Wellington Chevreuil <wellington.chevreuil@gmail.com>
2022-05-05 13:43:15 -05:00
LiangJun He
cb61d6a4bd HBASE-26977 HMaster's ShutdownHook does not take effect, if tablesOnMaster is false (#4397)
Signed-off-by: Yu Li <liyu@apache.org>
2022-05-05 21:55:50 +08:00
Duo Zhang
9a41117ca5
HBASE-26995 Remove ref guide check in pre commit and nightly for branches other than master (#4399)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
2022-05-05 18:25:22 +08:00
Bryan Beaudreault
a0258441ab HBASE-26990 Add default implementation for BufferedMutator interface setters (#4387)
Signed-off-by: Josh Elser <elserj@apache.org>
2022-05-03 14:59:54 -04:00
Duo Zhang
3bafbf1cd2 HBASE-26892 Add spotless:check in our pre commit general check (#4393)
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
(cherry picked from commit 386869a428bc6256d44436cd4cd5d668a919aacd)
2022-05-03 21:19:26 +08:00
Nick Dimiduk
1b5c881ffb HBASE-26648 Improve fidelity of RegionLocator spans (addendum)
Addendum extends the test case to cover both `RpcConnectionRegistry` and `ZKConnectionRegistry`.
2022-05-03 13:40:42 +02:00
Nick Dimiduk
a38716ca2a HBASE-26648 Improve fidelity of RegionLocator spans
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-05-03 13:40:42 +02:00
d-c-manning
be8a9a5920 HBASE-26989 TestStochasticLoadBalancer fixes for performance and consistency (#4385)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Reviewed by: Rushabh Shah <shahrs87@gmail.com>

Conflicts:
	hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancer.java
2022-05-02 10:51:37 -07:00
Duo Zhang
1a5b1b266c HBASE-26899 Run spotless:apply 2022-05-01 22:41:49 +08:00
Duo Zhang
731da45b91 HBASE-26899 tweak pom and formatter
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
(cherry picked from commit 0edecbf9e00fa33ff163af2b7098873e0c84a34e)
2022-05-01 22:20:12 +08:00
Andrew Purtell
191e932944 HBASE-26992 Brotli compressor has unexpected behavior during reinitialization (#4389)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-04-30 09:12:35 -07:00
d-c-manning
afb8afd26c HBASE-26988 dynamic configuration of loadbalance.bytable (#4384)
Signed-off-by: Andrew Purtell <apurtell@apache.org>

Conflicts:
	hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
2022-04-29 15:55:16 -07:00
Duo Zhang
0a0bea64f7 HBASE-26917 Do not add --threads when running 'mvn site' (#4354)
Signed-off-by: GeorryHuang <huangzhuoyue@apache.org>
(cherry picked from commit f4eb9071fdc3293be91a8f12570b4191543a4211)
2022-04-29 17:49:26 +08:00
LiangJun He
e9c9418d1d HBASE-26943 HMaster page style display confusion (#4369)
Signed-off-by: Yu Li <liyu@apache.org>
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
2022-04-29 15:59:53 +08:00
Duo Zhang
30908482c5
HBASE-26932 Skip generating ref guide when running 'mvn site' on branch other than master (#4360)
Signed-off-by: GeorryHuang <huangzhuoyue@apache.org>
2022-04-29 08:05:24 +08:00
d-c-manning
fd2e7205ac HBASE-22349 slop in StochasticLoadBalancer (#4371)
Signed-off-by: Andrew Purtell <apurtell@apache.org>

Conflicts:
	hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.java
	hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/BalancerTestBase.java
2022-04-28 12:38:50 -07:00
liangxs
895e0f474a HBASE-26975 Add on heap and off heap memstore info in rs web UI (#4368)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit cdf81ea5cca16cec3b854ac67bc08c43c489918b)
2022-04-28 23:15:10 +08:00
liangxs
ea5c5da1b3 HBASE-26980 Update javadoc of BucketCache.java (#4374)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit c02e7553d46ddfb3b0911240f6edd4b900b869b6)
2022-04-28 23:11:51 +08:00
Andrew Purtell
6813a5c502 HBASE-26979 StoreFileListFile logs frequent stacktraces at INFO level (#4373)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-04-27 18:02:18 -07:00
Bri Augenreich
c2baa1fb7b HBASE-26581 Add metrics for failed replication edits (#4347)
Co-authored-by: Briana Augenreich <baugenreich@hubspot.com>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
2022-04-26 17:44:01 -04:00
Bryan Beaudreault
2fe5a4fa4b
HBASE-26807 Addendum: adhere to maxAttempts in RawAsyncTableImpl.batch (#4370)
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
2022-04-25 13:25:05 -04:00
Wellington Ramos Chevreuil
c9d833ed5e HBASE-26971 SnapshotInfo --snapshot param is marked as required even when trying to list all snapshots (#4366)
Signed-off-by: Josh Elser <elserj@apache.org>
(cherry picked from commit af13c6d4c67757c8029ae5e546ba1f2d1e9a4299)
2022-04-25 14:18:57 +01:00
Andrew Purtell
0f9f6f2cde HBASE-26959 Brotli compression support (#4353)
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
2022-04-22 16:48:04 -07:00
Ruanhui
8d17241ce0
HBASE-26942 cache region locations when getAllRegionLocations (#4364)
Co-authored-by: huiruan <huiruan@tencent.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
2022-04-22 15:30:26 -04:00
Bryan Beaudreault
e5b008418f
HBASE-26891 Make MetricsConnection scope configurable (#4365)
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
2022-04-22 11:42:28 -04:00
Bryan Beaudreault
2240025349
HBASE-26807 Unify CallQueueTooBigException special pause with CallDroppedException (#4273)
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
2022-04-22 08:56:52 -04:00
Duo Zhang
edbe44b0d1 HBASE-25058 Export necessary modules when running under JDK11 (#4337)
Singed-off-by: Nick Dimiduk <ndimiduk@apache.org>
(cherry picked from commit 82e47cde27c1db91a685cff38c44a5572194f988)
2022-04-21 23:50:08 +08:00
Duo Zhang
d7e6baf758 HBASE-26947 Implement a special TestAppender to limit the size of test output (#4340)
Singed-off-by: Nick Dimiduk <ndimiduk@apache.org>
(cherry picked from commit 13d932cba321719e63d0b4419f3379c3ca81ab66)
2022-04-21 23:06:53 +08:00
Nick Dimiduk
a81b369157 HBASE-26906 Remove duplicate dependency declaration
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-04-19 16:05:24 +02:00
Duo Zhang
085c65107e HBASE-26941 LocalHBaseCluster.waitOnRegionServer should not call join while interrupted (#4352)
Signed-off-by: Xin Sun <ddupgs@gmail.com>
(cherry picked from commit 35aa57e4452c6f0a7f5037371edca64163913345)
2022-04-17 23:26:56 +08:00
Duo Zhang
ae8eccd5c0 HBASE-26938 Compaction failures after StoreFileTracker integration (#4350)
Introduce a StoreFileWriterCreationTracker to track the store files being written

Signed-off-by: Josh Elser <elserj@apache.org>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
(cherry picked from commit 48c4a4626e54724beb4ed46becbedbe292841dc4)
2022-04-17 22:44:44 +08:00
Duo Zhang
bbe048c1e5 HBASE-26946 TestRetainAssignmentOnRestartSplitWithoutZk infinite loop (#4344)
Signed-off-by: Xin Sun <ddupgs@gmail.com>
(cherry picked from commit 2622fa05a6aa9e0b57d9d15cf243af11927e9a2d)
2022-04-16 13:23:57 +08:00
Pankaj
c76daa1cc8 HBASE-26944 Possible resource leak while creating new region scanner (#4339)
* HBASE-26944 Possible resource leak while creating new region scanner

Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 62e3efccef766e580642a8b7cb5654c96e47687d)
2022-04-15 11:37:58 +05:30