Commit Graph

6384 Commits

Author SHA1 Message Date
tedyu 2f5ca9010b HBASE-19677 Miscellaneous HFileCleaner Improvements (BELUGA BEHR) 2017-12-31 09:47:53 -08:00
Xiang Li 5b3513a5ee HBASE-19672 Correct comments for default values of major compaction in SortedCompactionPolicy#getNextMajorCompactTime()
Signed-off-by: tedyu <yuzhihong@gmail.com>
2017-12-30 16:28:09 -08:00
BELUGA BEHR 24b7fc92f0 HBASE-19649 Use singleton feature for ImmutableSegment
Signed-off-by: Chia-Ping Tsai <chia7712@gmail.com>
2017-12-30 06:42:24 +08:00
brandboat 9e141d12a4 HBASE-8518 Get rid of hbase.hstore.compaction.complete setting
Signed-off-by: Chia-Ping Tsai <chia7712@gmail.com>
2017-12-30 04:32:12 +08:00
Chia-Ping Tsai 5612f2f692 HBASE-19428 Deprecate the compareTo(Row) 2017-12-29 20:07:21 +08:00
anastas 0907563eb7 HBASE-19282: Making CellChunkMap the default index (CellSet delegatee) for ImmutableSegments, when MSLAB is used.
In order to avoid additional user settings. If no MSLAB is requested the index is going to be CellArrayMap

Signed-off-by: Anastasia Braginsky <anastas@yahoo-inc.com>
Signed-off-by: Michael Stack <stack@apache.org>
2017-12-28 16:49:56 -08:00
Michael Stack b4e3798bb9 HBASE-19660 Up default retries from 10 to 15 and blocking store files limit from 10 to 16 2017-12-28 15:02:23 -08:00
Michael Stack a8ef734ddd HBASE-19651 Remove LimitInputStream
Signed-off-by: Beluga Behr <dam6923@gmail.com>
2017-12-28 13:08:46 -08:00
Michael Stack d8775d08ae HBASE-19656 Disable TestAssignmentManagerMetrics for beta-1 2017-12-28 12:15:00 -08:00
gsheffi f96f89157d HBASE-19133 Transfer big cells or upserted/appended cells into
MSLAB upon flattening to CellChunkMap

Signed-off-by: Gali Sheffi <gsheffi@oath.com>
2017-12-28 10:53:06 -08:00
Mike Drob 64cb777a8a HBASE-19552 find-and-replace thirdparty offset 2017-12-28 12:01:25 -06:00
Mike Drob 968b938fde HBASE-19552 Update hbase-thirdparty version
Some manual cleanup of changing package names in pom files and getting
rid of the no-longer-needed netty system property.

This commit will break compilation, package renames in source code are
done in follow-on commits using straightforward find and replace.

's/org.apache.hadoop.hbase.shaded.com.google/org.apache.hbase.thirdparty.com.google/'
's/org.apache.hadoop.hbase.shaded.io.netty/org.apache.hbase.thirdparty.io.netty/'
2017-12-28 11:58:49 -06:00
Guanghao Zhang 33ce14cb29 HBASE-19643 Need to update cache location when get error in AsyncBatchRpcRetryingCaller 2017-12-28 14:44:17 +08:00
Chia-Ping Tsai 97f0aad66e HBASE-19626 Rename Cell.DataType to Cell.Type 2017-12-28 12:59:28 +08:00
Michael Stack 50348cc1a4 HBASE-19652 Turn down CleanerChore logging; too chatty 2017-12-27 20:50:46 -08:00
Michael Stack d6d8369655
HBASE-19648 Move branch-2 version from 2.0.0-beta-1-SNAPSHOT to 2.0.0-beta-1 2017-12-27 14:41:19 -08:00
Michael Stack e4ab29ada2 HBASE-19647 Logging cleanups; emit regionname when RegionTooBusyException inside RetriesExhausted... make netty connect/disconnect TRACE-level; ADDENDUM 2017-12-27 14:14:37 -08:00
Chia-Ping Tsai 7dee1bcd31 HBASE-19644 add the checkstyle rule to reject the illegal imports 2017-12-28 04:17:45 +08:00
Michael Stack cc8b37f847 HBASE-19647 Logging cleanups; emit regionname when RegionTooBusyException inside RetriesExhausted... make netty connect/disconnect TRACE-level 2017-12-27 11:56:40 -08:00
Chia-Ping Tsai 2468f30029 HBASE-19628 ByteBufferCell should extend ExtendedCell 2017-12-27 23:02:18 +08:00
Vasudevan 0454a389a3 HBASE-19629 RawCell#getTags should return the Iterator<Tag> in order to avoid iterating through whole tag array at once
Signed-off-by: Chia-Ping Tsai <chia7712@gmail.com>
2017-12-27 21:30:08 +08:00
BELUGA BEHR 9c9beb79ef HBASE-19615 CompositeImmutableSegment ArrayList Instead of LinkedList
Signed-off-by: Chia-Ping Tsai <chia7712@gmail.com>
2017-12-27 10:00:51 +08:00
Chia-Ping Tsai f0781d49e4 HBASE-19624 TestIOFencing hangs 2017-12-27 09:38:17 +08:00
Chia-Ping Tsai 8362b0dba5 HBASE-19550 Wrap the cell passed via Mutation#add(Cell) to be of ExtendedCell 2017-12-26 16:43:01 +08:00
Guanghao Zhang 2abf7b508c HBASE-19621 Revisit the methods in ReplicationPeerConfigBuilder 2017-12-26 14:44:07 +08:00
Guanghao Zhang 65159dc256 HBASE-19618 Remove replicationQueuesClient.class/replicationQueues.class config and remove table based ReplicationQueuesClient/ReplicationQueues implementation 2017-12-26 14:44:02 +08:00
zhangduo 33f2e6535c HBASE-19608 Race in MasterRpcServices.getProcedureResult 2017-12-25 11:52:38 +08:00
Guanghao Zhang 1e490dcc11 HBASE-19602 Cleanup the usage of ReplicationAdmin from document 2017-12-23 19:05:04 +08:00
Guanghao Zhang b552eb2ff9 HBASE-19576 Introduce builder for ReplicationPeerConfig and make it immutable 2017-12-23 19:04:58 +08:00
tedyu 96ae9add68 HBASE-19514 TestJMXListener now uses random port
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
2017-12-22 18:46:52 +01:00
Rajeshbabu Chintaguntla 79d4f6c11c HBASE-19593 Possible NPE if wal is closed during waledit append.(Rajeshabbu) 2017-12-22 17:21:30 +05:30
Chia-Ping Tsai d4af099e9e HBASE-19496 Reusing the ByteBuffer in rpc layer corrupt the ServerLoad and RegionLoad 2017-12-22 18:58:08 +08:00
Guanghao Zhang 3a210d514c HBASE-19590 Remove the duplicate code in deprecated ReplicationAdmin 2017-12-22 18:36:28 +08:00
Apekshit Sharma 11ea19a101 HBASE-19589 New regions should always be added with state CLOSED (followup of HBASE-19530) 2017-12-21 22:58:28 -08:00
Daisuke c89cfd3406 HBASE--17248 fix javadoc in SimpleRegionNormalizer
Signed-off-by: Michael Stack <stack@apache.org>
2017-12-21 21:35:50 -08:00
Michael Stack a150062bfb
HBASE-19148 Reevaluate default values of configurations; minor ADDENDUM 2017-12-21 14:13:23 -08:00
Michael Stack 18987ed867
HBASE-19148 Reevaluate default values of configurations
Removed unused:
    <name>hbase.fs.tmp.dir</name>
Added hbase.master.loadbalance.bytable

Edit of description text. Moved stuff around  to put configs beside each
other.

M hbase-server/src/main/java/org/apache/hadoop/hbase/util/ServerCommandLine.java

 Emit some hbase configs in log on startup.

Signed-off-by: Michael Stack <stack@apache.org>
2017-12-21 14:07:47 -08:00
Chia-Ping Tsai 4aec7a491a HBASE-19575 add copy constructor to Mutation 2017-12-22 03:19:47 +08:00
Peter Somogyi bf998077b9 HBASE-19578 MasterProcWALs cleaning is incorrect
Signed-off-by: tedyu <yuzhihong@gmail.com>
2017-12-21 09:39:31 -08:00
zhangduo a82f89bd3c HBASE-10092 Addendum fix TestAssignProcedure and TestWALEntrySinkFilter 2017-12-21 21:45:09 +08:00
zhangduo 69ea6928bc HBASE-19559 Fix TestLogRolling.testLogRollOnDatanodeDeath 2017-12-21 15:20:31 +08:00
Balazs Meszaros 992b5d8630 HBASE-10092 Move up on to log4j2
Changes:
- replaced commons-logging to slf4j everywhere
- log.XXX(Throwable) calls were replaced with log.XXX(t.toString(), t)
- log.XXX(Object) calls were replaced with log.XXX(Objects.toString(obj))
- log.fatal() calls were replaced with log.error(HBaseMarkers.FATAL, ...)
- programmatic log4j configuration was removed from the unit test

This commit does not affect the current logging configurations, because log4j
is still on the classpath. slf4j-log4j12 binds log4j to slf4j.

Signed-off-by: Michael Stack <stack@apache.org>
2017-12-20 22:58:12 -08:00
Michael Stack 13d9e8088c HBASE-19218 Master stuck thinking hbase:namespace is assigned after restart preventing intialization
Signed-off-by: Li Xiang <easyliangjob@gmail.com>
2017-12-20 21:47:50 -08:00
Chia-Ping Tsai 0a5ef1ed88 HBASE-19542 fix TestSafemodeBringsDownMaster 2017-12-21 10:28:19 +08:00
Michael Stack 0887cdf1da
HBASE-19567 ClassNotFoundException:
org.apache.hadoop.hbase.KeyValue$RawBytesComparator starting 2.0.0 over
a 0.98.25 data.
2017-12-20 11:21:56 -08:00
zhangduo 4fad3d96c9
HBASE-19554 For debug: Modify HTU.waitUntilAllRegionsAssigned to handle the case where we do not have entries for the given table 2017-12-20 10:22:08 -08:00
Guangxu Cheng 728d5ec041 HBASE-19561 maxCacheSize in CacheEvictionStats can't be accumulated repeatedly When dealing with each region
Signed-off-by: tedyu <yuzhihong@gmail.com>
2017-12-20 07:05:30 -08:00
Guanghao Zhang c63cc68c01 HBASE-19492 (addendum) Add EXCLUDE_NAMESPACE and EXCLUDE_TABLECFS support to replication peer config
Signed-off-by: zhangduo <zhangduo@apache.org>
2017-12-20 20:49:16 +08:00
Vasudevan 5be25bcf6b HBASE-19468 FNFE during scans and flushes (Ram) 2017-12-20 11:11:06 +05:30
Michael Stack f80d2e9c8e
HBASE-19558 TestRegionsOnMasterOptions hack so it works reliably 2017-12-19 15:59:30 -08:00
Yi Liang 1d7b0a9958
HBASE-19556: Remove TestAssignmentManager#testGoodSplit, which no longer make sense 2017-12-19 13:53:37 -08:00
Michael Stack 31ebd24b7d
HBASE-19494 Create simple WALKey filter that can be plugged in on the Replication Sink
Implement new WALEntrySinkFilter (as opposed to WALEntryFilter) and
specify the implmentation (with a no-param constructor) in config
using property hbase.replication.sink.walentrysinkfilter

Signed-off-by: wolfgang hoschek whoscheck@cloudera.com
2017-12-19 13:50:09 -08:00
Peter Somogyi ef509f2ac7 HBASE-19555 TestSplitTransactionOnCluster is flaky
Signed-off-by: tedyu <yuzhihong@gmail.com>
2017-12-19 09:26:42 -08:00
Guanghao Zhang 60cd494d1c HBASE-19492 Add EXCLUDE_NAMESPACE and EXCLUDE_TABLECFS support to replication peer config 2017-12-19 16:57:38 +08:00
tedyu 1fd22a7b0f HBASE-19532 AssignProcedure#COMPARATOR may produce incorrect sort order 2017-12-18 18:33:27 -08:00
Michael Stack 495bedea35
HBASE-19122 Suspect methods on Cell to be deprecated 2017-12-18 15:23:03 -08:00
Yun Chi-Shih 5895719420 HBASE-19531 Remove needless volatile declaration
Signed-off-by: Chia-Ping Tsai <chia7712@gmail.com>
2017-12-19 00:40:37 +08:00
QilinCao 07d20b2d18 HBASE-19521 HBase mob compaction needs to check hfile version
Signed-off-by: tedyu <yuzhihong@gmail.com>
2017-12-18 08:32:51 -08:00
zhangduo c0740b84ef HBASE-19546 TestMasterReplication.testCyclicReplication2 uses wrong assertion 2017-12-18 19:59:19 +08:00
Chia-Ping Tsai 1ca2d10299 HBASE-18309 (addendum) fix NPE in LogCleaner 2017-12-17 17:30:33 +08:00
Guanghao Zhang 8fa08b56f3 HBASE-19522 The complete order may be wrong in AsyncBufferedMutatorImpl 2017-12-16 14:09:35 +08:00
Peter Somogyi 2043c337d8
HBASE-19498 Fix findbugs and error-prone warnings in hbase-client (branch-2)
Signed-off-by: Michael Stack <stack@apache.org>
Signed-off-by: Apekshit Sharma <appy@apache.org>
2017-12-15 15:57:01 -08:00
Michael Stack 85969cfcda HBASE-18352 Enable TestMasterOperationsForRegionReplicas#testCreateTableWithMultipleReplicas disabled by Proc-V2 AM in HBASE-14614
Reenables the test. Adds facility to HBaseTestingUtility so
you can pass in ports a restarted cluster should use. This
is needed so retention of region placement, on which this
test depends, can come trigger (this is why it was broke
on AMv2 commit... region placement retention is done
different in AMv2).
2017-12-15 12:48:19 -08:00
Michael Stack bff4226105 HBASE-19272 Deal with HBCK tests disabled by HBASE-14614 AMv2 when HBCK
works again...

I removed them
2017-12-15 12:20:18 -08:00
Mike Drob 23a9059cb2 HBASE-18838 Fix hadoop3 check-shaded-invariants 2017-12-15 13:20:54 -06:00
Michael Stack 672c440b9f HBASE-18946 Stochastic load balancer assigns replica regions to the same RS
Added new bulk assign createRoundRobinAssignProcedure to complement
the existing createAssignProcedure. The former asks the balancer for
target servers to set into the created AssignProcedures. The latter
sets no target server into AssignProcedure. When no target server
is specified, we make effort at assign-time at trying to deploy the
region to its old location if there was one.

The new round robin assign procedure creator does not do this. Use
the new round robin method on table create or reenabling offline
regions. Use the old assign in ServerCrashProcedure or in
EnableTable so there is a chance we retain locality.

Bulk preassigning passing all to-be-assigned to the balancer in one
go is good for ensuring good distribution especially when read
replicas in the mix.

The old assign was single-assign scoped so region replicas could
end up on the same server.

M hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignProcedure.java
 Cleanup around forceNewPlan. Was confusing.
 Added a Comparator to sort AssignProcedures so meta and system tables
 come ahead of user-space tables.

M hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
 Remove the forceNewPlan argument on createAssignProcedure. Didn't make
 sense given we were creating a new AssignProcedure; the arg had no
 effect.

 (createRoundRobinAssignProcedures) Recast to feed all regions to the balancer in
 bulk and to sort the return so meta and system tables take precedence.

Miscellaneous fixes including keeping the Master around until all
RegionServers are down, documentation on how assignment retention
works, etc.
2017-12-15 08:54:35 -08:00
Michael Stack 76057aab62 HBASE-15536 Make AsyncFSWAL as our default WAL
Signed-off-by: zhangduo <zhangduo@apache.org>
2017-12-15 20:45:46 +08:00
anoopsamjohn a2dbb42284 HBASE-19505 Disable ByteBufferPool by default at HM. 2017-12-15 15:44:14 +05:30
tedyu 1d8a601166 HBASE-19516 IntegrationTestBulkLoad and IntegrationTestImportTsv run into 'java.lang.RuntimeException: DistributedHBaseCluster@1bb564e2 not an instance of MiniHBaseCluster' (Ankit) 2017-12-14 18:37:55 -08:00
zhangduo f070c381e2 HBASE-19513 Fix the wrapped AsyncFSOutput implementation 2017-12-15 09:39:42 +08:00
Chia-Ping Tsai 33d48754f5
HBASE-19462 Deprecate all addImmutable methods in Put
Signed-off-by: Michael Stack <stack@apache.org>
2017-12-14 14:18:04 -08:00
Mike Drob 2952cc7dea HBASE-19289 Add flag to disable stream capability enforcement
Signed-off-by: Josh Elser <elserj@apache.org>
2017-12-14 12:19:59 -06:00
ramkrish86 eac13e2315 HBASE-19511 Splits causes blocks to be cached again and so such blocks cannot be evicted from bucket cache (Ram)
Signed-off Duo Zhang, Anoop Sam John <palomino219@gmail.com, anoop.hbase@gmail.com>
2017-12-15 00:39:36 +05:30
zhangduo c2bb63fbf9 HBASE-19512 Move EventType and ExecutorType from hbase-client to hbase-server 2017-12-14 20:15:35 +08:00
zhangduo a1f8821b85 HBASE-19510 TestDistributedLogSplitting is flakey for AsyncFSWAL 2017-12-14 15:59:58 +08:00
Michael Stack cb4bbea0f1 HBASE-19287 Revert "Revert "master hangs forever if RecoverMeta
send assign meta region request to target server fail""

This is a revert of a revert; i.e a reapplication with the
log message fixed up and some added javadoc.

This reverts commit 9ef115163b.

Signed-off-by: Yi Liang <yliang@us.ibm.com>
2017-12-13 23:09:09 -08:00
zhangduo 211f231b4a HBASE-19503 Fix TestWALOpenAfterDNRollingStart for AsyncFSWAL 2017-12-14 09:41:23 +08:00
Michael Stack fb6625fdd9
HBASE-19508 ReadOnlyConfiguration throws exception if any Configuration in current context calls addDefautlResource; ADDENDUM -- fix license 2017-12-13 10:29:46 -08:00
Michael Stack b475f15f25
HBASE-19508 ReadOnlyConfiguration throws exception if any Configuration in current context calls addDefautlResource
Signed-off-by: Peter Somogyi <psomogyi@cloudera.com>
2017-12-13 10:29:34 -08:00
Sergey Soldatov 78ff501ad8 HBASE-19456 RegionMover's region server hostname option is no longer case insensitive
Signed-off-by: Josh Elser <elserj@apache.org>
2017-12-13 11:45:11 -05:00
Guangxu Cheng 015b66103a HBASE-19000 Group multiple block cache clear requests per server
Signed-off-by: tedyu <yuzhihong@gmail.com>
2017-12-13 07:47:33 -08:00
Chia-Ping Tsai a489292a83 HBASE-19502 Make sure we have closed all StoreFileScanner if we fail to open any StoreFileScanners 2017-12-13 21:38:45 +08:00
Chia-Ping Tsai 55eb59e654 HBASE-19427 Add TimeRange support into Append to optimize for counters 2017-12-13 15:40:56 +08:00
Peter Somogyi 941acc5c05 HBASE-19213 Align check and mutate operations in Table and AsyncTable
- Deprecates old checkAnd*() operations in Table
- Adds Table#CheckAndMutateBuilder and implements it in HTable

Commiter note: When committing the patch, noticed redundant {@inheritDoc} being added in HTable.
Removed new and olds ones.

Signed-off-by: Apekshit Sharma <appy@apache.org>
2017-12-12 20:46:39 -08:00
tedyu 0e47ded1a5 HBASE-19394 Support multi-homing env for the publication of RS status with multicast (hbase.status.published) (Toshihiro Suzuki) 2017-12-12 07:48:40 -08:00
zhangduo 46d9b4cf08 HBASE-19493 Make TestWALMonotonicallyIncreasingSeqId also work with AsyncFSWAL 2017-12-12 20:57:04 +08:00
zhangduo 3aa56b3932
HBASE-19371 Running WALPerformanceEvaluation against asyncfswal throws exceptions
Signed-off-by: Michael Stack <stack@apache.org>
2017-12-11 13:38:34 -08:00
Vasudevan 8dfb62029b HBASE-19485 Minor improvement to TestCompactedHFilesDischarger (Ram)
Signed off by : Ted Yu <yuzhihong@gmail.com>
2017-12-11 22:57:35 +05:30
Jan Hentschel aec5581885 HBASE-17425 Fixed deprecated calls in TestUpdateConfiguration 2017-12-09 14:44:06 +01:00
Guanghao Zhang 62ccc340fd HBASE-19463 Make CPEnv#getConnection return a facade that throws Unsupported if CP calls #close 2017-12-09 20:26:37 +08:00
Apekshit Sharma e8ba7b2320 HBASE-19457 Debugging flaky TestTruncateTableProcedure
- Adds debug logging for future ease
- Removes 60s timeout since testRecoveryAndDoubleExecutionPreserveSplits is only halfway after a minute.
- Adds some comments
- Logging change: Some places report "regionState=" while others just "state=".
  State machine procs also have "state=" in their logs. Let me change all region related logging to "regionState=" so that
  1) it's consistent everywhere, 2) more filtered results when searching through logs.
2017-12-08 17:25:44 -08:00
Michael Stack a33a9de643
HBASE-19134 Make WALKey an Interface; expose Read-Only version to CPs
Created a new WALKey Interface and a WALKeyImpl. The WALKey Interface
is surfaced to Coprocessors and throughout most of the code base.
WALKeyImpl is used internally by WAL and by Replication which need
access to WALKey setters.

Methods that were deprecated in WALObserver because they were exposing
Private audience Classes have been undeprecated now we have WALKey.

Moved over to use SequenceId#getSequenceId throughout. Changed
SequenceId#getSequenceId removing the IOE.
2017-12-08 15:12:51 -08:00
Apekshit Sharma a70b9b5e94 HBASE-19454 Debugging TestDistributedLogSplitting#testThreeRSAbort
- Changed testThreeRSAbort to kill the RSs intead of aborting. Simple aborting will close the regions, we want extreme failure testing here.
- Adds some logging for easier debugging.
- Refactors TestDistributedLogSplitting to use standard junit rules.
2017-12-07 19:15:54 -08:00
Michael Stack b0d68d6814
HBASE-19349 Introduce wrong version depencency of servlet-api jar
Move the hadoop-hdfs guava exclude in modules up to the top pom.
Looks like an exclude in a module is not additive but rather exclusive
blanking out the top level set of exclusions.

Tested by looking in lib dir of the built tarball.
2017-12-07 18:06:33 -08:00
huaxiangsun f34648e464 HBASE-19163 Maximum lock count exceeded from region server's batch processing
Signed-off-by: Michael Stack <stack@apache.org>
2017-12-07 14:13:19 -08:00
Zach York a39d5bed1b HBASE-19435 Reopen Files for ClosedChannelException in BucketCache
Signed-off-by: tedyu <yuzhihong@gmail.com>
2017-12-07 10:53:26 -08:00
BELUGA BEHR c3743be05c HBASE-19448 Replace StringBuffer with StringBuilder for hbase-server
Signed-off-by: Chia-Ping Tsai <chia7712@gmail.com>
2017-12-07 22:52:43 +08:00
Michael Stack 8dc82165f3
HBASE-19301 Provide way for CPs to create short circuited connection
with custom configurations; ADDENDUM -- adds warning to powerful new,

Signed-off-by: anoopsamjohn <anoopsamjohn@gmail.com>
2017-12-07 06:39:12 -08:00
Chia-Ping Tsai 2245dfc558 HBASE-12444 Total number of requests overflow because it's int 2017-12-07 18:42:32 +08:00
anoopsamjohn f8e2323323 HBASE-19357 Bucket cache no longer L2 for LRU cache. 2017-12-07 15:06:30 +05:30