Norman Maurer
92525fb869
HBASE-27180 Fix multiple possible buffer leaks ( #4597 )
...
* Fix multiple possible buffer leaks
Motivation:
When using ByteBuf you need to be very careful about releasing it as otherwise you might leak data. There were various places in the code-base where such a leak could happen.
Modifications:
- Fix possible buffer leaks
- Ensure we call touch(...) so its easier to debug buffer leaks
Result:
Fix buffer leaks
* Formatting
* Revert some changes as requested
* revert touch
* Also release checksum and header buffers
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 2197b3806b
)
2022-07-08 08:27:19 +08:00
Duo Zhang
1a5b1b266c
HBASE-26899 Run spotless:apply
2022-05-01 22:41:49 +08:00
Duo Zhang
e7eb628025
HBASE-26922 Fix LineLength warnings as much as possible if it can not be fixed by spotless ( #4324 )
...
Signed-off-by: Yulin Niu <niuyulin@apache.org
(cherry picked from commit 3ae0d9012c
)
2022-04-09 23:13:49 +08:00
Duo Zhang
340cc6c6f1
HBASE-26802 Backport the log4j2 changes to branch-2 ( #4166 )
...
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-03-11 11:17:43 -08:00
xicm
e9065e76e9
HBASE-26815 TestFanOutOneBlockAsyncDFSOutput is flakey ( #4186 )
...
Trigger BlockReports in MiniDFSCluster after restarting datanode
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-03-10 16:10:07 +08:00
Andrew Purtell
300f9b9576
HBASE-26582 Prune use of Random and SecureRandom objects ( #4118 )
...
Avoid the pattern where a Random object is allocated, used once or twice, and
then left for GC. This pattern triggers warnings from some static analysis tools
because this pattern leads to poor effective randomness. In a few cases we were
legitimately suffering from this issue; in others a change is still good to
reduce noise in analysis results.
Use ThreadLocalRandom where there is no requirement to set the seed to gain
good reuse.
Where useful relax use of SecureRandom to simply Random or ThreadLocalRandom,
which are unlikely to block if the system entropy pool is low, if we don't need
crypographically strong randomness for the use case. The exception to this is
normalization of use of Bytes#random to fill byte arrays with randomness.
Because Bytes#random may be used to generate key material it must be backed by
SecureRandom.
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-03-08 15:22:00 -08:00
Duo Zhang
4644efb9f3
HBASE-26691 Replacing log4j with reload4j for branch-2.x ( #4050 )
...
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-03-04 12:06:34 -08:00
Mike Drob
8a9e083994
HBASE-26622 Update error-prone to 2.10
...
Author: Mike Drob <mdrob@apache.org>
Co-authored-by: Nick Dimiduk <ndimiduk@apache.org>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-03-03 11:51:51 +01:00
chenglei
4bdc052faa
HBASE-26679 Wait on the future returned by FanOutOneBlockAsyncDFSOutput.flush would stuck ( #4039 )
...
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-01-28 14:02:02 +08:00
Xiaolin Ha
7db277737a
HBASE-26347 Support detect and exclude slow DNs in fan-out of WAL ( #3800 )
...
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-01-06 11:45:38 +08:00
Andrew Purtell
b1bc5f3a5c
Renumber to 2.6.0-SNAPSHOT after branching branch-2.5
...
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2021-12-08 16:54:32 -08:00
Tak Lon (Stephen) Wu
665305cc3b
HBASE-26124 Backport HBASE-25373 "Remove HTrace completely in code base and try to make use of OpenTelemetry" to branch-2 ( #3529 )
...
1/17 commits of HBASE-22120
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
2021-09-01 15:29:09 -07:00
Tak Lon (Stephen) Wu
c11a3e1b39
Revert "HBASE-26124 Backport HBASE-25373 "Remove HTrace completely in code base and try to make use of OpenTelemetry" to branch-2 ( #3529 )"
...
This reverts commit f049301606
.
2021-08-04 15:55:13 -07:00
Tak Lon (Stephen) Wu
f049301606
HBASE-26124 Backport HBASE-25373 "Remove HTrace completely in code base and try to make use of OpenTelemetry" to branch-2 ( #3529 )
...
1/17 commits of HBASE-22120
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
2021-07-29 09:15:10 -07:00
Michael Stack
ef9149bf78
HBASE-25989 FanOutOneBlockAsyncDFSOutput using shaded protobuf in hdfs 3.3+ ( #3368 )
...
Signed-off-by: Wei-Chiu Chuang <weichiu@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2021-06-12 08:29:06 -06:00
Viraj Jasani
0788547fea
HBASE-25474 : Bump HBase version on branch-2 ( #2871 )
...
Signed-off-by: stack <stack@apache.org>
2021-01-12 10:20:22 +05:30
Guanghao Zhang
4667a971b1
HBASE-24912 Enlarge MemstoreFlusherChore/CompactionChecker period for unit test ( #2285 )
...
Signed-off-by: stack <stack@apache.org>
2020-08-21 12:42:11 +08:00
chenglei
457234c695
HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length(addendum) ( #2055 )
...
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2020-08-10 10:04:05 +08:00
chenglei
deff4c88d3
HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length.( #2034 )
...
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
2020-07-11 16:35:10 +08:00
Duo Zhang
28602d6fdb
Revert "HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length. ( #1970 )"
...
This reverts commit f834919929
.
2020-07-07 18:16:58 +08:00
chenglei
f834919929
HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length. ( #1970 )
...
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2020-07-04 21:12:07 +08:00
Duo Zhang
dc2146069c
HBASE-24309 Avoid introducing log4j and slf4j-log4j dependencies for … ( #1697 )
...
Signed-off-by: stack <stack@apache.org>
2020-05-13 17:59:21 +08:00
Duo Zhang
f41c9038e7
HBASE-24333 Backport HBASE-24304 "Separate a hbase-asyncfs module" to branch-2.x ( #1664 )
...
Signed-off-by: stack <stack@apache.org>
2020-05-09 12:00:45 +08:00