Commit Graph

762 Commits

Author SHA1 Message Date
Jan Hentschel ee50d4829e
HBASE-23625 Reduced number of Checkstyle violations in hbase-common
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2020-01-21 12:13:32 +01:00
Jan Hentschel 99a59cf9e7
HBASE-23622 Reduced the number of Checkstyle violations in hbase-common
Signed-off-by: Sean Busbey <busbey@apache.org>
2020-01-19 18:02:08 +01:00
Viraj Jasani 1451063115
HBASE-23590 : Update maxStoreFileRefCount to maxCompactedStoreFileRefCount for auto region recovery based on old reader references
Signed-off-by: Anoop Sam John <anoopsamjohn@apache.org>
2020-01-01 23:50:24 +05:30
Bharath Vissapragada eb5e94aced HBASE-23259: Populate master address end points in cluster/rs configs (#807) (#858)
All the clients need to know the master RPC end points while using master
based registry for creating cluster connections. This patch amends the
test cluster utility to populate these configs in the base configuration
object used to spin up the cluster.

The config key added here ("hbase.master.addrs") is used in the subsequent
patches for HBASE-18095.

Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
(cherry picked from commit 834ccb4bf6)
2019-11-21 09:47:05 -08:00
Geoffrey Jacoby 5f36343949 HBASE-23288 - Backport HBASE-23251 (Add Column Family and Table Names to HFileContext) to branch-1 (#822)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2019-11-18 16:56:10 -08:00
Josh Elser b566a4f9bc HBASE-22701 Disable the DynamicClassLoader when it fails to initialize
Signed-off-by: Ankit Singhal <ankitsinghal59@gmail.com>
2019-11-15 13:56:10 -06:00
Mingliang Liu a154bd8a73 HBASE-23283 Provide clear and consistent logging about the period of enabled chores
Signed-off-by: Sean Busbey <busbey@apache.org>
2019-11-14 21:10:17 -06:00
Viraj Jasani a5f09cd756
HBASE-23212 Dynamically reload configs for Region Recovery chore (#803)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2019-11-06 15:43:08 -08:00
Viraj Jasani 5e414f2d46 HBASE-23213 Backport HBASE-22460 to branch-1 (#761)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2019-10-29 13:15:39 -07:00
chenxu14 425d84dc14
HBASE-23151 Backport HBASE-23083 (Collect Executor status info periodically and report to metrics system) to branch-1
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2019-10-15 10:13:04 -07:00
Sanjeet Nishad b96aefd07f HBASE-23038 Provide consistent and clear logging about disabling chores
Differs from master/branch-2 version due to commons-logging

Co-authored-by: Sean Busbey <busbey@apache.org>
Signed-off-by: Viraj Jasani <virajjasani007@gmail.com>
Signed-off-by: Sean Busbey <busbey@apache.org>
(cherry picked from commit b45c0d0efa)
2019-09-27 20:17:46 -05:00
Viraj Jasani f77c14d181 HBASE-23015 : Moving from Jackson2 to shaded Gson (#616)
* Backport HBASE-20587
* moving to shaded gson with jdk7 compatibility
* Include jackson-mapper-asl for testing-util because of Hadoop
* Update shaded jar check to allow hbase-thirdparty libs

Signed-off-by: Sean Busbey <busbey@apache.org>
Co-authored-by: Duo Zhang <zhangduo@apache.org>
2019-09-25 21:49:48 -05:00
Viraj Jasani 5c4d8e036f HBASE-23024 Replace initcause with Constructor arg (#627)
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
2019-09-17 14:00:12 +02:00
Viraj Jasani 72ea3666c0 HBASE-22760 : Pause/Resume/Query Snapshot Auto Cleanup Activity (#619) 2019-09-13 10:38:10 +05:30
openinx 4c2bf71a3a
HBASE-22937 The RawBytesComparator in branch-1 have wrong comparison order (#582) 2019-09-05 17:48:41 +08:00
huzheng be2de08c12 HBASE-22810 Initialize an separate ThreadPoolExecutor for taking/restoring snapshot (addendum - use the old config key) 2019-08-22 12:09:57 +08:00
openinx eb6b617d92 HBASE-22810 Initialize an separate ThreadPoolExecutor for taking/restoring snapshot (#486) 2019-08-15 11:46:30 +08:00
Viraj Jasani f7bdf76295
HBASE-22648 Snapshot TTL (#371)
Signed-off-by: Reid Chan <reidchan@apache.org>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Co-authored-by: Andrew Purtell <apurtell@apache.org>

Conflicts:
	hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java
	hbase-client/src/main/java/org/apache/hadoop/hbase/client/SnapshotDescription.java
	hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java
	hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java
	hbase-common/src/main/resources/hbase-default.xml
	hbase-protocol-shaded/src/main/protobuf/Snapshot.proto
	hbase-protocol/src/main/protobuf/HBase.proto
	hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotInfo.java
	hbase-server/src/main/resources/hbase-webapps/master/snapshot.jsp
	hbase-server/src/main/resources/hbase-webapps/master/snapshotsStats.jsp
	hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestSnapshotFromClient.java
	hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestSnapshotTemporaryDirectory.java
	hbase-shell/src/main/ruby/hbase/admin.rb
	src/main/asciidoc/_chapters/hbase-default.adoc
2019-07-23 09:56:31 -07:00
syedmurtazahassan d38078a67c
HBASE-22603 Javadoc Warnings related to @link tag
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
2019-07-23 14:59:55 +02:00
Jan Hentschel 55e2a36a58
HBASE-22344 Documented the deprecation of public and limited private APIs (#208)
Signed-off-by: stack <stack@apache.org>
2019-06-17 23:47:15 +02:00
Andrew Purtell eae71261b3
HBASE-22510 Address findbugs/spotbugs complaints (branch-1) (#278)
Signed-off-by: Sean Busbey <busbey@apache.org>
2019-06-03 11:33:47 -07:00
Wellington Chevreuil e0197ac615 HBASE-22496 UnsafeAccess.unsafeCopy should not copy more than UNSAFE_COPY_THRESHOLD on each iteration
Signed-off-by: huzheng <openinx@gmail.com>
2019-05-30 10:27:07 +08:00
Andrew Purtell 084745de18
HBASE-22235 OperationStatus.{SUCCESS|FAILURE|NOT_RUN} are not visible to 3rd party coprocessors 2019-04-16 13:18:00 -07:00
Andrew Purtell 953e0f5f77
HBASE-22034 Backport HBASE-21401 and HBASE-22032 to branch-1
HBASE-21401 Sanity check when constructing the KeyValue

HBASE-22032 KeyValue validation should check for null byte array
2019-03-21 17:27:54 -07:00
Sean Busbey 35308a5d82 HBASE-22044 Addendum for checkstyle. 2019-03-13 13:42:53 -05:00
Sean Busbey 8cab60cd2b HBASE-22044 Restore compat for ByteBufferUtils. Also deprecated because it will be IA.Private in HBase 3.0
(cherry picked from commit f13a897bf7484f0bc512048e7a16f0d8f04cc238)

Signed-off-by: Andrew Purtell <apurtell@apache.org>
2019-03-13 13:41:17 -05:00
Mingliang Liu f4af3881c1
HBASE-21164 reportForDuty should do backoff rather than retry
Remove unused methods from Sleeper (its ok, its @Private).
Remove notion of startTime from Sleeper handling (it is is unused).
Allow passing in how long to sleep so can maintain externally.
In HRS, use a RetryCounter to calculate backoff sleep time for when
reportForDuty is failing against a struggling Master.

Conflicts:
	hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
	hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerReportForDuty.java
2019-02-20 18:15:30 -08:00
Andrew Purtell 47e42dab75
Revert "HBASE-21164 reportForDuty should do backoff rather than retry"
This reverts commit f3f3798575.

This change causes TestMasterShutdown to reproducibly fail in some environments.
2019-02-20 09:25:46 -08:00
Peter Somogyi 48e8675728 HBASE-21727 Simplify documentation around client timeout - ADDENDUM
Add back HBaseConfiguration#getInt with deprecation

Signed-off-by: zhangduo <zhangduo@apache.org>
2019-02-05 18:28:03 +01:00
Andrew Purtell ff0e587b8f
HBASE-21735 Port HBASE-18784 (Use of filesystem that requires hflush / hsync / append / etc should query outputstream capabilities) to branch-1
HBASE-18784 if available, query underlying outputstream capabilities where we need hflush/hsync.

* pull things that don't rely on HDFS in hbase-server/FSUtils into hbase-common/CommonFSUtils
* refactor setStoragePolicy so that it can move into hbase-common/CommonFSUtils
* refactor WALProcedureStore so that it handles its own FS interactions
* add a reflection-based lookup of stream capabilities
* call said lookup in places where we make WALs to make sure hflush/hsync is available.

HBASE-19289 Add flag to disable stream capability enforcement

HBASE-19841 Tests against hadoop3 fail with StreamLacksCapabilityException

HBASE-19947 ITU should overwrite HTU local FS

HBASE-20354 better docs for impact of proactively checking hsync support.

* Add to the quickstart guide disabling the hsync check, with a
  big warning about how we'll lose data if the check is disabled.
* Add to troubleshooting section so folks searching can get a pointer.
2019-01-24 09:23:14 -08:00
Peter Somogyi cad3630c70
HBASE-21727 Simplify documentation around client timeout
Signed-off-by: Michael Stack <stack@apache.org>

Conflicts:
	hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientScanner.java
	src/main/asciidoc/_chapters/configuration.adoc
	src/main/asciidoc/_chapters/troubleshooting.adoc

Amending-Author: Andrew Purtell <apurtell@apache.org>
2019-01-17 16:59:12 -08:00
Andrew Purtell d6a3e6b404
HBASE-21679 Port HBASE-6028 (Start/Stop compactions at region server level) to branch-1
HBASE-6028 Start/Stop compactions at region server level

Add switching on/off of compactions.

Switching off compactions will also interrupt any currently ongoing compactions.
Adds a "compaction_switch" to hbase shell. Switching off compactions will
interrupt any currently ongoing compactions. State set from shell will be
lost on restart. To persist the changes across region servers modify
hbase.regionserver.compaction.enabled in hbase-site.xml and restart.
2019-01-11 18:08:27 -08:00
Mingliang Liu f3f3798575
HBASE-21164 reportForDuty should do backoff rather than retry
Remove unused methods from Sleeper (its ok, its @Private).
Remove notion of startTime from Sleeper handling (it is is unused).
Allow passing in how long to sleep so can maintain externally.
In HRS, use a RetryCounter to calculate backoff sleep time for when
reportForDuty is failing against a struggling Master.

Conflicts:
	hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
	hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerReportForDuty.java

Amending-Author: Andrew Purtell <apurtell@apache.org>
2019-01-11 16:50:45 -08:00
Saurabh Singh 231e6d56b5
HBASE-20928 Rewrite calculation of midpoint in binarySearch functions to prevent overflow
HBASE-20928 Rewrite calculation of midpoint - addendum (Xu Cang)

Signed-off-by: tedyu <yuzhihong@gmail.com>

Conflicts:
	hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/RowIndexSeekerV1.java
	hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java

Amending-Author: Andrew Purtell <apurtell@apache.org>
2019-01-11 14:40:51 -08:00
Chia-Ping Tsai 2f541f5710
HBASE-21208 Bytes#toShort doesn't work without unsafe
Signed-off-by: Ted Yu <yuzhihong@gmail.com>
Signed-off-by: anoopsamjohn <anoopsamjohn@gmail.com>
Signed-off-by: Reid Chan <reidchan@apache.org>

Conflicts:
	hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java
	hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestBytes.java

Amending-Author: Andrew Purtell <apurtell@apache.org>
2019-01-11 14:40:51 -08:00
Sahil Aggarwal 21cfff857d
HBASE-20716 Unsafe access cleanup
Changes the bytes[] conversion done in Bytes and ByteBufferUtils.
Instead of doing check unsafe_aligned available everytime, choose
the best converter at startup.

Conflicts:
	hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FuzzyRowFilter.java
	hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteBufferUtils.java
	hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java

Amending-Author: Andrew Purtell <apurtell@apache.org>
2019-01-11 14:40:45 -08:00
huzheng 9cef4e1141 HBASE-21473 RowIndexSeekerV1 may return cell with extra two \x00\x00 bytes which has no tags 2018-11-14 23:29:25 +08:00
Andrew Purtell ebad3ab8ed HBASE-21256 Improve IntegrationTestBigLinkedList for testing huge data
Backport to branch-1

Signed-off-by: Duo Zhang <zhangduo@apache.org>
2018-10-15 10:53:34 +08:00
Tyler Mi d385ba1a5d HBASE-21098 Improve Snapshot Performance with Temporary Snapshot Directory when rootDir on S3
Test fixes by: Taklon Wu <wutaklon@amazon.com>

Signed-off-by: Zach York <zyork@apache.org>
Signed-off-by: Mingliang Liu <liuml07@apache.org>
2018-10-12 11:13:16 -07:00
Andrew Purtell 1cba67b8ba
HBASE-21000 Default limits for PressureAwareCompactionThroughputController are too low
Based on experimental results adjust default pressure-aware compaction
throughput controller settings to bring compaction time with default
settings in line with those measured on branch-1.4 and below.

hbase.hstore.compaction.throughput.lower.bound = 52428800
hbase.hstore.compaction.throughput.higher.bound = 104857600
2018-10-09 18:46:35 -07:00
Andrew Purtell 0c6226b56c
HBASE-21162 Revert suspicious change to BoundedByteBufferPool and disable use of direct buffers for IPC reservoir by default
Revert suspicious change to BoundedByteBufferPool made on HBASE-19239 (Fix
findbugs and error-prone issues).

In addition the allocation of direct memory for the server RPC reservoir is
problematic in that tracing native memory or direct buffer leaks to a
particular class or compilation unit is difficult, so allocate the reservoir
on the heap by default instead.
2018-09-10 18:25:27 -07:00
Xu Cang 3a97976eae HBASE-20744 Address FindBugs warnings in branch-1
minor fix

Signed-off-by: tedyu <yuzhihong@gmail.com>
2018-07-23 16:29:13 -07:00
Mike Drob 2ae61521aa HBASE-20884 Reclassify Base64 as IA.Private 2018-07-13 14:33:23 -05:00
Yu Li 50f7894cc4 HBASE-20691 Change the default WAL storage policy back to "NONE""
This partially reverts HBASE-19858 and adds more doc about why we choose "NONE" as the default.
2018-07-05 15:26:56 +08:00
Xu Cang 2fd69cf93c HBASE-19722 Implement a meta query statistics metrics source
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2018-06-28 17:17:50 -07:00
Sean Busbey 4b63557682 HBASE-20444 Addendum keep folks from looking at raw version component array.
Signed-off-by: Andrew Purtell <apurtell@apache.org>

 Conflicts:
	hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
2018-05-31 14:19:14 -05:00
maoling 345567d714 HBASE-20444 Improve comparison logic for HBase version strings
Signed-off-by: Sean Busbey <busbey@apache.org>

 Conflicts:
	hbase-common/src/main/java/org/apache/hadoop/hbase/util/VersionInfo.java

Amended to use commons-lang 2, where isNumeric("") -> true

Amending-Author: Sean Busbey <busbey@apache.org>
2018-05-30 10:25:14 -05:00
Lars Hofhansl 6685b62abe HBASE-20459 Majority of scan CPU time in HBase-1 spent in size estimation. 2018-04-21 10:02:07 -07:00
Sean Busbey ba7a936f74 Revert "HBASE-9465 Push entries to peer clusters serially"
This reverts commit 441bc050b9.

 Conflicts:
	hbase-client/src/main/java/org/apache/hadoop/hbase/MetaTableAccessor.java
	hbase-client/src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationAdmin.java
	hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/WALProtos.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/Replication.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java

Signed-off-by: Andrew Purtell <apurtell@apache.org>
2018-02-23 14:42:15 +08:00
Sean Busbey 0a284d2b76 Revert "HBASE-17010 Serial replication should handle daughter regions being assigned to another RS (Phil Yang)"
This reverts commit 97276da9a7.

Signed-off-by: Andrew Purtell <apurtell@apache.org>
2018-02-23 14:42:04 +08:00