Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
12,845 Commits 95 Branches 866 Tags 550 MiB
Commit Graph

873 Commits

Author SHA1 Message Date
huzheng 9cef4e1141 HBASE-21473 RowIndexSeekerV1 may return cell with extra two \x00\x00 bytes which has no tags 2018-11-14 23:29:25 +08:00
Andrew Purtell ebad3ab8ed HBASE-21256 Improve IntegrationTestBigLinkedList for testing huge data 
Backport to branch-1

Signed-off-by: Duo Zhang <zhangduo@apache.org>
 2018-10-15 10:53:34 +08:00
Tyler Mi d385ba1a5d HBASE-21098 Improve Snapshot Performance with Temporary Snapshot Directory when rootDir on S3 
Test fixes by: Taklon Wu <wutaklon@amazon.com>

Signed-off-by: Zach York <zyork@apache.org>
Signed-off-by: Mingliang Liu <liuml07@apache.org>
 2018-10-12 11:13:16 -07:00
Andrew Purtell 1cba67b8ba
HBASE-21000 Default limits for PressureAwareCompactionThroughputController are too low 
Based on experimental results adjust default pressure-aware compaction
throughput controller settings to bring compaction time with default
settings in line with those measured on branch-1.4 and below.

hbase.hstore.compaction.throughput.lower.bound = 52428800
hbase.hstore.compaction.throughput.higher.bound = 104857600
 2018-10-09 18:46:35 -07:00
Mike Drob ac94011677
HBASE-20764 build broken when latest commit is gpg signed 
Signed-off-by: Andrew Purtell <apurtell@apache.org>
 2018-10-08 19:53:34 -05:00
Andrew Purtell 0c6226b56c
HBASE-21162 Revert suspicious change to BoundedByteBufferPool and disable use of direct buffers for IPC reservoir by default 
Revert suspicious change to BoundedByteBufferPool made on HBASE-19239 (Fix
findbugs and error-prone issues).

In addition the allocation of direct memory for the server RPC reservoir is
problematic in that tracing native memory or direct buffer leaks to a
particular class or compilation unit is difficult, so allocate the reservoir
on the heap by default instead.
 2018-09-10 18:25:27 -07:00
Xu Cang 3a97976eae HBASE-20744 Address FindBugs warnings in branch-1 
minor fix

Signed-off-by: tedyu <yuzhihong@gmail.com>
 2018-07-23 16:29:13 -07:00
Mike Drob 2ae61521aa HBASE-20884 Reclassify Base64 as IA.Private 2018-07-13 14:33:23 -05:00
Yu Li 50f7894cc4 HBASE-20691 Change the default WAL storage policy back to "NONE"" 
This partially reverts HBASE-19858 and adds more doc about why we choose "NONE" as the default.
 2018-07-05 15:26:56 +08:00
Xu Cang 2fd69cf93c HBASE-19722 Implement a meta query statistics metrics source 
Signed-off-by: Andrew Purtell <apurtell@apache.org>
 2018-06-28 17:17:50 -07:00
Sean Busbey 4b63557682 HBASE-20444 Addendum keep folks from looking at raw version component array. 
Signed-off-by: Andrew Purtell <apurtell@apache.org>

 Conflicts:
	hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
 2018-05-31 14:19:14 -05:00
maoling 345567d714 HBASE-20444 Improve comparison logic for HBase version strings 
Signed-off-by: Sean Busbey <busbey@apache.org>

 Conflicts:
	hbase-common/src/main/java/org/apache/hadoop/hbase/util/VersionInfo.java

Amended to use commons-lang 2, where isNumeric("") -> true

Amending-Author: Sean Busbey <busbey@apache.org>
 2018-05-30 10:25:14 -05:00
Andrew Purtell 210b90604b HBASE-20619 TestWeakObjectPool occasionally times out 
Remove too-stringent timeout already removed from this test in master branch.
 2018-05-22 12:24:05 -07:00
Lars Hofhansl 6685b62abe HBASE-20459 Majority of scan CPU time in HBase-1 spent in size estimation. 2018-04-21 10:02:07 -07:00
Sean Busbey ba7a936f74 Revert "HBASE-9465 Push entries to peer clusters serially" 
This reverts commit 441bc050b9.

 Conflicts:
	hbase-client/src/main/java/org/apache/hadoop/hbase/MetaTableAccessor.java
	hbase-client/src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationAdmin.java
	hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/WALProtos.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/Replication.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java

Signed-off-by: Andrew Purtell <apurtell@apache.org>
 2018-02-23 14:42:15 +08:00
Sean Busbey 0a284d2b76 Revert "HBASE-17010 Serial replication should handle daughter regions being assigned to another RS (Phil Yang)" 
This reverts commit 97276da9a7.

Signed-off-by: Andrew Purtell <apurtell@apache.org>
 2018-02-23 14:42:04 +08:00
Andrew Purtell f35bcd2fe3 HBASE-19858 Backport HBASE-14061 (Support CF-level Storage Policy) to branch-1 
HBASE-14061 Support CF-level Storage Policy
HBASE-14061 Support CF-level Storage Policy (addendum)
HBASE-14061 Support CF-level Storage Policy (addendum2)
HBASE-15172 Support setting storage policy in bulkload
HBASE-17538 HDFS.setStoragePolicy() logs errors on local fs
HBASE-18015 Storage class aware block placement for procedure v2 WALs
HBASE-18017 Reduce frequency of setStoragePolicy failure warnings
Default storage policy if not configured cannot be "NONE"
HBASE-19016 Coordinate storage policy property name for table schema and bulkload
Fix checkstyle warnings
Addressed additional review feedback on backport
 2018-02-01 17:10:39 -08:00
Chia-Ping Tsai 71862094d7 HBASE-19877 hbase-common and hbase-zookeeper don't add the log4j.properties to the resource path for testing 2018-01-29 16:52:01 +08:00
Peter Somogyi 528eb10826 HBASE-19545 Replace getBytes(StandardCharsets.UTF_8) with Bytes.toBytes 
Signed-off-by: Chia-Ping Tsai <chia7712@gmail.com>
 2017-12-27 20:15:01 +08:00
Andrew Purtell 1fe75f98d3 HBASE-19421 branch-1 does not compile against Hadoop 3.0.0 2017-12-04 15:48:38 -08:00
Michael Stack fb3fee3414 HBASE-19383 [1.2] java.lang.AssertionError: expected:<2> but was:<1> at 
org.apache.hadoop.hbase.TestChoreService.testTriggerNowFailsWhenNotScheduled(TestChoreService.java:707)
 2017-11-29 20:45:31 -08:00
Andrew Purtell c179d5144f HBASE-19239 Fix findbugs and error-prone issues 
Fixes for hbase-common
 2017-11-17 15:20:45 -08:00
Lars Hofhansl f9833a7802 HBASE-12091 Optionally ignore edits for dropped tables for replication. 2017-11-14 16:33:12 -08:00
Andrew Purtell ef3b59cb7a HBASE-19232 Fix shaded-check-invariants (check-jar-contents) failure on branch-1 2017-11-13 10:37:20 -08:00
Andrew Purtell 6961526573 HBASE-12350 Backport error-prone build support to branch-1 and branch-2 2017-11-09 15:34:09 -08:00
Andrew Purtell d099263e13 HBASE-19129 TestChoreService is flaky 
Increase the delta to compensate for environmental variance.
 2017-10-31 00:08:31 +00:00
Andrew Purtell 64328caef0 HBASE-15631 Backport Regionserver Groups (HBASE-6721) to branch-1 (Francis Liu and Andrew Purtell) 2017-10-23 17:10:33 -07:00
Sean Busbey aa50971947 Revert "HBASE-17678 FilterList with MUST_PASS_ONE may lead to redundant cells returned" 
This reverts commit 256fc63007.

Backing out filterlist regression, see HBASE-18957. Work continuing branch for HBASE-18410.

Signed-off-by: Peter Somogyi <psomogyi@cloudera.com>
Signed-off-by: Michael Stack <stack@apache.org>
 2017-10-09 17:06:14 -05:00
tedyu d5033fd350 HBASE-18743 HFiles in use by a table which has the same name and namespace with a default table cloned from snapshot may be deleted when that snapshot and default table are deleted (wenbang) 2017-09-04 07:52:57 -07:00
Guangxu Cheng 433b42b41c HBASE-18461 Build broken If the username contains a backslash 
Signed-off-by: tedyu <yuzhihong@gmail.com>
 2017-08-31 08:46:39 -07:00
Sean Mackrory aec4bf6bae HBASE-15947 Classes used only for tests included in main code base 
Signed-off-by: Chia-Ping Tsai <chia7712@gmail.com>
 2017-08-30 10:53:31 +08:00
Mike Drob 9c26a42ab1 HBASE-18656 First issues found by error-prone 2017-08-24 13:04:45 -05:00
Andrew Purtell 3feb87b005 HBASE-18431 Mitigate compatibility concerns between branch-1.3 and branch-1.4 
- Refactor TableName into its own proto module and fix up users

- Move SnapshotDescription from Snapshot.proto back to HBase.proto

- Restore FastLongHistogram and TestFastLongHistogram;
  deprecate FastLongHistogram

- Move DeleteQueryTracker back to o.a.h.h.regionserver
 2017-08-16 11:34:18 -07:00
Josh Elser c7e1d67df7 HBASE-18023 Update row threshold warning from 1k to 5k (addendum) 2017-07-25 18:39:44 -04:00
rgidwani 26247996d2 HBASE-15816 Provide client with ability to set priority on Operations 
Signed-off-by: Andrew Purtell <apurtell@apache.org>
 2017-07-21 17:12:25 -07:00
anoopsamjohn 9036556a33 HBASE-16993 BucketCache throw java.io.IOException: Invalid HFile block magic when configuring hbase.bucketcache.bucket.sizes. 2017-07-20 23:00:48 +05:30
Chia-Ping Tsai 1b8fb0a8d8 HBASE-18365 Eliminate the findbugs warnings for hbase-common 2017-07-13 19:35:18 +08:00
Andrew Purtell 3dd55fa0c0 Set versions on branch-1 to 1.5.0-SNAPSHOT 2017-07-03 18:01:15 -07:00
Phil Yang 3381c6c453 HBASE-17931 Assign system tables to servers with highest version 2017-07-03 11:35:31 +08:00
David Harju 743f454d25 HBASE-18023 Log multi-* requests for more than threshold number of rows 
Signed-off-by: Josh Elser <elserj@apache.org>
Amending-Author: Andrew Purtell <apurtell@apache.org>
 2017-06-30 18:45:36 -07:00
tedyu 940f4107b0 HBASE-18226 Disable reverse DNS lookup at HMaster and use the hostname provided by RegionServer (Duo Xu) 2017-06-21 18:23:30 -07:00
Sean Busbey c6e587c5ac HBASE-16242 Manually resolve transitive Apache Avro dependency to consistently be ver 1.7.7. 
Signed-off-by: Jerry He <jerryjch@apache.org>

 Conflicts:
	hbase-common/pom.xml
	hbase-spark/pom.xml
	pom.xml
 2017-06-19 15:58:43 -05:00
Andrew Purtell 316e02e3d8 HBASE-18219 Fix typo in constant HConstants.HBASE_CLIENT_MEAT_REPLICA_SCAN_TIMEOUT 2017-06-14 16:03:54 -07:00
huzheng 256fc63007 HBASE-17678 FilterList with MUST_PASS_ONE may lead to redundant cells returned 
Signed-off-by: tedyu <yuzhihong@gmail.com>
Signed-off-by: zhangduo <zhangduo@apache.org>
 2017-06-13 20:28:04 +08:00
zhangduo d6e85b0511 Revert "FilterList with MUST_PASS_ONE may lead to redundant cells returned" miss issue number 
This reverts commit c71da858ad.
 2017-06-13 20:27:28 +08:00
huzheng c71da858ad FilterList with MUST_PASS_ONE may lead to redundant cells returned 
Signed-off-by: tedyu <yuzhihong@gmail.com>
 2017-06-12 23:55:25 -07:00
Vincent a3c3f1012d HBASE-18060 Backport to branch-1 HBASE-9774 HBase native metrics and metric collection for coprocessors 
Signed-off-by: Andrew Purtell <apurtell@apache.org>
 2017-05-24 13:20:44 -07:00
tedyu c03f003f4f HBASE-18035 Meta replica does not give any primaryOperationTimeout to primary meta region (huaxiang sun) 2017-05-21 06:39:33 -07:00
tedyu 300c5388f2 HBASE-18058 Zookeeper retry sleep time should have an upper limit (Allan Yang) 2017-05-19 10:58:38 -07:00
Andrew Purtell 292226690a HBASE-18043 Institute a hard limit for individual cell size that cannot be overridden by clients 2017-05-15 18:03:24 -07:00
Guanghao Zhang 9f25836d99 HBASE-17958 Avoid passing unexpected cell to ScanQueryMatcher when optimize SEEK to SKIP 2017-05-03 21:39:30 +08:00
Vikas Vishwakarma a2e4e0a1eb HBASE-17877 Improve HBase's byte[] comparator. 
Signed-off-by: Lars Hofhansl <larsh@apache.org>
 2017-04-27 13:27:02 -07:00
Colm O hEigeartaigh 439711e0a0 HBASE-17944 - Removed unused JDK version parsing from ClassSize. 
Signed-off-by: Sean Busbey <busbey@apache.org>
 2017-04-21 09:29:07 -05:00
Jerry He b6a2c02b93 HBASE-17869 UnsafeAvailChecker wrongly returns false on ppc 2017-04-06 16:13:52 -07:00
Yi Liang cc700ef4c1 HBASE-17821: The CompoundConfiguration#toString is wrong 
Signed-off-by: CHIA-PING TSAI <chia7712@gmail.com>
 2017-03-31 15:13:58 +08:00
Chia-Ping Tsai 006bfc7054 HBASE-17623 Reuse the bytes array when building the hfile block 2017-03-25 23:51:14 +08:00
Andrew Purtell d7666b6066 HBASE-17780 BoundedByteBufferPool "At capacity" messages are not actionable 2017-03-14 13:23:47 -07:00
Ashu Pachauri 20cb390529 HBASE-15429 Add split policy for busy regions 
Signed-off-by: Gary Helmling <garyh@apache.org>
 2017-03-09 17:33:53 -08:00
Andrew Purtell ccf1f17d78 HBASE-17722 Metrics subsystem stop/start messages add a lot of useless bulk to operational logging 
Conflicts:
	hbase-spark/src/test/resources/log4j.properties
 2017-03-03 12:35:21 -08:00
Ashu Pachauri 4b8195f22c HBASE-17057 Minor compactions should also drop page cache (Ashu Pachauri) 
Signed-off-by: Gary Helmling <garyh@apache.org>
 2017-02-24 15:31:36 -08:00
Zach York 8f6388503b HBASE-17437 Support specifying a WAL directory outside of the root directory (Yishan Yang and Zach York) 
HBASE-17588 Remove unused imports brought in by HBASE-17437 (Zach York)

Signed-off-by: Enis Soztutar <enis@apache.org>
 2017-02-08 15:01:59 -08:00
Sean Busbey 3d4639f34d HBASE-17522 Handle JVM throwing runtime exceptions when we ask for details on heap usage the same as a correctly returned 'undefined'. 
Signed-off-by: Michael Stack <stack@apache.org>

 Conflicts:
	hbase-common/src/main/java/org/apache/hadoop/hbase/io/util/HeapMemorySizeUtil.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java
	hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestCacheConfig.java
	hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDefaultMemStore.java
 2017-02-01 10:38:29 -06:00
Michael Stack 6130ea4d54 HBASE-12148 Remove TimeRangeTracker as point of contention when many threads writing a Store (Huaxiang Sun) 2017-01-09 13:35:20 -08:00
rahul gidwani 667c5eb3a0 HBASE-16710 Add ZStandard Codec to Compression.java 
Signed-off-by: Andrew Purtell <apurtell@apache.org>
 2017-01-05 10:47:12 -08:00
Phil Yang 29e390c808 HBASE-17314 Limit total buffered size for all replication sources 2016-12-23 12:17:39 +08:00
Phil Yang dd0206ff31 Revert "HBASE-17314 Limit total buffered size for all replication sources" 
This reverts commit e9444ed077.
 2016-12-22 19:08:17 +08:00
Phil Yang e9444ed077 HBASE-17314 Limit total buffered size for all replication sources 2016-12-21 13:10:29 +08:00
binlijin 4c7f0f2436 HBASE-17332 Replace HashMap to Array for DataBlockEncoding.idToEncoding 2016-12-20 12:28:04 +08:00
Jonathan M Hsieh 9da0d5d00e HBASE-17224 Fix lots of spelling errors in HBase logging and exception messages (Grant Sohn) 2016-12-01 09:10:03 -08:00
Yu Li 4068a8b4d4 HBASE-17114 Add an option to set special retry pause when encountering CallQueueTooBigException 2016-12-01 16:48:46 +08:00
Guanghao Zhang f26b3bf5ba HBASE-17178 Add region balance throttling 
Signed-off-by: Phil Yang <yangzhe1991@apache.org>
 2016-11-30 18:07:02 +08:00
tedyu 97276da9a7 HBASE-17010 Serial replication should handle daughter regions being assigned to another RS (Phil Yang) 2016-11-08 06:35:12 -08:00
tedyu 05b010cacb HBASE-16832 Reduce the default number of versions in Meta table for branch-1 (binlijin) 2016-10-14 13:53:39 -07:00
Gary Helmling 4f29c23038 HBASE-16146 Remove thread local usage in Counter 2016-10-11 14:47:02 -07:00
Jonathan M Hsieh ecc1c294f5 HBASE-12088 Addendum - fix spacing 2016-09-21 20:58:34 -07:00
Jonathan M Hsieh 13d6acbc7f HBASE-12088 Remove unused hadoop-1.0, hadoop-1.1 profiles from non-root poms 2016-09-21 20:52:19 -07:00
Phil Yang 069d1f73fa HBASE-16388 Prevent client threads being blocked by only one slow region server 
Signed-off-by: stack <stack@apache.org>
 2016-09-14 09:28:20 -07:00
tedyu ac1ee77f40 HBASE-16612 Use array to cache Types for KeyValue.Type.codeToType (Phil Yang) 2016-09-13 12:44:36 -07:00
tedyu 8ad14bac67 HBASE-16616 Rpc handlers stuck on ThreadLocalMap.expungeStaleEntry (Tomu Tsuruhara) 2016-09-12 16:29:24 -07:00
binlijin ad67fd0816 HBASE-16530 Reduce DBE code duplication 
Signed-off-by: Yu Li <liyu@apache.org>
 2016-09-09 16:25:56 +08:00
Andrew Purtell abbb36f625 Amend HBASE-16538 Changes the way version information is stored during build 
Generated Version class needs an interface audience annotation
 2016-09-02 19:54:14 -07:00
Apekshit Sharma 84ad592748 HBASE-16538 Changes the way version information is stored during build. 
Instead of writing package-info.java with VersionAnnotation, saveVersion.sh now writes Version.java with static members.

Change-Id: I009f440fa049f409e10cb3f1c3afb483bc2aa876
 2016-09-02 16:20:10 -07:00
tedyu 9907a7e2a2 HBASE-16502 Reduce garbage in BufferedDataBlockEncoder - addendum adopts Hiroshi's suggestion (binlijin) 2016-08-30 18:06:24 -07:00
Matteo Bertozzi 57c6384b09 HBASE-16522 Procedure v2 - Cache system user and avoid IOException 2016-08-30 15:35:08 -07:00
Apekshit Sharma e46a073ed2 HBASE-16101 Tool to microbenchmark procedure WAL performance. 
Change-Id: I8ec158319395d2ec8e36641a3beab2694f7b6aef
 2016-08-30 13:32:42 -07:00
anoopsamjohn c899897bc8 HBASE-16213 A new HFileBlock structure for fast random get. (binlijin) 2016-08-29 12:11:46 +05:30
Matteo Bertozzi 35fa341913 HBASE-16508 Move UnexpectedStateException to common 2016-08-26 18:37:59 -07:00
tedyu b59f18c2af HBASE-16502 Reduce garbage in BufferedDataBlockEncoder (binlijin) 2016-08-25 20:39:42 -07:00
Ramkrishna e7cd7fffbf HBASE-16444 CellUtil#estimatedSerializedSizeOfKey() should consider 
KEY_INFRASTRUCTURE_SIZ (Ram)
 2016-08-23 10:58:50 +05:30
Apekshit Sharma a8909f5cba HBASE-16467 Move AbstractHBaseTool to hbase-common. 
Change-Id: Ifb81c15b89b308f53e6ee8a76e18189b5b526cd3
 2016-08-22 16:32:46 -07:00
stack cf9878f77e HBASE-16363 Correct javadoc for qualifier length and value (Xiang Li) 2016-08-10 17:53:37 -07:00
Phil Yang 441bc050b9 HBASE-9465 Push entries to peer clusters serially 
Signed-off-by: zhangduo <zhangduo@apache.org>
 2016-08-09 15:26:15 +08:00
Vivek ec99838b9c HBASE-15866 Split hbase.rpc.timeout into *.read.timeout and *.write.timeout 
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Amending-Author: Andrew Purtell <apurtell@apache.org>

Conflicts:
	hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java
	hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
	hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java
	hbase-client/src/main/java/org/apache/hadoop/hbase/client/Table.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/client/HTableWrapper.java
	hbase-server/src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java
	hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestHCM.java
 2016-08-06 10:38:41 -07:00
Sean Busbey a5f98c3f9e HBASE-16321 ensure no findbugs-jsr305 
Signed-off-by: Esteban Gutierrez <esteban@apache.org>

 Conflicts:
	hbase-client/src/main/java/org/apache/hadoop/hbase/MetaTableAccessor.java
	hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
	hbase-rsgroup/pom.xml
	hbase-server/pom.xml
	hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/ObserverContext.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/master/TableStateManager.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSTableDescriptors.java
	hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
	hbase-spark/pom.xml
	src/main/asciidoc/_chapters/developer.adoc
 2016-08-05 14:08:50 -05:00
zhangduo dc56aa2d4f HBASE-16225 Refactor ScanQueryMatcher 2016-08-02 14:04:49 +08:00
stack d54bcfb1e2 HBASE-16256 Purpose of EnvironmentEdge, EnvironmentEdgeManager (Sai Teja Ranuva) 2016-07-29 16:34:53 -07:00
zhangduo e06bbe4804 HBASE-16280 Use hash based map in SequenceIdAccounting 2016-07-26 16:36:46 +08:00
Jerry He fe915e10d6 HBASE-14548 Expand how table coprocessor jar and dependency path can be specified (Xiang Li) 2016-07-09 18:18:22 -07:00
stack 9563ab4ca1 HBASE-16176 Bug fixes/improvements on HBASE-15650 Remove TimeRangeTracker as point of contention when many threads reading a StoreFile Fixes HBASE-16074 ITBLL fails, reports lost big or tiny families broken scanning because of a side effect of a clean up in HBASE-15650 to make TimeRange construction consistent exposed a latent issue in TimeRange#compare. See HBASE-16074 for more detail. 
Also change HFile Writer constructor so we pass in the TimeRangeTracker, if one,
on construction rather than set later (the flag and reference were not volatile
so could have made for issues in concurrent case). And make sure the construction
of a TimeRange from a TimeRangeTracer on open of an HFile Reader never makes a
bad minimum value, one that would preclude us reading any values from a file
(set min to 0)

M hbase-common/src/main/java/org/apache/hadoop/hbase/io/TimeRange.java
 Call through to next constructor (if minStamp was 0, we'd skip setting
 allTime=true). Add asserts that timestamps are not < 0 cos it messes
 us up if they are (we already were checking for < 0 on construction but
 assert passed in timestamps are not < 0).

M hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
 Add constructor override that takes a TimeRangeTracker (set when flushing
 but not when compacting)

M hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
 Add override creating an HFile in tmp that takes a TimeRangeTracker

M hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java
 Add override for HFile Writer that takes a TimeRangeTracker Take it on
 construction instead of having it passed by a setter later (flags and
 reference set by the setter were not volatile... could have been prob
 in concurrent case)

M hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/TimeRangeTracker.java
 Log WARN if bad initial TimeRange value (and then 'fix' it)

M hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestTimeRangeTracker.java
 A few tests to prove serialization works as expected and that we'll get a bad min if not constructed properly.

M hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ScanQueryMatcher.java
 Handle OLDEST_TIMESTAMP explictly. Don't expect TimeRange to do it.

M hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestQueryMatcher.java
 Refactor from junit3 to junit4 and add test for this weird case.
 2016-07-08 14:23:23 -07:00
Andrew Purtell 8efc6148b9 HBASE-16091 Canary takes lot more time when there are delete markers in the table (Vishal Khandelwal) 
Conflicts:
	hbase-server/src/main/java/org/apache/hadoop/hbase/tool/Canary.java

Amending-Author: Andrew Purtell <apurtell@apache.org>
 2016-07-05 10:34:27 -07:00