Commit Graph

1079 Commits

Author SHA1 Message Date
Yu Li 36bb496e48 HBASE-15931 Add log for long-running tasks in AsyncProcess 2016-06-02 12:02:19 +08:00
Andrew Purtell 22aa501436 HBASE-15854 Log the cause of SASL connection failures (Robert Yokota) 2016-05-26 14:27:36 -07:00
Mikhail Antonov 51dfe44174 HBASE-15880 RpcClientImpl#tracedWriteRequest incorrectly closes HTrace span 2016-05-23 12:47:46 -07:00
tedyu 6738dbadac HBASE-15802 ConnectionUtils should use ThreadLocalRandom instead of Random (Matt Warhaftig) 2016-05-22 06:47:59 -07:00
Jerry He b7de663580 HBASE-14818 user_permission does not list namespace permissions (li xiang) 2016-05-21 20:32:20 -07:00
Gary Helmling aacc816ac7 HBASE-15856 Addendum Fix UnknownHostException import in MetaTableLocator 2016-05-20 19:31:07 -07:00
Gary Helmling df40739ae7 HBASE-15856 Don't cache unresolved addresses for connections 2016-05-20 10:02:05 -07:00
Matteo Bertozzi e5eea96ca6 HBASE-15843 Replace RegionState.getRegionInTransition() Map with a Set 2016-05-18 12:51:17 -07:00
tedyu ce43e33876 HBASE-15769 Perform validation on cluster key for add_peer (Matt Warhaftig) 2016-05-17 13:26:45 -07:00
stack c0fcce2bde HBASE-15593 Time limit of scanning should be offered by client (Phil Yang) 2016-05-17 12:51:03 -07:00
Elliott Clark 89146d85ac HBASE-15840 WAL.proto compilation broken for cpp 2016-05-17 12:04:31 -07:00
Sean Busbey e365191896 HBASE-15780 Make AuthUtil public and rely on it for talking to secure HBase.
Signed-off-by: Gary Helmling <garyh@apache.org>
Signed-off-by: Mikhail Antonov <antonov@apache.org>
Signed-off-by: stack <stack@apache.org>
2016-05-16 00:53:45 -05:00
Mikhail Antonov 0042d6d4c8 HBASE-15615 Wrong sleep time when RegionServerCallable need retry (Guanghao Zhang) 2016-05-15 20:49:00 -07:00
stack 77f511fceb HBASE-15811 Batch Get after batch Put does not fetch all Cells We were not waiting on all executors in a batch to complete. The test for no-more-executors was damaged by the 0.99/0.98.4 fix "HBASE-11403 Fix race conditions around Object#notify"
It added this in AsyncProcess#waitForMaximumCurrentTasks:

synchronized (this.tasksInProgress) {
+          if (tasksInProgress.get() != oldInProgress) break;
           this.tasksInProgress.wait(100);

which added a break out of our waiting loop if any change in
count of tasks; it seems that what was wanted was instead to
avoid the wait if there was movement in the count of completed
task.

Reformats waitForMaximumCurrentTasks so it is testable. Adds
test that we indeed wait on the specified parameter.
2016-05-13 17:53:37 -07:00
Ramkrishna 94c4d568b5 HBASE-15609 Remove PB references from Result, DoubleColumnInterpreter and
any such public facing class for 2.0 (Ram)
2016-05-09 14:57:39 +05:30
Ashish Singhi 0964884b92 HBASE-15669 HFile size is not considered correctly in a replication request 2016-05-06 17:28:06 +05:30
Ramkrishna b9df7978fc HBASE-15608 Remove PB references from SnapShot related Exceptions (Ram) 2016-05-06 17:07:44 +05:30
tedyu 09d451b1db HBASE-15292 Refined ZooKeeperWatcher to prevent ZooKeeper's callback while construction (Hiroshi Ikeda) 2016-05-05 16:07:39 -07:00
Gary Helmling b36222831d HBASE-15741 Provide backward compatibility for HBase coprocessor service names 2016-05-04 12:37:39 -07:00
Ramkrishna 902b673167 HBASE-15607 Remove PB references from Admin for 2.0 (Ram) 2016-05-03 10:52:59 +05:30
Mikhail Antonov 7e0e86072a HBASE-15703 Deadline scheduler needs to return to the client info about skipped calls, not just drop them 2016-05-02 15:27:13 -07:00
Yu Li 44fdfb3ba0 HBASE-15711 Add client side property to allow logging details for batch errors 2016-04-29 10:16:01 +08:00
tedyu 4f2d8dc328 HBASE-15676 FuzzyRowFilter fails and matches all the rows in the table if the mask consists of all 0s (Matt Warhaftig) 2016-04-27 21:03:34 -07:00
Gary Helmling 4272178b1f HBASE-15658 Avoid excess meta cache clearing for RegionServerCallable 2016-04-26 23:02:24 -07:00
Phil Yang d5acbdd1e4 HBASE-15645 hbase.rpc.timeout is not used in operations of HTable
Signed-off-by: stack <stack@apache.org>
2016-04-26 10:52:12 -07:00
stack 9f222d59e1 HBASE-15710 Include issue servers information in RetriesExhaustedWithDetailsException message (Yu Li) 2016-04-26 09:15:24 -07:00
chenheng 5d497d5ba8 HBASE-15674 HRegionLocator#getAllRegionLocations should put the results in cache
Conflicts:
	hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
	hbase-client/src/main/java/org/apache/hadoop/hbase/client/HRegionLocator.java
2016-04-21 14:28:07 +08:00
chenheng 96e9c466d2 HBASE-15406 Split / merge switch left disabled after early termination of hbck
Conflicts:
        hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java
        hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
        hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
        hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/MasterProtos.java
        hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java
        hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java
        hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
        hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestSplitOrMergeStatus.java
        hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsckOneRS.java
2016-04-15 15:34:43 +08:00
tedyu 85f2caf184 HBASE-15633 Backport HBASE-15507 to branch-1 (Geoffrey Jacoby) 2016-04-13 02:25:32 -07:00
Vasudevan e407e1e81d HBASE-15605 Remove PB references from HCD and HTD for 2.0 (Ram_ 2016-04-11 14:15:09 +05:30
Enis Soztutar 5202d3c25b HBASE-15295 MutateTableAccess.multiMutate() does not get high priority causing a deadlock
Conflicts:
	hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
	hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
	hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java
	hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/CoprocessorRpcChannel.java
	hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/MasterCoprocessorRpcChannel.java
	hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RegionCoprocessorRpcChannel.java
	hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
	hbase-it/src/test/java/org/apache/hadoop/hbase/DistributedHBaseCluster.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
	hbase-server/src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java
	hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide3.java
	hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestScannersFromClientSide.java
	hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestClockSkewDetection.java
	hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerNoMaster.java
	hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestNamespaceCommands.java
2016-03-28 17:00:21 -07:00
Mikhail Antonov ca819e1ef6 HBASE-15524 Fix NPE in client-side metrics 2016-03-23 21:59:15 -07:00
Jesse Yates ee33bf0c7d HBASE-14703 HTable.mutateRow does not collect stats (Heng Chen)
Conflicts:
	hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java
	hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java
	hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerFactory.java
	hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerImpl.java
	hbase-client/src/main/java/org/apache/hadoop/hbase/client/StatsTrackingRpcRetryingCaller.java
	hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java
2016-03-24 11:27:54 +08:00
zhangduo 9fa44a8126 HBASE-15520 Fix broken TestAsyncIPC
Conflicts:
	hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AsyncRpcChannel.java
2016-03-24 10:57:42 +08:00
Elliott Clark 604415e827 HBASE-15475 Allow TimestampsFilter to provide a seek hint 2016-03-23 18:57:02 -07:00
tedyu 1c5002660b HBASE-15325 ResultScanner allowing partial result will miss the rest of the row if the region is moved between two rpc requests (Phil Yang) 2016-03-21 13:20:23 -07:00
tedyu 050c13e83f HBASE-15479 No more garbage or beware of autoboxing (Vladimir Rodionov) 2016-03-19 17:23:29 -07:00
Jerry He 8151503fa0 HBASE-14963 Remove use of Guava Stopwatch from HBase client code (Devaraj Das) 2016-03-19 13:23:05 -07:00
Mikhail Antonov a317a0f89c HBASE-15390 Unnecessary MetaCache evictions cause elevated number of requests to meta (ADDENDUM) 2016-03-17 01:09:10 -07:00
Elliott Clark aaaae83423 HBASE-15441 Fix WAL splitting when region has moved multiple times
Summary:
Currently WAL splitting is broken when a region has been opened multiple times in recent minutes.

Region open and region close write event markers to the wal. These markers should have the sequence id in them. However it is currently getting 1. That means that if a region has moved multiple times in the last few mins then multiple split log workers will try and create the recovered edits file for sequence id 1. One of the workers will fail and on failing they will delete the recovered edits. Causing all split wal attempts to fail.

We need to:

It appears that the close event with a sequence id of one is coming from region warm up.

This patch fixes that by making sure the close on warm up doesn't happen. Also splitting will ignore any of the events that are already in the logs.

Test Plan: Unit tests pass

Differential Revision: https://reviews.facebook.net/D55557
2016-03-16 16:35:18 -07:00
Mikhail Antonov 94d576025f HBASE-15390 Unnecessary MetaCache evictions cause elevated number of requests to meta 2016-03-16 16:32:11 -07:00
anoopsjohn 75547a42b9 HBASE-15322 Operations using Unsafe path broken for platforms not having sun.misc.Unsafe. 2016-03-11 09:38:24 +05:30
tedyu e103f75ae7 HBASE-15378 Scanner cannot handle heartbeat message with no results (Phil Yang) 2016-03-09 10:05:06 -08:00
Mikhail Antonov 3339bac563 HBASE-15137 CallTimeoutException and CallQueueTooBigException should trigger PFFE 2016-03-08 02:59:20 -08:00
tedyu 4ec6ad12c9 HBASE-15243 Utilize the lowest seek value when all Filters in MUST_PASS_ONE FilterList return SEEK_NEXT_USING_HINT 2016-03-07 19:28:21 -08:00
Mikhail Antonov 43698b3fcb HBASE-15354 Use same criteria for clearing meta cache for all operations (Ashu Pachauri) 2016-03-07 17:34:11 -08:00
tedyu c1524485c5 HBASE-15393 Enable table replication command will fail when parent znode is not default in peer cluster (Ashish Singhi) 2016-03-07 04:57:55 -08:00
tedyu 42c3fcabc0 HBASE-15397 Create bulk load replication znode(hfile-refs) in ZK replication queue by default (Ashish Singhi) 2016-03-04 13:49:00 -08:00
chenheng 18194f8a56 HBASE-15128 Disable region splits and merges switch in master 2016-02-29 20:41:27 +08:00
Mikhail Antonov 998e339d6e HBASE-15342 create branch-1.3 and update branch-1 poms to 1.4.0-SNAPSHOT 2016-02-28 16:23:29 -08:00
Josh Elser d747188f2c HBASE-15232 Handle region location cache mgmt in AsyncProcess for multi()'s
Further investigation after HBASE-15221 lead to some findings that
AsyncProcess should have been managing the contents of the region
location cache, appropriately clearing it when necessary (e.g. an
RPC to a server fails because the server doesn't host that region)

For multi() RPCs, the tableName argument is null since there is no
single table that the updates are destined to. This inadvertently
caused the existing region location cache updates to fail on 1.x
branches. AsyncProcess needs to handle when tableName is null
and perform the necessary cache evictions.

As such, much of the new retry logic in HTableMultiplexer is
unnecessary and is removed with this commit. Getters which were
added as a part of testing were left since that are mostly
harmless and should contain no negative impact.

Signed-off-by: stack <stack@apache.org>
2016-02-23 10:28:33 -08:00
anoopsjohn cc45b4ab38 HBASE-15247 InclusiveStopFilter does not respect reverse Filter property. (Amal Joshy) 2016-02-23 09:59:35 +05:30
Jonathan M Hsieh 7b4646fe3d HBASE-15285 ADDENDUM make RETURN_RESULTS attribute name protected to match branch-1.1 and deprecated to warn of 2.0 (Sean Busbey) 2016-02-18 07:17:10 -08:00
stack 23917519e8 HBASE-15285 Forward-port respect for isReturnResult from HBASE-15095 2016-02-17 23:34:42 -06:00
Jonathan M Hsieh 2e1a3ef644 HBASE-15283 Revert to IOException in TimeRange constructor to maintain API compat in 1.x line
[branch-1 and branch-1.2 only] HBASE-14355 changed the type of exception thrown if an invalid TimeRange is specified.  This reverts to 1.1.x semantics.
2016-02-17 15:57:54 -08:00
anoopsjohn 7e5ce6b0a3 HBASE-15198 RPC client not using Codec and CellBlock for puts by default-addendum. 2016-02-12 07:35:42 +05:30
anoopsjohn 19f8faeb88 HBASE-15198 RPC client not using Codec and CellBlock for puts by default. 2016-02-11 16:37:20 +05:30
Josh Elser 01b73e9877 HBASE-15221 Reload the cache on re-tried puts in HTableMultiplexer and adds a close() method to HTableMultiplexer
When a Put fails due to a NotServingRegionException, the cached location
of that Region is never cleared. Thus, subsequent calls to resubmit
the Put will fail in the same way as the original, never determining
the new location of the Region.

If the Connection is not closed by the user before the Multiplexer
is discarded, it will leak resources and could cause resource
issues.

Signed-off-by: Sean Busbey <busbey@cloudera.com>
2016-02-08 00:07:08 -06:00
anoopsjohn 64c87f2476 HBASE-15214 Valid mutate Ops fail with RPC Codec in use and region moves across. 2016-02-06 02:41:29 +05:30
Andrew Purtell 1b420be56a Amend HBASE-15200 ZooKeeper znode ACL checks should only compare the shortname
Fixes for newly introduced FindBugs warnings
2016-02-04 17:33:29 -08:00
Enis Soztutar 73d6778820 HBASE-15177 Reduce garbage created under high load
Conflicts:
	hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
2016-02-04 13:26:22 -08:00
Andrew Purtell 360bb62469 HBASE-15200 ZooKeeper znode ACL checks should only compare the shortname 2016-02-03 10:43:29 -08:00
Enis Soztutar f1e7c06539 HBASE-15129 Set default value for hbase.fs.tmp.dir rather than fully depend on hbase-default.xml (Yu Li)
Conflicts:
	hbase-client/src/main/java/org/apache/hadoop/hbase/security/SecureBulkLoadUtil.java
2016-02-02 17:06:20 -08:00
tedyu 486f7612be HBASE-15173 Execute mergeRegions RPC call as the request user 2016-01-28 10:02:49 -08:00
Elliott Clark 421fe24e9b HBASE-15146 Don't block on Reader threads queueing to a scheduler queue 2016-01-28 08:11:11 -05:00
ramkrishna bc0e5fc048 HBASE-14970 Backport HBASE-13082 and its sub-jira to branch-1 - recommit
(Ram)
2016-01-25 08:04:22 +05:30
stack a5228a0b4d Revert "HBASE-14970 Backport HBASE-13082 and its sub-jira to branch-1 (Ram)"
Causes TestHFileOutputFormat to fail every time. Messes up our 1.3 CI.

This reverts commit 58521869b0.
2016-01-22 10:45:51 -08:00
stack a9c008344f HBASE-15091 Forward-port to 1.2 HBASE-15031 "Fix merge of MVCC and SequenceID performance regression in branch-1.0" 2016-01-21 10:26:46 -08:00
stack d965d14a63 Revert "HBASE-14865 Support passing multiple QOPs to SaslClient/Server via hbase.rpc.protection (Apply)"
Needs newer Hadoop with n HADOOP-10786/HADOOP-11287 (courtesy of Matteo)

This reverts commit e76a2e4e6d.
2016-01-21 08:27:06 -08:00
ramkrishna 58521869b0 HBASE-14970 Backport HBASE-13082 and its sub-jira to branch-1 (Ram) 2016-01-21 21:22:40 +05:30
Mikhail Antonov cea43788fe HBASE-15139 Connection manager doesn't pass client metrics to RpcClient 2016-01-20 14:20:26 -08:00
tedyu e76a2e4e6d HBASE-14865 Support passing multiple QOPs to SaslClient/Server via hbase.rpc.protection (Apply) 2016-01-19 13:08:24 -08:00
tedyu 7a096ac6cb HBASE-15073 Revert due to different opinion on usefulness 2016-01-18 17:35:18 -08:00
stack d9fd87d5a8 HBASE-15115 Fix findbugs complaints in hbase-client 2016-01-16 16:14:13 -08:00
tedyu 53983f5b2e HBASE-15073 Finer grained control over normalization actions for RegionNormalizer 2016-01-06 15:38:46 -08:00
tedyu 2797adf45f HBASE-14987 Compaction marker whose region name doesn't match current region's needs to be handled 2016-01-04 07:19:13 -08:00
Ashish Singhi 64553236a9 HBASE-15018 Inconsistent way of handling TimeoutException in the rpc client implementations
Signed-off-by: Sean Busbey <busbey@apache.org>
2015-12-30 09:18:48 -06:00
tedyu afaa7f843a HBASE-14717 enable_table_replication command should only create specified table for a peer cluster (Ashish) 2015-12-24 11:18:32 -08:00
anoopsjohn 4a7565af9c HBASE-14940 Make our unsafe based ops more safe. 2015-12-24 07:56:27 +05:30
stack fdeca854ec Revert "HBASE-15018 Inconsistent way of handling TimeoutException in the rpc client implemenations (Ashish Singhi)"
This reverts commit 59cca6297f.
2015-12-23 15:31:35 -08:00
stack 59cca6297f HBASE-15018 Inconsistent way of handling TimeoutException in the rpc client implemenations (Ashish Singhi) 2015-12-23 07:29:44 -08:00
anoopsjohn b7100c934b HBASE-13158 When client supports CellBlock, return the result Cells as controller payload for get(Get) API also - Addendum 2015-12-22 09:58:12 +05:30
Lars Hofhansl c27d2c9c3e HBASE-14822 Renewing leases of scanners doesn't work. 2015-12-19 10:15:26 -08:00
anoopsjohn 574774d8b1 HBASE-13158 When client supports CellBlock, return the result Cells as controller payload for get(Get) API also. 2015-12-19 14:58:52 +05:30
Enis Soztutar f3ebeeb3fc HBASE-14989 Implementation of Mutation.getWriteToWAL() is backwards 2015-12-17 11:48:14 -08:00
anoopsjohn a93c0e822e HBASE-14999 Remove ref to org.mortbay.log.Log. 2015-12-17 23:33:39 +05:30
stack 2f7d5e6354 HBASE-14946 Don't allow multi's to over run the max result size. 2015-12-10 21:25:46 -08:00
Enis Soztutar aeb6ae97d3 HBASE-14960 Fallback to using default RPCControllerFactory if class cannot be loaded
Conflicts:
	hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestRpcControllerFactory.java
2015-12-10 19:13:14 -08:00
Elliott Clark 8508dd07ff HBASE-14946 Don't allow multi's to over run the max result size.
Summary:
* Add VersionInfoUtil to determine if a client has a specified version or better
* Add an exception type to say that the response should be chunked
* Add on client knowledge of retry exceptions
* Add on metrics for how often this happens

Test Plan: Added a unit test

Differential Revision: https://reviews.facebook.net/D51771
2015-12-10 18:31:05 -08:00
ramkrishna 65117d3d04 HBASE-13153 Bulk Loaded HFile Replication (Ashish Singhi) 2015-12-10 13:10:41 +05:30
Gary Helmling 5dec5ad250 HBASE-14866 VerifyReplication and ReplicationAdmin should use full peer configuration for peer connection 2015-12-09 16:47:25 -08:00
tedyu 66adeb3048 HBASE-14894 Fix misspellings of threshold in log4j.properties files for tests (Youngjoon Kim) 2015-11-28 10:10:27 -08:00
tedyu 447a0e7b7e HBASE-14737 Clear cachedMaxVersions when HColumnDescriptor#setValue(VERSIONS, value) is called (Pankaj Kumar) 2015-11-23 20:26:18 -08:00
chenheng 40e01512cf HBASE-14782 FuzzyRowFilter skips valid rows (Vladimir Rodionov) 2015-11-19 11:41:05 +08:00
tedyu a6e0ad636a HBASE-14824 HBaseAdmin.mergeRegions should recognize both full region names and encoded region names (Eungsop Yoo) 2015-11-18 14:26:31 -08:00
Elliott Clark e40ed0e836 HBASE-14812 Fix ResultBoundedCompletionService deadlock 2015-11-17 13:48:50 -08:00
Elliott Clark 4d5ac316b6 HBASE-14708 Use copy on write Map for region location cache
Summary:
Create and use a copy on write map for region location.

  - Create a copy on write map backed by a sorted array.
  - Create a test for both comparing each with a jdk provided map.
  - Change MetaCache to use the new map.

Test Plan:
  - org.apache.hadoop.hbase.client.TestFromClientSide
  - TestHCM

Differential Revision: https://reviews.facebook.net/D49545
2015-11-17 11:01:52 -08:00
stack 336eb92016 HBASE-14355 Scan different TimeRange for each column family 2015-11-13 22:44:05 -08:00
tedyu 3e551ea538 HBASE-14498 Revert for on-going review 2015-11-12 12:55:44 -08:00
tedyu c36b9489aa HBASE-14498 Master stuck in infinite loop when all Zookeeper servers are unreachable (Pankaj Kumar) 2015-11-12 07:22:42 -08:00