8670 Commits

Author SHA1 Message Date
Andrew Purtell
9af341c672 HBASE-27097 SimpleRpcServer is broken (#4613)
Replace BufferChain#write(channel,int) with a simpler #write(channel)
implementation that does not attempt to "chunk" data to be written. This
method was used exclusively by SimpleRpcServer. The code was unnecessarily
complex and caused short writes when values were large, so was corrected
and simplified. Any difference in performance from this change will be
limited to SimpleRpcServer. Testing under load confirms the fix and does
not show significant regression.

SimpleRpcServer and its related code is now also marked as @Deprecated.

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>

Conflicts:
	hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/SimpleRpcServer.java
2022-07-12 11:14:42 -07:00
Bryan Beaudreault
7dfed53819 HBASE-27188 Report maxStoreFileCount in jmx (#4609)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-07-11 22:19:30 -04:00
Bryan Beaudreault
a8a67d4314 HBASE-27186 Report block cache size metrics separately for L1 and L2 (#4608)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-07-11 22:09:57 -04:00
Duo Zhang
d054c93be1 HBASE-27189 NettyServerRpcConnection is not properly closed when the netty channel is closed (#4611)
Signed-off-by: Viraj Jasani <vjasani@apache.org>
(cherry picked from commit 5bc867032299099822298ede1382e011224c3add)
2022-07-12 09:47:03 +08:00
Duo Zhang
decb96edd2 HBASE-26708 Netty leak detected and OutOfDirectMemoryError due to direct memory buffering with SASL implementation (#4596)
Co-authored-by: Norman Maurer <norman_maurer@apple.com>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
(cherry picked from commit 816e919e952de72c94543180870a438ff3c53caa)
2022-07-07 16:04:40 +08:00
Ujjawal
60521caf9f
HBASE-27175 - Failure to cleanup WAL split dir log should be at INFO level (#4593)
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2022-07-06 16:35:22 -07:00
Bryan Beaudreault
87f22813f4 HBASE-27048 Server side scanner time limit should account for time in queue (#4562)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-07-06 14:21:56 -04:00
tianhang
c725dc98e5 HBASE-27171 Fix Annotation Error in HRegionFileSystem (#4588)
Co-authored-by: Tang Tianhang <tianhang.tang@shopee.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 6031a3a8d4729279a27e6271fe847c1ab6a011d7)
2022-07-06 12:39:35 +08:00
Duo Zhang
2cd30e5f00 HBASE-23330: Fix delegation token fetch with MasterRegistry (#1084) (#4598)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
(cherry picked from commit d8b3f55518fcf73df54f67ab1cb2f3920088d70d)

Co-authored-by: Bharath Vissapragada <bharathv@apache.org>
2022-07-06 12:00:09 +08:00
Bryan Beaudreault
f36b8eadd8 HBASE-27170 ByteBuffAllocator leak when decompressing blocks near minSizeForReservoirUse (#4592)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2022-07-04 16:47:47 -04:00
Duo Zhang
ab722fe765 HBASE-27169 TestSeparateClientZKCluster is flaky (#4587)
Signed-off-by: Xin Sun <ddupgs@gmail.com>
(cherry picked from commit 03c23beb57e5927d2244a00b66ce6fa3148aa84b)
2022-07-01 22:16:52 +08:00
Ishika
ba9aa5df99 HBASE-26218 Add logs in Canary tool (#4501)
Co-authored-by: Ishika Soni <isoni@isoni-ltmag9r.internal.salesforce.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit acfbc3ff7dacd706fabe1eb586a7c64019d27328)
2022-06-30 23:28:41 +08:00
Duo Zhang
aaf6435317 HBASE-27160 ClientZKSyncer.deleteDataForClientZkUntilSuccess should break from the loop when deletion is succeeded (#4579)
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
(cherry picked from commit d7f6861e8dfc06398455330e25bdac958d0dcb37)
2022-06-26 15:29:47 +08:00
Bryan Beaudreault
ce3a37ebac HBASE-26790 getAllRegionLocations can cache locations with null hostname (#4575)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-06-24 07:47:37 -04:00
Bryan Beaudreault
207b7d0fe5 HBASE-26945 Quotas causes too much load on meta for large clusters (#4576)
Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>
2022-06-23 16:48:52 -04:00
Andrew Purtell
54be59642d Preparing development version 2.4.14-SNAPSHOT
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-06-22 20:15:07 -07:00
Andrew Purtell
90fb1ddc1d Preparing hbase release 2.4.13RC1; tagging and updates to CHANGES.md and RELEASENOTES.md
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-06-22 20:15:03 -07:00
Andrew Purtell
67592eaba0 Preparing development version 2.4.14-SNAPSHOT
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-06-22 09:51:14 -07:00
Andrew Purtell
249b5f1170 Preparing hbase release 2.4.13RC0; tagging and updates to CHANGES.md and RELEASENOTES.md
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-06-22 09:51:11 -07:00
Andrew Purtell
cd2a7ff1c0 HBASE-27051 TestReplicationSource.testReplicationSourceInitializingMetric is flaky (#4448)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2022-06-22 14:05:52 +02:00
xiaozhang0319
745cc7bc58 HBASE-27099 The log printing fspread/fsread cost time unit should be milliseconds (#4500)
Co-authored-by: xiaozhang <issac.zhang@huolala.cn>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit b498efdbc1f4f51d715edcf6b06456f04f518c7f)
2022-06-21 00:14:44 +08:00
SiCheng-Zheng
eb41b47baa HBASE-27128 when open archiveRetries totalLogSize calculation mistake (#4546)
Co-authored-by: zhengsicheng <zhengsicheng@jd.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 5833756e5e7cdc01d50538e5c9f959a79fcfd7a3)
2022-06-20 23:48:51 +08:00
Xiaolin Ha
51e8f6e6dc
HBASE-27125 The batch size of cleaning expired mob files should have an upper bound(addendum) (#4553)
fix ut error
2022-06-20 11:44:31 +08:00
Xiaolin Ha
15a88efb17 HBASE-27125 The batch size of cleaning expired mob files should have an upper bound (#4541)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-06-18 02:09:00 +08:00
litao
e21f164050
HBASE-27117 Update the method comments for RegionServerAccounting (#4532) 2022-06-16 17:20:19 -07:00
Viraj Jasani
ae1a0ed94e Revert "HBASE-25709 Close region may stuck when region is compacting and skipped most cells read (#3117)" (#4524)
This reverts commit f3a48d19101a6a485628f71fc4b980fb95b44ad2.

Signed-off-by: Andrew Purtell <apurtell@apache.org>

Conflicts:
	hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
2022-06-12 10:25:28 -07:00
Nick Dimiduk
a3153bfde5
HBASE-27095 HbckChore should produce a report
In #4470 for HBASE-26192, it was noted that the HbckChore is kind of a pain to use and test
because it maintains a bunch of local state. By contract, the CatalogJanitorChore makes a nice
self-contained report. Let's update HbckChore to do the same.

Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-06-10 15:47:23 +02:00
liuzhuang2017
999801adad HBASE-27080 Optimize debug output log of ConstantSizeRegionSplitPolicy class. (#4481)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 12a9e6e5ec7e3c86b60ae818d736b9f83fb69604)

Conflicts:
	hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ConstantSizeRegionSplitPolicy.java
2022-06-06 13:43:58 +08:00
huaxiangsun
976dbe8b2b
HBASE-26649 Support meta replica LoadBalance mode for RegionLocator#getAllRegionLocations() (#4442) (#4485)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-06-03 15:28:19 -07:00
skysiders
2e08c69c5c
HBASE-26985 check permission for SecureBulkLoadManager (#4379)
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2022-06-02 15:30:31 -07:00
Duo Zhang
9ea3e39d7a HBASE-27046 The filenum in AbstractFSWAL should be monotone increasing (#4449)
Signed-off-by: Xin Sun <ddupgs@gmail.com>
Signed-off-by: GeorryHuang <huangzhuoyue@apache.org>
(cherry picked from commit 313a37f7ac780a36b51064372868a31849df6727)
2022-06-03 00:23:45 +08:00
Xiaolin Ha
df9739979e HBASE-26680 Close and do not write trailer for the broken WAL writer(addendum) (#4405)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 80f410ec3fddf35f77b1e3f2b352110d296a2415)
2022-06-03 00:08:53 +08:00
LiangJun He
3ce6e1afe7 HBASE-27039 Some methods of MasterRegion should be annotated for testing only (#4433)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 15002fccb4abb187467a9355f436d533928da7ef)
2022-06-02 21:39:20 +08:00
Andrew Purtell
f1c7f3a2f0 HBASE-27079 Lower some DEBUG level logs in ReplicationSourceWALReader to TRACE (#4476)
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2022-05-31 12:43:50 -07:00
d-c-manning
6ae8c9a808 HBASE-27054 TestStochasticLoadBalancerRegionReplicaLargeCluster.testRegionReplicasOnLargeCluster is flaky (#4454)
Signed-off-by: Andrew Purtell <apurtell@apache.org>

Conflicts:
	hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancerRegionReplicaLargeCluster.java
2022-05-21 09:42:40 -07:00
Viraj Jasani
91a44f5bac
HBASE-26523 + HBASE-25465 + HBASE-26855 backport to branch-2.4 (#4439)
* HBASE-26523 Upgrade hbase-thirdparty dependency to 4.0.1 (#3988)

Signed-off-by: GeorryHuang <huangzhuoyue@apache.org>

* HBASE-25465 Use javac --release option for supporting cross version compilation (#4164)

Signed-off-by: Andrew Purtell <apurtell@apache.org>

* HBASE-26855 Delete unnecessary dependency on jaxb-runtime jar (#4236)

Signed-off-by: Duo Zhang <zhangduo@apache.org>

* spotless apply

Co-authored-by: Duo Zhang <zhangduo@apache.org>
Co-authored-by: Nick Dimiduk <ndimiduk@apache.org>

Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-05-18 16:28:55 -07:00
Duo Zhang
1ab7491c6d HBASE-27045 Disable TestClusterScopeQuotaThrottle (#4440)
Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
(cherry picked from commit 487cf301a46a5df9201d24f19117b79967082b73)
2022-05-18 20:51:56 +08:00
litao
4f9896ebc0 HBASE-27032 The draining region servers metric description is incorrect (#4428)
Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>
Signed-off-by: Pankaj Kumar<pankajkumar@apache.org>
(cherry picked from commit ed1665355a221f9f36ce7c8905d9ed063c6e9eac)
2022-05-17 10:47:52 +05:30
Tak Lon (Stephen) Wu
5b319752de
HBASE-27033 Backport "HBASE-27013 Introduce read all bytes when using pread for prefetch" (#4429)
- introduce optional flag `hfile.pread.all.bytes.enabled` for pread that must read full bytes with the next block header

Signed-off-by: Ankit Singhal <ankit@apache.org>
Signed-off-by: Josh Elser <elserj@apache.org>
2022-05-16 11:21:25 -07:00
skysiders
bba83dc931
HBASE-26994 MasterFileSystem create directory without permission check (#4391)
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2022-05-08 13:29:33 -07:00
Rushabh Shah
daaf5addbe HBASE-26963 ReplicationSource#removePeer hangs if we try to remove bad peer. (#4413)
Signed-off-by: Andrew Purtell <apurtell@apache.org>

Conflicts:
	hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
2022-05-07 17:45:39 +00:00
litao
b8868f225a
HBASE-27000 Block cache stats (Misses Caching) display error in RS web UI (#4406)
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2022-05-05 23:36:18 -07:00
Duo Zhang
02dd256703 HBASE-26899 Run spotless:apply 2022-05-01 23:10:46 +08:00
Andrew Purtell
526bdf61d0 Preparing development version 2.4.13-SNAPSHOT
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-04-29 19:32:49 -07:00
Andrew Purtell
8382f55b15 Preparing hbase release 2.4.12RC0; tagging and updates to CHANGES.md and RELEASENOTES.md
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-04-29 19:32:46 -07:00
Bryan Beaudreault
6d3b583abf
HBASE-26860 Backport "HBASE-25681 Add a switch for server/table queryMeter" to branch-2.4 (#4240)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-04-29 18:57:23 -07:00
liangxs
95f9792c3a HBASE-26980 Update javadoc of BucketCache.java (#4374)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit c02e7553d46ddfb3b0911240f6edd4b900b869b6)
2022-04-28 23:12:51 +08:00
Bri Augenreich
282c1c2737 HBASE-26581 Add metrics for failed replication edits (#4347)
Co-authored-by: Briana Augenreich <baugenreich@hubspot.com>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
2022-04-26 17:45:36 -04:00
Wellington Ramos Chevreuil
828025bb37 HBASE-26971 SnapshotInfo --snapshot param is marked as required even when trying to list all snapshots (#4366)
Signed-off-by: Josh Elser <elserj@apache.org>
(cherry picked from commit af13c6d4c67757c8029ae5e546ba1f2d1e9a4299)
2022-04-26 15:02:17 +01:00
Ruanhui
7715e37d37
HBASE-26942 cache region locations when getAllRegionLocations (#4357)
Co-authored-by: huiruan <huiruan@tencent.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
2022-04-22 07:53:01 -04:00