Commit Graph

4908 Commits

Author SHA1 Message Date
tedyu bf7015d320 HBASE-16304 HRegion#RegionScannerImpl#handleFileNotFoundException may lead to deadlock when trying to obtain write lock on updatesLock 2016-08-24 09:04:47 -07:00
Enis Soztutar dda8f67b2c HBASE-16270 Handle duplicate clearing of snapshot in region replicas (Robert Yokota) 2016-08-24 06:33:46 -07:00
Ashish Singhi 31f16d6aec HBASE-16471 Region Server metrics context will be wrong when machine hostname contain "master" word (Pankaj Kumar) 2016-08-24 18:59:44 +05:30
Enis Soztutar cbfd6eecbd HBASE-16474 Remove dfs.support.append related code and documentation 2016-08-24 03:41:54 -07:00
chenheng 3909b7c96f HBASE-16464 archive folder grows bigger and bigger due to corrupt snapshot under tmp dir 2016-08-24 13:38:32 +08:00
anoopsamjohn 32c21f4594 HBASE-14921 In-Memory MemStore Flush and Compaction : Memory optimizations. (Anastasia) 2016-08-24 09:25:21 +05:30
Geoffrey cb02be38ab HBASE-16448 Custom metrics for custom replication endpoints
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2016-08-23 17:17:08 -07:00
Matteo Bertozzi cb507b8cff HBASE-16360 TableMapReduceUtil addHBaseDependencyJars has the wrong class name for PrefixTreeCodec (Jing Pu Chen) 2016-08-23 14:22:20 -07:00
anoopsamjohn 897631f8d1 HBASE-16440 MemstoreChunkPool might cross its maxCount of chunks to pool. 2016-08-23 22:28:14 +05:30
Ashish Singhi 77a7394f17 HBASE-16446 append_peer_tableCFs failed when there already have this table's partial cfs in the peer (Guanghao Zhang) 2016-08-23 15:28:33 +05:30
Ramkrishna ff6182b020 HBASE-16454 Compactor's shipping logic decision should be based on the
current store's block size (Ram)
2016-08-23 11:06:02 +05:30
Esteban Gutierrez abc64fa69f HBASE-16450 Shell tool to dump replication queues
New tool to dump existing replication peers, configurations and
queues when using HBase Replication. The tool provides two flags:

 --distributed  This flag will poll each RS for information about
                the replication queues being processed on this RS.
                By default this is not enabled and the information
                about the replication queues and configuration will
                be obtained from ZooKeeper.
 --hdfs         When --distributed is used, this flag will attempt
                to calculate the total size of the WAL files used
                by the replication queues. Since its possible that
                multiple peers can be configured this value can be
                overestimated.

Signed-off-by: Matteo Bertozzi <matteo.bertozzi@cloudera.com>
2016-08-22 19:50:10 -07:00
Apekshit Sharma ae42a934d8 HBASE-16467 Move AbstractHBaseTool to hbase-common.
Change-Id: I64775f875f6900520e66c22c007704a067e8c2a4
2016-08-22 16:06:17 -07:00
tedyu f174fec391 HBASE-16455 Provide API for obtaining all the WAL files 2016-08-22 01:34:58 -07:00
tedyu d077219d3a HBASE-16409 Row key for bad row should be properly delimited in VerifyReplication 2016-08-20 17:16:39 -07:00
anoopsamjohn 5f61f9cc5c HBASE-16405 Change read path Bloom check to work with Cells with out any copy. 2016-08-19 11:25:35 +05:30
Yu Li 642d2fe0f8 HBASE-16429 FSHLog: deadlock if rollWriter called when ring buffer filled with appends 2016-08-18 09:59:36 +08:00
Matteo Bertozzi e637a61e26 HBASE-16378 Procedure v2 - Make ProcedureException extend HBaseException 2016-08-17 14:31:08 -07:00
chenheng fb4ef53571 HBASE-15635 Mean age of Blocks in cache (seconds) on webUI should be greater than zero
Signed-off-by: stack <stack@apache.org>
2016-08-17 10:59:00 -07:00
tedyu 233ca65b8f HBASE-16419 check REPLICATION_SCOPE's value more stringently (Guangxu Cheng) 2016-08-17 07:58:06 -07:00
stack 907ac1f655 HBASE-16341 Missing bit on "Regression: Random Read/WorkloadC slower in 1.x than 0.98" 2016-08-13 20:16:44 -07:00
Ramkrishna 65c03b058c HBASE-16404 Make DeleteBloomFilters work with BloomContext (Ram) 2016-08-12 15:09:31 +05:30
Ramkrishna 285e104176 HBASE-15554 - StoreFile$Writer.appendGeneralBloomFilter generates extra KV
(Ram)
2016-08-12 10:21:41 +05:30
tedyu fb668a0d3f HBASE-16267 Remove commons-httpclient dependency from hbase-rest module 2016-08-10 21:28:45 -07:00
tedyu 9e116e048b HBASE-16389 Thread leak in CoprocessorHost#getTable(TableName) API (Ankit Singhal) 2016-08-10 19:58:13 -07:00
stack 45bb6180a3 REVERT of revert of "HBASE-16308 Contain protobuf references Gather up the pb references into a few locations only rather than have pb references distributed all about the code base."
This is a revert of a revert; i.e. we are adding back the change only adding
back with fixes for the broken unit test; was a real issue on a test that
went in just at same time as this commit; I was getting a new nonce on each
retry rather than getting one for the mutation.

Other changes since revert are more hiding of RpcController. Use
accessor method rather than always pass in a RpcController

Walked back retrying operations that used to be single-shot (though
code comment said need a retry) because it opens a can of worms where
we retry stuff like bad column family when we shouldn't (needs
work adding in DoNotRetryIOEs)

Changed name of class from PayloadCarryingServerCallable to
CancellableRegionServerCallable.

Fix javadoc and findbugs warnings.

Fix case of not initializing the ScannerCallable RpcController.

Below is original commit message:

 Remove mention of ServiceException and other protobuf classes from all over the codebase.
 Purge TimeLimitedRpcController. Lets just have one override of RpcController.
        M hbase-client/src/main/java/org/apache/hadoop/hbase/client/AbstractRegionServerCallable.java
         Cleanup. Make it clear this is an odd class for async hbase intro.
        M hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java
         Refactor of RegionServerCallable allows me clean up a bunch of
         boilerplate in here and remove protobuf references.
        M hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
          Purge protobuf references everywhere except a reference to a throw of a
          ServiceException in method checkHBaseAvailable. I deprecated it in favor
          of new available method (the SE is not actually needed)
        M hbase-client/src/main/java/org/apache/hadoop/hbase/client/PayloadCarryingServerCallable.java
         Move the RetryingTimeTracker instance in here from HTable.
         Allows me to contain tracker and remove a repeated code in HTable.
        M hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionServerCallable.java
         Clean up move set up of rpc in here rather than have it repeat in HTable.
         Allows me to remove protobuf references from a bunch of places.
    M hbase-client/src/main/java/org/apache/hadoop/hbase/client/FlushRegionCallable.java
     Make use of the push of boilerplate up into RegionServerCallable
    M hbase-client/src/main/java/org/apache/hadoop/hbase/client/MultiServerCallable.java
    M hbase-client/src/main/java/org/apache/hadoop/hbase/client/PayloadCarryingServerCallable.java
    M hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionAdminServiceCallable.java
    M hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerWithReadReplicas.java
    M hbase-client/src/main/java/org/apache/hadoop/hbase/client/ScannerCallable.java
    M hbase-client/src/main/java/org/apache/hadoop/hbase/client/SecureBulkLoadClient.java
    M hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java
     Move boilerplate up into superclass.
    M hbase-client/src/main/java/org/apache/hadoop/hbase/client/RetryingTimeTracker.java
     Cleanup
    M hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/PayloadCarryingRpcController.java
    M hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
    M hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALEditsReplaySink.java
    M hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/RegionReplicaReplicationEndpoint.java
     Factor in TimeLimitedRpcController. Just have one RpcController override.
    D hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/TimeLimitedRpcController.java
     Removed. Lets have one override of pb rpccontroller only.
    M hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
     (handleRemoteException) added
     (toText) added
2016-08-10 10:12:06 -07:00
Phil Yang 091a17e3c9 HBASE-16368 test*WhenRegionMove in TestPartialResultsFromClientSide is flaky
Signed-off-by: zhangduo <zhangduo@apache.org>
2016-08-10 18:13:12 +08:00
Phil Yang ede9940a7b HBASE-16285 Drop RPC requests if it must be considered as timeout at client
Signed-off-by: zhangduo <zhangduo@apache.org>
2016-08-10 16:56:27 +08:00
stack 46defe8e31 HBASE-9899 for idempotent operation dups, return the result instead of throwing conflict exception (Guanghao Zhang): ADDENDUM 2016-08-09 07:09:44 -07:00
Phil Yang 5cadcd59aa HBASE-9465 Push entries to peer clusters serially
Signed-off-by: zhangduo <zhangduo@apache.org>
2016-08-09 15:25:50 +08:00
tedyu 1ecb0fce34 HBASE-16367 Race between master and region server initialization may lead to premature server abort - addendum shortens the waiting duration 2016-08-08 10:39:35 -07:00
tedyu 50f3c9572c HBASE-16367 Race between master and region server initialization may lead to premature server abort 2016-08-08 04:07:30 -07:00
Phil Yang e5f9df1e23 HBASE-12770 Don't transfer all the queued hlogs of a dead server to the same alive server
Signed-off-by: zhangduo <zhangduo@apache.org>
2016-08-08 16:30:23 +08:00
Vivek 30d7eeaefe HBASE-15866 Split hbase.rpc.timeout into *.read.timeout and *.write.timeout
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Amending-Author: Andrew Purtell <apurtell@apache.org>
2016-08-06 16:55:09 -07:00
zhangduo 977858c9cb HBASE-16362 Mob compaction does not set cacheBlocks to false when creating StoreScanner 2016-08-06 22:38:26 +08:00
stack 0206dc67d6 Revert "HBASE-16308 Contain protobuf references Gather up the pb references into a few locations only rather than have pb references distributed all about the code base."
This reverts commit ed87a81b4b.
2016-08-05 15:18:48 -07:00
stack ed87a81b4b HBASE-16308 Contain protobuf references Gather up the pb references into a few locations only rather than have pb references distributed all about the code base.
Purge ServiceException from Callable subclasses by pushing SE handling
up into the parent Callable class (varies by context but this is basic
patten). Allows us remove a bunch of boilerplate.
Do this in the public facing classes in particular (though if
an API has SE in it -- which a few do, this patch leaves these
untouched -- for now.) Make it so HBaseAdmin and HTable have no
direct pb imports (except for endpoint processor API).

Change a few of the HBaseAdmin calls to be retrying where comments
ask that we do retry rather than one time.

Purge TimeLimitedRpcController. Lets just have one override of RpcController.

        M hbase-client/src/main/java/org/apache/hadoop/hbase/client/AbstractRegionServerCallable.java
         Cleanup. Make it clear this is an odd class for async hbase intro.

        M hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java
         Refactor of RegionServerCallable allows me clean up a bunch of
         boilerplate in here and remove protobuf references.

        M hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
          Purge protobuf references everywhere except a reference to a throw of a
          ServiceException in method checkHBaseAvailable. I deprecated it in favor
          of new available method (the SE is not actually needed)

        M hbase-client/src/main/java/org/apache/hadoop/hbase/client/PayloadCarryingServerCallable.java
         Move the RetryingTimeTracker instance in here from HTable.
         Allows me to contain tracker and remove a repeated code in HTable.

        M hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionServerCallable.java
         Clean up move set up of rpc in here rather than have it repeat in HTable.
         Allows me to remove protobuf references from a bunch of places.

    M hbase-client/src/main/java/org/apache/hadoop/hbase/client/FlushRegionCallable.java
     Make use of the push of boilerplate up into RegionServerCallable

    M hbase-client/src/main/java/org/apache/hadoop/hbase/client/MultiServerCallable.java
    M hbase-client/src/main/java/org/apache/hadoop/hbase/client/PayloadCarryingServerCallable.java
    M hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionAdminServiceCallable.java
    M hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerWithReadReplicas.java
    M hbase-client/src/main/java/org/apache/hadoop/hbase/client/ScannerCallable.java
    M hbase-client/src/main/java/org/apache/hadoop/hbase/client/SecureBulkLoadClient.java
    M hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java
     Move boilerplate up into superclass.

    M hbase-client/src/main/java/org/apache/hadoop/hbase/client/RetryingTimeTracker.java
     Cleanup

    M hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/PayloadCarryingRpcController.java
    M hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
    M hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALEditsReplaySink.java
    M hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/RegionReplicaReplicationEndpoint.java
     Factor in TimeLimitedRpcController. Just have one RpcController override.

    D hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/TimeLimitedRpcController.java
     Removed. Lets have one override of pb rpccontroller only.

    M hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
     (handleRemoteException) added
     (toText) added

Signed-off-by: stack <stack@apache.org>
2016-08-05 10:13:58 -07:00
Sean Busbey 431c8c9ad0 HBASE-8386 deprecate TableMapReduce.addDependencyJars(Configuration, class<?> ...)
Signed-off-by: Matteo Bertozzi <matteo.bertozzi@cloudera.com>
2016-08-05 10:35:02 -05:00
Sean Busbey 60b79e2daa HBASE-16321 ensure no findbugs-jsr305
Signed-off-by: Esteban Gutierrez <esteban@apache.org>
2016-08-05 10:16:29 -05:00
tedyu 4b3e45fceb HBASE-16359 Addendum moves null checking as suggested by Heng 2016-08-05 03:18:28 -07:00
Ramkrishna 19c609fa5e HBASE-16303 FilterList with MUST_PASS_ONE optimization (Ram) 2016-08-05 10:58:02 +05:30
tedyu 5e23b3aad5 HBASE-16359 NullPointerException in RSRpcServices.openRegion() 2016-08-04 20:46:48 -07:00
stack 975f0dd958 HBASE-9899 for idempotent operation dups, return the result instead of throwing conflict exception (Guanghao Zhang) 2016-08-04 12:40:19 -07:00
chenheng 550b937bcf HBASE-16287 LruBlockCache size should not exceed acceptableSize too many(Yu Sun) 2016-08-04 21:13:42 +08:00
Lim Chee Hau 0eaf3edc3a HBASE-15574 Fix typo in HRegionServerCommandLine
Signed-off-by: Sean Busbey <busbey@apache.org>
2016-08-03 23:43:33 -05:00
Nick Dimiduk 209b6f74c7 HBASE-16317 revert all ESAPI changes
Revert "HBASE-15270 Use appropriate encoding for "filter" field in TaskMonitorTmpl.jamon."

This reverts commit bba4f107c1.

Revert "HBASE-15122 Servlets generate XSS_REQUEST_PARAMETER_TO_SERVLET_WRITER findbugs warnings (Samir Ahmic)"

This reverts commit 68b300173f.

 Conflicts:
	hbase-server/pom.xml

Revert "HBASE-15329 Cross-Site Scripting: Reflected in table.jsp (Samir Ahmic)"

This reverts commit 4b3e38705c.

 Conflicts:
	hbase-server/src/main/resources/hbase-webapps/master/table.jsp

Revert "HBASE-15369 Handle NPE in region.jsp (Samir Ahmic)"

This reverts commit 3826894f89.
2016-08-03 20:47:02 -07:00
Enis Soztutar 81b06b3bdd HBASE-16350 Undo server abort from HBASE-14968 2016-08-03 19:37:58 -07:00
Enis Soztutar bcf2738a01 HBASE-16301 Trigger flush without waiting when compaction is disabled on a table (huaxiang sun) 2016-08-02 18:46:07 -07:00
Andrew Purtell e63fb6c025 HBASE-16319 Fix TestCacheOnWrite after HBASE-16288 2016-08-02 16:53:32 -07:00
Deokwoo Han eef6a4834a HBASE-16284 Unauthorized client can shutdown the cluster 2016-08-02 11:21:31 -07:00