Commit Graph

14783 Commits

Author SHA1 Message Date
Michael Stack c1470714bb HBASE-19794 TestZooKeeper hangs
Kill backup master first

Add some cleanup around NamespaceManager

Shorten the timeout waiting on namespace manager as workaround
until we have better soln for interrupting ongoing client rpcs.
Do it in general for all tests.

Signed-off-by: zhangduo <zhangduo@apache.org>
2018-01-21 20:59:31 +08:00
Michael Stack 86ecc963e4 HBASE-19828 Flakey TestRegionsOnMasterOptions.testRegionsOnAllServers
Rename the PE Worker threads.

Send an interrupt if worker taking a long time to go down
(it may be RPC'ing out to a dead server, retrying so
interrupt). Also join on the ProcedureExecutor shutting down.
This will make problems shutting down more obvious.

Disable TestRegionsOnMasterOptions. Master carrying Regions is broke.
2018-01-19 21:54:44 -08:00
Artem Ervits 8f713fcc19 HBASE-19829 hadoop-minicluster pulls zookeeper:test-jar:tests 3.4.6
Signed-off-by: tedyu <yuzhihong@gmail.com>
2018-01-19 15:22:15 -08:00
Apekshit Sharma cdfd12c101 HBASE-19823 Make RawCellBuilderFactory LimitedPrivate.UNITTEST 2018-01-19 14:53:27 -08:00
Michael Stack 0f9a837bd1
HBASE-19827 Addendum for Flakey TestAssignmentManager Don't clear old location from RTP... 2018-01-19 13:47:11 -08:00
Reid Chan 3131234ffd HBASE-19822 Override cancel(boolean) in LogCleaner (Addendum)
Signed-off-by: Michael Stack <stack@apache.org>
2018-01-19 11:48:16 -08:00
Guangxu Cheng c01dc69123 HBASE-19799 Add web UI to rsgroup
Signed-off-by: tedyu <yuzhihong@gmail.com>
2018-01-18 19:30:06 -08:00
Umesh Agashe 3f1203d6d6 HBASE-19825 Fix hadoop3 compat test failures, need commons-beanutils from hadoop 3 2018-01-18 18:29:28 -08:00
tedyu 5aa802e2c9 HBASE-19757 System table gets stuck after enabling region server group feature in secure cluster - addendum removes unused import 2018-01-18 18:14:53 -08:00
tedyu 8ad56249a8 HBASE-19757 System table gets stuck after enabling region server group feature in secure cluster 2018-01-18 17:56:52 -08:00
Michael Stack a57769a15c HBASE-19822 HFileCleaner threads stick around after shutdown stuck on queue#take Interrupt wait on queue when cancel is called. 2018-01-18 13:53:11 -08:00
Michael Stack 13547d53eb HBASE-19815 Flakey TestAssignmentManager.testAssignWithRandExec (Part Two).
Part One cleaned up a ClassCastException.

Part Two adds the ServerCrashProcedure#handleRIT behavior to RecoverMetaProcedure.

Adds debug in the test.
2018-01-18 11:32:37 -08:00
Michael Stack 7225899e01 HBASE-19527 Make ExecutorService threads daemon=true
Set the ProcedureExcecutor worker threads as daemon.
Ditto for the timeout thread.

Remove hack from TestRegionsOnMasterOptions that was
put in place because the test would not go down.
2018-01-18 11:30:46 -08:00
lixiang a2d9a17851 HBASE-19821 TestCleanerChore#testOnConfigurationChange() requires at least 4 processors to get passed
Signed-off-by: tedyu <yuzhihong@gmail.com>
2018-01-18 11:20:52 -08:00
Apekshit Sharma 25621c6ea2 HBASE-19820 Restore public constructor of MiniHBaseCluster (API compat). 2018-01-18 09:07:30 -08:00
tedyu 251826e138 HBASE-19806 Lower max versions for table column family of hbase:meta 2018-01-18 07:58:44 -08:00
zhangduo d7e2e0d02c HBASE-19812 TestFlushSnapshotFromClient fails because of failing region.flush 2018-01-18 16:23:15 +08:00
Scott Wilson 0f2c1fa066 HBASE-19816 Refresh repliation sinks on UnknownHostException
Signed-off-by: tedyu <yuzhihong@gmail.com>
2018-01-17 16:25:17 -08:00
Mike Drob 4476cc196c
HBASE-19784 bin/stop-hbase more friendly when hbase already stopped
Signed-off-by: Michael Stack <stack@apache.org>
2018-01-17 15:49:23 -08:00
Michael Stack af2d890055 Revert "HBASE-19527 Make ExecutorService threads daemon=true"
Applied prematurely. Revert.

This reverts commit 5e4ed33fa2.
2018-01-17 15:08:42 -08:00
Michael Stack 0f5b0fb759 HBASE-19815 Flakey TestAssignmentManager.testAssignWithRandExec 2018-01-17 13:50:42 -08:00
Michael Stack 5e4ed33fa2 HBASE-19527 Make ExecutorService threads daemon=true
Set the ProcedureExcecutor worker threads as daemon.
Ditto for the timeout thread.

Remove hack from TestRegionsOnMasterOptions that was
put in place because the test would not go down.
2018-01-17 13:41:38 -08:00
Peter Somogyi 4676d4bf4a HBASE-19810 Fix findbugs and error-prone warnings in hbase-metrics (branch-2)
Signed-off-by: Michael Stack <stack@apache.org>
2018-01-17 11:26:07 -08:00
Peter Somogyi 0561312bc4 HBASE-19809 Fix findbugs and error-prone warnings in hbase-procedure (branch-2) 2018-01-17 11:24:22 -08:00
Josh Elser b4f6ae86b6 HBASE-19770 Separate command return values from interactive shells
Uses a new option to the shell to specify that return values are
unwanted instead of overloading the interactive option. Enable
return_values when the shell is non-interactive.

Signed-off-by: Apekshit Sharma <appy@apache.org>
2018-01-17 13:13:46 -05:00
Michael Stack addd716549
HBASE-19808 Reenable TestMultiParallel 2018-01-17 08:59:05 -08:00
Reid Chan f22cf7226e HBASE-19736 Remove BaseLogCleanerDelegate deprecated #isLogDeletable(FileStatus) and use #isFileDeletable(FileStatus) instead
Signed-off-by: Chia-Ping Tsai <chia7712@gmail.com>
2018-01-17 21:25:20 +08:00
zhangduo 48bb19012c HBASE-19792 TestReplicationSmallTests.testDisableEnable fails 2018-01-17 14:23:17 +08:00
Umesh Agashe 20afaca769
HBASE-19739 Include thrift IDL files in hbase-thrift.jar and .proto files in hbase-protocol-shaded.jar respectively
Signed-off-by: Michael Stack <stack@apache.org>
2018-01-16 12:35:56 -08:00
Apekshit Sharma e60d302b90 HBASE-19789 Not exclude flaky tests from nightly builds. 2018-01-16 10:09:50 -08:00
Vasudevan f23fd7208b HBASE-19732 Replica regions does not return back the MSLAB chunks to pool
(Ram)
2018-01-15 22:15:01 +05:30
zhangduo e014e5f8ef HBASE-19797 Operator priority leads to wrong logic in ReplicationSourceWALReader 2018-01-15 18:10:56 +08:00
zhangduo 204a4539c4 HBASE-19793 Minor improvements on Master/RS startup 2018-01-15 17:54:01 +08:00
zhangduo 8dd4bf8e54 HBASE-19795 Move the tests which only need zookeeper in TestZooKeeper to hbase-zookeeper module 2018-01-15 10:58:03 +08:00
zhangduo ffa28502c4 HBASE-19768 RegionServer startup failing when DN is dead 2018-01-14 17:31:23 +08:00
zhangduo 842f794a62 HBASE-19772 Do not close connection to zk when there are still pending request in ReadOnlyZKClient 2018-01-14 17:08:30 +08:00
Apekshit Sharma f91589d305 HBASE-19789 Exclude flaky tests from nightly branch-2 runs 2018-01-12 16:24:45 -08:00
Michael Stack 026f535a77 HBASE-19787 Fix or disable tests broken in branch-2 so can cut beta-1
M dev-support/make_rc.sh
  Disable checkstyle building site. Its an issue being fixed over in HBASE-19780

M hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
  The clusterid was being set into the process only after the
  regionserver registers with the Master. That can be too late for some
  test clients in particular. e.g. TestZKAsyncRegistry needs it as soon
  as it goes to run which could be before Master had called its run
  method  which is regionserver run method which then calls back to the
  master to register itself... and only then do we set the clusterid.
  HBASE-19694 changed start order which made it so this test failed.
  Setting the clusterid right after we set it in zk makes the test pass.

  Another change was that backup masters were not going down on stop.
  Backup masters were sleeping for the default zk period which is 90
  seconds. They were not being woken up to check for stop. On stop
  master now tells active master manager.

M hbase-server/src/test/java/org/apache/hadoop/hbase/TestJMXConnectorServer.java
  Prevent creation of acl table. Messes up our being able to go down
  promptly.

M hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestRegionsOnMasterOptions.java
M hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMultiParallel.java
M hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerReadRequestMetrics.java
  Disabled for now because it wants to run with regions on the Master...
  currently broke!

M hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestZKAsyncRegistry.java
  Add a bit of debugging.

M hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestDLSAsyncFSWAL.java
  Disabled. Fails 40% of the time.

M hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestDLSFSHLog.java
  Disabled. Fails 33% of the time.

Disabled stochastic load balancer for favored nodes because it fails on
occasion and we are not doing favored nodes in branch-2.
2018-01-12 14:09:23 -08:00
Michael Stack d8271b0361
HBASE-19694 The initialization order for a fresh cluster is incorrect Addendum. Adds in a missing line that helps debugging. 2018-01-12 13:08:27 -08:00
tedyu 9ed52ee3e5 HBASE-19752 RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where rs group cannot be determined 2018-01-12 12:16:06 -08:00
Josh Elser b662080734 HBASE-19769 Remove ZK metrics because of classloader issues
When we run MapReduce jobs via `yarn jar`, the special classloader
which is set up by YARN creates a situation where our invocation of
package-private Hadoop classes throws an IllegalAccessError. It's
easiest to just remove these and rethink how to avoid further
Hadoop metrics2 issues.

Signed-off-by: Michael Stack <stack@apache.org>
2018-01-12 12:40:47 -05:00
Sergey Soldatov b979487cac HBASE-19775 hbase shell doesn't handle the exceptions that are wrapped in java.io.UncheckedIOException
Signed-off-by: Josh Elser <elserj@apache.org>
Signed-off-by: Michael Stack <stack@apache.org>
2018-01-12 12:38:13 -05:00
Janos Gub f7fbc168a1 HBASE-19771 restore_snapshot shell command gives wrong namespace if the namespace doesn't exist
Signed-off-by: tedyu <yuzhihong@gmail.com>
2018-01-12 07:37:40 -08:00
Guanghao Zhang 72702eeb70 HBASE-19783 Change replication peer cluster key/endpoint from a not-null value to null is not allowed
Signed-off-by: zhangduo <zhangduo@apache.org>
2018-01-12 21:41:57 +08:00
Chia-Ping Tsai 3e6f80dcd5
HBASE-19746 Add default impl to Cell#getType 2018-01-11 15:04:25 -08:00
Michael Stack 1a11fc92b1 HBASE-19694 The initialization order for a fresh cluster is incorrect
Become active Master before calling the super class's run method. Have
the wait-on-becoming-active-Master be in-line rather than off in a
background thread (i.e. undo running thread in startActiveMasterManager)

Purge the fragile HBASE-16367 hackery that attempted to fix this issue
previously by adding a latch to try and hold up superclass RegionServer
until cluster id set by subclass Master.
2018-01-11 14:25:25 -08:00
Apekshit Sharma 25e4bf8f37 HBASE-19773 Documenting how to get instance of type RawCellBuilder 2018-01-11 13:17:30 -08:00
zhangduo 0dacdde0f9 HBASE-19758 Split TestHCM to several smaller tests
Signed-off-by: Michael Stack <stack@apache.org>
2018-01-11 11:40:48 -08:00
Michael Stack a917a4e796 HBASE-19753 Miscellany of fixes for hbase-zookeeper tests to make them more robust
First, we add test resources to CLASSPATH when tests run. W/o it, there
was no logging of hbase-zookeeper test output (not sure why I have to
add this here and not over in hbase-server; research turns up nothing
so far).

M hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKMainServer.java
 Improve fail log message.

M hbase-zookeeper/src/test/java/org/apache/hadoop/hbase/zookeeper/TestReadOnlyZKClient.java
M hbase-zookeeper/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZKNodeTracker.java
 Wait until ZK is connected before progressing. On my slow zk, it could
 be a while post construction before zk connected. Using an unconnected
 zk caused test to fail.

M hbase-zookeeper/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZKMainServer.java
 Change session timeout to default 30s from 1s which was way too short.

M hbase-zookeeper/src/test/resources/log4j.properties
 Set zk logs to DEBUG level in this module at least.

Adds a ZooKeeperHelper class that has utility to help interacting w/ ZK.
2018-01-11 11:22:56 -08:00
Rahul Gidwani 3849db8f1d HBASE-11409 - Add more flexibility for input directory structure to LoadIncrementalHFiles 2018-01-11 11:07:47 -08:00