Andrew Purtell
a11220d3bf
HBASE-25693 NPE getting metrics from standby masters (MetricsMasterWrapperImpl.getMergePlanCount) ( #3091 )
...
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
2021-03-24 19:11:07 -07:00
huaxiangsun
91205bf227
HBASE-25691 Test failure: TestVerifyBucketCacheFile.testRetrieveFromFile ( #3088 )
...
The issue is that FileInputStream is created with try-with-resources, so its close() is called right after the try sentence.
FileInputStream is a finalize class, when this object is garbage collected, its close() is called again.
To avoid this double-free resources, add guard against it.
Signed-off-by: stack <stack@apache.org>
2021-03-24 14:39:35 -07:00
Toshihiro Suzuki
4cf28c43f5
HBASE-25678 Support nonce operations for Increment/Append in RowMutations and CheckAndMutate
...
Signed-off-by: stack <stack@apache.org>
2021-03-21 23:39:45 +09:00
shahrs87
27e9c281da
HBASE-25679 Size of log queue metric is incorrect ( #3071 )
...
Co-authored-by: Rushabh <rushabh.shah@salesforce.com>
Signed-off-by: stack <stack@apache.org>
2021-03-19 16:16:13 -07:00
haxiaolin
df6e5dd0b1
HBASE-25518 Support separate child regions to different region servers ( #3001 )
...
Signed-off-by: stack <stack@apache.org>
2021-03-18 12:39:15 -07:00
Michael Stack
3331e8307a
HBASE-25677 Server+table counters on each scan #nextRaw invocation becomes a bottleneck when heavy load ( #3061 )
...
Don't have every handler update regionserver metrics on each
scan#nextRaw; instead, do a batch update just before Scan
returns. Otherwise, all running handlers end up contending
on metrics update.
M hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
Update of regionserver metrics counters moved out to caller where
can be done as a batch update instead of per-next.
M hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServer.java
Class doc to encourage batch updating metrics.
Remove the single update as unused anymore.
M hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
Count calls to nextRaw. Update regionserver count in finally block when
scan is done rather than per nextRaw call. Move all metrics updates to
finally.
Signed-off-by: Reid Chan <reidchan@apache.org>
Signed-off-by: Baiqiang Zhao <ZhaoBQ>
2021-03-18 11:34:53 -07:00
Sandeep Pal
c485a6bb79
HBASE-25627: HBase replication should have a metric to represent if the source is stuck getting initialized ( #3018 )
...
Introduces a new metric that tracks number of replication sources that are stuck in initialization.
Signed-off-by: Xu Cang <xucang@apache.org>
Signed-off-by: Bharath Vissapragada <bharathv@apache.org>
(cherry picked from commit ff3821814a
)
2021-03-17 10:36:24 -07:00
stack
7de67b30fc
Revert "HBASE-25665 Option to use hostname instead of canonical hostname for secure HBase cluster connection ( #3051 )"
...
This reverts commit 90c147f97c
.
Reverting because new feature and only want bug fixes on branches.
2021-03-16 21:08:24 -07:00
bitterfox
90c147f97c
HBASE-25665 Option to use hostname instead of canonical hostname for secure HBase cluster connection ( #3051 )
2021-03-16 21:05:42 -07:00
Baiqiang Zhao
aa6c013a01
HBASE-25597 Add row info in Exception when cell size exceeds maxCellSize ( #2976 )
...
Signed-off-by: stack <stack@apache.org>
2021-03-15 15:50:45 -07:00
haxiaolin
df2daf9e1e
HBASE-25621 Balancer should check region plan source to avoid misplace region groups ( #3002 )
...
Signed-off-by: stack <stack@duboce.net>
2021-03-15 14:48:47 -07:00
haxiaolin
3c9a7e01ed
HBASE-25595 TestLruBlockCache.testBackgroundEvictionThread is flaky ( #2974 )
...
Signed-off-by: stack <stack@apache.org>
2021-03-15 14:26:31 -07:00
Michael Stack
6414ef91d6
HBASE-25660 Print split policy in use on Region open (as well as split policy vitals) ( #3044 )
...
Add a toString to all split policy implementations listing name and
vitals. Use this toString in the Region open message. Ditto for flush
policy for the Region.
Signed-off-by: Huaxiang Sun<huaxiangsun@apache.org>
2021-03-15 14:11:54 -07:00
haxiaolin
2ecf9232bf
HBASE-25635 CandidateGenerator may miss some region balance actions ( #3024 )
...
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2021-03-15 21:42:02 +08:00
Duo Zhang
f9d80f18cb
HBASE-25657 Fix spotbugs warnings after upgrading spotbugs to 4.x ( #3041 )
...
Signed-off-by: meiyi <myimeiyi@gmail.com>
Signed-off-by: stack <stack@apache.org>
2021-03-12 14:37:29 +08:00
shahrs87
5c149d1ce6
HBASE-25622 Result#compareResults should compare tags. ( #3026 )
...
Signed-off-by: stack <stack@apache.org>
2021-03-11 21:52:45 -08:00
Michael Stack
8658650823
HBASE-25570 On largish cluster, "CleanerChore: Could not delete dir..." makes master log unreadable ( #2949 )
...
Turn down the amount we log. If you want to see the full exception
enable TRACE-level logging.
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: shahrs87
2021-03-11 21:37:16 -08:00
Peter Somogyi
723f2eea76
HBASE-25587 [hbck2] Schedule SCP for all unknown servers ( #2978 )
...
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
2021-03-11 17:28:56 +01:00
meiyi
35d44c6ce6
HBASE-25636 Expose HBCK report as metrics ( #3031 )
...
Signed-off-by: zhangduo <zhangduo@apache.org>
2021-03-11 15:32:41 +08:00
Duo Zhang
ee7beca604
HBASE-25629 Reimplement TestCurrentHourProvider to not depend on unstable TZs ( #3013 )
...
Signed-off-by: XinSun <ddupgs@gmail.com>
2021-03-10 23:54:10 +08:00
Wellington Ramos Chevreuil
75a4b6143e
HBASE-25548 Optionally allow snapshots to preserve cluster's max file… ( #2923 )
...
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
(cherry picked from commit 373dc7788d
)
2021-03-10 10:37:46 +00:00
Anoop Sam John
e793303d7f
HBASE-25582 Support setting scan ReadType to be STREAM at cluster level ( #3040 )
...
Signed-off-by: zhangduo <zhangduo@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2021-03-10 13:24:31 +05:30
Narges Shadab
4a0b3cc724
HBASE-25646: Possible Resource Leak in CatalogJanitor #3036
...
Close the stream using a try-with-resources block.
Reviewed-by: Aman Poonia <aman.poonia.29@gmail.com>
Signed-off-by: Wei-Chiu Chuang <weichiu@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: Bharath Vissapragada <bharathv@apache.org>
(cherry picked from commit 573daed419
)
2021-03-09 09:14:44 -08:00
Andrew Purtell
bda2b8af8b
Preparing development version 2.4.3-SNAPSHOT
...
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2021-03-08 15:59:42 -08:00
Andrew Purtell
3e98c51c51
Preparing hbase release 2.4.2RC0; tagging and updates to CHANGES.md and RELEASENOTES.md
...
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2021-03-08 15:59:36 -08:00
Duo Zhang
7f4ad3cfb2
HBASE-23578 [UI] Master UI shows long stack traces when table is broken ( #3014 )
...
Co-authored-by: Shuhei Yamasaki <yamasakisua@oss.nttdata.com>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2021-03-07 21:36:55 +08:00
Narges Shadab
13a86924d7
HBASE-25626 Possible Resource Leak in HeterogeneousRegionCountCostFunction
...
Signed-off-by Anoop Sam John <anoopsamjohn@apache.org>
Signed-off-by shahrs87 <shahrs87@gmail.com>
2021-03-05 08:58:05 +05:30
Rahul Kumar
eb640a6f0f
HBASE-25460 : Expose drainingServers as cluster metric ( #2994 ) ( #2995 )
...
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2021-03-04 12:51:47 +05:30
Andrew Purtell
ddbb3e4b69
HBASE-25385 TestCurrentHourProvider fails if the latest timezone changes are not present ( #3012 )
...
Disable this problematic test for now. May be removed after additional
discussion.
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2021-03-03 18:16:24 -08:00
Sandeep Pal
f535223861
HBASE-25596: Fix NPE and avoid permanent unreplicated data due to EOF ( #3008 )
...
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Conflicts:
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationBase.java
2021-03-03 11:40:51 -08:00
Akshay Sudheer
5b92554906
HBASE-25367 Sort broken after Change 'State time' in UI ( #2964 )
...
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Pankaj Kumar<pankajkumar@apache.org>
(cherry picked from commit 5d9a6ed1fe
)
2021-03-03 15:12:47 +05:30
Mohammad Arshad
a561c71f00
HBASE-25371: When openRegion fails during initial verification(before… ( #2785 )
...
Signed-off-by: stack <stack@apache.org>
2021-03-03 08:28:31 +08:00
Andrew Purtell
65999a9027
Revert "HBASE-25596: Fix NPE and avoid permanent unreplicated data due to EOF ( #2990 )"
...
This reverts commit 9590080a21
.
2021-03-02 12:23:17 -08:00
Balazs Meszaros
1c49ffd432
HBASE-25586 Fix HBASE-22492 on branch-2 (SASL GapToken) ( #2961 )
...
ServerCall.java: calling wrapWithSasl() was moved to getResponse(), so
the SASL wrapping is delayed until the reply is sent back to the client.
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
2021-02-26 14:11:33 +01:00
XinSun
db4f2bfa25
HBASE-25590 Bulkload replication HFileRefs cannot be cleared in some cases where set exclude-namespace/exclude-table-cfs ( #2969 )
...
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
2021-02-26 09:59:52 +08:00
Sandeep Pal
9590080a21
HBASE-25596: Fix NPE and avoid permanent unreplicated data due to EOF ( #2990 )
...
Signed-off-by: Xu Cang <xucang@apache.org>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Conflicts:
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationBase.java
2021-02-25 13:38:08 -08:00
XinSun
9ebddeeda5
HBASE-25598 TestFromClientSide5.testScanMetrics is flaky ( #2977 )
...
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2021-02-24 14:45:19 +08:00
Andrew Purtell
4240dca4ff
HBASE-25556 Frequent replication "Encountered a malformed edit" warnings ( #2965 )
...
ProtobufLogReader#readNext may be called by code that attempts to advance
the reader but does not necessarily expect to succeed, for example
WALEntryStream#tryAdvanceEntry. Much of the logging in this method is
at TRACE level. Other logging at WARN level will be frequently emitted, as
often as several per minute, and this will cause false positive assessment
from operators that they are experiencing a bug. Fix the mixed intent with
respect to log levels in readNext. Log at only DEBUG level or below.
Signed-off-by: Sean Busbey <busbey@apache.org>
2021-02-23 14:41:31 -08:00
Toshihiro Suzuki
9cfeec0deb
HBASE-25575 Should validate Puts in RowMutations
...
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2021-02-22 11:04:09 +09:00
Toshihiro Suzuki
b78366cf50
HBASE-25574 Revisit put/delete/increment/append related RegionObserver methods
...
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2021-02-22 10:16:42 +09:00
XinSun
c1a9e8973a
HBASE-25562 ReplicationSourceWALReader log and handle exception immediately without retrying ( #2943 )
...
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Signed-off-by: stack <stack@apache.org>
Signed-off-by: shahrs87
2021-02-20 10:28:18 +08:00
shahrs87
627ac016cc
HBASE-25539: Add age of oldest wal metric ( #2962 )
...
Signed-off-by: Bharath Vissapragada <bharathv@apache.org>
(cherry picked from commit 6a4c9be967
)
2021-02-18 21:26:39 -08:00
Sandeep Pal
f637a60992
HBASE-25541 : Setting the path to null when we dequeue the current log ( #2959 )
...
Signed-off-by: Bharath Vissapragada <bharathv@apache.org>
2021-02-18 11:57:01 +05:30
pustota2009
83cc05a14e
HBASE-23887 Bug fix heavyEvictionMbSizeLimit (ADDENDUM) ( #2957 )
...
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2021-02-15 20:46:14 +05:30
pustota2009
79272e481b
HBASE-23887 AdaptiveLRU cache ( #2934 )
...
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2021-02-13 20:12:16 +05:30
Baiqiang Zhao
56937056ea
HBASE-25534 Honor TableDescriptor settings earlier in normalization ( #2917 )
...
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
2021-02-09 16:57:59 -08:00
XinSun
e7414f98fd
HBASE-25559 Terminate threads of oldsources while RS is closing ( #2938 )
...
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: stack <stack@apache.org>
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
2021-02-09 16:57:29 +08:00
haxl
6849279023
HBASE-25507 Leak of ESTABLISHED sockets when compaction encountered "java.io.IOException: Invalid HFile block magic" ( #2882 )
...
Signed-off-by: Ramkrishna <ramkrishna@apache.org>
Signed-off-by: stack <stack@apache.org>
2021-02-08 22:16:18 -08:00
Michael Stack
de9bbd6968
HBASE-25542 Add client detail to scan name so when lease expires, we … ( #2930 )
...
* HBASE-25542 Add client detail to scan name so when lease expires, we have clue on who was scanning
When we create a scanner lease, record client ip and port (removed
unnecessary store of scannerName).
Signed-off-by: Clara Xiong <clarax98007@gmail.com>
2021-02-08 14:39:30 -08:00
Baiqiang Zhao
2989f8edb0
HBASE-25431 MAX_FILESIZE and MEMSTORE_FLUSHSIZE should not be set negative number ( #2803 )
...
Signed-off-by: stack <stack@apache.org>
2021-02-08 14:39:25 -08:00