a1d59bf1a5
HBASE-25994 Active WAL tailing fails when WAL value compression is enabled ( #3377 )
...
Depending on which compression codec is used, a short read of the
compressed bytes can cause catastrophic errors that confuse the WAL reader.
This problem can manifest when the reader is actively tailing the WAL for
replication. To avoid these issues when WAL value compression is enabled,
BoundedDelegatingInputStream should assume enough bytes are available to
supply a reader up to its bound. This behavior is valid per the contract
of available(), which provides an _estimate_ of available bytes, and
equivalent to IOUtils.readFully but without requiring an intermediate
buffer.
Added TestReplicationCompressedWAL and TestReplicationValueCompressedWAL.
Without the WALCellCodec change TestReplicationValueCompressedWAL will
fail.
Signed-off-by: Bharath Vissapragada <bharathv@apache.org>
2021-06-14 17:18:53 -07:00
88f031eeec
HBASE-25967 The readRequestsCount does not calculate when the outResu… ( #3351 )
...
* HBASE-25967 The readRequestsCount does not calculate when the outResults is empty
Co-authored-by: Zheng Wang <wangzheng@apache.org>
(cherry picked from commit 329f0baa98
2021-06-10 10:24:18 +08:00
b6837295f3
HBASE-25981 JVM crash when displaying RegionServer UI ( #3364 )
...
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2021-06-09 18:16:33 +08:00
e4dd4901a8
HBASE-25963 HBaseCluster should be marked as IA.Public ( #3348 )
...
Signed-off-by: Yulin Niu <niuyulin@apache.org>
2021-06-06 21:27:02 +08:00
1267bdb1a4
HBASE-25929 RegionServer JVM crash when compaction ( #3318 )
...
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2021-06-03 17:20:08 +08:00
a4e8ee183e
HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime ( #3302 )
...
We introduced EnvironmentEdgeManager as a way to inject alternate clocks
for unit tests. In order for this to be effective, all callers that would
otherwise use System.currentTimeMillis() must call
EnvironmentEdgeManager.currentTime() instead, except the implementers of
EnvironmentEdge.
Signed-off-by: Bharath Vissapragada <bharathv@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Conflicts:
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManager.java
hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupBase.java
hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupManager.java
hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupSystemTable.java
hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncConnectionTracing.java
hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncRegionLocatorTracing.java
hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestBackupRestore.java
hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestManyRegions.java
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/MoveRegionsOfTableAction.java
hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestWALRecordReader.java
hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/replication/TestVerifyReplicationCrossDiffHdfs.java
hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/snapshot/TestExportSnapshotV1NoCluster.java
hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestEnableRSGroups.java
hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsAdmin2.java
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/CallRunner.java
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/SimpleRpcServer.java
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionStateStore.java
hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/SimpleLoadBalancer.java
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/AbstractWALRoller.java
hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
hbase-server/src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java
hbase-server/src/test/java/org/apache/hadoop/hbase/TestMetaTableAccessor.java
hbase-server/src/test/java/org/apache/hadoop/hbase/TestMetaUpdatesGoToPriorityQueue.java
hbase-server/src/test/java/org/apache/hadoop/hbase/TestSerialization.java
hbase-server/src/test/java/org/apache/hadoop/hbase/backup/TestHFileArchiving.java
hbase-server/src/test/java/org/apache/hadoop/hbase/client/RestoreSnapshotFromClientSimpleTestBase.java
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin2.java
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestConnection.java
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide3.java
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMobCloneSnapshotFromClientCloneLinksAfterDelete.java
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMutationGetCellBuilder.java
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestSnapshotMetadata.java
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestActiveMasterManager.java
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterMetricsWrapper.java
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMetaAssignmentWithStopMaster.java
hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestRegionStateStore.java
hbase-server/src/test/java/org/apache/hadoop/hbase/master/cleaner/TestLogsCleaner.java
hbase-server/src/test/java/org/apache/hadoop/hbase/master/cleaner/TestReplicationHFileCleaner.java
hbase-server/src/test/java/org/apache/hadoop/hbase/master/janitor/TestCatalogJanitor.java
hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/MasterProcedureSchedulerPerformanceEvaluation.java
hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestCloneSnapshotProcedure.java
hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestRestoreSnapshotProcedure.java
hbase-server/src/test/java/org/apache/hadoop/hbase/procedure2/store/region/RegionProcedureStorePerformanceEvaluation.java
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionInfo.java
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHStoreFile.java
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMajorCompaction.java
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionOpen.java
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSimpleTimeRangeTracker.java
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestWideScanner.java
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/compactions/TestCloseChecker.java
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/AbstractTestProtobufLog.java
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/AbstractTestWALReplay.java
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestCombinedAsyncWriter.java
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/master/TestRecoverStandbyProcedure.java
hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestFlushSnapshotFromClient.java
hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestSyncReplicationWALProvider.java
hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java
2021-06-01 12:41:15 -07:00
d4285be5c1
HBASE-25932: Ensure replication reads the trailer bytes from WAL. ( #3332 ) ( #3345 )
...
This bug was exposed by the test from HBASE-25924. Since this wal
implementations close the wal asynchronously, replication can potentially
miss the trailer bytes. (see jira comment for detailed analysis).
While this is not a correctness problem (since trailer does not have any entry data),
it erroneously bumps a metric that is used to track skipped bytes in WAL resulting
in false alarms which is something we should avoid.
Reviewed-by: Rushabh Shah <rushabh.shah@salesforce.com>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by Anoop Sam John <anoopsamjohn@apache.org>
(cherry picked from commit b04c3c7786
2021-06-01 08:04:12 -07:00
1a45b743a0
HBASE-25940 Update Compression/TestCompressionTest: LZ4, SNAPPY, LZO ( #3334 )
...
Undo asserts that LZ4 and SNAPPY fails if their native libs are NOT
loaded; as of hadoop 3.3.1, LZ4 and SNAPPY can work w/o native libs.
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2021-05-29 09:04:08 -07:00
5157521213
HBASE-25927: Fix the log messages by not stringifying the exceptions in log ( #3338 )
...
Signed-off-by: Bharath Vissapragada <bharathv@apache.org>
(cherry picked from commit 9a2027bf71
2021-05-28 21:34:14 -07:00
2a84fd40d3
HBASE-25938 The SnapshotOfRegionAssignmentFromMeta.initialize call in FavoredNodeLoadBalancer is just a dummy one ( #3329 )
...
Signed-off-by: Yulin Niu <niuyulin@apache.org>
2021-05-29 11:10:52 +08:00
bbe9558040
HBASE-25745 Deprecate/Rename config `hbase.normalizer.min.region.count` to `hbase.normalizer.merge.min.region.count`
...
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
2021-05-28 13:10:20 -07:00
5aa39a975c
HBASE-25910 - Fix port assignment test ( #3308 )
...
Signed-off-by: David Manning <david.manning@salesforce.com>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2021-05-28 20:53:20 +05:30
cad9ae386a
HBASE-25933 Log trace raw exception, instead of cause message in NettyRpcServerRequestDecoder ( #3323 )
...
Signed-off-by: Rushabh Shah <shahrs87@gmail.com>
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
Signed-off-by: Josh Elser <elserj@apache.org>
2021-05-27 20:03:17 +01:00
3cf0678aee
HBASE-25926 Cleanup MetaTableAccessor references in FavoredNodeBalancer related code ( #3313 )
...
Signed-off-by: Yulin Niu <niuyulin@apache.org>
2021-05-27 16:25:01 +08:00
e265eccf20
HBASE-25924 Re-compute size of WAL file while removing from WALEntryStream ( #3315 )
...
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Bharath Vissapragada <bharathv@apache.org>
2021-05-26 10:42:03 -07:00
563ebc214a
HBASE-25534 Honor TableDescriptor settings earlier in normalization ( #2917 )
...
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
2021-05-25 08:24:05 -07:00
2cb6cc8a6c
HBASE-25894 Improve the performance for region load and region count related cost functions ( #3276 )
...
Signed-off-by: Yi Mei <myimeiyi@gmail.com>
2021-05-25 18:07:33 +08:00
8754e88fa7
HBASE-25906 UI of master-status to show recent history of balancer desicion ( #3303 ) ( #3296 )
...
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2021-05-25 12:39:47 +05:30
073f23e2bd
HBASE-25513 When the table is turned on normalize, the first region may not be merged even the size is 0 ( #2887 )
...
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
2021-05-24 17:27:06 -07:00
1649013b99
HBASE-25898 RS getting aborted due to NPE in Replication WALEntryStream ( #3292 )
...
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: Rushabh Shah <shahrs87@gmail.com>
2021-05-24 23:44:32 +05:30
76d56bc42e
HBASE-25899 Improve efficiency of SnapshotHFileCleaner ( #3280 )
...
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2021-05-24 22:18:43 +08:00
1c1acee2fb
HBASE-25873 Refactor and cleanup the code for CostFunction ( #3274 )
...
Signed-off-by: Yi Mei <myimeiyi@gmail.com>
2021-05-24 22:13:01 +08:00
16f865f65d
HBASE-25773 TestSnapshotScannerHDFSAclController.setupBeforeClass is flaky ( #3160 )
...
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2021-05-22 22:20:47 +08:00
a19dee1eed
HBASE-25892: 'False' should be 'True' in auditlog of listLabels ( #3273 )
...
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2021-05-22 17:25:43 +08:00
926c1132c0
HBASE-25848: Add flexibility to backup replication in case replication filter throws an exception
...
Signed-off-by: Xu Cang <xcang@salesforce.com>
2021-05-21 12:14:35 -07:00
2d591ab3c4
HBASE-25869 WAL value compression ( #3244 )
...
WAL storage can be expensive, especially if the cell values
represented in the edits are large, consisting of blobs or
significant lengths of text. Such WALs might need to be kept around
for a fairly long time to satisfy replication constraints on a space
limited (or space-contended) filesystem.
We have a custom dictionary compression scheme for cell metadata that
is engaged when WAL compression is enabled in site configuration.
This is fine for that application, where we can expect the universe
of values and their lengths in the custom dictionaries to be
constrained. For arbitrary cell values it is better to use one of the
available compression codecs, which are suitable for arbitrary albeit
compressible data.
Signed-off-by: Bharath Vissapragada <bharathv@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
2021-05-21 11:53:36 -07:00
7b374b7c76
HBASE-25827 Per Cell TTL tags get duplicated with increments causing tags length overflow ( #3290 )( #3210 )
...
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2021-05-21 22:58:32 +05:30
d78c164429
HBASE-25897 TestRetainAssignmentOnRestart is flaky after HBASE-25032 ( #3281 )
...
Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>
2021-05-20 21:18:09 +08:00
3040be1438
HBASE-25791 UI of master-status to show a recent history of that why balancer was rejected to run ( #3278 )
...
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2021-05-20 15:00:00 +08:00
aab6e1d0ff
HBASE-25861 Correct the usage of Configuration#addDeprecation ( #3249 )
...
Co-authored-by: Baiqiang Zhao <zbq.dean@gmail.com>
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
2021-05-18 06:53:31 -07:00
8110b18ab0
HBASE-25032 Do not assign regions to region server which has not called regionServerReport yet ( #3268 )
...
Signed-off-by: Bharath Vissapragada <bharathv@apache.org>
Signed-off-by: Michael Stack <stack@apache.org>
2021-05-18 10:43:01 +08:00
1a8d3c3b6b
HBASE-25875 RegionServer failed to start with IllegalThreadStateException due to race condition in AuthenticationTokenSecretManager ( #3250 )
...
* HBASE-25875 RegionServer failed to start with IllegalThreadStateException due to race condition in AuthenticationTokenSecretManager's start & retrievePassword method
Signed-off-by: stack <stack@apache.com>
(cherry picked from commit 2126ec94f0
2021-05-17 12:21:47 +05:30
439fd4aff2
HBASE-25872 Add documentation for LoadBalancer about synchronization ( #3267 )
...
Signed-off-by: Xin Sun <ddupgs@gmail.com>
2021-05-17 10:20:48 +08:00
d5d972f92e
HBASE-25883 The regionFinder and rackManager fields in BaseLoadBalancer should be volatile ( #3262 )
...
Signed-off-by: meiyi <myimeiyi@gmail.com>
2021-05-17 09:54:40 +08:00
1bb16fea5b
HBASE-25884 Return empty records for disabled balancer in-memory queue ( #3263 )
...
Signed-off-by: stack <stack@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Aman Poonia <apoonia@salesforce.com>
2021-05-14 12:57:24 +05:30
72d7641fb5
HBASE-25852 Move all the intialization work of LoadBalancer implementation to initialize method ( #3248 ) ( #3258 )
...
Signed-off-by: Michael Stack <stack@apache.org>
Signed-off-by: Yulin Niu <niuyulin@apache.org>
2021-05-13 14:19:03 +08:00
075545731a
HBASE-25876 Add retry if we fail to read all bytes of the protobuf magic marker ( #3251 )
...
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by Anoop Sam John <anoopsamjohn@apache.org>
2021-05-12 11:20:50 -07:00
61d9b46aab
HBASE-25867 Extra doc around ITBLL ( #3242 )
...
* HBASE-25867 Extra doc around ITBLL
Minor edits to a few log messages.
Explain how the '-c' option works when passed to ChaosMonkeyRunner.
Some added notes on ITBLL.
Fix whacky 'R' and 'Not r' thing in Master (shows when you run ITBLL).
In HRS, report hostname and port when it checks in (was debugging issue
where Master and HRS had different notions of its hostname).
Spare a dirty FNFException on startup if base dir not yet in place.
* Address Review by Sean
Signed-off-by: Sean Busbey <busbey@apache.org>
2021-05-11 19:24:33 +01:00
4e507ccda0
HBASE-25859 Reference class incorrectly parses the protobuf magic marker ( #3236 )
...
Co-authored-by: Catalin Luca <luca@adobe.com>
Signed-off-by: stack <stack@apache.org>
2021-05-10 14:47:18 -05:00
63d49cb7ed
HBASE-25790 NamedQueue 'BalancerRejection' for recent history of balancer skipping ( #3182 ) ( #3245 )
...
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2021-05-09 00:09:23 +05:30
90dc150b1b
HBASE-25860 Add metric for successful wal roll requests. ( #3238 )
...
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2021-05-08 13:02:52 +05:30
d60aa0a865
HBASE-25774 ServerManager.getOnlineServer may miss some region servers when refreshing state in some procedure implementations
...
Revert "HBASE-25032 Wait for region server to become online before adding it to online servers in Master (#2771 )"
This reverts commit 3bb978894d
2021-05-07 17:55:20 -07:00
5e65da64e2
HBASE-25837 TestRollingRestart is flaky ( #3220 )
...
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2021-05-07 20:28:37 +08:00
bec79d877f
HBASE-25850 Fix spotbugs warnings on branch-2 ( #3239 )
...
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2021-05-07 20:21:53 +08:00
2938ba421b
HBASE-25854 Remove redundant AM in-memory state changes in CatalogJanitor ( #3234 )
...
In CatalogJanitor we schedule GCRegionProcedure to clean up both
filesystem and in-memory state after a split, and
GCMultipleMergedRegionsProcedure to do the same for merges. Both of these
procedures clean up in-memory state, but CatalogJanitor also does this
redundantly just after scheduling the procedures. The cleanup should be
done in only one place. Presumably we are using the procedures to do it in
a principled way. Remove the redundancy in CatalogJanitor and fix any
follow on issues, like test failures.
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Michael Stack <stack@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2021-05-06 09:17:29 -07:00
2d4904ceea
HBASE-25851 Make LoadBalancer not extend Configurable interface ( #3233 ) ( #3235 )
...
Signed-off-by: Yulin Niu <niuyulin@apache.org>
2021-05-06 23:39:43 +08:00
b2c58331f3
HBASE-25847 More DEBUG and TRACE level logging in CatalogJanitor and HbckChore ( #3230 )
...
Signed-off-by: Bharath Vissapragada <bharathv@apache.org>
Signed-off-by: Michael Stack <stack@apache.org>
2021-05-05 17:02:12 -07:00
6f2842d1af
HBASE-25843 move master http-related code into o.a.h.h.master.http
...
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2021-05-05 08:36:40 -07:00
afa9836b87
HBASE-25834 Remove balanceTable method from LoadBalancer interface ( #3217 )
...
Signed-off-by: Yulin Niu <niuyulin@apache.org>
2021-05-05 16:03:51 +08:00
3f8d3ba6d9
HBASE-25842 move regionserver http-related code into o.a.h.h.regionserver.http
...
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2021-05-04 15:46:53 -07:00
Andrew Purtell
bsglz
Xiaolin Ha
Duo Zhang
meiyi
Bharath Vissapragada
Michael Stack
Sandeep Pal
Baiqiang Zhao
Victor
Wellington Ramos Chevreuil
Rushabh Shah
GeorryHuang
Anoop Sam John
caoliqing
Sandeep Pal
Nick Dimiduk
Pankaj
Viraj Jasani
Catalin Luca
niuyulin
xiaozhang0319