Commit Graph

13164 Commits

Author SHA1 Message Date
lhofhansl 71aec0fb43
HBASE-24742 Improve performance of SKIP vs SEEK logic. (#2075) 2020-07-16 10:16:03 -07:00
Reid Chan b249092a5f
HBASE-24739 [Build] branch-1's build seems broken because of pylint (#2065)
* Specify the version
* by using apt-get instead of pip install
* Remove comment blocks

Signed-off-by: Bharath Vissapragada <bharathv@apache.org>
Signed-off-by: Lars Hofhansl <larsh@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2020-07-16 10:54:50 +08:00
Mohammad Arshad f5080eb9a6
HBASE-24721: rename_rsgroup overwriting the existing rsgroup
Closes #2066

Co-authored-by: Viraj Jasani <vjasani@apache.org>

Signed-off-by: Reid Chan <reidchan@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2020-07-15 18:42:38 +05:30
WenFeiYi e5b2334124
HBASE-24615 MutableRangeHistogram#updateSnapshotRangeMetrics doesn't calculate the distribution for last bucket
Closes #1962

Signed-off-by: David Manning
Signed-off-by: Rushabh
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2020-07-15 15:59:28 +05:30
Bo Cui 0841f12e4e
HBASE-24693 regioninfo#isLast() should point to EMPTY_END_ROW (readability improvement)
Closes #2051

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2020-07-14 15:48:16 +05:30
Geoffrey Jacoby be151e3fce
HBASE-23744 - FastPathBalancedQueueRpcExecutor should enforce queue length of 0
Closes #1094

Co-authored-by: Viraj Jasani <vjasani@apache.org>

Signed-off-by: Xu Cang <xucang@apache.org>
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2020-07-13 13:07:14 +05:30
David Manning 15c20be6ff
HBASE-24657 fix JsonBean.java from HBASE-23015 HBASE-20571 (branch-1)
Closes #1999

Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Bharath Vissapragada <bharathv@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2020-07-02 19:06:47 +05:30
Bharath Vissapragada 32690e1e89
HBASE-24603: Make Zookeeper sync() call synchronous (#1945) (#1976)
Writing a test for this is tricky. There is enough coverage for
functional tests. Only concern is performance, but there is enough
logging for it to detect timed out/badly performing sync calls.

Additionally, this patch decouples the ZK event processing into it's
own thread rather than doing it in the EventThread's context. That
avoids deadlocks and stalls of the event thread.

Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
(cherry picked from commit 84e246f9b1)
(cherry picked from commit 2379a25f0c)
2020-06-25 18:36:14 -07:00
Abhishek Singh Chouhan 54c38c840c HBASE-24618 Backport HBASE-21204 to branch-1 2020-06-24 10:21:41 -07:00
Viraj Jasani d1449231f0
HBASE-24380 : Provide WAL splitting journal logging (#1860) (#1939)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2020-06-22 23:43:12 +05:30
Nick Dimiduk 0224dccdb8 HBASE-24360 RollingBatchRestartRsAction loses track of dead servers
`RollingBatchRestartRsAction` doesn't handle failure cases when
tracking its list of dead servers. The original author believed that a
failure to restart would result in a retry. However, by removing the
dead server from the failed list, that state is lost, and retry never
occurs. Because this action doesn't ever look back to the current
state of the cluster, relying only on its local state for the current
action invocation, it never realizes the abandoned server is still
dead. Instead, be more careful to only remove the dead server from the
list when the `startRs` invocation claims to have been successful.

Signed-off-by: stack <stack@apache.org>
(cherry picked from commit 0dae377f53)
2020-06-22 10:29:09 -07:00
BukrosSzabolcs 186373bea4 HBASE-22982: region server suspend/resume (#592)
* Add chaos monkey action for suspend/resume region servers
* Add these to relevant chaos monkeys

branch-1-backport-note: Graceful regionserver restart action wasn't
backported due to a dependency of "RegionMover" script. Can be done
later if needed.

Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
2020-06-22 10:29:09 -07:00
WenFeiYi 655658ce36
HBASE-24550 Passing '-h' or '--help' to bin/hbase doesn't do as expected
Closes #1930

Signed-off-by: Viraj Jasani <vjasani@apache.org>
2020-06-19 23:09:17 +05:30
Josh Elser 404c2dd3fe HBASE-19365 Guard against a missing table descriptor which crashes master
While we never expect table descriptors to be missing, a corrupt meta
can result in the master crashing before regions get assigned. We can
guard against that happening with a simple null-check.

Signed-off-by: Viraj Jasani <vjasani@apache.org>

Closes #1908
2020-06-17 16:48:02 -04:00
Bharath Vissapragada 4dd59a0635 HBASE-24564: Make RS abort call idempotent.
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 2567d15)
2020-06-16 09:06:36 -07:00
satanson 5d64f062d8 HBASE-22870 reflection fails to access a private nested class
Signed-off-by Reid Chan <reidchan@apache.org>

(cherry picked from commit 7697d48cd7)
2020-06-15 18:22:32 -07:00
Anoop Sam John 81ee344439
HBASE-24189 WALSplit recreates region dirs for deleted table with recovered edits data. 2020-06-13 22:21:49 +05:30
sguggilam a21e9049a5
HBASE-24446 Use EnvironmentEdgeManager to compute clock skew in Master (#1886)
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2020-06-12 16:54:18 +05:30
Andrew Purtell f74d181914
HBASE-24525 [branch-1] Support ZooKeeper 3.6.0+ (#1879)
Signed-off-by: Bharath Vissapragada <bharathv@apache.org>
2020-06-10 11:44:22 -07:00
thangTang e07aaf7fef
HBASE-24184 Backport HBASE-23896 to branch-1: Snapshot owner cannot delete snapshot when ACL is enabled and Kerberos is not enabled (#1510)
Signed-off-by: binlijin <binlijin@gmail.com>
2020-06-10 16:12:36 +08:00
bsglz b6598ccaad
HBASE-24483 Add repeated prefix logging for MultipleColumnPrefixFilter (#1822)
Signed-off-by: clarax
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2020-06-08 16:30:05 +05:30
Viraj Jasani 94a04fb88c
Revert "HBASE-24446 Use EnvironmentEdgeManager to compute clock skew in Master (#1835)"
This reverts commit 4853961b2c.
2020-06-07 14:45:14 +05:30
Ravi Kishore Valeti cdab7b33f2
HBASE-24499 Use a client property for SaslConnection MAX_ATTEMPTS (#1857)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2020-06-05 20:37:30 +05:30
sguggilam 4853961b2c
HBASE-24446 Use EnvironmentEdgeManager to compute clock skew in Master (#1835)
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2020-06-05 16:45:31 +05:30
Bharath Vissapragada 4e4d11cb19
HBASE-24260 Add a ClusterManager that issues commands via coprocessor (#1853)
Implements `ClusterManager` that relies on the new
`ShellExecEndpointCoprocessor` for remote shell command execution.

Signed-off-by: Bharath Vissapragada <bharathv@apache.org>

Co-authored-by: Nick Dimiduk <ndimiduk@apache.org>
2020-06-04 22:08:16 -07:00
thangTang d3d527637f
HBASE-24485 Backport to branch-1 HBASE-17738 BucketCache startup is slow (#1823)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
2020-06-05 11:48:23 +08:00
thangTang 4118383fb1
HBASE-24501 Backport to branch-1 HBASE-15785 Unnecessary lock in ByteBufferArray (#1842)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
2020-06-04 09:06:22 +08:00
Bharath Vissapragada 26828ac615
HBASE-21905: [FIFOCompaction] Don't compact already inflight store files (#1829)
This one surfaced as a flake test but turns out to be a legit bug
in FIFOCompaction code. FifoCompaction does not check if an empty
store file is already being compacted by an in-flight compaction
request and still enqueues. It can potentially race with a running
compaction (as in this test case, see jira for the exact exception).

Fixes the edge case and cleans up the test code a bit.

Signed-off-by: Andrew Purtell <apurtell@apache.org>
2020-06-03 16:22:28 -07:00
Viraj Jasani bbfb4d432f
HBASE-24492 : Remove infinite loop from ProtobufLogReader#readNext (#1831)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2020-06-03 22:22:05 +05:30
Bharath Vissapragada d889c7b442
HBASE-24480: Deflake TestRSGroupsBasics#testClearDeadServers (#1821)
More details about the flakiness in the jira comments.

Signed-off-by: Reid Chan <reidchan@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2020-06-01 09:11:27 -07:00
Bharath Vissapragada cd0aaed929
HBASE-24477 (addendum): Fix missing IA annotations in ConfigurationManager
Found this via failure in the nightly tests on branch-1
2020-06-01 09:03:32 -07:00
bsglz 4096925b98
HBASE-24455 Correct the doc of "On the number of column families" (#1799)
Signed-off-by: Wellington Ramos Chevreuil <wchevreuil@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2020-06-01 14:11:57 +05:30
Bharath Vissapragada 6bca1dd1c1
HBASE-24479: Deflake TestCompaction#testStopStartCompaction (#1820)
HBASE-24479: Deflake TestCompaction#testStopStartCompaction

Polling of active compaction count is racy. Tightened the asserts
to be more reliable.

Reid Chan <reidchan@apache.org>
2020-05-31 22:45:31 -07:00
sguggilam 3c138845d9
HBASE-24069 Provide an ExponentialBackOffPolicy sleep between failed … (#1755)
HBASE-24069: Provide an ExponentialBackOffPolicy sleep between failed region close requests

Signed-off-by: Bharath Vissapragada <bharathv@apache.org>
2020-05-31 14:41:18 -07:00
Bharath Vissapragada ee869b9aea
HBASE-24477: Move ConfigurationObserver and related classes to hbase-common
This utility is useful for any module that wants to detect
dynamic config changes. Having it to hbase-common makes it
accessible to all the other modules.

Signed-off-by: Michael Stack <stack@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2020-05-31 14:26:26 -07:00
jacob-leblanc 90b66544f0 HBASE-24454 - Read ioErrorStartTime to local temporary variable to avoid issue when it is set to -1 between greater than zero check and calculation of error duration (#1816)
Signed-off-by Anoop Sam John <anoopsamjohn@apache.org>
2020-05-30 21:10:56 -07:00
xincunSong 61fa21e657
HBASE-24470 : Add store file info when log meessages in HStore. (#1804)
Signed-off-by: binlijin <binlijin@gmail.com>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2020-05-29 19:20:37 +05:30
wenbang 136414dd72
HBASE-24453 [BackPort-HBASE-20220] Check if table exists in the cluster before moving it to the specified regionserver group
Co-authored-by: wenbang <wenbang@didiglobal.com>
Signed-off-by: Reid Chan <reidchan@apache.org>
2020-05-29 11:39:42 +08:00
Viraj Jasani 7df034a824
HBASE-24428 : Update compaction priority (ADDENDUM) 2020-05-28 14:39:49 +05:30
Javier Akira Luca de Tena 6aa2286733
HBASE-24435 Add hedgedReads and hedgedReadWins count metrics (#1781)
Co-authored-by: stack <stack@apache.org>
Co-authored-by: Javier <javier.lucadetena@linecorp.com>
Signed-off-by: Reid Chan <reidchan@apache.org>
2020-05-28 10:11:10 +08:00
Alexander Myasnikov 1870876bd3 HBASE-24434 Fix building cpp-example DemoClient
Changed boost::shared_ptr to std::shared_ptr for compatibility with apache thrift v0.13.

Signed-off-by: Bharath Vissapragada <bharathv@apache.org>
2020-05-27 14:16:44 -07:00
Viraj Jasani 1e386e3d83
HBASE-24428 : Update compaction priority for recently split daughter regions (#1784)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2020-05-27 22:52:56 +05:30
Zheng Wang 9f12ef0772 HBASE-24423 No need to get lock in canSplit because hasReferences will get lock too
Signed-off-by: Bharath Vissapragada <bharathv@apache.org>
2020-05-26 13:38:06 -07:00
niuyulin 3235b568da
HBASE-24386 TableSnapshotScanner support scan limit (#1724)
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
Signed-off by: Viraj Jasani <vjasani@apache.org>
2020-05-19 21:30:59 +05:30
Sandeep Pal fbe5e68251
HBASE-24350: Extending and Fixing HBaseTable level replication metrics (#1704)
branch-1 backport

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Co-Authored-by: Andrew Purtell <apurtell@apache.org>
2020-05-14 15:00:37 -07:00
Nick Dimiduk a53356729f HBASE-24271 Set values in `conf/hbase-site.xml` that enable running on `LocalFileSystem` out of the box
Simplify the new user experience shipping a configuration that enables
a fresh checkout or tarball distribution to run in standalone mode
without direct user configuration. This change restores the behavior
we had when running on Hadoop 2.8 and earlier.

Patch for master includes an update to the book. This change will be
omitted when backporting to earlier branches.

Signed-off-by: stack <stack@apache.org>
Signed-off-by: Josh Elser <elserj@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2020-05-14 14:35:50 -07:00
Nick Dimiduk 67abffa105 Revert "HBASE-24086 Disable output stream capability enforcement when running on LocalFileSystem"
This reverts commit 03d73f151b.
2020-05-14 14:35:50 -07:00
Gkkkk302 59a48fc470
HBASE-24355 Fix typos in the HStore#compact annotation (#1699)
Co-authored-by: guo.kangkang <guo.kangkang@immomo.com>

Signed-off-by: Viraj Jasani <vjasani@apache.org>
2020-05-12 21:06:47 +05:30
Wellington Ramos Chevreuil f57b3d68c7
HBASE-24351 Backport HBASE-24302 to branch-1 (#1693)
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2020-05-12 16:27:05 +01:00
Reid Chan 29c24e7257
HBASE-24345 [ACL] renameRSGroup should require Admin level permission (#1689) 2020-05-11 14:50:21 +08:00