Commit Graph

4564 Commits

Author SHA1 Message Date
Yu Li e03d4fbb0a HBASE-16194 Should count in MSLAB chunk allocation into heap size change when adding duplicate cells 2016-07-11 21:40:30 +08:00
stack 9563ab4ca1 HBASE-16176 Bug fixes/improvements on HBASE-15650 Remove TimeRangeTracker as point of contention when many threads reading a StoreFile Fixes HBASE-16074 ITBLL fails, reports lost big or tiny families broken scanning because of a side effect of a clean up in HBASE-15650 to make TimeRange construction consistent exposed a latent issue in TimeRange#compare. See HBASE-16074 for more detail.
Also change HFile Writer constructor so we pass in the TimeRangeTracker, if one,
on construction rather than set later (the flag and reference were not volatile
so could have made for issues in concurrent case). And make sure the construction
of a TimeRange from a TimeRangeTracer on open of an HFile Reader never makes a
bad minimum value, one that would preclude us reading any values from a file
(set min to 0)

M hbase-common/src/main/java/org/apache/hadoop/hbase/io/TimeRange.java
 Call through to next constructor (if minStamp was 0, we'd skip setting
 allTime=true). Add asserts that timestamps are not < 0 cos it messes
 us up if they are (we already were checking for < 0 on construction but
 assert passed in timestamps are not < 0).

M hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
 Add constructor override that takes a TimeRangeTracker (set when flushing
 but not when compacting)

M hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
 Add override creating an HFile in tmp that takes a TimeRangeTracker

M hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java
 Add override for HFile Writer that takes a TimeRangeTracker Take it on
 construction instead of having it passed by a setter later (flags and
 reference set by the setter were not volatile... could have been prob
 in concurrent case)

M hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/TimeRangeTracker.java
 Log WARN if bad initial TimeRange value (and then 'fix' it)

M hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestTimeRangeTracker.java
 A few tests to prove serialization works as expected and that we'll get a bad min if not constructed properly.

M hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ScanQueryMatcher.java
 Handle OLDEST_TIMESTAMP explictly. Don't expect TimeRange to do it.

M hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestQueryMatcher.java
 Refactor from junit3 to junit4 and add test for this weird case.
2016-07-08 14:23:23 -07:00
Yu Li 09d9dc4b59 HBASE-16201 NPE in RpcServer causing intermittent UT failure of TestMasterReplication#testHFileCyclicReplication 2016-07-09 02:04:54 +08:00
Yu Li 44d2a9bc1c Revert "NPE in RpcServer causing intermittent UT failure of TestMasterReplication#testHFileCyclicReplication"
This reverts commit b6d4fc955f.
2016-07-09 02:04:01 +08:00
Yu Li b6d4fc955f NPE in RpcServer causing intermittent UT failure of TestMasterReplication#testHFileCyclicReplication 2016-07-09 01:06:55 +08:00
stack 37040bfc42 HBASE-15775 Canary launches two AuthUtil Chores 2016-07-08 09:36:17 -07:00
stack 2d6cdfb10a HBASE-16180 Fix ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD findbugs introduced by parent 2016-07-06 09:12:00 -07:00
tedyu 368c32e322 HBASE-16157 The incorrect block cache count and size are caused by removing duplicate block key in the LruBlockCache (ChiaPing Tsai) 2016-07-05 13:54:59 -07:00
Elliott Clark ff8c2fcac0 HBASE-16087 Replication shouldn't start on a master if if only hosts system tables 2016-07-05 13:47:49 -07:00
Andrew Purtell 8efc6148b9 HBASE-16091 Canary takes lot more time when there are delete markers in the table (Vishal Khandelwal)
Conflicts:
	hbase-server/src/main/java/org/apache/hadoop/hbase/tool/Canary.java

Amending-Author: Andrew Purtell <apurtell@apache.org>
2016-07-05 10:34:27 -07:00
Yu Li 84dd9cbcb6 HBASE-16132 Scan does not return all the result when regionserver is busy (binlijin) 2016-07-04 21:46:19 +08:00
zhangduo 4807836304 HBASE-16135 addendum format comments 2016-07-04 20:41:06 +08:00
zhangduo 721c5b7128 HBASE-16135 PeerClusterZnode under rs of removed peer may never be deleted 2016-07-04 19:52:28 +08:00
chenheng f18ac8157b HBASE-15844 We should respect hfile.block.index.cacheonwrite when write intermediate index Block 2016-07-02 09:09:51 +08:00
tedyu a345aa8707 HBASE-16108 RowCounter should support multiple key ranges (Konstantin Ryakhovskiy) 2016-07-01 09:32:43 -07:00
tedyu 5bc0655529 HBASE-16114 Get regionLocation of required regions only for MR jobs (Thiruvel Thirumoolan) 2016-07-01 03:14:51 -07:00
stack f4d7cd5f58 HBASE-16150 Remove ConcurrentIndex (Hiroshi Ikeda) 2016-06-30 15:04:36 -07:00
Jonathan M Hsieh 9aa40424fe HBASE-16140 bump owasp.esapi from 2.1.0 to 2.1.0.1 2016-06-29 08:58:25 -07:00
Jingcheng Du b93c08d358 HBASE-15976 RegionServerMetricsWrapperRunnable will be failure when disable blockcache. - Addendum 2016-06-29 16:37:23 +08:00
tedyu 96a24aede7 HBASE-16122 PerformanceEvaluation should provide user friendly hint when client threads argument is missing (Konstantin Ryakhovskiy) 2016-06-28 20:28:06 -07:00
Jingcheng Du 7a78d871d0 HBASE-15976 RegionServerMetricsWrapperRunnable will be failure when disable blockcache. 2016-06-28 13:52:30 +08:00
tedyu 1a88673f33 HBASE-16052 Improve HBaseFsck Scalability (Ben Lau) 2016-06-27 20:16:34 -07:00
tedyu 34d62ecfae HBASE-14007 Writing to table through MR should fail upfront if table does not exist/is disabled (Thiruvel Thirumoolan) 2016-06-27 14:47:57 -07:00
Ramkrishna 385a6e878f HBASE-16055 TestHFileOutputFormat2 is broken (Ram) 2016-06-27 11:02:03 +05:30
Elliott Clark f4c1fd1a47 HBASE-16089 Add on FastPath for CoDel 2016-06-25 12:59:18 -07:00
stack 8ef87ce434 Revert "Is this ok... removing synchronizations?"
REVERT MISTAKEN COMMIT

This reverts commit 86242e1f55.
2016-06-25 10:45:10 +01:00
Ramkrishna a02c6da4d3 HBASE-16055 PutSortReducer loses any Visibility/acl attribute set on the
Puts (Ram)
2016-06-24 15:26:51 +05:30
Jingcheng Du 83c0cc109e HBASE-15353 Add metric for number of CallQueueTooBigException's 2016-06-24 14:39:53 +08:00
Gary Helmling 198165ef5b HBASE-16085 Add a metric for failed compactions 2016-06-23 16:04:27 -07:00
Elliott Clark 93d82112f0 HBASE-16093 Fix splits failed before creating daughter regions leave meta inconsistent 2016-06-23 12:21:52 -07:00
tedyu 857ec2f448 HBASE-16090 ResultScanner is not closed in SyncTable#finishRemainingHashRanges() 2016-06-23 07:29:34 -07:00
Matteo Bertozzi 339cb81747 HBASE-16068 Procedure v2 - use consts for conf properties in tests 2016-06-22 23:08:13 -07:00
Ramkrishna 7056b66d37 HBASE-16070 Mapreduce Serialization classes do not have Interface audience
(Ram)
2016-06-23 10:55:54 +05:30
tedyu 9e9c243ed0 HBASE-16049 TestRowProcessorEndpoint is failing on Apache Builds (Guanghao Zhang) 2016-06-22 12:24:39 -07:00
tedyu ba631b4d92 HBASE-16012 Major compaction can't work due to obsolete scanner read point in RegionServer (Guanghao Zhang) 2016-06-22 02:09:35 -07:00
tedyu 6ba67ab8d6 HBASE-16062 Improper error handling in WAL Reader/Writer creation (Vladimir Rodionov) 2016-06-21 20:01:05 -07:00
tedyu 8dea578bcf HBASE-16051 TestScannerHeartbeatMessages fails on some machines (Phil Yang) 2016-06-21 09:28:46 -07:00
Yu Li c6b8c9bb02 HBASE-16032 Possible memory leak in StoreScanner 2016-06-21 20:07:52 +08:00
tedyu 78f5262896 HBASE-16059 Region normalizer fails to trigger merge action where one of the regions is empty 2016-06-20 11:24:33 -07:00
Matteo Bertozzi 6605f8f683 HBASE-14644 Region in transition metric is broken -- addendum (Huaxiang Sun) 2016-06-20 10:45:23 -07:00
stack d34e65327e HBASE-16023 Fastpath for the FIFO rpcscheduler AMENDMENT 2016-06-20 08:28:43 +01:00
stack 86242e1f55 Is this ok... removing synchronizations? 2016-06-20 08:23:49 +01:00
Enis Soztutar 1a989a1964 HBASE-16058 TestHRegion fails on 1.4 builds
Conflicts:
	hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
2016-06-17 19:00:01 -07:00
stack 411e3cdb6d HBASE-16023 Fastpath for the FIFO rpcscheduler Adds an executor that does balanced queue and fast path handing off requests directly to waiting handlers if any present. Idea taken from Apace Kudu (incubating). See https://gerrit.cloudera.org/#/c/2938/7/src/kudu/rpc/service_queue.h
M hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcExecutor.java
 Refactor which makes a Handler type. Put all 'handler' stuff inside this
 new type. Also make it so subclass can provide its own Handler type.

M hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/SimpleRpcScheduler.java
 Name the handler threads for their type so can tell if configs are
 having an effect.

Signed-off-by: stack <stack@apache.org>
2016-06-17 17:07:35 -07:00
stack 76cf0d799f HBASE-15224 Undo "hbase.increment.fast.but.narrow.consistency" option; it is not necessary since HBASE-15213 (stack) 2016-06-17 14:39:45 -07:00
chenheng 3723baefe3 HBASE-14915 Hanging test : org.apache.hadoop.hbase.mapreduce.TestImportExport (Heng Chen) 2016-06-17 12:35:36 -07:00
Matteo Bertozzi 1f37cdfb4b HBASE-14730 region server needs to log warnings when there are attributes configured for cells with hfile v2 (huaxiang sun) 2016-06-17 11:26:53 -07:00
Liu Shaohui 419d15f834 HBASE-14277 TestRegionServerHostname.testRegionServerHostname may fail at host with a case sensitive name 2016-06-17 10:49:21 -07:00
tedyu 755a5de470 HBASE-16048 Tag InternalScanner with LimitedPrivate(HBaseInterfaceAudience.COPROC) 2016-06-17 07:30:43 -07:00
tedyu 45a0fc531a HBASE-5291 Addendum 2 passes correct path to deleteRecursively 2016-06-16 17:01:51 -07:00
tedyu 4c1db3cb03 HBASE-16045 endtime argument for VerifyReplication was incorrectly specified in usage 2016-06-16 15:52:16 -07:00
Mikhail Antonov 560bf74884 HBASE-16047 TestFastFail is broken again 2016-06-16 14:10:32 -07:00
Yu Li 66b2788432 HBASE-16033 Add more details in logging of responseTooSlow/TooLarge 2016-06-16 16:40:38 +08:00
tedyu 0b48adaa30 HBASE-5291 Addendum removes duplicate spnego (Josh Elser) 2016-06-15 14:59:58 -07:00
Enis Soztutar ff5dbf584e HBASE-15950 Fix memstore size estimates to be more tighter 2016-06-15 14:19:28 -07:00
Mikhail Antonov b64d5e5f4b HBASE-16026 Master UI should display status of additional ZK switches 2016-06-15 13:06:52 -07:00
tedyu e417cf6b24 HBASE-5291 Add Kerberos HTTP SPNEGO authentication support to HBase web consoles (Josh Elser) 2016-06-15 10:26:18 -07:00
tedyu cc50bfcc72 HBASE-16017 HBase TableOutputFormat has connection leak in getRecordWriter (Zhan Zhang) 2016-06-15 09:18:18 -07:00
stack 8a0e135a35 HBASE-15971 Regression: Random Read/WorkloadC slower in 1.x than 0.98 Restore FIFO as the default in place of 'deadline' that sorted on request priority. The sort costs us throughput. Enable it if you want it rather than have it as default.
Name threads to include the scheduler type.
2016-06-14 16:13:38 -07:00
Stephen Yuan Jiang e35564ede0 HBASE-15746 Remove extra RegionCoprocessor preClose() in RSRpcServices#closeRegion (Stephen Yuan Jiang) 2016-06-14 13:31:24 -07:00
Stephen Yuan Jiang 286934fc40 HBASE-16016 Fix overflow deadline value in AssignmentManager#waitForAssignment (Stephen Yuan Jiang) 2016-06-13 18:22:35 -07:00
tedyu cb331507b9 HBASE-16007 Job's Configuration should be passed to TableMapReduceUtil#addDependencyJars() in WALPlayer 2016-06-11 07:07:39 -07:00
Matteo Bertozzi d1bec9d0b8 HBASE-14644 Region in transition metric is broken (Huaxiang Sun) 2016-06-10 21:53:14 -07:00
Sean Mackrory 37807b38a3 HBASE-15946 Eliminate possible security concerns in RS web UI's store file metrics (Sean Mackrory) 2016-06-09 18:54:53 -07:00
tedyu a4e2b3856e HBASE-15990 The priority value of subsequent coprocessors in the Coprocessor.Priority.SYSTEM list are not incremented by one (ChiaPing Tsai) 2016-06-09 11:20:33 -07:00
Ashish Singhi a40ec70da9 HBASE-15952 Bulk load data replication is not working when RS user does not have permission on hfile-refs node 2016-06-09 18:46:07 +05:30
stack 867150333c HBASE-15994 Allow selection of RpcSchedulers
Adds logging by the RpcExecutors of their run configs
Adds a FifoRpcSchedulerFactory so you can try Fifo scheduler.
2016-06-08 20:25:38 -07:00
stack e90a6db20b Revert "HBASE-15994 Allow selection of RpcSchedulers Adds logging by the RpcExecutors of their run configs Changes the default RpcSchedulerFactory from SimpleRpcSchedulerFactory.class to RpcSchedulerFactoryImpl.class. RpcSchedulerFactoryImpl.class. defaults to using SimpleRpcSchedulerFactory.class and the SimpleRpcScheduler, as has been default up to this, unless you set "hbase.region.server.rpc.scheduler.class" to org.apache.hadoop.hbase.ipc.FifoRpcScheduler"
This reverts commit d49b883825.
2016-06-08 20:25:09 -07:00
stack d49b883825 HBASE-15994 Allow selection of RpcSchedulers Adds logging by the RpcExecutors of their run configs Changes the default RpcSchedulerFactory from SimpleRpcSchedulerFactory.class to RpcSchedulerFactoryImpl.class. RpcSchedulerFactoryImpl.class. defaults to using SimpleRpcSchedulerFactory.class and the SimpleRpcScheduler, as has been default up to this, unless you set "hbase.region.server.rpc.scheduler.class" to org.apache.hadoop.hbase.ipc.FifoRpcScheduler
Signed-off-by: stack <stack@apache.org>
2016-06-08 20:06:22 -07:00
Enis Soztutar 602b2839c6 HBASE-15600 Add provision for adding mutations to memstore or able to write to same region in batchMutate coprocessor hooks (Rajeshbabu and Enis)
Conflicts:
	hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
2016-06-07 20:32:06 -07:00
stack 3ff082cb87 HBASE-15913 Sasl encryption doesn't work with AsyncRpcChannel 2016-06-07 09:22:09 -07:00
Andrew Purtell 76404238a8 HBASE-15698 Increment TimeRange not serialized to server (Ted Yu) 2016-06-06 22:17:37 -07:00
Enis Soztutar 4a0a9a20dd HBASE-15954 REST server should log requests with TRACE instead of DEBUG
Conflicts:
	hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/RESTServer.java
	hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/ScannerResource.java
2016-06-06 11:06:52 -07:00
Sean Mackrory 878b1ea721 HBASE-15889. String case conversions are locale-sensitive, used without locale
Signed-off-by: Sean Busbey <busbey@apache.org>
2016-06-06 12:14:20 -05:00
Apekshit Sharma 6d0e8b2a91 Revert "HBASE-15949 Cleanup TestRegionServerMetrics."
This change passes on master but fails on branch-1. Will try to debug.

This reverts commit 520d27b267.
2016-06-03 23:55:53 -07:00
Apekshit 520d27b267 HBASE-15949 Cleanup TestRegionServerMetrics.
@Before and @After to setup/teardown tables using @Rule to set table name based on testname.
Refactor out copy-pasted code fragments to single function.

Change-Id: Ic22e5027cc3952bab5ec30070ed20e98017db65a
2016-06-03 23:27:23 -07:00
Stephen Yuan Jiang fa182c2ea6 HBASE-15955 Disable action in CatalogJanitor#setEnabled should wait for active cleanup scan to finish (Stephen Yuan Jiang) 2016-06-03 15:50:13 -07:00
Lars Hofhansl 9f343b5871 HBASE-15881 Allow BZIP2 compression. 2016-06-03 15:33:05 -07:00
Matteo Bertozzi 7bcdd44be6 HBASE-15927 Remove HMaster.assignRegion() 2016-06-03 12:41:51 -07:00
Ashish Singhi 950a09b03c HBASE-15888 Extend HBASE-12769 for bulk load data replication 2016-06-03 18:47:31 +05:30
tedyu a8c8bfd5ee HBASE-15727 Canary Tool for Zookeeper (churro morales) 2016-06-02 10:17:42 -07:00
tedyu 72dc6fe5d5 HBASE-15933 Addendum - make merge decision when sizes of both regions are known 2016-06-02 09:29:57 -07:00
tedyu 37bb8a5f69 HBASE-15933 NullPointerException may be thrown from SimpleRegionNormalizer#getRegionSize() 2016-06-02 06:33:04 -07:00
Mikhail Antonov d03ffb0788 HBASE-15908 Checksum verification is broken due to incorrect passing of ByteBuffers in DataChecksum (Mikhail Antonov and Appy) 2016-05-28 03:16:05 -07:00
Enis Soztutar 02a641e2b1 HBASE-15837 Memstore size accounting is wrong if postBatchMutate() throws exception
Conflicts:
	hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
	hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
2016-05-26 11:13:06 -07:00
Apekshit 7af013b267 HBASE-14635 Fix flaky test TestSnapshotCloneIndependence
Signed-off-by: Matteo Bertozzi <matteo.bertozzi@cloudera.com>
2016-05-25 21:24:09 -07:00
tedyu a049b5f799 HBASE-15884 NPE in StoreFileScanner#skipKVsNewerThanReadpoint during reverse scan (Sergey Soldatov) 2016-05-25 17:29:32 -07:00
Joseph Hwang 2346b5e216 HBASE-15471 Added in Priority, General, and Replication queue sizes for RegionServers to the Web UI
Changed UI labels so that queue "size" refers to size in bytes and queue "length" refers to number of items in queue.

Signed-off-by: Elliott Clark <elliott@fb.com>
2016-05-25 15:15:01 -07:00
stack e50bf9d7a9 HBASE-15878 Deprecate doBulkLoad(Path hfofDir, final HTable table) in branch-1 (even though its 'late') 2016-05-23 09:12:53 -07:00
stack 67c02684c9 Revert "HBASE-15876 Remove doBulkLoad(Path hfofDir, final HTable table) though it has not been through a full deprecation cycle"
Wrong commit message
This reverts commit 04ef799dd0.
2016-05-23 09:11:17 -07:00
stack 04ef799dd0 HBASE-15876 Remove doBulkLoad(Path hfofDir, final HTable table) though it has not been through a full deprecation cycle 2016-05-23 09:07:28 -07:00
tedyu 34ca6f5069 HBASE-15873 ACL for snapshot restore / clone is not enforced 2016-05-22 19:13:13 -07:00
tedyu 6738dbadac HBASE-15802 ConnectionUtils should use ThreadLocalRandom instead of Random (Matt Warhaftig) 2016-05-22 06:47:59 -07:00
Jerry He b7de663580 HBASE-14818 user_permission does not list namespace permissions (li xiang) 2016-05-21 20:32:20 -07:00
tedyu 01d77bf37b HBASE-15529 Override needBalance in StochasticLoadBalancer (Guanghao Zhang) 2016-05-21 14:39:41 -07:00
tedyu 108a130f38 HBASE-15529 Revert due to TestRegionRebalancing failing 2016-05-20 12:56:48 -07:00
tedyu b91a6199e9 HBASE-15529 Override needBalance in StochasticLoadBalancer (Guanghao Zhang) 2016-05-20 10:20:44 -07:00
Gary Helmling df40739ae7 HBASE-15856 Don't cache unresolved addresses for connections 2016-05-20 10:02:05 -07:00
Matteo Bertozzi 6dbc8ebec1 HBASE-15865 Move TestTableDeleteFamilyHandler and TestTableDescriptorModification handler tests to procedure 2016-05-20 07:15:48 -07:00
Matteo Bertozzi 233264bc17 HBASE-15864 Reuse the testing helper to wait regions in transition 2016-05-20 06:49:14 -07:00
Jerry He d038b762a5 HBASE-15465 userPermission returned by getUserPermission() for the selected namespace does not have namespace set (li xiang) 2016-05-19 20:38:24 -07:00
tedyu 696a51d344 HBASE-15847 VerifyReplication prefix filtering (Geoffrey Jacoby) 2016-05-19 10:43:49 -07:00
Vincent 5eed14272b HBASE-15617 Canary in regionserver mode might not enumerate all regionservers
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2016-05-18 18:42:17 -07:00
Matteo Bertozzi e5eea96ca6 HBASE-15843 Replace RegionState.getRegionInTransition() Map with a Set 2016-05-18 12:51:17 -07:00
Jerry He a9972355c4 HBASE-15841 Performance Evaluation tool total rows may not be set correctly 2016-05-18 12:15:18 -07:00
Enis Soztutar 49359a4ee3 HBASE-15824 LocalHBaseCluster gets bind exception in master info port - ADDENDUM 2016-05-18 11:36:16 -07:00
Stephen Yuan Jiang 0078522549 HBASE-15850 Localize the configuration change in testCheckTableLocks to reduce flakiness of TestHBaseFsck test suite (Stephen Yuan Jiang) 2016-05-18 07:13:39 -07:00
tedyu ce43e33876 HBASE-15769 Perform validation on cluster key for add_peer (Matt Warhaftig) 2016-05-17 13:26:45 -07:00
stack c0fcce2bde HBASE-15593 Time limit of scanning should be offered by client (Phil Yang) 2016-05-17 12:51:03 -07:00
Elliott Clark 89146d85ac HBASE-15840 WAL.proto compilation broken for cpp 2016-05-17 12:04:31 -07:00
tedyu cadebe691f HBASE-15842 SnapshotInfo should display ownership information 2016-05-16 20:34:41 -07:00
Enis Soztutar c96227eed1 HBASE-15824 LocalHBaseCluster gets bind exception in master info port 2016-05-16 10:35:45 -07:00
Sean Busbey e365191896 HBASE-15780 Make AuthUtil public and rely on it for talking to secure HBase.
Signed-off-by: Gary Helmling <garyh@apache.org>
Signed-off-by: Mikhail Antonov <antonov@apache.org>
Signed-off-by: stack <stack@apache.org>
2016-05-16 00:53:45 -05:00
Mikhail Antonov 0042d6d4c8 HBASE-15615 Wrong sleep time when RegionServerCallable need retry (Guanghao Zhang) 2016-05-15 20:49:00 -07:00
Apekshit 92f415976e HBASE-13532 Make UnknownScannerException less scary by giving more information in the exception string. (Apekshit)
Signed-off-by: Matteo Bertozzi <matteo.bertozzi@cloudera.com>
2016-05-13 15:03:36 -07:00
Apekshit a6f8214e9b HBASE-15236 Inconsistent cell reads over multiple bulk-loaded HFiles. In KeyValueHeap, if two cells are same i.e. have same key and timestamp, then instead of directly using seq id to determine newer one, we should use StoreFile.Comparater.SEQ_ID because that's what is used to determine order of hfiles. In this patch, we assign each scanner an order based on it's index in storefiles list, which is then used in KeyValueHeap to disambiguate between same cells. Changes the getSequenceId() in KeyValueScanner class to getScannerOrder(). Testing: Adds unit test to TestKeyValueHeap. Manual testing: Three cases (Tables t, t2, t3 in the jira description), single region, 2 hfiles with same seq id, timestamps and duplicate KVs. Made sure that returned kv was same for get and scan. (Apekshit)
Change-Id: I22600c91c0a51fb63eb17db73472839d2f13957c

Signed-off-by: stack <stack@apache.org>
2016-05-12 21:31:13 -07:00
Jerry He cadc4cf15b HBASE-15808 Reduce potential bulk load intermediate space usage and waste 2016-05-12 15:22:56 -07:00
Matteo Bertozzi 98d13c745c HBASE-15415 Improve Master WebUI snapshot information (huaxiang sun) 2016-05-09 20:22:07 -07:00
Apekshit 2f282aca15 HBASE-11625 - Verifies data before building HFileBlock. - Adds HFileBlock.Header class which contains information about location of fields. Testing: Adds CorruptedFSReaderImpl to TestChecksum.
Change-Id: I6777f2ddf8922691c84ca86d0cffa9a37dc879ae

Signed-off-by: stack <stack@apache.org>
2016-05-09 16:29:47 -07:00
Enis Soztutar d07d316113 HBASE-15740 Replication source.shippedKBs metric is undercounting because it is in KB 2016-05-09 10:25:57 -07:00
Gary Helmling e44c360350 HBASE-15773 Improvements to CellCounter job 2016-05-06 11:18:24 -07:00
Ashish Singhi 0964884b92 HBASE-15669 HFile size is not considered correctly in a replication request 2016-05-06 17:28:06 +05:30
tedyu 3a7552a9f3 HBASE-15563 'counter' may overflow in BoundedGroupingStrategy (Matt Warhaftig) 2016-05-05 10:29:10 -07:00
Matteo Bertozzi 686a31fbde HBASE-15755 SnapshotDescriptionUtils and SnapshotTestingUtils do not have any Interface audience marked 2016-05-05 07:28:52 -07:00
Gary Helmling b36222831d HBASE-15741 Provide backward compatibility for HBase coprocessor service names 2016-05-04 12:37:39 -07:00
Enis Soztutar 12da71b824 HBASE-15613 TestNamespaceCommand times out 2016-05-04 11:37:09 -07:00
tedyu a7b31f74db HBASE-15752 ClassNotFoundException is encountered when custom WAL codec is not found in WALPlayer job 2016-05-03 07:01:08 -07:00
chenheng 0ee3ca2a78 HBASE-15714 We are calling checkRow() twice in doMiniBatchMutation() 2016-05-03 22:34:09 +10:00
Yu Li 330b3b281a HBASE-15675 Add more details about region on table.jsp 2016-05-03 20:29:49 +08:00
Mikhail Antonov 7e0e86072a HBASE-15703 Deadline scheduler needs to return to the client info about skipped calls, not just drop them 2016-05-02 15:27:13 -07:00
Mikhail Antonov 36d634d353 HBASE-15281 Allow the FileSystem inside HFileSystem to be wrapped (Rajesh Nishtala) 2016-05-02 13:26:37 -07:00
tedyu 57ca428c54 HBASE-15357 TableInputFormatBase getSplitKey does not handle signed bytes correctly (Nathan Schile) 2016-04-29 20:55:47 -07:00
Mikhail Antonov e6bcf95da5 HBASE-15551 Make call queue too big exception use servername 2016-04-29 10:26:18 -07:00
tedyu c512750914 HBASE-15686 Add override mechanism for the exempt classes when dynamically loading table coprocessor 2016-04-28 09:21:22 -07:00
Vasudevan 2b0913eea4 HBASE-15697 Excessive TestHRegion running time on branch-1 (Ram) 2016-04-28 14:18:33 +05:30
tedyu 4f2d8dc328 HBASE-15676 FuzzyRowFilter fails and matches all the rows in the table if the mask consists of all 0s (Matt Warhaftig) 2016-04-27 21:03:34 -07:00
chenheng 5f5cdaae9a HBASE-15720 Print row locks at the debug dump page 2016-04-28 11:46:06 +08:00
tedyu 4ba57cb935 HBASE-15707 ImportTSV bulk output does not support tags with hfile.format.version=3 (huaxiang sun) 2016-04-27 13:40:54 -07:00
stack 6b78409eb2 HBASE-15477 Purge 'next block header' from cached blocks
When we read from HDFS, we overread to pick up the next blocks header.
Doing this saves a seek as we move through the hfile; we save having to
do an explicit seek just to read the block header every time we need to
read the body.  We used to read in the next header as part of the
current blocks buffer. This buffer was then what got persisted to
blockcache; so we were over-persisting: our block plus the next blocks'
header (33 bytes).

This patch undoes this over-persisting.

Removes support for version 1 blocks (0.2 was added in hbase-0.92.0).
Not needed any more.

There is an open question on whether checksums should be persisted
when caching. The code seems to say no but if cache is SSD backed or
backed by anything that does not do error correction, we'll want
checksums.

Adds loads of documentation.

M hbase-common/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockType.java
  (write) Add writing from a ByteBuff.

M hbase-common/src/main/java/org/apache/hadoop/hbase/nio/ByteBuff.java
  (toString) Add one so ByteBuff looks like ByteBuffer when you click on
  it in IDE

M hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java
  Remove support for version 1 blocks.

  Cleaned up handling of metadata added when we serialize a block to
  caches. Metadata is smaller now.

  When we serialize (used when caching), do not persist the next blocks
  header if present.

  Removed a bunch of methods, a few of which had overlapping
  functionality and others that exposed too much of our internals.
  Also removed a bunch of constructors and unified the constructors we
  had left over making them share a common init method.
  Shutdown access to defines that should only be used internally here.

  Renamed all to do w/ 'EXTRA' and 'extraSerialization' to instead talk
  about metadata saved to caches; was unclear previously what EXTRA was
  about.

  Renamed static final declarations as all uppercase.

  (readBlockDataInternal): Redid. Couldn't make sense of it previously.
  Undid heavy-duty parse of header by constructing HFileBlock. Other
  cleanups. Its 1/3rd the length it used to be. More to do in here.

Signed-off-by: stack <stack@apache.org>
2016-04-27 10:41:47 -07:00
Gary Helmling 4272178b1f HBASE-15658 Avoid excess meta cache clearing for RegionServerCallable 2016-04-26 23:02:24 -07:00
Phil Yang d5acbdd1e4 HBASE-15645 hbase.rpc.timeout is not used in operations of HTable
Signed-off-by: stack <stack@apache.org>
2016-04-26 10:52:12 -07:00
tedyu 2562043e23 HBASE-15634 TestDateTieredCompactionPolicy#negativeForMajor is flaky (Duo Zhang and Ted Yu) 2016-04-26 09:24:38 -07:00
tedyu 5a69bc2dcb HBASE-14252 RegionServers fail to start when setting hbase.ipc.server.callqueue.scan.ratio to 0 (Yubao Liu and Ted Yu) 2016-04-25 14:32:53 -07:00
Enis Soztutar 51be6569e6 HBASE-15670 Add missing Snapshot.proto to the maven profile for compiling protobuf
Conflicts:
	hbase-protocol/pom.xml
	hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestBatchCoprocessorEndpoint.java
2016-04-22 11:44:14 -07:00
stack 27446a5c4a HBASE-15392 Single Cell Get reads two HFileBlocks
M hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ScanQueryMatcher.java
moreRowsMayExistAfterCell Exploit the fact a Scan is a Get Scan. Also save compares
if no non-default stopRow.

M hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
optimize Add doc on what is being optimized. Also, if a Get Scan, do not
optimize else we'll keep going after our row is DONE.
Another place to make use of the Get Scan fact is when we are DONE.. if
Get Scan, we can close out the scan.

Signed-off-by: stack <stack@apache.org>
2016-04-22 09:07:09 -07:00
Enis Soztutar 550d253ead HBASE-15671 Add per-table metrics on memstore, storefile and regionsize (Alicia Ying Shu) 2016-04-21 13:33:31 -07:00
stack 0b65f2002b HBASE-15366 Add doc, trace-level logging, and test around No change in operation, just adding doc., and some helpful logging
M hbase-common/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileContext.java
 Make it emit its toString in format that matches the way we log
 elsewhere
M hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
 Capitalize statics.
M hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java
 Verify and cleanup documentation of hfileblock format at head of class.
 Explain what 'EXTRA_SERIALIZATION_SPACE' is all about.
 Connect how we serialize and deserialize... done in different places
 and one way when pulling from HDFS and another when pulling from cache
 (TO BE FIXED). Shut down a load of public access.
M hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java
 Add trace-level logging

Signed-off-by: stack <stack@apache.org>
2016-04-21 10:56:07 -07:00
chenheng 5d497d5ba8 HBASE-15674 HRegionLocator#getAllRegionLocations should put the results in cache
Conflicts:
	hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
	hbase-client/src/main/java/org/apache/hadoop/hbase/client/HRegionLocator.java
2016-04-21 14:28:07 +08:00
zhangduo 80e324cdc7 HBASE-15368 Add pluggable window support 2016-04-21 12:02:42 +08:00
Andrew Purtell 780cff5886 HBASE-15614 Report metrics from JvmPauseMonitor 2016-04-20 17:36:59 -07:00