Commit Graph

7040 Commits

Author SHA1 Message Date
Chia-Ping Tsai 95596e8ba7 HBASE-20119 Introduce a pojo class to carry coprocessor information in order to make TableDescriptorBuilder accept multiple cp at once
Signed-off-by: Ted Yu <yuzhihong@gmail.com>
Signed-off-by: Michael Stack <stack@apache.org>
2018-03-16 01:26:08 +08:00
Ashish Singhi 24ea9d1e48 HBASE-20146 Addendum Regions are stuck while opening when WAL is disabled
Signed-off-by: zhangduo <zhangduo@apache.org>
Signed-off-by: Chia-Ping Tsai <chia7712@gmail.com>
2018-03-15 10:13:55 +08:00
Michael Stack 63ce0c0733 HBASE-20178 [AMv2] Throw exception if hostile environment
Add Fail-Fast to Procedures by throwing exception out of Procedure
constructor so if move but table is disabled or if master is going
down, etc., we can give notice before the procedure is scheduled.
Will help guard against scheduling Procedures that will have a hard
time succeeding; e.g. a move when table is offline.

Also fixed bug around table state where we presumed ENABLED though no
entry in hbase:meta (we were using this mechanism for whether a table
existed or not).

M hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionMove.java
 Test stolen from HBASE-20131

M hbase-client/src/main/java/org/apache/hadoop/hbase/client/TableState.java
 Add convenience isEnabled/isDisabled

M hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
 Promote assert state to throw exception.

M hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterServices.java
 Add isClusterUp

M hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
 Move constructor now throws exception
M hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/MoveRegionProcedure.java
M hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/MergeTableRegionsProcedure.java
M hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/SplitTableRegionProcedure.java
M hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/DisableTableProcedure.java
M hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ModifyTableProcedure.java
M hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/RestoreSnapshotProcedure.java
M hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/TruncateTableProcedure.java
 Do environment check at construction and fail-fast if hostile.

M hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/AbstractStateMachineTableProcedure.java
 Add preflightCheck utility method.

M hbase-client/src/main/java/org/apache/hadoop/hbase/MetaTableAccessor.java
 Removed setting time setting table state; broke when using other than
 default environment edge masked by presumption that no state meant
 active.
2018-03-14 14:43:34 -07:00
Mike Drob 5e2f8e4023 HBASE-20180 Avoid Class::newInstance 2018-03-14 12:23:38 -05:00
Apekshit Sharma ad425e8603 HBASE-20185 Fix ACL check for MasterRpcServices#execProcedure 2018-03-14 19:08:17 +05:30
Chance Li 47b227b55b HBASE-19389 Limit concurrency of put with dense (hundreds) columns to prevent write handler exhausted
Signed-off-by: Yu Li <liyu@apache.org>
2018-03-14 18:36:58 +08:00
Yu Li c8ecfc5461 Revert "HBASE-19389 Limit concurrency of put with dense (hundreds) columns to prevent write handler exhausted"
This reverts commit c6d89b494c.
2018-03-14 18:35:22 +08:00
Yu Li c6d89b494c HBASE-19389 Limit concurrency of put with dense (hundreds) columns to prevent write handler exhausted
Signed-off-by: Yu Li <liyu@apache.org>
2018-03-14 18:33:39 +08:00
Mike Grimes a9d9fa35a2 HBASE-17165 Make use of retry setting in LoadIncrementalHFiles & fix test 2018-03-13 14:59:56 -07:00
Sahil Aggarwal 3757915dac HBASE-19075: Fix the 'tasks' table on master info page to not scroll up on clicking the tab 2018-03-13 14:24:56 -07:00
Michael Stack 260ee0da60 HBASE-20173 [AMv2] DisableTableProcedure concurrent to ServerCrashProcedure can deadlock
Allow that DisableTableProcedue can grab a region lock before
ServerCrashProcedure can. Cater to this cricumstance where SCP
was not unable to make progress by running the search for RIT
against the crashed server a second time, post creation of all
crashed-server assignemnts. The second run will uncover such as
the above DisableTableProcedure unassign and will interrupt its
suspend allowing both procedures to make progress.

M hbase-protocol-shaded/src/main/protobuf/MasterProcedure.proto
 Add new procedure step post-assigns that reruns the RIT finder method.

M hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
 Make this important log more specific as to what is going on.

M hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/UnassignProcedure.java
 Better explanation as to what is going on.

M hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java
 Add extra step and run handleRIT a second time after we've queued up
 all SCP assigns. Also fix a but. SCP was adding an assign of a RIT
 that was actually trying to unassign (made the deadlock more likely).
2018-03-13 05:44:43 -07:00
BELUGA BEHR 4033405b36 HBASE-19449 Minor logging change in HFileArchiver
Signed-off-by: Apekshit Sharma <appy@apache.org>
2018-03-12 22:12:27 +05:30
Umesh Agashe 842678c991 HBASE-20120 Removed unused classes/ java files from hbase-server
deleted:    hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/NoOpHeapMemoryTuner.java
deleted:    hbase-server/src/main/java/org/apache/hadoop/hbase/replication/BaseWALEntryFilter.java
deleted:    hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSMapRUtils.java
deleted:    hbase-server/src/main/java/org/apache/hadoop/hbase/util/ProtoUtil.java
Signed-off-by: Sean Busbey <busbey@apache.org>
Signed-off-by: tedyu <yuzhihong@gmail.com>
Signed-off-by: Chia-Ping Tsai <chia7712@gmail.com>
2018-03-10 12:59:48 +08:00
Guangxu Cheng 1728b48c82 HBASE-20132 Change the "KV" to "Cell" for web UI
Signed-off-by: Chia-Ping Tsai <chia7712@gmail.com>
2018-03-10 12:36:29 +08:00
Umesh Agashe 55e3dda25d HBASE-20024 Fixed flakyness of TestMergeTableRegionsProcedure
We assumed that we can run for loop from 0 to lastStep sequentially. MergeTableRegionProcedure skips step 2. So, when i is 0 the procedure is already at step 3.
Added a method StateMachineProcedure#getCurrentStateId that can be used from test code only.
2018-03-09 12:44:49 -08:00
Ashish Singhi cdf7be8929 HBASE-20146 Regions are stuck while opening when WAL is disabled
Signed-off-by: zhangduo <zhangduo@apache.org>
2018-03-09 21:14:42 +08:00
zhangduo d4e0fc74d4 HBASE-20082 Fix findbugs errors only on master which are introduced by HBASE-19397 2018-03-09 20:55:48 +08:00
Guanghao Zhang 55d0d3026a HBASE-19923 Reset peer state and config when refresh replication source failed 2018-03-09 20:55:48 +08:00
zhangduo d1e775e35e HBASE-19936 Introduce a new base class for replication peer procedure 2018-03-09 20:55:48 +08:00
zhangduo abaa80f26e HBASE-19873 addendum add missing rule for new tests 2018-03-09 20:55:48 +08:00
Guanghao Zhang db4cb01a9e HBASE-19783 Change replication peer cluster key/endpoint from a not-null value to null is not allowed
Signed-off-by: zhangduo <zhangduo@apache.org>
2018-03-09 20:55:48 +08:00
huzheng a7dce36766 HBASE-19748 TestRegionReplicaFailover and TestRegionReplicaReplicationEndpoint UT hangs 2018-03-09 20:55:48 +08:00
zhangduo 1c32241a00 HBASE-19719 Fix checkstyle issues 2018-03-09 20:55:48 +08:00
Guanghao Zhang 1e69d7fa24 HBASE-19711 TestReplicationAdmin.testConcurrentPeerOperations hangs
Signed-off-by: zhangduo <zhangduo@apache.org>
2018-03-09 20:55:48 +08:00
zhangduo 0165455d34 HBASE-19707 Race in start and terminate of a replication source after we async start replicatione endpoint 2018-03-09 20:55:48 +08:00
Guanghao Zhang d36aacdf9e HBASE-19636 All rs should already start work with the new peer change when replication peer procedure is finished
Signed-off-by: zhangduo <zhangduo@apache.org>
2018-03-09 20:55:48 +08:00
zhangduo 53b18fe0ac HBASE-19634 Add permission check for executeProcedures in AccessController 2018-03-09 20:55:48 +08:00
zhangduo 029406c45b HBASE-19697 Remove TestReplicationAdminUsingProcedure 2018-03-09 20:55:48 +08:00
huzheng 5655b3c0ca HBASE-19661 Replace ReplicationStateZKBase with ZKReplicationStorageBase 2018-03-09 20:55:48 +08:00
zhangduo b84fbde175 HBASE-19687 Move the logic in ReplicationZKNodeCleaner to ReplicationChecker and remove ReplicationZKNodeCleanerChore 2018-03-09 20:55:48 +08:00
Guanghao Zhang 13318dd350 HBASE-19544 Add UTs for testing concurrent modifications on replication peer
Signed-off-by: zhangduo <zhangduo@apache.org>
2018-03-09 20:55:48 +08:00
zhangduo b0de0ec439 HBASE-19686 Use KeyLocker instead of ReentrantLock in PeerProcedureHandlerImpl 2018-03-09 20:55:48 +08:00
zhangduo 5d922a5e0c HBASE-19623 Create replication endpoint asynchronously when adding a replication source 2018-03-09 20:55:48 +08:00
zhangduo 525fef572e HBASE-19633 Clean up the replication queues in the postPeerModification stage when removing a peer 2018-03-09 20:55:48 +08:00
huzheng 1e36a84afc HBASE-19622 Reimplement ReplicationPeers with the new replication storage interface 2018-03-09 20:55:48 +08:00
zhangduo 4c6942df58 HBASE-19635 Introduce a thread at RS side to call reportProcedureDone 2018-03-09 20:55:48 +08:00
zhangduo d9b5eb3abb HBASE-19617 Remove ReplicationQueues, use ReplicationQueueStorage directly 2018-03-09 20:55:48 +08:00
zhangduo b40c426806 HBASE-19642 Fix locking for peer modification procedure 2018-03-09 20:55:48 +08:00
zhangduo ac07e07988 HBASE-19592 Add UTs to test retry on update zk failure 2018-03-09 20:55:48 +08:00
Guanghao Zhang 712b5a80dc HBASE-19630 Add peer cluster key check when add new replication peer
Signed-off-by: zhangduo <zhangduo@apache.org>
2018-03-09 20:55:48 +08:00
Guanghao Zhang eae251d203 HBASE-19573 Rewrite ReplicationPeer with the new replication storage interface 2018-03-09 20:55:48 +08:00
zhangduo 15055a421b HBASE-19599 Remove ReplicationQueuesClient, use ReplicationQueueStorage directly 2018-03-09 20:55:48 +08:00
zhangduo 1de08ded58 HBASE-19543 Abstract a replication storage interface to extract the zk specific code 2018-03-09 20:55:48 +08:00
huzheng 3fd417600e HBASE-19525 RS side changes for moving peer modification from zk watcher to procedure 2018-03-09 20:55:48 +08:00
zhangduo da07870995 HBASE-19580 Use slf4j instead of commons-logging in new, just-added Peer Procedure classes 2018-03-09 20:55:48 +08:00
Guanghao Zhang 9ead5934c0 HBASE-19520 Add UTs for the new lock type PEER
Signed-off-by: zhangduo <zhangduo@apache.org>
2018-03-09 20:55:48 +08:00
zhangduo 7c2a0d7e21 HBASE-19564 Procedure id is missing in the response of peer related operations 2018-03-09 20:55:48 +08:00
zhangduo 5e410d8140 HBASE-19524 Master side changes for moving peer modification from zk watcher to procedure 2018-03-09 20:55:48 +08:00
zhangduo 95af14fea6 HBASE-19216 Implement a general framework to execute remote procedure on RS 2018-03-09 20:55:48 +08:00
zhangduo 3576eb6bd8 HBASE-19598 Fix TestAssignmentManagerMetrics flaky test 2018-03-09 20:31:45 +08:00
zhangduo b4e297f3f6 HBASE-20160 TestRestartCluster.testRetainAssignmentOnRestart uses the wrong condition to decide whether the assignment is finished 2018-03-09 11:08:57 +08:00
haxiaolin 78c02c5081 HBASE-20114 Fix IllegalFormatConversionException in rsgroup.jsp
Repplication. Was reverted earlier.
2018-03-08 09:29:01 -08:00
Sean Busbey 71cc7869db HBASE-20155 update branch-2 version to 2.1.0-SNAPSHOT
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
2018-03-08 08:44:30 -08:00
zhangduo 25efd37f32 HBASE-20144 The shutdown of master will hang if there are no live region server 2018-03-08 15:54:40 +08:00
Michael Stack 96a42b7359 Revert "HBASE-20137 TestRSGroups is flakey"
Revert. Fix is not right.

This reverts commit 6d1740d498.
2018-03-07 09:25:02 -08:00
Michael Stack 6d1740d498 HBASE-20137 TestRSGroups is flakey
On failed RPC we expire the server and suspend expecting the
resultant ServerCrashProcedure to wake us back up again. In tests,
TestRSGroup hung because it failed to schedule a server expiration
because the server was already expired undergoing processing (the
test was shutting down). Deal with this case by having expire
servers return false if unable to expire. Callers will then know
where a ServerCrashProcedure has been scheduled or not.

M hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
  Have expireServer return true if successful.

M hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionTransitionProcedure.java
 The log that included an exception whose message was the current
procedure as a String totally baffled me. Make it more obvious what
exception is.

M hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/UnassignProcedure.java
 If failed expire of a server, wake our procedure -- do not suspend --
and presume ok to move region to CLOSED state (because going down or
concurrent crashed server processing ongoing).
2018-03-05 22:53:27 -08:00
tedyu 9e9b347d66 HBASE-20114 Fix IllegalFormatConversionException in rsgroup.jsp - revert premature commit 2018-03-02 12:07:16 -08:00
haxiaolin 4ec2eeef63 HBASE-20114 Fix IllegalFormatConversionException in rsgroup.jsp
Signed-off-by: tedyu <yuzhihong@gmail.com>
2018-03-02 09:01:05 -08:00
Sean Busbey 9927c2e14a HBASE-20070 refactor website generation
* rely on git plumbing commands when checking if we've built the site for a particular commit already
* switch to forcing '-e' for bash
* add command line switches for: path to hbase, working directory, and publishing
* only export JAVA/MAVEN HOME if they aren't already set.
* add some docs about assumptions
* Update javadoc plugin to consistently be version 3.0.0
* avoid duplicative site invocations on reactor modules
* update use of cp command so it works both on linux and mac
* manually skip enforcer plugin during build
* still doing install of all jars due to MJAVADOC-490, but then skip rebuilding during aggregate reports.
* avoid the pager on git-diff by teeing to a log file, which also helps later reviewing in the case of big changesets.

Signed-off-by: Michael Stack <stack@apache.org>
Signed-off-by: Misty Stanley-Jones <misty@apache.org>

 Conflicts:
	hbase-backup/pom.xml
	hbase-spark-it/pom.xml
2018-03-02 09:51:43 -06:00
Chia-Ping Tsai e06e90bdbc HBASE-19437 Batch operation can't handle the null result for Append/Increment
Signed-off-by: anoopsamjohn <anoopsamjohn@gmail.com>
Signed-off-by: Michael Stack <stack@apache.org>
2018-03-02 23:42:41 +08:00
Michael Stack a2de29560f HBASE-20113 Move branch-2 version from 2.0.0-beta-2-SNAPSHOT to 2.0.0-beta-2 2018-03-01 15:46:38 -08:00
Umesh Agashe 4547edbfe0 HBASE-20055 Removed declaration of un-thrown exceptions and unused setRegionStateBackToOpen() from MergeTableRegionsProcedure
Plus some minor cleanup.
2018-03-01 08:45:54 -08:00
Chia-Ping Tsai a2bf2ad71e HBASE-20093 (addendum) remove unused import of ServerLoad
Signed-off-by: tedyu <yuzhihong@gmail.com>
2018-03-01 23:44:29 +08:00
tedyu e0ff595744 HBASE-20107 Add a test case for HBASE-14317 (Zephyr Guo) 2018-02-28 21:18:14 -08:00
Sergey Soldatov 313464f007 HBASE-19863 java.lang.IllegalStateException: isDelete failed when SingleColumnValueFilter is used
Signed-off-by: Chia-Ping Tsai <chia7712@gmail.com>
Signed-off-by: ramkrish86 <ramkrishna.s.vasudevan@gmail.com>
2018-02-28 14:06:17 -05:00
Chia-Ping Tsai f71c00c02e HBASE-20097 Merge TableDescriptors#getAll and TableDescriptors#getAllDescriptors into one
Signed-off-by: tedyu <yuzhihong@gmail.com>
2018-02-28 15:21:31 +08:00
Chia-Ping Tsai e50e6f7ce9 HBASE-20084 Refactor the RSRpcServices#doBatchOp
Signed-off-by: tedyu <yuzhihong@gmail.com>
2018-02-28 15:13:09 +08:00
Chia-Ping Tsai c459282fe0 HBASE-20093 Replace ServerLoad by ServerMetrics for ServerManager
Signed-off-by: tedyu <yuzhihong@gmail.com>
2018-02-28 15:05:52 +08:00
Michael Stack 5317ca92bc HBASE-20069 fix existing findbugs errors in hbase-server; ADDENDUM Address review
Revert of the revert, i.e. reapply. Thought this had broken the build
but it was a bad nightly. Putting it back.

Revert "Revert "HBASE-20069 fix existing findbugs errors in hbase-server; ADDENDUM Address review""

This reverts commit 07eae00ec1.
2018-02-27 21:07:38 -08:00
Michael Stack 2ceafe108f HBASE-20092 Fix TestRegionMetrics#testRegionMetrics
Reapplication of a patch temporarily removed...
I thought this was causing issue but now I don't think it the culprit.

Revert "Revert "HBASE-20092 Fix TestRegionMetrics#testRegionMetrics""

This reverts commit 367d316781.
2018-02-27 15:42:17 -08:00
Michael Stack 7d7ca33e6d HBASE-20100 TestEnableTableProcedure flakey
Allow OPEN as a possible state when update region transition state.
Usually state is OPENING but if crash before finish step is completed,
on replay, master may have read that the state is OPEN from meta table
and so will think it open... When we replay the procedure finish, allow
that the region is already OPEN.
2018-02-27 12:10:51 -08:00
gsheffi 06cf04e458 HBASE-20074 [FindBugs] Same code on both branches in CompactingMemStore#initMemStoreCompactor
Signed-off-by: Michael Stack <stack@apache.org>
2018-02-27 11:23:16 -06:00
Sean Busbey e0f8076693 Revert "for creating patch HBASE-20074-V01.patch"
This reverts commit a312705dbc.

bad commit message
2018-02-27 11:22:59 -06:00
Michael Stack 07eae00ec1 Revert "HBASE-20069 fix existing findbugs errors in hbase-server; ADDENDUM Address review"
This reverts commit 43d661b008.
2018-02-27 08:44:22 -08:00
Michael Stack 367d316781 Revert "HBASE-20092 Fix TestRegionMetrics#testRegionMetrics"
This reverts commit ae288a7b41.
2018-02-27 08:26:47 -08:00
Chia-Ping Tsai ae288a7b41 HBASE-20092 Fix TestRegionMetrics#testRegionMetrics
Signed-off-by: Michael Stack <stack@apache.org>
Signed-off-by: tedyu <yuzhihong@gmail.com>
2018-02-27 16:48:48 +08:00
zhangduo 8e8e50683d HBASE-20066 Region sequence id may go backward after split or merge 2018-02-27 15:37:32 +08:00
Michael Stack 43d661b008 HBASE-20069 fix existing findbugs errors in hbase-server; ADDENDUM Address review 2018-02-26 23:15:43 -08:00
Michael Stack 44544c7db0 HBASE-20069 fix existing findbugs errors in hbase-server 2018-02-26 10:55:53 -08:00
gsheffi a312705dbc for creating patch HBASE-20074-V01.patch
Signed-off-by: Michael Stack <stack@apache.org>
2018-02-26 09:56:44 -08:00
Vasudevan 372c68fca2 HBASE-20036 TestAvoidCellReferencesIntoShippedBlocks timed out (Ram) 2018-02-26 22:06:28 +05:30
zhangduo ef02762dd8 HBASE-20083 Fix findbugs error for ReplicationSyncUp 2018-02-26 22:16:37 +08:00
Michael Stack 8b3ae58e18 HBASE-20043 ITBLL fails against hadoop3
Fix MoveRandomRegionOfTableAction. It depended on old AM behavior.
Make it do explicit move as is required in AMv3; w/o it, it was just
closing region causing test to fail.

Fix pom so hadoop3 profile specifies a different netty3 version.

Bunch of logging format change that came of trying trying to read
the spew from this test.
2018-02-24 17:29:24 -08:00
zhangduo 2d5065bc7e HBASE-20065 Revisit the timestamp usage in MetaTableAccessor 2018-02-25 09:14:09 +08:00
Sean Busbey 62b8da927e HBASE-20061 HStore synchronized member variable filesCompacting should be private
Signed-off-by: Chia-Ping Tsai <chia7712@gmail.com>
2018-02-24 10:58:14 -06:00
Sean Busbey a66fa85a16 Revert "HBASE-19835 Use explicit casting to avoid side effects"
This reverts commit bc080e7500.

 Conflicts:
	hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Segment.java

patch reverted changes that happened in parallel without explanation. see jira.
2018-02-23 23:04:34 -06:00
tedyu d6d1e49a75 HBASE-20054 removes the indefinite retry introduced by HBASE-18282 2018-02-23 19:14:04 -08:00
zhangduo 4ddfdaffdc HBASE-20048 Revert serial replication feature 2018-02-23 13:54:10 +08:00
tedyu 8a22e4119f HBASE-20049 Region replicas of SPLIT and MERGED regions are kept in in-memory states until restarting master (Toshihiro Suzuki) 2018-02-22 20:11:11 -08:00
Apekshit Sharma 991e163cc2 HBASE-19401 Add missing security checks in RSRpcServices 2018-02-22 16:23:47 -08:00
Apekshit Sharma 161f9de8e5 HBASE-19400 Add missing security checks in MasterRpcServices
- Added ADMIN permission check for following rpc calls:
  normalize, setNormalizerRunning, runCatalogScan, enableCatalogJanitor, runCleanerChore,
  setCleanerChoreRunning, execMasterService, execProcedure, execProcedureWithRet
- Moved authorizationEnabled check to start of AccessChecker's functions. Currently, and IDK why,
  we call authManager.authorize() first and then discard its result if authorizationEnabled is false. Weird.
2018-02-22 16:23:43 -08:00
tedyu f3753e394a HBASE-20052 TestRegionOpen#testNonExistentRegionReplica fails due to NPE 2018-02-22 12:35:50 -08:00
Umesh Agashe 6c039383b9 HBASE-19767 Fix for Master web UI shows negative values for Remaining KVs
Negative Remaining KVs and progress percent greater than 100 is because CompactionProgress#totalCompactingKVs is sometimes less than CompactionProgress#currentCompactedKVs.
Changes add a getter to CompactionProgress#totalCompactingKVs and from inside getter warning is logged. currentCompactedKVs are return when totalCompactingKVs are less than current.

Signed-off-by: Michael Stack <stack@apache.org>
2018-02-22 10:09:47 -08:00
Michael Stack 1db1474591 HBASE-20044 TestClientClusterStatus is flakey"
Revert "Revert "HBASE-2004 TestClientClusterStatus is flakey""
This is a revert of a revert, i.e. a reapplication, just so I can fix
the JIRA number.

This reverts commit 6796b8e21f.
2018-02-22 09:42:37 -08:00
Michael Stack 6796b8e21f Revert "HBASE-2004 TestClientClusterStatus is flakey"
Revert to fix JIRA number; should be 20044.

This reverts commit 92bb4db9ef.
2018-02-22 09:41:27 -08:00
Michael Stack 38a97b87e6 HBASE-19391 Calling HRegion#initializeRegionInternals from a region replica can still re-create a region directory; ADDEDNDUM to fix TestRegionOpen failure 2018-02-22 09:14:35 -08:00
Josh Elser 9d3eadd924 HBASE-20035 Stabilize the flaky TestQuotaStatusRPCs
The test will fail if the quota moves to violation before
the second half of the test.

Signed-off-by: Michael Stack <stack@apache.org>
2018-02-22 09:34:05 -05:00
zhangduo 0432d49d83 HBASE-20038 TestLockProcedure.testTimeout is flakey 2018-02-21 17:23:49 -08:00
Esteban Gutierrez c06c4f30d1 HBASE-19391 Calling HRegion#initializeRegionInternals from a region replica can still re-create a region directory 2018-02-21 16:34:53 -08:00
Michael Stack c677c30020 HBASE-20042 TestRegionServerAbort flakey; ADDENDUM, RETRY 2018-02-21 15:26:59 -08:00
Michael Stack 92bb4db9ef HBASE-2004 TestClientClusterStatus is flakey 2018-02-21 14:52:10 -08:00
Michael Stack baec532aa2 HBASE-20042 TestRegionServerAbort flakey 2018-02-21 13:24:39 -08:00
Andrew Purtell 67b7ce38fb HBASE-20027 Add test TestClusterPortAssignment
LocalHBaseCluster forces random port assignment for sake of concurrent unit test
execution friendliness, but we still need a positive test for RPC and info port
assignment.
2018-02-21 13:12:30 -08:00
tedyu 5c988c9960 HBASE-19166 AsyncProtobufLogWriter persists ProtobufLogWriter as class name for backward compatibility 2018-02-21 13:05:54 -08:00
Mike Drob d8ec10e20f HBASE-20039 MR tests out to hbase-mapreduce mobile 2018-02-21 14:53:30 -06:00
Josh Elser e10db9d29a HBASE-19953 Ensure post DDL hooks are only called after successful operations
The 1.x functionality of Master DDL operations is that "post" observer hooks
are only invoked when the DDL action was successful. With the async-ness of
ProcV2, we find ourselves in a case where the post-hook may be invoked before
the Procedure runs and fails. We need to introduce some blocking to wait and
see if the Procedure is going to fail on a precondition before invoking the hook.

Signed-off-by: Michael Stack <stack@apache.org>
2018-02-21 13:53:09 -05:00
zhangduo 30c2dcd883
HBASE-20037 Race when calling SequenceIdAccounting.resetHighest 2018-02-21 10:04:33 -08:00
anastas 2b4df5e36e HBASE-19506: The CellChunkMap index chunks are usually small, so in order to prevent memory underutilization, HBASE-19506 presents small chunks preallocated in a small pool 2018-02-21 10:19:49 +02:00
Chia-Ping Tsai bc1ac49de2 HBASE-20017 BufferedMutatorImpl submit the same mutation repeatedly
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2018-02-20 16:59:48 -08:00
Ted Yu cbd138d41a HBASE-19954 Separate TestBlockReorder into individual tests to avoid ShutdownHook suppression error against hadoop3 2018-02-20 14:56:46 -08:00
Michael Stack 7e2978787d HBASE-20029 @Ignore TestQuotaThrottle and TestReplicasClient#testCancelOfMultiGet 2018-02-20 12:08:35 -08:00
Michael Stack 9be0360c5d HBASE-20024 TestMergeTableRegionsProcedure is STILL flakey 2018-02-20 11:07:36 -08:00
zhangduo 0152d5e2ae HBASE-20021 TestFromClientSideWithCoprocessor is flakey 2018-02-20 06:24:22 -08:00
zhangduo 34d3e847cc HBASE-20020 Make sure we throw DoNotRetryIOException when ConnectionImplementation is closed 2018-02-20 06:10:45 -08:00
zhangduo c1fe9f441c HBASE-19978 The keepalive logic is incomplete in ProcedureExecutor 2018-02-19 17:13:16 -08:00
Reid Chan 4ef6319af0 HBASE-19950 Introduce a ColumnValueFilter
Signed-off-by: Chia-Ping Tsai <chia7712@gmail.com>
2018-02-20 05:05:19 +08:00
eshcar a458d7c400 HBASE-18294 Reduce global heap pressure: flush based on heap occupancy 2018-02-18 12:58:52 +02:00
Michael Stack 0082f55595 HBASE-20015 TestMergeTableRegionsProcedure and TestRegionMergeTransactionOnCluster flakey 2018-02-17 11:37:42 -08:00
Michael Stack 07bdd492f4 Revert "HBASE-20015 TestMergeTableRegionsProcedure and TestRegionMergeTransactionOnCluster flakey"
This reverts commit 72193650dd.
2018-02-16 23:21:56 -08:00
Michael Stack 3ea2ffcd57 HBASE-20013 TestZKPermissionWatcher is flakey 2018-02-16 23:19:07 -08:00
Michael Stack 72193650dd HBASE-20015 TestMergeTableRegionsProcedure and TestRegionMergeTransactionOnCluster flakey 2018-02-16 22:59:32 -08:00
Chia-Ping Tsai 34d5f2b70e HBASE-19680 BufferedMutatorImpl#mutate should wait the result from AP in order to throw the failed mutations 2018-02-17 07:27:23 +08:00
Michael Stack d59959d19e HBASE-20011 Disable TestRestoreSnapshotFromClientWithRegionReplicas; it is flakey. Needs attention. 2018-02-16 14:45:55 -08:00
Mike Drob 138f82c8c5 HBASE-19920 Lazy init for ProtobufUtil classloader 2018-02-16 09:11:45 -06:00
Umesh Agashe 70d3413ee2 HBASE-19988 Fixed chatty log from HRegion#lockRowsAndBuildMiniBatch() when interrupted while waiting on a row lock 2018-02-16 07:01:23 -08:00
Michael Stack 9f27fdaffc HBASE-20006 TestRestoreSnapshotFromClientWithRegionReplicas is flakey
Remove assert in splittableregionprocedure. It was in the prepare.
Was causing fail in legit case where a region split follows a
table split BEFORE the parent has been GC'd. The region split
finds the parent in SPLIT state which is right. The assert was
having us fail. No need.

Also disabled TestHTrace since not supported in 2.0.0 and flakey.
2018-02-15 20:44:39 -08:00
Michael Stack 13bc4fe33c
HBASE-19998 Flakey TestVisibilityLabelsWithDefaultVisLabelService
Only call server.checkIfShouldMoveSystemRegionAsync if a node has been
added. Do not call it if only one regionserver in cluster. Make it
so ServerCrashProcedure runs before it. Add logging if
server.checkIfShouldMoveSystemRegionAsync was responsible for
MOVE (Previous was a mystery when it cut in).

Previous we'd call it when there was a nodeChildrenChanged. These
happen before nodeDeleted. If a server crashed,
checkIfShouldMoveSystemRegionAsync could run first, find the
server that had not yet registered as crashed, find system
tables on it and then try to move them. It would fail because
server would not respond to RPC. The region move would then
be waiting on the servercrashprocedure to wake it up when
done processing but this move had locked the region so
SCP couldn't run....
2018-02-15 19:41:17 -08:00
Thiruvel Thirumoolan 65ac99b675 HBASE-19996 Some nonce procs might not be cleaned up (follow up HBASE-19756)
Signed-off-by: tedyu <yuzhihong@gmail.com>
2018-02-15 04:48:24 -08:00
anastas af804a586b HBASE-19930: Fixing the bug, in the rare case when there is a merge into CCM and the one of the old segments has a big cell allocated on-heap and it needs to be copied to the MSLAB 2018-02-15 14:35:41 +02:00
zhangduo ce5f5e6bcd HBASE-20000 Remove the quantum logic in FairQueue, always put high priority queue in front 2018-02-15 16:40:21 +08:00
Ben Lau 0743bda059 HBASE-18282 ReplicationLogCleaner can delete WALs not yet replicated in case of a KeeperException
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2018-02-14 17:23:09 -08:00
Toshihiro Suzuki 9cbf936f90 HBASE-19980 NullPointerException when restoring a snapshot after splitting a region
Signed-off-by: tedyu <yuzhihong@gmail.com>
2018-02-14 09:38:16 -08:00
Michael Stack 8a3b4cdc67 HBASE-19116 Currently the tail of hfiles with CellComparator* classname makes it so hbase1 can't open hbase2 written hfiles; fix
Serializing, if appropriate, write the hbase-1.x version of the
Comparator to the hfile trailer so hbase-1.x files can read hbase-2.x
hfiles (they are the same format).
2018-02-14 07:46:05 -08:00
Michael Stack 02bba3b788 HBASE-19998 Flakey TestVisibilityLabelsWithDefaultVisLabelService 2018-02-13 22:31:57 -08:00
Michael Stack 1f3c131371 HBASE-19965 Fix flaky TestAsyncRegionAdminApi; ADDENDUM do same to TestAsyncTableAdminAPI AGAIN (make TestAsyncTableAdminAPI3... already an TestAsyncTableAdminAPI2) 2018-02-13 21:05:34 -08:00
Pankaj Kumar 4594f7156d HBASE-19979 ReplicationSyncUp tool may leak Zookeeper connection 2018-02-13 08:43:52 -08:00
Michael Stack 562402ec23 Revert "HBASE-19970 Remove unused functions from TableAuthManager."
This reverts commit b19531f04b.
2018-02-13 06:18:35 -08:00
Chia-Ping Tsai 6923472f75 HBASE-19876 The exception happening in converting pb mutation to hbase.mutation messes up the CellScanner 2018-02-13 21:20:21 +08:00
Vasudevan 3623089cba HBASE-19977 FileMmapEngine allocation of byte buffers should be
synchronized (Ram)
2018-02-13 15:51:21 +05:30
Michael Stack 5b95ea01da HBASE-19965 Fix flaky TestAsyncRegionAdminApi; ADDENDUM do same to TestAsyncTableAdminAPI 2018-02-12 22:53:29 -08:00
Michael Stack 7104364a4d HBASE-19965 Fix flaky TestAsyncRegionAdminApi 2018-02-12 22:24:50 -08:00
Apekshit Sharma b19531f04b HBASE-19970 Remove unused functions from TableAuthManager.
Functions deleted: setTableUserPermissions, setTableGroupPermissions, setNamespaceUserPermissions,
setNamespaceGroupPermissions, writeTableToZooKeeper, writeNamespaceToZooKeeper
2018-02-12 16:02:48 -08:00
Michael Stack e94f082776 HBASE-19986 If HBaseTestClassRule timesout a test, thread dump 2018-02-12 15:13:42 -08:00
Michael Stack 1ae64ccee0 HBASE-19972 Should rethrow the RetriesExhaustedWithDetailsException when failed to apply the batch in ReplicationSink; ADDENDUM to fix TestReplicationSink 2018-02-12 10:48:21 -08:00
Michael Stack c7473df2c3 HBASE-16060 1.x clients cannot access table state talking to 2.0 cluster
This patch adds mirroring of table state out to zookeeper. HBase-1.x
clients look for table state in zookeeper, not in hbase:meta where
hbase-2.x maintains table state.

The patch also moves and refactors the 'migration' code that was put in
place by HBASE-13032.

D hbase-client/src/main/java/org/apache/hadoop/hbase/CoordinatedStateException.java
 Unused.

M hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
 Move table state migration code from Master startup out to
TableStateManager where it belongs. Also start
MirroringTableStateManager dependent on config.

A hbase-server/src/main/java/org/apache/hadoop/hbase/master/MirroringTableStateManager.java

M hbase-server/src/main/java/org/apache/hadoop/hbase/master/TableStateManager.java
 Move migration from zookeeper of table state in here. Also plumb in
mechanism so subclass can get a chance to look at table state as we do
the startup fixup full-table scan of meta.

M hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
 Bug-fix. Now we create regions in CLOSED state but we fail to check
table state; were presuming table always enabled. Meant on startup
there'd be an unassigned region that never got assigned.

A hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMirroringTableStateManager.java
 Test migration and mirroring.
2018-02-12 08:22:14 -08:00
zhangduo 43f507dfa8 HBASE-19554 Dump thread info before failure 2018-02-12 16:06:50 +08:00
huzheng d793db7c7d HBASE-19972 Should rethrow the RetriesExhaustedWithDetailsException when failed to apply the batch in ReplicationSink 2018-02-12 15:15:08 +08:00
zhangduo 3f127063ff HBASE-19966 The WriteEntry for WALKey maybe null if we failed to call WAL.append 2018-02-09 19:11:08 -08:00
Guanghao Zhang 4461cb7d7a HBASE-19942 (addendum) Fix flaky TestSimpleRpcScheduler 2018-02-09 13:38:05 +08:00
Aman Poonia bc080e7500 HBASE-19835 Use explicit casting to avoid side effects
Signed-off-by: tedyu <yuzhihong@gmail.com>
2018-02-08 12:33:08 -08:00
Michael Stack c93ba37dfc HBASE-19956 Remove category as a consideration timing out tests; set all test to timeout at 10minutes regardless 2018-02-07 20:10:36 -08:00
Michael Stack 8f1e01b6e5 HBASE-19951 Cleanup the explicit timeout value for test method 2018-02-07 16:39:54 -08:00
Mike Drob 7d449892af HBASE-19947 ITU should overwrite HTU local FS 2018-02-07 16:56:11 -06:00
zhangduo e71b0bf19d HBASE-19929 Call RS.stop on a session expired RS may hang 2018-02-07 15:53:08 +08:00
Chia-Ping Tsai e2636c81f7 HBASE-19900 Region-level exception destroy the result of batch 2018-02-07 08:38:04 +08:00
Guanghao Zhang f481386e3e HBASE-19942 Fix flaky TestSimpleRpcScheduler 2018-02-07 08:00:01 +08:00
Balazs Meszaros 4d24b19822 HBASE-19886 Display maintenance mode in shell, web UI 2018-02-06 14:53:48 -08:00
Mike Drob f155da3791 HBASE-19946 More test clean up for local-mode HTU 2018-02-06 15:39:17 -06:00
Michael Stack 89baad5bbe HBASE-19940 TestMetaShutdownHandler flakey; ADDENDUM: yet more debug 2018-02-06 09:48:26 -08:00
Michael Stack ca6b37d63c HBASE-19940 TestMetaShutdownHandler flakey; ADDENDUM: more debug 2018-02-06 06:35:02 -08:00
Guanghao Zhang fb480775d5 HBASE-19944 Fix timeout TestVisibilityLabelsWithCustomVisLabService
Signed-off-by: zhangduo <zhangduo@apache.org>
2018-02-06 20:30:16 +08:00
Umesh Agashe e4aeb46177 HBASE-19941 Flaky TestCreateTableProcedure times out in nightly, needs to LargeTests 2018-02-05 22:11:53 -08:00
tedyu b9175680b6 HBASE-19934 HBaseSnapshotException when read replicas is enabled and online snapshot is taken after region splitting (Toshihiro Suzuki) 2018-02-05 21:06:20 -08:00
Umesh Agashe 53e5707224
HBASE-19939 Fixed NPE in tests TestSplitTableRegionProcedure#testSplitWithoutPONR() and testRecoveryAndDoubleExecution()
Value of 'htd' is null as it is initialized in the constructor but when the object is deserialized its null. Got rid of member variable htd and made it local to method.
2018-02-05 20:48:20 -08:00
zhangduo 8b6b3326a6 HBASE-19927 Addendum join on RegionServerThread instead of HRegionServer 2018-02-06 10:01:41 +08:00
Michael Stack 7723a3d60d HBASE-19940 TestMetaShutdownHandler flakey 2018-02-05 12:38:51 -08:00
Michael Stack a1600c1490 HBASE-19840 Flakey TestMetaWithReplicas; ADDENDUM Adding debug 2018-02-05 11:00:46 -08:00
Michael Stack 29016bc100 HBASE-19837 Flakey TestRegionLoad; ADDENDUM Report more often and wait less time on change (also add some debug on TestMetaShutdown test) 2018-02-05 08:39:52 -08:00
Rajeshbabu Chintaguntla f0a5f12d97 HBASE-19703 Functionality added as part of HBASE-12583 is not working after moving the split code to master
Co-authored-by: Michael Stack <stack@apache.org>

Signed-off-by: Chia-Ping Tsai <chia7712@gmail.com>
2018-02-05 23:41:32 +08:00
anastas 514eadbe95 HBASE-19658 make the test testFlatteningToJumboCellChunkMap() stable, by eliminating the possibility of third cell to be added while in-memory-flush is still in progress 2018-02-05 11:29:10 +02:00
zhangduo 30a7e4a35c HBASE-19554 reenable TestDLSAsyncFSWAL/TestDLSFSHLog for debugging 2018-02-05 08:58:30 +08:00
zhangduo 054acca866 HBASE-19927 TestFullLogReconstruction flakey 2018-02-05 08:41:37 +08:00
Michael Stack 32d1903377 HBASE-19931 TestMetaWithReplicas failing 100% of the time in testHBaseFsckWithMetaReplicas 2018-02-04 14:37:13 -08:00
Ashish Singhi 2d5b36d194 HBASE-19905 ReplicationSyncUp tool will not exit if a peer replication is disabled
Signed-off-by: Ashish Singhi <ashishsinghi@apache.org>
2018-02-04 18:12:46 +05:30
zhangduo 3b603d2c08 HBASE-19926 Use a separated class to implement the WALActionListener for Replication 2018-02-04 20:32:14 +08:00
zhangduo cb138c2da8 HBASE-19914 Refactor TestVisibilityLabelsOnNewVersionBehaviorTable 2018-02-04 13:37:09 +08:00
Michael Stack a3233572ac HBASE-19928 TestVisibilityLabelsOnNewVersionBehaviorTable fails 2018-02-03 10:17:16 -08:00
Michael Stack 00653a4d18 HBASE-19919 Tidying up logging; ADDENDUM Fix tests w/ mocked Servers 2018-02-03 09:25:45 -08:00
zhangduo 66a11f2ac0 HBASE-19904 Break dependency of WAL constructor on Replication 2018-02-03 17:11:30 +08:00
Michael Stack bac4687345 HBASE-19919 Tidying up logging 2018-02-02 22:42:30 -08:00
Michael Stack 897afb7d18
HBASE-19726 Failed to start HMaster due to infinite retrying on meta assign 2018-02-02 18:30:24 -08:00
Guanghao Zhang 3398637bcd HBASE-19918 Promote TestAsyncClusterAdminApi to LargeTests 2018-02-03 09:40:58 +08:00
Chia-Ping Tsai b0bf6f504e HBASE-19720 Rename WALKey#getTabnename to WALKey#getTableName 2018-02-02 20:02:04 +08:00
tedyu efed668f74 HBASE-19895 Add keepDeletedCells option in ScanOptions for customizing scanInfo in pre-hooks (Ankit Singhal) 2018-02-01 18:28:05 -08:00
Mike Drob a165bd766a HBASE-19841 Every HTU should be local until DFS starts 2018-02-01 20:23:56 -06:00
zhangduo 79ccb0b38e HBASE-19913 Split TestStochasticLoadBalancer2 2018-02-02 08:29:33 +08:00
Michael Stack ea8290f3dc HBASE-19147 TestCacheOnWrite Times Out 2018-02-01 16:15:50 -08:00
Chia-Ping Tsai 6a1ed25581 HBASE-19897 RowMutations should follow the fluent pattern 2018-02-02 05:24:08 +08:00
Peter Somogyi 7fe215db5f HBASE-19884 BucketEntryGroup's equals, hashCode and compareTo methods are not consistent
Move back to default equals and hashCode.
Remove compareTo and Comparator to PriorityQueue.

Signed-off-by: Michael Stack <stack@apache.org>
2018-02-01 13:21:23 -08:00
kewang 86ca65218d HBASE-19912 Remove useless 'writeToWAL' flag of Region#checkAndRowMutate
Signed-off-by: Michael Stack <stack@apache.org>
2018-02-01 12:34:46 -08:00
Umesh Agashe 4cdc13b86e HBASE-19839 Fixed flakey tests TestMergeTableRegionsProcedure#testRollbackAndDoubleExecution and TestSplitTableRegionProcedure#testRollbackAndDoubleExecution
* Added a comment in MergeTableRegionsProcedure and SplitTableRegionProcedure explaining specific rollbacks has side effect that AssignProcedure/s are submitted asynchronously and those procedures may continue to execute even after rollback() is done.
* Updated comments in tests with correct rollback state to abort
* Added overloaded method MasterProcedureTestingUtility#testRollbackAndDoubleExecution which takes additional argument for waiting on all procedures to finish before asserting conditions
* Updated TestMergeTableRegionsProcedure#testRollbackAndDoubleExecution and TestSplitTableRegionProcedure#testRollbackAndDoubleExecution to use newly added method

Signed-off-by: Michael Stack <stack@apache.org>
2018-02-01 12:01:57 -08:00
Michael Stack 23471deb75 HBASE-19906 TestZooKeeper Timeout Includes move of TestQoSFunction from smalltests to mediumtests; it timedout in a run. 2018-02-01 10:53:51 -08:00
Michael Stack 4c210eb212 HBASE-19911 Convert some tests from small to medium because they are timing out: TestNettyRpcServer, TestClientClusterStatus; ADDENDUM changes TestCheckTestClasses to be medium sized test 2018-01-31 20:28:02 -08:00
Michael Stack ba265a7e51 HBASE-19911 Convert some tests from small to medium because they are timing out: TestNettyRpcServer, TestClientClusterStatus 2018-01-31 20:21:57 -08:00
Michael Stack 113432c9b9 HBASE-19910 TestBucketCache TimesOut 2018-01-31 18:17:22 -08:00
Michael Stack faea89ea4f HBASE-19909 TestRegionLocationFinder Timeout 2018-01-31 17:53:48 -08:00
Michael Stack 13f92b7daa HBASE-19908 TestCoprocessorShortCircuitRPC Timeout.... 2018-01-31 17:34:05 -08:00
Michael Stack 7a82126f8b Revert "HBASE-19906 TestZooKeeper Timeout"
Revert. Pushed prematurely.

This reverts commit 80af9bdef0.
2018-01-31 15:56:26 -08:00
Michael Stack e6d2682f0f HBASE-19907 TestMetaWithReplicas still flakey 2018-01-31 15:18:45 -08:00
Michael Stack 80af9bdef0 HBASE-19906 TestZooKeeper Timeout 2018-01-31 15:18:38 -08:00
Rahul Gidwani 4148d7c614 HBASE-19528 - Major Compaction Tool 2018-01-31 14:37:48 -08:00
zhangduo 28d13c54a9 HBASE-19887 Do not overwrite the surefire junit listener property in the pom of sub modules 2018-01-31 20:49:25 +08:00
binlijin b3824b8c92 HBASE-19728 Add lock to filesCompacting in all place. 2018-01-31 14:18:27 +08:00
Peter Somogyi 0ee280db22
HBASE-19868 TestCoprocessorWhitelistMasterObserver is flakey
Recategorize TestCoprocessorWhitelistMasterObserver as Large test
2018-01-30 06:01:50 -08:00
Michael Stack 364650bad5 HBASE-19868 TestCoprocessorWhitelistMasterObserver is flakey 2018-01-29 21:33:16 -08:00
Michael Stack 90a75fb052 HBASE-19888 Move branch-2 version from 2.0.0-beta-1 to 2.0.0-beta-2-SNAPSHOT 2018-01-29 14:17:54 -08:00
Peter Somogyi 27d73dec8a
HBASE-19811 Fix findbugs and error-prone warnings in hbase-server (branch-2) - addendum
Signed-off-by: Michael Stack <stack@apache.org>
2018-01-29 14:02:42 -08:00
Duo Zhang bbf3bae72a
HBASE-19873 Add a CategoryBasedTimeout ClassRule for all UTs 2018-01-29 12:41:14 -08:00
Michael Stack 7cbb70945a
HBASE-19840 Flakey TestMetaWithReplicas; ADDENDUM to fix Checksyte 2018-01-29 09:35:52 -08:00
Michael Stack 77607e4961
HBASE-19840 Flakey TestMetaWithReplicas
Fix two issues:

 # Meta Replicas can all be assigned to the same server. This
 will call the test to hang when we do our kill of the server
 hosting meta because there'll be no replicas to read from
 as test intends. Check is to look for this condition on
 startup and adjust if we come across it. Replicas cross-cut
 assignment. They need work.
 # Other issue was shutdown. The master started toward the
 end of the test may not have come up fully by the time
 shutdown is called. We could be stuck assigning the
 meta replicas. Have shutdown shutdown the procedure
 executor engine.

There is other cleanup and notes in the below.

M HMaster
 Remove the silly stops in startup now we have real
 means of shutting down Master during init.

M hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterMetaBootstrap.java
 This replica stuff was doing stuff it shouldn't be doing
 like setting core Master state flags. It may have made
 sense once but now meta is assigned by a Pv2 Procedure
 so the flag setting in here is meddlesome. Clear out
 methods no longer needed.

M hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
 Remove unused methods.
 Changes local variable names so they align w/ our naming elsewhere in
 code base.

M hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMetaWithReplicas.java
 Check for all replicas on the one server.
2018-01-29 09:26:41 -08:00
zhangduo 1efa050ebf HBASE-19885 Promote TestAssignmentManager to LargeTests 2018-01-30 00:25:32 +08:00
zhangduo f8bde7b76c HBASE-19866 TestRegionServerReportForDuty doesn't timeout
Synchronized on authManager instead of RpcServer
2018-01-29 21:23:57 +08:00
zhangduo 5b0d7dc45b HBASE-19882 Promote TestProcedureManager to MediumTests 2018-01-29 17:50:29 +08:00
zhangduo cdda0a79ea HBASE-19881 Promote TestRegionReplicaReplicationEndpoint to LargeTests 2018-01-29 16:15:55 +08:00
zhangduo b75c85a075 HBASE-19880 Promote TestFuzzyRowFilterEndToEnd to LargeTests 2018-01-29 16:15:36 +08:00
zhangduo 5ef5c5a247 HBASE-19879 Promote TestAcidGuaranteesXXX to LargeTests 2018-01-29 14:57:31 +08:00
Jan Hentschel 380169eaf2 HBASE-19869 TestLockManager now uses the right class for logging 2018-01-28 14:04:46 +01:00
zhangduo b355af0fad HBASE-19867 Split TestStochasticLoadBalancer into several small tests 2018-01-27 18:26:01 +08:00
haxiaolin 4c4352c727 HBASE-19861 - Avoid using RPCs when querying table infos for master status pages
Signed-off-by: tedyu <yuzhihong@gmail.com>
2018-01-26 08:02:43 -08:00
Guanghao Zhang c88e570dc1 HBASE-19818 Scan time limit not work if the filter always filter row key 2018-01-26 17:06:00 +08:00
Apekshit Sharma c16dae13f2 HBASE-19866 Add cateogry based timeout using Timeout Rule to TestRegionServerReportForDuty. 2018-01-26 00:44:04 -08:00
Apekshit Sharma f8295a810d HBASE-19862 addendum: Checkstyle fixes, remove unused imports and variables. Add @Rule for timeout. 2018-01-26 00:25:11 -08:00
Apekshit Sharma dbe5cbf5ae HBASE-19862 Fix TestTokenAuthentication - mock RegionCoprocessorEnvironment should be of type HasRegionServerServices also. 2018-01-25 23:55:12 -08:00
Thiruvel Thirumoolan c9950b5a79 HBASE-19756 Master NPE during completed failed proc eviction
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2018-01-24 16:43:08 -08:00
Michael Stack 739b9b4a8e HBASE-19838 Can not shutdown backup master cleanly when it has already tried to become the active master
On Master@shutdown, close the shared Master connection to kill any
ongoing RPCs by hosted clients.

M hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
Call close ont the Master shared clusterconnection to kill any ongoing
rpcs.

M hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
Remove guts of close; we were closing the Masters connection....not
our responsibility.

Added unit test written by Duo Zhang which demonstrates the case where
Master will not go down.

Signed-off-by: zhangduo <zhangduo@apache.org>
2018-01-23 11:09:42 +08:00
Chia-Ping Tsai f952779ba2 HBASE-4224 Need a flush by regionserver rather than by table option 2018-01-23 09:47:15 +08:00
Peter Somogyi b1269ec57f HBASE-19811 Fix findbugs and error-prone warnings in hbase-server (branch-2)
Signed-off-by: Michael Stack <stack@apache.org>
2018-01-22 17:14:15 -08:00
Michael Stack 1e5fc1ed63 HBASE-19840 Flakey TestMetaWithReplicas
Adding debuging
2018-01-22 12:26:03 -08:00
Rahul Gidwani 0fa24dddb9 HBASE-15321 - Ability to open a HRegion from hdfs snapshot. 2018-01-22 12:13:13 -08:00
Sergey Soldatov 6f8c31242a HBASE-19774 incorrect behavior of locateRegionInMeta 2018-01-22 11:49:19 -08:00
Michael Stack d4ffee2023 HBASE-19837 Flakey TestRegionLoad
Add debug, change name of the rows so readable.
2018-01-22 08:00:26 -08:00
zhangduo 5cce0f8f7d HBASE-19836 Fix TestZooKeeper.testLogSplittingAfterMasterRecoveryDueToZKExpiry 2018-01-22 18:30:11 +08:00
Michael Stack b44be75bd1 HBASE-19837 Flakey TestRegionLoad
Add debug, change name of the rows so readable.
2018-01-21 23:24:58 -08:00
Michael Stack c1470714bb HBASE-19794 TestZooKeeper hangs
Kill backup master first

Add some cleanup around NamespaceManager

Shorten the timeout waiting on namespace manager as workaround
until we have better soln for interrupting ongoing client rpcs.
Do it in general for all tests.

Signed-off-by: zhangduo <zhangduo@apache.org>
2018-01-21 20:59:31 +08:00
Michael Stack 86ecc963e4 HBASE-19828 Flakey TestRegionsOnMasterOptions.testRegionsOnAllServers
Rename the PE Worker threads.

Send an interrupt if worker taking a long time to go down
(it may be RPC'ing out to a dead server, retrying so
interrupt). Also join on the ProcedureExecutor shutting down.
This will make problems shutting down more obvious.

Disable TestRegionsOnMasterOptions. Master carrying Regions is broke.
2018-01-19 21:54:44 -08:00
Artem Ervits 8f713fcc19 HBASE-19829 hadoop-minicluster pulls zookeeper:test-jar:tests 3.4.6
Signed-off-by: tedyu <yuzhihong@gmail.com>
2018-01-19 15:22:15 -08:00
Michael Stack 0f9a837bd1
HBASE-19827 Addendum for Flakey TestAssignmentManager Don't clear old location from RTP... 2018-01-19 13:47:11 -08:00
Reid Chan 3131234ffd HBASE-19822 Override cancel(boolean) in LogCleaner (Addendum)
Signed-off-by: Michael Stack <stack@apache.org>
2018-01-19 11:48:16 -08:00
Guangxu Cheng c01dc69123 HBASE-19799 Add web UI to rsgroup
Signed-off-by: tedyu <yuzhihong@gmail.com>
2018-01-18 19:30:06 -08:00
Michael Stack a57769a15c HBASE-19822 HFileCleaner threads stick around after shutdown stuck on queue#take Interrupt wait on queue when cancel is called. 2018-01-18 13:53:11 -08:00
Michael Stack 13547d53eb HBASE-19815 Flakey TestAssignmentManager.testAssignWithRandExec (Part Two).
Part One cleaned up a ClassCastException.

Part Two adds the ServerCrashProcedure#handleRIT behavior to RecoverMetaProcedure.

Adds debug in the test.
2018-01-18 11:32:37 -08:00
Michael Stack 7225899e01 HBASE-19527 Make ExecutorService threads daemon=true
Set the ProcedureExcecutor worker threads as daemon.
Ditto for the timeout thread.

Remove hack from TestRegionsOnMasterOptions that was
put in place because the test would not go down.
2018-01-18 11:30:46 -08:00
lixiang a2d9a17851 HBASE-19821 TestCleanerChore#testOnConfigurationChange() requires at least 4 processors to get passed
Signed-off-by: tedyu <yuzhihong@gmail.com>
2018-01-18 11:20:52 -08:00
Apekshit Sharma 25621c6ea2 HBASE-19820 Restore public constructor of MiniHBaseCluster (API compat). 2018-01-18 09:07:30 -08:00
tedyu 251826e138 HBASE-19806 Lower max versions for table column family of hbase:meta 2018-01-18 07:58:44 -08:00
zhangduo d7e2e0d02c HBASE-19812 TestFlushSnapshotFromClient fails because of failing region.flush 2018-01-18 16:23:15 +08:00
Scott Wilson 0f2c1fa066 HBASE-19816 Refresh repliation sinks on UnknownHostException
Signed-off-by: tedyu <yuzhihong@gmail.com>
2018-01-17 16:25:17 -08:00
Michael Stack af2d890055 Revert "HBASE-19527 Make ExecutorService threads daemon=true"
Applied prematurely. Revert.

This reverts commit 5e4ed33fa2.
2018-01-17 15:08:42 -08:00
Michael Stack 0f5b0fb759 HBASE-19815 Flakey TestAssignmentManager.testAssignWithRandExec 2018-01-17 13:50:42 -08:00
Michael Stack 5e4ed33fa2 HBASE-19527 Make ExecutorService threads daemon=true
Set the ProcedureExcecutor worker threads as daemon.
Ditto for the timeout thread.

Remove hack from TestRegionsOnMasterOptions that was
put in place because the test would not go down.
2018-01-17 13:41:38 -08:00
Michael Stack addd716549
HBASE-19808 Reenable TestMultiParallel 2018-01-17 08:59:05 -08:00
Reid Chan f22cf7226e HBASE-19736 Remove BaseLogCleanerDelegate deprecated #isLogDeletable(FileStatus) and use #isFileDeletable(FileStatus) instead
Signed-off-by: Chia-Ping Tsai <chia7712@gmail.com>
2018-01-17 21:25:20 +08:00
zhangduo 48bb19012c HBASE-19792 TestReplicationSmallTests.testDisableEnable fails 2018-01-17 14:23:17 +08:00
Vasudevan f23fd7208b HBASE-19732 Replica regions does not return back the MSLAB chunks to pool
(Ram)
2018-01-15 22:15:01 +05:30
zhangduo e014e5f8ef HBASE-19797 Operator priority leads to wrong logic in ReplicationSourceWALReader 2018-01-15 18:10:56 +08:00
zhangduo 204a4539c4 HBASE-19793 Minor improvements on Master/RS startup 2018-01-15 17:54:01 +08:00
zhangduo 8dd4bf8e54 HBASE-19795 Move the tests which only need zookeeper in TestZooKeeper to hbase-zookeeper module 2018-01-15 10:58:03 +08:00
zhangduo ffa28502c4 HBASE-19768 RegionServer startup failing when DN is dead 2018-01-14 17:31:23 +08:00
Michael Stack 026f535a77 HBASE-19787 Fix or disable tests broken in branch-2 so can cut beta-1
M dev-support/make_rc.sh
  Disable checkstyle building site. Its an issue being fixed over in HBASE-19780

M hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
  The clusterid was being set into the process only after the
  regionserver registers with the Master. That can be too late for some
  test clients in particular. e.g. TestZKAsyncRegistry needs it as soon
  as it goes to run which could be before Master had called its run
  method  which is regionserver run method which then calls back to the
  master to register itself... and only then do we set the clusterid.
  HBASE-19694 changed start order which made it so this test failed.
  Setting the clusterid right after we set it in zk makes the test pass.

  Another change was that backup masters were not going down on stop.
  Backup masters were sleeping for the default zk period which is 90
  seconds. They were not being woken up to check for stop. On stop
  master now tells active master manager.

M hbase-server/src/test/java/org/apache/hadoop/hbase/TestJMXConnectorServer.java
  Prevent creation of acl table. Messes up our being able to go down
  promptly.

M hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestRegionsOnMasterOptions.java
M hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMultiParallel.java
M hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerReadRequestMetrics.java
  Disabled for now because it wants to run with regions on the Master...
  currently broke!

M hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestZKAsyncRegistry.java
  Add a bit of debugging.

M hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestDLSAsyncFSWAL.java
  Disabled. Fails 40% of the time.

M hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestDLSFSHLog.java
  Disabled. Fails 33% of the time.

Disabled stochastic load balancer for favored nodes because it fails on
occasion and we are not doing favored nodes in branch-2.
2018-01-12 14:09:23 -08:00
Michael Stack d8271b0361
HBASE-19694 The initialization order for a fresh cluster is incorrect Addendum. Adds in a missing line that helps debugging. 2018-01-12 13:08:27 -08:00
Guanghao Zhang 72702eeb70 HBASE-19783 Change replication peer cluster key/endpoint from a not-null value to null is not allowed
Signed-off-by: zhangduo <zhangduo@apache.org>
2018-01-12 21:41:57 +08:00
Chia-Ping Tsai 3e6f80dcd5
HBASE-19746 Add default impl to Cell#getType 2018-01-11 15:04:25 -08:00
Michael Stack 1a11fc92b1 HBASE-19694 The initialization order for a fresh cluster is incorrect
Become active Master before calling the super class's run method. Have
the wait-on-becoming-active-Master be in-line rather than off in a
background thread (i.e. undo running thread in startActiveMasterManager)

Purge the fragile HBASE-16367 hackery that attempted to fix this issue
previously by adding a latch to try and hold up superclass RegionServer
until cluster id set by subclass Master.
2018-01-11 14:25:25 -08:00
zhangduo 0dacdde0f9 HBASE-19758 Split TestHCM to several smaller tests
Signed-off-by: Michael Stack <stack@apache.org>
2018-01-11 11:40:48 -08:00
Rahul Gidwani 3849db8f1d HBASE-11409 - Add more flexibility for input directory structure to LoadIncrementalHFiles 2018-01-11 11:07:47 -08:00
Rahul Gidwani 482d413e0a Revert due to missing jira ticket "Add more flexibility for input directory structure to LoadIncrementalHFiles"
This reverts commit d524768528.
2018-01-11 11:07:10 -08:00
Chia-Ping Tsai 5d4140e09d HBASE-19685 Fix TestFSErrorsExposed#testFullSystemBubblesFSErrors by increasing scanner timeout.
Signed-off-by: Apekshit Sharma <appy@apache.org>
2018-01-11 10:35:36 -08:00
Apekshit Sharma 31fe5dbf6b Revert due to missing author. "HBASE-19685 Fix TestFSErrorsExposed#testFullSystemBubblesFSErrors by increasing scanner timeout."
This reverts commit 0b9dc14dbc.
2018-01-11 10:35:32 -08:00
Apekshit Sharma bf3c207785 HBASE-19685 Fix TestFSErrorsExposed#testFullSystemBubblesFSErrors by increasing scanner timeout. 2018-01-11 10:32:26 -08:00
zhangduo 814d08a2d6 HBASE-19751 Use RegionInfo directly instead of an identifier and a namespace when getting WAL 2018-01-11 15:48:33 +08:00
huzheng 98e56ae4c6 HBASE-19749 Revisit logic of UserScanQueryMatcher#mergeFilterResponse method 2018-01-11 12:06:12 +08:00
tedyu 47326729fe HBASE-19740 Repeated error message for NamespaceExistException 2018-01-10 18:26:23 -08:00
Rahul Gidwani d524768528 Add more flexibility for input directory structure to LoadIncrementalHFiles 2018-01-10 13:42:34 -08:00
Michael Stack 345b8ba9a1 HBASE-19743 Disable TestMemstoreLABWithoutPool
This is a revert of a revert, i.e., a reapplication only this time
I'm pushing w/ the right JIRA number
2018-01-09 18:22:36 -08:00
Michael Stack 950ecd2764 Revert "HBASE-19742 Disable TestMemstoreLABWithoutPool"
Revert because have wrong JIRA number.

This reverts commit 1454c44bcb.
2018-01-09 18:20:37 -08:00
Michael Stack 1454c44bcb HBASE-19742 Disable TestMemstoreLABWithoutPool 2018-01-09 14:32:58 -08:00
Guangxu Cheng 3fa3dcd9f9 HBASE-19483 Add proper privilege check for rsgroup commands
Signed-off-by: tedyu <yuzhihong@gmail.com>
2018-01-09 08:11:07 -08:00
Guanghao Zhang 895267d09c HBASE-19139 Create Async Admin methods for Clear Block Cache 2018-01-09 14:55:21 +08:00
huzheng d9ca212d55 HBASE-19729 UserScanQueryMatcher#mergeFilterResponse should return INCLUDE_AND_SEEK_NEXT_ROW when filterResponse is INCLUDE_AND_SEEK_NEXT_ROW 2018-01-09 07:22:09 +08:00
zhangduo 4c31374a90
HBASE-19731 TestFromClientSide#testCheckAndDeleteWithCompareOp and testNullQualifier are flakey 2018-01-08 10:34:57 -08:00
BELUGA BEHR c8e8f7008d HBASE-19684 BlockCacheKey toString Performance
Signed-off-by: zhangduo <zhangduo@apache.org>
2018-01-08 17:06:34 +08:00
Jingyun Tian 1e352f6247 HBASE-19358 Improve the stability of splitting log when do fail over
Signed-off-by: Yu Li <liyu@apache.org>
2018-01-08 10:57:46 +08:00
Chia-Ping Tsai a66e923106 HBASE-19712 Fix TestSnapshotQuotaObserverChore#testSnapshotSize 2018-01-08 08:52:28 +08:00
tedyu 0168c1e6cb HBASE-19696 Filter returning INCLUDE_AND_NEXT_COL doesn't skip remaining versions when scan has explicit columns (Ankit Singhal) 2018-01-07 07:50:33 -08:00
Josh Elser 443b27b707 HBASE-19709 Ensure that we don't set a poolSize of 0
In some situations, Runtime.getRuntime().getAvailableProcessors()
may return 0 which would result in calculatePoolSize returning 0
which will trigger an exception. Guard against this case.

Signed-off-by: Reid Chan <reidddchan@outlook.com>
Signed-off-by: Chia-Ping Tsai <chia7712@gmail.com>
Signed-off-by: Ted Yu <yuzhihong@gmail.com>
2018-01-05 18:36:50 -05:00
Michael Stack ce80e8e38f
HBASE-19651 Remove LimitInputStream; AMENDMENT: fix compile 2018-01-05 17:28:40 -06:00
Beluga Behr 88c7493948
HBASE-19651 Remove LimitInputStream 2018-01-05 17:01:50 -06:00
Michael Stack e7da907c3c
Revert "HBASE-19651 Remove LimitInputStream"
Revert to fix author.

This reverts commit 4c19e1f4e3.
2018-01-05 16:59:59 -06:00
Michael Stack 4c19e1f4e3
HBASE-19651 Remove LimitInputStream
Signed-off-by: Beluga Behr <dam6923@gmail.com>
2018-01-05 08:38:12 -06:00
Reid Chan e35fec284d HBASE-19688 TimeToLiveProcedureWALCleaner should extends BaseLogCleanerDelegate
Signed-off-by: tedyu <yuzhihong@gmail.com>
2018-01-04 10:26:51 -08:00
Chia-Ping Tsai 654edc5fa5 HBASE-19596 RegionMetrics/ServerMetrics/ClusterMetrics should apply to all public classes 2018-01-04 13:05:21 +08:00
Chia-Ping Tsai f993425f01 HBASE-19490 Rare failure in TestRateLimiter 2018-01-04 10:43:26 +08:00
BELUGA BEHR 59558f020f HBASE-19613 Miscellaneous changes to WALSplitter.
* Use ArrayList instead LinkedList
* Use Apache Commons where appropriate
* Parameterize and improve logging
2018-01-03 18:39:14 -08:00
huzheng 16e8422855 HBASE-18806 VerifyRep by snapshot need not to restore snapshot for each mapper 2018-01-04 10:12:53 +08:00
Josh Elser f0011ebfe0 HBASE-19691 Removes Global(A) requirement for getClusterStatus
Signed-off-by: Chia-Ping Tsai <chia7712@gmail.com>
2018-01-03 19:02:26 -05:00
Reid Chan 97dc7d87cd HBASE-19654 Remove misleading and chatty debug message in ReplicationLogCleaner
Signed-off-by: tedyu <yuzhihong@gmail.com>
2018-01-03 06:58:57 -08:00
zhangduo 47a264a6aa HBASE-19620 Add UT to confirm the race in MasterRpcServices.getProcedureResult 2018-01-03 20:29:02 +08:00
Balazs Meszaros 37f846dc0c HBASE-19666 TestDefaultCompactSelection test failed
Signed-off-by: Chia-Ping Tsai <chia7712@gmail.com>
2018-01-03 19:12:17 +08:00
BELUGA BEHR 76580fa991 HBASE-19675 Miscellaneous HStore Class Improvements.
* Use HashSet instead of List for a variable which is only used for lookups
* Remove logging code guards in favor of slf4j parameters
* Use CollectionsUtils.isEmpty() consistently
* Small check-style fixes
2018-01-02 15:21:15 -08:00
Chia-Ping Tsai 97c770a1d3 HBASE-19667 Get rid of MasterEnvironment#supportGroupCPs 2018-01-03 05:03:57 +08:00
tedyu 69e161cf64 HBASE-19676 CleanerChore logging improvements (BELUGA BEHR) 2018-01-02 06:27:41 -08:00
anastas 488797f4bb HBASE-19658: Fixing small problem and enabling test 2018-01-02 12:54:05 +02:00
Chia-Ping Tsai 99399cdeef HBASE-19671 Fix TestMultiParallel#testActiveThreadsCount 2018-01-02 17:05:47 +08:00
tedyu 3f1cfc8f08 HBASE-19679 Superusers Logging and Data Structures (BELUGA BEHR) 2018-01-01 14:19:04 -08:00
tedyu c394f3919e HBASE-19678 HBase Admin security capabilities should be represented as a Set - revert due to wrong issue 2018-01-01 14:16:46 -08:00
tedyu c2ca90f0fb HBASE-19678 HBase Admin security capabilities should be represented as a Set (BELUGA BEHR) 2017-12-31 11:32:14 -08:00
tedyu 2f5ca9010b HBASE-19677 Miscellaneous HFileCleaner Improvements (BELUGA BEHR) 2017-12-31 09:47:53 -08:00
Xiang Li 5b3513a5ee HBASE-19672 Correct comments for default values of major compaction in SortedCompactionPolicy#getNextMajorCompactTime()
Signed-off-by: tedyu <yuzhihong@gmail.com>
2017-12-30 16:28:09 -08:00
BELUGA BEHR 24b7fc92f0 HBASE-19649 Use singleton feature for ImmutableSegment
Signed-off-by: Chia-Ping Tsai <chia7712@gmail.com>
2017-12-30 06:42:24 +08:00
brandboat 9e141d12a4 HBASE-8518 Get rid of hbase.hstore.compaction.complete setting
Signed-off-by: Chia-Ping Tsai <chia7712@gmail.com>
2017-12-30 04:32:12 +08:00
Chia-Ping Tsai 5612f2f692 HBASE-19428 Deprecate the compareTo(Row) 2017-12-29 20:07:21 +08:00
anastas 0907563eb7 HBASE-19282: Making CellChunkMap the default index (CellSet delegatee) for ImmutableSegments, when MSLAB is used.
In order to avoid additional user settings. If no MSLAB is requested the index is going to be CellArrayMap

Signed-off-by: Anastasia Braginsky <anastas@yahoo-inc.com>
Signed-off-by: Michael Stack <stack@apache.org>
2017-12-28 16:49:56 -08:00
Michael Stack b4e3798bb9 HBASE-19660 Up default retries from 10 to 15 and blocking store files limit from 10 to 16 2017-12-28 15:02:23 -08:00
Michael Stack a8ef734ddd HBASE-19651 Remove LimitInputStream
Signed-off-by: Beluga Behr <dam6923@gmail.com>
2017-12-28 13:08:46 -08:00
Michael Stack d8775d08ae HBASE-19656 Disable TestAssignmentManagerMetrics for beta-1 2017-12-28 12:15:00 -08:00
gsheffi f96f89157d HBASE-19133 Transfer big cells or upserted/appended cells into
MSLAB upon flattening to CellChunkMap

Signed-off-by: Gali Sheffi <gsheffi@oath.com>
2017-12-28 10:53:06 -08:00
Mike Drob 64cb777a8a HBASE-19552 find-and-replace thirdparty offset 2017-12-28 12:01:25 -06:00
Mike Drob 968b938fde HBASE-19552 Update hbase-thirdparty version
Some manual cleanup of changing package names in pom files and getting
rid of the no-longer-needed netty system property.

This commit will break compilation, package renames in source code are
done in follow-on commits using straightforward find and replace.

's/org.apache.hadoop.hbase.shaded.com.google/org.apache.hbase.thirdparty.com.google/'
's/org.apache.hadoop.hbase.shaded.io.netty/org.apache.hbase.thirdparty.io.netty/'
2017-12-28 11:58:49 -06:00
Guanghao Zhang 33ce14cb29 HBASE-19643 Need to update cache location when get error in AsyncBatchRpcRetryingCaller 2017-12-28 14:44:17 +08:00
Chia-Ping Tsai 97f0aad66e HBASE-19626 Rename Cell.DataType to Cell.Type 2017-12-28 12:59:28 +08:00
Michael Stack 50348cc1a4 HBASE-19652 Turn down CleanerChore logging; too chatty 2017-12-27 20:50:46 -08:00
Michael Stack d6d8369655
HBASE-19648 Move branch-2 version from 2.0.0-beta-1-SNAPSHOT to 2.0.0-beta-1 2017-12-27 14:41:19 -08:00
Michael Stack e4ab29ada2 HBASE-19647 Logging cleanups; emit regionname when RegionTooBusyException inside RetriesExhausted... make netty connect/disconnect TRACE-level; ADDENDUM 2017-12-27 14:14:37 -08:00
Chia-Ping Tsai 7dee1bcd31 HBASE-19644 add the checkstyle rule to reject the illegal imports 2017-12-28 04:17:45 +08:00
Michael Stack cc8b37f847 HBASE-19647 Logging cleanups; emit regionname when RegionTooBusyException inside RetriesExhausted... make netty connect/disconnect TRACE-level 2017-12-27 11:56:40 -08:00
Chia-Ping Tsai 2468f30029 HBASE-19628 ByteBufferCell should extend ExtendedCell 2017-12-27 23:02:18 +08:00
Vasudevan 0454a389a3 HBASE-19629 RawCell#getTags should return the Iterator<Tag> in order to avoid iterating through whole tag array at once
Signed-off-by: Chia-Ping Tsai <chia7712@gmail.com>
2017-12-27 21:30:08 +08:00
BELUGA BEHR 9c9beb79ef HBASE-19615 CompositeImmutableSegment ArrayList Instead of LinkedList
Signed-off-by: Chia-Ping Tsai <chia7712@gmail.com>
2017-12-27 10:00:51 +08:00
Chia-Ping Tsai f0781d49e4 HBASE-19624 TestIOFencing hangs 2017-12-27 09:38:17 +08:00
Chia-Ping Tsai 8362b0dba5 HBASE-19550 Wrap the cell passed via Mutation#add(Cell) to be of ExtendedCell 2017-12-26 16:43:01 +08:00
Guanghao Zhang 2abf7b508c HBASE-19621 Revisit the methods in ReplicationPeerConfigBuilder 2017-12-26 14:44:07 +08:00
Guanghao Zhang 65159dc256 HBASE-19618 Remove replicationQueuesClient.class/replicationQueues.class config and remove table based ReplicationQueuesClient/ReplicationQueues implementation 2017-12-26 14:44:02 +08:00
zhangduo 33f2e6535c HBASE-19608 Race in MasterRpcServices.getProcedureResult 2017-12-25 11:52:38 +08:00
Guanghao Zhang 1e490dcc11 HBASE-19602 Cleanup the usage of ReplicationAdmin from document 2017-12-23 19:05:04 +08:00
Guanghao Zhang b552eb2ff9 HBASE-19576 Introduce builder for ReplicationPeerConfig and make it immutable 2017-12-23 19:04:58 +08:00
tedyu 96ae9add68 HBASE-19514 TestJMXListener now uses random port
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
2017-12-22 18:46:52 +01:00
Rajeshbabu Chintaguntla 79d4f6c11c HBASE-19593 Possible NPE if wal is closed during waledit append.(Rajeshabbu) 2017-12-22 17:21:30 +05:30
Chia-Ping Tsai d4af099e9e HBASE-19496 Reusing the ByteBuffer in rpc layer corrupt the ServerLoad and RegionLoad 2017-12-22 18:58:08 +08:00
Guanghao Zhang 3a210d514c HBASE-19590 Remove the duplicate code in deprecated ReplicationAdmin 2017-12-22 18:36:28 +08:00
Apekshit Sharma 11ea19a101 HBASE-19589 New regions should always be added with state CLOSED (followup of HBASE-19530) 2017-12-21 22:58:28 -08:00
Daisuke c89cfd3406 HBASE--17248 fix javadoc in SimpleRegionNormalizer
Signed-off-by: Michael Stack <stack@apache.org>
2017-12-21 21:35:50 -08:00
Michael Stack a150062bfb
HBASE-19148 Reevaluate default values of configurations; minor ADDENDUM 2017-12-21 14:13:23 -08:00
Michael Stack 18987ed867
HBASE-19148 Reevaluate default values of configurations
Removed unused:
    <name>hbase.fs.tmp.dir</name>
Added hbase.master.loadbalance.bytable

Edit of description text. Moved stuff around  to put configs beside each
other.

M hbase-server/src/main/java/org/apache/hadoop/hbase/util/ServerCommandLine.java

 Emit some hbase configs in log on startup.

Signed-off-by: Michael Stack <stack@apache.org>
2017-12-21 14:07:47 -08:00
Chia-Ping Tsai 4aec7a491a HBASE-19575 add copy constructor to Mutation 2017-12-22 03:19:47 +08:00
Peter Somogyi bf998077b9 HBASE-19578 MasterProcWALs cleaning is incorrect
Signed-off-by: tedyu <yuzhihong@gmail.com>
2017-12-21 09:39:31 -08:00
zhangduo a82f89bd3c HBASE-10092 Addendum fix TestAssignProcedure and TestWALEntrySinkFilter 2017-12-21 21:45:09 +08:00
zhangduo 69ea6928bc HBASE-19559 Fix TestLogRolling.testLogRollOnDatanodeDeath 2017-12-21 15:20:31 +08:00
Balazs Meszaros 992b5d8630 HBASE-10092 Move up on to log4j2
Changes:
- replaced commons-logging to slf4j everywhere
- log.XXX(Throwable) calls were replaced with log.XXX(t.toString(), t)
- log.XXX(Object) calls were replaced with log.XXX(Objects.toString(obj))
- log.fatal() calls were replaced with log.error(HBaseMarkers.FATAL, ...)
- programmatic log4j configuration was removed from the unit test

This commit does not affect the current logging configurations, because log4j
is still on the classpath. slf4j-log4j12 binds log4j to slf4j.

Signed-off-by: Michael Stack <stack@apache.org>
2017-12-20 22:58:12 -08:00
Michael Stack 13d9e8088c HBASE-19218 Master stuck thinking hbase:namespace is assigned after restart preventing intialization
Signed-off-by: Li Xiang <easyliangjob@gmail.com>
2017-12-20 21:47:50 -08:00
Chia-Ping Tsai 0a5ef1ed88 HBASE-19542 fix TestSafemodeBringsDownMaster 2017-12-21 10:28:19 +08:00
Michael Stack 0887cdf1da
HBASE-19567 ClassNotFoundException:
org.apache.hadoop.hbase.KeyValue$RawBytesComparator starting 2.0.0 over
a 0.98.25 data.
2017-12-20 11:21:56 -08:00
zhangduo 4fad3d96c9
HBASE-19554 For debug: Modify HTU.waitUntilAllRegionsAssigned to handle the case where we do not have entries for the given table 2017-12-20 10:22:08 -08:00
Guangxu Cheng 728d5ec041 HBASE-19561 maxCacheSize in CacheEvictionStats can't be accumulated repeatedly When dealing with each region
Signed-off-by: tedyu <yuzhihong@gmail.com>
2017-12-20 07:05:30 -08:00
Guanghao Zhang c63cc68c01 HBASE-19492 (addendum) Add EXCLUDE_NAMESPACE and EXCLUDE_TABLECFS support to replication peer config
Signed-off-by: zhangduo <zhangduo@apache.org>
2017-12-20 20:49:16 +08:00
Vasudevan 5be25bcf6b HBASE-19468 FNFE during scans and flushes (Ram) 2017-12-20 11:11:06 +05:30
Michael Stack f80d2e9c8e
HBASE-19558 TestRegionsOnMasterOptions hack so it works reliably 2017-12-19 15:59:30 -08:00
Yi Liang 1d7b0a9958
HBASE-19556: Remove TestAssignmentManager#testGoodSplit, which no longer make sense 2017-12-19 13:53:37 -08:00
Michael Stack 31ebd24b7d
HBASE-19494 Create simple WALKey filter that can be plugged in on the Replication Sink
Implement new WALEntrySinkFilter (as opposed to WALEntryFilter) and
specify the implmentation (with a no-param constructor) in config
using property hbase.replication.sink.walentrysinkfilter

Signed-off-by: wolfgang hoschek whoscheck@cloudera.com
2017-12-19 13:50:09 -08:00
Peter Somogyi ef509f2ac7 HBASE-19555 TestSplitTransactionOnCluster is flaky
Signed-off-by: tedyu <yuzhihong@gmail.com>
2017-12-19 09:26:42 -08:00
Guanghao Zhang 60cd494d1c HBASE-19492 Add EXCLUDE_NAMESPACE and EXCLUDE_TABLECFS support to replication peer config 2017-12-19 16:57:38 +08:00
tedyu 1fd22a7b0f HBASE-19532 AssignProcedure#COMPARATOR may produce incorrect sort order 2017-12-18 18:33:27 -08:00
Michael Stack 495bedea35
HBASE-19122 Suspect methods on Cell to be deprecated 2017-12-18 15:23:03 -08:00
Yun Chi-Shih 5895719420 HBASE-19531 Remove needless volatile declaration
Signed-off-by: Chia-Ping Tsai <chia7712@gmail.com>
2017-12-19 00:40:37 +08:00
QilinCao 07d20b2d18 HBASE-19521 HBase mob compaction needs to check hfile version
Signed-off-by: tedyu <yuzhihong@gmail.com>
2017-12-18 08:32:51 -08:00
zhangduo c0740b84ef HBASE-19546 TestMasterReplication.testCyclicReplication2 uses wrong assertion 2017-12-18 19:59:19 +08:00
Chia-Ping Tsai 1ca2d10299 HBASE-18309 (addendum) fix NPE in LogCleaner 2017-12-17 17:30:33 +08:00
Guanghao Zhang 8fa08b56f3 HBASE-19522 The complete order may be wrong in AsyncBufferedMutatorImpl 2017-12-16 14:09:35 +08:00
Peter Somogyi 2043c337d8
HBASE-19498 Fix findbugs and error-prone warnings in hbase-client (branch-2)
Signed-off-by: Michael Stack <stack@apache.org>
Signed-off-by: Apekshit Sharma <appy@apache.org>
2017-12-15 15:57:01 -08:00
Michael Stack 85969cfcda HBASE-18352 Enable TestMasterOperationsForRegionReplicas#testCreateTableWithMultipleReplicas disabled by Proc-V2 AM in HBASE-14614
Reenables the test. Adds facility to HBaseTestingUtility so
you can pass in ports a restarted cluster should use. This
is needed so retention of region placement, on which this
test depends, can come trigger (this is why it was broke
on AMv2 commit... region placement retention is done
different in AMv2).
2017-12-15 12:48:19 -08:00
Michael Stack bff4226105 HBASE-19272 Deal with HBCK tests disabled by HBASE-14614 AMv2 when HBCK
works again...

I removed them
2017-12-15 12:20:18 -08:00
Mike Drob 23a9059cb2 HBASE-18838 Fix hadoop3 check-shaded-invariants 2017-12-15 13:20:54 -06:00
Michael Stack 672c440b9f HBASE-18946 Stochastic load balancer assigns replica regions to the same RS
Added new bulk assign createRoundRobinAssignProcedure to complement
the existing createAssignProcedure. The former asks the balancer for
target servers to set into the created AssignProcedures. The latter
sets no target server into AssignProcedure. When no target server
is specified, we make effort at assign-time at trying to deploy the
region to its old location if there was one.

The new round robin assign procedure creator does not do this. Use
the new round robin method on table create or reenabling offline
regions. Use the old assign in ServerCrashProcedure or in
EnableTable so there is a chance we retain locality.

Bulk preassigning passing all to-be-assigned to the balancer in one
go is good for ensuring good distribution especially when read
replicas in the mix.

The old assign was single-assign scoped so region replicas could
end up on the same server.

M hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignProcedure.java
 Cleanup around forceNewPlan. Was confusing.
 Added a Comparator to sort AssignProcedures so meta and system tables
 come ahead of user-space tables.

M hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
 Remove the forceNewPlan argument on createAssignProcedure. Didn't make
 sense given we were creating a new AssignProcedure; the arg had no
 effect.

 (createRoundRobinAssignProcedures) Recast to feed all regions to the balancer in
 bulk and to sort the return so meta and system tables take precedence.

Miscellaneous fixes including keeping the Master around until all
RegionServers are down, documentation on how assignment retention
works, etc.
2017-12-15 08:54:35 -08:00
Michael Stack 76057aab62 HBASE-15536 Make AsyncFSWAL as our default WAL
Signed-off-by: zhangduo <zhangduo@apache.org>
2017-12-15 20:45:46 +08:00
anoopsamjohn a2dbb42284 HBASE-19505 Disable ByteBufferPool by default at HM. 2017-12-15 15:44:14 +05:30
tedyu 1d8a601166 HBASE-19516 IntegrationTestBulkLoad and IntegrationTestImportTsv run into 'java.lang.RuntimeException: DistributedHBaseCluster@1bb564e2 not an instance of MiniHBaseCluster' (Ankit) 2017-12-14 18:37:55 -08:00
zhangduo f070c381e2 HBASE-19513 Fix the wrapped AsyncFSOutput implementation 2017-12-15 09:39:42 +08:00
Chia-Ping Tsai 33d48754f5
HBASE-19462 Deprecate all addImmutable methods in Put
Signed-off-by: Michael Stack <stack@apache.org>
2017-12-14 14:18:04 -08:00
Mike Drob 2952cc7dea HBASE-19289 Add flag to disable stream capability enforcement
Signed-off-by: Josh Elser <elserj@apache.org>
2017-12-14 12:19:59 -06:00
ramkrish86 eac13e2315 HBASE-19511 Splits causes blocks to be cached again and so such blocks cannot be evicted from bucket cache (Ram)
Signed-off Duo Zhang, Anoop Sam John <palomino219@gmail.com, anoop.hbase@gmail.com>
2017-12-15 00:39:36 +05:30
zhangduo c2bb63fbf9 HBASE-19512 Move EventType and ExecutorType from hbase-client to hbase-server 2017-12-14 20:15:35 +08:00
zhangduo a1f8821b85 HBASE-19510 TestDistributedLogSplitting is flakey for AsyncFSWAL 2017-12-14 15:59:58 +08:00
Michael Stack cb4bbea0f1 HBASE-19287 Revert "Revert "master hangs forever if RecoverMeta
send assign meta region request to target server fail""

This is a revert of a revert; i.e a reapplication with the
log message fixed up and some added javadoc.

This reverts commit 9ef115163b.

Signed-off-by: Yi Liang <yliang@us.ibm.com>
2017-12-13 23:09:09 -08:00
zhangduo 211f231b4a HBASE-19503 Fix TestWALOpenAfterDNRollingStart for AsyncFSWAL 2017-12-14 09:41:23 +08:00
Michael Stack fb6625fdd9
HBASE-19508 ReadOnlyConfiguration throws exception if any Configuration in current context calls addDefautlResource; ADDENDUM -- fix license 2017-12-13 10:29:46 -08:00
Michael Stack b475f15f25
HBASE-19508 ReadOnlyConfiguration throws exception if any Configuration in current context calls addDefautlResource
Signed-off-by: Peter Somogyi <psomogyi@cloudera.com>
2017-12-13 10:29:34 -08:00
Sergey Soldatov 78ff501ad8 HBASE-19456 RegionMover's region server hostname option is no longer case insensitive
Signed-off-by: Josh Elser <elserj@apache.org>
2017-12-13 11:45:11 -05:00
Guangxu Cheng 015b66103a HBASE-19000 Group multiple block cache clear requests per server
Signed-off-by: tedyu <yuzhihong@gmail.com>
2017-12-13 07:47:33 -08:00
Chia-Ping Tsai a489292a83 HBASE-19502 Make sure we have closed all StoreFileScanner if we fail to open any StoreFileScanners 2017-12-13 21:38:45 +08:00
Chia-Ping Tsai 55eb59e654 HBASE-19427 Add TimeRange support into Append to optimize for counters 2017-12-13 15:40:56 +08:00
Peter Somogyi 941acc5c05 HBASE-19213 Align check and mutate operations in Table and AsyncTable
- Deprecates old checkAnd*() operations in Table
- Adds Table#CheckAndMutateBuilder and implements it in HTable

Commiter note: When committing the patch, noticed redundant {@inheritDoc} being added in HTable.
Removed new and olds ones.

Signed-off-by: Apekshit Sharma <appy@apache.org>
2017-12-12 20:46:39 -08:00
tedyu 0e47ded1a5 HBASE-19394 Support multi-homing env for the publication of RS status with multicast (hbase.status.published) (Toshihiro Suzuki) 2017-12-12 07:48:40 -08:00
zhangduo 46d9b4cf08 HBASE-19493 Make TestWALMonotonicallyIncreasingSeqId also work with AsyncFSWAL 2017-12-12 20:57:04 +08:00
zhangduo 3aa56b3932
HBASE-19371 Running WALPerformanceEvaluation against asyncfswal throws exceptions
Signed-off-by: Michael Stack <stack@apache.org>
2017-12-11 13:38:34 -08:00
Vasudevan 8dfb62029b HBASE-19485 Minor improvement to TestCompactedHFilesDischarger (Ram)
Signed off by : Ted Yu <yuzhihong@gmail.com>
2017-12-11 22:57:35 +05:30
Jan Hentschel aec5581885 HBASE-17425 Fixed deprecated calls in TestUpdateConfiguration 2017-12-09 14:44:06 +01:00
Guanghao Zhang 62ccc340fd HBASE-19463 Make CPEnv#getConnection return a facade that throws Unsupported if CP calls #close 2017-12-09 20:26:37 +08:00
Apekshit Sharma e8ba7b2320 HBASE-19457 Debugging flaky TestTruncateTableProcedure
- Adds debug logging for future ease
- Removes 60s timeout since testRecoveryAndDoubleExecutionPreserveSplits is only halfway after a minute.
- Adds some comments
- Logging change: Some places report "regionState=" while others just "state=".
  State machine procs also have "state=" in their logs. Let me change all region related logging to "regionState=" so that
  1) it's consistent everywhere, 2) more filtered results when searching through logs.
2017-12-08 17:25:44 -08:00
Michael Stack a33a9de643
HBASE-19134 Make WALKey an Interface; expose Read-Only version to CPs
Created a new WALKey Interface and a WALKeyImpl. The WALKey Interface
is surfaced to Coprocessors and throughout most of the code base.
WALKeyImpl is used internally by WAL and by Replication which need
access to WALKey setters.

Methods that were deprecated in WALObserver because they were exposing
Private audience Classes have been undeprecated now we have WALKey.

Moved over to use SequenceId#getSequenceId throughout. Changed
SequenceId#getSequenceId removing the IOE.
2017-12-08 15:12:51 -08:00
Apekshit Sharma a70b9b5e94 HBASE-19454 Debugging TestDistributedLogSplitting#testThreeRSAbort
- Changed testThreeRSAbort to kill the RSs intead of aborting. Simple aborting will close the regions, we want extreme failure testing here.
- Adds some logging for easier debugging.
- Refactors TestDistributedLogSplitting to use standard junit rules.
2017-12-07 19:15:54 -08:00
Michael Stack b0d68d6814
HBASE-19349 Introduce wrong version depencency of servlet-api jar
Move the hadoop-hdfs guava exclude in modules up to the top pom.
Looks like an exclude in a module is not additive but rather exclusive
blanking out the top level set of exclusions.

Tested by looking in lib dir of the built tarball.
2017-12-07 18:06:33 -08:00
huaxiangsun f34648e464 HBASE-19163 Maximum lock count exceeded from region server's batch processing
Signed-off-by: Michael Stack <stack@apache.org>
2017-12-07 14:13:19 -08:00
Zach York a39d5bed1b HBASE-19435 Reopen Files for ClosedChannelException in BucketCache
Signed-off-by: tedyu <yuzhihong@gmail.com>
2017-12-07 10:53:26 -08:00
BELUGA BEHR c3743be05c HBASE-19448 Replace StringBuffer with StringBuilder for hbase-server
Signed-off-by: Chia-Ping Tsai <chia7712@gmail.com>
2017-12-07 22:52:43 +08:00
Michael Stack 8dc82165f3
HBASE-19301 Provide way for CPs to create short circuited connection
with custom configurations; ADDENDUM -- adds warning to powerful new,

Signed-off-by: anoopsamjohn <anoopsamjohn@gmail.com>
2017-12-07 06:39:12 -08:00
Chia-Ping Tsai 2245dfc558 HBASE-12444 Total number of requests overflow because it's int 2017-12-07 18:42:32 +08:00
anoopsamjohn f8e2323323 HBASE-19357 Bucket cache no longer L2 for LRU cache. 2017-12-07 15:06:30 +05:30
Chia-Ping Tsai 4833e63d17 HBASE-19430 Remove the SettableTimestamp and SettableSequenceId 2017-12-07 13:34:38 +08:00
Andrew Purtell e7a2e4352c HBASE-19447 INFO level logging of GetClusterStatus from HMaster is too chatty 2017-12-06 17:06:34 -08:00
Michael Stack d29ffd4e29 HBASE-19295 The Configuration returned by CPEnv should be read-only.
Adds a ReadOnlyConfiguration that delegates gets but throws exception
on sets/adds, etc.
2017-12-06 15:18:53 -08:00
tedyu 497902731a HBASE-19417 Remove boolean return value from postBulkLoadHFile hook 2017-12-06 14:23:22 -08:00
Michael Stack 52ffa68f8b
HBASE-15628 Implement an AsyncOutputStream which can work with any FileSystem implementation; ADDENDUM -- Change Log output 2017-12-06 11:36:20 -08:00
TAK LON WU b2f9b7bc19 HBASE-19023 Replace hbase-server with hbase-mapreduce for HBase and MapReduce chapter
RowCounter and other related HBase's MapReduce classes have been moved
to hbase-mapreduce component by HBASE-18640, related chapter was
out-of-date and this fix replaced hbase-server with hbase-mapreduce
to correct those commands

Also this change moved RowCounter_Counters.properties
to hbase-mapreduce package as well

JIRA https://issues.apache.org/jira/browse/HBASE-19023

Signed-off-by: tedyu <yuzhihong@gmail.com>
2017-12-06 09:04:02 -08:00
Chia-Ping Tsai b9f1f5a17c HBASE-18112 (addendum) fix the out-of-bounds index 2017-12-06 22:01:12 +08:00
zhangduo 03cb581585 HBASE-19410 Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests 2017-12-06 16:38:58 +08:00
anoopsamjohn 78a6e0532e Revert "HBASE-19357 Bucket cache no longer L2 for LRU cache."
This reverts commit d952c5df9f.
2017-12-06 11:36:19 +05:30
anoopsamjohn d952c5df9f HBASE-19357 Bucket cache no longer L2 for LRU cache. 2017-12-06 11:26:10 +05:30
Michael Stack e048b2cbdb
HBASE-19323 Make netty engine default in hbase2 2017-12-05 15:29:57 -08:00
Michael Stack c77778dd13
HBASE-19426 Move has() and setTimestamp() to Mutation (Chia-Ping Tsai)
Signed-off-by: Chia-Ping Tsai <chia7712@gmail.com>
2017-12-05 09:42:13 -08:00
Michael Stack db49391683 HBASE-19384 Results returned by preAppend hook in a coprocessor are replaced with
null from other coprocessor even on bypass

If 'bypass' is set by a Coprocessor, skip out on calling any subsequent
Coprocessors that might be chained to a bypassable method.

This patch restores some of the 'complete' behavior removed by
HBASE-19123 only 'bypass' now triggers 'complete'.
2017-12-05 08:07:23 -08:00
Ted Yu b906980e14 HBASE-19056 TestCompactionInDeadRegionServer is top of the flakies charts!
Signed-off-by: zhangduo <zhangduo@apache.org>
2017-12-04 14:13:49 +08:00
zhangduo c61ed5dc7e HBASE-19399 Purge curator dependency from hbase-client 2017-12-03 08:30:43 +08:00
Chia-Ping Tsai 5f8b459cc1 HBASE-19408 Remove WALActionsListener.Base 2017-12-03 01:17:03 +08:00
Chia-Ping Tsai a5853221b4 HBASE-19339 Eager policy results in the negative size of memstore 2017-12-03 00:50:25 +08:00
Guanghao Zhang 6c6910b0b4 HBASE-19396 Fix flaky test TestHTableMultiplexerFlushCache 2017-12-02 20:05:59 +08:00
Andrew Purtell 99790a52ae HBASE-19406 Fix CompactionRequest equals and hashCode 2017-12-01 19:15:11 -08:00
Josh Elser fa5473c299 HBASE-19285 Implements table-level latency histograms
For a egionserver's view of a table (the regions
that belong to a table hosted on a regionserver),
this change tracks the latencies of operations that
affect the regions for this table.

Tracking at the per-table level avoids the memory bloat
and performance impact that accompanied the previous
per-region latency metrics while still providing important
details for operators to consume.

Signed-Off-By: Andrew Purtell <apurtell@apache.org>
2017-12-01 17:34:43 -05:00
Guangxu Cheng 01d366da4a HBASE-19326 Remove decommissioned servers from rsgroup
Signed-off-by: Michael Stack <stack@apache.org>

Conflicts:
	hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminEndpoint.java
2017-12-01 11:12:34 -08:00
Michael Stack 752be198e7 HBASE-19392 TestReplicaWithCluster#testReplicaGetWithPrimaryAndMetaDown failure in master
Signed-off-by: Huaxiang Sun <hsun@apache.org>
2017-11-30 22:46:00 -08:00
zhangduo df3668818d HBASE-19344 improve asyncWAL by using Independent thread for netty #IO in FanOutOneBlockAsyncDFSOutput 2017-12-01 11:19:09 +08:00
Harshal Deepakkumar Jain 49eaa7a8f9 HBASE-19388 - Incorrect value is being set for Compaction Pressure in RegionLoadStats object inside HRegion class
Signed-off-by: tedyu <yuzhihong@gmail.com>
2017-11-30 08:48:27 -08:00
Toshihiro Suzuki 29079886ca HBASE-18112 Write RequestTooBigException back to client for NettyRpcServer
Signed-off-by: zhangduo <zhangduo@apache.org>
2017-11-30 17:07:22 +08:00
zhangduo e2e08866f6 HBASE-19346 Use EventLoopGroup to create AsyncFSOutput 2017-11-30 15:23:22 +08:00
Michael Stack 0e6f1a0240 HBASE-19385 [1.3] TestReplicator failed 1.3 nightly 2017-11-29 23:13:25 -08:00
Apekshit Sharma 4f4aac77e1 HBASE-19367 Refactoring in RegionStates, and RSProcedureDispatcher
- Adding javadoc comments
- Bug: ServerStateNode#regions is HashSet but there's no synchronization to prevent concurrent addRegion/removeRegion. Let's use concurrent set instead.
- Use getRegionsInTransitionCount() directly to avoid instead of getRegionsInTransition().size() because the latter copies everything into a new array - what a waste for just the size.
- There's mixed use of getRegionNode and getRegionStateNode for same return type - RegionStateNode. Changing everything to getRegionStateNode. Similarly rename other *RegionNode() fns to *RegionStateNode().
- RegionStateNode#transitionState() return value is useless since it always returns it's first param.
- Other minor improvements
2017-11-29 22:42:39 -08:00
Guanghao Zhang 9e7ab9ffe2
HBASE-19359 Revisit the default config of hbase client retries number 2017-11-29 10:33:20 -08:00
zhangduo 22b90c4a64
HBASE-19372 Remove the Span object in SyncFuture as it is useless now
Signed-off-by: Michael Stack <stack@apache.org>
2017-11-29 09:13:02 -08:00
binlijin 64ddce303e HBASE-19290 Reduce zk request when doing split log 2017-11-29 18:43:41 +08:00
Jerry He 0c4c395538 HBASE-19096 Add RowMutions batch support in AsyncTable
Signed-off-by: Jerry He <jerryjch@apache.org>
2017-11-28 18:49:08 -08:00
zhangduo 8688da9e9c HBASE-17049 Do not issue sync request when there are still entries in ringbuffer 2017-11-29 10:19:53 +08:00
Balazs Meszaros e946d9d841
HBASE-19242 Add MOB compact support for AsyncAdmin
Signed-off-by: Michael Stack <stack@apache.org>
Signed-off-by: Guanghao Zhang <zghaobac@gmail.com>
2017-11-28 15:04:56 -08:00
Peter Somogyi 1447956846 HBASE-19363 Tests under TestCheckAndMutate are identical
Remove testCheckAndMutateUsingNewComparisonOperatorInstead

Signed-off-by: Michael Stack <stack@apache.org>
2017-11-28 12:19:13 -08:00
Josh Elser 4fef4cfc30 HBASE-19267 Remove compiler-plugin mapping executions as it breaks Java8 detection
It seems like the original reason this execution filter was added is no
longer an issue for 2.0. Actually, these entries actually preclude
Eclipse from correctly using the Java8 source/target version that we
have specified (which creates numerous compilation errors in Eclipse)

Signed-off-by: Guanghao Zhang <zghao@apache.org>
2017-11-28 14:54:32 -05:00
Peter Somogyi 12efae4829 HBASE-19351 Deprecated is missing in Table implementations
Signed-off-by: Michael Stack <stack@apache.org>
2017-11-28 11:18:07 -08:00
Chia-Ping Tsai 8b6f305ac7 HBASE-19342 fix TestTableBasedReplicationSourceManagerImpl#testRemovePeerMetricsCleanup 2017-11-28 18:12:55 +08:00
Balazs Meszaros ed16667208
HBASE-19328 Remove asked if splittable log messages
Signed-off-by: Michael Stack <stack@apache.org>
Signed-off-by: Chia-Ping Tsai <chia7712@gmail.com>
2017-11-27 21:07:59 -08:00
binlijin a62010c9e7 HBASE-19338 Performance regression in RegionServerRpcQuotaManager to get ugi 2017-11-28 09:58:39 +08:00
Apekshit Sharma 0384561423 HBASE-19335 Fix waitUntilAllRegionsAssigned(). Ignore assignments to killed servers and when region state != OPEN.
Update timeouts for TestRegionObserverInterface.
Reason: There are ~10 tests there, each with 5 min individual timeout. Too much. The test class is labelled MediumTests,
let's used that with our standard CategoryBasedTimeout. 3 min per test function should be enough even on slower Apache machines.
2017-11-27 16:25:54 -08:00
Balazs Meszaros 95e4f059a3 HBASE-18601 Update Htrace to 4.2 (addendum)
- TraceTree fix

Signed-off-by: Chia-Ping Tsai <chia7712@gmail.com>
2017-11-28 06:59:30 +08:00
Josh Elser e42d20f8dd HBASE-19318 Use the PB service interface as the judge of whether some security feature exists
Hard-coded checks on HBase implementations (e.g. AccessController and
VisibilityController) preclude custom implementations of authorization
and visibility labels (Apache Ranger).

Signed-off-by: Ted Yu <tedyu@apache.org>
2017-11-27 17:49:41 -05:00
Apekshit Sharma 96e63ac7b8 HBASE-19319 Fix bug in synchronizing over ProcedureEvent
Also moves event related functions (wake/wait/suspend) from ProcedureScheduler to ProcedureEvent class
2017-11-27 12:06:07 -08:00