Commit Graph

141 Commits

Author SHA1 Message Date
Jonathan M Hsieh 09a00efc0b Merge remote-tracking branch 'apache/master' (5/19/15) into hbase-11339
Patches that caused deltas:
HBASE-10810 - around HColumnDescriptor 'should' vs 'is' api.
HBASE-11677 - LOG was made private
HBASE-11927 - Checksum constant changed
HBASE-10800 - CellComparator instead of KVComparator

Conflicts:
	hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/DeleteTableHandler.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreEngine.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/DefaultCompactor.java
	hbase-server/src/test/java/org/apache/hadoop/hbase/util/LoadTestTool.java
2015-05-19 16:30:21 -07:00
Enis Soztutar 59a6e031fb HBASE-13661 Correct binary compatibility issues discovered in 1.1.0RC0 2015-05-11 18:28:29 -07:00
Jonathan M Hsieh 0e20bbf6a3 Merge branch 'apache/master' (4/16/15) into hbase-11339
API conflicts and test fixes
Update LoadTestTool.COLUMN_FAMILY -> DEFAULT_COLUMN_FAMILY due HBASE-11842
Use new 1.0+ api in some tests
Use updated Scanners internal api
Fix to take into account  HBASE-13203 - procedure v2 table delete

Conflicts:
	hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
	hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java
2015-05-01 08:18:51 -07:00
Elliott Clark 2c5dc53a32 HBASE-13477 Create metrics on failed requests
Summary: Add metrics on how many requests are exceptions and what type.

Test Plan: behold unit tests.

Differential Revision: https://reviews.facebook.net/D37167
2015-04-17 15:37:31 -07:00
tedyu 64941c6151 HBASE-13369 Expose scanNext stats to region server level 2015-03-31 15:25:36 -07:00
tedyu 619d34487e HBASE-13213 Split out locality metrics among primary and secondary region 2015-03-31 15:16:08 -07:00
Elliott Clark 55a5a3be33 HBASE-13364 Make error prone off by default 2015-03-30 16:03:53 -07:00
nke 18256fc954 HBASE-8725 Add total time RPC call metrics
Signed-off-by: Elliott Clark <eclark@apache.org>
2015-03-26 11:11:53 -07:00
Josh Elser 72855c584e HBASE-13236 Add addt'l lifecycle-mapping executions.
Adds a number of lifecycle-mapping entries which
prevent errors from showing up in Eclipse on a fresh
import of HBase. For plugins defined in the top-level
pom, the mapping is added there; otherwise, the mapping
is pushed down to the child pom.

Signed-off-by: Sean Busbey <busbey@apache.org>
2015-03-13 22:35:52 -05:00
Misty Stanley-Jones 39425a8558 HBASE-11670 Generate PDF of Reference Guide 2015-03-05 09:31:11 +10:00
Jonathan M Hsieh fe335b683c Merge branch 'master' (2/11/15) into hbase-11339
Conflicts:
	hbase-client/src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java
	hbase-client/src/test/java/org/apache/hadoop/hbase/TestHColumnDescriptor.java
	hbase-common/src/main/java/org/apache/hadoop/hbase/TagType.java
	hbase-common/src/main/resources/hbase-default.xml
	hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapper.java
	hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSourceImpl.java
	hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestAcidGuarantees.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/io/HFileLink.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/DeleteTableHandler.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/DisabledTableSnapshotHandler.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreEngine.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperImpl.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/DefaultCompactor.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/StripeCompactor.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/ExportSnapshot.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/RestoreSnapshotHelper.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotReferenceUtil.java
	hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperStub.java
	pom.xml
	src/main/docbkx/book.xml
	src/main/docbkx/ops_mgt.xml
	src/main/docbkx/schema_design.xml
2015-02-22 12:54:45 -08:00
Andrew Purtell cecc475d2f HBASE-12102 Duplicate keys in HBase.RegionServer metrics JSON (Ravi Kishore Valeti) 2015-02-18 08:08:46 -08:00
Ashish Singhi 16ed345191 HBASE-9531 a command line (hbase shell) interface to retreive the replication metrics and show replication lag
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2015-02-12 14:50:01 -08:00
Sean Busbey 418ea93774 HBASE-12898 ensure direct dependencies are declared. 2015-01-22 14:33:25 -06:00
Misty Stanley-Jones 1a21c1684c HBASE-11533 Asciidoc Proof of Concept 2015-01-13 22:32:29 -08:00
Lars Hofhansl 7774f964e6 HBASE-12779 SplitTransaction: Add metrics. 2015-01-05 17:13:58 -08:00
Esteban Gutierrez b2eea8cac6 HBASE-12695 JDK 1.8 compilation broken
Signed-off-by: stack <stack@apache.org>
2014-12-29 11:02:04 -08:00
Sean Busbey a6093139eb HBASE-12661 add missing licenses. 2014-12-09 09:51:55 -06:00
Elliott Clark da0e807dd3 HBASE-12574 Update replication metrics to not do so many map look ups. 2014-12-08 10:35:57 -08:00
Elliott Clark 29ee0cb0e1 HBASE-12576 Add metrics for rolling the HLog if there are too few DN's in the write pipeline 2014-12-02 09:30:52 -08:00
Ramkrishna 7aea38118e HBASE-12489 Incorrect 'mobFileCacheMissCount' calculated in the mob
metrics (Li Jiajia)
2014-11-20 10:29:06 +05:30
Andrew Purtell 22f29ca8ef HBASE-12496 A blockedRequestsCount metric (Yi Deng) 2014-11-18 14:14:31 -08:00
stack b94e6738d9 HBASE-10378 Refactor write-ahead-log implementation -- ADDEDNUM 2014-11-18 12:12:35 -08:00
Andrew Purtell 1ba615657b HBASE-12382 Restore incremental compilation 2014-11-11 17:45:37 -08:00
stack 804444f892 HBASE-12455 Add 'description' to bean and attribute output when you do /jmx?description=true 2014-11-11 12:59:43 -08:00
Andrew Purtell 7718390703 HBASE-12424 Finer grained logging and metrics for split transactions 2014-11-07 11:32:01 -08:00
Jonathan M Hsieh e5a1b86dba HBASE-11683 Metrics for MOB (Jingcheng Du) 2014-10-30 06:50:13 -07:00
Andrew Purtell 70a312e53f HBASE-11912 Catch some bad practices at compile time with error-prone 2014-10-27 09:29:23 -07:00
Andrew Purtell ff5bc351b2 Revert "HBASE-11912 Catch some bad practices at compile time with error-prone"
This reverts commit 7ed0260eff.
2014-10-25 08:33:43 -07:00
Andrew Purtell 7ed0260eff HBASE-11912 Catch some bad practices at compile time with error-prone 2014-10-24 18:15:12 -07:00
stack 31c185aad5 HBASE-12328 Need to separate JvmMetrics for Master and RegionServer (Sanghyun Yun) 2014-10-23 21:49:47 -07:00
stack 06a8bb5bd1 HBASE-12189 Fix new issues found by coverity static analysis 2014-10-09 20:51:04 -07:00
stack d5be58dfd2 Add hedgedReads and hedgedReadWins count metrics 2014-10-09 15:00:25 -07:00
Elliott Clark 0a28af366b HBASE-12076 Move InterfaceAudience imports to hbase-annotations 2014-09-24 03:57:55 -07:00
Elliott Clark a5bd931682 HBASE-12059 Create hbase-annotations module 2014-09-23 16:44:14 -07:00
stack 3c9bd7d296 HBASE-11911 Break up tests into more fine grained categories (Alex Newman) 2014-09-12 21:37:06 -07:00
stack f96dc97612 HBASE-11816 Initializing custom Metrics implementation failed in Mapper or Reducer 2014-08-25 12:27:09 -07:00
Andrew Purtell 6367074381 HBASE-11702 Better introspection of long running compactions 2014-08-14 09:12:52 -07:00
Andrew Purtell 19e9b8aa52 HBASE-11516 Track time spent in executing coprocessors in each region (Srikanth Srungarapu and Andrew Purtell) 2014-08-01 09:37:56 -07:00
stack 6da1a485fc HBASE-11463 (findbugs) HE: Class defines equals() and uses Object.hashCode() 2014-07-03 21:54:28 -07:00
Enis Soztutar 92c52a727a Updated version in master to 2.0.0-SNAPSHOT after 'branch-1' is created for 1.x line of releases 2014-06-30 20:26:47 -07:00
Ted Yu afbe165676 HBASE-11267 Dynamic metrics2 metrics may consume large amount of heap memory 2014-05-30 14:00:32 +00:00
liangxie e1d16e9892 Amend HBASE-10561 Forward port: HBASE-10212 New rpc metric: number of active handler
git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1594126 13f79535-47bb-0310-9956-ffa450edef68
2014-05-13 05:06:14 +00:00
Jean-Daniel Cryans 205654d818 HBASE-10755 MetricsRegionSourceImpl creates metrics that start with a lower case
git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1578647 13f79535-47bb-0310-9956-ffa450edef68
2014-03-17 22:37:25 +00:00
Jonathan Hsieh fb349b084e HBASE-10436 restore regionserver lists removed from hbase 0.96.0 jmx
git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1571887 13f79535-47bb-0310-9956-ffa450edef68
2014-02-26 01:02:00 +00:00
mbertozzi e541b46b63 HBASE-10586 hadoop2-compat IPC metric registred twice
git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1570737 13f79535-47bb-0310-9956-ffa450edef68
2014-02-21 22:47:41 +00:00
Michael Stack 013c6a6285 HBASE-10407 String Format Exception (Siwakorn Srisakaokul)
git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1562364 13f79535-47bb-0310-9956-ffa450edef68
2014-01-29 06:06:16 +00:00
ndimiduk a8ec7232cc HBASE-9343 Implement stateless scanner for Stargate (Vandana Ayyalasomayajula)
git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1558994 13f79535-47bb-0310-9956-ffa450edef68
2014-01-17 02:31:00 +00:00
eclark 1e0185468c HBASE-10124 Make Sub Classes Static When Possible
git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1550294 13f79535-47bb-0310-9956-ffa450edef68
2013-12-11 22:20:00 +00:00
Michael Stack 3f58873f08 HBASE-10048 Add hlog number metric in regionserver
git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1548768 13f79535-47bb-0310-9956-ffa450edef68
2013-12-07 00:32:59 +00:00
Andrew Kyle Purtell f8139d1bf5 Update version in POMs to 0.99.0-SNAPSHOT after branching for release 0.98.0
git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1547743 13f79535-47bb-0310-9956-ffa450edef68
2013-12-04 09:31:02 +00:00
Michael Stack 74f6e25c8f HBASE-5945 Reduce buffer copies in IPC server response path
git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1543458 13f79535-47bb-0310-9956-ffa450edef68
2013-11-19 15:39:35 +00:00
eclark 22b77dc791 HBASE-9653 Add compaction metrics to trunk
git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1526314 13f79535-47bb-0310-9956-ffa450edef68
2013-09-25 21:44:33 +00:00
eclark e0768e0814 HBASE-9650 Per region metrics are not showing up for system tables.
git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1526309 13f79535-47bb-0310-9956-ffa450edef68
2013-09-25 21:41:05 +00:00
Jonathan Hsieh d2ddf0986a HBASE-9579 Sanity check visiblity and audience for server-side modules
git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1525055 13f79535-47bb-0310-9956-ffa450edef68
2013-09-20 17:09:39 +00:00
nkeywal 1eb261ab42 HBASE-9558 PerformanceEvaluation is in hbase-server, and creates a dependency to MiniDFSCluster
git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1524985 13f79535-47bb-0310-9956-ffa450edef68
2013-09-20 13:02:54 +00:00
eclark 01bdee029a HBASE-9194 Break HMaster metrics into multiple contexts
git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1514513 13f79535-47bb-0310-9956-ffa450edef68
2013-08-15 22:04:24 +00:00
Michael Stack 34c8e0ab16 HBASE-8224 Publish hbase build against h1 and h2 adding '-hadoop1' or '-hadoop2' to version string
git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1509813 13f79535-47bb-0310-9956-ffa450edef68
2013-08-02 19:01:34 +00:00
Michael Stack e07dedcdec HBASE-8689 Cover all mutations rather than only Put while reporting for mutations not writing to WAL
git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1493307 13f79535-47bb-0310-9956-ffa450edef68
2013-06-15 04:23:24 +00:00
Michael Stack 998296008a HBASE-8564 TestMetricsRegionServer depends on test order; ADDENDUM
git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1484052 13f79535-47bb-0310-9956-ffa450edef68
2013-05-18 03:23:13 +00:00
eclark b3c97c3e3e HBASE-8564 TestMetricsRegionServer depends on test order
git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1483617 13f79535-47bb-0310-9956-ffa450edef68
2013-05-17 00:28:50 +00:00
Michael Stack cb53db35f3 HBASE-7006 [MTTR] Improve Region Server Recovery Time - Distributed Log Replay
git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1482675 13f79535-47bb-0310-9956-ffa450edef68
2013-05-15 04:24:02 +00:00
sershe 5b81ff6045 HBASE-8474 there are dups in hadoop2 pom
git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1478120 13f79535-47bb-0310-9956-ffa450edef68
2013-05-01 17:54:49 +00:00
eclark b33878f6fc HBASE-8426 Opening a region failed on Metrics source RegionServer,sub=Regions already exists
git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1477247 13f79535-47bb-0310-9956-ffa450edef68
2013-04-29 18:17:37 +00:00
Jonathan Hsieh 026779686f HBASE-8429 TestMetricsWALSourceImpl from hbase-hadoop2-compat module missing Apache license
git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1471777 13f79535-47bb-0310-9956-ffa450edef68
2013-04-24 23:33:08 +00:00
eclark 1c81734163 HBASE-7255 KV size metric went missing from StoreScanner.
git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1467485 13f79535-47bb-0310-9956-ffa450edef68
2013-04-12 21:47:19 +00:00
mbertozzi 8465f20316 HBASE-7615 Add metrics for snapshots
git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1464441 13f79535-47bb-0310-9956-ffa450edef68
2013-04-04 11:10:56 +00:00
Michael Stack 91ded8af10 HBASE-8263 Master LogSplitting metrics update wrong counters
git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1464268 13f79535-47bb-0310-9956-ffa450edef68
2013-04-04 03:05:41 +00:00
Zhihong Yu b16e84e632 HBASE-7871 HBase can be stuck when closing regions concurrently (Ted Yu)
git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1464012 13f79535-47bb-0310-9956-ffa450edef68
2013-04-03 13:51:01 +00:00
Michael Stack 00f7bb46c5 HBASE-8187 trunk/0.95 tarball packaging
git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1462606 13f79535-47bb-0310-9956-ffa450edef68
2013-03-29 18:49:42 +00:00
Michael Stack 466902ffde HBASE-8101 Cleanup: findbugs and javadoc warning fixes as well as making it illegal passing null row to Put/Delete, etc.
git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1457024 13f79535-47bb-0310-9956-ffa450edef68
2013-03-15 17:11:32 +00:00
nkeywal 62d1ad5fde HBASE-7968 Packaging of Trunk and 0.95 does not create the dependent jars in the lib folder
git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1452261 13f79535-47bb-0310-9956-ffa450edef68
2013-03-04 11:30:49 +00:00
Michael Stack 05711f7553 HBASE-7940 Upgrade version to 0.97-SNAPSHOT in pom.xml files
git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1450337 13f79535-47bb-0310-9956-ffa450edef68
2013-02-26 18:26:28 +00:00
Michael Stack 778ab055a0 HBASE-7356 Fix all javadoc warnings in all modules but hbase-server
git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1422134 13f79535-47bb-0310-9956-ffa450edef68
2012-12-14 22:37:55 +00:00
eclark a23ecdae14 HBASE-7262 Move HBaseRPC metrics to metrics2
git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1419962 13f79535-47bb-0310-9956-ffa450edef68
2012-12-11 01:12:46 +00:00
eclark abd334265e HBASE-7265 Make Maven skip module test properties consistent
git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1416723 13f79535-47bb-0310-9956-ffa450edef68
2012-12-03 23:17:29 +00:00
Michael Stack 489726957e HBASE-7253 CompactionTool
git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1416657 13f79535-47bb-0310-9956-ffa450edef68
2012-12-03 20:35:58 +00:00
eclark 7dc5908e6b HBASE-7220 Creating a table with 3000 regions on 2 nodes fails after 1 hour
git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1415016 13f79535-47bb-0310-9956-ffa450edef68
2012-11-29 01:12:55 +00:00
eclark 7fdc889169 HBASE-7062 Move HLog stats to metrics 2
git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1411337 13f79535-47bb-0310-9956-ffa450edef68
2012-11-19 18:04:53 +00:00
eclark 3900978ffe HBASE-6410 Move RegionServer Metrics to metrics2
git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1406396 13f79535-47bb-0310-9956-ffa450edef68
2012-11-06 23:22:01 +00:00
Michael Stack 6b82ddc911 HBASE-6926 Cleanup some of the javadoc warnings
git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1393168 13f79535-47bb-0310-9956-ffa450edef68
2012-10-02 20:42:55 +00:00
Michael Stack 8c393a32a8 HBASE-6848 Make hbase-hadoop-compat findbugs clean
git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1388252 13f79535-47bb-0310-9956-ffa450edef68
2012-09-20 22:51:30 +00:00
Michael Stack 1afea63673 HBASE-6501 Integrate with unit-testing tools of hadoop's metrics2 framework
git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1387820 13f79535-47bb-0310-9956-ffa450edef68
2012-09-19 23:44:59 +00:00
Michael Stack 053fc8e7ba HBASE-6409 Create histogram class for metrics 2
git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1387358 13f79535-47bb-0310-9956-ffa450edef68
2012-09-18 20:54:06 +00:00
Michael Stack 2627730b7d HBASE-6412 Move external servers to metrics2 (thrift,thrift2,rest)
git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1387323 13f79535-47bb-0310-9956-ffa450edef68
2012-09-18 19:10:03 +00:00
Michael Stack 773650bb0c HBASE-6706 Remove TotalOrderPartitioner
git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1381881 13f79535-47bb-0310-9956-ffa450edef68
2012-09-07 05:28:31 +00:00
Michael Stack b815812863 HBASE-4050 Clean up BaseMetricsSourceImpl
git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1381008 13f79535-47bb-0310-9956-ffa450edef68
2012-09-05 05:58:03 +00:00
Michael Stack 93e03d7d09 HBASE-4050 Combine Master Metrics into a single class
git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1377896 13f79535-47bb-0310-9956-ffa450edef68
2012-08-27 22:39:23 +00:00
Zhihong Yu efe471f74b HBASE-6411 Move Master Metrics to metrics 2 (Alex Baranau)
git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1368598 13f79535-47bb-0310-9956-ffa450edef68
2012-08-02 16:58:35 +00:00
Zhihong Yu 92ed1401b7 HBASE-6405 Addendum for Eclipse (Jesse Yates)
git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1363201 13f79535-47bb-0310-9956-ffa450edef68
2012-07-19 01:41:01 +00:00
Zhihong Yu c863b51baa HBASE-6405 Create Hadoop compatibilty modules and Metrics2 implementation of replication metrics (Elliot Clark)
git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1362681 13f79535-47bb-0310-9956-ffa450edef68
2012-07-17 22:02:06 +00:00