17228 Commits

Author SHA1 Message Date
Mingliang Liu
96fd75bd0e HBASE-22607. TestExportSnapshotNoCluster fails intermittently 2019-11-20 07:47:46 -08:00
belugabehr
33bedf8d4d HBASE-23308: Review of NullPointerExceptions (#836)
Signed-off-by: stack <stack@apache.org>
2019-11-19 13:51:11 -08:00
stack
ca6e67a6de HBASE-23315 Miscellaneous HBCK Report page cleanup
* Add a bit of javadoc around SerialReplicationChecker.
 * Miniscule edit to the profiler jsp page and then a bit of doc on how to make it work that might help.
 * Add some detail if NPE getting BitSetNode to help w/ debug.
 * Change HbckChore to log region names instead of encoded names; helps doing diagnostics; can take region name and query in shell to find out all about the region according to hbase:meta.
 * Add some fix-it help inline in the HBCK Report page – how to fix.
 * Add counts in procedures page so can see if making progress; move listing of WALs to end of the page.
2019-11-19 07:34:24 -08:00
Baiqiang Zhao
e83bb205f4 HBASE-23278 Add a table-level compaction progress display on the UI (#816)
Signed-off-by: Guangxu Cheng <gxcheng@apache.org>
2019-11-19 16:21:36 +08:00
Andrew Purtell
3ba71fe589
HBASE-23318 LoadTestTool doesn't start (#848)
* Package the test jar from hbase-zookeeper into lib/

Signed-off-by: Duo Zhang <zhangduo@apache.org>
2019-11-18 16:49:11 -08:00
Duo Zhang
4b99816dd6
HBASE-23182 The create-release scripts are broken (#736)
Signed-off-by: stack <stack@apache.org>
Signed-off-by: Bharath Vissapragada <bharathv@apache.org>
2019-11-19 08:28:43 +08:00
stack
f8f9a26cb3 HBASE-23282 HBCKServerCrashProcedure for 'Unknown Servers'
Have the existing scheduleRecoveries launch a new HBCKSCP
instead of SCP. It gets regions to recover from Master
in-memory context AND from a scan of hbase:meta. This
new HBCKSCP is For processing 'Unknown Servers', servers that
are 'dead' and purged but still have references in
hbase:meta. Rare occurance but needs tooling to address.
Later have catalogjanitor take care of these deviations
between Master in-memory and hbase:meta content (usually
because of overdriven cluster with failed RPCs to hbase:meta,
etc)

Changed expireServers in ServerManager so could pass in
custom reaction to expired server.... This is how we
run our custom HBCKSCP while keeping all other aspects
of expiring services (rather than try replicate it
externally).
2019-11-18 14:28:55 -08:00
Mingliang Liu
8bfdfe1b85 HBASE-23289 Update links to Hadoop wiki in book and code
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
2019-11-18 08:58:07 -08:00
Udai Bhan Kashyap
b5e8727617 HBASE-22969 A new binary component comparator(BinaryComponentComparator) to perform comparison of arbitrary length and position (#829)
Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
2019-11-18 13:28:06 +01:00
belugabehr
a3efa5911d HBASE-23102: Improper Usage of Map putIfAbsent (#828)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
2019-11-17 10:13:52 +00:00
Sean Busbey
b292ffd14d HBASE-19450 Addendum Limit logging of chore execution time at INFO to once per 5 minutes.
* Ensure MovingAverage related classes are IA.Private
* Move trace logging into MovingAverage class

Signed-off-by: Duo Zhang <zhangduo@apache.org>
2019-11-16 09:38:44 -06:00
Duo Zhang
e60764f5a1
HBASE-23294 ReplicationBarrierCleaner should delete all the barriers for a removed region which does not belong to any serial replication peer (#827)
Signed-off-by: stack <stack@apache.org>
2019-11-15 18:59:51 +08:00
Reid Chan
67f9afc722 HBASE-19450 Add log about average execution time for ScheduledChore
Signed-off-by: Sean Busbey <busbey@apache.org>
2019-11-14 21:50:08 -06:00
Mingliang Liu
73f3e1d4a4 HBASE-23283 Provide clear and consistent logging about the period of enabled chores
Signed-off-by: Sean Busbey <busbey@apache.org>
2019-11-14 20:32:10 -06:00
Mingliang Liu
4cc899d8e3 HBASE-23290 shell processlist command is broken 2019-11-14 16:03:29 -08:00
Mingliang Liu
1d6f50fd86 HBASE-23284 Fix Hadoop wiki link in Developer guide to "Distributions and Commercial Support"
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
2019-11-13 10:17:19 -08:00
Viraj Jasani
9494c12e35 HBASE-23245 : MutableHistogram constructor changes and provide HistogramImpl maxExpected as long (#787)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Xu Cang <xucang@apache.org> 
Signed-off-by: Guangxu Cheng <gxcheng@apache.org>
2019-11-12 00:22:02 +08:00
Geoffrey Jacoby
77490f815a HBASE-23251 - Add Column Family and Table Names to HFileContext and use in HFileWriterImpl logging (#796)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Xu Cang <xucang@apache.org>
Signed-off-by: Zheng Hu <openinx@gmail.com>
2019-11-11 16:18:43 +08:00
ravowlga123
08aae42156 HBASE-18439 Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
Signed-off-by: Guangxu Cheng <gxcheng@apache.org>
2019-11-08 18:56:21 +01:00
Sean Busbey
d5dcc090c1
HBASE-23228 Allow for jdk8 specific modules on branch-1 in precommit/nightly testing (#804)
Signed-off-by: Josh Elser <elserj@apache.org>
2019-11-08 10:07:24 -06:00
Daisuke Kobayashi
2c1d500828 HBASE-23268 Remove disable/enable ops from doc when altering schema
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
2019-11-08 10:47:08 +00:00
chenxu14
34661050c8 HBASE-22888 Share some stuffs with the initial reader when new stream reader created (#581)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2019-11-08 13:54:53 +08:00
Duo Zhang
b53e9a325c HBASE-23236 Upgrade to yetus 0.11.1
Signed-off-by: stack <stack@apache.org>
2019-11-08 13:47:54 +08:00
Bharath Vissapragada
c2e01f2398 HBASE-23257: Track clusterID in stand by masters (#798)
This patch implements a simple cache that all the masters
can lookup to serve cluster ID to clients. Active HMaster
is still responsible for creating it but all the masters
will read it from fs to serve clients.

RPCs exposing it will come in a separate patch as a part of
HBASE-18095.

Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Signed-off-by: Guangxu Cheng <guangxucheng@gmail.com>
2019-11-08 10:32:44 +08:00
Karthik Palanisamy
264d3e3b16 HBASE-23263 NPE in Quotas.jsp (#800)
Signed-off-by: Guangxu Cheng <guangxucheng@gmail.com>
2019-11-08 09:55:57 +08:00
Karthik Palanisamy
c348e642d9 HBASE-23262 Cannot load Master UI (#799)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2019-11-08 09:49:35 +08:00
lijinbin
02f264321b HBASE-22480 Get block from BlockCache once and return this block to BlockCache twice make ref count error. 2019-11-08 09:34:58 +08:00
Nick Dimiduk
34d5b3bf05
HBASE-23272 Fix link in Developer guide to "code review checklist" (#805)
Signed-off-by: stack <stack@apache.org>
2019-11-07 15:34:37 -08:00
Nick Dimiduk
12c19a6e51
HBASE-23230 Enforce member visibility in HRegionServer (#775)
* Clean up a bunch of private variable leakage into other
   classes. Reduces visibility as much as possible, providing getters
   where access remains necessary or making use of getters that
   already exist. There remains an insidious relationship between
   `HRegionServer` and `RSRpcServices`.
 * Rename `fs` to `dataFs`, `rootDir` as `dataRootDir` so as to
   distinguish from the new `walFs`, `walRootDir` (and make it easier
   to spot bugs).
 * Cleanup or delete a bunch of lack-luster javadoc comments.
 * Delete a handful of methods that are unused according to static
   analysis.
 * Reduces the warning count as reported by IntelliJ from 100 to 7.

Signed-off-by: stack <stack@apache.org>
2019-11-07 15:27:02 -08:00
Shardul Singh
f58bd4a7ac HBASE-22980 HRegionPartioner getPartition() method incorrectly partitions the regions of the table. (#590)
Signed-off-by: Guangxu Cheng <guangxucheng@gmail.com>
2019-11-06 22:07:44 +08:00
BukrosSzabolcs
d2142a8ebb HBASE-23085 Network and Data related Actions
Add monkey actions:
- manipulate network packages with tc (reorder, loose,...)
- add CPU load
- fill the disk
- corrupt or delete regionserver data files

Extend HBaseClusterManager to allow sudo calls.

Signed-off-by: Josh Elser <elserj@apache.org>
Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
2019-11-06 14:43:00 +01:00
Michael Stack
f0f7fae400 HBASE-21458 Error: Could not find or load main class org.apache.hadoop.hbase.util.GetJavaProperty
Signed-off-by: Sean Busbey <busbey@apache.org>
2019-11-05 22:50:16 -06:00
ravowlga123
56e63b106c HBASE-23250 Log message about CleanerChore delegate initialization should be at INFO
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
2019-11-05 20:21:16 +01:00
Viraj Jasani
10cc64a7d6 HBASE-23212 : Dynamically reload configs for Region Recovery chore (#773)
* HBASE-23212 : Dynamically reload configs for Region Recovery chore

* remove redundant volatile
2019-11-04 11:36:38 -08:00
Michael Stack
2f8860b1da HBASE-23243 [pv2] Filter out SUCCESS procedures; on decent-sized cluster, plethora overwhelms problems (#790)
Signed-off-by: GuangxuCheng  <guangxucheng@gmail.com>
Signed-off-by: Sean Busbey <busbey@apache.org>
2019-11-04 09:18:09 -08:00
Michael Stack
bbfc73789f HBASE-23247 [hbck2] Schedule SCPs for 'Unknown Servers' (#791)
Signed-off-by: Sean Busbey <busbey@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2019-11-04 09:01:56 -08:00
binlijin
90007b7e80
HBASE-23241 TestExecutorService sometimes fail (#782)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
2019-11-04 17:15:50 +08:00
stack
3ccfd50bd9 HBASE-23244 NPEs running Canary (#784)
Addendum to fix findbugs complaint.
2019-11-02 09:35:15 -07:00
Michael Stack
c58e80fbe6 HBASE-23244 NPEs running Canary (#784)
Signed-off-by: Viraj Jasani <virajjasani007@gmail.com>
2019-11-01 21:41:22 -07:00
Wellington Chevreuil
b8a4504a26 HBASE-23238 Additional test and checks for null references on ScannerCallableWithReplicas (#780)
Signed-off-by: Sean Busbey <busbey@apache.org>
(cherry picked from commit 577db5d7e50c56b4773c9ce92b807aae80bf5706 - Test only, removed changes from no more exisiting ScannerCallableWithReplicas class)
2019-11-01 12:15:41 +00:00
stack
ea5c572963 Revert "HBASE-22917 Proc-WAL roll fails saying someone else has already created log (#544)"
This reverts commit 538a4c51ff8464f57e26cc22f9c559c1a30b5864.
2019-10-31 08:10:34 -07:00
Michael Stack
e1b4a2a895 HBASE-23221 Polish the WAL interface after HBASE-23181 (#774)
Removes the closeRegion flag added by HBASE-23181 and instead
relies on reading meta WALEdit content. Modified how qualifier is
written when the meta WALEdit is for a RegionEventDescriptor
so the 'type' is added to the qualifer so can figure type
w/o having to deserialize protobuf value content: e.g.
HBASE::REGION_EVENT::REGION_CLOSE

Added doc on WALEdit and tried to formalize the 'meta' WALEdit
type and how it works. Needs complete redo in part as suggested
by HBASE-8457. Meantime, some doc and cleanup.

Also changed the LogRoller constructor to remove redundant param.
Because of constructor change, need to change also
TestFailedAppendAndSync, TestWALLockup, TestAsyncFSWAL &
WALPerformanceEvaluation.java

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Lijin Bin <binlijin@apache.org>
2019-10-31 18:52:04 +08:00
chenxu14
255be63e1d HBASE-23184 The HeapAllocation in WebUI is not accurate (#730)
Signed-off-by: stack <stack@apache.org>
2019-10-31 17:53:24 +08:00
Duo Zhang
2451c2c532 HBASE-23231 Addendum remove redundant metrics.clear in ReplicationSource
This is only a problem on master which was introduced when we merge sync replication feature branch back
2019-10-31 09:40:43 +08:00
binlijin
3152d9981b HBASE-23231 ReplicationSource do not update metrics after refresh (#778)
Signed-off-by: stack <stack@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2019-10-31 09:23:59 +08:00
Ankit Singhal
0108e57309 HBASE-23175 Yarn unable to acquire delegation token for HBase Spark jobs 2019-10-30 14:49:04 -07:00
binlijin
e808ea1d04 HBASE-22739 ArrayIndexOutOfBoundsException when balance (#729)
Signed-off-by: stack <stack@apache.org>
2019-10-30 13:28:01 -07:00
Michael Stack
54425bf87b
HBASE-23192 CatalogJanitor consistencyCheck does not log problematic row on exception (#734)
Adds logging of row and complaint if consistency check fails during CJ
checking. Adds a few more null checks. Does edit on the 'HBCK Report'
top line.

Signed-off-by: Reid Chan <reidchan@apache.org>
2019-10-30 13:10:19 -07:00
Pankaj
538a4c51ff HBASE-22917 Proc-WAL roll fails saying someone else has already created log (#544)
Signed-off-by: stack <stack@apache.org>
2019-10-30 12:58:29 -07:00
Karthik Palanisamy
0a4c0b2dd6 HBASE-23191 EOFE log spam (#733)
Convert log message added for 2.2.0 from INFO to DEBUG.

Signed-off-by: stack <stack@apache.org>
2019-10-30 12:49:04 -07:00