Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
17,677 Commits 95 Branches 866 Tags 550 MiB
Commit Graph

2373 Commits

Author SHA1 Message Date
Itsuki Toyota dfe7e27e25 HBASE-22833 MultiRowRangeFilter should provide a method for creating… (#493) 
* HBASE-22833: MultiRowRangeFilter should provide a method for creating a filter which is functionally equivalent to multiple prefix filters

* Delete superfluous comments

* Add description for MultiRowRangeFilter constructor

* Add null check for rowKeyPrefixes

* Fix checkstyle

Signed-off-by: huzheng <openinx@gmail.com>
 2019-08-16 10:06:44 +08:00
Sakthi ba55315aab HBASE-22845 Revert MetaTableAccessor#makePutFromTableState access to public (#489) 
HBCK2 is dependent on it
 2019-08-13 11:27:28 -07:00
stack 665e0ead27 Revert "HBASE-22699 refactor isMetaClearingException (#436)" 
This reverts commit cc6e157112.
 2019-08-12 11:19:42 -07:00
johnhomsea cc6e157112 HBASE-22699 refactor isMetaClearingException (#436) 
Signed-off-by: Duo Zhang <zhangduo@apache.org>
 2019-08-12 16:12:58 +08:00
syedmurtazahassan c5b29265a3
HBASE-22725 Remove all remaining Javadoc warnings 
Signed-off-by: stack <stack@apache.org>
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
 2019-08-11 22:02:53 +02:00
stack 225c6cd5bc HBASE-22777 Add a multi-region merge (for fixing overlaps) 
Makes MergeTableRegionsProcedure do more than just two regions at a
time. Compatible as MTRP was done considering one day it'd do more than
two at a time.

Changes hardcoded assumption that merge parent regions are named
mergeA and mergeB in a column on the resultant region. Instead
can have N columns on the merged region, one for each parent
merged. Column qualifiers all being with 'merge'.

Most of code below is undoing the assumption that there are two
parents on a merge only.
 2019-08-07 16:58:06 -07:00
stack c03bf73e24 HBASE-22771 [HBCK2] fixMeta method and server-side support; AMENDMENT remove mistaken .rej commit 2019-08-05 22:39:54 -07:00
stack 2bc9526080 HBASE-22771 [HBCK2] fixMeta method and server-side support 
This is a first cut at this patch. Implements hold fixing only
currently.

Add a fixMeta method to Hbck Interface.

M hbase-server/src/main/java/org/apache/hadoop/hbase/master/CatalogJanitor.java
 Bug fix. If hole is on end of last table, I wasn't seeing it.

A hbase-server/src/main/java/org/apache/hadoop/hbase/master/MetaFixer.java
 Add a general meta fixer class. Explains up top why this stuff doesn't
 belong inside MetaTableAccessor.

M hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
 Break out the filesystem messing so don't have to copy it nor do more
 than is needed doing fixup for Region holes.

M hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionFileSystem.java
 Change behavious slightly. If directory exists, don't fail as we did
 but try and keep going and create .regioninfo file if missing (or
 overwrite if in place). This should make it idempotent. Can rerun
 command. Lets see if any repercussions in test suite.

A hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMetaFixer.java
 Add test.

Signed-off-by: Zheng Hu <openinx@gmail.com>
Signed-off-by: Guanghao Zhang <zghao@apache.org>
 2019-08-05 22:33:20 -07:00
Jan Hentschel d7af4f9802
HBASE-22785 Fixed Checkstyle issues in exceptions and enhanced Javadoc 
Signed-off-by: stack <stack@apache.org>
 2019-08-05 15:08:24 +02:00
Jan Hentschel ce709de6f4
HBASE-22786 Fixed Checkstyle issues in tests in hbase-client 
Signed-off-by: stack <stack@apache.org>
 2019-08-05 11:54:11 +02:00
Wellington Chevreuil 5cd0433dc9 HBASE-22707 [HBCK2] MasterRpcServices assigns method should try to reload regions from meta if the passed regions isn't found under AssignmentManager RegionsStateStore 2019-08-01 16:56:57 +01:00
Guanghao Zhang 6a20872e01 HBASE-22737 Add a new admin method and shell cmd to trigger the hbck chore to run (#425) 
Signed-off-by: stack <stack@apache.org>
 2019-08-01 09:02:26 +08:00
Thanh NM eb700db44c HBASE-22714 - Fix opertationTimeout typo (#392) 
Signed-off-by: Duo Zhang <zhangduo@apache.org>
 2019-07-30 21:59:22 +08:00
openinx 300f906200 HBASE-22758 Remove the unneccesary info cf deletion in DeleteTableProcedure#deleteFromMeta (#424) 2019-07-30 21:37:52 +08:00
stack 4565e9f43b HBASE-22723 Have CatalogJanitor report holes and overlaps; i.e. problems it sees when doing its regular scan of hbase:meta 
Refactor of CatalogJanitor so it generates a
Report on the state of hbase:meta when it runs. Also
refactor so CJ runs even if RIT (previous it would
punt on running if RIT) so it can generate a 'Report'
on the interval regardless. If RIT, it just doesn't
go on to do the merge/split GC as it used to.

If report finds an issue, dump as a WARN message
to the master log.

Follow-on is to make the Report actionable/available
for the Master to pull when it goes to draw the hbck
UI page (could also consider shipping the Report as
part of ClusterMetrics?)

Adds new, fatter Visitor to CJ, one that generates
Report on each run keeping around more findings as
it runs.

Moved some methods around so class reads better;
previous methods were randomly ordered in the class.

M hbase-client/src/main/java/org/apache/hadoop/hbase/MetaTableAccessor.java
 Make a few handy methods public.

M hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionInfo.java
 Add utility as defaults on the Inteface; i.e. is this the first region
 in table, is it last, does a passed region come next, or does passed
 region overlap this region (added tests for this new stuff).

M hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java
 Bugfix... handle case where buffer passed is null.

M hbase-server/src/main/java/org/apache/hadoop/hbase/master/CatalogJanitor.java
 Lots of change, reorg., but mostly adding consistency checking
 to the visitor used scanning hbase:meta on a period and the
 generation of a Report on what the scan has found traversing
 hbase:meta. Added a main so could try the CatalogJanitor against
 a running cluster.

A hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitorCluster.java
 Fat ugly test for CatalogJanitor consistency checking.

M hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionInfo.java
 Add tests for new functionality in RI.

M hbase-shell/src/main/ruby/hbase/table.rb
 Bug fix for case where meta has a null regioninfo; scan was aborting.

Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
 2019-07-29 16:07:10 -07:00
Gabriel 5ab3f76a16 HBASE-22750 Correct @throws in comment.(In class org.apache.hadoop.hbase.client.RetryingCallerInterceptor) (#418) 2019-07-26 21:35:52 -07:00
Viraj Jasani 3a72ccefbd
HBASE-22648 Snapshot TTL (#371) 
Signed-off-by: Reid Chan <reidchan@apache.org>
Signed-off-by: Andrew Purtell <apurtell@apache.org>

Conflicts:
	hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotDescriptionUtils.java
 2019-07-22 15:08:20 -07:00
Guanghao 4c89354f3b HBASE-22673 Avoid to expose protobuf stuff in Hbck interface 
Signed-off-by: stack <stack@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
 2019-07-19 08:10:38 +08:00
syedmurtazahassan b6e66699a9
HBASE-22571 Javadoc Warnings related to @return tag 
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
 2019-07-13 13:48:45 +02:00
Bing Xiao 12c933ac51 HBASE-21751 WAL creation fails during region open may cause region assign forever fail 
Signed-off-by: Allan Yang <allan163@apache.org>
    Signed-off-by: Michael Stack <stack@apache.org>
 2019-07-01 22:19:42 -07:00
syedmurtazahassan 8fa7800389 HBASE-22572 Javadoc Warnings: @link reference not found (#306) 
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
Signed-off-by: stack <stack@apache.org>
 2019-07-01 21:18:11 -07:00
zhangduo 7cd1caa1ec HBASE-22477 Throwing exception when meta region is not in OPEN state in client registry may crash a master 2019-07-02 10:36:49 +08:00
huzheng c19592a971 HBASE-21916 Abstract an ByteBuffAllocator to allocate/free ByteBuffer in ByteBufferPool 2019-06-25 21:12:37 +08:00
Jan Hentschel 6cff25cc23
HBASE-22344 Documented the deprecation of public and limited private APIs (#208) 
Signed-off-by: stack <stack@apache.org>
 2019-06-17 22:29:51 +02:00
Andrew Purtell d3fba8c0c5
HBASE-22530 The metrics of store files count of region are returned to clients incorrectly (Eungsop Yoo) 
Signed-off-by: Xu Cang <xucang@apache.org>
 2019-06-13 17:45:28 -07:00
Duo Zhang d2eee1400d HBASE-22569 Should treat null consistency as Consistency.STRONG in ConnectionUtils.timelineConsistentRead 2019-06-13 08:20:50 +08:00
meiyi 17ea99c83d HBASE-22513 Admin#getQuota does not work correctly if exceedThrottleQuota is set 2019-06-03 17:51:28 +08:00
Andrew Purtell d06c3af980
HBASE-22459 Expose store reader reference count (#248) 2019-05-30 15:08:32 -07:00
Andrew Purtell 2c55bd9344
HBASE-22449 https everywhere in Maven metadata (#247) 2019-05-21 12:38:42 -07:00
zhangduo 6a28e76f7e HBASE-22442 Nightly build is failing with hadoop 3.x 2019-05-19 07:56:02 +08:00
Andrew Purtell cc0b70db1f
HBASE-22377 Provide API to check the existence of a namespace which does not require ADMIN permissions (#225) 
Signed-off-by: Xu Cang <xucang@apache.org>
 2019-05-14 12:51:51 -07:00
Duo Zhang 6bd6a953a7 HBASE-22399 Change default hadoop-two.version to 2.8.x and remove the 2.7.x hadoop checks 2019-05-14 16:45:32 +08:00
zhangduo 912bbab1bf HBASE-21658 Addendum fix infinite wait when there are no meta locations yet 2019-05-14 08:13:02 +08:00
zhangduo ee1ebac4c2 HBASE-21658 Should get the meta replica number from zk instead of config at client side 2019-05-11 09:31:46 +08:00
zhangduo f1a00b9d57 HBASE-22236 AsyncNonMetaRegionLocator should not cache HRegionLocation with null location 2019-04-30 17:18:56 +08:00
Duo Zhang 75055c831e HBASE-22325 AsyncRpcRetryingCaller will not schedule retry if we hit a NotServingRegionException but there is no TableName provided 2019-04-30 15:20:09 +08:00
Duo Zhang 37c0ab30c7 HBASE-22322 Use special pause for CallQueueTooBigException 2019-04-30 10:07:47 +08:00
Sakthi c3e490f75c HBASE-22086: Space Quota issue: Deleting snapshot doesn't update the usage of table 
Signed-off-by: Duo Zhang <zhangduo@apache.org>
 2019-04-29 14:44:51 +08:00
Duo Zhang 940f374a07 HBASE-22317 Support reading from meta replicas 2019-04-28 15:59:11 +08:00
Sean Busbey 4862a596ef HBASE-22083 move eclipse settings into a profile. 
Signed-off-by: stack <stack@apache.org>

 Conflicts:
	hbase-backup/pom.xml
	hbase-hadoop-compat/pom.xml
	hbase-protocol/pom.xml
 2019-04-25 14:38:38 -05:00
Duo Zhang a3e36cb545 HBASE-22307 Addendum deprecated PreemptiveFastFailException 2019-04-25 16:57:39 +08:00
Yu Li 54b944a10f HBASE-22283 Print row and table information when failed to get region location 2019-04-24 15:52:52 +08:00
李小保 1bd5b5cf7b HBASE-22250 The same constants used in many places should be placed in constant classes 
Signed-off-by: stack <stack@apache.org>
 2019-04-23 21:24:46 -07:00
zouxiangwen 4138fce370 HBASE-22292 PreemptiveFastFailInterceptor clean repeatedFailuresMap issue 
Signed-off-by: stack <stack@apache.org>
 2019-04-23 08:02:48 -07:00
Igor Rudenko 7046996d64 HBASE-22047 LeaseException in Scan should be retried 
Signed-off-by: stack <stack@apache.org>
 2019-04-23 06:26:33 -07:00
Jan Hentschel c40e6e2339 HBASE-22231 Removed unused and '*' import 2019-04-23 12:53:52 +02:00
zhangduo 8973885cf4 HBASE-22279 Add a getRegionLocator method in Table/AsyncTable interface 2019-04-22 18:39:53 +08:00
zhangduo 38c7ab59a2 HBASE-22282 Should deal with error in the callback of RawAsyncHBaseAdmin.splitRegion methods 2019-04-22 16:49:02 +08:00
zhangduo 3a1dc8ec82 HBASE-22278 RawAsyncHBaseAdmin should not use cached region location 2019-04-21 22:35:00 +08:00
zhangduo 393c5b9502 HBASE-22261 Make use of ClusterStatusListener for async client 2019-04-21 22:26:58 +08:00
zhangduo 65fb40d7ee HBASE-22267 Implement client push back for async client 2019-04-21 16:51:55 +08:00
zhangduo cbe4ec2c51 HBASE-22244 Make use of MetricsConnection in async client 2019-04-18 22:20:24 +08:00
Jan Hentschel b5b1f86dc7
HBASE-22187 Removed remaining usages of ClusterConnection.clearRegionCache 2019-04-12 09:59:52 +02:00
Josh Elser 0f155b9ec9 HBASE-22144 Correct MultiRowRangeFilter to work with reverse scans 
Signed-off-by: Toshihiro Suzuki <brfrn169@gmail.com>
 2019-04-11 17:41:24 -04:00
stack c7e92bbc0d HBASE-22155 Move 2.2.0 on to hbase-thirdparty-2.2.0 2019-04-09 09:39:31 -07:00
Jingyun Tian 8a6b8e81aa HBASE-21965 Fix failed split and merge transactions that have failed to roll back 2019-04-09 20:11:56 +08:00
meiyi 0e85571b39 HBASE-22117 Move hasPermission/checkPermissions from region server to master 
Signed-off-by: Guanghao Zhang <zghao@apache.org>
 2019-04-09 17:06:09 +08:00
zhangduo 838e86952f HBASE-22178 Introduce a createTableAsync with TableDescriptor method in Admin 2019-04-07 21:19:25 +08:00
zhangduo b04b1ecc74 HBASE-22108 Avoid passing null in Admin methods 
Signed-off-by: Guanghao Zhang <zghao@apache.org>
 2019-04-07 21:08:55 +08:00
zhangduo 0b46ac5db3 HBASE-22179 Fix RawAsyncHBaseAdmin.getCompactionState 2019-04-07 08:35:03 +08:00
zhangduo 448f26775c HBASE-22177 Do not recreate IOException in RawAsyncHBaseAdmin.adminCall 2019-04-07 08:33:49 +08:00
Duo Zhang e35ff3acb7 HBASE-22158 RawAsyncHBaseAdmin.getTableSplits should filter out none default replicas 
Signed-off-by: Guanghao Zhang <zghao@apache.org>
Signed-off-by: Zheng Hu <openinx@gmail.com>
 2019-04-05 20:33:54 +08:00
Duo Zhang 7154f86b4b HBASE-22157 Include the cause when constructing RestoreSnapshotException in restoreSnapshot 
Signed-off-by: Zheng Hu <openinx@gmail.com>
 2019-04-04 10:45:30 +08:00
zhangduo 6fad60232b HBASE-22135 AsyncAdmin will not refresh master address 
Signed-off-by: Guanghao Zhang <zghao@apache.org>
 2019-04-01 09:24:00 +08:00
pingsutw b78c7a4f00 HBASE-22101 AsyncAdmin.isTableAvailable should not throw TableNotFoundException 
Signed-off-by: zhangduo <zhangduo@apache.org>
 2019-03-30 20:43:12 +08:00
zhangduo 4cf8e3b04c HBASE-22121 AsyncAdmin can not deal with non default meta replica 
Signed-off-by: Guanghao Zhang <zghao@apache.org>
 2019-03-30 20:19:02 +08:00
Sakthi 37b2cab98a HBASE-22094: Throw TableNotFoundException if table not exists in AsyncAdmin.compact 
Signed-off-by: zhangduo <zhangduo@apache.org>
 2019-03-27 20:14:29 +08:00
meiyi 89dbab7c9f HBASE-21911 Move getUserPermissions from regionserver to master 
Signed-off-by: Guanghao Zhang <zghao@apache.org>
 2019-03-27 11:22:57 +08:00
zhangduo bb52a6766a HBASE-22074 Should use procedure store to persist the state in reportRegionStateTransition 2019-03-26 18:14:17 +08:00
yaojingyi 1926b86a8c HBASE-21964 unset Quota by Throttle Type 
Signed-off-by: Guanghao Zhang <zghao@apache.org>
 2019-03-26 09:46:01 +08:00
zhangduo 8fb8886e5c Revert "HBASE-21965 Fix failed split and merge transactions that have failed to roll back" 
This reverts commit b2a4265992.
 2019-03-24 13:50:39 +08:00
Jingyun Tian b2a4265992 HBASE-21965 Fix failed split and merge transactions that have failed to roll back 2019-03-22 17:12:34 +08:00
niuyulin ffcc003f85 HBASE-22065 Add listTableDescriptors(List<TableName>) method in AsyncAdmin 
Signed-off-by: zhangduo <zhangduo@apache.org>
 2019-03-21 22:36:10 +08:00
xujunhong c14f362bf8 HBASE-22063 Deprecated Admin.deleteSnapshot(byte[]) 
Signed-off-by: zhangduo <zhangduo@apache.org>
 2019-03-21 22:25:27 +08:00
Rishabh Jain 3a0cc2a098 HBASE-22042 Missing @Override annotation for RawAsyncTableImpl.scan 
Signed-off-by: zhangduo <zhangduo@apache.org>
 2019-03-19 17:01:44 +08:00
meiyi 3317f03d41 HBASE-22015 UserPermission should be annotated as InterfaceAudience.Public 
Signed-off-by: Guanghao Zhang <zghao@apache.org>
 2019-03-19 14:55:15 +08:00
zhangduo 2277ca422e HBASE-22040 Add mergeRegionsAsync with a List of region names method in AsyncAdmin 
Signed-off-by: Zheng Hu <openinx@gmail.com>
 2019-03-18 21:05:27 +08:00
Duo Zhang 40bf6c5069 HBASE-22039 Should add the synchronous parameter for the XXXSwitch method in AsyncAdmin 
Signed-off-by: Zheng Hu <openinx@gmail.com>
 2019-03-16 10:09:07 +08:00
Nihal Jain 04b78bb416 HBASE-20662 Increasing space quota on a violated table does not remove SpaceViolationPolicy.DISABLE enforcement 
Signed-off-by: Josh Elser <elserj@apache.org>
 2019-03-15 14:00:52 -04:00
zhangduo 31b3716e84 HBASE-22001 Polish the Admin interface 
Signed-off-by: stack <stack@apache.org>
 2019-03-11 14:43:12 +08:00
Norbert Kalmar 003095cbca HBASE-21416 - fix TestRegionInfoDisplay flaky test 2019-03-08 09:19:00 -08:00
zhangduo d084423b52 HBASE-22007 Add restoreSnapshot and cloneSnapshot with acl methods in AsyncAdmin 
Signed-off-by: Zheng Hu <openinx@gmail.com>
 2019-03-08 18:19:11 +08:00
johnhomsea 1667762937 HBASE-22000 Deprecated isTableAvailable with splitKeys 
Signed-off-by: Duo Zhang <zhangduo@apache.org>
 2019-03-07 09:18:14 +08:00
zhangduo 21c7e880d4 HBASE-21983 Should track the scan metrics in AsyncScanSingleRegionRpcRetryingCaller if scan metrics is enabled 2019-03-03 19:08:28 +08:00
zhangduo 00e6208de0 HBASE-21978 Should close AsyncRegistry if we fail to get cluster id when creating AsyncConnection 
Signed-off-by: Guanghao Zhang <zghao@apache.org>
 2019-03-03 08:19:31 +08:00
meiyi 0d882bbc2b HBASE-21974 Change Admin#grant/revoke parameter from UserPermission to user and Permission 
Signed-off-by: Guanghao Zhang <zghao@apache.org>
 2019-03-02 23:47:56 +08:00
Syeda 5c03df5e50 HBASE-21487 Concurrent modify table ops can lead to unexpected results 
Signed-off-by: Guanghao Zhang <zghao@apache.org>
 2019-03-02 13:07:35 +08:00
Duo Zhang 8677031707 HBASE-21976 Deal with RetryImmediatelyException for batching request 
Signed-off-by: Guanghao Zhang <zghao@apache.org>
 2019-03-02 12:14:32 +08:00
Guanghao Zhang e412e036e1 HBASE-20724 Sometimes some compacted storefiles are still opened after region failover 2019-02-28 09:51:29 +08:00
meiyi ea0675eb96 HBASE-21820 Implement CLUSTER quota scope 
Signed-off-by: Guanghao Zhang <zghao@apache.org>
 2019-02-27 18:24:03 +08:00
Duo Zhang 11624c63e3 HBASE-21961 Infinite loop in AsyncNonMetaRegionLocator if there is only one region and we tried to locate before a non empty row 
Signed-off-by: Guanghao Zhang <zghao@apache.org>
 2019-02-27 17:55:09 +08:00
Duo Zhang 80830ee555 HBASE-21943 The usage of RegionLocations.mergeRegionLocations is wrong for async client 
Signed-off-by: Guanghao Zhang <zghao@apache.org>
 2019-02-26 11:22:11 +08:00
Wellington Chevreuil a8af0e5894 HBASE-21505 - proposal for a more consistent report on status 
Signed-off-by: Jingyun Tian <tianjy@apache.org>
 2019-02-25 10:07:51 +08:00
zhangduo d7c5d73de0 HBASE-21944 Validate put for batch operation 
Signed-off-by: Guanghao Zhang <zghao@apache.org>
 2019-02-24 20:20:16 +08:00
zhangduo d47d64c6e3 Revert "HBASE-21943 The usage of RegionLocations.mergeRegionLocations is wrong for async client" 
This reverts commit 3ccc6fec6c.
 2019-02-24 20:14:27 +08:00
zhangduo 1568aad302 HBASE-21945 Maintain the original order when sending batch request 
Signed-off-by: Guanghao Zhang <zghao@apache.org>
 2019-02-24 17:56:16 +08:00
Duo Zhang 3ccc6fec6c HBASE-21943 The usage of RegionLocations.mergeRegionLocations is wrong for async client 
Signed-off-by: Guanghao Zhang <zghao@apache.org>
 2019-02-24 17:34:29 +08:00
Guanghao Zhang 607ac735c4 HBASE-21922 BloomContext#sanityCheck may failed when use ROWPREFIX_DELIMITED bloom filter 2019-02-23 23:29:53 +08:00
meiyi 9e45752d6e HBASE-21783 Support exceed user/table/ns throttle quota if region server has available quota 
Signed-off-by: Guanghao Zhang <zghao@apache.org>
 2019-02-22 17:43:40 +08:00
Duo Zhang 761aef6d9d HBASE-20587 Replace Jackson with shaded thirdparty gson 
Signed-off-by: Michael Stack <stack@apache.org>
 2019-02-22 16:40:45 +08:00
meiyi 61621a33ce HBASE-21938 Add a new ClusterMetrics.Option SERVERS_NAME to only return the live region servers's name without metrics 
Signed-off-by: Guanghao Zhang <zghao@apache.org>
 2019-02-22 10:45:35 +08:00
zhangduo 164c250691 HBASE-21927 Always fail the locate request when error occur 
Signed-off-by: Zheng Hu <openinx@gmail.com>
 2019-02-20 19:48:32 +08:00
zhangduo f198311556 HBASE-21928 Deprecated HConstants.META_QOS 
Signed-off-by: Zheng Hu <openinx@gmail.com>
 2019-02-20 14:16:54 +08:00
zhangduo 4b36de3161 HBASE-21930 Deal with ScannerResetException when opening region scanner 
Signed-off-by: Zheng Hu <openinx@gmail.com>
 2019-02-20 11:04:15 +08:00
Nihal Jain f671703c7f HBASE-17942 Disable region splits and merges per table 
Signed-off-by: Guanghao Zhang <zghao@apache.org>
 2019-02-19 07:20:34 +08:00
Duo Zhang 3efccfe510 HBASE-21907 Should set priority for rpc request 
Signed-off-by: Guanghao Zhang <zghao@apache.org>
 2019-02-18 19:46:31 +08:00
zhangduo d88a87fd04 HBASE-21909 Validate the put instance before executing in AsyncTable.put method 
Signed-off-by: Michael Stack <stack@apache.org>
 2019-02-16 18:06:39 +08:00
Duo Zhang 48f2ef432b HBASE-21910 The nonce implementation is wrong for AsyncTable 
Signed-off-by: Guanghao Zhang <zghao@apache.org>
 2019-02-15 20:24:48 +08:00
Duo Zhang dec5bf3087 HBASE-21900 Infinite loop in AsyncMetaRegionLocator if we can not get the location for meta 
Signed-off-by: Guanghao Zhang <zghao@apache.org>
 2019-02-14 19:50:23 +08:00
Duo Zhang 33bdf09f77 HBASE-21888 Add a isClosed method to AsyncConnection 
Signed-off-by: Guanghao Zhang <zghao@apache.org>
 2019-02-14 11:41:30 +08:00
zhangduo beb7d01092 HBASE-21859 Add clearRegionLocationCache method for AsyncConnection 
Signed-off-by: Guanghao Zhang <zghao@apache.org>
 2019-02-13 10:07:43 +08:00
zhangduo 3759bf5309 HBASE-21862 IPCUtil.wrapException should keep the original exception types for all the connection exceptions 
Signed-off-by: Michael Stack <stack@apache.org>
 2019-02-10 09:37:34 +08:00
zhangduo 94c9aecea2 HBASE-21857 Do not need to check clusterKey if replicationEndpoint is provided when adding a peer 
Signed-off-by: Xu Cang <xucang@apache.org>
 2019-02-08 19:48:07 +08:00
zhangduo 54a8cc87c6 HBASE-21829 Use FutureUtils.addListener instead of calling whenComplete directly 2019-02-03 15:29:20 +08:00
zhangduo ed60532543 HBASE-21828 Make sure we do not return CompletionException when locating region 2019-02-02 21:14:09 +08:00
zhangduo e61c12c46f HBASE-21684 Throw DNRIOE when connection or rpc client is closed 2019-01-31 20:22:00 +08:00
Tommy Li 8699ec0fc8 HBASE-21775 ADDENDUM - fix TestAsyncProcess 2019-01-30 15:41:41 -08:00
meiyi ec9029f77e HBASE-21739 Move grant/revoke from regionserver to master 
Signed-off-by: Guanghao Zhang <zghao@apache.org>
 2019-01-30 19:03:43 +08:00
wanghuan 69c331efed HBASE-21699 Fixed create table failed when using SPLITS_FILE => 'splits.txt' 
Signed-off-by: Guanghao Zhang <zghao@apache.org>
 2019-01-30 15:57:21 +08:00
Guanghao Zhang 16665b6e93 HBASE-21799 Update branch-2 version to 2.3.0-SNAPSHOT 2019-01-29 21:53:21 +08:00
Duo Zhang e736d78362 HBASE-21792 Mark HTableMultiplexer as deprecated and remove it in 3.0.0 
Signed-off-by: Michael Stack <stack@apache.org>
 2019-01-29 09:08:26 +08:00
zhangduo f359d260d3 HBASE-21789 Rewrite MetaTableAccessor.multiMutate with Table.coprocessorService 
Signed-off-by: Michael Stack <stack@apache.org>
 2019-01-27 11:37:11 +08:00
Tommy Li 5f25985b98 HBASE-21775 The BufferedMutator doesn't ever refresh region location cache 
Fix server location metadata refresh in multi-actions

Signed-off-by: stack <stack@apache.org>
 2019-01-26 13:11:12 -08:00
Duo Zhang 1ac090b3f0 HBASE-21762 Move some methods in ClusterConnection to Connection 
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
 2019-01-25 21:14:07 +08:00
meiyi 1e7f306e17 HBASE-21713 Support set region server throttle quota 
Signed-off-by: Guanghao Zhang <zghao@apache.org>
 2019-01-25 15:47:32 +08:00
Wellington Chevreuil aae52f787c HBASE-20215 - Rename CollectionUtils to ConcurrentMapUtils 2019-01-24 20:55:55 -08:00
zhangduo de31d56c2d HBASE-21770 Should deal with meta table in HRegionLocator.getAllRegionLocations 
Signed-off-by: Guanghao Zhang <zghao@apache.org>
 2019-01-25 11:05:29 +08:00
zhangduo 67ba050fce HBASE-21761 Align the methods in RegionLocator and AsyncTableRegionLocator 
Signed-off-by: Guanghao Zhang <zghao@apache.org>
 2019-01-24 15:21:26 +08:00
xujunhong 7cebc0a74c HBASE-21715 set timeout instead of throwing Exception when calling ProcedureFuture.get in client side. 
Signed-off-by: Duo Zhang <zhangduo@apache.org>
 2019-01-24 14:55:33 +08:00
Kevin 0b81c63b1b HBASE-21716 Add toStringCustomizedValues to TableDescriptor 
Signed-off-by: Duo Zhang <zhangduo@apache.org>
 2019-01-24 11:32:39 +08:00
Tommy Li 8a7dd2de24 HBASE-21720 : metric to measure how actions are distributed to servers within a MultiAction 
Signed-off-by: Sergey Shelukhin <sershe@apache.org>
 2019-01-23 17:53:59 -08:00
Duo Zhang 6c57050af6 HBASE-21753 Support getting the locations for all the replicas of a region 2019-01-23 18:10:01 +08:00
huzheng 4eba6b3656 HBASE-21750 Most of KeyValueUtil#length can be replaced by cell#getSerializedSize for better performance because the latter one has been optimized 2019-01-22 20:21:49 +08:00
huzheng 1443694f89 HBASE-21734 Some optimization in FilterListWithOR 2019-01-22 11:50:19 +08:00
Duo Zhang ff272e8683 HBASE-21726 Add getAllRegionLocations method to AsyncTableRegionLocator 2019-01-19 11:14:40 +08:00
zhangduo 07484db1ff HBASE-19695 Handle disabled table for async client 
Signed-off-by: tianjingyun <tianjy1990@gmail.com>
 2019-01-17 18:34:30 +08:00
Duo Zhang ebf4fe3bb9 HBASE-21710 Add quota related methods to the Admin interface 
Signed-off-by: Michael Stack <stack@apache.org>
 2019-01-16 21:10:27 +08:00
Duo Zhang 479b8bef6d HBASE-21732 Should call toUpperCase before using Enum.valueOf in some methods for ColumnFamilyDescriptor 
Signed-off-by: Zheng Hu <openinx@gmail.com>
 2019-01-16 20:46:29 +08:00
Peter Somogyi c353d93f69 HBASE-21727 Simplify documentation around client timeout 
Signed-off-by: Michael Stack <stack@apache.org>
 2019-01-16 11:41:40 +01:00
Allan Yang b82ef56267 HBASE-20854 Wrong retries number in RpcRetryingCaller's log message 2019-01-16 11:40:49 +01:00
huzheng fdfbd9a21c HBASE-21657 PrivateCellUtil#estimatedSerializedSizeOf has been the bottleneck in 100% scan case 2019-01-16 09:47:27 +08:00
Sakthi dc50b570c6 HBASE-21225: Having RPC & Space quota on a table/Namespace doesn't allow space quota to be removed using 'NONE' 
Signed-off-by: Josh Elser <elserj@apache.org>
 2019-01-14 18:01:33 -07:00
zhangduo e7113edddf HBASE-21705 Should treat meta table specially for some methods in AsyncAdmin 2019-01-13 13:41:01 +08:00
Duo Zhang a09dffd106 HBASE-21663 Add replica scan support 2019-01-11 14:19:17 +08:00
Duo Zhang 8b9bfa0df5 HBASE-21580 Support getting Hbck instance from AsyncConnection 2019-01-11 11:26:48 +08:00
meiyi 14fb3af5fb HBASE-21694 Add append_peer_exclude_tableCFs and remove_peer_exclude_tableCFs shell commands 
Signed-off-by: Guanghao Zhang <zghao@apache.org>
 2019-01-09 22:22:47 +08:00
Sergey Shelukhin dfa86404dd HBASE-21614 RIT recovery with ServerCrashProcedure doesn't account for all regions 
Signed-off-by: zhangduo <zhangduo@apache.org>
 2019-01-09 20:03:30 +08:00
zhangduo d5fff9c256 HBASE-21682 Support getting from specific replica 2019-01-08 10:04:08 +08:00
meiyi c28e03e5df HBASE-21159 Add shell command to switch throttle on or off 
Signed-off-by: Guanghao Zhang <zghao@apache.org>
 2019-01-08 09:39:22 +08:00
zhangduo 77ca660389 HBASE-17356 Add replica get support 2019-01-03 08:38:53 +08:00
Sakthi b396051153 HBASE-21631: list_quotas should print human readable values for LIMIT 
Signed-off-by: Guanghao Zhang <zghao@apache.org>
 2018-12-22 22:05:32 +08:00
openinx 406f44219f HBASE-21620 Problem in scan query when using more than one column prefix filter in some cases 
Signed-off-by: Guanghao Zhang <zghao@apache.org>
Signed-off-by: Michael Stack <stack@apache.org>
Signed-off-by: Allan Yang <allan163@apache.org>
 2018-12-21 15:21:34 -08:00
Guanghao Zhang 1dd137b148 HBASE-21618 Scan with the same startRow(inclusive=true) and stopRow(inclusive=false) returns one result 2018-12-21 09:50:23 +08:00
meiyi c494e9ff20 HBASE-21578 Fix wrong throttling exception for capacity unit 
Signed-off-by: Guanghao Zhang <zghao@apache.org>
 2018-12-14 18:22:34 +08:00
zhangduo 9981e3f843 HBASE-21570 Add write buffer periodic flush support for AsyncBufferedMutator 2018-12-11 15:29:39 +08:00
Sakthi af72916c4c HBASE-21453 Convert ReadOnlyZKClient to DEBUG instead of INFO 2018-12-11 08:18:39 +01:00
Josh Elser 68bb66e35e HBASE-21524 Fix logging in ConnectionImplementation.isTableAvailable() 
Signed-off-by: Michael Stack <stack@apache.org>
 2018-11-29 11:28:19 -05:00
meiyi d590d6e472 HBASE-21034 Add new throttle type: read/write capacity unit 
Signed-off-by: Guanghao Zhang <zghao@apache.org>
 2018-11-21 09:50:07 +08:00
Reid Chan 6ab0fbb1f1 HBASE-21255 [acl] Refactor TablePermission into three classes (Global, Namespace, Table) 
Signed-off-by: Michael Stack <stack@apache.org>
 2018-11-15 11:45:24 +08:00
Ben Lau 13b68abb58
HBASE-21439 RegionLoads aren't being used in RegionLoad cost functions 
Signed-off-by: tedyu <yuzhihong@gmail.com>
Signed-off-by: Andrew Purtell <apurtell@apache.org>

Conflicts:
	hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancer.java
 2018-11-08 14:08:52 -08:00
tianjingyun 857abfb082
HBASE-21322 Add a scheduleServerCrashProcedure() API to HbckService 
Signed-off-by: Michael Stack <stack@apache.org>
 2018-10-29 20:56:11 -07:00
Guanghao Zhang f71768308c HBASE-21385 HTable.delete request use rpc call directly instead of AsyncProcess 
Signed-off-by: Michael Stack <stack@apache.org>
 2018-10-25 16:22:18 -07:00
jingyuntian 4a609db30c
HBASE-21269　Forward-port HBASE-21213 [hbck2] bypass leaves behind state in RegionStates when assign/unassign 2018-10-18 06:22:22 -07:00
Sahil Aggarwal ad6ca7c95a
HBASE-20716: Changes the bytes[] conversion done in Bytes and ByteBufferUtils. Instead of doing check unsafe_aligned available everytime, choose the best converter at startup. 2018-10-17 21:04:09 -07:00
Michael Stack 6125872f48 HBASE-21303 [shell] clear_deadservers with no args fails 2018-10-12 11:19:40 -07:00
Nihal Jain 3d1a2dbe68
HBASE-21196 HTableMultiplexer clears the meta cache after every put operation 
Signed-off-by: Andrew Purtell <apurtell@apache.org>
 2018-09-28 16:35:53 -07:00
Michael Stack 2836f75625
HBASE-21223 [amv2] Remove abort_procedure from shell 
Signed-off-by: Balazs Meszaros <balazs.meszaros@cloudera.com>
 2018-09-25 11:28:54 -07:00
Guangxu Cheng fd68e7593e
HBASE-20636 Introduce two bloom filter type : ROWPREFIX and ROWPREFIX_DELIMITED 
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Amending-Author: Andrew Purtell <apurtell@apache.org>
 2018-09-21 16:06:34 -07:00
Umesh Agashe 899fddb4e7
HBASE-21023 Added bypassProcedure() API to HbckService 2018-09-19 15:17:52 -07:00
Michael Stack 8876f12c0c
HBASE-21156 [hbck2] Queue an assign of hbase:meta and bulk assign/unassign 
Adds 'raw' assigns and unassigns methods to Hbck Service.

Fixes HbckService so it works when cluster is Kerberized.
 2018-09-19 09:47:32 -07:00
Guangxu Cheng e1548d3349 HBASE-21179 Fix the number of actions in responseTooSlow log 2018-09-12 10:45:55 +08:00
Guangxu Cheng 1a7dba44ce HBASE-21158 Empty qualifier cell is always returned when using QualifierFilter 2018-09-10 21:51:48 +08:00
Toshihiro Suzuki 49501cd5b5 HBASE-21052 After restoring a snapshot, table.jsp page for the table gets stuck 2018-09-09 10:25:10 +09:00
Reid Chan 0409c54ba7 HBASE-21129 Clean up duplicate codes in #equals and #hashCode methods of Filter 
Signed-off-by Ted Yu <yuzhihong@gmail.com>
 2018-09-04 11:15:57 +08:00
Toshihiro Suzuki 9b7c530b6c HBASE-21084 When cloning a snapshot including a split parent region, the split parent region of the cloned table will be online - addendum 2018-08-28 15:34:52 +09:00
Umesh Agashe cdf5cfa396 HBASE-20941 Created and implemented HbckService in master 
Added API setTableStateInMeta() to update table state only in Meta. This will be used by hbck2 tool.
 2018-08-27 12:10:33 -07:00
subrat.mishra 25e988dd43 HBASE-21030: Changed javadoc for append operation. 
Signed-off-by: Toshihiro Suzuki <brfrn169@gmail.com>
 2018-08-26 23:45:24 +09:00
zhangduo f533f01a3a HBASE-20881 Introduce a region transition procedure to handle all the state transition for a region 2018-08-26 18:08:06 +08:00
liubangchen a7a281a644 HBASE-19008 Add missing equals or hashCode method(s) to stock Filter implementations 
Signed-off-by: Reid Chan <reidchan@apache.org>
Signed-off-by: Ted Yu <yuzhihong@gmail.com>
 2018-08-24 00:39:35 +08:00
jingyuntian bee8566f2c HBASE-20985 add two attributes when we do normalization 
Signed-off-by: Guanghao Zhang <zghao@apache.org>
 2018-08-13 16:49:37 +08:00
Sakthi b2cefab0e1 HBASE-20885 Removed entry for RPC quota from hbase:quota when RPC quota is removed 
Signed-off-by: Josh Elser <elserj@apache.org>
Signed-off-by: Mike Drob <mdrob@apache.org>
 2018-08-03 11:06:56 -04:00
Michael Stack fc0c4660fa HBASE-20989 Minor, miscellaneous logging fixes 
Signed-off-by: Zach York <zyork@amazon.com>
Signed-off-by: Mingliang Liu <liuml07@apache.org>
 2018-08-01 11:20:26 -07:00
Reid Chan e14b60a539 HBASE-20886 [Auth] Support keytab login in hbase client 
Signed-off-by: Sean Busbey <busbey@apache.org>
 2018-07-31 11:10:34 +08:00
Allan Yang ac4b789f5f HBASE-20867 RS may get killed while master restarts 2018-07-25 18:13:50 +08:00
huzheng 99701968c8 HBASE-20565 ColumnRangeFilter combined with ColumnPaginationFilter can produce incorrect result 2018-07-24 10:33:33 +08:00
Ankit Singhal cf1f63bf91 HBASE-20901 Reducing region replica has no effect 
Signed-off-by: tedyu <yuzhihong@gmail.com>
 2018-07-19 13:39:44 -07:00
Mohit Goel 35a3c605f2 HBASE-6028 Start/Stop compactions at region server level 
Add switching on/off of compactions.

Switching off compactions will also interrupt any currently ongoing compactions.
Adds a "compaction_switch" to hbase shell. Switching off compactions will
interrupt any currently ongoing compactions. State set from shell will be
lost on restart. To persist the changes across region servers modify
hbase.regionserver.compaction.enabled in hbase-site.xml and restart.

Signed-off-by: Umesh Agashe <uagashe@cloudera.com>
Signed-off-by: Michael Stack <stack@apache.org>
 2018-07-19 06:20:12 -07:00
Balazs Meszaros 29f1352edd HBASE-20853 Polish "Add defaults to Table Interface so Implementors don't have to" 
Signed-off-by: Chia-Ping Tsai <chia7712@gmail.com>
Signed-off-by: Michael Stack <stack@apache.org>
 2018-07-19 19:57:09 +08:00
Mike Drob 2a9162a503
HBASE-20884 Replace Base64 with j.u.Base64 
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: tedyu <yuzhihong@gmail.com>
 2018-07-13 13:00:23 -05:00
zhaoyuan 7990283d50 HBASE-20697 Can't cache All region locations of the specify table by calling table.getRegionLocator().getAllRegionLocations() 
Signed-off-by: Guanghao Zhang <zghao@apache.org>
 2018-07-11 11:07:04 +08:00
zhangduo 8decae9b92 HBASE-20784 Will lose the SNAPSHOT suffix if we get the version of RS from ServerManager 2018-07-10 10:00:11 +08:00
zhangduo 8a394ade4c HBASE-20822 TestAsyncNonMetaRegionLocator is flakey 2018-07-09 14:56:42 +08:00
Michael Stack e2d0cdbc09 HBASE-20812 Add defaults to Table Interface so implementors don't have to 
Signed-off-by: Mike Drob <mdrob@apache.org>
 2018-06-29 11:05:09 -07:00
Pankaj a16e5523fc HBASE-20357 AccessControlClient API Enhancement 
Signed-off-by: tedyu <yuzhihong@gmail.com>
 2018-06-29 07:54:14 -07:00
zhangduo 5ba314e3f3 HBASE-20810 Include the procedure id in the exception message in HBaseAdmin for better debugging 2018-06-29 11:40:48 +08:00
Michael Stack 4e16ecd7f4
HBASE-20770 WAL cleaner logs way too much; gets clogged when lots of work to do 
General log cleanup; setting stuff that can flood the log to TRACE.
 2018-06-25 12:12:43 -07:00
Michael Stack daa3e007ec HBASE-20710 extra cloneFamily() in Mutation.add(Cell); ADDENDUM checkstyle 2018-06-23 23:32:45 -07:00
Huaxiang Sun 6f4ff8dcf0 HBASE-20710 extra cloneFamily() in Mutation.add(Cell) 
Signed-off-by: Michael Stack <stack@apache.org>
 2018-06-23 23:32:37 -07:00
zhangduo 2f4b0a4a42 HBASE-20775 TestMultiParallel is flakey 2018-06-24 08:26:26 +08:00
zhangduo dde042cc93 HBASE-20776 Update branch-2 version to 2.2.0-SNAPSHOT 2018-06-22 22:15:18 +08:00
zhangduo 108e636247 HBASE-18569 Add prefetch support for async region locator 2018-06-22 18:20:08 +08:00
zhangduo a86141b625 HBASE-20752 Make sure the regions are truly reopened after ReopenTableRegionsProcedure 2018-06-22 14:06:29 +08:00
Ankit Singhal 28d0d8c5cc HBASE-20642 Clients should re-use the same nonce across DDL operations 
Also changes modify table operations to help the case where a MTP spans
two master, avoiding the sanity-checks propagating back to the client
unnecessarily.

Signed-off-by: Josh Elser <elserj@apache.org>
Signed-off-by: Michael Stack <stack@apache.org>
 2018-06-20 15:10:52 -07:00
taiynlee 8aabe36a49 HBASE-20737 (addendum) put collection into ArrayList instead of addAll function -- RetriesExhaustedWithDetailsException.java 
Signed-off-by: Chia-Ping Tsai <chia7712@gmail.com>
 2018-06-20 14:46:04 +08:00
zhangduo 3e33aecea2 HBASE-20708 Remove the usage of RecoverMetaProcedure in master startup 2018-06-19 15:09:11 +08:00
Sean Busbey ee84a8f243 HBASE-20332 shaded mapreduce module shouldn't include hadoop 
* modify the jar checking script to take args; make hadoop stuff optional
* separate out checking the artifacts that have hadoop vs those that don't.
* * Unfortunately means we need two modules for checking things
* * put in a safety check that the support script for checking jar contents is maintained in both modules
* * have to carve out an exception for o.a.hadoop.metrics2. :(
* fix duplicated class warning
* clean up dependencies in hbase-server and some modules that depend on it.
* allow Hadoop to have its own htrace where it needs it
* add a precommit check to make sure we're not using old htrace imports

 Conflicts:
	hbase-backup/pom.xml
	hbase-checkstyle/src/main/resources/hbase/checkstyle-suppressions.xml

Signed-off-by: Mike Drob <mdrob@apache.org>
 2018-06-18 14:02:48 -07:00
Mike Drob b04c976fe6 HBASE-20478 Update checkstyle to v8.2 
Cannot go to latest (8.9) yet due to
  https://github.com/checkstyle/checkstyle/issues/5279

* move hbaseanti import checks to checkstyle
* implment a few missing equals checks, and ignore one
* fix lots of javadoc errors

Signed-off-by: Sean Busbey <busbey@apache.org>
 2018-06-18 14:02:40 -07:00
Rajeshbabu Chintaguntla c0d67209df HBASE-20635 Add missing shaded-pb conversion method for UserPermission 
Signed-off-by: Josh Elser <elserj@apache.org>
Signed-off-by: Ted Yu <yuzhihong@gmail.com>
 2018-06-11 15:13:17 -04:00
Guanghao Zhang 9d15e16946 HBASE-20698 Master don't record right server version until new started region server call regionServerReport method 2018-06-09 14:47:07 +08:00
EugeneNik 323eccc65b HBASE-20684 org.apache.hadoop.hbase.client.Scan#setStopRow javadoc uses incorrect method 
Signed-off-by: zhangduo <zhangduo@apache.org>
 2018-06-05 21:58:06 +08:00
Josh Elser 26e7065cb4 HBASE-20640 Add missing test category and class rule 
Signed-off-by: tedyu <yuzhihong@gmail.com>
 2018-05-30 10:34:14 -04:00
Apekshit Sharma a2d5e3183c HBASE-20594 Provide utility to get table desc delta 
Ammending Author: Mike Drob <mdrob@apache.org>

Signed-off-by: Sean Busbey <busbey@apache.org>
Signed-off-by: Apekshit Sharma <appy@apache.org>
 2018-05-29 14:28:46 -05:00
huzheng fbda502435 HBASE-20612 TestReplicationKillSlaveRSWithSeparateOldWALs sometimes fail because it uses an expired cluster conn 2018-05-23 12:07:54 +08:00
zhangduo 60b8344cf1 HBASE-20457 Return immediately for a scan rpc call when we want to switch from pread to stream 2018-05-15 21:09:04 +08:00
Sean Busbey 61f96b6ffa HBASE-20544 Make HBTU default to random ports. 
Signed-off-by: Umesh Agashe <uagashe@cloudera.com>
Signed-off-by: Josh Elser <elserj@apache.org>

 Conflicts:
	hbase-backup/src/test/resources/hbase-site.xml
	hbase-spark-it/src/test/resources/hbase-site.xml
	hbase-spark/src/test/resources/hbase-site.xml
 2018-05-09 23:45:39 -07:00
Nihal Jain 55badefa38 HBASE-20485 Copy constructor of Scan doesn't copy the readType and replicaId 
Signed-off-by: Chia-Ping Tsai <chia7712@gmail.com>
 2018-05-09 16:45:39 +08:00
Mingdao Yang 2373451f94 HBASE-20527 Remove unused code in MetaTableAccessor 
Signed-off-by: Chia-Ping Tsai <chia7712@gmail.com>
 2018-05-05 22:20:24 +08:00
Guangxu Cheng 3fc2c3bf34 HBASE-20484 Remove the unnecessary autoboxing in FilterListBase 
Signed-off-by: Chia-Ping Tsai <chia7712@gmail.com>
 2018-04-26 16:32:14 +08:00
Sean Busbey 24eb141bac HBASE-20442 clean up incorrect use of commons-collections 3 
Signed-off-by: Umesh Agashe <uagashe@cloudera.com>
Signed-off-by: Yu Li <liyu@apache.org>

 Conflicts:
	hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/master/BackupLogCleaner.java
 2018-04-20 08:17:22 -05:00
Huaxiang Sun 36680da549 HBASE-19994 Create a new class for RPC throttling exception, make it retryable 2018-04-17 10:45:44 -07:00
zhangduo ae8a21204d HBASE-20377 Deal with table in enabling and disabling state when modifying serial replication peer 2018-04-13 20:33:25 +08:00
Guangxu Cheng b0701434e3 HBASE-20243 [Shell] Add shell command to create a new table by cloning the existent table 
Signed-off-by: tedyu <yuzhihong@gmail.com>
 2018-04-11 19:34:30 -07:00
Balazs Meszaros b52bf4052f HBASE-20382 If RSGroups not enabled, rsgroup.jsp prints stack trace 2018-04-11 09:49:50 -07:00
zhangduo 3eee7d37f4 HBASE-20367 Write a replication barrier for regions when disabling a table 2018-04-11 20:36:59 +08:00
zhangduo 28d09cedcf HBASE-20182 Addendum throw IOException instead of NoServerForRegionException because it is a DoNotRetryRegionException 2018-04-11 14:47:41 +08:00
zhangduo 74ab10c353 HBASE-20296 Remove last pushed sequence ids when removing tables from a peer 2018-04-09 15:18:44 +08:00
zhangduo 9369cf26eb HBASE-20147 Serial replication will be stuck if we create a table with serial replication but add it to a peer after there are region moves 2018-04-09 15:18:44 +08:00
zhangduo 644bfe36b2 HBASE-20117 Cleanup the unused replication barriers in meta table 2018-04-09 15:18:44 +08:00
zhangduo cea5199ea1 HBASE-20148 Make serial replication as a option for a peer instead of a table 2018-04-09 15:18:44 +08:00
zhangduo 8b61a061d3 HBASE-20129 Add UT for serial replication checker 2018-04-09 15:18:44 +08:00
zhangduo f29bf1d778 HBASE-20115 Reimplement serial replication based on the new replication storage layer 2018-04-09 15:18:44 +08:00
zhangduo 39c1ddc6e3 HBASE-20362 TestMasterShutdown.testMasterShutdownBeforeStartingAnyRegionServer is flaky 2018-04-09 14:55:42 +08:00
zhangduo dcc1d9e36a HBASE-20182 Can not locate region after split and merge 2018-04-07 13:37:59 +08:00
BELUGA BEHR 039bc73571 HBASE-19488 Move to using Apache commons CollectionUtils 
Signed-off-by: Apekshit Sharma <appy@apache.org>
 2018-04-04 14:16:33 -07:00
Michael Stack d4e115bf34 HBASE-20259 Doc configs for in-memory-compaction and add detail to 
in-memory-compaction logging

Adds logging of CompactingMemStore configuration on construction.

Add logging of detail about Store on creation including memstore type.

Add chapter to refguide on new in-memory compaction feature.
 2018-04-02 09:56:32 -07:00
Yu Li b72e19e3b9 HBASE-20159 Support using separate ZK quorums for client 2018-03-29 03:20:52 +08:00
Toshihiro Suzuki e1afc5932a HBASE-20229 ConnectionImplementation.locateRegions() returns duplicated entries when region replication is on 2018-03-26 15:13:13 -07:00
Jan Hentschel 52014b9423 HBASE-13300 Fixed casing in set/getTimeStamp for Mutations 2018-03-23 17:23:55 -07:00
Chia-Ping Tsai 6aba045aae HBASE-19504 Add TimeRange support into checkAndMutate 
Signed-off-by: Michael Stack <stack@apache.org>
 2018-03-24 00:05:22 +08:00
Umesh Agashe 96d63fee11 HBASE-20224 Web UI is broken in standalone mode 
Changes for HBASE-20027 seem to cause UI not showing up on default port in standalone mode. For concurrent
unit test execution, individual tests can set hbase.localcluster.assign.random.ports to true or modify
test/resources/hbase-site.xml.
 2018-03-22 20:28:08 -07:00
Michael Stack 79e4c9d925
Revert "HBASE-20224 Web UI is broken in standalone mode" 
Broke shell tests.

This reverts commit dd9fe813ec.
 2018-03-22 10:47:47 -07:00
Umesh Agashe dd9fe813ec HBASE-20224 Web UI is broken in standalone mode 
Changes for HBASE-20027 seem to cause UI not showing up on default port in standalone mode. For concurrent
unit test execution, individual tests can set hbase.localcluster.assign.random.ports to true or modify
test/resources/hbase-site.xml.
 2018-03-22 06:52:51 -07:00
Chia-Ping Tsai dd9e46bbf5 HBASE-20212 Make all Public classes have InterfaceAudience category 
Signed-off-by: tedyu <yuzhihong@gmail.com>
Signed-off-by: Michael Stack <stack@apache.org>
 2018-03-22 18:09:54 +08:00
Andrew Purtell 4fcc1ac7f7 HBASE-19024 Provide a configurable option to hsync WAL edits to the disk for better durability (Harshal Jain) 2018-03-20 17:30:39 -07:00
Chia-Ping Tsai 7ba86d056c HBASE-20119 (addendum) revert the removed methods in TableDescriptorBuilder and TableDescriptor 
Signed-off-by: Josh Elser <elserj@apache.org>
Signed-off-by: Michael Stack <stack@apache.org>
 2018-03-19 09:08:29 +08:00
Michael Stack 3f1c86786c HBASE-20213 [LOGGING] Aligning formatting and logging less (compactions, 
in-memory compactions)

Log less. Log using same format as used elsewhere in log.

Align logs in HFileArchiver with how we format elsewhere. Removed
redundant 'region' qualifiers, tried to tighten up the emissions so
easier to read the long lines.

M hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ChunkCreator.java
 Add a label for each of the chunkcreators we make (I was confused by
two chunk creater stats emissions in log file -- didn't know that one
was for data and the other index).

M hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplit.java
 Formatting. Log less.

M hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreCompactionStrategy.java
 Make the emissions in here trace-level. When more than a few regions,
log is filled with this stuff.
 2018-03-16 13:07:34 -07:00
Michael Stack 79d47dd57a HBASE-20202 [AMv2] Don't move region if its a split parent or offlined 
M hbase-client/src/main/java/org/apache/hadoop/hbase/client/DoNotRetryRegionException.java
M hbase-client/src/main/java/org/apache/hadoop/hbase/exceptions/MergeRegionException.java
 Allow passing cause to Constructor.

M hbase-protocol-shaded/src/main/protobuf/MasterProcedure.proto
 Add prepare step to move procedure.

M hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/MergeTableRegionsProcedure.java
 Add check that regions to merge are actually online to the Constructor
so we can fail fast if they are offline

M hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/MoveRegionProcedure.java
 Add prepare step. Check regions and context and skip move if not right.

M hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/SplitTableRegionProcedure.java
 Add check parent region is online to constructor.

M hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/AbstractStateMachineTableProcedure.java
 Add generic check region is online utility function for use by subclasses.

M hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionMove.java
 Add test that we fail if we try to move an offlined region.
 2018-03-16 09:34:15 -07:00
Chia-Ping Tsai 95596e8ba7 HBASE-20119 Introduce a pojo class to carry coprocessor information in order to make TableDescriptorBuilder accept multiple cp at once 
Signed-off-by: Ted Yu <yuzhihong@gmail.com>
Signed-off-by: Michael Stack <stack@apache.org>
 2018-03-16 01:26:08 +08:00
Michael Stack 63ce0c0733 HBASE-20178 [AMv2] Throw exception if hostile environment 
Add Fail-Fast to Procedures by throwing exception out of Procedure
constructor so if move but table is disabled or if master is going
down, etc., we can give notice before the procedure is scheduled.
Will help guard against scheduling Procedures that will have a hard
time succeeding; e.g. a move when table is offline.

Also fixed bug around table state where we presumed ENABLED though no
entry in hbase:meta (we were using this mechanism for whether a table
existed or not).

M hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionMove.java
 Test stolen from HBASE-20131

M hbase-client/src/main/java/org/apache/hadoop/hbase/client/TableState.java
 Add convenience isEnabled/isDisabled

M hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
 Promote assert state to throw exception.

M hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterServices.java
 Add isClusterUp

M hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
 Move constructor now throws exception
M hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/MoveRegionProcedure.java
M hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/MergeTableRegionsProcedure.java
M hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/SplitTableRegionProcedure.java
M hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/DisableTableProcedure.java
M hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ModifyTableProcedure.java
M hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/RestoreSnapshotProcedure.java
M hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/TruncateTableProcedure.java
 Do environment check at construction and fail-fast if hostile.

M hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/AbstractStateMachineTableProcedure.java
 Add preflightCheck utility method.

M hbase-client/src/main/java/org/apache/hadoop/hbase/MetaTableAccessor.java
 Removed setting time setting table state; broke when using other than
 default environment edge masked by presumption that no state meant
 active.
 2018-03-14 14:43:34 -07:00
maoling fac3b8aad6 HBASE-20047 AuthenticationTokenIdentifier should provide a toString 
Signed-off-by: Chia-Ping Tsai <chia7712@gmail.com>
 2018-03-12 22:16:22 +08:00
Guanghao Zhang d36aacdf9e HBASE-19636 All rs should already start work with the new peer change when replication peer procedure is finished 
Signed-off-by: zhangduo <zhangduo@apache.org>
 2018-03-09 20:55:48 +08:00
zhangduo 525fef572e HBASE-19633 Clean up the replication queues in the postPeerModification stage when removing a peer 2018-03-09 20:55:48 +08:00
huzheng 1e36a84afc HBASE-19622 Reimplement ReplicationPeers with the new replication storage interface 2018-03-09 20:55:48 +08:00
huzheng 3fd417600e HBASE-19525 RS side changes for moving peer modification from zk watcher to procedure 2018-03-09 20:55:48 +08:00
Guanghao Zhang 750b7d8dbe HBASE-19536 Client side changes for moving peer modification from zk watcher to procedure 
Signed-off-by: zhangduo <zhangduo@apache.org>
 2018-03-09 20:55:48 +08:00
Sean Busbey 71cc7869db HBASE-20155 update branch-2 version to 2.1.0-SNAPSHOT 
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
 2018-03-08 08:44:30 -08:00
Mike Drob af9a108a93 HBASE-19987 error-prone 2.2.0 2018-03-07 21:21:05 -06:00
Sean Busbey 9927c2e14a HBASE-20070 refactor website generation 
* rely on git plumbing commands when checking if we've built the site for a particular commit already
* switch to forcing '-e' for bash
* add command line switches for: path to hbase, working directory, and publishing
* only export JAVA/MAVEN HOME if they aren't already set.
* add some docs about assumptions
* Update javadoc plugin to consistently be version 3.0.0
* avoid duplicative site invocations on reactor modules
* update use of cp command so it works both on linux and mac
* manually skip enforcer plugin during build
* still doing install of all jars due to MJAVADOC-490, but then skip rebuilding during aggregate reports.
* avoid the pager on git-diff by teeing to a log file, which also helps later reviewing in the case of big changesets.

Signed-off-by: Michael Stack <stack@apache.org>
Signed-off-by: Misty Stanley-Jones <misty@apache.org>

 Conflicts:
	hbase-backup/pom.xml
	hbase-spark-it/pom.xml
 2018-03-02 09:51:43 -06:00
Michael Stack a2de29560f HBASE-20113 Move branch-2 version from 2.0.0-beta-2-SNAPSHOT to 2.0.0-beta-2 2018-03-01 15:46:38 -08:00
zhangduo 10270e36c9 HBASE-20065 Addendum remove wrong comment 2018-02-26 09:48:55 +08:00
zhangduo 2d5065bc7e HBASE-20065 Revisit the timestamp usage in MetaTableAccessor 2018-02-25 09:14:09 +08:00
Sean Busbey a66fa85a16 Revert "HBASE-19835 Use explicit casting to avoid side effects" 
This reverts commit bc080e7500.

 Conflicts:
	hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Segment.java

patch reverted changes that happened in parallel without explanation. see jira.
 2018-02-23 23:04:34 -06:00
zhangduo 4ddfdaffdc HBASE-20048 Revert serial replication feature 2018-02-23 13:54:10 +08:00
Chia-Ping Tsai bc1ac49de2 HBASE-20017 BufferedMutatorImpl submit the same mutation repeatedly 
Signed-off-by: Andrew Purtell <apurtell@apache.org>
 2018-02-20 16:59:48 -08:00
zhangduo 34d3e847cc HBASE-20020 Make sure we throw DoNotRetryIOException when ConnectionImplementation is closed 2018-02-20 06:10:45 -08:00
Reid Chan 4ef6319af0 HBASE-19950 Introduce a ColumnValueFilter 
Signed-off-by: Chia-Ping Tsai <chia7712@gmail.com>
 2018-02-20 05:05:19 +08:00
eshcar a458d7c400 HBASE-18294 Reduce global heap pressure: flush based on heap occupancy 2018-02-18 12:58:52 +02:00
Chia-Ping Tsai 34d5f2b70e HBASE-19680 BufferedMutatorImpl#mutate should wait the result from AP in order to throw the failed mutations 2018-02-17 07:27:23 +08:00
Mike Drob 138f82c8c5 HBASE-19920 Lazy init for ProtobufUtil classloader 2018-02-16 09:11:45 -06:00
Chia-Ping Tsai 6923472f75 HBASE-19876 The exception happening in converting pb mutation to hbase.mutation messes up the CellScanner 2018-02-13 21:20:21 +08:00
Michael Stack c7473df2c3 HBASE-16060 1.x clients cannot access table state talking to 2.0 cluster 
This patch adds mirroring of table state out to zookeeper. HBase-1.x
clients look for table state in zookeeper, not in hbase:meta where
hbase-2.x maintains table state.

The patch also moves and refactors the 'migration' code that was put in
place by HBASE-13032.

D hbase-client/src/main/java/org/apache/hadoop/hbase/CoordinatedStateException.java
 Unused.

M hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
 Move table state migration code from Master startup out to
TableStateManager where it belongs. Also start
MirroringTableStateManager dependent on config.

A hbase-server/src/main/java/org/apache/hadoop/hbase/master/MirroringTableStateManager.java

M hbase-server/src/main/java/org/apache/hadoop/hbase/master/TableStateManager.java
 Move migration from zookeeper of table state in here. Also plumb in
mechanism so subclass can get a chance to look at table state as we do
the startup fixup full-table scan of meta.

M hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
 Bug-fix. Now we create regions in CLOSED state but we fail to check
table state; were presuming table always enabled. Meant on startup
there'd be an unassigned region that never got assigned.

A hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMirroringTableStateManager.java
 Test migration and mirroring.
 2018-02-12 08:22:14 -08:00
Aman Poonia bc080e7500 HBASE-19835 Use explicit casting to avoid side effects 
Signed-off-by: tedyu <yuzhihong@gmail.com>
 2018-02-08 12:33:08 -08:00
Michael Stack 8f1e01b6e5 HBASE-19951 Cleanup the explicit timeout value for test method 2018-02-07 16:39:54 -08:00
Chia-Ping Tsai e2636c81f7 HBASE-19900 Region-level exception destroy the result of batch 2018-02-07 08:38:04 +08:00
Umesh Agashe 5905415f9c HBASE-19915 (addendum): Fixed a typo because of which only daughterA was getting stored with a CLOSED state and not daughterB 2018-02-05 15:41:28 -08:00
Mike Drob e69c1fd7a0 HBASE-19922 remove ProtobufUtil::PRIMITIVES 2018-02-05 16:55:45 -06:00
Michael Stack 0ca7a2e916 HBASE-19726 Failed to start HMaster due to infinite retrying on meta assign; ADDENDUM Fix failing TestMetaWithReplicas#testShutdownHandling; it was reading meta TableState"" 
Retry applying this addendum. Previous commit added it w/ wrong log
message so had to revert and then reapply here.
 2018-02-03 21:49:42 -08:00
Michael Stack cd610607e7 Revert "HBASE-19928 TestVisibilityLabelsOnNewVersionBehaviorTable fails; ADDENDUM Fix failing TestMetaWithReplicas#testShutdownHandling; it was reading meta TableState" 
Wrong log message!

This reverts commit fbcb453ce2.
 2018-02-03 21:48:39 -08:00
Michael Stack fbcb453ce2 HBASE-19928 TestVisibilityLabelsOnNewVersionBehaviorTable fails; ADDENDUM Fix failing TestMetaWithReplicas#testShutdownHandling; it was reading meta TableState 2018-02-03 21:48:18 -08:00
zhangduo cb138c2da8 HBASE-19914 Refactor TestVisibilityLabelsOnNewVersionBehaviorTable 2018-02-04 13:37:09 +08:00
Michael Stack bac4687345 HBASE-19919 Tidying up logging 2018-02-02 22:42:30 -08:00
Umesh Agashe fdbc843516
HBASE-19915 Create merged/ daughter region/s with initial state CLOSED from MetaTableAccessor#splitRegion()/ mergeRegions() 
If the initial state is not set to CLOSED while creating merged/ children region/s, merged/
children region/s get stored in meta with state OFFLINE(0). If the master gets restarted after
Merge/ Split procedure stores merged/ children region/s, master startup sequence tries to assign
offline region/s. This is followed by re-assignment of merged/ children region from resumed Merge/
Split procedure.

This bug is related to HBASE-19530.

Signed-off-by: Michael Stack <stack@apache.org>
 2018-02-02 18:24:42 -08:00
Chia-Ping Tsai 6a1ed25581 HBASE-19897 RowMutations should follow the fluent pattern 2018-02-02 05:24:08 +08:00
zhangduo 28d13c54a9 HBASE-19887 Do not overwrite the surefire junit listener property in the pom of sub modules 2018-01-31 20:49:25 +08:00
Michael Stack 90a75fb052 HBASE-19888 Move branch-2 version from 2.0.0-beta-1 to 2.0.0-beta-2-SNAPSHOT 2018-01-29 14:17:54 -08:00
Duo Zhang bbf3bae72a
HBASE-19873 Add a CategoryBasedTimeout ClassRule for all UTs 2018-01-29 12:41:14 -08:00
zhangduo 0dea3656ab HBASE-19870 Fix the NPE in ReadOnlyZKClient#run 
Signed-off-by: Chia-Ping Tsai <chia7712@gmail.com>
 2018-01-29 16:22:40 +08:00
Chia-Ping Tsai f952779ba2 HBASE-4224 Need a flush by regionserver rather than by table option 2018-01-23 09:47:15 +08:00
Sergey Soldatov 6f8c31242a HBASE-19774 incorrect behavior of locateRegionInMeta 2018-01-22 11:49:19 -08:00
Guangxu Cheng c01dc69123 HBASE-19799 Add web UI to rsgroup 
Signed-off-by: tedyu <yuzhihong@gmail.com>
 2018-01-18 19:30:06 -08:00
zhangduo 8dd4bf8e54 HBASE-19795 Move the tests which only need zookeeper in TestZooKeeper to hbase-zookeeper module 2018-01-15 10:58:03 +08:00
zhangduo 842f794a62 HBASE-19772 Do not close connection to zk when there are still pending request in ReadOnlyZKClient 2018-01-14 17:08:30 +08:00
Michael Stack a917a4e796 HBASE-19753 Miscellany of fixes for hbase-zookeeper tests to make them more robust 
First, we add test resources to CLASSPATH when tests run. W/o it, there
was no logging of hbase-zookeeper test output (not sure why I have to
add this here and not over in hbase-server; research turns up nothing
so far).

M hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKMainServer.java
 Improve fail log message.

M hbase-zookeeper/src/test/java/org/apache/hadoop/hbase/zookeeper/TestReadOnlyZKClient.java
M hbase-zookeeper/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZKNodeTracker.java
 Wait until ZK is connected before progressing. On my slow zk, it could
 be a while post construction before zk connected. Using an unconnected
 zk caused test to fail.

M hbase-zookeeper/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZKMainServer.java
 Change session timeout to default 30s from 1s which was way too short.

M hbase-zookeeper/src/test/resources/log4j.properties
 Set zk logs to DEBUG level in this module at least.

Adds a ZooKeeperHelper class that has utility to help interacting w/ ZK.
 2018-01-11 11:22:56 -08:00
tedyu 47326729fe HBASE-19740 Repeated error message for NamespaceExistException 2018-01-10 18:26:23 -08:00
Josh Elser efa911f56f HBASE-19734 Fix IntegrationTestReplication and related impl changes 
Adds (client-side) validation to ReplicationPeerConfigBuilder and javadoc
to builder methods in addition to the test fix.

Signed-off-by: Guanghao Zhang <zghao@apache.org>
Signed-off-by: Michael Stack <stack@apache.org>
 2018-01-10 13:51:22 -05:00
Guanghao Zhang 895267d09c HBASE-19139 Create Async Admin methods for Clear Block Cache 2018-01-09 14:55:21 +08:00
Mike Drob b0a92bd4e1
HBASE-19721 Unnecessary stubbings in TestReversedScannerCallable 
Signed-off-by: Michael Stack <stack@apache.org>
 2018-01-06 08:57:20 -06:00
Beluga Behr 88c7493948
HBASE-19651 Remove LimitInputStream 2018-01-05 17:01:50 -06:00
Michael Stack e7da907c3c
Revert "HBASE-19651 Remove LimitInputStream" 
Revert to fix author.

This reverts commit 4c19e1f4e3.
 2018-01-05 16:59:59 -06:00
Michael Stack 4c19e1f4e3
HBASE-19651 Remove LimitInputStream 
Signed-off-by: Beluga Behr <dam6923@gmail.com>
 2018-01-05 08:38:12 -06:00