Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
12,079 Commits 95 Branches 866 Tags 550 MiB
Commit Graph

230 Commits

Author SHA1 Message Date
Apekshit Sharma 15c03fd1c9 HBASE-15965 
- Testing by executing a command will cover the exact path users will trigger, so its better then directly calling library functions in tests. Changing the tests to use @shell.command(:<command>, args) to execute them like it's a command coming from shell.

Norm change:
Commands should print the output user would like to see, but in the end, should also return the relevant value. This way:
- Tests can use returned value to check that functionality works
- Tests can capture stdout to assert particular kind of output user should see.
- We do not print the return value in interactive mode and keep the output clean. See Shell.command() function.

Bugs found due to this change:
- Uncovered bug in major_compact.rb with this approach. It was calling admin.majorCompact() which doesn't exist but our tests didn't catch it since they directly tested admin.major_compact()
- Enabled TestReplicationShell. If it's bad, flaky infra will take care of it.

Change-Id: I5d8af16bf477a79a2f526a5bf11c245b02b7d276
 2016-06-06 17:50:22 -07:00
Apekshit Sharma 70762faa98 HBASE-15849 Simplify the way we handle runtime of commands. 
Functions format_simple_command and format_and_return_simple_command are used to print runtimes right now. They are called from within every single command and use Ruby's 'yield' magic.  Instead, we can simplify it using 'command_safe' function. Since command_safe wraps all commands, we can simply time before and after we call individual command.
If a command only wants to time a part of its logic, it can set instance variables start_time and end_time accordingly which is far more simpler to understand and work with than 'yield'.

Change-Id: Ibfacf3593175af22fc4f7d80896dd2f6d7c5dde3
 2016-06-03 15:50:03 -07:00
Apekshit bdb46f01b9 HBASE-15845 Changes: 
- Renaming hbase.rb to hbase_constants.rb because there are two hbase.rb files right now which is confusing.
- Remove omnipresence of formatter object since it is kind of a use-and-throw class. Commands should create
  an instance, use it to format the output and discard it.
- Some refactoring

Change-Id: If9ea9873904e0a39d199a6aa10e23864b86a2f09
 2016-06-03 13:37:38 -07:00
tedyu 72d3f2a868 HBASE-15939 Two shell test failures on master (Talat and Ted) 2016-06-02 15:44:18 -07:00
tedyu a0f49c9884 HBASE-15858 Some region server group shell commands don't work 2016-06-01 21:13:33 -07:00
tedyu cbb95cd3a9 HBASE-15932 Shell test fails due to uninitialized constant 2016-06-01 10:35:00 -07:00
tedyu 015f2ef629 HBASE-15923 Shell rows counter test fails 2016-05-31 14:21:32 -07:00
Daniel Vimont e6d613de70 HBASE-15835 - Prevent HBaseTestingUtility#startMiniCluster from throwing _HMasterAddress already in use_ RuntimeException when another HBase thread is running 
Signed-off-by: stack <stack@apache.org>
 2016-05-30 20:05:19 -07:00
Enis Soztutar b89d88a193 HBASE-10358 Shell changes for setting consistency per request (yi liang) 2016-05-26 17:01:03 -07:00
stack 2515b0974d HBASE-4368 Expose processlist in shell (per regionserver and perhaps by cluster) (Talat Uyarer) 2016-05-23 15:49:17 -07:00
Jerry He 56e4b85d06 HBASE-14818 user_permission does not list namespace permissions (li xiang) 2016-05-21 20:06:05 -07:00
eshcar a27504c701 HBASE-14920: Compacting memstore 
Signed-off-by: stack <stack@apache.org>
 2016-05-20 03:41:43 -07:00
Matteo Bertozzi 5ac54e6abb HBASE-15843 Replace RegionState.getRegionInTransition() Map with a Set 2016-05-18 12:48:26 -07:00
tedyu 838c306c0a HBASE-15769 Perform validation on cluster key for add_peer (Matt Warhaftig) 2016-05-17 11:01:26 -07:00
tedyu 3b74b6f329 HBASE-15799 Two Shell 'close_region' Example Syntaxes Don't Work (Matt Warhaftig) 2016-05-09 20:58:55 -07:00
tedyu 387c7e6b08 HBASE-15782 TestShell fails due to some moved types 2016-05-06 06:11:12 -07:00
Li Fanxi e512c40ad5 HBASE-15680 Examples in shell help message for TIMERANGE scanner specifications should use milliseconds instead of seconds 
Signed-off-by: stack <stack@apache.org>
 2016-04-26 12:00:06 -07:00
tedyu ef47e1b68c HBASE-15641 Shell "alter" should do a single modifyTable operation (Matt Warhaftig) 2016-04-21 08:20:06 -07:00
chenheng a9f1c4a871 HBASE-15406 Split / merge switch left disabled after early termination of hbck 2016-04-15 14:09:52 +08:00
tedyu e0f31ba6e6 HBASE-15507 Online modification of enabled ReplicationPeerConfig (Geoffrey Jacoby) 2016-04-08 21:26:31 -07:00
Enis Soztutar bcc4444420 HBASE-15567 TestReplicationShell broken by recent replication changes (Geoffrey Jacoby) 2016-03-31 11:37:09 -07:00
chenheng 7f39baf0f4 HBASE-11393 Replication TableCfs should be a PB object rather than a string 2016-03-29 10:25:29 +08:00
tedyu 448ac5b37c HBASE-12940 Expose listPeerConfigs and getPeerConfig to the HBase shell (Geoffrey Jacoby) 2016-03-16 18:42:52 -07:00
Enis Soztutar ca816f0780 HBASE-6721 RegionServer Group based Assignment (Francis Liu) 2016-03-14 18:28:50 -07:00
chenheng 99955a3240 HBASE-15128 Disable region splits and merges switch in master 2016-02-27 08:36:59 +08:00
chenheng bf4fcc30c6 Revert "HBASE-15128 Disable region splits and merges switch in master" 
This reverts commit 24d481c580.
 2016-02-26 08:52:12 +08:00
chenheng 24d481c580 HBASE-15128 Disable region splits and merges switch in master 2016-02-26 08:11:16 +08:00
Phil Yang 30cec72f9a HBASE-15302 Reenable the other tests disabled by HBASE-14678 
Signed-off-by: stack <stack@apache.org>
 2016-02-24 07:14:01 -08:00
Enis Soztutar 110274b335 HBASE-15147 Shell should use Admin.listTableNames() instead of Admin.listTables() 2016-01-21 11:09:02 -08:00
tedyu eb17f74b9e HBASE-15073 Revert due to different opinion on usefulness 2016-01-18 17:51:21 -08:00
tedyu d65978fceb HBASE-15073 Finer grained control over normalization actions for RegionNormalizer 2016-01-06 17:25:41 -08:00
stack 2fba25b66a HBASE-15023 Reenable TestShell and TestStochasticLoadBalancer 2015-12-28 13:27:17 -08:00
tedyu e15c48ed2c HBASE-15032 hbase shell scan filter string assumes UTF-8 encoding (huaxiang sun) 2015-12-24 07:00:22 -08:00
Matteo Bertozzi 9a297ef0a5 HBASE-15022 replication_admin.rb throws undefined method `getZooKeeperClusterKey' for ZKUtil 2015-12-21 13:20:26 -08:00
Mikhail Antonov abe30b52a8 HBASE-14534 Bump yammer/coda/dropwizard metrics dependency version 2015-12-15 12:11:27 -08:00
stack bebcc09fb3 HBASE-14769 Remove unused functions and duplicate javadocs from HBaseAdmin 2015-12-10 15:02:21 -08:00
Matteo Bertozzi 6f8d5e86ce HBASE-14941 locate_region shell command 2015-12-10 13:22:48 -08:00
Enis Soztutar 63f2ebca13 HBASE-14804 HBase shell's create table command ignores 'NORMALIZATION_ENABLED' attribute (Jean-Marc Spaggiari) 2015-12-08 11:13:39 -08:00
stack 92e178df28 Revert "HBASE-14769 Removing unused functions from HBaseAdmin. Removing redundant javadocs from HBaseAdmin as they will be automatically inhertited from Admin.java. (Apekshit)" 
Reverting. The conversation on issues to do with this patch was not done (Appy brought it to my attention).

This reverts commit 6adce67572.
 2015-12-01 11:30:39 -08:00
Apekshit(Appy) Sharma 6adce67572 HBASE-14769 Removing unused functions from HBaseAdmin. Removing redundant javadocs from HBaseAdmin as they will be automatically inhertited from Admin.java. (Apekshit) 
Signed-off-by: stack <stack@apache.org>
 2015-11-30 20:44:11 -08:00
tedyu 2317ec583d HBASE-14894 Fix misspellings of threshold in log4j.properties files for tests (Youngjoon Kim) 2015-11-28 10:08:38 -08:00
Matteo Bertozzi 55087ce888 HBASE-14863 Add missing test/resources/log4j files in hbase modules 2015-11-22 07:31:16 -08:00
Enis Soztutar b2c20cebb0 HBASE-14805 status should show the master in shell 2015-11-18 15:25:48 -08:00
Apekshit(Appy) Sharma 08963189a2 HBASE-14767 - Remove deprecated functions from HBaseAdmin Deprecated in HBASE-12083 (1.0.0, 2.0.0, 0.99.2) - HBaseAdmin(Configuration) 
Deprecated in HBASE-10479 (0.99.0, hbase-10070)
  - HBaseAdmin(Connection)

  Deprecated in HBASE-11826 (0.99.0, 1.0.0, 2.0.0)
  - flush()
  - compact()
  - majorCompact()
  - split()
  - getCompactionState()

- Changes many declarations from HBaseAdmin to Admin
(Apekshit)

Signed-off-by: stack <stack@apache.org>
 2015-11-06 16:23:55 -10:00
Elliott Clark 68b94886a5 HBASE-14773 Fix HBase shell tests are skipped when skipping server tests. 2015-11-05 16:27:14 -08:00
Elliott Clark 86da57f498 HBASE-14765 Remove snappy profile 2015-11-05 10:20:40 -08:00
Enis Soztutar 4534f8ed0c HBASE-14733 Minor typo in alter_namespace.rb 2015-10-30 17:52:28 -07:00
Jonathan M Hsieh 094d65e6f5 HBASE-14673 Exorcise deprecated Delete#delete* api 2015-10-29 11:15:34 -07:00
Jonathan M Hsieh de9555cec4 HBASE-14675 Exorcise deprecated Put#add(...) and replace with Put#addColumn(...) 2015-10-29 11:15:31 -07:00
stack 93023f544b HBASE-14678 Experiment: Temporarily disable balancer and a few others to see if root of crashed/timedout JVMs 2015-10-22 12:31:04 -07:00