Commit Graph

1247 Commits

Author SHA1 Message Date
Matteo Bertozzi 41cc215544 HBASE-15975 logic in TestHTableDescriptor#testAddCoprocessorWithSpecStr is wrong (Huaxiang Sun) 2016-06-08 22:42:50 -07:00
Matteo Bertozzi d9463bcce0 HBASE-15989 Remove hbase.online.schema.update.enable 2016-06-08 13:09:31 -07:00
Sergey Soldatov da88b48240 HBASE-15957 RpcClientImpl.close never ends in some circumstances
Signed-off-by: Enis Soztutar <enis@apache.org>
2016-06-07 11:33:03 -07:00
Andrew Purtell 376ad0d986 HBASE-15698 Increment TimeRange not serialized to server (Ted Yu) 2016-06-06 22:17:00 -07:00
tedyu 7fd3532de6 HBASE-15803 ZooKeeperWatcher's constructor can leak a ZooKeeper instance with throwing ZooKeeperConnectionException when canCreateBaseZNode is true 2016-06-06 18:35:15 -07:00
Apekshit Sharma 15c03fd1c9 HBASE-15965
- Testing by executing a command will cover the exact path users will trigger, so its better then directly calling library functions in tests. Changing the tests to use @shell.command(:<command>, args) to execute them like it's a command coming from shell.

Norm change:
Commands should print the output user would like to see, but in the end, should also return the relevant value. This way:
- Tests can use returned value to check that functionality works
- Tests can capture stdout to assert particular kind of output user should see.
- We do not print the return value in interactive mode and keep the output clean. See Shell.command() function.

Bugs found due to this change:
- Uncovered bug in major_compact.rb with this approach. It was calling admin.majorCompact() which doesn't exist but our tests didn't catch it since they directly tested admin.major_compact()
- Enabled TestReplicationShell. If it's bad, flaky infra will take care of it.

Change-Id: I5d8af16bf477a79a2f526a5bf11c245b02b7d276
2016-06-06 17:50:22 -07:00
Ramkrishna b21c56e795 HBASE-15174 Client Public API should not have PB objects in 2.0 (Ram) 2016-06-06 10:11:38 +05:30
Joseph Hwang 21e98271c3 HBASE-15883 Adding WAL files and tracking offsets in HBase.
Implemented ReplicationQueuesHBaseImpl that tracks WAL offsets and replication queues in an HBase table.
Only wrote the basic tracking methods, have not implemented claimQueue() or HFileRef methods yet.
Wrote a basic unit test for ReplicationQueueHBaseImpl that tests the implemented functions on a single Region Server

Signed-off-by: Elliott Clark <elliott@fb.com>
Signed-off-by: Elliott Clark <eclark@apache.org>
2016-06-03 15:23:10 -07:00
Ashish Singhi 0cbce07626 HBASE-15888 Extend HBASE-12769 for bulk load data replication 2016-06-03 18:42:00 +05:30
Yu Li 53eb27bb60 HBASE-15931 Add log for long-running tasks in AsyncProcess 2016-06-02 12:00:42 +08:00
tedyu cbb95cd3a9 HBASE-15932 Shell test fails due to uninitialized constant 2016-06-01 10:35:00 -07:00
Jurriaan Mous a1f0c1cbb3 HBASE-15875 Remove HTable references and HTableInterface
Signed-off-by: stack <stack@apache.org>
2016-05-30 19:56:54 -07:00
Jurriaan Mous cdd532da8a HBASE-15610 Remove deprecated HConnection for 2.0 thus removing all PB references for 2.0
Signed-off-by: stack <stack@apache.org>
2016-05-29 07:50:55 -07:00
Sean Mackrory f4470af95d HBASE-15891. Closeable resources potentially not getting closed if exception is thrown.
Signed-off-by: stack <stack@apache.org>
2016-05-28 21:32:22 -07:00
Sean Mackrory 3b6e6e6c25 HBASE-15889. String case conversions are locale-sensitive, used without locale
Signed-off-by: Sean Busbey <busbey@apache.org>
2016-05-28 10:41:31 -07:00
Gary Helmling da0d74cd27 HBASE-15830 SASL encryption doesn't work with AsyncRpcChannelImpl (Colin Ma) 2016-05-26 21:58:27 -07:00
Andrew Purtell fdaf3be84f HBASE-15854 Log the cause of SASL connection failures (Robert Yokota) 2016-05-26 14:16:20 -07:00
Mikhail Antonov 1c30ae68ec HBASE-15880 RpcClientImpl#tracedWriteRequest incorrectly closes HTrace span 2016-05-23 12:44:48 -07:00
tedyu ae42c65cfd HBASE-15802 ConnectionUtils should use ThreadLocalRandom instead of Random (Matt Warhaftig) 2016-05-21 21:15:10 -07:00
Jerry He 56e4b85d06 HBASE-14818 user_permission does not list namespace permissions (li xiang) 2016-05-21 20:06:05 -07:00
Gary Helmling b1bf622e69 HBASE-15856 Addendum Fix UnknownHostException import in MetaTableLocator 2016-05-20 20:44:56 -07:00
stack 8dc0ae6fb3 HBASE-15863 Typo in Put.java class documentation (Tamer Soliman) 2016-05-20 11:51:36 -07:00
Gary Helmling 4793988aef HBASE-15856 Don't cache unresolved addresses for connections 2016-05-20 09:36:11 -07:00
eshcar a27504c701 HBASE-14920: Compacting memstore
Signed-off-by: stack <stack@apache.org>
2016-05-20 03:41:43 -07:00
Matteo Bertozzi 5ac54e6abb HBASE-15843 Replace RegionState.getRegionInTransition() Map with a Set 2016-05-18 12:48:26 -07:00
Phil Yang 3bd9220f0c HBASE-15593 Time limit of scanning should be offered by client
Signed-off-by: zhangduo <zhangduo@apache.org>
2016-05-18 19:13:15 +08:00
Ramkrishna 7b5d5394c0 HBASE-15784 Misuse core/maxPoolSize of LinkedBlockingQueue in
ThreadPoolExecutor (Jingcheng Du)
2016-05-18 12:40:43 +05:30
Elliott Clark 9269b8199e HBASE-15840 WAL.proto compilation broken for cpp 2016-05-17 12:04:14 -07:00
tedyu 838c306c0a HBASE-15769 Perform validation on cluster key for add_peer (Matt Warhaftig) 2016-05-17 11:01:26 -07:00
Sean Busbey e0aff10901 HBASE-15780 Make AuthUtil public and rely on it for talking to secure HBase.
Signed-off-by: Gary Helmling <garyh@apache.org>
Signed-off-by: Mikhail Antonov <antonov@apache.org>
Signed-off-by: stack <stack@apache.org>
2016-05-16 00:50:14 -05:00
stack c47511baa7 HBASE-15828 fix extant findbug NM_SAME_SIMPLE_NAME_AS_INTERFACE in Future 2016-05-15 21:11:29 -07:00
Mikhail Antonov 2482062d34 HBASE-15615 Wrong sleep time when RegionServerCallable need retry (Guanghao Zhang) 2016-05-15 20:37:26 -07:00
stack 6904430a3d HBASE-15811 Batch Get after batch Put does not fetch all Cells We were not waiting on all executors in a batch to complete. The test for no-more-executors was damaged by the 0.99/0.98.4 fix "HBASE-11403 Fix race conditions around Object#notify"
It added this in AsyncProcess#waitForMaximumCurrentTasks:

synchronized (this.tasksInProgress) {
+          if (tasksInProgress.get() != oldInProgress) break;
           this.tasksInProgress.wait(100);

which added a break out of our waiting loop if any change in
count of tasks; it seems that what was wanted was instead to
avoid the wait if there was movement in the count of completed
task.

Reformats waitForMaximumCurrentTasks so it is testable. Adds
test that we indeed wait on the specified parameter.
2016-05-13 17:51:27 -07:00
Jurriaan Mous a11091c49c HBASE-15798 Add Async RpcChannels to all RpcClients
Signed-off-by: stack <stack@apache.org>
2016-05-10 07:44:51 -07:00
Jurriaan Mous 9d17e3d22a HBASE-15797 TestIPCUtil fails after HBASE-15795
Signed-off-by: stack <stack@apache.org>
2016-05-09 17:04:58 -07:00
Ramkrishna 97ad33c691 HBASE-15609 Remove PB references from Result, DoubleColumnInterpreter and
any such public facing class for 2.0 (Ram)
2016-05-09 14:56:00 +05:30
Jurriaan Mous 9ee0cbb995 HBASE-15796 TestMetaCache fails after HBASE-15745
Signed-off-by: stack <stack@apache.org>
2016-05-07 15:29:07 -07:00
Jurriaan Mous fa033b6a08 HBASE-15793 Port over AsyncCall improvements
Signed-off-by: stack <stack@apache.org>
2016-05-07 10:38:38 -07:00
Jurriaan Mous ac31ceb835 HBASE-15794 Fix Findbugs instanceof always true issue in
MultiServerCallable

Signed-off-by: stack <stack@apache.org>
2016-05-07 10:10:23 -07:00
Jurriaan Mous e71ae601f7 HBASE-15795 Cleanup all classes in package org.apache.hadoop.hbase.ipc
for code style

Signed-off-by: stack <stack@apache.org>
2016-05-07 09:55:07 -07:00
Jurriaan Mous 56358a0fd3 HBASE-15745 Refactor RPC classes to better accept async changes
Signed-off-by: stack <stack@apache.org>
2016-05-06 13:43:45 -07:00
Ashish Singhi 34e9a6ff30 HBASE-15669 HFile size is not considered correctly in a replication request 2016-05-06 17:26:17 +05:30
Ramkrishna bec81b1977 HBASE-15608 Remove PB references from SnapShot related Exceptions (ram) 2016-05-06 17:06:25 +05:30
Alex Moundalexis 0bf065a5d5 HBASE-15768 fix capitalization of ZooKeeper usage
Signed-off-by: Sean Busbey <busbey@apache.org>
2016-05-05 15:35:44 -05:00
tedyu 8b0ce77942 HBASE-15292 Refined ZooKeeperWatcher to prevent ZooKeeper's callback while construction (Hiroshi Ikeda) 2016-05-05 11:14:32 -07:00
Gary Helmling d23d600d76 HBASE-15741 Provide backward compatibility for HBase coprocessor service names 2016-05-04 12:09:57 -07:00
Ramkrishna c06a976a98 HBASE-15607 Remove PB references from Admin for 2.0 (Ram) 2016-05-03 10:51:46 +05:30
Mikhail Antonov 58c4c3d174 HBASE-15703 Deadline scheduler needs to return to the client info about skipped calls, not just drop them 2016-05-02 15:23:07 -07:00
Jurriaan Mous 15631a76f5 HBASE-15744 Port over small format/text improvements from HBASE-13784
(Jurriaan Mous)

Signed-off-by: stack <stack@apache.org>
2016-05-01 19:48:43 -07:00
chenheng ccd8888b4b Revert "HBASE-15278 AsyncRPCClient hangs if Connection closes before RPC call response"
This reverts commit 01c0448ccd.
2016-04-30 11:37:05 +08:00
chenheng 01c0448ccd HBASE-15278 AsyncRPCClient hangs if Connection closes before RPC call response 2016-04-30 09:27:32 +08:00
Yu Li d8e032279f HBASE-15711 Add client side property to allow logging details for batch errors 2016-04-29 10:14:27 +08:00
tedyu 9343ef438f HBASE-15676 FuzzyRowFilter fails and matches all the rows in the table if the mask consists of all 0s (Matt Warhaftig) 2016-04-27 21:00:11 -07:00
Gary Helmling ce318a2906 HBASE-15658 Avoid excess meta cache clearing for RegionServerCallable 2016-04-26 22:54:13 -07:00
Phil Yang 53d7316075 HBASE-15645 hbase.rpc.timeout is not used in operations of HTable
Signed-off-by: stack <stack@apache.org>
2016-04-26 10:51:29 -07:00
stack 4bdd47c52c HBASE-15710 Include issue servers information in RetriesExhaustedWithDetailsException message (Yu Li) 2016-04-26 09:15:02 -07:00
chenheng 03f3c392a3 HBASE-15674 HRegionLocator#getAllRegionLocations should put the results in cache 2016-04-21 14:19:39 +08:00
chenheng a9f1c4a871 HBASE-15406 Split / merge switch left disabled after early termination of hbck 2016-04-15 14:09:52 +08:00
Vasudevan a395922ad5 HBASE-15605 Remove PB references from HCD and HTD for 2.0 (Ram) 2016-04-11 14:12:07 +05:30
tedyu e0f31ba6e6 HBASE-15507 Online modification of enabled ReplicationPeerConfig (Geoffrey Jacoby) 2016-04-08 21:26:31 -07:00
Samir Ahmic d393603dea HBASE-15606 Limit creating zk connection in HBaseAdmin#getCompactionState() only to case when 'hbase:meta' is checked.
Signed-off-by: stack <stack@apache.org>
2016-04-07 14:25:49 -07:00
Enis Soztutar 7e399883f6 HBASE-15505 ReplicationPeerConfig should be builder-style (Gabor Liptak) 2016-04-05 11:44:05 -07:00
Stephen Yuan Jiang e1d5c3d269 HBASE-15521 Procedure V2 - RestoreSnapshot and CloneSnapshot (Stephen Yuan Jiang) 2016-03-31 21:49:13 -07:00
chenheng 7f39baf0f4 HBASE-11393 Replication TableCfs should be a PB object rather than a string 2016-03-29 10:25:29 +08:00
Enis Soztutar 0520097611 HBASE-15295 MutateTableAccess.multiMutate() does not get high priority causing a deadlock 2016-03-28 17:56:32 -07:00
Mikhail Antonov db3ba652f8 HBASE-15524 Fix NPE in client-side metrics 2016-03-23 21:23:54 -07:00
zhangduo fd5c0934b6 HBASE-15520 Fix broken TestAsyncIPC 2016-03-24 10:46:44 +08:00
Elliott Clark 925c185969 HBASE-15475 Allow TimestampsFilter to provide a seek hint
Summary:
Allow TestTimestampFilterSeekHint to provide a seek next hint.
This can be incorrect as it might skip deletes. However it can
make things much much faster.

Test Plan: Added a unit test.

Differential Revision: https://reviews.facebook.net/D55617
2016-03-23 18:56:52 -07:00
Misty Stanley-Jones b6e1f63074 HBASE-15447 Improve javadocs description for Delete methods <Wellington Chevreuil> 2016-03-22 12:56:30 -07:00
tedyu dc6cd0bb74 HBASE-15479 No more garbage or beware of autoboxing (Vladimir Rodionov) 2016-03-19 17:22:53 -07:00
tedyu fbf58f330b HBASE-15325 ResultScanner allowing partial result will miss the rest of the row if the region is moved between two rpc requests (Phil Yang) 2016-03-17 11:03:29 -07:00
Mikhail Antonov a2c99b133f HBASE-15390 Unnecessary MetaCache evictions cause elevated number of requests to meta (ADDENDUM) 2016-03-17 01:08:36 -07:00
Elliott Clark ecec35ae4e HBASE-15441 Fix WAL splitting when region has moved multiple times
Summary:
Currently WAL splitting is broken when a region has been opened multiple times in recent minutes.

Region open and region close write event markers to the wal. These markers should have the sequence id in them. However it is currently getting 1. That means that if a region has moved multiple times in the last few mins then multiple split log workers will try and create the recovered edits file for sequence id 1. One of the workers will fail and on failing they will delete the recovered edits. Causing all split wal attempts to fail.

We need to:

It appears that the close event with a sequence id of one is coming from region warm up.

This patch fixes that by making sure the close on warm up doesn't happen. Also splitting will ignore any of the events that are already in the logs.

Test Plan: Unit tests pass

Differential Revision: https://reviews.facebook.net/D55557
2016-03-16 16:26:09 -07:00
Mikhail Antonov 3adcc750e3 HBASE-15390 Unnecessary MetaCache evictions cause elevated number of requests to meta 2016-03-16 16:22:36 -07:00
Enis Soztutar ca816f0780 HBASE-6721 RegionServer Group based Assignment (Francis Liu) 2016-03-14 18:28:50 -07:00
anoopsjohn eea8b38dfa HBASE-15180 Reduce garbage created while reading Cells from Codec Decoder. 2016-03-11 13:58:41 +05:30
anoopsjohn 6628d2df11 HBASE-15322 Operations using Unsafe path broken for platforms not having sun.misc.Unsafe. 2016-03-11 09:37:00 +05:30
tedyu ad9b91a904 HBASE-15378 Scanner cannot handle heartbeat message with no results (Phil Yang) 2016-03-09 09:28:54 -08:00
Mikhail Antonov 46cc3d4972 HBASE-15137 CallTimeoutException and CallQueueTooBigException should trigger PFFE 2016-03-07 20:54:54 -08:00
tedyu ed977fd125 HBASE-15243 Utilize the lowest seek value when all Filters in MUST_PASS_ONE FilterList return SEEK_NEXT_USING_HINT 2016-03-07 16:15:59 -08:00
tedyu dfc650a953 HBASE-15243 Revert due to compilation error - master branch change makes the patch stale 2016-03-07 15:59:29 -08:00
tedyu 05c1309b3c HBASE-15243 Utilize the lowest seek value when all Filters in MUST_PASS_ONE FilterList return SEEK_NEXT_USING_HINT 2016-03-07 15:41:06 -08:00
Jesse Yates ef712df944 HBASE-14703 HTable.mutateRow does not collect stats (Heng Chen) 2016-03-05 11:01:45 -08:00
tedyu d083e4f29f HBASE-15393 Enable table replication command will fail when parent znode is not default in peer cluster (Ashish Singhi) 2016-03-05 06:28:09 -08:00
Ashu Pachauri 27cf0c8c36 HBASE-15354 Same criteria to clear metacache across operations (Ashu Pachauri)
Signed-off-by: Mikhail Antonov <antonov@apache.org>
2016-03-04 17:55:35 -08:00
tedyu 664575598e HBASE-15397 Create bulk load replication znode(hfile-refs) in ZK replication queue by default (Ashish Singhi) 2016-03-04 13:43:25 -08:00
Jonathan M Hsieh f658f3ef83 HBASE-15356 Remove unused imports (Youngjoon Kim) 2016-03-03 11:42:38 -08:00
chenheng 99955a3240 HBASE-15128 Disable region splits and merges switch in master 2016-02-27 08:36:59 +08:00
chenheng bf4fcc30c6 Revert "HBASE-15128 Disable region splits and merges switch in master"
This reverts commit 24d481c580.
2016-02-26 08:52:12 +08:00
chenheng 24d481c580 HBASE-15128 Disable region splits and merges switch in master 2016-02-26 08:11:16 +08:00
Josh Elser a8073c4a98 HBASE-15232 Handle region location cache mgmt in AsyncProcess for multi()'s
Further investigation after HBASE-15221 lead to some findings that
AsyncProcess should have been managing the contents of the region
location cache, appropriately clearing it when necessary (e.g. an
RPC to a server fails because the server doesn't host that region)

For multi() RPCs, the tableName argument is null since there is no
single table that the updates are destined to. This inadvertently
caused the existing region location cache updates to fail on 1.x
branches. AsyncProcess needs to handle when tableName is null
and perform the necessary cache evictions.

As such, much of the new retry logic in HTableMultiplexer is
unnecessary and is removed with this commit. Getters which were
added as a part of testing were left since that are mostly
harmless and should contain no negative impact.

Signed-off-by: stack <stack@apache.org>
2016-02-22 22:03:14 -08:00
anoopsjohn 2d66cd86d0 HBASE-15247 InclusiveStopFilter does not respect reverse Filter property. (Amal Joshy) 2016-02-23 09:21:37 +05:30
stack 4b1acead42 HBASE-15285 Forward-port respect for isReturnResult from HBASE-15095 2016-02-17 19:26:17 -08:00
anoopsjohn 12982d1957 HBASE-15198 RPC client not using Codec and CellBlock for puts by default-addendum. 2016-02-12 07:37:45 +05:30
anoopsjohn 29a192ef3c HBASE-15198 RPC client not using Codec and CellBlock for puts by default. 2016-02-11 09:51:11 +05:30
tedyu 7bb68b9031 HBASE-15231 Make TableState.State private (Misty Stanley-Jones) 2016-02-08 15:21:18 -08:00
Josh Elser dfd8a31a13 HBASE-15221 Reload the cache on re-tried puts in HTableMultiplexer and adds a close() method to HTableMultiplexer
When a Put fails due to a NotServingRegionException, the cached location
of that Region is never cleared. Thus, subsequent calls to resubmit
the Put will fail in the same way as the original, never determining
the new location of the Region.

If the Connection is not closed by the user before the Multiplexer
is discarded, it will leak resources and could cause resource
issues.

Signed-off-by: Sean Busbey <busbey@cloudera.com>
2016-02-08 00:04:28 -06:00
anoopsjohn 7239056c78 HBASE-15214 Valid mutate Ops fail with RPC Codec in use and region moves across. 2016-02-06 02:40:49 +05:30
chenheng 8f20bc748d HBASE-15197 Expose filtered read requests metric to metrics framework and Web UI (Eungsop Yoo) 2016-02-05 10:57:14 +08:00
Andrew Purtell b80325fb1b Amend HBASE-15200 ZooKeeper znode ACL checks should only compare the shortname
Fixes for newly introduced FindBugs warnings
2016-02-04 17:33:32 -08:00