Commit Graph

17196 Commits

Author SHA1 Message Date
Duo Zhang 8815215b3e HBASE-24500 The behavior of RegionInfoBuilder.newBuilder(RegionInfo) is strange (#1840)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
Signed-off-by: Michael Stack <stack@apache.org>
2020-06-04 11:18:25 +08:00
Bharath Vissapragada e59f39e09e
HBASE-21905: [FIFOCompaction] Don't compact already inflight store files (#1829)
This one surfaced as a flake test but turns out to be a legit bug
in FIFOCompaction code. FifoCompaction does not check if an empty
store file is already being compacted by an in-flight compaction
request and still enqueues. It can potentially race with a running
compaction (as in this test case, see jira for the exact exception).

Fixes the edge case and cleans up the test code a bit.

Signed-off-by: Andrew Purtell <apurtell@apache.org>
2020-06-03 17:03:24 -07:00
Nick Dimiduk 4884773676 HBASE-24418 Consolidate Normalizer implementations
Simplify our Normalizer story to have just a single, configurable
implementation.

* fold the features of `MergeNormalizer` into
  `SimpleRegionNormalizer`, removing the intermediate abstract class.
* configuration keys for merge-only features now share a common
  structure.
* add configuration to selectively disable normalizer split/merge
  operations.
* `RegionNormalizer` now extends `Configurable` instead of creating a
  new instance of `HBaseConfiguration` or snooping one off of other
  fields.
* avoid the extra RPCs by using `MasterServices` instead of
  `MasterRpcServices`.
* boost test coverage of all the various flags and feature
  combinations.

Signed-off-by: Michael Stack <stack@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: huaxiangsun <huaxiangsun@apache.org>
2020-06-03 16:43:40 -07:00
Nick Dimiduk 5c390f0800 HBASE-24280 ADDENDUM branch on CHANGE_TARGET instead of BRANCH_NAME
Signed-off-by: Josh Elser <elserj@apache.org>
2020-06-03 16:36:54 -07:00
Nick Dimiduk fd7beffcf9 Revert "Merge pull request #1847 from ndimiduk/24280-addendum-CHANGE_TARGET-branch-2"
This reverts commit f66c80b6a6.
2020-06-03 16:36:54 -07:00
Nick Dimiduk f66c80b6a6
Merge pull request #1847 from ndimiduk/24280-addendum-CHANGE_TARGET-branch-2
HBASE-24280 ADDENDUM branch on CHANGE_TARGET instead of BRANCH_NAME
2020-06-03 16:20:49 -07:00
Nick Dimiduk 8c9c670aaa HBASE-24309 ADDENDUM remove redundant dependency 2020-06-03 10:19:50 -07:00
Wellington Ramos Chevreuil 11d093bc39 HBASE-21406 "status 'replication'" should not show SINK if the cluste… (#1761)
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
Signed-off by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: Josh Elser <elserj@apache.org>

(Cherry picked from commit e5345b3a7c)
2020-06-03 09:33:36 +01:00
Viraj Jasani b3c6af9500
HBASE-24492 : Remove infinite loop from ProtobufLogReader#readNext (#1831)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2020-06-03 13:44:19 +05:30
niuyulin 571ef7e811 HBASE-24412 Canary support check only one column family per RegionTask (#1817)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
2020-06-03 09:16:11 +08:00
stack 9c8895cfbf HBASE-24474 Rename LocalRegion to MasterRegion (#1811)
Addendum: HRegion changed size.
2020-06-02 10:44:48 -07:00
Duo Zhang 6b43015fc9 HBASE-24474 Rename LocalRegion to MasterRegion (#1811)
Signed-off-by: Michael Stack <stack@apache.org>
2020-06-02 10:43:27 +08:00
bsglz 69999371c6
HBASE-24455 Correct the doc of "On the number of column families" (#1799)
Signed-off-by: Wellington Ramos Chevreuil <wchevreuil@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2020-06-01 14:09:43 +05:30
Bharath Vissapragada a7a8afdf6a
HBASE-24479: Deflake TestCompaction#testStopStartCompaction (#1820)
Polling of active compaction count is racy. Tightened the asserts
to be more reliable.

Signed-off-by: Reid Chan <reidchan@apache.org>
2020-05-31 23:25:39 -07:00
Bharath Vissapragada d7f388518c
HBASE-24477: Move ConfigurationObserver and related classes to hbase-common
This utility is useful for any module that wants to detect
dynamic config changes. Having it to hbase-common makes it
accessible to all the other modules.

Signed-off-by: Michael Stack <stack@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2020-05-31 14:14:30 -07:00
bsglz 327d090e1b HBASE-24475 Clean up the master thread name getting in SplitLogManager and AssignmentManager (#1810) 2020-05-30 22:24:05 -07:00
jacob-leblanc 7b17e1cdaa HBASE-24454 - Read ioErrorStartTime to local temporary variable to avoid issue when it is set to -1 between greater than zero check and calculation of error duration (#1816)
Signed-off-by Anoop Sam John <anoopsamjohn@apache.org>
2020-05-30 21:07:46 -07:00
Duo Zhang 4d5efec767 HBASE-24471 The way we bootstrap meta table is confusing (#1806)
Signed-off-by: Michael Stack <stack@apache.org>
2020-05-30 16:37:41 +08:00
Wellington Ramos Chevreuil 2dd160e4c7 HBASE-23716 MasterFileSystem should not create MasterProcWALs dir on … (#1078)
Signed-off-by: Josh Elser <elserj@apache.org>
2020-05-30 16:37:30 +08:00
Duo Zhang 1ac00e11cb Revert "HBASE-23716 MasterFileSystem should not create MasterProcWALs dir on … (#1078)"
Wrong jira id

This reverts commit aca7f6fcf3.
2020-05-30 16:37:19 +08:00
Viraj Jasani b2d24a1812
HBASE-23941 : FilterBy operator support in get_slowlog_responses API (#1793)
Signed-off-by: Bharath Vissapragada <bharathv@apache.org>
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
2020-05-30 13:57:32 +05:30
Wellington Ramos Chevreuil aca7f6fcf3 HBASE-23716 MasterFileSystem should not create MasterProcWALs dir on … (#1078)
Signed-off-by: Josh Elser <elserj@apache.org>
2020-05-30 16:11:32 +08:00
Nick Dimiduk d522ef2cb8 HBASE-24343 Document how to configure the http request log
Signed-off-by: Michael Stack <stack@apache.org>
2020-05-29 16:59:35 -07:00
Sean Busbey 7ff3e650c2
HBASE-22033 Update to maven-javadoc-plugin 3.2.0 and switch to non-forking aggregate goals
closes #1796

Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: Michael Stack <stack@apache.org>
Signed-off-by: Jan Hentschel <janh@apache.org>
(cherry picked from commit 06949ff6a6)
2020-05-29 15:23:08 -05:00
Sean Busbey 9a77aad60c
HBASE-19663 javadoc creation needs jsr305.
Some javadoc invocations require that annotations we reference can have any
classes they reference resolved. This includes annotations _they_ have,
even though annotations are normally optional.

In some cases this showed up as javax.annotation.meta.TypeQualifierNickname
not found, because some findbugs annotations use it. Other times it was
javax.annotation.concurrent.Immutable not found, because some old guava
versions use it.

(updated for master branch by doing the config in report config instead of plugin)

Signed-off-by: Peter Somogyi <psomogyi@apache.org>
Signed-off-by: Michael Stack <stack@apache.org>
(cherry picked from commit f0d66273cd)
2020-05-29 15:22:52 -05:00
Michael Stack 6f1992f32f
HBASE-22287 inifinite retries on failed server in RSProcedureDispatcher (#1800)
Adds backoff in place of retry every 100ms.

Signed-off-by: Duo Zhang <zhangduo@apache.org>
2020-05-29 10:00:53 -07:00
Josh Elser 99a40ddacf HBASE-24280 Skip explicit hadoop3 profile activation on master
On 2.x branches, we need to explicitly activate profiles for H3. On
master, all H2 support is dropped which means no special profiles are
required for H3 (though, there is still a profile there to encapsulate
H3 logic).

We need to make sure that the yetus invocation can correctly pass down
any profile information into the personality, so we activate the exact
profiles we want.

Closes #1609

Co-authored-by: Istvan Toth <stoty@cloudera.com>
Signed-off-by: stack <stack@apache.org>
2020-05-29 12:27:58 -04:00
xincunSong 8edcbb4441
HBASE-24470 : Add store file info when log meessages in HStore. (#1804)
Signed-off-by: binlijin <binlijin@gmail.com>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2020-05-29 19:01:12 +05:30
Viraj Jasani bce06627bb
HBASE-24428 : Fix for testSplitCompactWithPriority (ADDENDUM) 2020-05-29 18:24:12 +05:30
bsglz 22efe67758
HBASE-24451 Remove the HasThread because the related bug had been fixed since jdk7 (#1797)
Signed-off-by: stack <stack@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2020-05-29 17:46:03 +05:30
Alexander Myasnikov 60c125367b HBASE-24434 Fix building cpp-example DemoClient
Changed boost::shared_ptr to std::shared_ptr for compatibility with apache thrift v0.13.

Signed-off-by: Bharath Vissapragada <bharathv@apache.org>
2020-05-27 14:05:29 -07:00
Viraj Jasani 1e86ff09d7
HBASE-24428 : Update compaction priority for recently split daughter regions (#1784)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2020-05-27 20:58:57 +05:30
binlijin c94b946b31 HBASE-24371 Add more details when print CompactionConfiguration info (#1711)
Signed-off-by: Anoop Sam John <anoopsamjohn@apache.org>
2020-05-27 19:48:53 +08:00
Duo Zhang 441935a9d9 HBASE-24437 Addendum just start mini dfs cluster, and make the log roll more robust (#1787)
Signed-off-by: stack <stack@apache.org>
2020-05-27 11:26:35 +08:00
Michael Stack f8a5cc92af
HBASE-24425 Run hbck_chore_run and catalogjanitor_run on draw of 'HBCK Report' page (#1771)
Signed-off-by: clarax
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
Signed-off-by: Huaxiang Sun <huaxiangsun@apache.com>
2020-05-26 19:50:23 -07:00
Zheng Wang 1e16d385f8 HBASE-24423 No need to get lock in canSplit because hasReferences will get lock too
Signed-off-by: Bharath Vissapragada <bharathv@apache.org>
2020-05-26 13:37:29 -07:00
stack 3ef44a4dcf HBASE-24437 Flaky test, TestLocalRegionOnTwoFileSystems#testFlushAndCompact
Force another WAL roll just in case and make the check more loose (its
about whether the files are present, not their count)
2020-05-26 11:55:09 -07:00
huaxiangsun 90bd19e55b
HBASE-24379 CatalogJanitor misreports region holes when there are actually over laps. (#1741) (#1777)
Signed-off-by: stack <stack@apache.org>
2020-05-26 10:06:13 -07:00
XinSun d285c6b681 HBASE-24416 RegionNormalizer spliting region should not be limited by hbase.normalizer.min.region.count (#1770)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
2020-05-26 17:05:16 +08:00
huaxiangsun 51a84025cb
HBASE-24369 Provide more information about merged child regions in Hbck Overlaps section, which cannot be fixed immediately (#1756) (#1768)
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
Signed-off-by: Clara Xiong
Signed-off-by: stack <stack@apache.org>
2020-05-25 16:00:39 -07:00
WenFeiYi b0fd3fc3e2
HBASE-24427 HStore.add log format error (#1773)
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2020-05-25 18:30:00 +05:30
Viraj Jasani 9d364af796
HBASE-24426 : Provide regionName in warning during failure to move region from CLOSING to CLOSED (#1772)
Signed-off-by: Anoop Sam John <anoopsamjohn@apache.org>
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
2020-05-25 17:38:01 +05:30
Guangxu Cheng 9fb934eb2c HBASE-24417 update copyright notices year to 2020 (#1760)
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com> 
Signed-off-by: Clara
2020-05-25 13:00:27 +08:00
wenbang 03929770fe HBASE-24401 Cell size limit check on append should consider 0 or less value to disable the check (#1742)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
2020-05-25 10:05:18 +08:00
niuyulin 61eb7e5003 HBASE-24387 TableSnapshotInputFormatImpl support row limit on each InputSplit (#1731)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
2020-05-25 10:05:09 +08:00
Duo Zhang 58eed9a4bb HBASE-24408 Introduce a general 'local region' to store data on master (#1753)
Signed-off-by: stack <stack@apache.org>
2020-05-23 16:40:39 +08:00
huaxiangsun be9e12d626
HBASE-24370 Avoid aggressive MergeRegion and GCMultipleMergedRegionsProcedure (#1719) (#1763)
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
2020-05-22 16:40:16 -07:00
Viraj Jasani 2383cc4242
HBASE-24405 : Document hbase:slowlog related operations (#1747)
Signed-off-by: ramkrish86 <ramkrishna@apache.org>
Signed-off-by: Anoop Sam John <anoopsamjohn@apache.org>
2020-05-22 20:58:04 +05:30
huaxiangsun b144d17044
HBASE-24376 MergeNormalizer is merging non-adjacent regions and causing region overlaps/holes. (#1734) (#1758)
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
Signed-off-by: stack <stack@apache.org>
2020-05-22 08:09:36 -07:00
meiyi a41d2a3030 HBASE-24364 [Chaos Monkey] Invalid data block encoding in ChangeEncodingAction (#1707)
Signed-off-by: Jan Hentschel <janh@apache.org>
2020-05-20 18:26:08 +08:00