8686 Commits

Author SHA1 Message Date
Andrew Purtell
e46fbedf56 HBASE-26761 TestMobStoreScanner (testGetMassive) can OOME (#4204)
Change the timing of the test but not the objective by storing three large
MOB values into the row with three separate puts, each randomizing the
data. Increases running time of the testGetMassive case 2x but avoids OOME
in the test environment where the OOME was consistently reproductable.

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Pankaj Kumar <pankajkumar@apache.org>
2022-03-11 15:12:51 +08:00
Andrew Purtell
0b879f2054 HBASE-26824 TestHBaseTestingUtil.testResolvePortConflict failing after HBASE-26582 (#4203)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>
2022-03-11 14:54:49 +08:00
Xiaolin Ha
8c42bca86e HBASE-26816 Fix CME in ReplicationSourceManager (#4187)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-03-11 11:49:29 +08:00
Andrew Purtell
49d3a00652 HBASE-26715 Blocked on SyncFuture in AsyncProtobufLogWriter#write (#4184)
Co-authored-by: Bryan Beaudreault <bbeaudreault@gmail.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Viraj Jasani<virajjasani@apache.org>
Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>
2022-03-10 11:57:01 -08:00
Bryan Beaudreault
fac011ed87 HBASE-26814 Addendum: Fix spotbugs warning and clarify intent (#4201)
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-03-10 10:10:12 -08:00
Bryan Beaudreault
8a4317838b HBASE-26814 Default StoreHotnessProtector to off, with logs to guide when to turn it on (#4194)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-03-09 14:44:23 -08:00
Bryan Beaudreault
91cb3028c4
HBASE-26783 ScannerCallable doubly clears meta cache on retries (#4147)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-03-09 12:02:51 -08:00
Nick Dimiduk
7e267c6069 HBASE-26782 Minor code cleanup in and around RpcExecutor
Signed-off-by: Bharath Vissapragada <bharathv@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-03-09 12:44:54 +01:00
Andrew Purtell
300f9b9576 HBASE-26582 Prune use of Random and SecureRandom objects (#4118)
Avoid the pattern where a Random object is allocated, used once or twice, and
then left for GC. This pattern triggers warnings from some static analysis tools
because this pattern leads to poor effective randomness. In a few cases we were
legitimately suffering from this issue; in others a change is still good to
reduce noise in analysis results.

Use ThreadLocalRandom where there is no requirement to set the seed to gain
good reuse.

Where useful relax use of SecureRandom to simply Random or ThreadLocalRandom,
which are unlikely to block if the system entropy pool is low, if we don't need
crypographically strong randomness for the use case. The exception to this is
normalization of use of Bytes#random to fill byte arrays with randomness.
Because Bytes#random may be used to generate key material it must be backed by
SecureRandom.

Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-03-08 15:22:00 -08:00
Bryan Beaudreault
5bae04e20c
HBASE-26784 Use HIGH_QOS for ResultScanner.close requests (#4163)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>
2022-03-08 10:50:00 +08:00
Xiaolin Ha
f4c91ee65b
HBASE-26552 Introduce retry to logroller to avoid abort (#4170)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-03-07 16:41:49 +08:00
Xiaolin Ha
1aff89e0e4 HBASE-25709 Close region may stuck when region is compacting and skipped most cells read (#3117)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-03-07 11:45:40 +08:00
Rushabh Shah
0a7e49ca3b
HBASE-26792 Implement ScanInfo#toString (#4154)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-03-05 17:45:45 +08:00
Nick Dimiduk
01acd870b7 HBASE-26759 Fix trace continuity through CallRunner (#4126)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-03-04 15:26:48 -08:00
Andrew Purtell
961796a59e [branch-2] Amend HBASE-26731 Add metrics for active and expired scanners
Compliation fixes

Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-03-04 14:14:12 -08:00
Bryan Beaudreault
fc92a00bd1 HBASE-26731 Add metrics for active and expired scanners (#4145)
Signed-off-by: Andrew Purtell <apurtell@apache.org>

Conflicts:
	hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServer.java
	hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegionServer.java
2022-03-04 14:06:13 -08:00
Istvan Toth
eb1c57d12e HBASE-26777 BufferedDataBlockEncoder$OffheapDecodedExtendedCell.deepC… (#4139)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-03-04 13:50:03 -08:00
Duo Zhang
4644efb9f3
HBASE-26691 Replacing log4j with reload4j for branch-2.x (#4050)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-03-04 12:06:34 -08:00
Xiaolin Ha
df90a4ba6b HBASE-26242 Allow split when store file count larger than the configed blocking file count (#3652)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-03-04 20:47:50 +08:00
haxiaolin
b5ac6380c4 Revert "HBASE-26242 Allow split when store file count larger than the configed blocking file count (#3652)"
This reverts commit 2fa4bb0313bf8c1f0b2c314a6541a3b89c16b581.
2022-03-04 20:38:32 +08:00
Xiaolin Ha
2fa4bb0313 HBASE-26242 Allow split when store file count larger than the configed blocking file count (#3652)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-03-04 20:25:23 +08:00
Nick Dimiduk
87ce5755cd
HBASE-26764 Implement generic exception support for TraceUtil methods over Callables and Runnables
For the `TraceUtil` methods that accept `Callable` and `Runnable` types, make them generic over a
child of `Throwable`. This allows us to consolidate the two method signatures into a single more
flexible definition.

Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-03-04 09:19:03 +01:00
Mike Drob
8a9e083994 HBASE-26622 Update error-prone to 2.10
Author:    Mike Drob <mdrob@apache.org>
Co-authored-by: Nick Dimiduk <ndimiduk@apache.org>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-03-03 11:51:51 +01:00
Niels Basjes
c5f63550b7 HBASE-26762 Un-Deprecate and improve documentation for Scan#setRowPrefixFilter (#4119)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-03-02 23:34:17 +08:00
Nick Dimiduk
e93abe687b HBASE-26776 RpcServer failure to SASL handshake always logs user "unknown" to audit log (#4138)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
2022-03-02 15:51:27 +01:00
BukrosSzabolcs
77bb153a2e
HBASE-26707: Reduce number of renames during bulkload (#4066) (#4122)
Signed-off-by: Wellington Ramos Chevreuil <wchevreuil@apache.org>
2022-02-25 20:11:41 +00:00
Duo Zhang
4cdb380ccc HBASE-26640 Reimplement master local region initialization to better work with SFT (#4111)
Signed-off-by: Josh Elser <elserj@apache.org>
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
2022-02-24 11:09:50 +08:00
Bryan Beaudreault
5118e7199c HBASE-26703 Allow configuration of IPC queue balancer (#4063)
Signed-off-by: Andrew Purtell <apurtell@apache.org>

Conflicts:
	hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcExecutor.java
2022-02-18 17:49:41 -08:00
Bryan Beaudreault
2a7b413b71 HBASE-26727 Fix CallDroppedException reporting (#4088)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-02-18 17:27:52 -08:00
Richard Marscher
1145581489 HBASE-26576 Allow pluggable queue to be used with the fast path executor or normal balanced executor (#3944)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-02-18 10:19:12 -08:00
Yutong Xiao
cb225f1d90 HBASE-26659 The ByteBuffer of metadata in RAMQueueEntry in BucketCache could be reused. (#4026)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-02-19 00:41:49 +08:00
chenglei
07d638161c
HBASE-26712 Balancer encounters NPE in rare case (#4112) (#4092)
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2022-02-16 12:12:56 +05:30
Xiaolin Ha
69062916a3 HBASE-26742 Comparator of NOT_EQUAL NULL is invalid for checkAndMutate (#4105)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-02-16 11:22:37 +08:00
Andrew Purtell
3e84e50107
HBASE-26730 Extend hbase shell 'status' command to support an option 'tasks' (#4094)
Signed-off-by: Geoffrey Jacoby <gjacoby@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2022-02-15 18:38:25 -08:00
Xiaolin Ha
55a83ac1af HBASE-26434 Do compact when all L0 files are expired (#3830)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-02-15 22:37:40 +08:00
Yutong Xiao
1bee6046f0 HBASE-26688 Threads shared EMPTY_RESULT may lead to unexpected client job down (#4073)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-02-15 20:30:55 +08:00
Nick Dimiduk
d242c8fafa HBASE-26521 Name RPC spans as $package.$service/$method (#4024)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-02-10 12:57:45 +01:00
Duo Zhang
d747da6985 HBASE-26709 Ban the usage of junit 3 TestCase (#4065)
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
2022-02-10 01:06:06 +08:00
Duo Zhang
cbbb1a0542
HBASE-26724 Backport the UT changes in HBASE-24510 to branch-2.x (#4081)
Signed-off-by: Xin Sun <ddupgs@gmail.com>
2022-02-09 21:45:52 +08:00
Tak Lon (Stephen) Wu
f637a60bdd
HBASE-26729 Backport "HBASE-26714 Introduce path configuration for system coprocessors" to branch-2 (#4093)
- rename from HBaseCommonTestingUtil to HBaseCommonTestingUtility

Signed-off-by: Ankit Singhal <ankit@apache.org>
2022-02-04 05:56:23 -08:00
Andrew Purtell
08c2c65957
HBASE-26726 Allow disable of region warmup before graceful move (#4086)
Signed-off-by: Viraj Jasani<virajjasani@apache.org>
2022-02-01 15:38:31 -08:00
Duo Zhang
dffeb8e63e
HBASE-26587 Introduce a new Admin API to change SFT implementation (#4030) (#4080)
Signed-off-by: Wellington Ramos Chevreuil <wchevreuil@apache.org>
Reviewed-by: Josh Elser <elserj@apache.org>
2022-01-30 20:43:23 +08:00
Bryan Beaudreault
76eb1b091d
HBASE-26713 Default to LATEST_TIMESTAMP if no timestamp sent along on Increment/Append (#4075)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2022-01-28 12:55:51 -08:00
Duo Zhang
a8b68c9b88 HBASE-26690 Modify FSTableDescriptors to not rely on renaming when writing TableDescriptor (#4054)
Signed-off-by: Wellington Ramos Chevreuil <wchevreuil@apache.org>
2022-01-27 13:38:11 +08:00
Nick Dimiduk
d8085b43fc HBASE-26614 Refactor code related to "dump"ing ZK nodes (#3969)
The code starting at `ZKUtil.dump(ZKWatcher)` is a small mess – it has cyclic dependencies woven
through itself, `ZKWatcher` and `RecoverableZooKeeper`. It also initializes a static variable in
`ZKUtil` through the factory for `RecoverableZooKeeper` instances. Let's decouple and clean it
up.

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Josh Elser <elserj@apache.org>
2022-01-25 09:08:35 -08:00
Duo Zhang
3021c58513 HBASE-26700 The way we bypass broken track file is not enough in StoreFileListFile (#4055)
Signed-off-by: Wellington Ramos Chevreuil <wchevreuil@apache.org>
2022-01-25 15:12:38 +08:00
Duo Zhang
5aa0fd2651 HBASE-26675 Data race on Compactor.writer (#4035)
Signed-off-by: Xin Sun <ddupgs@gmail.com>
2022-01-24 19:52:31 +08:00
Peter Somogyi
d9a20630b0
HBASE-26689 Backport HBASE-24443 Refactor TestCustomSaslAuthenticationProvider (#4049)
Duo Zhang <zhangduo@apache.org>
2022-01-20 15:04:31 +01:00
Duo Zhang
8fbc9a2606 HBASE-26674 Should modify filesCompacting under storeWriteLock (#4040)
Signed-off-by: Josh Elser <elserj@apache.org>
2022-01-19 16:53:00 +08:00
Nick Dimiduk
d4f2b66a43
HBASE-26474 Implement connection-level attributes (#4014)
Add support for `db.system`, `db.connection_string`, `db.user`.

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Huaxiang Sun <huaxiangsun@apache.org>
Co-authored-by: Josh Elser <josh.elser@gmail.com>
2022-01-18 12:29:35 -08:00