Commit Graph

2515 Commits

Author SHA1 Message Date
Bryan Beaudreault 1e97fbfc9f HBASE-27768 Race conditions in BlockingRpcConnection (#5154)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>
2023-04-10 15:23:34 -04:00
Victor 56613517fb
HBASE-27684: add client metrics related to user region lock. (#5081)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: David Manning <david.manning@salesforce.com>
Signed-off-by: Rushabh Shah <shahrs87@apache.org>
Signed-off-by: Tanuj Khurana <tkhurana@apache.org>
2023-03-20 22:37:05 -07:00
Nihal Jain 620ab79b59
HBASE-27671 Client should not be able to restore/clone a snapshot after it has TTL expired it's TTL has expired (#5117) ( #5109)
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2023-03-18 00:08:34 -07:00
Nick Dimiduk d151af1663
HBASE-27652 Client-side lock contention around Configuration when using read replica regions
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2023-03-15 16:08:19 +01:00
huaxiangsun 6e31c18bf2 HBASE-27250 MasterRpcService#setRegionStateInMeta does not support replica region encodedNames or region names
- Added sanity check to make sure input region encoded name or region name is valid
- Assignment improvements pertaining to read replica regions
- make several MetaTableAccessor methods more precise in their handling of replica regions
- hbck2 setRegionStateInMeta and HBCKServerCrashProcedure handle read replicas
- separate AM helper methods -- loading RegionInfo from cache vs. refreshing cache from meta
- AM helper method support loading RegionInfo from cache via either region name and encoded region
  name (both caches are maintained, and under lock)
- consolidate, extend tests to cover read replica regions

Co-authored-by: Huaxiang Sun <huaxiangsun@apache.com>
Co-authored-by: Nick Dimiduk <ndimiduk@apache.org>
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
2023-03-08 14:41:48 +01:00
Duo Zhang c319c6f0a3 HBASE-27668 PB's parseDelimitedFrom can successfully return when there are not enough bytes (#5059)
Signed-off-by: Viraj Jasani <vjasani@apache.org>
(cherry picked from commit d1fede72c3)
2023-02-28 10:08:19 +08:00
Bryan Beaudreault a3ed4a19d7 HBASE-27650 Merging empty regions corrupts meta cache (branch-2) (#5038)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2023-02-27 20:41:04 -05:00
Victor 7cb4a58bb1 HBASE-15242: add client side metrics for timeout and remote exceptions. (#5023)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2023-02-24 16:29:22 -08:00
Nihal Jain a38ffec51b HBASE-27626 Suppress noisy logging in client.ConnectionImplementation (#5019)
Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org>
2023-02-09 10:31:10 -08:00
chaijunjie0101 4caa19f6a9 HBASE-26967 FilterList with FuzzyRowFilter and SingleColumnValueFilter evaluated with operator MUST_PASS_ONE doesn't work as expected(#4820)
Close #4820

Co-authored-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 382681e2d6)
2023-01-29 17:39:59 +08:00
Andrew Purtell e124b31815 HBASE-27561 hbase.master.port is ignored in processing of hbase.masters (#4952)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Reid Chan <reidchan@apache.org>
2023-01-17 13:21:07 -08:00
Bryan Beaudreault 1c98931267 HBASE-27531 AsyncRequestFutureImpl unnecessarily clears meta cache for full server (#4930)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2023-01-10 07:56:00 -05:00
Victor 6ee8dd2bcf HBASE-27540 add client side counter metrics for failed rpc calls (#4929)
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
2022-12-21 08:53:27 -05:00
Bri Augenreich dd60d7f86e HBASE-27491 Do not clear cache on RejectedExecutionException (#4914)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
2022-12-09 08:46:40 -05:00
Vaibhav Joshi 748ec455b3
HBASE-27498: Added logic in ConnectionImplementation.getKeepAliveMasterService to avoid expensive rpc calls in synchronized block (#4889)
Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org>
2022-12-08 08:15:23 -08:00
Bryan Beaudreault ed8549b3f6 HBASE-27490 Locating regions for all actions of batch requests can exceed operation timeout (#4908)
Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>
2022-12-06 08:04:07 -05:00
Victor 3e3c8fa700
HBASE-27466: Making metrics instance containing one or more connections. (#4874) (#4909)
Signed-off-by: David Manning <67607031+d-c-manning@users.noreply.github.com>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2022-12-05 12:23:26 -08:00
Bri Augenreich 1bfc58a369 HBASE-27487: Slow meta can create pathological feedback loop with multigets (#4900)
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-12-01 08:15:52 -05:00
Bri Augenreich 8b5fe81c03 HBASE-27494: Fix missing meta cache dropping exception metrics (#4902)
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
2022-11-30 13:05:49 -05:00
Bri Augenreich 2d038edf4c HBASE-26809: Report client backoff time for server overloaded (#4786)
Co-authored-by: Briana Augenreich <baugenreich@hubspot.com>
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
2022-11-15 15:41:40 -05:00
Duo Zhang f3a64e468e HBASE-27434 Use ${revision} as placeholder for maven version to make it easier to control the version from command line (#4836)
Signed-off-by: GeorryHuang <huangzhuoyue@apache.org>
(cherry picked from commit 2fc879e863)
2022-10-24 12:16:04 +08:00
Andrew Purtell 27d69ff53f Preparing development version 2.5.2-SNAPSHOT
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-10-17 15:37:08 -07:00
Andrew Purtell 894ac15342 Preparing hbase release 2.5.1RC1; tagging and updates to CHANGES.md and RELEASENOTES.md
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-10-17 15:37:04 -07:00
Andrew Purtell a8605912ec Preparing development version 2.5.2-SNAPSHOT
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-10-13 09:11:37 -07:00
Andrew Purtell edf0b62273 Preparing hbase release 2.5.1RC0; tagging and updates to CHANGES.md and RELEASENOTES.md
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-10-13 09:11:34 -07:00
Andrew Purtell 39978b80ab HBASE-27339 Improve sasl connection failure log message to include server (#4823)
Include the remote server name in the logged exception message when the
connection setup fails in BlockingRpcConnection.

Add an equivalent log line in NettyRpcConnection.

Signed-off-by: Viraj Jasani <vjasani@apache.org>

Conflicts:
	hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java
2022-10-11 10:23:06 -07:00
Duo Zhang fb988373c1 HBASE-27401 Clean up current broken 'n's in our javadoc (#4812)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
(cherry picked from commit 63cdd026f0)

Conflicts:
	hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManager.java
	hbase-client/src/main/java/org/apache/hadoop/hbase/HRegionLocation.java
	hbase-client/src/main/java/org/apache/hadoop/hbase/client/Append.java
	hbase-client/src/main/java/org/apache/hadoop/hbase/client/Mutation.java
	hbase-client/src/main/java/org/apache/hadoop/hbase/client/Scan.java
	hbase-client/src/main/java/org/apache/hadoop/hbase/filter/SingleColumnValueExcludeFilter.java
	hbase-client/src/main/java/org/apache/hadoop/hbase/filter/SingleColumnValueFilter.java
	hbase-client/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityClient.java
	hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/RequestConverter.java
	hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java
	hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestReplication.java
	hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/client/TestRemoteTable.java
	hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManager.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/HBaseServerBase.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/MasterObserver.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobUtils.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/procedure/flush/RegionServerFlushTableProcedureManager.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Region.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/replication/HBaseReplicationEndpoint.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsSource.java
	hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtil.java
	hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
	hbase-server/src/test/java/org/apache/hadoop/hbase/tool/TestBulkLoadHFilesSplitRecovery.java
	hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftUtilities.java
2022-10-06 23:01:14 +08:00
Bryan Beaudreault 4c9185b37d HBASE-27381 Still seeing 'Stuck' in static initialization creating RegionInfo instance (#4813)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-10-04 08:30:15 -04:00
Bryan Beaudreault ad395b49ff HBASE-27391 Downgrade ERROR log to DEBUG in ConnectionUtils.updateStats (#4804)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-09-28 11:34:17 -04:00
Duo Zhang ca86eea482
HBASE-27373 Fix new spotbugs warnings after upgrading spotbugs to 4.7.2 (#4787) (#4790)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
2022-09-19 07:56:47 +08:00
binlijin 18c23f75f5 HBASE-27314 Make index block be customized and configured (#4763)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-09-13 10:10:10 +08:00
Duo Zhang c1cad7f653 HBASE-27360 The trace related assertions are flaky for async client tests (#4767)
Signed-off-by: GeorryHuang <huangzhuoyue@apache.org>
(cherry picked from commit f3f88ff6c1)
2022-09-09 23:03:16 +08:00
LiangJun He 5f6998b955 HBASE-27335 HBase shell hang for a minute when quiting (#4737)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 6a7a91a256)
2022-08-31 11:06:45 +08:00
Nick Dimiduk f1f79b9efe Preparing development version 2.5.1-SNAPSHOT
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
2022-08-23 15:44:51 +00:00
Nick Dimiduk 2ecd8bd6d6 Preparing hbase release 2.5.0RC1; tagging and updates to CHANGES.md and RELEASENOTES.md
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
2022-08-23 15:44:34 +00:00
Nick Dimiduk 29475d6edb Preparing development version 2.5.1-SNAPSHOT
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
2022-08-23 14:04:18 +00:00
Nick Dimiduk 6cdbc46c02 Preparing hbase release 2.5.0RC1; tagging and updates to CHANGES.md and RELEASENOTES.md
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
2022-08-23 14:03:59 +00:00
LiangJun He 78f587f559 HBASE-27104 Add a tool command list_unknownservers (#4714)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 1bd0b581cb)
2022-08-22 21:26:19 +08:00
Fantasy-Jay 46ffdabd13 HBASE-27268 In trace log mode, the client does not print callId/startTime and the server does not print receiveTime (#4710)
Co-authored-by: jay.zhu <jay.zhu@huolala.cn>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 32c135d8a5)
2022-08-20 21:09:53 +08:00
SiCheng-Zheng 0ceb3577fc HBASE-27301 Add Delete addFamilyVersion timestamp verify (#4700)
Co-authored-by: SiCheng-Zheng <zhengsicheng@jd.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit b531e71455)
2022-08-15 15:23:34 +08:00
Peter Somogyi ad6770652f HBASE-27281 Add default implementation for Connection$getClusterId (#4683)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-08-11 17:21:33 +02:00
Duo Zhang 187c084cf2 HBASE-27283 Use readTO instead of hard coded RpcClient.DEFAULT_SOCKET_TIMEOUT_READ when creating ReadTimeoutHandler in NettyRpcConnection (#4685)
Signed-off-by: Xin Sun <ddupgs@gmail.com
Signed-off-by: GeorryHuang <huangzhuoyue@apache.org>
(cherry picked from commit 5919b30b6d)
2022-08-09 16:23:08 +08:00
Duo Zhang 1720ced4c5 HBASE-27271 BufferCallBeforeInitHandler should ignore the flush request (#4676)
Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
(cherry picked from commit fb529e2352)

Conflicts:
	hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java
2022-08-04 23:03:52 +08:00
Nick Dimiduk 472e81098e HBASE-27153 Improvements to read-path tracing
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-08-02 14:10:05 +02:00
chenglei 95a2e59618 HBASE-27247 TestPerTableCFReplication.testParseTableCFsFromConfig is broken because of ReplicationPeerConfigUtil.parseTableCFsFromConfig (#4658)
Co-authored-by: comnetwork <comnetwork@163.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-07-27 17:57:09 -07:00
Andrew Purtell 6a169b5079 HBASE-27203 Clean up error-prone findings in hbase-client [branch-2] (#4651)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2022-07-27 15:59:06 -07:00
Duo Zhang 88f957b323 HBASE-27222 Purge FutureReturnValueIgnored warnings from error prone (#4634)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
(cherry picked from commit 8b091c4061)
2022-07-26 23:45:29 +08:00
Andrew Purtell 9cec74c503 HBASE-27204 BlockingRpcClient will hang for 20 seconds when SASL is enabled after finishing negotiation (#4642)
Revert "HBASE-24579: Failed SASL authentication does not result in an exception on client side (#1921)"

This reverts commit bd79c4065c.

When Kerberos authentication succeeds, on the server side, after
receiving the final SASL token from the client, we simply wait for
the client to continue by sending the connection header.
After HBASE-24579, on the client side, an additional readStatus()
was added, which mistakenly assumes that after negotiation has
completed a status code will be sent. However when authentication
has succeeded the server will not send one. As a result the client
will hang and only throw an exception when the configured read
timeout is reached, which is 20 seconds by default.

We cannot unilaterally send the expected additional status code
from the server side because older clients will not expect it. The
first call will fail because the client finds unexpected bytes in
the stream ahead of the call response. Fabricating a call response
also does not seem a viable strategy for backwards compatibility.

The HBASE-24579 change needs to be reconsidered given the
difficult backwards compatibility challenges here.

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2022-07-24 23:07:01 -07:00
Minwoo Kang ee56bcafb4 HBASE-27219 Change JONI encoding in RegexStringComparator (#4632)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-07-19 09:20:59 -07:00
Duo Zhang 9c3528d730 HBASE-27220 Apply the spotless format change in HBASE-27208 to our code base
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-07-19 10:03:26 +08:00