Commit Graph

6585 Commits

Author SHA1 Message Date
Josh Elser e10db9d29a HBASE-19953 Ensure post DDL hooks are only called after successful operations
The 1.x functionality of Master DDL operations is that "post" observer hooks
are only invoked when the DDL action was successful. With the async-ness of
ProcV2, we find ourselves in a case where the post-hook may be invoked before
the Procedure runs and fails. We need to introduce some blocking to wait and
see if the Procedure is going to fail on a precondition before invoking the hook.

Signed-off-by: Michael Stack <stack@apache.org>
2018-02-21 13:53:09 -05:00
zhangduo 30c2dcd883
HBASE-20037 Race when calling SequenceIdAccounting.resetHighest 2018-02-21 10:04:33 -08:00
anastas 2b4df5e36e HBASE-19506: The CellChunkMap index chunks are usually small, so in order to prevent memory underutilization, HBASE-19506 presents small chunks preallocated in a small pool 2018-02-21 10:19:49 +02:00
Chia-Ping Tsai bc1ac49de2 HBASE-20017 BufferedMutatorImpl submit the same mutation repeatedly
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2018-02-20 16:59:48 -08:00
Ted Yu cbd138d41a HBASE-19954 Separate TestBlockReorder into individual tests to avoid ShutdownHook suppression error against hadoop3 2018-02-20 14:56:46 -08:00
Michael Stack 7e2978787d HBASE-20029 @Ignore TestQuotaThrottle and TestReplicasClient#testCancelOfMultiGet 2018-02-20 12:08:35 -08:00
Michael Stack 9be0360c5d HBASE-20024 TestMergeTableRegionsProcedure is STILL flakey 2018-02-20 11:07:36 -08:00
zhangduo 0152d5e2ae HBASE-20021 TestFromClientSideWithCoprocessor is flakey 2018-02-20 06:24:22 -08:00
zhangduo 34d3e847cc HBASE-20020 Make sure we throw DoNotRetryIOException when ConnectionImplementation is closed 2018-02-20 06:10:45 -08:00
zhangduo c1fe9f441c HBASE-19978 The keepalive logic is incomplete in ProcedureExecutor 2018-02-19 17:13:16 -08:00
Reid Chan 4ef6319af0 HBASE-19950 Introduce a ColumnValueFilter
Signed-off-by: Chia-Ping Tsai <chia7712@gmail.com>
2018-02-20 05:05:19 +08:00
eshcar a458d7c400 HBASE-18294 Reduce global heap pressure: flush based on heap occupancy 2018-02-18 12:58:52 +02:00
Michael Stack 0082f55595 HBASE-20015 TestMergeTableRegionsProcedure and TestRegionMergeTransactionOnCluster flakey 2018-02-17 11:37:42 -08:00
Michael Stack 07bdd492f4 Revert "HBASE-20015 TestMergeTableRegionsProcedure and TestRegionMergeTransactionOnCluster flakey"
This reverts commit 72193650dd.
2018-02-16 23:21:56 -08:00
Michael Stack 3ea2ffcd57 HBASE-20013 TestZKPermissionWatcher is flakey 2018-02-16 23:19:07 -08:00
Michael Stack 72193650dd HBASE-20015 TestMergeTableRegionsProcedure and TestRegionMergeTransactionOnCluster flakey 2018-02-16 22:59:32 -08:00
Chia-Ping Tsai 34d5f2b70e HBASE-19680 BufferedMutatorImpl#mutate should wait the result from AP in order to throw the failed mutations 2018-02-17 07:27:23 +08:00
Michael Stack d59959d19e HBASE-20011 Disable TestRestoreSnapshotFromClientWithRegionReplicas; it is flakey. Needs attention. 2018-02-16 14:45:55 -08:00
Mike Drob 138f82c8c5 HBASE-19920 Lazy init for ProtobufUtil classloader 2018-02-16 09:11:45 -06:00
Umesh Agashe 70d3413ee2 HBASE-19988 Fixed chatty log from HRegion#lockRowsAndBuildMiniBatch() when interrupted while waiting on a row lock 2018-02-16 07:01:23 -08:00
Michael Stack 9f27fdaffc HBASE-20006 TestRestoreSnapshotFromClientWithRegionReplicas is flakey
Remove assert in splittableregionprocedure. It was in the prepare.
Was causing fail in legit case where a region split follows a
table split BEFORE the parent has been GC'd. The region split
finds the parent in SPLIT state which is right. The assert was
having us fail. No need.

Also disabled TestHTrace since not supported in 2.0.0 and flakey.
2018-02-15 20:44:39 -08:00
Michael Stack 13bc4fe33c
HBASE-19998 Flakey TestVisibilityLabelsWithDefaultVisLabelService
Only call server.checkIfShouldMoveSystemRegionAsync if a node has been
added. Do not call it if only one regionserver in cluster. Make it
so ServerCrashProcedure runs before it. Add logging if
server.checkIfShouldMoveSystemRegionAsync was responsible for
MOVE (Previous was a mystery when it cut in).

Previous we'd call it when there was a nodeChildrenChanged. These
happen before nodeDeleted. If a server crashed,
checkIfShouldMoveSystemRegionAsync could run first, find the
server that had not yet registered as crashed, find system
tables on it and then try to move them. It would fail because
server would not respond to RPC. The region move would then
be waiting on the servercrashprocedure to wake it up when
done processing but this move had locked the region so
SCP couldn't run....
2018-02-15 19:41:17 -08:00
Thiruvel Thirumoolan 65ac99b675 HBASE-19996 Some nonce procs might not be cleaned up (follow up HBASE-19756)
Signed-off-by: tedyu <yuzhihong@gmail.com>
2018-02-15 04:48:24 -08:00
anastas af804a586b HBASE-19930: Fixing the bug, in the rare case when there is a merge into CCM and the one of the old segments has a big cell allocated on-heap and it needs to be copied to the MSLAB 2018-02-15 14:35:41 +02:00
zhangduo ce5f5e6bcd HBASE-20000 Remove the quantum logic in FairQueue, always put high priority queue in front 2018-02-15 16:40:21 +08:00
Ben Lau 0743bda059 HBASE-18282 ReplicationLogCleaner can delete WALs not yet replicated in case of a KeeperException
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2018-02-14 17:23:09 -08:00
Toshihiro Suzuki 9cbf936f90 HBASE-19980 NullPointerException when restoring a snapshot after splitting a region
Signed-off-by: tedyu <yuzhihong@gmail.com>
2018-02-14 09:38:16 -08:00
Michael Stack 8a3b4cdc67 HBASE-19116 Currently the tail of hfiles with CellComparator* classname makes it so hbase1 can't open hbase2 written hfiles; fix
Serializing, if appropriate, write the hbase-1.x version of the
Comparator to the hfile trailer so hbase-1.x files can read hbase-2.x
hfiles (they are the same format).
2018-02-14 07:46:05 -08:00
Michael Stack 02bba3b788 HBASE-19998 Flakey TestVisibilityLabelsWithDefaultVisLabelService 2018-02-13 22:31:57 -08:00
Michael Stack 1f3c131371 HBASE-19965 Fix flaky TestAsyncRegionAdminApi; ADDENDUM do same to TestAsyncTableAdminAPI AGAIN (make TestAsyncTableAdminAPI3... already an TestAsyncTableAdminAPI2) 2018-02-13 21:05:34 -08:00
Pankaj Kumar 4594f7156d HBASE-19979 ReplicationSyncUp tool may leak Zookeeper connection 2018-02-13 08:43:52 -08:00
Michael Stack 562402ec23 Revert "HBASE-19970 Remove unused functions from TableAuthManager."
This reverts commit b19531f04b.
2018-02-13 06:18:35 -08:00
Chia-Ping Tsai 6923472f75 HBASE-19876 The exception happening in converting pb mutation to hbase.mutation messes up the CellScanner 2018-02-13 21:20:21 +08:00
Vasudevan 3623089cba HBASE-19977 FileMmapEngine allocation of byte buffers should be
synchronized (Ram)
2018-02-13 15:51:21 +05:30
Michael Stack 5b95ea01da HBASE-19965 Fix flaky TestAsyncRegionAdminApi; ADDENDUM do same to TestAsyncTableAdminAPI 2018-02-12 22:53:29 -08:00
Michael Stack 7104364a4d HBASE-19965 Fix flaky TestAsyncRegionAdminApi 2018-02-12 22:24:50 -08:00
Apekshit Sharma b19531f04b HBASE-19970 Remove unused functions from TableAuthManager.
Functions deleted: setTableUserPermissions, setTableGroupPermissions, setNamespaceUserPermissions,
setNamespaceGroupPermissions, writeTableToZooKeeper, writeNamespaceToZooKeeper
2018-02-12 16:02:48 -08:00
Michael Stack e94f082776 HBASE-19986 If HBaseTestClassRule timesout a test, thread dump 2018-02-12 15:13:42 -08:00
Michael Stack 1ae64ccee0 HBASE-19972 Should rethrow the RetriesExhaustedWithDetailsException when failed to apply the batch in ReplicationSink; ADDENDUM to fix TestReplicationSink 2018-02-12 10:48:21 -08:00
Michael Stack c7473df2c3 HBASE-16060 1.x clients cannot access table state talking to 2.0 cluster
This patch adds mirroring of table state out to zookeeper. HBase-1.x
clients look for table state in zookeeper, not in hbase:meta where
hbase-2.x maintains table state.

The patch also moves and refactors the 'migration' code that was put in
place by HBASE-13032.

D hbase-client/src/main/java/org/apache/hadoop/hbase/CoordinatedStateException.java
 Unused.

M hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
 Move table state migration code from Master startup out to
TableStateManager where it belongs. Also start
MirroringTableStateManager dependent on config.

A hbase-server/src/main/java/org/apache/hadoop/hbase/master/MirroringTableStateManager.java

M hbase-server/src/main/java/org/apache/hadoop/hbase/master/TableStateManager.java
 Move migration from zookeeper of table state in here. Also plumb in
mechanism so subclass can get a chance to look at table state as we do
the startup fixup full-table scan of meta.

M hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
 Bug-fix. Now we create regions in CLOSED state but we fail to check
table state; were presuming table always enabled. Meant on startup
there'd be an unassigned region that never got assigned.

A hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMirroringTableStateManager.java
 Test migration and mirroring.
2018-02-12 08:22:14 -08:00
zhangduo 43f507dfa8 HBASE-19554 Dump thread info before failure 2018-02-12 16:06:50 +08:00
huzheng d793db7c7d HBASE-19972 Should rethrow the RetriesExhaustedWithDetailsException when failed to apply the batch in ReplicationSink 2018-02-12 15:15:08 +08:00
zhangduo 3f127063ff HBASE-19966 The WriteEntry for WALKey maybe null if we failed to call WAL.append 2018-02-09 19:11:08 -08:00
Guanghao Zhang 4461cb7d7a HBASE-19942 (addendum) Fix flaky TestSimpleRpcScheduler 2018-02-09 13:38:05 +08:00
Aman Poonia bc080e7500 HBASE-19835 Use explicit casting to avoid side effects
Signed-off-by: tedyu <yuzhihong@gmail.com>
2018-02-08 12:33:08 -08:00
Michael Stack c93ba37dfc HBASE-19956 Remove category as a consideration timing out tests; set all test to timeout at 10minutes regardless 2018-02-07 20:10:36 -08:00
Michael Stack 8f1e01b6e5 HBASE-19951 Cleanup the explicit timeout value for test method 2018-02-07 16:39:54 -08:00
Mike Drob 7d449892af HBASE-19947 ITU should overwrite HTU local FS 2018-02-07 16:56:11 -06:00
zhangduo e71b0bf19d HBASE-19929 Call RS.stop on a session expired RS may hang 2018-02-07 15:53:08 +08:00
Chia-Ping Tsai e2636c81f7 HBASE-19900 Region-level exception destroy the result of batch 2018-02-07 08:38:04 +08:00
Guanghao Zhang f481386e3e HBASE-19942 Fix flaky TestSimpleRpcScheduler 2018-02-07 08:00:01 +08:00
Balazs Meszaros 4d24b19822 HBASE-19886 Display maintenance mode in shell, web UI 2018-02-06 14:53:48 -08:00
Mike Drob f155da3791 HBASE-19946 More test clean up for local-mode HTU 2018-02-06 15:39:17 -06:00
Michael Stack 89baad5bbe HBASE-19940 TestMetaShutdownHandler flakey; ADDENDUM: yet more debug 2018-02-06 09:48:26 -08:00
Michael Stack ca6b37d63c HBASE-19940 TestMetaShutdownHandler flakey; ADDENDUM: more debug 2018-02-06 06:35:02 -08:00
Guanghao Zhang fb480775d5 HBASE-19944 Fix timeout TestVisibilityLabelsWithCustomVisLabService
Signed-off-by: zhangduo <zhangduo@apache.org>
2018-02-06 20:30:16 +08:00
Umesh Agashe e4aeb46177 HBASE-19941 Flaky TestCreateTableProcedure times out in nightly, needs to LargeTests 2018-02-05 22:11:53 -08:00
tedyu b9175680b6 HBASE-19934 HBaseSnapshotException when read replicas is enabled and online snapshot is taken after region splitting (Toshihiro Suzuki) 2018-02-05 21:06:20 -08:00
Umesh Agashe 53e5707224
HBASE-19939 Fixed NPE in tests TestSplitTableRegionProcedure#testSplitWithoutPONR() and testRecoveryAndDoubleExecution()
Value of 'htd' is null as it is initialized in the constructor but when the object is deserialized its null. Got rid of member variable htd and made it local to method.
2018-02-05 20:48:20 -08:00
zhangduo 8b6b3326a6 HBASE-19927 Addendum join on RegionServerThread instead of HRegionServer 2018-02-06 10:01:41 +08:00
Michael Stack 7723a3d60d HBASE-19940 TestMetaShutdownHandler flakey 2018-02-05 12:38:51 -08:00
Michael Stack a1600c1490 HBASE-19840 Flakey TestMetaWithReplicas; ADDENDUM Adding debug 2018-02-05 11:00:46 -08:00
Michael Stack 29016bc100 HBASE-19837 Flakey TestRegionLoad; ADDENDUM Report more often and wait less time on change (also add some debug on TestMetaShutdown test) 2018-02-05 08:39:52 -08:00
Rajeshbabu Chintaguntla f0a5f12d97 HBASE-19703 Functionality added as part of HBASE-12583 is not working after moving the split code to master
Co-authored-by: Michael Stack <stack@apache.org>

Signed-off-by: Chia-Ping Tsai <chia7712@gmail.com>
2018-02-05 23:41:32 +08:00
anastas 514eadbe95 HBASE-19658 make the test testFlatteningToJumboCellChunkMap() stable, by eliminating the possibility of third cell to be added while in-memory-flush is still in progress 2018-02-05 11:29:10 +02:00
zhangduo 30a7e4a35c HBASE-19554 reenable TestDLSAsyncFSWAL/TestDLSFSHLog for debugging 2018-02-05 08:58:30 +08:00
zhangduo 054acca866 HBASE-19927 TestFullLogReconstruction flakey 2018-02-05 08:41:37 +08:00
Michael Stack 32d1903377 HBASE-19931 TestMetaWithReplicas failing 100% of the time in testHBaseFsckWithMetaReplicas 2018-02-04 14:37:13 -08:00
Ashish Singhi 2d5b36d194 HBASE-19905 ReplicationSyncUp tool will not exit if a peer replication is disabled
Signed-off-by: Ashish Singhi <ashishsinghi@apache.org>
2018-02-04 18:12:46 +05:30
zhangduo 3b603d2c08 HBASE-19926 Use a separated class to implement the WALActionListener for Replication 2018-02-04 20:32:14 +08:00
zhangduo cb138c2da8 HBASE-19914 Refactor TestVisibilityLabelsOnNewVersionBehaviorTable 2018-02-04 13:37:09 +08:00
Michael Stack a3233572ac HBASE-19928 TestVisibilityLabelsOnNewVersionBehaviorTable fails 2018-02-03 10:17:16 -08:00
Michael Stack 00653a4d18 HBASE-19919 Tidying up logging; ADDENDUM Fix tests w/ mocked Servers 2018-02-03 09:25:45 -08:00
zhangduo 66a11f2ac0 HBASE-19904 Break dependency of WAL constructor on Replication 2018-02-03 17:11:30 +08:00
Michael Stack bac4687345 HBASE-19919 Tidying up logging 2018-02-02 22:42:30 -08:00
Michael Stack 897afb7d18
HBASE-19726 Failed to start HMaster due to infinite retrying on meta assign 2018-02-02 18:30:24 -08:00
Guanghao Zhang 3398637bcd HBASE-19918 Promote TestAsyncClusterAdminApi to LargeTests 2018-02-03 09:40:58 +08:00
Chia-Ping Tsai b0bf6f504e HBASE-19720 Rename WALKey#getTabnename to WALKey#getTableName 2018-02-02 20:02:04 +08:00
tedyu efed668f74 HBASE-19895 Add keepDeletedCells option in ScanOptions for customizing scanInfo in pre-hooks (Ankit Singhal) 2018-02-01 18:28:05 -08:00
Mike Drob a165bd766a HBASE-19841 Every HTU should be local until DFS starts 2018-02-01 20:23:56 -06:00
zhangduo 79ccb0b38e HBASE-19913 Split TestStochasticLoadBalancer2 2018-02-02 08:29:33 +08:00
Michael Stack ea8290f3dc HBASE-19147 TestCacheOnWrite Times Out 2018-02-01 16:15:50 -08:00
Chia-Ping Tsai 6a1ed25581 HBASE-19897 RowMutations should follow the fluent pattern 2018-02-02 05:24:08 +08:00
Peter Somogyi 7fe215db5f HBASE-19884 BucketEntryGroup's equals, hashCode and compareTo methods are not consistent
Move back to default equals and hashCode.
Remove compareTo and Comparator to PriorityQueue.

Signed-off-by: Michael Stack <stack@apache.org>
2018-02-01 13:21:23 -08:00
kewang 86ca65218d HBASE-19912 Remove useless 'writeToWAL' flag of Region#checkAndRowMutate
Signed-off-by: Michael Stack <stack@apache.org>
2018-02-01 12:34:46 -08:00
Umesh Agashe 4cdc13b86e HBASE-19839 Fixed flakey tests TestMergeTableRegionsProcedure#testRollbackAndDoubleExecution and TestSplitTableRegionProcedure#testRollbackAndDoubleExecution
* Added a comment in MergeTableRegionsProcedure and SplitTableRegionProcedure explaining specific rollbacks has side effect that AssignProcedure/s are submitted asynchronously and those procedures may continue to execute even after rollback() is done.
* Updated comments in tests with correct rollback state to abort
* Added overloaded method MasterProcedureTestingUtility#testRollbackAndDoubleExecution which takes additional argument for waiting on all procedures to finish before asserting conditions
* Updated TestMergeTableRegionsProcedure#testRollbackAndDoubleExecution and TestSplitTableRegionProcedure#testRollbackAndDoubleExecution to use newly added method

Signed-off-by: Michael Stack <stack@apache.org>
2018-02-01 12:01:57 -08:00
Michael Stack 23471deb75 HBASE-19906 TestZooKeeper Timeout Includes move of TestQoSFunction from smalltests to mediumtests; it timedout in a run. 2018-02-01 10:53:51 -08:00
Michael Stack 4c210eb212 HBASE-19911 Convert some tests from small to medium because they are timing out: TestNettyRpcServer, TestClientClusterStatus; ADDENDUM changes TestCheckTestClasses to be medium sized test 2018-01-31 20:28:02 -08:00
Michael Stack ba265a7e51 HBASE-19911 Convert some tests from small to medium because they are timing out: TestNettyRpcServer, TestClientClusterStatus 2018-01-31 20:21:57 -08:00
Michael Stack 113432c9b9 HBASE-19910 TestBucketCache TimesOut 2018-01-31 18:17:22 -08:00
Michael Stack faea89ea4f HBASE-19909 TestRegionLocationFinder Timeout 2018-01-31 17:53:48 -08:00
Michael Stack 13f92b7daa HBASE-19908 TestCoprocessorShortCircuitRPC Timeout.... 2018-01-31 17:34:05 -08:00
Michael Stack 7a82126f8b Revert "HBASE-19906 TestZooKeeper Timeout"
Revert. Pushed prematurely.

This reverts commit 80af9bdef0.
2018-01-31 15:56:26 -08:00
Michael Stack e6d2682f0f HBASE-19907 TestMetaWithReplicas still flakey 2018-01-31 15:18:45 -08:00
Michael Stack 80af9bdef0 HBASE-19906 TestZooKeeper Timeout 2018-01-31 15:18:38 -08:00
Rahul Gidwani 4148d7c614 HBASE-19528 - Major Compaction Tool 2018-01-31 14:37:48 -08:00
zhangduo 28d13c54a9 HBASE-19887 Do not overwrite the surefire junit listener property in the pom of sub modules 2018-01-31 20:49:25 +08:00
binlijin b3824b8c92 HBASE-19728 Add lock to filesCompacting in all place. 2018-01-31 14:18:27 +08:00
Peter Somogyi 0ee280db22
HBASE-19868 TestCoprocessorWhitelistMasterObserver is flakey
Recategorize TestCoprocessorWhitelistMasterObserver as Large test
2018-01-30 06:01:50 -08:00
Michael Stack 364650bad5 HBASE-19868 TestCoprocessorWhitelistMasterObserver is flakey 2018-01-29 21:33:16 -08:00