18443 Commits

Author SHA1 Message Date
Andrew Purtell
f705e3e7d8 HBASE-27206 Clean up error-prone findings in hbase-common (#4645)
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit fbe3b90e0c4eef1dc13fb2a5ed9381106ca671dd)

Conflicts:
	hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java
	hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValueUtil.java
	hbase-common/src/main/java/org/apache/hadoop/hbase/ServerName.java
	hbase-common/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfo.java
	hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java
	hbase-common/src/test/java/org/apache/hadoop/hbase/io/crypto/TestKeyStoreKeyProvider.java
	hbase-common/src/test/java/org/apache/hadoop/hbase/types/TestOrderedFloat32.java
2022-08-21 21:36:01 +08:00
Andrew Purtell
ca6baa8050 HBASE-27234 Clean up error-prone warnings in hbase-examples
Close #4647

Co-authored-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
(cherry picked from commit 35fb37cf86229d830496bf7a64a9a96c154f4f05)

Conflicts:
	hbase-examples/src/main/java/org/apache/hadoop/hbase/coprocessor/example/BulkDeleteEndpoint.java
	hbase-examples/src/main/java/org/apache/hadoop/hbase/coprocessor/example/RowCountEndpoint.java
	hbase-examples/src/test/java/org/apache/hadoop/hbase/security/provider/example/TestShadeSaslAuthenticationProvider.java
2022-08-21 00:27:18 +08:00
Andrew Purtell
e5f551ebf7 HBASE-27252 Clean up error-prone findings in hbase-it
Close #4662

Co-authored-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
(cherry picked from commit 1004876bad1947e301bf8bdabf6979444aee7ee0)

Conflicts:
	hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestBackupRestore.java
	hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestIngest.java
	hbase-it/src/test/java/org/apache/hadoop/hbase/trace/IntegrationTestSendTraceRequests.java
2022-08-20 23:39:06 +08:00
Fantasy-Jay
8a10dbf6c4 HBASE-27268 In trace log mode, the client does not print callId/startTime and the server does not print receiveTime (#4710)
Co-authored-by: jay.zhu <jay.zhu@huolala.cn>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 32c135d8a552970e592ed39735186b4364f85ed1)
2022-08-20 21:09:43 +08:00
BukrosSzabolcs
d073404706 HBASE-26969:Eliminate MOB renames when SFT is enabled
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Signed-off-by: Peter Somogyi <psomogyi@apache.org>

closes #4712
2022-08-19 11:33:48 +02:00
Peter Somogyi
1176b484d1 HBASE-25970 MOB data loss - incorrect concatenation of MOB_FILE_REFS (#3355)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Signed-off-by: Pankaj Kumar<pankajkumar@apache.org>
2022-08-19 11:20:53 +02:00
Sean Busbey
1986a6ec31 HBASE-24163 MOB compactor implementations should use format specifiers when calling String.format
Signed-off-by: stack <stack@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: Josh Elser <elserj@apache.org>
2022-08-17 13:46:18 +02:00
Duo Zhang
e4c141cb48 HBASE-27294 Add new hadoop releases in our hadoop checks (#4692)
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
(cherry picked from commit 4a57cbd2cb01b63a93f0171c068b9fd49d239c99)
2022-08-16 21:43:27 +08:00
Duo Zhang
c2dff398d3 HBASE-27279 Make SslHandler work with SaslWrapHandler/SaslUnwrapHandler (#4705)
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
Reviewed-by: Andor Molnár <andor@cloudera.com>
(cherry picked from commit 2b9d36869ffe765256d4a7b6a74b95a8200678df)

Conflicts:
	hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestNettyTlsIPCRejectPlainText.java
	hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestSecureIPC.java
	hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestTlsWithKerberos.java
2022-08-16 21:37:47 +08:00
Wellington Ramos Chevreuil
3acf920e1f HBASE-27264 Add options to consider compressed size when delimiting blocks during hfile writes (#4675)
Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org>
Signed-off-by: Ankit Singhal <ankit@apache.org>
2022-08-15 22:36:44 +01:00
liangxs
aaad3a7077 HBASE-26982 Add index and bloom filter statistics of LruBlockCache on… (#4376)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: stack <stack@apache.org>
2022-08-15 11:12:05 -07:00
huaxiangsun
b25ded026b
HBASE-27296 Some Cell's implementation of toString() such as IndividualBytesFieldCell prints out value and tags which is too verbose (#4695) (#4701)
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
2022-08-15 09:16:29 -07:00
Duo Zhang
60394e95a7
HBASE-27299 Bump minimum hadoop 2 version to 2.10.2 (#4699)
Signed-off-by: Xin Sun <ddupgs@gmail.com>
2022-08-15 18:54:46 +08:00
Duo Zhang
b83165cf60 HBASE-27221 Bump spotless version to 2.24.1 (#4693)
Signed-off-by: Xin Sun <ddupgs@gmail.com>
(cherry picked from commit 9215066e2b8e114fb4e96f1b701a8cbd85638284)
2022-08-15 15:23:11 +08:00
SiCheng-Zheng
1b5d20dcf6 HBASE-27301 Add Delete addFamilyVersion timestamp verify (#4700)
Co-authored-by: SiCheng-Zheng <zhengsicheng@jd.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit b531e71455423a9f5a5956da90026085dde96117)
2022-08-15 15:23:04 +08:00
Andrew Purtell
f36b34984f
HBASE-23723 Ensure MOB compaction works in optimized mode after snapshot clone (#4617)
* HBASE-23723 Ensure MOB compaction works in optimized mode after snapshot clone (#1446)

* Reorganize MOB compaction tests for more reuse.
* Add tests for mob compaction after snapshot clone operations
* note the original table used to write a given mob hfile and use that to find it later.

Signed-off-by: Esteban Gutierrez <esteban@apache.org>

* spotless:apply to fix HBaseTestingUtility

* Fix error-prone errors

Signed-off-by: Esteban Gutierrez <esteban@apache.org>
Co-authored-by: Sean Busbey <busbey@apache.org>
2022-08-12 14:29:26 -07:00
dependabot[bot]
ed6554de45 HBASE-27298 Bump hadoop version to 3.2.4 (#4696)
Bumps hadoop-common from 3.2.3 to 3.2.4.

---
updated-dependencies:
- dependency-name: org.apache.hadoop:hadoop-common
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Duo Zhang <zhangduo@apache.org>

Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 97fb5cc6d24daf7b62c59972f8b24e788a7edae9)
2022-08-12 14:36:28 +08:00
Duo Zhang
b820188c68 HBASE-27278 Improve TestTlsIPC to reuse existing IPC test code (#4682)
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
(cherry picked from commit 3309108ca728cb40ad0da5be567ca0e1beabbeff)
2022-08-12 13:21:11 +08:00
Peter Somogyi
3f5076dac5 HBASE-27281 Add default implementation for Connection$getClusterId (#4683)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-08-11 17:21:14 +02:00
Duo Zhang
4079647c39 HBASE-27293 Remove jenkins and personality scripts support for 1.x (#4690)
Signed-off-by: GeorryHuang <huangzhuoyue@apache.org>
(cherry picked from commit bffae99f40f5fb144d52450bfedadfd168a429e0)
2022-08-11 16:59:49 +08:00
Andrew Purtell
2941b8e583 HBASE-27240 Clean up error-prone findings in hbase-http (#4653)
Signed-off-by: Duo Zhang <zhangduo@apache.org>

(cherry picked from commit 5eaeff5fcdd5c4e42376a56cca02e4cbb56cc3f0)
2022-08-11 14:44:14 +08:00
Masatake Iwasaki
0b9f9871a6 HBASE-27292. Fix build failure against Hadoop 3.3.4 due to added dependency on okhttp. (#4687)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 00612106b5fa78a0dd198cbcaab610bd8b1be277)
2022-08-10 22:15:23 +08:00
SiCheng-Zheng
25e192b807 HBASE-27248 WALPrettyPrinter add print timestamp (#4659)
Co-authored-by: SiCheng-Zheng <zhengsicheng@jd.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 6b2e9d14a71d3ccbedabf971fe961802d263a995)
2022-08-10 21:30:55 +08:00
Bryan Beaudreault
e99faad83e HBASE-27241 Add metrics for evaluating cost and effectiveness of bloom filters (#4669)
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
2022-08-09 15:25:47 -04:00
Duo Zhang
beb7c6d490 HBASE-27283 Use readTO instead of hard coded RpcClient.DEFAULT_SOCKET_TIMEOUT_READ when creating ReadTimeoutHandler in NettyRpcConnection (#4685)
Signed-off-by: Xin Sun <ddupgs@gmail.com
Signed-off-by: GeorryHuang <huangzhuoyue@apache.org>
(cherry picked from commit 5919b30b6d9e905130033461efc37fae60bab947)
2022-08-09 16:22:57 +08:00
chaijunjie0101
30f6a17056 HBASE-27282 CME in AuthManager causes region server crash (#4684)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit d6641626a97529982720de2b73593e294869c4ca)
2022-08-09 09:56:26 +08:00
LiangJun He
6e82a26a51 HBASE-27275 graceful_stop.sh unable to restore the balance state (#4680)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit b431652e48e7cd003c7f8cad4eb9e3065cb0b40f)
2022-08-09 09:55:54 +08:00
Abhradeep Kundu
a85de838ab HBASE-27265 : Tool to read StoreFileTrackerFile (#4673)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-08-08 15:31:14 +01:00
SiCheng-Zheng
c81517638c HBASE-27270 Add bulkloadExecutor.resizeQueues (#4677)
Co-authored-by: SiCheng-Zheng <zhengsicheng@jd.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 4ebf71982c8a26033c0e7513ef4fc52a303ed71f)
2022-08-08 18:15:25 +08:00
ryakhovskiy
74726617b8
HBASE-26775 - add synchronized modifier to the toString() method of ProcedureEvent.java (#4681)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-08-08 18:03:40 +08:00
Andor Molnár
2821cc518a HBASE-26666 Add native TLS encryption support to RPC server/client (#4666)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
(cherry picked from commit f8dcf0705538ffeddcaa5eff74c8c2f61f7a844a)

Conflicts:
	hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcClient.java
	hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcServer.java
2022-08-06 19:43:17 -04:00
Duo Zhang
2e7a983923 HBASE-27273 Should stop autoRead and skip all the bytes when rpc request too big (#4679)
Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>
(cherry picked from commit 486d19e99ff4370bc60e0db235508198c84a00e3)
2022-08-06 20:31:27 +08:00
LiangJun He
c5b22d973b HBASE-27269 The implementation of TestReplicationStatus.waitOnMetricsReport is incorrect (#4678)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 2dc26082be978796046d9124212e8c9d2d8a1f5d)
2022-08-04 23:14:24 +08:00
Duo Zhang
272805c32e HBASE-27271 BufferCallBeforeInitHandler should ignore the flush request (#4676)
Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
(cherry picked from commit fb529e23526eaa250bdd355db3c2f0dedc55c3e8)

Conflicts:
	hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java
2022-08-04 22:57:13 +08:00
Nick Dimiduk
bcec871959 HBASE-27153 Improvements to read-path tracing
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-08-02 14:09:39 +02:00
Bryan Beaudreault
dbad3d1175 HBASE-27257 Remove unnecessary usage of CachedBlocksByFile from RS UI (#4667)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
2022-07-29 15:28:54 -04:00
Duo Zhang
5e4ddad9a9 HBASE-27185 Addendum fix TestShadeSaslAuthenticationProvider 2022-07-28 17:31:28 +08:00
chenglei
7910f7738f HBASE-27247 TestPerTableCFReplication.testParseTableCFsFromConfig is broken because of ReplicationPeerConfigUtil.parseTableCFsFromConfig (#4658)
Co-authored-by: comnetwork <comnetwork@163.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-07-27 17:55:00 -07:00
Andrew Purtell
29f51c05f0
HBASE-27203 Clean up error-prone findings in hbase-client [branch-2] (#4651)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2022-07-27 15:58:40 -07:00
Duo Zhang
5f231d3fb3 HBASE-27185 Rewrite NettyRpcServer to decode rpc request with netty handler (#4624)
Signed-off-by: Xin Sun <ddupgs@gmail.com>
(cherry picked from commit 0c4263a18be13f412fcf71ebba9715dcc5ca2a12)

Conflicts:
	hbase-client/src/main/java/org/apache/hadoop/hbase/security/NettyHBaseSaslRpcClientHandler.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ServerRpcConnection.java
2022-07-27 09:10:32 +08:00
Andrew Purtell
6f3538bb4b HBASE-27236 Clean up error-prone warnings in hbase-hbtop (#4649)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-07-26 18:05:09 -07:00
Andrew Purtell
6e92500444 HBASE-27210 Clean up error-prone findings in hbase-endpoint (#4646)
Signed-off-by: Duo Zhang <zhangduo@apache.org>

Conflicts:
	hbase-endpoint/src/test/java/org/apache/hadoop/hbase/client/TestRpcControllerFactory.java
	hbase-endpoint/src/test/java/org/apache/hadoop/hbase/coprocessor/TestSecureExport.java
2022-07-26 17:42:32 -07:00
Andrew Purtell
4c08a8a423 HBASE-27087 TestQuotaThrottle times out
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-07-26 14:10:49 -07:00
Bryan Beaudreault
827c1ab5dd HBASE-27229 BucketCache statistics should not count evictions by hfile (#4639)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
2022-07-26 17:00:46 -04:00
Duo Zhang
84e7cdb2c0 HBASE-27222 Purge FutureReturnValueIgnored warnings from error prone (#4634)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
(cherry picked from commit 8b091c4061220cc4307ef2ed35291f6fe14bbdb0)
2022-07-26 23:45:15 +08:00
Bryan Beaudreault
1fd772c3b1 HBASE-27225 Add BucketAllocator bucket size statistic logging (#4637)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
2022-07-25 20:56:05 -04:00
Andrew Purtell
b17bc94b10 HBASE-27235 Clean up error-prone warnings in hbase-hadoop-compat (#4648)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2022-07-25 17:30:50 -07:00
Ramón García Fernández
e762b026db HBASE-27179 Issues building with OpenJDK 17 (#4594)
Fix test case failures in org.apache.hadoop.hbase.http.log.TestLogLevel under Openjdk 17 because of a missing export of java.security.jgss/sun.security.krb5.
Removed option --illegal-access=permit ignored since Openjdk 17.

Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit e10c15d0306e678ace8748680527e6eecbf424e5)
2022-07-25 19:23:42 +08:00
Wellington Ramos Chevreuil
80c33e0d46 HBASE-27232 Fix checking for encoded block size when deciding if bloc… (#4640)
Signed-off-by: Andor Molnár <andor@cloudera.com>
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
Signed-off-by: Ankit Singhal <ankit@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>

(cherry picked from commit d5ed8f59e582272c2e3cd9b6b33488fa0f265cbf)
2022-07-25 12:08:09 +01:00
Andrew Purtell
eef5edb403 HBASE-27204 BlockingRpcClient will hang for 20 seconds when SASL is enabled after finishing negotiation (#4642)
Revert "HBASE-24579: Failed SASL authentication does not result in an exception on client side (#1921)"

This reverts commit bd79c4065ccb13a5e217d844376b3e7b9489d2fe.

When Kerberos authentication succeeds, on the server side, after
receiving the final SASL token from the client, we simply wait for
the client to continue by sending the connection header.
After HBASE-24579, on the client side, an additional readStatus()
was added, which mistakenly assumes that after negotiation has
completed a status code will be sent. However when authentication
has succeeded the server will not send one. As a result the client
will hang and only throw an exception when the configured read
timeout is reached, which is 20 seconds by default.

We cannot unilaterally send the expected additional status code
from the server side because older clients will not expect it. The
first call will fail because the client finds unexpected bytes in
the stream ahead of the call response. Fabricating a call response
also does not seem a viable strategy for backwards compatibility.

The HBASE-24579 change needs to be reconsidered given the
difficult backwards compatibility challenges here.

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2022-07-24 23:06:58 -07:00