e019961150
Addresses review comments by Sean Busbey and Appy that happened to come in long after the commit of HBASE-6721, the original rsgroup issue. Also includes subsequent accommodation of Duo Zhang review. Adds a new type to hold hostname and port. It is called Address. It is a facade over Guava's HostAndPort. Replace all instances of HostAndPort with Address. In particular, those places where HostAndPort was part of the rsgroup public API. Fix licenses. Add audience annotations. Cleanup and note concurrency expectation on a few core classes. In particular, all access on RSGroupInfoManager is made synchronized. M hbase-client/src/main/java/org/apache/hadoop/hbase/ServerName.java Host the hostname and port in an instance of the new type Address. Add a bunch of deprecation of exotic string parses that should never have been public. M hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdmin.java Make this an Interface rather than abstract class. Creation was a static internal method that only chose one type.... Let it be free as a true Interface instead. |
||
|---|---|---|
| .. | ||
| src | ||
| README.txt | ||
| pom.xml | ||
README.txt
ON PROTOBUFS
This maven module has core protobuf definition files ('.protos') used by hbase
table gropuing Coprocessor Endpoints.
Generation of java files from protobuf .proto files included here is done apart
from the build. Run the generation whenever you make changes to the .orotos files
and then check in the produced java (The reasoning is that change is infrequent
so why pay the price of generating files anew on each build.
To generate java files from protos run:
$ mvn compile -Dcompile-protobuf
or
$ mvn compile -Pcompile-protobuf
After you've done the above, check it and then check in changes (or post a patch
on a JIRA with your definition file changes and the generated files). Be careful
to notice new files and files removed and do appropriate git rm/adds.