HTTPCLIENT-1106: Use character arrays for passwords in Credentials objects, not Strings

Deprecate constructors using String-based passwords

git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/branches/4.5.x@1696576 13f79535-47bb-0310-9956-ffa450edef68

httpclient/src/main/java/org/apache/http/auth/NTCredentials.java

@@ -59,6 +59,7 @@ public class NTCredentials implements Credentials, Serializable {
      * string argument.
      *
      * @param usernamePassword the domain/username:password formed string
+     * @deprecated (4.5) will be replaced with {@code String}, {@code char[]} in 5.0
      */
     public NTCredentials(final String usernamePassword) {
         super();
@@ -88,7 +89,7 @@ public class NTCredentials implements Credentials, Serializable {
     /**
      * Constructor.
      * @param userName The user name.  This should not include the domain to authenticate with.
-     * For example: "user" is correct whereas "DOMAIN\\user" is not.
+     * For example: "user" is correct whereas "DOMAIN\user" is not.
      * @param password The password.
      * @param workstation The workstation the authentication request is originating from.
      * Essentially, the computer name for this machine.

httpclient/src/main/java/org/apache/http/auth/UsernamePasswordCredentials.java

@@ -52,6 +52,7 @@ public class UsernamePasswordCredentials implements Credentials, Serializable {
      *
      * @param usernamePassword the username:password formed string
      * @see #toString
+     * @deprecated (4.5) will be replaced with {@code String}, {@code char[]} in 5.0
      */
     public UsernamePasswordCredentials(final String usernamePassword) {
         super();