From 4006d7e4f23dac62462995a3cf923eae662239e5 Mon Sep 17 00:00:00 2001
From: Sebastian Bazley <sebb@apache.org>
Date: Mon, 23 Jun 2014 17:46:29 +0000
Subject: [PATCH] Add TODOs for code that needs looking at

git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1604892 13f79535-47bb-0310-9956-ffa450edef68
---
 .../apache/http/impl/client/cache/TestProtocolRequirements.java | 2 +-
 .../main/java/org/apache/http/impl/auth/HttpAuthenticator.java  | 2 +-
 .../java/org/apache/http/conn/ssl/TestSSLSocketFactory.java     | 1 +
 3 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestProtocolRequirements.java b/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestProtocolRequirements.java
index 6cafb6814..8211b1f75 100644
--- a/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestProtocolRequirements.java
+++ b/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestProtocolRequirements.java
@@ -6049,7 +6049,7 @@ public class TestProtocolRequirements extends AbstractProtocolTest {
         // received-by
         if (!Pattern.matches(tokenRegexp, parts[1])) {
             // host : port
-            new HttpHost(parts[1]);
+            new HttpHost(parts[1]); // TODO - unused - is this a test bug? else use Assert.assertNotNull
         }
 
         // comment
diff --git a/httpclient/src/main/java/org/apache/http/impl/auth/HttpAuthenticator.java b/httpclient/src/main/java/org/apache/http/impl/auth/HttpAuthenticator.java
index e9787ac90..6bc28783e 100644
--- a/httpclient/src/main/java/org/apache/http/impl/auth/HttpAuthenticator.java
+++ b/httpclient/src/main/java/org/apache/http/impl/auth/HttpAuthenticator.java
@@ -177,7 +177,7 @@ public class HttpAuthenticator {
             final HttpContext context) throws HttpException, IOException {
         AuthScheme authScheme = authState.getAuthScheme();
         Credentials creds = authState.getCredentials();
-        switch (authState.getState()) {
+        switch (authState.getState()) { // TODO add UNCHALLENGED and HANDSHAKE cases
         case FAILURE:
             return;
         case SUCCESS:
diff --git a/httpclient/src/test/java/org/apache/http/conn/ssl/TestSSLSocketFactory.java b/httpclient/src/test/java/org/apache/http/conn/ssl/TestSSLSocketFactory.java
index 83800ad32..af16ba927 100644
--- a/httpclient/src/test/java/org/apache/http/conn/ssl/TestSSLSocketFactory.java
+++ b/httpclient/src/test/java/org/apache/http/conn/ssl/TestSSLSocketFactory.java
@@ -176,6 +176,7 @@ public class TestSSLSocketFactory {
 
     @Test
     public void testClientAuthSSLAliasChoice() throws Exception {
+    	// TODO unused - is there a bug in the test?
         final PrivateKeyStrategy aliasStrategy = new PrivateKeyStrategy() {
 
             @Override