HTTPCLIENT-1032: additional unit test coverage for HttpCacheEntry

git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1044636 13f79535-47bb-0310-9956-ffa450edef68

httpclient-cache/src/test/java/org/apache/http/client/cache/TestHttpCacheEntry.java

@@ -27,16 +27,20 @@
 package org.apache.http.client.cache;
 
 import static org.easymock.classextension.EasyMock.*;
+import static org.junit.Assert.*;
+
 import java.util.Date;
+import java.util.HashSet;
+import java.util.Set;
 
 import org.apache.http.Header;
 import org.apache.http.HttpStatus;
 import org.apache.http.HttpVersion;
 import org.apache.http.StatusLine;
 import org.apache.http.client.cache.HttpCacheEntry;
+import org.apache.http.impl.cookie.DateUtils;
 import org.apache.http.message.BasicHeader;
 import org.apache.http.message.BasicStatusLine;
-import org.junit.Assert;
 import org.junit.Before;
 import org.junit.Test;
 
@@ -47,6 +51,7 @@ public class TestHttpCacheEntry {
 	private Date nineSecondsAgo;
 	private Resource mockResource;
 	private StatusLine statusLine;
+	private HttpCacheEntry entry;
 
 	@Before
 	public void setUp() {
@@ -69,8 +74,8 @@ public void testGetHeadersReturnsCorrectHeaders() {
 				new BasicHeader("bar", "barValue1"),
 				new BasicHeader("bar", "barValue2")
 		};
-        HttpCacheEntry entry = makeEntry(headers);
-        Assert.assertEquals(2, entry.getHeaders("bar").length);
+		entry = makeEntry(headers);
+		assertEquals(2, entry.getHeaders("bar").length);
 	}
 
 	@Test
@@ -79,8 +84,8 @@ public void testGetFirstHeaderReturnsCorrectHeader() {
 				new BasicHeader("bar", "barValue1"),
 				new BasicHeader("bar", "barValue2")
 		};
-        HttpCacheEntry entry = makeEntry(headers);
-        Assert.assertEquals("barValue1", entry.getFirstHeader("bar").getValue());
+		entry = makeEntry(headers);
+		assertEquals("barValue1", entry.getFirstHeader("bar").getValue());
 	}
 
 	@Test
@@ -89,9 +94,8 @@ public void testGetHeadersReturnsEmptyArrayIfNoneMatch() {
 				new BasicHeader("bar", "barValue1"),
 				new BasicHeader("bar", "barValue2")
 		};
-        HttpCacheEntry entry = makeEntry(headers);
-
-        Assert.assertEquals(0, entry.getHeaders("baz").length);
+		entry = makeEntry(headers);
+		assertEquals(0, entry.getHeaders("baz").length);
 	}
 
 	@Test
@@ -100,23 +104,22 @@ public void testGetFirstHeaderReturnsNullIfNoneMatch() {
 				new BasicHeader("bar", "barValue1"),
 				new BasicHeader("bar", "barValue2")
 		};
-        HttpCacheEntry entry = makeEntry(headers);
-
-        Assert.assertEquals(null, entry.getFirstHeader("quux"));
+		entry = makeEntry(headers);
+		assertEquals(null, entry.getFirstHeader("quux"));
 	}
 
 	@Test
 	public void testCacheEntryWithNoVaryHeaderDoesNotHaveVariants() {
 		Header[] headers = new Header[0];
-        HttpCacheEntry entry = makeEntry(headers);
-        Assert.assertFalse(entry.hasVariants());
+		entry = makeEntry(headers);
+		assertFalse(entry.hasVariants());
 	}
 
 	@Test
 	public void testCacheEntryWithOneVaryHeaderHasVariants() {
 		Header[] headers = { new BasicHeader("Vary", "User-Agent") };
-        HttpCacheEntry entry = makeEntry(headers);
-        Assert.assertTrue(entry.hasVariants());
+		entry = makeEntry(headers);
+		assertTrue(entry.hasVariants());
 	}
 
 	@Test
@@ -124,15 +127,179 @@ public void testCacheEntryWithMultipleVaryHeadersHasVariants() {
 		Header[] headers = { new BasicHeader("Vary", "User-Agent"),
 				new BasicHeader("Vary", "Accept-Encoding")
 		};
-        HttpCacheEntry entry = makeEntry(headers);
-        Assert.assertTrue(entry.hasVariants());
+		entry = makeEntry(headers);
+		assertTrue(entry.hasVariants());
 	}
 
 	@Test
 	public void testCacheEntryWithVaryStarHasVariants(){
 		Header[] headers = { new BasicHeader("Vary", "*") };
-        HttpCacheEntry entry = makeEntry(headers);
-        Assert.assertTrue(entry.hasVariants());
+		entry = makeEntry(headers);
+		assertTrue(entry.hasVariants());
 	}
 
+	@Test
+	public void mustProvideRequestDate() {
+		try {
+			new HttpCacheEntry(null, new Date(), statusLine,
+					new Header[]{}, mockResource, null);
+			fail("Should have thrown exception");
+		} catch (IllegalArgumentException expected) {
+		}
+	}
+
+	@Test
+	public void mustProvideResponseDate() {
+		try {
+			new HttpCacheEntry(new Date(), null, statusLine,
+					new Header[]{}, mockResource, null);
+			fail("Should have thrown exception");
+		} catch (IllegalArgumentException expected) {
+		}
+	}
+
+	@Test
+	public void mustProvideStatusLine() {
+		try {
+			new HttpCacheEntry(new Date(), new Date(), null,
+					new Header[]{}, mockResource, null);
+			fail("Should have thrown exception");
+		} catch (IllegalArgumentException expected) {
+		}
+	}
+
+	@Test
+	public void mustProvideResponseHeaders() {
+		try {
+			new HttpCacheEntry(new Date(), new Date(), statusLine,
+					null, mockResource, null);
+			fail("Should have thrown exception");
+		} catch (IllegalArgumentException expected) {
+		}
+	}
+
+	@Test
+	public void mustProvideResource() {
+		try {
+			new HttpCacheEntry(new Date(), new Date(), statusLine,
+					new Header[]{}, null, null);
+			fail("Should have thrown exception");
+		} catch (IllegalArgumentException expected) {
+		}
+	}
+
+	@Test
+	public void canProvideVariantSet() {
+		new HttpCacheEntry(new Date(), new Date(), statusLine,
+				new Header[]{}, mockResource, new HashSet<String>());
+	}
+
+	@Test
+	public void canRetrieveOriginalStatusLine() {
+		entry = new HttpCacheEntry(new Date(), new Date(), statusLine,
+				new Header[]{}, mockResource, null);
+		assertSame(statusLine, entry.getStatusLine());
+	}
+
+	@Test
+	public void protocolVersionComesFromOriginalStatusLine() {
+		entry = new HttpCacheEntry(new Date(), new Date(), statusLine,
+				new Header[]{}, mockResource, null);
+		assertSame(statusLine.getProtocolVersion(),
+				entry.getProtocolVersion());    	
+	}
+
+	@Test
+	public void reasonPhraseComesFromOriginalStatusLine() {
+		entry = new HttpCacheEntry(new Date(), new Date(), statusLine,
+				new Header[]{}, mockResource, null);
+		assertSame(statusLine.getReasonPhrase(), entry.getReasonPhrase());    	
+	}
+
+	@Test
+	public void statusCodeComesFromOriginalStatusLine() {
+		entry = new HttpCacheEntry(new Date(), new Date(), statusLine,
+				new Header[]{}, mockResource, null);
+		assertEquals(statusLine.getStatusCode(), entry.getStatusCode());    	
+	}
+
+	@Test
+	public void canGetOriginalRequestDate() {
+		final Date requestDate = new Date();
+		entry = new HttpCacheEntry(requestDate, new Date(), statusLine,
+				new Header[]{}, mockResource, null);
+		assertSame(requestDate, entry.getRequestDate());    	
+	}
+
+	@Test
+	public void canGetOriginalResponseDate() {
+		final Date responseDate = new Date();
+		entry = new HttpCacheEntry(new Date(), responseDate, statusLine,
+				new Header[]{}, mockResource, null);
+		assertSame(responseDate, entry.getResponseDate());    	
+	}
+
+	@Test
+	public void canGetOriginalResource() {
+		entry = new HttpCacheEntry(new Date(), new Date(), statusLine,
+				new Header[]{}, mockResource, null);
+		assertSame(mockResource, entry.getResource());    	
+	}
+
+	@Test
+	public void canGetOriginalHeaders() {
+		Header[] headers = {
+				new BasicHeader("Server", "MockServer/1.0"),
+				new BasicHeader("Date", DateUtils.formatDate(now))
+		};
+		entry = new HttpCacheEntry(new Date(), new Date(), statusLine,
+				headers, mockResource, null);
+		Header[] result = entry.getAllHeaders();
+		assertEquals(headers.length, result.length);
+		for(int i=0; i<headers.length; i++) {
+			assertEquals(headers[i], result[i]);
+		}
+	}
+
+	@Test
+	public void canRetrieveOriginalVariantSet() {
+		Set<String> variants = new HashSet<String>();
+		variants.add("variant1");
+		variants.add("variant2");
+		entry = new HttpCacheEntry(new Date(), new Date(), statusLine,
+				new Header[]{}, mockResource, variants);
+		Set<String> result = entry.getVariantURIs();
+		assertEquals(variants.size(), result.size());
+		for(String variant : variants) {
+			assertTrue(result.contains(variant));
+		}
+	}
+
+	@Test
+	public void variantSetIsNotModifiable() {
+		Set<String> variants = new HashSet<String>();
+		variants.add("variant1");
+		variants.add("variant2");
+		entry = new HttpCacheEntry(new Date(), new Date(), statusLine,
+				new Header[]{}, mockResource, variants);
+		Set<String> result = entry.getVariantURIs();
+		try {
+			result.remove("variant1");
+			fail("Should have thrown exception");
+		} catch (UnsupportedOperationException expected) {
+		}
+		try {
+			result.add("variant3");
+			fail("Should have thrown exception");
+		} catch (UnsupportedOperationException expected) {
+		}
+	}
+
+	@Test
+	public void canConvertToString() {
+		entry = new HttpCacheEntry(new Date(), new Date(), statusLine,
+				new Header[]{}, mockResource, null);
+		assertNotNull(entry.toString());
+		assertFalse("".equals(entry.toString()));
+	}
 }