From 66f8ca1f09213c7108229cc546350ca2b4768774 Mon Sep 17 00:00:00 2001 From: Gary Gregory Date: Fri, 10 Jul 2020 08:57:24 -0400 Subject: [PATCH] BasicExpiresHandler is annotated as immutable but is not. (#240) --- .../client5/http/impl/cookie/BasicExpiresHandler.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/httpclient5/src/main/java/org/apache/hc/client5/http/impl/cookie/BasicExpiresHandler.java b/httpclient5/src/main/java/org/apache/hc/client5/http/impl/cookie/BasicExpiresHandler.java index 1c01784e0..25d338574 100644 --- a/httpclient5/src/main/java/org/apache/hc/client5/http/impl/cookie/BasicExpiresHandler.java +++ b/httpclient5/src/main/java/org/apache/hc/client5/http/impl/cookie/BasicExpiresHandler.java @@ -46,11 +46,11 @@ public class BasicExpiresHandler extends AbstractCookieAttributeHandler implements CommonCookieAttributeHandler { /** Valid date patterns */ - private final String[] datepatterns; + private final String[] datePatterns; - public BasicExpiresHandler(final String[] datepatterns) { - Args.notNull(datepatterns, "Array of date patterns"); - this.datepatterns = datepatterns; + public BasicExpiresHandler(final String[] datePatterns) { + Args.notNull(datePatterns, "Array of date patterns"); + this.datePatterns = datePatterns.clone(); } @Override @@ -60,7 +60,7 @@ public void parse(final SetCookie cookie, final String value) if (value == null) { throw new MalformedCookieException("Missing value for 'expires' attribute"); } - final Date expiry = DateUtils.parseDate(value, this.datepatterns); + final Date expiry = DateUtils.parseDate(value, this.datePatterns); if (expiry == null) { throw new MalformedCookieException("Invalid 'expires' attribute: " + value);