Apache
/
httpcomponents-client
mirror of https://github.com/apache/httpcomponents-client.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Minor Improvements: 

* Remove redundant initialization
This commit is contained in:
Arturo Bernal 2021-01-04 21:16:34 +01:00 committed by Oleg Kalnichevski
parent 8285223560
commit 6a02e818ff
11 changed files with 34 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
httpclient5-cache/src/test/java/org/apache/hc/client5/http/impl/cache/ConsumableInputStream.java vendored
View File

@ -35,7 +35,7 @@ import org.apache.hc.core5.io.Closer;
public class ConsumableInputStream extends InputStream { public class ConsumableInputStream extends InputStream {
private final ByteArrayInputStream buf; private final ByteArrayInputStream buf;
private boolean closed = false; private boolean closed;
public ConsumableInputStream(final ByteArrayInputStream buf) { public ConsumableInputStream(final ByteArrayInputStream buf) {
this.buf = buf; this.buf = buf;

2
httpclient5-cache/src/test/java/org/apache/hc/client5/http/impl/cache/DummyBackend.java vendored
View File

@ -40,7 +40,7 @@ public class DummyBackend implements ExecChain {
private ClassicHttpRequest request; private ClassicHttpRequest request;
private ClassicHttpResponse response = new BasicClassicHttpResponse(HttpStatus.SC_OK, "OK"); private ClassicHttpResponse response = new BasicClassicHttpResponse(HttpStatus.SC_OK, "OK");
private int executions = 0; private int executions;
public void setResponse(final ClassicHttpResponse resp) { public void setResponse(final ClassicHttpResponse resp) {
response = resp; response = resp;

2
httpclient5-cache/src/test/java/org/apache/hc/client5/http/impl/cache/TestCachingExecChain.java vendored
View File

@ -1207,7 +1207,7 @@ public abstract class TestCachingExecChain {
final ClassicHttpResponse resp1 = new BasicClassicHttpResponse(HttpStatus.SC_OK, final ClassicHttpResponse resp1 = new BasicClassicHttpResponse(HttpStatus.SC_OK,
"OK"); "OK");
resp1.setEntity(new InputStreamEntity(new InputStream() { resp1.setEntity(new InputStreamEntity(new InputStream() {
private boolean closed = false; private boolean closed;
@Override @Override
public void close() throws IOException { public void close() throws IOException {

2
httpclient5-testing/src/test/java/org/apache/hc/client5/testing/sync/TestContentCodings.java
View File

@ -397,7 +397,7 @@ public class TestContentCodings extends LocalServerTestBase {
private final CountDownLatch startGate; private final CountDownLatch startGate;
private final CountDownLatch endGate; private final CountDownLatch endGate;
private boolean failed = false; private boolean failed;
private String text; private String text;
WorkerTask(final CloseableHttpClient client, final HttpHost target, final boolean identity, final CountDownLatch startGate, final CountDownLatch endGate) { WorkerTask(final CloseableHttpClient client, final HttpHost target, final boolean identity, final CountDownLatch startGate, final CountDownLatch endGate) {

2
httpclient5-testing/src/test/java/org/apache/hc/client5/testing/sync/TestSSLSocketFactory.java
View File

@ -79,7 +79,7 @@ public class TestSSLSocketFactory {
static class TestX509HostnameVerifier implements HostnameVerifier { static class TestX509HostnameVerifier implements HostnameVerifier {
private boolean fired = false; private boolean fired;
@Override @Override
public boolean verify(final String host, final SSLSession session) { public boolean verify(final String host, final SSLSession session) {

2
httpclient5/src/main/java/org/apache/hc/client5/http/entity/DeflateInputStream.java
View File

@ -138,7 +138,7 @@ public class DeflateInputStream extends InputStream {
static class DeflateStream extends InflaterInputStream { static class DeflateStream extends InflaterInputStream {
private boolean closed = false; private boolean closed;
public DeflateStream(final InputStream in, final Inflater inflater) { public DeflateStream(final InputStream in, final Inflater inflater) {
super(in, inflater); super(in, inflater);

6
httpclient5/src/main/java/org/apache/hc/client5/http/entity/mime/MultipartEntityBuilder.java
View File

@ -59,9 +59,9 @@ public class MultipartEntityBuilder {
private ContentType contentType; private ContentType contentType;
private HttpMultipartMode mode = HttpMultipartMode.STRICT; private HttpMultipartMode mode = HttpMultipartMode.STRICT;
private String boundary = null; private String boundary;
private Charset charset = null; private Charset charset;
private List<MultipartPart> multipartParts = null; private List<MultipartPart> multipartParts;
public static MultipartEntityBuilder create() { public static MultipartEntityBuilder create() {
return new MultipartEntityBuilder(); return new MultipartEntityBuilder();

40
httpclient5/src/main/java/org/apache/hc/client5/http/impl/auth/NTLMEngineImpl.java
View File

@ -332,22 +332,22 @@ final class NTLMEngineImpl implements NTLMEngine {
byte[] timestamp; byte[] timestamp;
// Stuff we always generate // Stuff we always generate
byte[] lmHash = null; byte[] lmHash;
byte[] lmResponse = null; byte[] lmResponse;
byte[] ntlmHash = null; byte[] ntlmHash;
byte[] ntlmResponse = null; byte[] ntlmResponse;
byte[] ntlmv2Hash = null; byte[] ntlmv2Hash;
byte[] lmv2Hash = null; byte[] lmv2Hash;
byte[] lmv2Response = null; byte[] lmv2Response;
byte[] ntlmv2Blob = null; byte[] ntlmv2Blob;
byte[] ntlmv2Response = null; byte[] ntlmv2Response;
byte[] ntlm2SessionResponse = null; byte[] ntlm2SessionResponse;
byte[] lm2SessionResponse = null; byte[] lm2SessionResponse;
byte[] lmUserSessionKey = null; byte[] lmUserSessionKey;
byte[] ntlmUserSessionKey = null; byte[] ntlmUserSessionKey;
byte[] ntlmv2UserSessionKey = null; byte[] ntlmv2UserSessionKey;
byte[] ntlm2SessionResponseUserSessionKey = null; byte[] ntlm2SessionResponseUserSessionKey;
byte[] lanManagerSessionKey = null; byte[] lanManagerSessionKey;
public CipherGen(final Random random, final long currentTime, public CipherGen(final Random random, final long currentTime,
final String domain, final String user, final char[] password, final String domain, final String user, final char[] password,
@ -808,7 +808,7 @@ final class NTLMEngineImpl implements NTLMEngine {
private final Cipher rc4; private final Cipher rc4;
final Mode mode; final Mode mode;
final private boolean isConnection; final private boolean isConnection;
int sequenceNumber = 0; int sequenceNumber;
Handle( final byte[] exportedSessionKey, final Mode mode, final boolean isConnection ) throws NTLMEngineException Handle( final byte[] exportedSessionKey, final Mode mode, final boolean isConnection ) throws NTLMEngineException
@ -1080,10 +1080,10 @@ final class NTLMEngineImpl implements NTLMEngine {
/** NTLM message generation, base class */ /** NTLM message generation, base class */
static class NTLMMessage { static class NTLMMessage {
/** The current response */ /** The current response */
byte[] messageContents = null; byte[] messageContents;
/** The current output position */ /** The current output position */
int currentOutputPosition = 0; int currentOutputPosition;
/** Constructor to use when message contents are not yet known */ /** Constructor to use when message contents are not yet known */
NTLMMessage() { NTLMMessage() {
@ -1862,7 +1862,7 @@ final class NTLMEngineImpl implements NTLMEngine {
int B = 0xefcdab89; int B = 0xefcdab89;
int C = 0x98badcfe; int C = 0x98badcfe;
int D = 0x10325476; int D = 0x10325476;
long count = 0L; long count;
final byte[] dataBuffer = new byte[64]; final byte[] dataBuffer = new byte[64];
MD4() { MD4() {

2
httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/RequestEntityProxy.java
View File

@ -51,7 +51,7 @@ class RequestEntityProxy implements HttpEntity {
} }
private final HttpEntity original; private final HttpEntity original;
private boolean consumed = false; private boolean consumed;
RequestEntityProxy(final HttpEntity original) { RequestEntityProxy(final HttpEntity original) {
super(); super();

4
httpclient5/src/main/java/org/apache/hc/client5/http/impl/io/PoolingHttpClientConnectionManagerBuilder.java
View File

@ -80,8 +80,8 @@ public class PoolingHttpClientConnectionManagerBuilder {
private boolean systemProperties; private boolean systemProperties;
private int maxConnTotal = 0; private int maxConnTotal;
private int maxConnPerRoute = 0; private int maxConnPerRoute;
private TimeValue timeToLive; private TimeValue timeToLive;
private TimeValue validateAfterInactivity; private TimeValue validateAfterInactivity;

4
httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/PoolingAsyncClientConnectionManagerBuilder.java
View File

@ -74,8 +74,8 @@ public class PoolingAsyncClientConnectionManagerBuilder {
private boolean systemProperties; private boolean systemProperties;
private int maxConnTotal = 0; private int maxConnTotal;
private int maxConnPerRoute = 0; private int maxConnPerRoute;
private TimeValue timeToLive; private TimeValue timeToLive;
private TimeValue validateAfterInactivity; private TimeValue validateAfterInactivity;