Apache
/
httpcomponents-client
mirror of https://github.com/apache/httpcomponents-client.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

HTTPCLIENT-1354: do not quote algorithm parameter in DIGEST auth response 

git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1485210 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Oleg Kalnichevski 2013-05-22 13:49:31 +00:00
parent a679b4f4ec
commit 6a58c84b03
2 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
RELEASE_NOTES.txt
View File

@ -1,6 +1,9 @@
Changes since release 4.3 BETA1 Changes since release 4.3 BETA1
------------------- -------------------
* [HTTPCLIENT-1354] do not quote algorithm parameter in DIGEST auth response.
Contributed by Oleg Kalnichevski <olegk at apache.org>
* [HTTPCLIENT-1351] Preserve last request URI in the execution context. * [HTTPCLIENT-1351] Preserve last request URI in the execution context.
Contributed by James Leigh <james at 3roundstones.com> Contributed by James Leigh <james at 3roundstones.com>

6
httpclient/src/main/java/org/apache/http/impl/auth/DigestScheme.java
View File

@ -423,7 +423,9 @@ public class DigestScheme extends RFC2617Scheme {
if (i > 0) { if (i > 0) {
buffer.append(", "); buffer.append(", ");
} }
final boolean noQuotes = "nc".equals(param.getName()) || "qop".equals(param.getName()); final String name = param.getName();
final boolean noQuotes = ("nc".equals(name) || "qop".equals(name)
|| "algorithm".equals(name));
BasicHeaderValueFormatter.INSTANCE.formatNameValuePair(buffer, param, !noQuotes); BasicHeaderValueFormatter.INSTANCE.formatNameValuePair(buffer, param, !noQuotes);
} }
return new BufferedHeader(buffer); return new BufferedHeader(buffer);
@ -476,7 +478,7 @@ public class DigestScheme extends RFC2617Scheme {
@Override @Override
public String toString() { public String toString() {
StringBuilder builder = new StringBuilder(); final StringBuilder builder = new StringBuilder();
builder.append("DIGEST [complete=").append(complete) builder.append("DIGEST [complete=").append(complete)
.append(", nonce=").append(lastNonce) .append(", nonce=").append(lastNonce)
.append(", nc=").append(nounceCount) .append(", nc=").append(nounceCount)