HTTPCLIENT-1859: Encode header name, filename appropriately
This commit is contained in:
parent
dac57c57f6
commit
6d583c7d8c
|
@ -103,11 +103,11 @@ public class FormBodyPartBuilder {
|
|||
if (headerCopy.getField(MIME.CONTENT_DISPOSITION) == null) {
|
||||
final StringBuilder buffer = new StringBuilder();
|
||||
buffer.append("form-data; name=\"");
|
||||
buffer.append(this.name);
|
||||
buffer.append(encodeForHeader(this.name));
|
||||
buffer.append("\"");
|
||||
if (this.body.getFilename() != null) {
|
||||
buffer.append("; filename=\"");
|
||||
buffer.append(this.body.getFilename());
|
||||
buffer.append(encodeForHeader(this.body.getFilename()));
|
||||
buffer.append("\"");
|
||||
}
|
||||
headerCopy.addField(new MinimalField(MIME.CONTENT_DISPOSITION, buffer.toString()));
|
||||
|
@ -138,4 +138,19 @@ public class FormBodyPartBuilder {
|
|||
return new FormBodyPart(this.name, this.body, headerCopy);
|
||||
}
|
||||
|
||||
private static String encodeForHeader(final String headerName) {
|
||||
if (headerName == null) {
|
||||
return null;
|
||||
}
|
||||
final StringBuilder sb = new StringBuilder();
|
||||
for (int i = 0; i < headerName.length(); i++) {
|
||||
final char x = headerName.charAt(i);
|
||||
if (x == '"' || x == '\\' || x == '\r') {
|
||||
sb.append("\\");
|
||||
}
|
||||
sb.append(x);
|
||||
}
|
||||
return sb.toString();
|
||||
}
|
||||
|
||||
}
|
||||
|
|
|
@ -27,12 +27,14 @@
|
|||
|
||||
package org.apache.http.entity.mime;
|
||||
|
||||
import java.io.ByteArrayInputStream;
|
||||
import java.io.File;
|
||||
import java.util.Arrays;
|
||||
import java.util.List;
|
||||
|
||||
import org.apache.http.entity.ContentType;
|
||||
import org.apache.http.entity.mime.content.FileBody;
|
||||
import org.apache.http.entity.mime.content.InputStreamBody;
|
||||
import org.apache.http.entity.mime.content.StringBody;
|
||||
import org.junit.Assert;
|
||||
import org.junit.Test;
|
||||
|
@ -58,6 +60,29 @@ public class TestFormBodyPartBuilder {
|
|||
header.getFields());
|
||||
}
|
||||
|
||||
@Test
|
||||
public void testCharacterStuffing() throws Exception {
|
||||
final FormBodyPartBuilder builder = FormBodyPartBuilder.create();
|
||||
final InputStreamBody fileBody = new InputStreamBody(new ByteArrayInputStream(
|
||||
"hello world".getBytes("UTF-8")), "stuff_with \"quotes\" and \\slashes\\.bin");
|
||||
final FormBodyPart bodyPart2 = builder
|
||||
.setName("yada_with \"quotes\" and \\slashes\\")
|
||||
.setBody(fileBody)
|
||||
.build();
|
||||
|
||||
Assert.assertNotNull(bodyPart2);
|
||||
Assert.assertEquals("yada_with \"quotes\" and \\slashes\\", bodyPart2.getName());
|
||||
Assert.assertEquals(fileBody, bodyPart2.getBody());
|
||||
final Header header2 = bodyPart2.getHeader();
|
||||
Assert.assertNotNull(header2);
|
||||
assertFields(Arrays.asList(
|
||||
new MinimalField("Content-Disposition", "form-data; name=\"yada_with \\\"quotes\\\" " +
|
||||
"and \\\\slashes\\\\\"; filename=\"stuff_with \\\"quotes\\\" and \\\\slashes\\\\.bin\""),
|
||||
new MinimalField("Content-Type", "application/octet-stream"),
|
||||
new MinimalField("Content-Transfer-Encoding", "binary")),
|
||||
header2.getFields());
|
||||
}
|
||||
|
||||
@Test
|
||||
public void testBuildBodyPartMultipleBuilds() throws Exception {
|
||||
final StringBody stringBody = new StringBody("stuff", ContentType.TEXT_PLAIN);
|
||||
|
|
Loading…
Reference in New Issue