Apache/httpcomponents-client
1
0
Fork 0
mirror of https://github.com/apache/httpcomponents-client.git synced 2025-02-16 23:16:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

Minor performance optimization: do not consume content of an intermediate response if the underlying connection is not re-usable

Browse Source 
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1511652 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Oleg Kalnichevski 2013-08-08 09:39:19 +00:00
parent 4db8167981
commit 78295c169a
2 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
httpclient/src/main/java/org/apache/http/impl/execchain/MainClientExec.java
View File

@ -271,10 +271,8 @@ public CloseableHttpResponse execute(
targetAuthState, proxyAuthState, route, request, response, context)) {
// Make sure the response body is fully consumed, if present
final HttpEntity entity = response.getEntity();
EntityUtils.consume(entity);
if (connHolder.isReusable()) {
// TODO consume response body on if connection is re-usable
// (requires post 4.3-beta2 bug fix in HttpCore)
EntityUtils.consume(entity);
} else {
managedConn.close();
if (proxyAuthState.getState() == AuthProtocolState.SUCCESS

1
httpclient/src/test/java/org/apache/http/impl/execchain/TestMainClientExec.java
View File

@ -528,7 +528,6 @@ public void testExecEntityEnclosingRequestRetryOnAuthChallenge() throws Exceptio
final CloseableHttpResponse finalResponse = mainClientExec.execute(
route, request, context, execAware);
Mockito.verify(requestExecutor, Mockito.times(2)).execute(request, managedConn, context);
Mockito.verify(instream1).close();
Mockito.verify(managedConn).close();
Mockito.verify(instream2, Mockito.never()).close();