Apache
/
httpcomponents-client
mirror of https://github.com/apache/httpcomponents-client.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

HTTPCLIENT-1031 Cannot clone BasicClientCookie2 without specified ports 

git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1043664 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Sebastian Bazley 2010-12-08 20:37:53 +00:00
parent 6e306aa4fd
commit 9475e26293
2 changed files with 18 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
httpclient/src/main/java/org/apache/http/impl/cookie/BasicClientCookie2.java
View File

@ -93,7 +93,9 @@ public class BasicClientCookie2 extends BasicClientCookie implements SetCookie2,
@Override @Override
public Object clone() throws CloneNotSupportedException { public Object clone() throws CloneNotSupportedException {
BasicClientCookie2 clone = (BasicClientCookie2) super.clone(); BasicClientCookie2 clone = (BasicClientCookie2) super.clone();
clone.ports = this.ports.clone(); if (this.ports != null) {
clone.ports = this.ports.clone();
}
return clone; return clone;
} }

15
httpclient/src/test/java/org/apache/http/impl/cookie/TestBasicClientCookie2.java
View File

@ -71,6 +71,21 @@ public class TestBasicClientCookie2 {
Assert.assertEquals(orig.getPorts()[1], clone.getPorts()[1]); Assert.assertEquals(orig.getPorts()[1], clone.getPorts()[1]);
} }
@Test
public void testHTTPCLIENT_1031() throws Exception {
BasicClientCookie2 orig = new BasicClientCookie2("name", "value");
orig.setDomain("domain");
orig.setPath("/");
orig.setAttribute("attrib", "stuff");
BasicClientCookie2 clone = (BasicClientCookie2) orig.clone();
Assert.assertEquals(orig.getName(), clone.getName());
Assert.assertEquals(orig.getValue(), clone.getValue());
Assert.assertEquals(orig.getDomain(), clone.getDomain());
Assert.assertEquals(orig.getPath(), clone.getPath());
Assert.assertEquals(orig.getAttribute("attrib"), clone.getAttribute("attrib"));
Assert.assertNull(clone.getPorts());
}
@Test @Test
public void testSerialization() throws Exception { public void testSerialization() throws Exception {
BasicClientCookie2 orig = new BasicClientCookie2("name", "value"); BasicClientCookie2 orig = new BasicClientCookie2("name", "value");